Activity
From 11/03/2017 to 11/09/2017
11/09/2017
-
11:08 PM Revision 324b6d30 (git): iseq.c: operand lvar
- * iseq.c (rb_insn_operand_intern): show local variable operand
name in unified instructions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60732 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60731 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:24 PM Feature #10903: [PATCH] Matrix#zip returns a matrix
- Wow, time flies. Sorry for not addressing this earlier.
I have some commits ready to address this: https://github.com/ruby/ruby/pull/1746
Naming: The issue I have with `zip` is not really the potential incompatibility, but that the... - 10:05 PM Revision 3527c863 (git): lib/matrix: Remove method catalog [doc] [ci-skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60730 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:04 PM Revision 6e3126d3 (git): * 2017-11-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60729 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:04 PM Revision a5abde57 (git): TracePoint.new: raise ArgumentError when no block given [#14074]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60728 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:29 PM Bug #14095: erb ignores attempt to set encoding
- Expected output was
$ erb -U
<%= "a".encoding %>
^D
UTF-8
Ruby works that way without setting anything
$ ruby
puts "a".encoding
^D
UTF-8
Why doesn't .erb have the same default?
-
- Erb seems to ignore any attempt to set encoding:
$ erb -U
<%= "a".encoding %>
^D
ASCII-8BIT
I've tried multiple ways to do this but I just can't convice it that the .erb file is in UTF-8. It insists on ASCII-8BIT. -
07:10 PM Bug #10630: ERB tags nested in escaped blocks are skipped
- Thanks!
I've reported it to Erubis a while back (https://github.com/kwatch/erubis/issues/6), but since that project is stale, I've reported it to Erubi as well (https://github.com/jeremyevans/erubi/issues/11). -
04:49 PM Bug #14078: Test Failure - OpenSSL::TestSSLSession#test_ctx_server_session_cb - with OpenSSL 1.1.0g
- I've tried to repro this locally and on Appveyor.
Running the test twenty times, using runner.rb, both parallel and not, no failures, see https://ci.appveyor.com/project/MSP-Greg/testing-appveyor/build/4
Locally, I can't repro with... -
04:46 PM Bug #14094 (Closed): IRB does not obey frame-level visibility modifiers
- I noticed the following today; IRB does not appear to obey the frame-local visibility modifiers like public and private:
```
$ irb
:here
irb(main):001:0> private
=> Object
irb(main):002:0> def foo; end; self.class.public_instance... -
11:50 AM Bug #14076: Installing Ruby 2.3.1 - Ubuntu 17.10
- The problem stems from default gcc version (it's 7) used on Ubuntu 17.10.
Installing gcc-6 and running the install via
`CC=/usr/bin/gcc-6 rbenv install 2.3.1`
should help.
I leave the note for someone passing thru this issue with t... -
11:35 AM Feature #11955: Expose Object that Receives logs in Logger
- So will **#logdev** will be exposed in Logger or Logger::LogDevice?
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60727 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:57 AM Revision 1c5ae5a1 (git): insn_info/insns_info
- * iseq.h (iseq_line_info_entry): rename to iseq_insn_info_entry.
* vm_core.h (rb_iseq_constant_body): rename field name line_info_table
to insns_info and also from line_info_size to insns_info_size.
* compile.c (INSN): add struct ins... -
- * vm_backtrace.c (rb_backtrace_use_iseq_first_lineno_for_last_location):
added. It modifies last location's line as corresponding iseq's first line
number.
* vm_args.c (raise_argument_error): use added function.
git-svn-id: svn+ss... -
- * compile.c (iseq_peephole_optimize): do not need to put `pop`
instruction.
* test/ruby/test_optimization.rb (test_peephole_optimization_without_trace):
This code "def foo; 1.times{|(a), &b| nil && a}; end" fails to compile
by sta... -
01:50 AM Revision 2b60e342 (git): node.c (dump_node): add an explanation of NODE_HASH's nd_alen
- The field has a flag to represent if it is a keyword argument (that has
no braces, e.g., `foo(k:1)`) or hash literal (that has braces, e.g.,
`foo({k:1})`).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60723 b2dd03c8-39d4-4d8f-98ff-... -
- `rb_ast_dispose` calls `rb_gc_writebarrier_remember`. Unless we call
it, the marked objects may not be GC'ed until `rb_ast_t` is GC'ed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60722 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:42 AM Revision 3ba9e6b6 (git): Merge rubygems-2.7.2.
- This version fixes some setup commands.
https://github.com/rubygems/rubygems/blob/01e797f6aa045fd09df7813d0b5448e3667172a9/History.txt#L3
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60721 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/08/2017
-
- * parse.y (rb_strterm_heredoc_t): should not define sourceline as
union, to fix wrong read on big-endian platforms.
as rb_imemo_new stores all members as VALUEs, should read it as
VALUE too.
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
08:03 PM Bug #14093 (Rejected): REXML doesn't implement name() and interprets nam() as an element path.
- Please see the attached script.
Considering this xml:
```xml
<a><b><name/></b></a>
```
The xpath `/a/b/name()` xpath should return the name of element `a`. Instead it returns the child element `name`.
Output:
```xml
<na... -
06:47 PM Feature #14092: Add extension key argument to Tempfile
- It may be best to just publish your suggestion/PR anyway. I may be wrong but
the ruby core team and matz appear to be quite busy currently - see the queue of
other suggestions and changes. Perhaps they will do some "batch-discussions" ... -
11:46 AM Feature #14092 (Open): Add extension key argument to Tempfile
- I don't work with Tempfile often, but every time I do, I get surprised by an obscure way to pass an extension to file name.
You have to pass array, where first element is a file name and a second is a file extension *(starting with a do... - 04:43 PM Revision b8878481 (git): * 2017-11-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60719 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:43 PM Revision d3b63f95 (git): Fix typo in doc [ci skip]
- `enable` and `disable` are instance methods.
Patch by: yuuji.yaginuma <yuuji.yaginuma@gmail.com>
https://github.com/ruby/ruby/pull/1744
[Fix GH-1744]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60718 b2dd03c8-39d4-4d8f-98ff-823f... -
02:14 PM Revision fb5bc568 (git): fixup r60440 [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60717 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:09 PM Bug #10630 (Third Party's Issue): ERB tags nested in escaped blocks are skipped
- > ERB (Erubis)
ERB and Erubis are totally different things.
~~~ ruby
$ irb -rerb -rerubis -rerubi
irb(main):001:0> RUBY_VERSION
=> "2.5.0"
irb(main):002:0> erb = "<div><%%= Results: <%= 'first' %> | <%= 'second' %> | <%= 'thir... -
- It seems an Erubis specific bug.
ERB hasn't had that issue.
-
11:40 AM Bug #14085: many redefinition warnings on test/win32ole/test_word.rb
- 実害ないのなら、revertまではしなくていいんじゃないかと思います。
2.5.0のリリースまでに対策するということで。 -
11:30 AM Bug #14085: many redefinition warnings on test/win32ole/test_word.rb
- #13984 で入れたんですけど、一旦、戻しましょうか。
WIN32OLEから定数を取得するときに、Wordサーバから複数回、同じ定数を返されるので、そうなるんですよね。
warningの対策は別で考えるとして。 -
- * parse.y (parser_params): removed in_single, which is referenced
with in_def always.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60716 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:57 AM Revision b0c719da (git): Fix typos in rdoc
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60715 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:03 AM Revision a6f372d1 (git): Omit first argument of NEW_CASE2
- * node.h (NEW_CASE2): Omit first argument of NEW_CASE2,
bacause the first argument of NEW_CASE2 is always 0.
* parse.y: Ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60714 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/07/2017
-
08:17 PM Revision 6f33cde6 (git): hash.c: improve docs for Hash#slice
- * hash.c: [DOC] clarify description for Hash#slice and remove
a sentence that might suggest that the receiver is modified;
improve example to also include a case where a hash with
several elements is returned.
git-svn-id: svn+ssh:... -
- * string.c: [DOC] remove a misleading call-seq for String#concat,
which suggests that all arguments must be Integers in this case;
also clarify in the example that the receiver is modified;
fix grammar for String#<<; move reference... -
- * ext/pathname/pathname.c: [DOC] improve example for Pathname.glob,
by using a more common glob pattern, and improve the reference
to the `base' keyword argument for Pathname#glob.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6... -
- * lib/net/http.rb: [DOC] fix typos and grammar
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60710 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/socket/socket.c: [DOC] fix grammar in deprecation notices.
* ext/socket/tcpsocket.c: [DOC] ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60709 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60708 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * string.c: [DOC] fix typos in doxygen comments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60707 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * file.c: [DOC] fix grammar in docs for File#path
and use a stronger description than "inaccurate".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60706 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60705 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/etc/etc.c: [DOC] small language fixes for etc_sysconfdir docs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60704 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60703 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60702 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:04 PM Revision ea26e72a (git): * 2017-11-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60701 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * doc/syntax/refinements.rdoc: [DOC] fix typos and grammar
and remove superfluous "for the first time".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60700 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Interesting.
If this is true, perhaps ruby core forgot about it.
I had a look at the current docu for Time:
https://ruby-doc.org/core/Time.html
https://ruby-doc.org/core-2.4.2/Time.html#method-i-succ
The documentation re... -
02:50 PM Feature #14091 (Closed): Remove Time#succ
- The method Time#succ was marked as obsolete in Ruby 1.9.3 and whilst it remains Rails has to patch Range#each and Range#step to prevent logs from being filled with the deprecation messages (see https://github.com/rails/rails/pull/11474)....
-
- Reopening, since there is movement on the ERB front in the upcoming v2.5.0.
-
- * test/ruby/test_io.rb (test_write_no_garbage): malloc can cause GC
and it will reduce string object counts. So disable GC during this test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60699 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60698 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_args.c: `th` parameter is not used on the following functions:
* args_check_block_arg0
* keyword_hash_p
* args_pop_keyword_hash
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60697 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:20 AM Feature #14044: Introduce a new attribute `step` in Range
- I want this feature for specifying a sliced view of a multi-dimensional array.
In Python, it can be represented by using slice notation or a slice object:
```python
>>> ary = numpy.arange(0, 36).reshape((6, 6))
> ...
array([[ 0, 1... -
- * vm.c (ruby_th_dtrace_setup): rename to rb_dtrace_setup()
and accept `ec`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60696 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60695 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- `TestGc#test_interrupt_in_finalizer` fails very rarely, only once every handred or thousand runs.
~~~
# Running tests:
[1/1] TestGc#test_interrupt_in_finalizer = 10.13 s
1) Error:
TestGc#test_interrupt_in_finalizer:
Timeout::... -
- Under uncertain condition, `rb_thread_terminate_all` gets stuck. `make
test-all TESTOPTS="test/ruby/test_gc.rb -n test_interrupt_in_finalizer`
fails very rarely (only once every thousand runs). This IS a bug, but
seems difficult to fix... -
- * vm_insnhelper.c (vm_once_dispatch): accepts `ec`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60693 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * eval.c (rb_threadptr_setup_exception): renamed to rb_ec_setup_exception().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60692 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_core.h: fix prefix `ruby_` to `rb_` for the following functions.
* ruby_current_execution_context
* ruby_current_thread
* ruby_current_vm
* ruby_vm_check_ints
* ruby_exec_event_hook_orig
git-svn-id: svn+ssh://ci.ruby-lan... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60690 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * load.c (rb_load_internal0): accepts `ec`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60689 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60688 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60687 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60686 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:28 AM Revision f477851b (git): Add details on the min/time parameters to the rdoc
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60685 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- rb_ec_raised_*.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60684 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread.c (rb_threadptr_set_raised): rename to rb_ec_set_raised
and accepts `ec`
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60683 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60682 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60681 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60680 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_core.h (rb_thread_t): move method_missing_reason to
rb_execution_context_t.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60679 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_trace.c (rb_postponed_job_t): remove `th` field because it is not used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60678 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60677 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * thread.c (rb_threadptr_reset_raised): rename to `rb_ec_reset_raised`
and accepts `ec`.
* vm_trace.c: the following functions accept `ec` instead of `th`
* exec_hooks_body
* exec_hooks_precheck
* exec_hooks_unprotected
* exec... - 03:41 AM Revision aa07918c (git): * 2017-11-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60675 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_trace.c (rb_threadptr_exec_event_hooks_orig): prepare local variables
`th` and `vm` instead of using rb_ec_... functions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60674 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:20 AM Feature #14079: Validate argument list without calling method
- I've removed the `String#prepend` example from the description. Thanks for catching that, Benoit and Hans.
I agree with Benoit that an instance method on `Method`/`UnboundMethod` would be better than my `respond_to_arguments?` method....
11/06/2017
-
11:15 PM Bug #14089 (Closed): Configure/build issue on OSX 10.12 w/ utimensat
- For other reasons I recently installed xcode (instead of JUST using the command line developer tools). This caused builds on ruby to break.
The symptom happens when rdoc tries to build the doco:
~~~
dyld: lazy symbol binding fail... -
- Is it time to revisit [svn 34739](https://github.com/ruby/ruby/commit/b67bc8d722e9351b34e68ac77d397aead29961cc#diff-b9dd4c7779e6e659753c9eea9c365135), at lease in terms of the changes to Date tests?
See https://github.com/ruby/ruby/pu... -
03:28 PM Feature #14084: Introduce Enumerator#next?
- edited the code example to be a little more readable as to michael's suggestion (https://twitter.com/__michaelg/status/927541360764342272)
-
- I guess we have to wait how matz feels about it, that is, .next? in
this context. I personally have no problem with it - I wanted to
say something to this, though:
> I am aware that we can currently figure out if there is a next
>... -
- I'd like to propose a new method for Enumerator which returns whether there will be a next value in the enumerator when calling `Enumerator#next`.
It should work like this ruby demo:
~~~ ruby
class Enumerator
def next?
pee... -
02:56 PM Bug #14087 (Third Party's Issue): Program Crash when using openssl
- The interpreter crashed when I assign a DH public key to X509::Certificate using gem openssl.
And I have attached a demo for this problem. -
-
10:57 AM Bug #14086: Interpreter seems to sneak in a nil value when a comma is missing on a nested array wrapped in parenthesis
- > is this the expected behaviour?
Yes.
Try this:
```ruby
[2, 2][3, 3] # => nil
```
Why?
Because it is read as "Array of `[2,2]`, call operator [] with arguments `3, 3` (which means fetch 3 elements starting from 3rd)". As th... -
10:51 AM Bug #14086 (Rejected): Interpreter seems to sneak in a nil value when a comma is missing on a nested array wrapped in parenthesis
- I believe the title is self explanatory. But code is always louder than words:
~~~ ruby
$ ruby --version
ruby 2.2.4p230 (2015-12-16 revision 53155) [x86_64-darwin16]
$ irb
2.2.4 :001 > ([[2,2], [3,3], [4,4], [5,5], [6,6]])
=> [[... -
10:23 AM Feature #14079: Validate argument list without calling method
- String#prepend might be a bad example because in your cases it doesn't raise an ArgumentError anymore
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60673 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- to rb_execution_context_t.
* vm_core.h (rb_thread_t): move
`rb_thread_t::interrupt_flag` and
`rb_thread_t::interrupt_mask` to rb_execution_context_t.
RUBY_VM_CHECK_INTS() accepts `ec` instead of `th`.
* cont.c (rb_fiber_terminat... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60671 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_core.h (rb_execution_context_t): renmae ec::fiber to
ec::fiber_ptr make consistent with ec::thread_ptr.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60670 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- win32oleのテストで、以下のような警告が出ます。
警告が出るのは `WIN32OLE.const_load(w, Word)` というコードですが、
該当コードが複数回呼ばれているわけではなくて、これを1回呼ぶだけで、
定数の再定義が何度も行われてしまうようです。
実害はないような気もしますが、できれば出ないようにできないでしょうか？
D:/Users/usa/ruby/test/win32ole/test_word.rb:22: warni... -
- * Fix `gem update --system` with RubyGems 2.7+.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60669 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/05/2017
-
- * enum.c (enum_cycle_size): check an argument before the size of
the receiver, if it is given.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60668 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60667 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r60666.
----------
Fix size on Enumerable#cycle when the size is 0 [Bug #14082].
Patch by Kenichi Kamiya -
- Good catch, great patch :-)
-
05:05 PM Bug #14082 (Closed): Enumerator#size from Enumerable#cycle returns 0 when the object is empty
- github: https://github.com/ruby/ruby/pull/1742
Is this an intentional behavior?
```ruby
p([].cycle.size) #=> 0
p({}.cycle.size) #=> Infinity
```
Array#cycle already special handled empty arrays. So similar behavior in Enumer... - 10:14 PM Revision dcb8a22f (git): Fix size on Enumerable#cycle when the size is 0 [Bug #14082].
- Patch by Kenichi Kamiya
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60666 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/ripper/lib/ripper/lexer.rb (Ripper::Lexer::State): wrapper
of lex_state values.
* parse.y (rb_parser_lex_state_name): return shared strings. lex
state combinations are very restricted.
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60664 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:36 PM Bug #14083 (Rejected): Refinement in block calling incorrect method
- Tested on ruby versions 2.3.4 and 2.4.1
When a refinement is used inside a block, the scope of the refinement is not ending when the block has ended. The following example illustrates the issue:
Example:
~~~ ruby
class Example
... - 03:10 PM Revision 0523a420 (git): * 2017-11-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60663 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Runing -> Running
Author: TomoyukiNakagawa <nakagawa.tomoyuki@gmail.com>
[Fix GH-1741] [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60662 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Hmm the above is a bit long and not easy to read ... I also put it
on a gist at github in raw format style at:
https://gist.githubusercontent.com/shevegen/512e204147d9c437e5cb16853c39e985/raw/43eb2a51b66e5569293cd2e1598b08c3bad9d486/... -
- Hello Ruby core team and everyone else,
I am not sure if this was already reported or not, but I will
report it now, just to be safe.
I have a self-compiled ruby, from the URL:
ftp://ftp.ruby-lang.org/pub/ruby/2.4/ruby-2.4.2.... -
05:12 AM Bug #14080 (Closed): Performance issue with Marshal.dump and Array of Floats - 100x regression in 2.3.x
- I am using Marshal.dump on array of Floats with Ruby 2.3.3 (same issue in 2.3.5). In our program with an Array size of 1M it seems to hang indefinitely. I take it down to 100K Floats and it takes about 10 seconds. My sample program lo...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60661 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- r60655 changed the usage of bison by defining a customized YYLTYPE,
which seemed to cause a random stall at rb_thread_terminate_all.
Kazuki Tsujimoto investigated the issue and pointed out the commit that
caused it. Thanks!
git-svn-id... -
- test/win32ole/test_win32ole.rb: add test for WIN32OLE#methods
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60659 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60658 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/win32ole/win32ole_error.h: ditto.
* ext/win32ole/win32ole.c(typeinfo_from_ole): raise WIN32OLEQueryInterfaceError in ole_methods.
* ext/win32ole/win32ole_method.c(ole_methods_from_typeinfo): ditto.
M ext/win32ole/win32ole.c
M ...
11/04/2017
-
- Oops, I think my description was somewhat misleading. I don't expect `respond_to_arguments?` to check for lines in the method body that might raise an `ArgumentError`. I expect it to check only whether the provided list of arguments matc...
-
- Hmm. Benoit, I may have misunderstood him but I think he was not
asking for argument checks per se, but instead being able to
know whether a method will respond with an ArgumentError or
possibly other errors beforehand (such as befor... -
06:38 PM Feature #14079: Validate argument list without calling method
- Maybe this could be some method like `check_arity` or so on a Method/UnboundMethod instance.
There is already `Method#arity` but this is limited information.
Maybe it is possible to check manually with `Method#parameters`, could you ... -
- I would find it useful to check whether a list of arguments matches a method signature, but without calling the method.
I'd like to check the arguments list using a method called, for example, `respond_to_arguments?`. Here's an exampl... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60656 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- rb_code_range_t has two t_code_location_t, i.e., the first and last
locations.
This is used for YYLTYPE, tracked locations of bison, and will be also
used for representing the "range", the first and the last locations of
each NODE. Cur... -
- * parse.y (rb_strterm_mark): do not define in ripper to get rid of
duplicate symbol with static-linked-ext.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60654 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:22 PM Revision 7d586cae (git): * 2017-11-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60653 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- `rb_code_location_t` has two integers, lineno and column, which point to
one location on a code. Now `rb_code_location_t` is used instead of
`VALUE nd_location`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60652 b2dd03c8-39d4-4d8... -
- * gc.c (UNEXPECTED_NODE): extract rb_bug for T_NODE.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60651 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This magic number has two meanings depending upon the context:
* "required keyword argument (no name)" on NODE_LASGN (`def foo(x:)`)
* "rest argument (no name)" on NODE_MASGN and NODE_POSTARG
('a, b, * = ary` or `a, b, *, z = ary`)
T... -
- * compile.c (setup_args): In this function,
an argument of nd_line is argn except this line.
And argn is a pointer of NODE. So I think this
is a typo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60649 b2dd03c8-39d4-4d8f-98ff... -
- The fields of imemo_alloc were accessed via RNODE() cast, since the
imemo was NODE_ALLOCA traditionally. This was refactored at r60239,
so now the fields should be accessed as imemo_alloc. This prevented
change of NODE structure.
Yuic... -
- `new_args_tail_gen` returned imemo, but the value was later accessed as
`NODE*`. This prevented change of NODE structure.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60647 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > where a square bracket indicates boundary inclusion and a parenthesis
> ...
I do not like the suggestion but I hope you are not too discouraged.
The reason is ... actually a weird one. I have fairly bad eyesight,
and I'd appreciat... -
- I saw this test failed once. There is no problem if `before > after`
but we cannot check it. To allow diagnosis in future, the detailed
message is added.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60646 b2dd03c8-39d4-4d8f-98ff-... -
- * parse.y (rb_discard_node_gen): rb_discard_node() is not used in
ripper right now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60645 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parser_set_line): removed no longer used function.
* parse.y (rb_strterm_heredoc_t): adjust type of sourceline to
ruby_sourceline.
* parse.y (rb_strterm_t): get rid of redefinition.
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
- Now, casting NODE to VALUE is not recommended. This change requires an
explicit cast from VALUE to NODE to use the NODE utility functions such
as `nd_type`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60643 b2dd03c8-39d4-4d8f-98f... -
- Per ko1's request.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60642 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60641 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60640 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This is a follow-up of r60488. Not only the Ruby parser but also Ripper
now use NODE buffer instead of NODE objects managed by GC.
Now we can change the struct of NODEs so that it can keep detailed
location information, perhaps (not tr... -
- Kazuki,
> Are you sure the DLLs used at runtime are from OpenSSL 1.1.0g?
Yes. MSYS2/MinGW only allows one package to be installed at once, so Appveyor can't have two available for the build. Also, downloading the build from [App... -
06:55 AM Bug #14078 (Feedback): Test Failure - OpenSSL::TestSSLSession#test_ctx_server_session_cb - with OpenSSL 1.1.0g
- I don't reproduce. Are you sure the DLLs used at runtime are from OpenSSL 1.1.0g?
-
- The most recent ruby-loco MinGW build (using OpenSSL 1.1.0g) failed with the following failure. It was the only failure/error in the build.
```
Retrying...
[1/9] OpenSSL::TestSSLSession#test_ctx_client_session_cb = 0.10 s
[2/9] Op... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60638 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Retry r60634
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60637 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:56 AM Bug #14039 (Closed): MinGW - OpenSSL::TestSSL#test_max_version & #test_min_version, TestNetHTTPS#test_max_version - Applied in changeset trunk|r60636.
----------
openssl: pull test case from upstream commit 62af0446569a
The test case added by r60310 ("fix OpenSSL::SSL::SSLContext#min_version
doesn't work", 2017-10-21) does not pass with OpenSSL >= 1... -
- The one from net/http tests is fixed by r60380.
-
- The test case added by r60310 ("fix OpenSSL::SSL::SSLContext#min_version
doesn't work", 2017-10-21) does not pass with OpenSSL >= 1.1.0 or
LibreSSL >= 2.6.0. Check that the default 'min_version' value is
properly enforced by actually att... -
- Due to build failure on mswin and mingw.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60635 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Just refactoring.
NODE_STRTERM and NODE_HEREDOC are not an internal node of AST, but a
temporary storage for managing termination of string literals and
heredocs. Instead of NODE abuse, I want to use imemo for the storage
in order to a... - 01:48 AM Revision 6916254a (git): * 2017-11-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60633 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * spec/ruby/library/pathname/empty_spec.rb: load spec_helper from
relative path to `__FILE__` same as other spec files, instead of
`__dir__` in which symlinks are resolved, to get rid of constant
redefinition warning when `srcdir` ... -
01:09 AM Feature #13901: Add branch coverage
- marcandre (Marc-Andre Lafortune) wrote:
> mame (Yusuke Endoh) wrote:
> ...
To add a little bit to the discussion: The only information that you lose when an asynchronous interrupt like Thread.raise happens are the details on which ones... -
- mame (Yusuke Endoh) wrote:
> I see... It is a very interesting approach, but it seems to completely ignore asynchronous interrupt, such as signal and `Thread#raise`. I wonder if it is not a good design decision for the embedded covera...
11/03/2017
-
- marcandre (Marc-Andre Lafortune) wrote:
> mame (Yusuke Endoh) wrote:
> ...
The parser gem produces a good work.
> > I had no thought of counting trivial evaluation such as a literal, but if your pure-Ruby approach does not cause per... -
- mame (Yusuke Endoh) wrote:
> `obj.foo.foo` has two NODE_CALLs. It is difficult to distinguish them by only the beginning, unless we have other information about the node in question. Honestly, I'm unsure if we can distinguish all rele... -
- marcandre (Marc-Andre Lafortune) wrote:
> I imagine you are planning on covering `||`, `&&`, `&.` and `? :`, right?
`? :` has been already supported. Yuichiro has experimentally implemented `&.` coverage. I think we should support... -
- mame (Yusuke Endoh) wrote:
> What do you think about the format of `Coverage.result`?
Having a character position is a big improvement on just a line #, that's for sure. It makes it possible to pinpoint exactly what we're talking abo... -
- While looking for a solution to the 'tests' variance, as mentioned above, there were test classes that were missing, especially when running with `-j`. Also, these missing classes varied from build to build.
I then noticed that the s... -
09:31 PM Feature #14077: Add Encoding::FILESYSTEM and Encoding::LOCALE constants
- On Fri, 2017-11-03 at 18:34 +0000, shevegen@gmail.com wrote:
> Issue #14077 has been updated by shevegen (Robert A. Heiler).
> I am in agreement with the feature-suggestion. Not sure whether
> it should be a constant or a method or b... -
09:00 PM Feature #14077: Add Encoding::FILESYSTEM and Encoding::LOCALE constants
- shevegen (Robert A. Heiler) wrote:
> > Even changing the $LANG environment variable within the Ruby
> ...
Sorry if I wasn't clear. Both of these encoding values are dependent on the system locale at the time the process is started. T... -
- I am in agreement with the feature-suggestion. Not sure whether
it should be a constant or a method or both but I agree that it
may be useful to have direct support for this in ruby.
> Even changing the $LANG environment variable wi... -
- On Fri, 2017-11-03 at 16:35 +0000, ruby@kevin.nirvdrum.com wrote:
> Issue #14077 has been reported by nirvdrum (Kevin Menard).
> Feature #14077: Add Encoding::FILESYSTEM and Encoding::LOCALE
> constants
> https://bugs.ruby-lang.org/... -
- The `Encoding` class has constants defined for all of the standard encodings, but does not have constants defined for some of the special encodings. In particular, the "filesystem" and "locale" encodings do not have a corresponding `Enco...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60631 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- well with did_you_mean gem.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60630 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60629 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * node.c (rb_node_buffer_new): Use offsetof for
node_buffer_t size calculation.
* node.c (rb_ast_newnode): Use offsetof for
node_buffer_elem_t size calculation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60628 b2dd03c8-39d4-4... -
- * node.h: NODE_FL_CREF_PUSHED_BY_EVAL was defined as
NODE_FL_NEWLINE by r25984, redefined by r40703
and removed by r49897.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60627 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:47 AM Bug #13181: Unexpected line in rescue backtrace
- ruby_2_4 r60626 merged revision(s) 58499,58500.
-
- parse.y: fix line in rescue
* parse.y (set_line_body, primary): fix line number of bodystmt as
the beginning of the block. [ruby-core:79388] [Bug #13181]
parse.y: set_line_body is not used in ripper
git-svn-... -
-
- dgames (Dax Games) wrote:
> I'm sorry I do not understand. Maybe I wasn't clear, Node is doing EXACTLY what you say Ruby should do and works where Ruby fails when it does EXACTLY what you say it should do.
What is sent by NodeJS in ... -
- This failure has been hidden by the bug of assert_raise which is
fixed at r60614.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60625 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- 2.3.1 is outdated.