Activity
From 09/16/2017 to 09/22/2017
09/22/2017
-
06:31 PM Bug #13921: buffered read_nonblock doesn't work as expected using SSLSocket
- chucke (Tiago Cardoso) wrote:
> I have something similar to the following code that handles both tcp as well as ssl sockets. The idea is to use the #read_nonblock API which uses a buffer when passed in the argument (instead of creating ... -
05:14 PM Bug #13736 (Feedback): ruby -00 should be the same as setting $/=""
- Try:
$ printf "1\n1b\n\n\n\n\n2\n2b\n\n3\3b" | ruby -00 -F"\n" -lane 'END{p $.}'
4
vs
$ printf "1\n1b\n\n\n\n\n2\n2b\n\n3\3b" | ruby -F"\n" -lane 'BEGIN{$/=""}; END{p $.}'
3
vs
$ printf "1\n1b\... -
- This does not seem to be corrected on ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-darwin16]
Exactly the same results as before. -
02:31 PM Bug #13930 (Closed): Exception is caught in rescue above ensure
- Given the following code:
~~~ ruby
def foo
i = 0
3.times do |n|
begin
puts "a"
i += 1
next if i > 1
puts "b"
rescue => e
puts "rescue in foo, caught #{e}"
ensure
puts "en... -
02:28 PM Bug #13757: TestBacktrace#test_caller_lev segaults on PPC
- normalperson (Eric Wong) wrote:
> v.ondruch@tiscali.cz wrote:
> ...
I passes with 262144 but fails with 131072. Should I try to find some value in between?
-
11:21 AM Revision fb38cfb9 (git): Update trick2013/yhara for Ruby 2.4
- I need to raise LocalJumpError here (for the first "J" of the
output "JUST ANOTHER RUBY HACKER"), but this `return` does
not raise error in Ruby 2.4.
[Fix GH-1703]
Author: Yutaka HARA <yutaka.hara+github@gmail.com>
git-svn-id: svn+s... -
10:18 AM Feature #13927: Integrate module_function as a core language type
- matz (Yukihiro Matsumoto) wrote:
> I admit modules with module_function play different role from ordinary modules, and so do refinements.
> ...
Hi Matz thanks for your reply. I think we would have a reasonably significant gain in makin... -
05:21 AM Feature #13927: Integrate module_function as a core language type
- I admit modules with module_function play different role from ordinary modules, and so do refinements.
I am not sure how much gain we would have by making them their own objects. Adding new syntax, keywords, or concepts may make the lan... -
08:29 AM Bug #13926: Non UTF response headers raise an Argument error since 2.4.2p198
- shevegen (Robert A. Heiler) wrote:
> Can you add a link to Net::HTTPHeader#add_header?
> ...
Apologies, I meant `Net::HTTPHeader#add_field` (https://ruby-doc.org/stdlib-2.4.2/libdoc/net/http/rdoc/Net/HTTPHeader.html#method-i-add_field)... -
04:03 AM Bug #13926: Non UTF response headers raise an Argument error since 2.4.2p198
- Can you add a link to Net::HTTPHeader#add_header?
I was trying to find it but I can not find it at https://ruby-doc.org/stdlib/libdoc/net/http/rdoc/Net/HTTPHeader.html - I do find []= though https://ruby-doc.org/stdlib-2.4.2/libdoc/n... -
05:42 AM Feature #13613: Prefer that require/require_relative/load to tell us permission error if the target file is unreadable
- I tried to write a patch which just adding `strerror(errno)` to error message.
https://github.com/sonots/ruby/commit/4af8960b65aec1c4a82d81431ed812bcebcdf7f8
But, I noticed that it was very fragile.
```
$:.replace([IO::NULL])
r... -
- * numeric.c (rb_num2ll, rb_num2ull, fix_pow): turn repeated
RFLOAT_VALUE calls into local variables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Anon92929 (Anon Ymous) wrote:
> This causes SO MANY ISSUES! Instead of CRASHING, why doesn't it just apply the `.to_s` operator in this case???
What is "this case"? -
- > This causes SO MANY ISSUES!
If you build up a `String` such as:
```ruby
x = 42
y = # String here
```
Then you can use:
```ruby
y = "The answer to everything is #{x}"
```
For global variables this is even shorter, th... -
12:23 AM Bug #13929 (Rejected): TypeError: no implicit conversion of XXXX into string
- This causes SO MANY ISSUES! Instead of CRASHING, why doesn't it just apply the .to_s operator in this case???
-
- Applied in changeset trunk|r59986.
----------
numeric.c: use NUM2DBL
* numeric.c (fix_fdiv_double), bignum.c (rb_big_fdiv_double): use
NUM2DBL on unknown object. RFLOAT_VALUE is only applicable to
T_FLOAT object. [ruby-cor... - 03:05 AM Revision d58ccfee (git): * 2017-09-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * numeric.c (fix_fdiv_double), bignum.c (rb_big_fdiv_double): use
NUM2DBL on unknown object. RFLOAT_VALUE is only appliicable to
T_FLOAT object. [ruby-core:82924] [Bug #13928]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@5998...
09/21/2017
-
10:28 PM Bug #13887: test/ruby/test_io.rb may get stuck with FIBER_USE_NATIVE=0 on Linux
- s.wanabe@gmail.com wrote:
> But I believe it is never correct.
> (`(char*)` cast is ugly, I want change `cont->machine.stack_src` but not `th->machine.stack_start`, ruby should change the behaviour only when `FIBER_USE_NATIVE == 0`, a... -
09:13 PM Bug #13928 (Closed): Calling Integer.fdiv with BigDecimal returns unexpected result
- After upgrading a Rails project from 2.3.1 to 2.4.2 I ran into a number of failing tests. Seems like to behaviour of fdiv and conjuction with bigdecimal is wrong.
### Reproduce by running:
```ruby
irb(main):001:0> require 'bigdecima... -
- Using ruby commercially we have discovered that modules are no longer serving their original intended purpose of mixins. Another usage of the module has been shoehorned by using module_function. We have found that when developers use mod...
-
- When setting headers using `Net::HTTPHeader#add_field` or `Net::HTTPHeader#[]=` in v2.4.2, an `ArgumentError (invalid byte sequence in UTF-8)` is raised.
In 2.4.1, this behaviour didn't exist and it looks like it was introduced in on... -
03:34 PM Bug #13758: TestRubyOptions#test_segv_setproctitle segfaults on AARCH64
- vo.x (Vit Ondruch) wrote:
> it actually takes down the bash instance it is running within. Is this expected?
Yes, Bash interprets the $$ inside the "":
echo "$$"
17490
echo '$$'
$$
-
- naruse (Yui NARUSE) wrote:
> I can't reproduce on ruby -v: ruby 2.5.0dev (2017-09-01 trunk 59707) [aarch64-linux].
> ...
You are using way older components then we do :/ I would blame glibc, binutils or something like that, since it se... -
01:49 PM Bug #13856: MinGW / mswin intermittent failure in test/socket/test_socket.rb
- Shirosaki-san,
'Breakfast build' is finished, passed `test-all`, and the following also passed:
```
ruby runner.rb -I../lib -I. --repeat-count=50 --show-skip socket/test_socket.rb -ntest_closed_read
```
This has been an intermit... -
11:39 AM Bug #13856: MinGW / mswin intermittent failure in test/socket/test_socket.rb
- Shirosaki-san, your patch seems ok.
Could you check in? -
10:36 AM Bug #13856: MinGW / mswin intermittent failure in test/socket/test_socket.rb
- I found that another exception raises while executing rb_exc_raise() in rb_threadptr_execute_interrupts().
This reentering exception would cause segfault for some reason.
Socket is closed releasing GVL before rb_exc_raise() in rb_threa... -
- Applied in changeset trunk|r59984.
----------
load.c: real path to load
* load.c (rb_construct_expanded_load_path): expand load paths to
real paths to get rid of duplicate loading from symbolic-linked
directories. [Feature #10222] -
- * defs/gmake.mk (ORDERED_TEST_TARGETS): order test-bundler too to
get rid of mixing outputs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59985 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:39 AM Bug #13917: Comparable#clamp is slower than using Array#min,max.
- Thank you, Hanmac. I understand why `Array#min/max` is so fast.
I guess `clamp` would be implemented in `numeric.c` and so on to be as fast as `Array#min/max`. -
- Another instance of this bug:
http://rubyci.s3.amazonaws.com/fedora26/ruby-trunk/log/20170919T063002Z.log.html.gz -
- v.ondruch@tiscali.cz wrote:
> normalperson (Eric Wong) wrote:
> > If you have time, can you try to find larger values changed by
> > r59047 (RUBY_THREAD_MACHINE_STACK_SIZE and
> > RUBY_FIBER_MACHINE_STACK_SIZE) which do not get s... -
- normalperson (Eric Wong) wrote:
> If you have time, can you try to find larger values changed by
> ...
Any idea what should be rasonable value? I started naively with 2 and then continued with 5, 10, 100, 1000, 10000 and it is still c... -
- * load.c (rb_construct_expanded_load_path): expand load paths to
real paths to get rid of duplicate loading from symbolic-linked
directories. [Feature #10222]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59984 b2dd03c8-39d4-4d... -
- * file.c (rb_check_realpath): returns real path which has no
symbolic links. similar to rb_realpath except for returning
Qnil if any parts did not exist.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59983 b2dd03c8-39d4-4d8f-98... -
07:25 AM Feature #12637: Unified and consistent method naming for safe and dangerous methods
- duerst (Martin Dürst) wrote:
> r.smitala (Radovan Smitala) wrote:
> ...
You are right about migration. I don't count all variations of method using.
>
> ...
I think it is why Ruby popularity stagnatess or slightly decreases. No ne... -
04:40 AM Feature #12637: Unified and consistent method naming for safe and dangerous methods
- r.smitala (Radovan Smitala) wrote:
> I also think migration to new method naming is really easy with simple regex replacing.
It's not so easy. There may be programs with variable names such as `fill`, user written classes with meth...
09/20/2017
-
11:48 PM Bug #13925: string.split(pattern, 1) should return [self.dup], but it returns [self]
- There are same problem in partition and rpartition
I expect the s is "abc", but it is modified.
```rb
s = "abc"; s.partition("d").map(&:upcase!); s
# => "ABC"
```
I expect the s is "abc", but it is modified.
```rb
s = "ab... -
04:38 PM Bug #13925 (Closed): string.split(pattern, 1) should return [self.dup], but it returns [self]
- ```ruby
msg = 'abababababa'
msg.split('b', 4).map(&:upcase!) # won't overwrite msg
puts msg # abababababa (expected)
msg.split('b', 1).map(&:upcase!) # this overwrites msg
puts msg # ABABABABABA (abababababa is expected)
```
I w... -
- * Improve spec rather than constrain implementation.
* Coercion ignores visibility in Ruby.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59982 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/net/ftp.rb (Net::FTP#initialize): simplify as per
the original intent.
* spec/ruby/library/net/ftp/initialize_spec.rb: adapt specs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59981 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I've setup some test cases with yahns on https://80x24.org:8443/
to handle large uploads and return the MD5
curl -v -T large_file https://80x24.org:8443/
curl -v -T large_file https://80x24.org:8443/gets_read_mix
curl -v -T large_... -
- cardoso_tiago@hotmail.com wrote:
> Issue #13921 has been updated by chucke (Tiago Cardoso).
>
>
> > Are you using sysread or sysread_nonblock directly, anywhere?
>
> I'm not. But can you reproduce the error as well?
I haven'... -
09:43 AM Bug #13921: buffered read_nonblock doesn't work as expected using SSLSocket
- > Are you using sysread or sysread_nonblock directly, anywhere?
I'm not. But can you reproduce the error as well? -
09:31 PM Feature #13919: Add a new method to create Time instances from unix time and nsec
- Following is a patch based on akr's API.
```diff
diff --git a/test/ruby/test_time.rb b/test/ruby/test_time.rb
index c92aafc149..31d245ade7 100644
--- a/test/ruby/test_time.rb
+++ b/test/ruby/test_time.rb
@@ -236,6 +236,17 @@ def ... -
01:46 PM Feature #13919: Add a new method to create Time instances from unix time and nsec
- I think new method is possible if we find a good method name.
Another idea is adding an optional argument, unit, for Time.at.
Time.at(s, ns, :nanosecond) for example. -
06:50 AM Feature #13919: Add a new method to create Time instances from unix time and nsec
- `Time.at_nsec` is ok for me, but it seems to take just one argument of nano seconds from epoch.
* `Time.at_nsec(nsec_from_epoch)`
* `Time.at_nsec(seconds_from_epoch, nsec)`
Is it not confusing? Or should it get exactly two arguments? -
09:20 PM Feature #10849: Adding an alphanumeric function to SecureRandom
- As an end user of Ruby, I'd like to be able to generate all sorts of cryptographically secure random characters. There's value in having only alphabetical or alphanumeric chars as they are slightly more human readable.
My use case is ... -
- Applied in changeset trunk|r59979.
----------
Move spec/rubyspec to spec/ruby for consistency
* Other ruby implementations use the spec/ruby directory.
[Misc #13792] [ruby-core:82287] -
- I will do it since I am assigned.
-
- * [Misc #13792] [ruby-core:82287]
* Prefer test-spec over test-rubyspec in spec/README.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59980 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * Other ruby implementations use the spec/ruby directory.
[Misc #13792] [ruby-core:82287]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59979 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- closing to trigger backport of r59975
-
- backport status change
-
- Eric Wong <normalperson@yhbt.net> wrote:
> russell.davis@gmail.com wrote:
> > https://bugs.ruby-lang.org/issues/13916
> https://80x24.org/spew/20170919223250.22840-1-e@80x24.org/raw
Cleaned up and added test, committed as r59975 -
06:47 PM Bug #13916 (Closed): Race condition when sending a signal to a new fork - Applied in changeset trunk|r59975.
----------
process: block/unblock signals around fork
As with forking for execve(2) in `spawn', we must block signals
to ensure they are handled correctly in a freshly `fork'-ed child.
* process.c (r... - 07:45 PM Revision 75bfc644 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59978 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59977 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:47 PM Revision 812d5040 (git): * 2017-09-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59976 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:47 PM Revision 5be38692 (git): process: block/unblock signals around fork
- As with forking for execve(2) in `spawn', we must block signals
to ensure they are handled correctly in a freshly `fork'-ed child.
* process.c (retry_fork_ruby): block/unblock signals around fork
(rb_fork_ruby): re-enable signals in f... -
06:21 PM Bug #12644: Support debug build on Windows with MSVC
- Most likely your ucrtbased.dll differs in such way that can't locate that structure, so either need to update implementation to work for it (you'll need to look at disassembly)
or you will need to compile with probably older version o... -
- I like `defer` idea, although adding a new keyword is hard.
Matz. -
04:01 PM Feature #13923: Idiom to release resources safely, with less indentations
- maybe new keyword **defer** which simply builds an array of blocks to be called at end of scope;
specifically immediately before **end** of **ensure** section;
i.e. if there is ensure code then defer underlying support should come afte... -
- tagomoris (Satoshi TAGOMORI) wrote:
> With this code, storage will not be closed if `buffer.close` raises exceptions.
IMHO if buffer.close raises an exception then that should be fixed and not silently ignored.
(e.g. if close fails ... -
- nobu (Nobuyoshi Nakada) wrote:
> Probably a way which is close to it right now would be:
> ...
With this code, storage will not be closed if `buffer.close` raises exceptions. -
- Probably a way which is close to it right now would be:
```ruby
begin
storage = getStorage()
buffer = storage.get(buffer_id)
# ...
rescue StorageError => e
# ...
ensure
buffer&.close
storage&.close
end
``` -
- In programs which grabs and releases resources very often, we need to write so much begin-ensure clauses.
```ruby
begin
storage = getStorage()
begin
buffer = storage.get(buffer_id)
# ...
ensure
buffer.close ... -
01:39 PM Feature #13924 (Open): Add headings/hints to RubyVM::InstructionSequence#disasm
- As the official document mentions, this method will return a String with the human readable instructions. However, it is quite hard to read since we can not understand the definition of each column, for example:
~~~ ruby
puts RubyVM:... -
- matz (Yukihiro Matsumoto) wrote:
> Ruby is not Scheme.
> ...
I know my reply could be annoying. I am apologise before.
After a year of using Ruby in mid-sized project we had some unlikely issues with mutating receiver. Because we are ... -
- * parse.y (parser_string_term, parser_parse_string): move setting
lex_state operations from parser_yylex per each token types.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- MSP-Greg (Greg L) wrote:
> rocifier (Ryan O'Connor) wrote:
> ...
Thanks my issue is very similar. The issue you linked to presents some undocumented requirements. When I try calling `rb_w32_sysinit` it crashes on this line:
https://... -
-
- fixed via https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/59973
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59973 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/ripper/lib/ripper/lexer.rb (List#inspect): splat self data
to local variables same as members of Elem.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59972 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:40 AM Revision da1b14bc (git): Add MonitorMinx#mon_locked? and #mon_owned? to check states of objects
- Patched by Satoshi "Moris" Tagomori <tagomoris@gmail.com>. [Fix GH-1699]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59971 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59970.
----------
ruby.c: paragraph mode by -00
* ruby.c (proc_options): set to paragraph mode, if -00 is given,
as well as perl and -R0 option in 0.49.
[ruby-core:81987] [Bug #13736] -
- * ruby.c (proc_options): set to paragraph mode, if -00 is given,
as well as perl and -R0 option in 0.49.
[ruby-core:81987] [Bug #13736]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59970 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/19/2017
-
- I file here rather than at https://github.com/yuki24/did_you_mean because I am not sure
if the site by Yuki Nishijima may be appropriate, so I think first ruby core has to
decide on this.
Consider the following code:
#!/usr/... -
- I have no objection to a new method at all.
I think the name "Time.of()" is strange though.
With Time.at(), we can say "ok, at this or that moment, we want the time".
With Time.of(), I am confused what that should mean. I am not... -
- Time object contains `nsec`, but Time class doesn't have method to create an instance with nsec.
Time.at() accepts 2nd argument, but it's micro-sec, and we need to divide nsec by 1000.0.
```ruby
t1 = Time.now
t1.nsec #=> nsec value... -
- Problem fixed. I assume Nobu's work has taken care of this. Thank you again.
2017-09-17_59946 Fails
2017-09-18_59956 Passes
2017-09-19_59967 Passes
I'm okay to close. - 11:09 PM Revision 6743bc37 (git): * 2017-09-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59968 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- russell.davis@gmail.com wrote:
> https://bugs.ruby-lang.org/issues/13916
Oops, I don't think we block signals properly for plain `fork' (vs `spawn').
We need to use pthread_sigmask / sigprocmask to block signal.
I am testing thi... -
01:43 AM Bug #13916 (Closed): Race condition when sending a signal to a new fork
- To reproduce, run this script:
~~~ ruby
1_000_000.times do |i|
pid = fork {sleep}
puts pid
Process.kill(:TERM, pid)
Process.wait(pid)
end
~~~
Expected behavior: it should print a million pids and then exit.
Actual... -
- Reading the implementation of read_nonblock and consume_rbuff in
ext/openssl/lib/openssl/buffering.rb and I'm not seeing a
problem in those pure Ruby methods...
Are you using sysread or sysread_nonblock directly, anywhere?
That wo... -
- Just confirmed that the problem only happens because I pass `exception: false`.
-
- I have something similar to the following code that handles both tcp as well as ssl sockets. The idea is to use the #read_nonblock API which uses a buffer when passed in the argument (instead of creating a string every time).
```
cl... -
- merch-redmine@jeremyevans.net wrote:
> Apache labels the SHA1 support "insecure". It's unsalted, so
> weak passwords would fall quickly to a rainbow table attack.
> While the first SHA1 collision attack was reported earlier
> this ... -
04:07 PM Feature #11365 (Closed): Change Webrick to support SHA htpasswd files
- normalperson (Eric Wong) wrote:
> This is an old issue; and nowadays SHA-1 is on it's way out...
> ...
I didn't think SHA-256 was supported in .htpasswd files. I suppose we could roll our own, but I figured the only reason crypt(3) w... -
- hsbt@ruby-lang.org wrote:
> Issue #11365 has been updated by hsbt (Hiroshi SHIBATA).
>
> Status changed from Open to Assigned
> Assignee set to normalperson (Eric Wong)
>
> ----------------------------------------
> Feature #11... -
06:00 AM Feature #11365 (Assigned): Change Webrick to support SHA htpasswd files
-
02:56 PM Revision e219f95d (git): fix a typo in NEWS at r59966.
- * NEWS: fix a typo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- As you know, without X509::DEFAULT_CERT_FILE or ENV['SSL_CERT_FILE'], properly setup verification won't occur. At present, all Appveyor ruby versions previous to 2.4 have this issue. The above link shows that info.
EDIT: I added an ... -
- I added workaround used http at r59964.
I will investigate this later. -
- usa (Usaku NAKAMURA) wrote:
> It's not only on 2.4 but also on trunk.
> ...
I'm sorry, I wasn't clear. Certs aren't configured correctly on Appveyor for ruby builds previous to 2.4. Hence, a ruby script using them can't verify a http... -
- It's not only on 2.4 but also on trunk.
See https://rubyci.org/logs/www.rubyist.net/~akr/chkbuild/debian/ruby-trunk/log/20170919T024800Z.fail.html.gz -
- See [PR 1702](https://github.com/ruby/ruby/pull/1702).
Builds previous to 2.4 don't have cert files, hence, can't verify.
See [Appveyor Ruby & MinGW detail](https://ci.appveyor.com/project/MSP-Greg/appveyor-ruby), which has ruby i... -
- rocifier (Ryan O'Connor) wrote:
> `fileno(stdin)` returns `-2`
Sounds similar to #13546
-
- I am linking to the static library from a win32 application (not console app) set to use the same runtime version as the ruby build. I have tried setting up a console with AllocConsole() and assigning *stdin to this console before initia...
-
- https://github.com/ruby/ruby/blob/c08f7b80889b531865e74bc5f573df8fa27f2088/io.c#L12730
`rb_stdin = prep_stdio(stdin, FMODE_READABLE, rb_cIO, "<STDIN>");`
When this line (io.c) is called upon initialising ruby with `ruby_init()` or ... -
- https://github.com/ruby/rdoc/issues/193 and https://github.com/ruby/rdoc/issues/194 are already closed.
-
- https://github.com/ruby/rdoc/pull/341 was merged 1yr ago.
If you still have this problem, try with rdoc-6.0.0.beta2 and report again. Thank you. -
09:07 AM Feature #10344: [PATCH] Implement Fiber#raise
- Let me add another use case which I discussed with naruse and akr in RubyKaigi.
`Fiber#raise` is helpful to improve compatibility of methods with blocks (internal iterators) and `Enumerator` (external iterators).
This happened for me... -
- applied at r59657
-
- v.ondruch@tiscali.cz wrote:
> Issue #13757 has been updated by vo.x (Vit Ondruch).
>
> Assignee set to normalperson (Eric Wong)
Sorry, I did not notice earlier. Feel free to Cc: me directly
in the future.
> Ok, so I did my h... -
08:48 AM Feature #13801: Implement case equality test for Set#===
- I don't remember but I guess I didn't define `Set#===` probably because Array didn't, but I agree `Set#===` could be useful and intuitive, so I've merged your PR with a slight modification (alias to save an extra method call) and a test ...
-
- Applied in changeset trunk|r59966.
----------
Alias Set#=== to #include?
* set.rb (Set#===): Added via [Feature #13801] by davidarnold.
Closes #1673. - 08:45 AM Revision 2aee703e (git): Alias Set#=== to #include?
- * set.rb (Set#===): Added via [Feature #13801] by davidarnold.
Closes #1673.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:39 AM Bug #12130 (Closed): WEBrick::HTTPProxy closes connection when the socket is not writable temporally
- Applied in changeset trunk|r59965.
----------
webrick: handle EAGAIN/EWOULDBLOCK on proxy connections
* lib/webrick/httpproxy.rb (do_CONNECT): high-level IO methods
[ruby-core:82861] [Bug #12130]
Patch by: Keisuke NISHI -
- > Eric
Could you review and handle this issue?
- 08:39 AM Revision b40a9475 (git): webrick: handle EAGAIN/EWOULDBLOCK on proxy connections
- * lib/webrick/httpproxy.rb (do_CONNECT): high-level IO methods
[ruby-core:82861] [Bug #12130]
Patch by: Keisuke NISHI
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:34 AM Bug #13917: Comparable#clamp is slower than using Array#min,max.
- i can explain why Array#min/max isn't much slower, because it was optimized to not create Array overhead WHEN using variables
(interesting it isn't optimized when only using literals)
~~~ ruby
RubyVM::InstructionSequence.compile("[4... -
- Comparable#clamp is slower than using Array#min,max.
(I noticed it by @onk's tweet. https://twitter.com/onk/status/907856892604461056)
### Performance
```
user system total real
minmax: 0.740000 ... -
- davispuh (Dāvis Mosāns) wrote:
> When building debug build with MSVC (`-MDd` flag) then it will be linked to `ucrtbased.dll` where `_isatty` function obviously differs.
> ...
I'm running into a similar issue to this trying to build wit... -
-
05:42 AM Feature #8499: Importing Hash#slice, Hash#slice!, Hash#except, and Hash#except! from ActiveSupport
- Improved implementation and test.
Added documentation. -
- A few environments couldn't handle https download.
* https://rubyci.org/logs/mswinci.japaneast.cloudapp.azure.com/vc12-x64/ruby-trunk/log/20170919T032511Z.fail.html.gz
* https://rubyci.org/logs/www.rubyist.net/~akr/chkbuild/debia... -
- Well, this issue states that the motivation for introducing the getter methods is for getting return values of Range#step(n) to be handled specially by some libraries or individual methods, and as I said it is to me a typical misuse of s...
-
- Applied in changeset trunk|r59963.
----------
thread.c: report then abort
* thread.c (thread_start_func_2): report then abort on exception,
if both are set. [ruby-core:79280] [Bug #13163] -
- Hmm, indeed this seems considered a bug.
@nobu Could you commit it? -
- * thread.c (thread_start_func_2): report then abort on exception,
if both are set. [ruby-core:79280] [Bug #13163]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59963 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59962.
----------
Added documentation
Added documentaiton for installation of bundled gems.
[Bug #13724][ruby-core:81938] -
- Added documentaiton for installation of bundled gems.
[Bug #13724][ruby-core:81938]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59962 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59961 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r59960.
----------
Define the MIME type for JSON in WEBrick::HTTPUtils::DefaultMimeTypes.
[Feature #10798][ruby-core:67879] -
- [Feature #10798][ruby-core:67879]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59960 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- These are fails when merging at r59779. But these are
working now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59959 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:22 AM Revision 23589094 (git): * 2017-09-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59958 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (parse_ident): disable tLPAREN_ARG state by local
variable. [ruby-list:50578]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59957 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/18/2017
-
- > evil things for optimization and specialization
Reminds me of good old evil.rb - now I am suddenly all for it! Just kidding. :-)
I have no particular pro or con opinion here but I think that one of ruby's philosophy is to put tru... -
12:35 PM Feature #13904: getter for original information of Enumerator
- > Enumerator is about abstracting enumeration and encapsulation of the source is by design.
Well, to be honest, it seems like "forced encapsulation", and is against Ruby's hackable nature.
I understand your concerns, but if _somethin... -
- Enumerator is about abstracting enumeration and encapsulation of the source is by design. If we exposed the guts of an Enumerator, people would start to look into the enclosed object and do (I think are) evil things for optimization and...
-
02:02 PM Misc #13915 (Closed): Updated docs of ThreadGroup
- Prefer 'Class.new' over 'Class::new' in documentation.
https://github.com/ruby/ruby/pull/1700 -
-
-
08:21 AM Bug #13705 (Closed): [PATCH] `cfp consistency error' occurs when raising exception in bmethod call event
- Applied in changeset trunk|r59956.
----------
vm.c: fix `cfp consistency error' which occurs
when raising exception in bmethod call event
* vm.c (invoke_bmethod): set FINISH flag just before calling vm_exec.
[ruby-dev:50162] [Bug #13... -
- when raising exception in bmethod call event
* vm.c (invoke_bmethod): set FINISH flag just before calling vm_exec.
[ruby-dev:50162] [Bug #13705]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59956 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- Applied in changeset trunk|r59955.
----------
error.c: KeyError#receiver and KeyError#key
* error.c: new method KeyError#receiver and KeyError#key.
[Feature #12063]
* hash.c: make KeyError object with receiver and key.
* sprintf.c:... -
- * error.c: new method KeyError#receiver and KeyError#key.
[Feature #12063]
* hash.c: make KeyError object with receiver and key.
* sprintf.c: ditto.
Author: ksss <co000ri@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59954 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This patch helped me understand the problem above: https://bugs.ruby-lang.org/issues/12644
After pasting the ucrtbased.dll from StarCraft II support folder into my build folder, I can now fully build ruby with /MDd and link it. You may ... -
- It is no longer used or exported as of r13641.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:17 AM Revision 9d899615 (git): thread.c: Clear an array for method coverage
- * thread.c (reset_coverage_i): Clear an
array for method coverage just like
line coverage and branch coverage.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59952 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * insns.def (intern): new instruction to turn string into symbol.
opt_call_c_function can not dump.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:41 AM Bug #13914 (Closed): FileUtis.cp_r with remove_destination cannot overwrite a symlink of directory
- ## Reproduce code
~~~
require 'fileutils'
# setup directory like following:
#
# tmp
# ├── dest
# └── src
# ├── a -> dir
# └── dir
#
FileUtils.rm_rf 'tmp'
%w(tmp/src tmp/dest tmp/src/dir).each do|path|
... -
- Applied in changeset trunk|r59950.
----------
refinements in string interpolation
* compile.c (iseq_compile_each0): insert to_s method call, so that
refinements activated at the caller should take place.
[Feature #13812]
* insns.d... -
- * compile.c (iseq_compile_each0): insert to_s method call, so that
refinements activated at the caller should take place.
[Feature #13812]
* insns.def (tostring): fix up converted object to a string,
infect and fallback.
* insns.... -
- * parse.y (ripper_lex_state_name): represent lex_state as OR-ed
form.
* ext/ripper/lib/ripper/lexer.rb (Ripper::Lexer::Elem#to_a):
lex_state for inspection.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59949 b2dd03c8-39d4-4d8f...
09/17/2017
- 11:56 PM Revision 5166f948 (git): * 2017-09-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59948 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:56 PM Revision 05561ad7 (git): ext/objspace/objspace.c: remove unneeded code clones.
- `setup_hash` have already performed nil check and empty check.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59947 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > I cannot understand "But you may want to discuss the issue further." correctly.
I think it means that matz has not made up his mind completely yet, not so much
about the feature itself, but how to implement it.
I do not have a g... -
- I cannot understand "But you may want to discuss the issue further." correctly... But,
Biggest thing of my idea is "there's no need to name the interface (a set of methods)".
In Ruby ecosystem, there are many cases that an argument i... -
- Evan Phoenix and others (including me) once discussed structural interface check instead of nominal check done by `isa?`. It hasn't become concrete but the idea is similar to your proposal. The discussed API was like:
~~~
arg.conform... -
- There are many cases to expect that arguments should respond to a/some methods like this:
```ruby
def call_foo(arg)
if !(arg.respond_to(:to_s) and arg.respond_to(:to_a) and arg.respond_to(:readpartial))
raise ArgumentError, "... -
- There are many cases to expect that arguments should respond to a/some methods like this:
```ruby
def call_foo(arg)
if !(arg.respond_to(:to_s) and arg.respond_to(:to_a) and arg.respond_to(:readpartial))
raise ArgumentError, "... -
01:05 PM Feature #13812: Refinements で定義した to_s を String interpolation が呼んでくれない
- hsbt さん
RubyKaigi でお忙しいところすみません、
hsbt さんに聞くのが適切か分かりませんが、もしよろしければ相談させてください。
本件、すでに nobu さんのパッチがあり、
まつもとさんの承認も得られていますが、どうされますか？
仕様変更の議論なので英語でやった方が良かったかなとも思うんですが、
既にまつもとさんの承認も得られていますし、こういう場合って普段どうされてます？
また、英語で議論する場合、
> 英語で新規... -
- * compile.c (iseq_compile_each0): literal symbol should not be
affected by redefinition of String#intern method.
* vm_insnhelper.c (rb_vm_str_intern): intern a string into a
symbol directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/r... -
- * compile.c (iseq_peephole_optimize): optimize away unnecessary
concatenation of single string, following tostring which always
puts a String instance.
https://github.com/ruby/ruby/pull/1626#discussion_r139285653
git-svn-id: svn+s... -
- `console_size` is not a instance method but a class method.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * node.h (nd_refinements_): nd_refinements_ was
introduced on r49894. But this macro has not been
used since r49897.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59943 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r59942 で何かが直ったようなので stable-snapshot.tar.gz を作り直したところ libffi がバンドルされているのを確認しました。
-
- Applied in changeset trunk|r59942.
----------
make-snapshot: after-update
* tool/make-snapshot (package): fix missing after-update for
libffi and so on. [ruby-dev:50244] [Bug #13897] -
- * tool/make-snapshot (package): fix missing after-update for
libffi and so on. [ruby-dev:50244] [Bug #13897]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59942 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I confirmed to fix this issue at r59937
-
- Applied in changeset trunk|r59937.
----------
Rename bin/ruby as exe/ruby
* common.mk, configure.in: rename the bin directory to run build
executable as exe, to get rid of overwriting true files at the
installation. [ruby-dev:5025... -
- 9/17 時点の trunk HEAD である r59936 を用いて、ソースコードと同じディレクトリで `make` して `make install` すると旧 ruby-runner がインストールされるようです。
https://gist.github.com/hsbt/aa69c38fe05947cce6487a6f6e42d4ed
r59927 で入れた `bin/ruby` へのリネームによって、旧 ruby-runner が `bin/rub... -
- That was a typo, I've tried both 2.4 and 2.5 separately.
I'd also settle for rebuilding all the other libraries in the project to use /MD but I'd need to get /MDd building on Ruby. I tried overwriting the option by manually setting CO... -
- rocifier (Ryan O'Connor) wrote:
> Do you know how to configure the project to build with /MTd? I am getting "unexpected ucrtbased.dll" when trying to link miniruby.exe
Sorry, I don't. I assume you've built other projects with /MTd? ... -
- MSP-Greg (Greg L) wrote:
> I'm not that familiar with MS build tools, but I think ruby is building with this file - [appveyor.yml](https://github.com/MSP-Greg/ruby/blob/appveyor140/appveyor.yml), which I believe is using 140. Test resu... -
- * compile.c: suppress maybe-uninitialized warnings by gcc7.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59941 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- https://en.oxforddictionaries.com/definition/iff
-
- At:
https://ruby-doc.org/stdlib-2.4.1/libdoc/net/ftp/rdoc/Net/FTP.html#method-i-closed-3F
"Returns true iff the connection is closed."
The "iff" should be "if". -
- The second value of key of branch/method coverage is unique ID, not
lineno.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59940 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Instead of in configure.in. As of r28592 the HAVE_VAR_TIMEZONE and
HAVE_VAR_ALTZONE macros are only used by ext/date. ext/date doesn't care
whether they are int or long, so just check for the existence.
git-svn-id: svn+ssh://ci.ruby-lan... -
- HAVE_TIMEZONE and TIMEZONE_VOID macros are not used anymore as of r28592
("strftime.c: unused declarations removed.", 2010-07-09).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59938 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk, configure.in: rename the bin directory to run build
executable as exe, to get rid of overwriting true files at the
installation. [ruby-dev:50250] [Bug #13911]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59937 b2d... -
- As some of you may recall, I have been building MinGW trunk for several months. I have been logging the test results since April on my [doc site](https://msp-greg.github.io/), which has several versions of ruby and a few gems.
I ment...
09/16/2017
- 10:40 PM Revision 08adad00 (git): * 2017-09-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59936 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59935 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I'm not that familiar with MS build tools, but I think ruby is building with this file - [appveyor.yml](https://github.com/MSP-Greg/ruby/blob/appveyor140/appveyor.yml), which I believe is using 140. Test results [here](https://ci.appvey...
-
- shevegen (Robert A. Heiler) wrote:
> Just for curiosity, ruby 2.4.x works for you on windows if you compile it?
I got both versions to build easily with an old VS2010 command prompt, but I still get the __imp__ errors when I link to ... -
- shevegen (Robert A. Heiler) wrote:
> Just for curiosity, ruby 2.4.x works for you on windows if you compile it?
Hi, exactly the same errors for ruby_2_4 branch.
My goal is to link to the produced static library, so I supposed I ne... -
- +1
The patch looks good.
The message of the assert_warn should be changed though. -
- Isn't this a bug?
https://github.com/nobu/ruby/tree/bug/13163-report-before-abort-on-exception -
- r59934 の変更で parent で親ディレクトリに遡っている時以外は Errno::ENOTEMPTY を無視しないように変更したようです(従ってドキュメントの ENOTEMPTY の記述の削除は戻したほうがいいかも?)。しかし存在しない名前を FileUtils.rmdir に指定した時にエラーにならなかったのが Errno::ENOENT が発生するなるようになってしまっているようです。
~~~
% ./ruby -r fileutils -e 'Fi... -
- Applied in changeset trunk|r59934.
----------
fileutils.rb: error at rmdir
* lib/fileutils.rb (rmdir): should not ignore errors first, except
for parent directories. [ruby-dev:50236] [Bug #13889] -
- * lib/fileutils.rb (rmdir): should not ignore errors first, except
for parent directories. [ruby-dev:50236] [Bug #13889]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59934 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59933.
----------
file.c: [DOC] separators at dirname and basename
* file.c (rb_file_s_basename, rb_file_s_dirname): [DOC] state
that trailing separators will be stripped first, like as
basename(1) and d... -
- davemyron (Dave Myron) wrote:
> Given `File.dirname("/some/folder/")` the result of `/some` is very surprising because the path is "obviously" a directory without a file specified. (I got bit by this today… yes, I needed more tests)
> ... -
04:14 AM Bug #13908 (Closed): Result of Pathname#dirname / File.dirname handling of paths with trailing File::SEPARATOR is surprising
- Given `File.dirname("/some/folder/")` the result of `/some` is very surprising because the path is "obviously" a directory without a file specified. (I got bit by this today… yes, I needed more tests)
My expectation was that it would ... -
- * file.c (rb_file_s_basename, rb_file_s_dirname): [DOC] state
that trailing separators will be stripped first, like as
basename(1) and dirname(1). [ruby-core:82828] [Bug #13908]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@599... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59932 b2dd03c8-39d4-4d8f-98ff-823fe69b080e