Project

General

Profile

Activity

From 09/13/2017 to 09/19/2017

09/19/2017

11:53 PM Feature #13922 (Open): Consider showing warning messages about same-named aliases - either directly or perhaps via the "did you mean gem"
I file here rather than at https://github.com/yuki24/did_you_mean because I am not sure
if the site by Yuki Nishijima may be appropriate, so I think first ruby core has to
decide on this.
Consider the following code:
#!/usr/...
shevegen (Robert A. Heiler)
11:49 PM Feature #13919: Add a new method to create Time instances from unix time and nsec
I have no objection to a new method at all.
I think the name "Time.of()" is strange though.
With Time.at(), we can say "ok, at this or that moment, we want the time".
With Time.of(), I am confused what that should mean. I am not...
shevegen (Robert A. Heiler)
06:59 AM Feature #13919 (Closed): Add a new method to create Time instances from unix time and nsec
Time object contains `nsec`, but Time class doesn't have method to create an instance with nsec.
Time.at() accepts 2nd argument, but it's micro-sec, and we need to divide nsec by 1000.0.
```ruby
t1 = Time.now
t1.nsec #=> nsec value...
tagomoris (Satoshi Tagomori)
11:09 PM Bug #13910: Seg Fault from require_relative
Problem fixed. I assume Nobu's work has taken care of this. Thank you again.
2017-09-17_59946 Fails
2017-09-18_59956 Passes
2017-09-19_59967 Passes
I'm okay to close.
MSP-Greg (Greg L)
11:09 PM Revision 6743bc37 (git): * 2017-09-20
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:09 PM Revision b823ecc3 (git): adjust indent
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59968 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
10:36 PM Bug #13916: Race condition when sending a signal to a new fork
russell.davis@gmail.com wrote:
> https://bugs.ruby-lang.org/issues/13916

Oops, I don't think we block signals properly for plain `fork' (vs `spawn').
We need to use pthread_sigmask / sigprocmask to block signal.

I am testing thi...
normalperson (Eric Wong)
01:43 AM Bug #13916 (Closed): Race condition when sending a signal to a new fork
To reproduce, run this script:
~~~ ruby
1_000_000.times do |i|
pid = fork {sleep}
puts pid
Process.kill(:TERM, pid)
Process.wait(pid)
end
~~~
Expected behavior: it should print a million pids and then exit.
Actual...
russelldavis (Russell Davis)
08:51 PM Bug #13921: buffered read_nonblock doesn't work as expected using SSLSocket
Reading the implementation of read_nonblock and consume_rbuff in
ext/openssl/lib/openssl/buffering.rb and I'm not seeing a
problem in those pure Ruby methods...

Are you using sysread or sysread_nonblock directly, anywhere?
That wo...
normalperson (Eric Wong)
06:25 PM Bug #13921: buffered read_nonblock doesn't work as expected using SSLSocket
Just confirmed that the problem only happens because I pass `exception: false`. chucke (Tiago Cardoso)
06:20 PM Bug #13921 (Closed): buffered read_nonblock doesn't work as expected using SSLSocket
I have something similar to the following code that handles both tcp as well as ssl sockets. The idea is to use the #read_nonblock API which uses a buffer when passed in the argument (instead of creating a string every time).
```
cl...
chucke (Tiago Cardoso)
05:08 PM Feature #11365: Change Webrick to support SHA htpasswd files
merch-redmine@jeremyevans.net wrote:
> Apache labels the SHA1 support "insecure". It's unsalted, so
> weak passwords would fall quickly to a rainbow table attack.
> While the first SHA1 collision attack was reported earlier
> this ...
normalperson (Eric Wong)
04:07 PM Feature #11365 (Closed): Change Webrick to support SHA htpasswd files
normalperson (Eric Wong) wrote:
> This is an old issue; and nowadays SHA-1 is on it's way out...
> ...
I didn't think SHA-256 was supported in .htpasswd files. I suppose we could roll our own, but I figured the only reason crypt(3) w...
jeremyevans0 (Jeremy Evans)
08:41 AM Feature #11365: Change Webrick to support SHA htpasswd files
hsbt@ruby-lang.org wrote:
> Issue #11365 has been updated by hsbt (Hiroshi SHIBATA).
>
> Status changed from Open to Assigned
> Assignee set to normalperson (Eric Wong)
>
> ----------------------------------------
> Feature #11...
normalperson (Eric Wong)
06:00 AM Feature #11365 (Assigned): Change Webrick to support SHA htpasswd files
hsbt (Hiroshi SHIBATA)
02:56 PM Revision e219f95d (git): fix a typo in NEWS at r59966.
* NEWS: fix a typo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nagachika (Tomoyuki Chikanaga)
01:44 PM Bug #13918: Appveyor failure - svn 59961 Use https instead of ftp for libffi downloading
As you know, without X509::DEFAULT_CERT_FILE or ENV['SSL_CERT_FILE'], properly setup verification won't occur. At present, all Appveyor ruby versions previous to 2.4 have this issue. The above link shows that info.
EDIT: I added an ...
MSP-Greg (Greg L)
05:05 AM Bug #13918: Appveyor failure - svn 59961 Use https instead of ftp for libffi downloading
I added workaround used http at r59964.
I will investigate this later.
hsbt (Hiroshi SHIBATA)
04:04 AM Bug #13918: Appveyor failure - svn 59961 Use https instead of ftp for libffi downloading
usa (Usaku NAKAMURA) wrote:
> It's not only on 2.4 but also on trunk.
> ...
I'm sorry, I wasn't clear. Certs aren't configured correctly on Appveyor for ruby builds previous to 2.4. Hence, a ruby script using them can't verify a http...
MSP-Greg (Greg L)
03:49 AM Bug #13918 (Assigned): Appveyor failure - svn 59961 Use https instead of ftp for libffi downloading
It's not only on 2.4 but also on trunk.
See https://rubyci.org/logs/www.rubyist.net/~akr/chkbuild/debian/ruby-trunk/log/20170919T024800Z.fail.html.gz
usa (Usaku NAKAMURA)
03:20 AM Bug #13918 (Closed): Appveyor failure - svn 59961 Use https instead of ftp for libffi downloading
See [PR 1702](https://github.com/ruby/ruby/pull/1702).
Builds previous to 2.4 don't have cert files, hence, can't verify.
See [Appveyor Ruby & MinGW detail](https://ci.appveyor.com/project/MSP-Greg/appveyor-ruby), which has ruby i...
MSP-Greg (Greg L)
12:35 PM Bug #13920: prepping io for stdin returns "access denied" on windows
rocifier (Ryan O'Connor) wrote:
> `fileno(stdin)` returns `-2`
Sounds similar to #13546
MSP-Greg (Greg L)
10:15 AM Bug #13920: prepping io for stdin returns "access denied" on windows
I am linking to the static library from a win32 application (not console app) set to use the same runtime version as the ruby build. I have tried setting up a console with AllocConsole() and assigning *stdin to this console before initia... rocifier (Ryan O'Connor)
10:10 AM Bug #13920 (Closed): prepping io for stdin returns "access denied" on windows
https://github.com/ruby/ruby/blob/c08f7b80889b531865e74bc5f573df8fa27f2088/io.c#L12730
`rb_stdin = prep_stdio(stdin, FMODE_READABLE, rb_cIO, "<STDIN>");`
When this line (io.c) is called upon initialising ruby with `ruby_init()` or ...
rocifier (Ryan O'Connor)
09:30 AM Bug #8037 (Rejected): rdoc issues preventing docs generating after ruby was compiled
https://github.com/ruby/rdoc/issues/193 and https://github.com/ruby/rdoc/issues/194 are already closed. hsbt (Hiroshi SHIBATA)
09:28 AM Bug #11092 (Rejected): rdoc-generated *.gz files contain references to full path of the original, breaking rpmbuild
https://github.com/ruby/rdoc/pull/341 was merged 1yr ago.
If you still have this problem, try with rdoc-6.0.0.beta2 and report again. Thank you.
hsbt (Hiroshi SHIBATA)
09:07 AM Feature #10344: [PATCH] Implement Fiber#raise
Let me add another use case which I discussed with naruse and akr in RubyKaigi.
`Fiber#raise` is helpful to improve compatibility of methods with blocks (internal iterators) and `Enumerator` (external iterators).
This happened for me...
yugui (Yuki Sonoda)
08:52 AM Bug #11310 (Closed): CSV::Table#to_csv should use concat not +
applied at r59657 hsbt (Hiroshi SHIBATA)
08:51 AM Bug #13757: TestBacktrace#test_caller_lev segaults on PPC
v.ondruch@tiscali.cz wrote:
> Issue #13757 has been updated by vo.x (Vit Ondruch).
>
> Assignee set to normalperson (Eric Wong)

Sorry, I did not notice earlier. Feel free to Cc: me directly
in the future.

> Ok, so I did my h...
normalperson (Eric Wong)
08:48 AM Feature #13801: Implement case equality test for Set#===
I don't remember but I guess I didn't define `Set#===` probably because Array didn't, but I agree `Set#===` could be useful and intuitive, so I've merged your PR with a slight modification (alias to save an extra method call) and a test ... knu (Akinori MUSHA)
08:45 AM Feature #13801 (Closed): Implement case equality test for Set#===
Applied in changeset trunk|r59966.
----------
Alias Set#=== to #include?
* set.rb (Set#===): Added via [Feature #13801] by davidarnold.
Closes #1673.
knu (Akinori MUSHA)
08:45 AM Revision 2aee703e (git): Alias Set#=== to #include?
* set.rb (Set#===): Added via [Feature #13801] by davidarnold.
Closes #1673.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Akinori MUSHA
08:39 AM Bug #12130 (Closed): WEBrick::HTTPProxy closes connection when the socket is not writable temporally
Applied in changeset trunk|r59965.
----------
webrick: handle EAGAIN/EWOULDBLOCK on proxy connections
* lib/webrick/httpproxy.rb (do_CONNECT): high-level IO methods
[ruby-core:82861] [Bug #12130]
Patch by: Keisuke NISHI
Anonymous
06:00 AM Bug #12130: WEBrick::HTTPProxy closes connection when the socket is not writable temporally
> Eric
Could you review and handle this issue?
hsbt (Hiroshi SHIBATA)
08:39 AM Revision b40a9475 (git): webrick: handle EAGAIN/EWOULDBLOCK on proxy connections
* lib/webrick/httpproxy.rb (do_CONNECT): high-level IO methods
[ruby-core:82861] [Bug #12130]
Patch by: Keisuke NISHI
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
07:34 AM Bug #13917: Comparable#clamp is slower than using Array#min,max.
i can explain why Array#min/max isn't much slower, because it was optimized to not create Array overhead WHEN using variables
(interesting it isn't optimized when only using literals)
~~~ ruby
RubyVM::InstructionSequence.compile("[4...
Hanmac (Hans Mackowiak)
02:26 AM Bug #13917 (Rejected): Comparable#clamp is slower than using Array#min,max.
Comparable#clamp is slower than using Array#min,max.
(I noticed it by @onk's tweet. https://twitter.com/onk/status/907856892604461056)
### Performance
```
user system total real
minmax: 0.740000 ...
kei-s (Kei Shiratsuchi)
07:19 AM Bug #12644: Support debug build on Windows with MSVC
davispuh (Dāvis Mosāns) wrote:
> When building debug build with MSVC (`-MDd` flag) then it will be linked to `ucrtbased.dll` where `_isatty` function obviously differs.
> ...
I'm running into a similar issue to this trying to build wit...
rocifier (Ryan O'Connor)
06:12 AM Feature #8126 (Assigned): OpenSSL::SSL::SSLSocket does not define #recv and #send messages
hsbt (Hiroshi SHIBATA)
05:42 AM Feature #8499: Importing Hash#slice, Hash#slice!, Hash#except, and Hash#except! from ActiveSupport
Improved implementation and test.
Added documentation.
Glass_saga (Masaki Matsushita)
05:01 AM Revision eccbd8c0 (git): Fixup r59961. Use http for libffi downloading.
A few environments couldn't handle https download.
* https://rubyci.org/logs/mswinci.japaneast.cloudapp.azure.com/vc12-x64/ruby-trunk/log/20170919T032511Z.fail.html.gz
* https://rubyci.org/logs/www.rubyist.net/~akr/chkbuild/debia...
hsbt (Hiroshi SHIBATA)
03:47 AM Feature #13904: getter for original information of Enumerator
Well, this issue states that the motivation for introducing the getter methods is for getting return values of Range#step(n) to be handled specially by some libraries or individual methods, and as I said it is to me a typical misuse of s... knu (Akinori MUSHA)
02:42 AM Bug #13163 (Closed): Uncaught exceptions may not be reported when Thread#report_on_exception=true and Thread#abort_on_exception=true
Applied in changeset trunk|r59963.
----------
thread.c: report then abort
* thread.c (thread_start_func_2): report then abort on exception,
if both are set. [ruby-core:79280] [Bug #13163]
nobu (Nobuyoshi Nakada)
02:02 AM Bug #13163 (Assigned): Uncaught exceptions may not be reported when Thread#report_on_exception=true and Thread#abort_on_exception=true
Hmm, indeed this seems considered a bug.
@nobu Could you commit it?
naruse (Yui NARUSE)
02:42 AM Revision ab81cc4d (git): thread.c: report then abort
* thread.c (thread_start_func_2): report then abort on exception,
if both are set. [ruby-core:79280] [Bug #13163]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59963 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:39 AM Bug #13724 (Closed): make install does not install bundled gems
Applied in changeset trunk|r59962.
----------
Added documentation
Added documentaiton for installation of bundled gems.
[Bug #13724][ruby-core:81938]
hsbt (Hiroshi SHIBATA)
02:39 AM Revision d61b1e9e (git): Added documentation
Added documentaiton for installation of bundled gems.
[Bug #13724][ruby-core:81938]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59962 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
02:25 AM Revision e9f5265b (git): Use https instead of ftp for libffi downloading.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59961 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
01:54 AM Feature #10798 (Closed): Define the MIME type for JSON in WEBrick::HTTPUtils::DefaultMimeTypes
Applied in changeset trunk|r59960.
----------
Define the MIME type for JSON in WEBrick::HTTPUtils::DefaultMimeTypes.
[Feature #10798][ruby-core:67879]
hsbt (Hiroshi SHIBATA)
01:54 AM Revision 2b86b6f3 (git): Define the MIME type for JSON in WEBrick::HTTPUtils::DefaultMimeTypes.
[Feature #10798][ruby-core:67879]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59960 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
12:37 AM Revision 08a0927c (git): Enabled temporary disabled examples of bundler rspec.
These are fails when merging at r59779. But these are
working now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59959 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
12:22 AM Revision 23589094 (git): * 2017-09-19
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59958 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:22 AM Revision 50f7d64f (git): parse.y: lex by lvar
* parse.y (parse_ident): disable tLPAREN_ARG state by local
variable. [ruby-list:50578]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59957 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)

09/18/2017

11:04 PM Feature #13904: getter for original information of Enumerator
> evil things for optimization and specialization
Reminds me of good old evil.rb - now I am suddenly all for it! Just kidding. :-)
I have no particular pro or con opinion here but I think that one of ruby's philosophy is to put tru...
shevegen (Robert A. Heiler)
12:35 PM Feature #13904: getter for original information of Enumerator
> Enumerator is about abstracting enumeration and encapsulation of the source is by design.
Well, to be honest, it seems like "forced encapsulation", and is against Ruby's hackable nature.
I understand your concerns, but if _somethin...
zverok (Victor Shepelev)
05:31 AM Feature #13904: getter for original information of Enumerator
Enumerator is about abstracting enumeration and encapsulation of the source is by design. If we exposed the guts of an Enumerator, people would start to look into the enclosed object and do (I think are) evil things for optimization and... knu (Akinori MUSHA)
02:02 PM Misc #13915 (Closed): Updated docs of ThreadGroup
Prefer 'Class.new' over 'Class::new' in documentation.
https://github.com/ruby/ruby/pull/1700
herwinw (Herwin Quarantainenet)
12:04 PM Misc #12937 (Closed): [PATCH] webrick/server: simplify Daemon.start
hsbt (Hiroshi SHIBATA)
11:52 AM Bug #13912 (Rejected): Method definition with explicitly callable method names
hsbt (Hiroshi SHIBATA)
08:21 AM Bug #13705 (Closed): [PATCH] `cfp consistency error' occurs when raising exception in bmethod call event
Applied in changeset trunk|r59956.
----------
vm.c: fix `cfp consistency error' which occurs
when raising exception in bmethod call event
* vm.c (invoke_bmethod): set FINISH flag just before calling vm_exec.
[ruby-dev:50162] [Bug #13...
ktsj (Kazuki Tsujimoto)
08:21 AM Revision 698f2db2 (git): vm.c: fix `cfp consistency error' which occurs
when raising exception in bmethod call event
* vm.c (invoke_bmethod): set FINISH flag just before calling vm_exec.
[ruby-dev:50162] [Bug #13705]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59956 b2dd03c8-39d4-4d8f-98ff-823fe69b...
ktsj (Kazuki Tsujimoto)
08:05 AM Feature #12063 (Closed): KeyError#receiver and KeyError#name
Applied in changeset trunk|r59955.
----------
error.c: KeyError#receiver and KeyError#key
* error.c: new method KeyError#receiver and KeyError#key.
[Feature #12063]
* hash.c: make KeyError object with receiver and key.
* sprintf.c:...
nobu (Nobuyoshi Nakada)
08:05 AM Revision 13f5dcb9 (git): error.c: KeyError#receiver and KeyError#key
* error.c: new method KeyError#receiver and KeyError#key.
[Feature #12063]
* hash.c: make KeyError object with receiver and key.
* sprintf.c: ditto.
Author: ksss <co000ri@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr...
nobu (Nobuyoshi Nakada)
07:52 AM Revision 2627c19d (git): configure.in: use newer libtool only
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59954 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
07:19 AM Bug #13903: cant compile ruby with /MT on windows
This patch helped me understand the problem above: https://bugs.ruby-lang.org/issues/12644
After pasting the ucrtbased.dll from StarCraft II support folder into my build folder, I can now fully build ruby with /MDd and link it. You may ...
rocifier (Ryan O'Connor)
05:37 AM Revision 2bd222ab (git): re.c: remove unused rb_memcmp() function
It is no longer used or exported as of r13641.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
rhenium (Kazuki Yamaguchi)
05:17 AM Revision 9d899615 (git): thread.c: Clear an array for method coverage
* thread.c (reset_coverage_i): Clear an
array for method coverage just like
line coverage and branch coverage.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59952 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
yui-knk (Kaneko Yuichiro)
05:16 AM Revision 5d988300 (git): intern instruction
* insns.def (intern): new instruction to turn string into symbol.
opt_call_c_function can not dump.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:41 AM Bug #13914 (Closed): FileUtis.cp_r with remove_destination cannot overwrite a symlink of directory
## Reproduce code
~~~
require 'fileutils'
# setup directory like following:
#
# tmp
# ├── dest
# └── src
# ├── a -> dir
# └── dir
#
FileUtils.rm_rf 'tmp'
%w(tmp/src tmp/dest tmp/src/dir).each do|path|
...
mzp (Hiroki MIZUNO)
02:27 AM Feature #13812 (Closed): Refinements で定義した to_s を String interpolation が呼んでくれない
Applied in changeset trunk|r59950.
----------
refinements in string interpolation
* compile.c (iseq_compile_each0): insert to_s method call, so that
refinements activated at the caller should take place.
[Feature #13812]
* insns.d...
nobu (Nobuyoshi Nakada)
02:27 AM Revision b2da3824 (git): refinements in string interpolation
* compile.c (iseq_compile_each0): insert to_s method call, so that
refinements activated at the caller should take place.
[Feature #13812]
* insns.def (tostring): fix up converted object to a string,
infect and fallback.
* insns....
nobu (Nobuyoshi Nakada)
12:08 AM Revision d1e63172 (git): parse.y: ripper_lex_state_name
* parse.y (ripper_lex_state_name): represent lex_state as OR-ed
form.
* ext/ripper/lib/ripper/lexer.rb (Ripper::Lexer::Elem#to_a):
lex_state for inspection.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59949 b2dd03c8-39d4-4d8f...
nobu (Nobuyoshi Nakada)

09/17/2017

11:56 PM Revision 5166f948 (git): * 2017-09-18
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59948 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:56 PM Revision 05561ad7 (git): ext/objspace/objspace.c: remove unneeded code clones.
`setup_hash` have already performed nil check and empty check.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59947 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mame (Yusuke Endoh)
05:16 PM Feature #13913: Method definition with explicitly callable method names
> I cannot understand "But you may want to discuss the issue further." correctly.
I think it means that matz has not made up his mind completely yet, not so much
about the feature itself, but how to implement it.
I do not have a g...
shevegen (Robert A. Heiler)
03:28 PM Feature #13913: Method definition with explicitly callable method names
I cannot understand "But you may want to discuss the issue further." correctly... But,
Biggest thing of my idea is "there's no need to name the interface (a set of methods)".
In Ruby ecosystem, there are many cases that an argument i...
tagomoris (Satoshi Tagomori)
03:06 PM Feature #13913: Method definition with explicitly callable method names
Evan Phoenix and others (including me) once discussed structural interface check instead of nominal check done by `isa?`. It hasn't become concrete but the idea is similar to your proposal. The discussed API was like:
~~~
arg.conform...
matz (Yukihiro Matsumoto)
02:40 PM Feature #13913 (Open): Method definition with explicitly callable method names
There are many cases to expect that arguments should respond to a/some methods like this:
```ruby
def call_foo(arg)
if !(arg.respond_to(:to_s) and arg.respond_to(:to_a) and arg.respond_to(:readpartial))
raise ArgumentError, "...
tagomoris (Satoshi Tagomori)
02:39 PM Bug #13912 (Rejected): Method definition with explicitly callable method names
There are many cases to expect that arguments should respond to a/some methods like this:
```ruby
def call_foo(arg)
if !(arg.respond_to(:to_s) and arg.respond_to(:to_a) and arg.respond_to(:readpartial))
raise ArgumentError, "...
tagomoris (Satoshi Tagomori)
01:05 PM Feature #13812: Refinements で定義した to_s を String interpolation が呼んでくれない
hsbt さん
RubyKaigi でお忙しいところすみません、
hsbt さんに聞くのが適切か分かりませんが、もしよろしければ相談させてください。
本件、すでに nobu さんのパッチがあり、
まつもとさんの承認も得られていますが、どうされますか?
仕様変更の議論なので英語でやった方が良かったかなとも思うんですが、
既にまつもとさんの承認も得られていますし、こういう場合って普段どうされてます?
また、英語で議論する場合、
> 英語で新規...
ttanimichi (Tsukuru Tanimichi)
09:28 AM Revision df33c063 (git): literal symbol by intern
* compile.c (iseq_compile_each0): literal symbol should not be
affected by redefinition of String#intern method.
* vm_insnhelper.c (rb_vm_str_intern): intern a string into a
symbol directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/r...
nobu (Nobuyoshi Nakada)
09:21 AM Revision 08bb3640 (git): compile.c: optimize unnecessary concatstrings
* compile.c (iseq_peephole_optimize): optimize away unnecessary
concatenation of single string, following tostring which always
puts a String instance.
https://github.com/ruby/ruby/pull/1626#discussion_r139285653
git-svn-id: svn+s...
nobu (Nobuyoshi Nakada)
08:04 AM Revision f3a491d9 (git): ext/io/console/lib/console/size.rb: Fix the context of method definition
`console_size` is not a instance method but a class method.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mame (Yusuke Endoh)
07:19 AM Revision affa40b9 (git): node.h: Remove a not used macro
* node.h (nd_refinements_): nd_refinements_ was
introduced on r49894. But this macro has not been
used since r49897.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59943 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
yui-knk (Kaneko Yuichiro)
07:14 AM Bug #13897: libffi is now not bundled in snapshots
r59942 で何かが直ったようなので stable-snapshot.tar.gz を作り直したところ libffi がバンドルされているのを確認しました。 hsbt (Hiroshi SHIBATA)
06:50 AM Bug #13897 (Closed): libffi is now not bundled in snapshots
Applied in changeset trunk|r59942.
----------
make-snapshot: after-update
* tool/make-snapshot (package): fix missing after-update for
libffi and so on. [ruby-dev:50244] [Bug #13897]
nobu (Nobuyoshi Nakada)
06:50 AM Revision eb0146e2 (git): make-snapshot: after-update
* tool/make-snapshot (package): fix missing after-update for
libffi and so on. [ruby-dev:50244] [Bug #13897]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59942 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:43 AM Bug #13911: Breaking 2.5.0 Installation with in-place build.
I confirmed to fix this issue at r59937 hsbt (Hiroshi SHIBATA)
04:17 AM Bug #13911 (Closed): Breaking 2.5.0 Installation with in-place build.
Applied in changeset trunk|r59937.
----------
Rename bin/ruby as exe/ruby
* common.mk, configure.in: rename the bin directory to run build
executable as exe, to get rid of overwriting true files at the
installation. [ruby-dev:5025...
nobu (Nobuyoshi Nakada)
02:39 AM Bug #13911 (Closed): Breaking 2.5.0 Installation with in-place build.
9/17 時点の trunk HEAD である r59936 を用いて、ソースコードと同じディレクトリで `make` して `make install` すると旧 ruby-runner がインストールされるようです。
https://gist.github.com/hsbt/aa69c38fe05947cce6487a6f6e42d4ed
r59927 で入れた `bin/ruby` へのリネームによって、旧 ruby-runner が `bin/rub...
hsbt (Hiroshi SHIBATA)
06:17 AM Bug #13903: cant compile ruby with /MT on windows
That was a typo, I've tried both 2.4 and 2.5 separately.
I'd also settle for rebuilding all the other libraries in the project to use /MD but I'd need to get /MDd building on Ruby. I tried overwriting the option by manually setting CO...
rocifier (Ryan O'Connor)
04:20 AM Bug #13903: cant compile ruby with /MT on windows
rocifier (Ryan O'Connor) wrote:
> Do you know how to configure the project to build with /MTd? I am getting "unexpected ucrtbased.dll" when trying to link miniruby.exe
Sorry, I don't. I assume you've built other projects with /MTd? ...
MSP-Greg (Greg L)
03:19 AM Bug #13903: cant compile ruby with /MT on windows
MSP-Greg (Greg L) wrote:
> I'm not that familiar with MS build tools, but I think ruby is building with this file - [appveyor.yml](https://github.com/MSP-Greg/ruby/blob/appveyor140/appveyor.yml), which I believe is using 140. Test resu...
rocifier (Ryan O'Connor)
05:51 AM Revision ad094e3a (git): suppress warnings
* compile.c: suppress maybe-uninitialized warnings by gcc7.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59941 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:46 AM Misc #13909 (Rejected): [Docu] Typo in ruby ftp - "Returns true iff the connection is closed."
https://en.oxforddictionaries.com/definition/iff nobu (Nobuyoshi Nakada)
01:49 AM Misc #13909 (Rejected): [Docu] Typo in ruby ftp - "Returns true iff the connection is closed."
At:
https://ruby-doc.org/stdlib-2.4.1/libdoc/net/ftp/rdoc/Net/FTP.html#method-i-closed-3F
"Returns true iff the connection is closed."
The "iff" should be "if".
shevegen (Robert A. Heiler)
04:30 AM Revision b366c4d4 (git): run-lcov.rb: wrongly used unique ID as lineno
The second value of key of branch/method coverage is unique ID, not
lineno.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59940 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mame (Yusuke Endoh)
04:26 AM Revision e2cb0ede (git): ext/date/extconf.rb: check for timezone and altzone
Instead of in configure.in. As of r28592 the HAVE_VAR_TIMEZONE and
HAVE_VAR_ALTZONE macros are only used by ext/date. ext/date doesn't care
whether they are int or long, so just check for the existence.
git-svn-id: svn+ssh://ci.ruby-lan...
rhenium (Kazuki Yamaguchi)
04:26 AM Revision 06af07dd (git): configure.in: don't check for existence of timezone()
HAVE_TIMEZONE and TIMEZONE_VOID macros are not used anymore as of r28592
("strftime.c: unused declarations removed.", 2010-07-09).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59938 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
rhenium (Kazuki Yamaguchi)
04:14 AM Revision 30290144 (git): Rename bin/ruby as exe/ruby
* common.mk, configure.in: rename the bin directory to run build
executable as exe, to get rid of overwriting true files at the
installation. [ruby-dev:50250] [Bug #13911]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59937 b2d...
nobu (Nobuyoshi Nakada)
02:30 AM Bug #13910 (Rejected): Seg Fault from require_relative
As some of you may recall, I have been building MinGW trunk for several months. I have been logging the test results since April on my [doc site](https://msp-greg.github.io/), which has several versions of ruby and a few gems.
I ment...
MSP-Greg (Greg L)

09/16/2017

10:40 PM Revision 08adad00 (git): * 2017-09-17
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59936 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
10:40 PM Revision 1241d59c (git): test_fileutils.rb: rmdir should fail on nonexistent directory
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59935 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
10:16 PM Bug #13903: cant compile ruby with /MT on windows
I'm not that familiar with MS build tools, but I think ruby is building with this file - [appveyor.yml](https://github.com/MSP-Greg/ruby/blob/appveyor140/appveyor.yml), which I believe is using 140. Test results [here](https://ci.appvey... MSP-Greg (Greg L)
05:02 AM Bug #13903: cant compile ruby with /MT on windows
shevegen (Robert A. Heiler) wrote:
> Just for curiosity, ruby 2.4.x works for you on windows if you compile it?
I got both versions to build easily with an old VS2010 command prompt, but I still get the __imp__ errors when I link to ...
rocifier (Ryan O'Connor)
02:16 AM Bug #13903: cant compile ruby with /MT on windows
shevegen (Robert A. Heiler) wrote:
> Just for curiosity, ruby 2.4.x works for you on windows if you compile it?
Hi, exactly the same errors for ruby_2_4 branch.
My goal is to link to the produced static library, so I supposed I ne...
rocifier (Ryan O'Connor)
02:47 PM Bug #13163: Uncaught exceptions may not be reported when Thread#report_on_exception=true and Thread#abort_on_exception=true
+1
The patch looks good.
The message of the assert_warn should be changed though.
Eregon (Benoit Daloze)
02:25 PM Bug #13163 (Feedback): Uncaught exceptions may not be reported when Thread#report_on_exception=true and Thread#abort_on_exception=true
Isn't this a bug?
https://github.com/nobu/ruby/tree/bug/13163-report-before-abort-on-exception
nobu (Nobuyoshi Nakada)
02:31 PM Bug #13889 (Open): FileUtils.rmdir が Errno::ENOTEMPTY を無視している
r59934 の変更で parent で親ディレクトリに遡っている時以外は Errno::ENOTEMPTY を無視しないように変更したようです(従ってドキュメントの ENOTEMPTY の記述の削除は戻したほうがいいかも?)。しかし存在しない名前を FileUtils.rmdir に指定した時にエラーにならなかったのが Errno::ENOENT が発生するなるようになってしまっているようです。
~~~
% ./ruby -r fileutils -e 'Fi...
nagachika (Tomoyuki Chikanaga)
11:59 AM Bug #13889 (Closed): FileUtils.rmdir が Errno::ENOTEMPTY を無視している
Applied in changeset trunk|r59934.
----------
fileutils.rb: error at rmdir
* lib/fileutils.rb (rmdir): should not ignore errors first, except
for parent directories. [ruby-dev:50236] [Bug #13889]
nobu (Nobuyoshi Nakada)
11:59 AM Revision 2635984c (git): fileutils.rb: error at rmdir
* lib/fileutils.rb (rmdir): should not ignore errors first, except
for parent directories. [ruby-dev:50236] [Bug #13889]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59934 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
11:51 AM Bug #13908 (Closed): Result of Pathname#dirname / File.dirname handling of paths with trailing File::SEPARATOR is surprising
Applied in changeset trunk|r59933.
----------
file.c: [DOC] separators at dirname and basename
* file.c (rb_file_s_basename, rb_file_s_dirname): [DOC] state
that trailing separators will be stripped first, like as
basename(1) and d...
nobu (Nobuyoshi Nakada)
09:13 AM Bug #13908: Result of Pathname#dirname / File.dirname handling of paths with trailing File::SEPARATOR is surprising
davemyron (Dave Myron) wrote:
> Given `File.dirname("/some/folder/")` the result of `/some` is very surprising because the path is "obviously" a directory without a file specified. (I got bit by this today… yes, I needed more tests)
> ...
rocifier (Ryan O'Connor)
04:14 AM Bug #13908 (Closed): Result of Pathname#dirname / File.dirname handling of paths with trailing File::SEPARATOR is surprising
Given `File.dirname("/some/folder/")` the result of `/some` is very surprising because the path is "obviously" a directory without a file specified. (I got bit by this today… yes, I needed more tests)
My expectation was that it would ...
davemyron (Dave Myron)
11:50 AM Revision 40d117ae (git): file.c: [DOC] separators at dirname and basename
* file.c (rb_file_s_basename, rb_file_s_dirname): [DOC] state
that trailing separators will be stripped first, like as
basename(1) and dirname(1). [ruby-core:82828] [Bug #13908]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@599...
nobu (Nobuyoshi Nakada)
11:50 AM Revision 65055fe2 (git): common.mk: make bin directory
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59932 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)

09/15/2017

11:46 PM Bug #13906 (Closed): homepage in gemspec
Applied in changeset trunk|r59931.
----------
To use github url for gemspec.
[Bug #13906][ruby-core:82817]
hsbt (Hiroshi SHIBATA)
08:21 PM Bug #13906: homepage in gemspec
I believe Hiroshi Shibata can answer this, he is busy integrating
gems and doing a lot of work on the .gemspec files + bundler
integration by now, I think. :)
I assume that the ruby github page is a secondary mirror site; the
pri...
shevegen (Robert A. Heiler)
04:00 PM Bug #13906 (Closed): homepage in gemspec
Some gemspec files set ruby-lang site instead of github site to homepage.
Is it intentional?
```
% git ls-files '*.gemspec' | xargs grep homepage | grep ruby-lang
ext/io/console/io-console.gemspec: s.homepage = "https://www.ruby-l...
znz (Kazuhiro NISHIYAMA)
11:46 PM Revision 274c6180 (git): To use github url for gemspec.
[Bug #13906][ruby-core:82817]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59931 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
10:36 PM Feature #13904: getter for original information of Enumerator
I agree, I think it's a good idea to expose such information when it is available in #inspect and it is user-provided (not internal). Eregon (Benoit Daloze)
05:33 PM Feature #13904: getter for original information of Enumerator
Super-upvote!
In fact, recently I became rather concerned with a lack of "inspectability" of Ruby's own objects (like "how `#format` would parse this string and what groups it has", or internal structure of Regexp and so on).
zverok (Victor Shepelev)
03:27 PM Feature #13904 (Closed): getter for original information of Enumerator
At https://gitter.im/red-data-tools/ja?at=59b0aaa097cedeb04828e268 ,
mrkn says narray and pycall use internal information of ruby to check `Range#step(n)`.
People of red-data-tools/ja suggest subclass of Enumerator.
But I think it d...
znz (Kazuhiro NISHIYAMA)
08:13 PM Bug #13907: Operation not permitted (Errno::EPERM) when adjusting .irbrc_history file permissions
I am pretty sure that this is a small bug in IRB. It is a method in IRB itself,
so it should be the responsibility of IRB to handle cases like the above
properly.
The method looks like this:
def save_history
if num = I...
shevegen (Robert A. Heiler)
04:49 PM Bug #13907 (Closed): Operation not permitted (Errno::EPERM) when adjusting .irbrc_history file permissions
This is happening every time I close irb on the server:
```
$ bin/rails console
Loading staging environment (Rails 5.1.3)
2.3.0 :001 > IRB.conf[:SAVE_HISTORY]
=> 100
2.3.0 :002 > IRB.conf[:HISTORY_FILE]
=> nil
2.3.0 :003 > IRB....
heaven (Alexander S.)
07:58 PM Bug #13898: Block parsing regression
Just got this error too after an update from 2.4.1 to 2.4.2.
Is this really the correct way to break the syntax in minor updates? I mean, going from 2.4 to 2.5 I might expect some syntax changes, but 2.4.1 to 2.4.2 should not break th...
markus_d (Markus Doits)
02:24 AM Bug #13898 (Rejected): Block parsing regression
nobu (Nobuyoshi Nakada)
07:25 PM Revision 4075d71c (git): ruby-runner.c: reduce duplicate code
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59930 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
07:25 PM Revision 84181a6c (git): Makefile.in: make wrappers for each name
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59929 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
06:47 PM Bug #13902 (Third Party's Issue): test/openssl/test_ocsp.rb にて Segmentation fault
どうやら LibreSSL の問題のようなので upstream に報告しました。
https://github.com/libressl-portable/portable/issues/350
rhenium (Kazuki Yamaguchi)
07:37 AM Bug #13902 (Third Party's Issue): test/openssl/test_ocsp.rb にて Segmentation fault
nmake test-all を走らせると、test/openssl/test_ocsp.rb にて Segmentation fault が起こります。
添付ファイルの 1553 行目からが [BUG] 出力です。
ビルド環境、使用したライブラリは次の通りです。
libressl-2.5.5-windows
zlib-1.2.11
Windows 10 Home 1703, 15063.608
Visual Studio Build Tools 2017,...
Anonymous
05:47 PM Revision 012ed577 (git): fixup r59927
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59928 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
05:42 PM Revision 86888f9c (git): rename ruby-runner as bin/ruby
* Makefile.in, configure.in, tool/runruby.rb: rename ruby-runner
executable file as $(RUBY_INSTALL_NAME) under bin, to mimic
dirty `#!/usr/bin/env` hack.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59927 b2dd03c8-39d4-4d8f-98f...
nobu (Nobuyoshi Nakada)
05:00 PM Feature #13896 (Closed): Find.find -> Use Dir.children instead of Dir.entries
Applied in changeset trunk|r59926.
----------
Find.find -> Use Dir.children instead of Dir.entries
Dir.children is available since Feature #11302.
Find.find can use of the new list (having no '.' neither '..' entries),
making now super...
naruse (Yui NARUSE)
05:00 PM Revision b2996b30 (git): Find.find -> Use Dir.children instead of Dir.entries
Dir.children is available since Feature #11302.
Find.find can use of the new list (having no '.' neither '..' entries),
making now superflous an if statement.
This change can improve the performance of Find.find when the path
has lots o...
naruse (Yui NARUSE)
04:56 PM Revision 40f3c519 (git): Fix test code of kconv
patched by tbpgr <tbpgr@tbpgr.jp>
https://github.com/ruby/ruby/pull/1696 fix GH-1696
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59925 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)
04:53 PM Revision 9708af66 (git): * 2017-09-16
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59924 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:53 PM Revision 16225d82 (git): include query parameters in Net::HTTP.post
patched by Samuel Giddins <segiddins@segiddins.me>
https://github.com/ruby/ruby/pull/1686 fix GH-1686
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59923 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)
04:38 PM Bug #13887: test/ruby/test_io.rb may get stuck with FIBER_USE_NATIVE=0 on Linux
I guess `cont->machine.stack_src` should not contain the under thread_start_func_1() stack.
Because this area will be used and overwritten by pthread, especially stack_list_{add,del} in nptl/allocatestack.c.
If cont_restore_1() copies ...
wanabe (_ wanabe)
04:31 PM Feature #12753: Useful operator to check bit-flag is true or false
How about `bitmask_test?` or `bitflag_test?`
shugo (Shugo Maeda) wrote:
> Shugo Maeda wrote:
> ...
tagomoris (Satoshi Tagomori)
04:08 PM Feature #13821: Allow fibers to be resumed across threads
I took a look at the C++ Boost library boost::fiber documentation. It allows fibers to be detached/attached between threads. Perhaps an explicit API like this is a better approach? See here: http://www.boost.org/doc/libs/1_62_0/libs/fibe... cremes (Chuck Remes)
01:40 PM Feature #13821: Allow fibers to be resumed across threads
Yes, the Fiber.new(migrate: true) would mean the programmer is taking responsibility for NOT wrapping that Fiber up in mutexes or relying on the default behavior. I think this is reasonable.
As for the async/await code I've written, i...
cremes (Chuck Remes)
03:56 PM Bug #13905 (Rejected): files in gemspec
ext/zlib/zlib.gemspec の files をみると ext/zlib/extconf.rb のような top_srcdir からの相対パスらしき指定と gemspec からの相対パスらしき(upstreamでのパス?) zlib.gemspec のようなものが混在しているように見えます。
top_srcdir からの相対パスが正しいのなら ext/zlib がついていないファイルを指しているのはおかしいし、 gemspec ファイルからの相対パス...
znz (Kazuhiro NISHIYAMA)
03:25 PM Bug #13903: cant compile ruby with /MT on windows
Just for curiosity, ruby 2.4.x works for you on windows if you compile it? shevegen (Robert A. Heiler)
11:57 AM Bug #13903 (Closed): cant compile ruby with /MT on windows
steps:
1. open VS2015 x86 Native Tools Command Prompt
2. follow instructions in https://github.com/ruby/ruby/blob/trunk/win32/README.win32
most of the compilation completes including producing .lib files, but nmake finally errors ...
rocifier (Ryan O'Connor)
02:11 PM Feature #5588 (Closed): add negation flag (v) to Regexp
naruse (Yui NARUSE)
01:12 PM Bug #13892: Matching the end of a string followed by an empty greedy regex and a word boundary (.*\b) fails in all versions >= 1.9
@naruse, k-takata -
Testing with Onigmo, Oniguruma, and php's mb_ereg() this case does indeed fail to match, though based on my understanding of this particular pattern (and all of the other regex implementations cited), it should mat...
jhriggs (Jim Riggs)
12:07 PM Bug #13892: Matching the end of a string followed by an empty greedy regex and a word boundary (.*\b) fails in all versions >= 1.9
@naruse -
You might be right. I (shamefully) did not investigate what regex library Ruby is using under the hood. Sorry.
I will do some testing with the upstream code to see if the problem lies there or in Ruby. If there, I will cr...
jhriggs (Jim Riggs)
06:18 AM Bug #13892: Matching the end of a string followed by an empty greedy regex and a word boundary (.*\b) fails in all versions >= 1.9
As far as I understand, this is intentional behavior of Oniguruma (Onigmo), which Ruby uses.
How do you think, k-takata?
naruse (Yui NARUSE)
12:03 PM Revision 743ab3c7 (git): Fix typos [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59922 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
12:03 PM Revision dd3b3dd0 (git): Remove needless splat array
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59921 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
09:32 AM Bug #13772: Memory leak recycling stacks for threads in 2.4.1
Thanks a lot, great news! perlun (Per Lundberg)
08:47 AM Revision f2234542 (git): parse.y: use SET_LEX_STATE
* parse.y (f_arglist, parser_yylex): set lex_state via
SET_LEX_STATE macro for yydebug messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59920 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
08:13 AM Bug #13856: MinGW / mswin intermittent failure in test/socket/test_socket.rb
Segmentation fault is caused by `RBASIC_CLASS(err)` access in hook_before_rewind() in vm.c:1667.
`err` is not a valid pointer.
Here is gdb output.
~~~
Run options: "--ruby=./miniruby.exe -I../snapshot/lib -I. -I.ext/common ../sn...
h.shirosaki (Hiroshi Shirosaki)
06:53 AM Bug #13900 (Closed): Segmentation fault - 2 different machines
As nobu wrote, this issue is already fixed.
You can avoid this by upgrading Ruby to 2.3.5 or 2.4.2.
naruse (Yui NARUSE)
03:37 AM Bug #13900 (Closed): Segmentation fault - 2 different machines
The same error appears systematically - on two different installs of Ruby 2.3.1
A/ Ubuntu 16.04 in Windows10 WSL
B/ Bodhi 4.3.1 on a virtualBOx Windows 10 host.
I followed the message at the end inviting me to report a bug. H...
marmotteNZ (pierre lonchampt)
06:23 AM Feature #13901 (Closed): Add branch coverage
I plan to add "branch coverage" (and "method coverage") as new target types of coverage.so, the coverage measurement library. I'd like to introduce this feature for Ruby 2.5.0. Let me to hear your opinions.
## Basic Usage of the Cov...
mame (Yusuke Endoh)
05:16 AM Bug #9891 (Closed): infinite fibers crash Ruby
Thank you for your confirmation. ko1 (Koichi Sasada)
02:45 AM Bug #13882 (Assigned): Exception in `ensure` stops threads from exiting
ko1 (Koichi Sasada)
02:27 AM Bug #11174: threads memory leak
Sorry I missed it. ko1 (Koichi Sasada)
02:01 AM Revision 581be44e (git): object.c: fix conversion failure message
* object.c (convert_type_with_id): fix failure message for
explicit conversion. rb_convert_type_with_id and
rb_check_convert_type_with_id are not only for implicit
conversions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59...
nobu (Nobuyoshi Nakada)
12:59 AM Revision 92e3ffdf (git): rubyspec: jobserver fd may not be available
* spec/rubyspec/optional/capi/spec_helper.rb (compile_extension):
rescue possible EBADF as jobserver fd may not be available.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59918 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:59 AM Revision 3ce856a6 (git): rubyspec: use mock directory
* spec/rubyspec/core/dir/mkdir_spec.rb: the source directory may
be on a read-only filesystem.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:59 AM Revision 39483722 (git): rubyspec: fix types
* spec/rubyspec/optional/capi/ext/fixnum_spec.c: FIX2INT and
FXI2UINT return long, in spite of their names.
* spec/rubyspec/optional/capi/ext/range_spec.c: err is int.
* spec/rubyspec/optional/capi/ext/st_spec.c: st_index_t is larger...
nobu (Nobuyoshi Nakada)
12:40 AM Revision c7fa2bf5 (git): ext/coverage/coverage.c (rb_coverage_start): Ensure `opt` is a hash
Ensure `opt` is a hash before using `rb_hash_lookup` to `opt`.
This will prevent SEGV when an inappropriate object (i.e. an array)
is passed to `opt`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59915 b2dd03c8-39d4-4d8f-98ff-823fe...
yui-knk (Kaneko Yuichiro)

09/14/2017

10:34 PM Bug #13899 (Closed): Ruby 2.4.2 and 2.3.5 cannot link with libgmp nor jemalloc
The released package of Ruby 2.4.2 and 2.3.5 cannot link with libgmp nor jemalloc.
Then, I provide the fixes.
for Ruby 2.4.2:
a. Override `configure` file in your package by `configure-2.4.2`, and run `configure`.
b. Or, apply ...
usa (Usaku NAKAMURA)
10:22 PM Bug #13402: [PATCH] fix --with-gmp (broken by r57490)
ruby_2_4 r59914 merged revision(s) 58254. nagachika (Tomoyuki Chikanaga)
08:41 PM Bug #13402: [PATCH] fix --with-gmp (broken by r57490)
ruby_2_3 r59912 merged revision(s) 58254. usa (Usaku NAKAMURA)
10:22 PM Revision edda7925 (git): merge revision(s) 58254: [Backport #13402]
fix --with-gmp (broken by r57490)
Looking at the generated shell script (also the autoconf manual), it
seems AC_SEARCH_LIBS() m4 macro does not define HAVE_LIBsomething C
preprocessor macros, unlike AC_CHECK_LIB(...
nagachika (Tomoyuki Chikanaga)
10:21 PM Revision ac74cb6b (git): bump up teeny version to 2.4.3.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59913 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nagachika (Tomoyuki Chikanaga)
09:21 PM Bug #13898: Block parsing regression
`let(:foo) { nil }` and `let :foo do nil end` (and `let(:foo) do nil end`) works. tt (Troels Thomsen)
09:18 PM Bug #13898 (Rejected): Block parsing regression
Upgrading to Ruby 2.4.2p198 from Ruby 2.4.1p111 introduces the following regression:
irb(main):001:0> def let(x, &b); end
=> :let
irb(main):002:0> let :foo { nil }
SyntaxError: (irb):2: syntax error, unexpected '{',...
tt (Troels Thomsen)
08:41 PM Revision 463a56d1 (git): merge revision(s) 58254: [Backport #13402]
fix --with-gmp (broken by r57490)
Looking at the generated shell script (also the autoconf manual), it
seems AC_SEARCH_LIBS() m4 macro does not define HAVE_LIBsomething C
preprocessor macros, unlike AC_CHECK_LIB(...
U.Nakamura
06:53 PM Bug #13790 (Closed): rubyspec.org domain seems to be expired
This is fixed as of r59911
There is still one instance in 1.9.3's ChangeLog but it seems harmless.
$ git grep rubyspec.org
doc/ChangeLog-1.9.3: http://rubyspec.org/issues/show/161
Eregon (Benoit Daloze)
12:58 PM Bug #13790: rubyspec.org domain seems to be expired
In spec/rubyspec/library/net/http/http/send_request_spec.rb, it's only the referer value in the headers.
The request are sent to a local WEBrick server.
Eregon (Benoit Daloze)
12:05 PM Bug #13790: rubyspec.org domain seems to be expired
Re spec/mspec/mspec.gemspec, actually https://github.com/ruby/mspec is no longer distributed as a gem, the file has been removed.
I'll do the usual ruby/spec and ruby/mspec synchronization so this one will be fixed by it.
Eregon (Benoit Daloze)
09:02 AM Bug #13790: rubyspec.org domain seems to be expired
Thanks for the report, I'll take a look.
http://ruby.github.io/rubyspec.github.io/ has similar contents to what rubyspec.org hosted but it's not really maintained.
I think we should replace the links with a link to https://github.c...
Eregon (Benoit Daloze)
06:12 AM Bug #13790: rubyspec.org domain seems to be expired
If we need to send real request to internet I suggest to use HTTPBin.org
https://httpbin.org/
Also, with HTTPBin we can un-comment all the other methods currently not tested (PUT, POST, DELETE, etc).
HTH.
---------------
E...
esparta (Espartaco Palma)
05:38 PM Bug #12670: Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
nagachika (Tomoyuki Chikanaga) wrote:
> ruby_2_4 r59302 merged revision(s) 56558,59116,59136.
Can confirm bug is fixed.
Checked again with attached Dockerfile
Bug reproduced on:
v2_4_1
v2_3_4
v2_2_8
Bug fixed on:
v2_4_2
v2...
ShockwaveNN (Pavel Lobashov)
05:31 PM Bug #13772: Memory leak recycling stacks for threads in 2.4.1
perlun (Per Lundberg) wrote:
> This bug unfortunately prevents my organization from using 2.4.1 at the moment, we will have to downgrade to 2.3.4. Is there any chance we could get a bug fix release (2.4.2) out including this fix, in the...
jrafanie (Joe Rafaniello)
05:02 PM Feature #13893: Add Fiber#[] and Fiber#[]= and restore Thread#[] and Thread#[]= to their original behavior
Ideally some of these changes could be rolled out in 2.x versions with deprecation notices for those methods whose behavior will change or those methods will be eliminated. For the 3.0 release, the deprecated methods should be removed en... cremes (Chuck Remes)
11:36 AM Feature #13893: Add Fiber#[] and Fiber#[]= and restore Thread#[] and Thread#[]= to their original behavior
I have nothing against the suggestion itself. However, there is no general, universal "Principal of Least Surprise".
To the topic, Threads and Fibers - I have used Threads sometimes but rarely. I haven't yet used Fibers. Without knowi...
shevegen (Robert A. Heiler)
03:56 PM Revision 6479a016 (git): Update to ruby/spec@a4bc1d8
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59911 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
03:56 PM Revision 938465be (git): * 2017-09-15
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:56 PM Revision 49a864ad (git): Update to ruby/mspec@5bd9409
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59909 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
03:32 PM Bug #13897 (Closed): libffi is now not bundled in snapshots
いつ頃からかは明確ではないのですが、trunkのmake-snapshotでlibffiがバンドルされなくなっています。
これは先ほどの安定版リリース作業中に発覚したのですが、libffiをダウンロードはしてくるものの、extractが行われていないようです。
リリースされたtarballの方は近永さんがどうにかしてくださいましたが、snapshot.tar.gzおよびstable-snapshot.tar.gzにもやはり同様にlibffiがバンドルされていないこと...
usa (Usaku NAKAMURA)
02:54 PM Revision 3efe410d (git): time.c (Time#-): Fix documentation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59908 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
02:32 PM Revision ea73cb5c (git): * version.h: bump to 2.3.6.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e U.Nakamura
01:56 PM Feature #13666: Development: Writing test code for new features/bug fixes can be done as specs under spec/rubyspec instead of tests under test/
Awesome!
This should make writing specs in MRI possible without duplicated work,
and at the same time make other Ruby implementations benefit greatly from it.
I see @nobu already showed the example with https://github.com/ruby/rub...
Eregon (Benoit Daloze)
12:01 PM Misc #13792: Rename spec/rubyspec to spec/ruby
It sounds good to me.
I am not aware of technical problems with the current name, but it is inconsistent.
Should I do it?
Or do you want to perform the rename?
Eregon (Benoit Daloze)
11:44 AM Revision d629ce0b (git): * ext/json: bump to version 1.8.1.1. [Backport #13853]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@59904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e U.Nakamura
11:41 AM Revision 5450329a (git): asn1: fix out-of-bounds read in decoding constructed objects
* OpenSSL::ASN1.{decode,decode_all,traverse}: have a bug of
out-of-bounds read. int_ossl_asn1_decode0_cons() does not give the
correct available length to ossl_asn1_decode() when decoding the
inner components of a constructed objec...
U.Nakamura
11:40 AM Bug #13885: Random.urandom と securerandom について
特に反対もなかったので、nil を返すのではなく RuntimeError を投げるようにしました(r59858)。
残るはシステムコールをループする点だけですが、
> それってO_NBLOCKのディスクリプタをビジーループで読み込みってことですよね。ユーザーランドからへんにビジーループするよりカーネル側で適切に生成されてくるのをユーザーランド側はすなおにブロッキングIOしたほうがトータルのコンテキストスイッチが少なそうな気がするんですが、まあ気がするだけで...
mame (Yusuke Endoh)
11:37 AM Revision 8a81d04d (git): merge revision(s) 59897:
lib/webrick/log.rb: sanitize any type of logs
It had failed to sanitize some type of exception messages. Reported and
patched by Yusuke Endoh (mame) at https://hackerone.com/reports/223363
git-svn-id: svn+ssh://ci.ruby...
U.Nakamura
11:35 AM Revision 4fdfb28e (git): merge revision(s) 58453,58454: [Backport #13499]
Fix space flag when Inf/NaN and width==3
* sprintf.c (rb_str_format): while `"% 2f"` and `"% 4f"` result in
`" Inf"` and `" Inf"` respectively, `"% 3f"` results in
`"Inf"` (no space).
Refactor "%f" % ...
U.Nakamura
11:26 AM Revision 3896b486 (git): merge revision(s) 59897:
lib/webrick/log.rb: sanitize any type of logs
It had failed to sanitize some type of exception messages. Reported and
patched by Yusuke Endoh (mame) at https://hackerone.com/reports/223363
git-svn-id: svn+ssh://ci.ruby...
U.Nakamura
11:24 AM Revision dead0efd (git): merge revision(s) 59897:
lib/webrick/log.rb: sanitize any type of logs
It had failed to sanitize some type of exception messages. Reported and
patched by Yusuke Endoh (mame) at https://hackerone.com/reports/223363
git-svn-id: svn+ssh://ci.ruby...
nagachika (Tomoyuki Chikanaga)
11:16 AM Revision 6617c412 (git): lib/webrick/log.rb: sanitize any type of logs
It had failed to sanitize some type of exception messages. Reported and
patched by Yusuke Endoh (mame) at https://hackerone.com/reports/223363
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mame (Yusuke Endoh)
10:53 AM Feature #13686 (Closed): Add states of scanner to tokens from Ripper.lex and Ripper::Filter#on_*
Applied in changeset trunk|r59896.
----------
ripper: add states of scanner
* parse.y (ripper_state): add states of scanner to tokens from
Ripper.lex and Ripper::Filter#on_*. based on the patch by
aycabta (Code Ahss) at [ruby-core...
nobu (Nobuyoshi Nakada)
10:53 AM Revision 7df1e45b (git): ripper: add states of scanner
* parse.y (ripper_state): add states of scanner to tokens from
Ripper.lex and Ripper::Filter#on_*. based on the patch by
aycabta (Code Ahss) at [ruby-core:81789]. [Feature #13686]
* ext/ripper/tools/preproc.rb (prelude, usercode):...
nobu (Nobuyoshi Nakada)
10:49 AM Revision a61ae940 (git): parse.y: [DOC] fix call-seq [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59895 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
10:45 AM Revision b324a649 (git): ext/coverage/coverage.c: use long instead of int for coverage site id
Coverage generates unique ID numbers for each branch and each method.
Use long instead of int for the IDs. I don't want to see 2^32 branches
and methods in one file, but just in case...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk...
mame (Yusuke Endoh)
09:21 AM Bug #13895 (Closed): TestVMDump test fails on High Sierra
Applied in changeset trunk|r59893.
----------
fix the case High Sierra's mincore(2) may return -128 [Bug #13895]
naruse (Yui NARUSE)
05:45 AM Bug #13895 (Closed): TestVMDump test fails on High Sierra
TestVMDump#test_darwin_invalid_call fails with `Timeout::Error`
I can reproduce with `ruby -rfiddle -e "Fiddle::Function.new(Fiddle::Pointer.new(1), [], Fiddle::TYPE_VOID).call"`.
After that backtrace was stopped "C level backtrace i...
hsbt (Hiroshi SHIBATA)
09:21 AM Revision fff6809b (git): fix the case High Sierra's mincore(2) may return -128 [Bug #13895]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59893 b2dd03c8-39d4-4d8f-98ff-823fe69b080e naruse (Yui NARUSE)
09:07 AM Feature #11302: Dir.entries and Dir.foreach without [".", ".."]
The decision here is surprising given https://bugs.ruby-lang.org/issues/13789#note-3
but nevertheless I'm very happy this got accepted.
Eregon (Benoit Daloze)
08:23 AM Bug #13887: test/ruby/test_io.rb may get stuck with FIBER_USE_NATIVE=0 on Linux
Another reproduction code is here.
```
10.times do |i|
p i
t = Thread.new { Fiber.new { sleep }.resume }
Thread.new {}.join
t.run.join
end
```
wanabe (_ wanabe)
08:04 AM Revision ea49381e (git): compile.c: iseq_pop_newarray
* compile.c (iseq_pop_newarray): optimize array literal in
condition.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59892 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
07:45 AM Revision db9f36f3 (git): ext/coverage/coverage.c (method_coverage): `id` was used uninitialized
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59891 b2dd03c8-39d4-4d8f-98ff-823fe69b080e mame (Yusuke Endoh)
06:32 AM Feature #13896 (Closed): Find.find -> Use Dir.children instead of Dir.entries
Dir.children is available since Feature #11302. Find.find can
use of the new list (having no '.' neither '..' entries), making
now superflous an if statement.
This change can improve the performance of Find.find when the path
has l...
esparta (Espartaco Palma)
06:07 AM Revision e43f3044 (git): Measure branch and method coverage for `make test-all`
To measure coverage of C code:
`./configure --enable-gcov && make && make exam && make lcov`
To measure coverage of Ruby code:
`./configure && make && make exam COVERAGE=true && make lcov`
To measure coverage of both languages at a tim...
mame (Yusuke Endoh)
05:27 AM Revision 3c8c17d3 (git): Introduce NODE_UNLESS for branch coverage
`unless` statement was a syntactic sugar for `if` statement,
which made the result of branch coverage hard to understand.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mame (Yusuke Endoh)
05:12 AM Revision 78cf4607 (git): Add method coverage
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59888 b2dd03c8-39d4-4d8f-98ff-823fe69b080e mame (Yusuke Endoh)
05:04 AM Bug #13816 (Closed): APFS Issue with High Sierra
Applied in changeset trunk|r59887.
----------
added workaround for APFS file format.
* TestFileExhaustive#test_atime: It fails with nano-sec precise.
I changed to use unixtime for this assertion for APFS.
* TestFileExhaustive#t...
hsbt (Hiroshi SHIBATA)
05:04 AM Revision a5641cdf (git): added workaround for APFS file format.
* TestFileExhaustive#test_atime: It fails with nano-sec precise.
I changed to use unixtime for this assertion for APFS.
* TestFileExhaustive#test_expand_path: skip assertion when given
invalid charactor on APFS.
[Bug #13816]...
hsbt (Hiroshi SHIBATA)
04:42 AM Revision 3155da02 (git): Fix the lineno of case statement that has no expression
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e mame (Yusuke Endoh)
04:32 AM Bug #13756: tDSTAR inside of defined causes [BUG]
ruby_2_3 r59884 merged revision(s) 59375. usa (Usaku NAKAMURA)
04:32 AM Revision 1f7abf72 (git): Add branch coverage for case-when statement
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59885 b2dd03c8-39d4-4d8f-98ff-823fe69b080e mame (Yusuke Endoh)
04:32 AM Revision ac6f2894 (git): merge revision(s) 59375: [Backport #13756]
parse.y: empty hash in defined
* parse.y (command): NODE_ARRAY with NULL is invalid. traversal
in defined_expr0 is simplified than iseq_compile_each0.
[ruby-core:82113] [Bug #13756]
git-svn-id: svn+ssh://ci...
U.Nakamura
04:31 AM Bug #13874: String#valid_encoding? has side effects
ruby_2_3 r59883 merged revision(s) 59763. usa (Usaku NAKAMURA)
04:31 AM Revision 04667398 (git): merge revision(s) 59763: [Backport #13874]
string.c: fix false coderange
* string.c (rb_enc_str_scrub): enc can differ from the actual
encoding of the string, the cached coderange is useless then.
[ruby-core:82674] [Bug #13874]
git-svn-id: svn+ssh://...
U.Nakamura
04:26 AM Revision fdeb8dc2 (git): * ChangeLog: forgotten entries for r59880 and r59881.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e U.Nakamura
04:21 AM Bug #13836: Null pointer dereference in defined_expr0()
ruby_2_3 r59881 merged revision(s) 59644. usa (Usaku NAKAMURA)
04:21 AM Revision 9b3e0ca6 (git): merge revision(s) 59644: [Backport #13836]
parse.y: primary should not be 0
* parse.y (primary): should not be 0, since it can be a receiver.
[ruby-core:82447] [Bug #13836]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59881 b2dd03c8-39d4-4d8f-...
U.Nakamura
04:19 AM Bug #13817: test/unit breaks Hash
ruby_2_3 r59880 merged revision(s) 59613. usa (Usaku NAKAMURA)
04:19 AM Revision ddda4baf (git): merge revision(s) 59613: [Backport #13817]
vm_method.c: alias warning at refined method
* vm_method.c (rb_method_entry_make): suppress a warning at
refined method which will not be redefined.
[ruby-core:82385] [Bug #13817]
git-svn-id: svn+ssh://ci.ru...
U.Nakamura
04:16 AM Revision 95c9c1dc (git): * ext/bigdecimal/bigdecimal.c (BigDecimal_hash): st_index_t may not be
fixable on 64bit mswin/mingw.
* ext/date/date_core.c (d_lite_hash): ditto.
[Backport #13877]
* ext/openssl/ossl_bn.c (ossl_bn_hash): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59879 b2dd03c8-39d4-4d8f-98ff...
U.Nakamura
03:57 AM Revision c4a64b73 (git): Removed needless operator.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
03:36 AM Revision 16ab236b (git): Add branch coverage for while and until statements
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e mame (Yusuke Endoh)
03:25 AM Revision ce570370 (git): Add branch coverage for if statement
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e mame (Yusuke Endoh)
02:53 AM Revision c171ca1e (git): ext/coverage/coverage.c: Fix the condition for non-experimental mode
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e mame (Yusuke Endoh)
02:36 AM Revision 68394b27 (git): [EXPERIMENTAL] Extend the API of `Coverage.start` and `result`
The old API:
Coverage.start
load "foo.rb"
p Coverage.result #=> {"foo.rb" => [1, 2, nil]}
The new API:
ENV["COVERAGE_EXPERIMENTAL_MODE"] = "true"
Coverage.start(lines: true)
load "foo.rb"
p Coverage.result ...
mame (Yusuke Endoh)
02:09 AM Bug #13642: MinGW - Bug::Win32::TestDln#test_check_imported & misc
h.shirosaki (Hiroshi Shirosaki) wrote:
> `RbConfig::CONFIG["PATH_SEPARATOR"]` is `:` which is separator on msys2 shell building ruby.
> ...
Indeed, could you commit it?
nobu (Nobuyoshi Nakada)
02:01 AM Revision 4d5c414f (git): Update gemspec for gem released versions.
* These are dbm, fcntl, io-console, sdbm, stringio, strscan, zlib,
cmath, scanf.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
02:00 AM Bug #9891: infinite fibers crash Ruby
Hello again. I reported this bug 3 years ago. I'm happy to report that I can't reproduce this bug with recent Ruby trunk,
```
$ ruby -v
ruby 2.5.0dev (2017-09-11 trunk 59840) [x86_64-openbsd6.1]
```
In recent days, I wrote some ...
kernigh (George Koehler)
01:55 AM Revision 9ea2102e (git): remove an unused variable (sometimes it fails test).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59872 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ko1 (Koichi Sasada)
01:55 AM Revision d1b290d5 (git): Add a new instruction `trace2` for hooking with custom data
This is needed for passing to the hook function the measuring target
type (line/branch/method) and the site of coverage event fired.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59871 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mame (Yusuke Endoh)

09/13/2017

11:38 PM Bug #10222: require_relative and require should be compatible with each other when symlinks are used
Akira, in those cases was the basename different among the real path and the symlink? rosenfeld (Rodrigo Rosenfeld Rosas)
11:35 PM Bug #10222: require_relative and require should be compatible with each other when symlinks are used
Here's an actual use case that we saw in Rails: https://github.com/rails/rails/pull/29638#issuecomment-321335175
The reporter says that it happened in Jenkins, but I guess the same situation may happen in any case where we put the .rb f...
matsuda (Akira Matsuda)
03:29 PM Bug #10222: require_relative and require should be compatible with each other when symlinks are used
I see, what you mean, if we simply add the expanded filenames to LOADED_PATH then that file would be loaded just once. Do you have any use cases where someone would symlink Ruby code for good usage? rosenfeld (Rodrigo Rosenfeld Rosas)
03:27 PM Bug #10222: require_relative and require should be compatible with each other when symlinks are used
I'd expect b.rb and c.rb to be handled like separate files, so "b loaded" would be printed twice. rosenfeld (Rodrigo Rosenfeld Rosas)
02:45 PM Bug #10222: require_relative and require should be compatible with each other when symlinks are used
Would you expect just directory names get expanded?
Or basename too?
For instance, 'b loaded' should be printed twice or just once,?
```
mkdir a
echo "p 'b loaded'" > a/b.rb
ln -s b.rb a/c.rb
ruby -I./a -ra -rb -e''
```
nobu (Nobuyoshi Nakada)
05:07 PM Bug #13569 (Closed): Windows - TestRubyOptions#test_search - append to paths instead of replacing
Applied in changeset trunk|r59870.
----------
test_rubyoptions.rb: keep paths if necessary
* test/ruby/test_rubyoptions.rb (TestRubyOptions#test_search):
PATH must keep library loading paths on a platform where it is
used for that ...
nobu (Nobuyoshi Nakada)
03:06 AM Bug #13569: Windows - TestRubyOptions#test_search - append to paths instead of replacing
My MinGW builds are very similar to rubyinstaller2 builds, and they also use a manifest. They use the rubyinstaller2 runtime.
Speaking of copying files, I do copy a file for another test, but I didn't note which test it affected...
...
MSP-Greg (Greg L)
02:42 AM Bug #13569: Windows - TestRubyOptions#test_search - append to paths instead of replacing
I can reproduce this with msys2 build.
miniruby.exe and ruby.exe have dependency to libgmp-10.dll.
So path which contains libgmp-10.dll is needed to PATH environment variable.
I can avoid the issue by copying libgmp-10.dll to curren...
h.shirosaki (Hiroshi Shirosaki)
05:07 PM Revision a4eedafb (git): test_rubyoptions.rb: keep paths if necessary
* test/ruby/test_rubyoptions.rb (TestRubyOptions#test_search):
PATH must keep library loading paths on a platform where it is
used for that purpose, for extra libraries.
[ruby-core:81178] [Bug #13569] [Fix GH-1616]
git-svn-id: svn...
nobu (Nobuyoshi Nakada)
03:28 PM Revision e1ada191 (git): * 2017-09-14
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59869 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:28 PM Revision 56c61b5c (git): LIBPATHENV on Windows
* configure.in, win32/Makefile.sub: set LIBPATHENV to PATH on
Windows, for extra DLLs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:54 PM Bug #13894: win32ole/test_word.rb sometimes not quit Word
I don't recall having this issue in my builds, but with the patch, I have quite a few warnings. I could file a separate bug report. Try:
```
ruby -v -rwin32ole -e "module Word ; end ; w = WIN32OLE.new('Word.Application') ; WIN32OLE...
MSP-Greg (Greg L)
01:25 PM Bug #13894 (Closed): win32ole/test_word.rb sometimes not quit Word
Applied in changeset trunk|r59867.
----------
test/win32ole/test_word.rb: word quit without confirmation dialog to save
files. [Bug #13894] Thanks to h.shirosaki.
suke (Masaki Suketa)
07:47 AM Bug #13894 (Closed): win32ole/test_word.rb sometimes not quit Word
When I run test-all, Word does not quit sometimes and Word opens confirm dialog to save files.
I have to close Word manually.
I think that `w.quit(Word::WdDoNotSaveChanges)` may be better to quit word.
```patch
diff --git a/test/...
h.shirosaki (Hiroshi Shirosaki)
01:37 PM Bug #13642: MinGW - Bug::Win32::TestDln#test_check_imported & misc
Thanks for reviewing. Added the patch, removed my copy command, and test passed in `make test-all`.
Maybe change
```
path = ::File.dirname(so) + ::File::PATH_SEPARATOR + path
```
to
```
path = path + ::File::PATH_SEPARATOR + ::...
MSP-Greg (Greg L)
07:22 AM Bug #13642: MinGW - Bug::Win32::TestDln#test_check_imported & misc
`RbConfig::CONFIG["PATH_SEPARATOR"]` is `:` which is separator on msys2 shell building ruby.
Should we use `File::PATH_SEPARATOR` `;` on test?
~~~patch
diff --git a/test/-ext-/win32/test_dln.rb b/test/-ext-/win32/test_dln.rb
index ...
h.shirosaki (Hiroshi Shirosaki)
01:24 PM Revision f1064697 (git): test/win32ole/test_word.rb: word quit without confirmation dialog to save
files. [Bug #13894] Thanks to h.shirosaki.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59867 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
suke (Masaki Suketa)
12:46 PM Revision 51de1548 (git): Random.urandom raises RuntimeError instead of returning nil
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59866 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
znz (Kazuhiro NISHIYAMA)
09:06 AM Revision a8c63297 (git): Removed needless magic-comment for encodings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
09:06 AM Revision 6336b394 (git): Fixup r59856. Added workaround for JRuby.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
02:36 AM Revision 71f98748 (git): Added executable to bundler template.
It's same as upstream permission.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
02:21 AM Revision 3fbd9d7e (git): Fix a typo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
 

Also available in: Atom