Activity
From 09/10/2017 to 09/16/2017
09/16/2017
- 10:40 PM Revision 08adad00 (git): * 2017-09-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59936 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:40 PM Revision 1241d59c (git): test_fileutils.rb: rmdir should fail on nonexistent directory
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59935 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:16 PM Bug #13903: cant compile ruby with /MT on windows
- I'm not that familiar with MS build tools, but I think ruby is building with this file - [appveyor.yml](https://github.com/MSP-Greg/ruby/blob/appveyor140/appveyor.yml), which I believe is using 140. Test results [here](https://ci.appvey...
-
05:02 AM Bug #13903: cant compile ruby with /MT on windows
- shevegen (Robert A. Heiler) wrote:
> Just for curiosity, ruby 2.4.x works for you on windows if you compile it?
I got both versions to build easily with an old VS2010 command prompt, but I still get the __imp__ errors when I link to ... -
- shevegen (Robert A. Heiler) wrote:
> Just for curiosity, ruby 2.4.x works for you on windows if you compile it?
Hi, exactly the same errors for ruby_2_4 branch.
My goal is to link to the produced static library, so I supposed I ne... -
02:47 PM Bug #13163: Uncaught exceptions may not be reported when Thread#report_on_exception=true and Thread#abort_on_exception=true
- +1
The patch looks good.
The message of the assert_warn should be changed though. -
- Isn't this a bug?
https://github.com/nobu/ruby/tree/bug/13163-report-before-abort-on-exception -
02:31 PM Bug #13889 (Open): FileUtils.rmdir が Errno::ENOTEMPTY を無視している
- r59934 の変更で parent で親ディレクトリに遡っている時以外は Errno::ENOTEMPTY を無視しないように変更したようです(従ってドキュメントの ENOTEMPTY の記述の削除は戻したほうがいいかも?)。しかし存在しない名前を FileUtils.rmdir に指定した時にエラーにならなかったのが Errno::ENOENT が発生するなるようになってしまっているようです。
~~~
% ./ruby -r fileutils -e 'Fi... -
- Applied in changeset trunk|r59934.
----------
fileutils.rb: error at rmdir
* lib/fileutils.rb (rmdir): should not ignore errors first, except
for parent directories. [ruby-dev:50236] [Bug #13889] -
- * lib/fileutils.rb (rmdir): should not ignore errors first, except
for parent directories. [ruby-dev:50236] [Bug #13889]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59934 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59933.
----------
file.c: [DOC] separators at dirname and basename
* file.c (rb_file_s_basename, rb_file_s_dirname): [DOC] state
that trailing separators will be stripped first, like as
basename(1) and d... -
- davemyron (Dave Myron) wrote:
> Given `File.dirname("/some/folder/")` the result of `/some` is very surprising because the path is "obviously" a directory without a file specified. (I got bit by this today… yes, I needed more tests)
> ... -
04:14 AM Bug #13908 (Closed): Result of Pathname#dirname / File.dirname handling of paths with trailing File::SEPARATOR is surprising
- Given `File.dirname("/some/folder/")` the result of `/some` is very surprising because the path is "obviously" a directory without a file specified. (I got bit by this today… yes, I needed more tests)
My expectation was that it would ... -
- * file.c (rb_file_s_basename, rb_file_s_dirname): [DOC] state
that trailing separators will be stripped first, like as
basename(1) and dirname(1). [ruby-core:82828] [Bug #13908]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@599... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59932 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/15/2017
-
11:46 PM Bug #13906 (Closed): homepage in gemspec
- Applied in changeset trunk|r59931.
----------
To use github url for gemspec.
[Bug #13906][ruby-core:82817] -
08:21 PM Bug #13906: homepage in gemspec
- I believe Hiroshi Shibata can answer this, he is busy integrating
gems and doing a lot of work on the .gemspec files + bundler
integration by now, I think. :)
I assume that the ruby github page is a secondary mirror site; the
pri... -
04:00 PM Bug #13906 (Closed): homepage in gemspec
- Some gemspec files set ruby-lang site instead of github site to homepage.
Is it intentional?
```
% git ls-files '*.gemspec' | xargs grep homepage | grep ruby-lang
ext/io/console/io-console.gemspec: s.homepage = "https://www.ruby-l... -
- [Bug #13906][ruby-core:82817]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59931 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I agree, I think it's a good idea to expose such information when it is available in #inspect and it is user-provided (not internal).
-
05:33 PM Feature #13904: getter for original information of Enumerator
- Super-upvote!
In fact, recently I became rather concerned with a lack of "inspectability" of Ruby's own objects (like "how `#format` would parse this string and what groups it has", or internal structure of Regexp and so on). -
- At https://gitter.im/red-data-tools/ja?at=59b0aaa097cedeb04828e268 ,
mrkn says narray and pycall use internal information of ruby to check `Range#step(n)`.
People of red-data-tools/ja suggest subclass of Enumerator.
But I think it d... -
- I am pretty sure that this is a small bug in IRB. It is a method in IRB itself,
so it should be the responsibility of IRB to handle cases like the above
properly.
The method looks like this:
def save_history
if num = I... -
04:49 PM Bug #13907 (Closed): Operation not permitted (Errno::EPERM) when adjusting .irbrc_history file permissions
- This is happening every time I close irb on the server:
```
$ bin/rails console
Loading staging environment (Rails 5.1.3)
2.3.0 :001 > IRB.conf[:SAVE_HISTORY]
=> 100
2.3.0 :002 > IRB.conf[:HISTORY_FILE]
=> nil
2.3.0 :003 > IRB.... -
07:58 PM Bug #13898: Block parsing regression
- Just got this error too after an update from 2.4.1 to 2.4.2.
Is this really the correct way to break the syntax in minor updates? I mean, going from 2.4 to 2.5 I might expect some syntax changes, but 2.4.1 to 2.4.2 should not break th... -
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59930 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59929 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:47 PM Bug #13902 (Third Party's Issue): test/openssl/test_ocsp.rb にて Segmentation fault
- どうやら LibreSSL の問題のようなので upstream に報告しました。
https://github.com/libressl-portable/portable/issues/350 -
07:37 AM Bug #13902 (Third Party's Issue): test/openssl/test_ocsp.rb にて Segmentation fault - nmake test-all を走らせると、test/openssl/test_ocsp.rb にて Segmentation fault が起こります。
添付ファイルの 1553 行目からが [BUG] 出力です。
ビルド環境、使用したライブラリは次の通りです。
libressl-2.5.5-windows
zlib-1.2.11
Windows 10 Home 1703, 15063.608
Visual Studio Build Tools 2017,... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59928 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Makefile.in, configure.in, tool/runruby.rb: rename ruby-runner
executable file as $(RUBY_INSTALL_NAME) under bin, to mimic
dirty `#!/usr/bin/env` hack.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59927 b2dd03c8-39d4-4d8f-98f... -
05:00 PM Feature #13896 (Closed): Find.find -> Use Dir.children instead of Dir.entries
- Applied in changeset trunk|r59926.
----------
Find.find -> Use Dir.children instead of Dir.entries
Dir.children is available since Feature #11302.
Find.find can use of the new list (having no '.' neither '..' entries),
making now super... -
- Dir.children is available since Feature #11302.
Find.find can use of the new list (having no '.' neither '..' entries),
making now superflous an if statement.
This change can improve the performance of Find.find when the path
has lots o... -
- patched by tbpgr <tbpgr@tbpgr.jp>
https://github.com/ruby/ruby/pull/1696 fix GH-1696
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59925 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:53 PM Revision 9708af66 (git): * 2017-09-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59924 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- patched by Samuel Giddins <segiddins@segiddins.me>
https://github.com/ruby/ruby/pull/1686 fix GH-1686
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59923 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:38 PM Bug #13887: test/ruby/test_io.rb may get stuck with FIBER_USE_NATIVE=0 on Linux
- I guess `cont->machine.stack_src` should not contain the under thread_start_func_1() stack.
Because this area will be used and overwritten by pthread, especially stack_list_{add,del} in nptl/allocatestack.c.
If cont_restore_1() copies ... -
04:31 PM Feature #12753: Useful operator to check bit-flag is true or false
- How about `bitmask_test?` or `bitflag_test?`
shugo (Shugo Maeda) wrote:
> Shugo Maeda wrote:
> ...
-
04:08 PM Feature #13821: Allow fibers to be resumed across threads
- I took a look at the C++ Boost library boost::fiber documentation. It allows fibers to be detached/attached between threads. Perhaps an explicit API like this is a better approach? See here: http://www.boost.org/doc/libs/1_62_0/libs/fibe...
-
- Yes, the Fiber.new(migrate: true) would mean the programmer is taking responsibility for NOT wrapping that Fiber up in mutexes or relying on the default behavior. I think this is reasonable.
As for the async/await code I've written, i... -
- ext/zlib/zlib.gemspec の files をみると ext/zlib/extconf.rb のような top_srcdir からの相対パスらしき指定と gemspec からの相対パスらしき(upstreamでのパス?) zlib.gemspec のようなものが混在しているように見えます。
top_srcdir からの相対パスが正しいのなら ext/zlib がついていないファイルを指しているのはおかしいし、 gemspec ファイルからの相対パス... -
- Just for curiosity, ruby 2.4.x works for you on windows if you compile it?
-
- steps:
1. open VS2015 x86 Native Tools Command Prompt
2. follow instructions in https://github.com/ruby/ruby/blob/trunk/win32/README.win32
most of the compilation completes including producing .lib files, but nmake finally errors ... -
-
01:12 PM Bug #13892: Matching the end of a string followed by an empty greedy regex and a word boundary (.*\b) fails in all versions >= 1.9
- @naruse, k-takata -
Testing with Onigmo, Oniguruma, and php's mb_ereg() this case does indeed fail to match, though based on my understanding of this particular pattern (and all of the other regex implementations cited), it should mat... -
- @naruse -
You might be right. I (shamefully) did not investigate what regex library Ruby is using under the hood. Sorry.
I will do some testing with the upstream code to see if the problem lies there or in Ruby. If there, I will cr... -
- As far as I understand, this is intentional behavior of Oniguruma (Onigmo), which Ruby uses.
How do you think, k-takata? -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59922 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59921 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:32 AM Bug #13772: Memory leak recycling stacks for threads in 2.4.1
- Thanks a lot, great news!
-
- * parse.y (f_arglist, parser_yylex): set lex_state via
SET_LEX_STATE macro for yydebug messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59920 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:13 AM Bug #13856: MinGW / mswin intermittent failure in test/socket/test_socket.rb
- Segmentation fault is caused by `RBASIC_CLASS(err)` access in hook_before_rewind() in vm.c:1667.
`err` is not a valid pointer.
Here is gdb output.
~~~
Run options: "--ruby=./miniruby.exe -I../snapshot/lib -I. -I.ext/common ../sn... -
- As nobu wrote, this issue is already fixed.
You can avoid this by upgrading Ruby to 2.3.5 or 2.4.2. -
03:37 AM Bug #13900 (Closed): Segmentation fault - 2 different machines
- The same error appears systematically - on two different installs of Ruby 2.3.1
A/ Ubuntu 16.04 in Windows10 WSL
B/ Bodhi 4.3.1 on a virtualBOx Windows 10 host.
I followed the message at the end inviting me to report a bug. H... -
06:23 AM Feature #13901 (Closed): Add branch coverage
- I plan to add "branch coverage" (and "method coverage") as new target types of coverage.so, the coverage measurement library. I'd like to introduce this feature for Ruby 2.5.0. Let me to hear your opinions.
## Basic Usage of the Cov... -
05:16 AM Bug #9891 (Closed): infinite fibers crash Ruby
- Thank you for your confirmation.
-
-
- Sorry I missed it.
-
- * object.c (convert_type_with_id): fix failure message for
explicit conversion. rb_convert_type_with_id and
rb_check_convert_type_with_id are not only for implicit
conversions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59... -
- * spec/rubyspec/optional/capi/spec_helper.rb (compile_extension):
rescue possible EBADF as jobserver fd may not be available.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59918 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * spec/rubyspec/core/dir/mkdir_spec.rb: the source directory may
be on a read-only filesystem.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * spec/rubyspec/optional/capi/ext/fixnum_spec.c: FIX2INT and
FXI2UINT return long, in spite of their names.
* spec/rubyspec/optional/capi/ext/range_spec.c: err is int.
* spec/rubyspec/optional/capi/ext/st_spec.c: st_index_t is larger... -
12:40 AM Revision c7fa2bf5 (git): ext/coverage/coverage.c (rb_coverage_start): Ensure `opt` is a hash
- Ensure `opt` is a hash before using `rb_hash_lookup` to `opt`.
This will prevent SEGV when an inappropriate object (i.e. an array)
is passed to `opt`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59915 b2dd03c8-39d4-4d8f-98ff-823fe...
09/14/2017
-
10:34 PM Bug #13899 (Closed): Ruby 2.4.2 and 2.3.5 cannot link with libgmp nor jemalloc
- The released package of Ruby 2.4.2 and 2.3.5 cannot link with libgmp nor jemalloc.
Then, I provide the fixes.
for Ruby 2.4.2:
a. Override `configure` file in your package by `configure-2.4.2`, and run `configure`.
b. Or, apply ... -
- ruby_2_4 r59914 merged revision(s) 58254.
-
- ruby_2_3 r59912 merged revision(s) 58254.
-
- fix --with-gmp (broken by r57490)
Looking at the generated shell script (also the autoconf manual), it
seems AC_SEARCH_LIBS() m4 macro does not define HAVE_LIBsomething C
preprocessor macros, unlike AC_CHECK_LIB(... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59913 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:21 PM Bug #13898: Block parsing regression
- `let(:foo) { nil }` and `let :foo do nil end` (and `let(:foo) do nil end`) works.
-
- Upgrading to Ruby 2.4.2p198 from Ruby 2.4.1p111 introduces the following regression:
irb(main):001:0> def let(x, &b); end
=> :let
irb(main):002:0> let :foo { nil }
SyntaxError: (irb):2: syntax error, unexpected '{',... - 08:41 PM Revision 463a56d1 (git): merge revision(s) 58254: [Backport #13402]
- fix --with-gmp (broken by r57490)
Looking at the generated shell script (also the autoconf manual), it
seems AC_SEARCH_LIBS() m4 macro does not define HAVE_LIBsomething C
preprocessor macros, unlike AC_CHECK_LIB(... -
- This is fixed as of r59911
There is still one instance in 1.9.3's ChangeLog but it seems harmless.
$ git grep rubyspec.org
doc/ChangeLog-1.9.3: http://rubyspec.org/issues/show/161
-
- In spec/rubyspec/library/net/http/http/send_request_spec.rb, it's only the referer value in the headers.
The request are sent to a local WEBrick server. -
- Re spec/mspec/mspec.gemspec, actually https://github.com/ruby/mspec is no longer distributed as a gem, the file has been removed.
I'll do the usual ruby/spec and ruby/mspec synchronization so this one will be fixed by it. -
- Thanks for the report, I'll take a look.
http://ruby.github.io/rubyspec.github.io/ has similar contents to what rubyspec.org hosted but it's not really maintained.
I think we should replace the links with a link to https://github.c... -
06:12 AM Bug #13790: rubyspec.org domain seems to be expired
- If we need to send real request to internet I suggest to use HTTPBin.org
https://httpbin.org/
Also, with HTTPBin we can un-comment all the other methods currently not tested (PUT, POST, DELETE, etc).
HTH.
---------------
E... -
05:38 PM Bug #12670: Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- nagachika (Tomoyuki Chikanaga) wrote:
> ruby_2_4 r59302 merged revision(s) 56558,59116,59136.
Can confirm bug is fixed.
Checked again with attached Dockerfile
Bug reproduced on:
v2_4_1
v2_3_4
v2_2_8
Bug fixed on:
v2_4_2
v2... -
05:31 PM Bug #13772: Memory leak recycling stacks for threads in 2.4.1
- perlun (Per Lundberg) wrote:
> This bug unfortunately prevents my organization from using 2.4.1 at the moment, we will have to downgrade to 2.3.4. Is there any chance we could get a bug fix release (2.4.2) out including this fix, in the... -
- Ideally some of these changes could be rolled out in 2.x versions with deprecation notices for those methods whose behavior will change or those methods will be eliminated. For the 3.0 release, the deprecated methods should be removed en...
-
- I have nothing against the suggestion itself. However, there is no general, universal "Principal of Least Surprise".
To the topic, Threads and Fibers - I have used Threads sometimes but rarely. I haven't yet used Fibers. Without knowi... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59911 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:56 PM Revision 938465be (git): * 2017-09-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59909 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- いつ頃からかは明確ではないのですが、trunkのmake-snapshotでlibffiがバンドルされなくなっています。
これは先ほどの安定版リリース作業中に発覚したのですが、libffiをダウンロードはしてくるものの、extractが行われていないようです。
リリースされたtarballの方は近永さんがどうにかしてくださいましたが、snapshot.tar.gzおよびstable-snapshot.tar.gzにもやはり同様にlibffiがバンドルされていないこと... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59908 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:32 PM Revision ea73cb5c (git): * version.h: bump to 2.3.6.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Awesome!
This should make writing specs in MRI possible without duplicated work,
and at the same time make other Ruby implementations benefit greatly from it.
I see @nobu already showed the example with https://github.com/ruby/rub... -
- It sounds good to me.
I am not aware of technical problems with the current name, but it is inconsistent.
Should I do it?
Or do you want to perform the rename? - 11:44 AM Revision d629ce0b (git): * ext/json: bump to version 1.8.1.1. [Backport #13853]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@59904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:41 AM Revision 5450329a (git): asn1: fix out-of-bounds read in decoding constructed objects
- * OpenSSL::ASN1.{decode,decode_all,traverse}: have a bug of
out-of-bounds read. int_ossl_asn1_decode0_cons() does not give the
correct available length to ossl_asn1_decode() when decoding the
inner components of a constructed objec... -
- 特に反対もなかったので、nil を返すのではなく RuntimeError を投げるようにしました（r59858）。
残るはシステムコールをループする点だけですが、
> それってO_NBLOCKのディスクリプタをビジーループで読み込みってことですよね。ユーザーランドからへんにビジーループするよりカーネル側で適切に生成されてくるのをユーザーランド側はすなおにブロッキングIOしたほうがトータルのコンテキストスイッチが少なそうな気がするんですが、まあ気がするだけで... - 11:37 AM Revision 8a81d04d (git): merge revision(s) 59897:
- lib/webrick/log.rb: sanitize any type of logs
It had failed to sanitize some type of exception messages. Reported and
patched by Yusuke Endoh (mame) at https://hackerone.com/reports/223363
git-svn-id: svn+ssh://ci.ruby... - 11:35 AM Revision 4fdfb28e (git): merge revision(s) 58453,58454: [Backport #13499]
- Fix space flag when Inf/NaN and width==3
* sprintf.c (rb_str_format): while `"% 2f"` and `"% 4f"` result in
`" Inf"` and `" Inf"` respectively, `"% 3f"` results in
`"Inf"` (no space).
Refactor "%f" % ... - 11:26 AM Revision 3896b486 (git): merge revision(s) 59897:
- lib/webrick/log.rb: sanitize any type of logs
It had failed to sanitize some type of exception messages. Reported and
patched by Yusuke Endoh (mame) at https://hackerone.com/reports/223363
git-svn-id: svn+ssh://ci.ruby... -
- lib/webrick/log.rb: sanitize any type of logs
It had failed to sanitize some type of exception messages. Reported and
patched by Yusuke Endoh (mame) at https://hackerone.com/reports/223363
git-svn-id: svn+ssh://ci.ruby... -
- It had failed to sanitize some type of exception messages. Reported and
patched by Yusuke Endoh (mame) at https://hackerone.com/reports/223363
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59896.
----------
ripper: add states of scanner
* parse.y (ripper_state): add states of scanner to tokens from
Ripper.lex and Ripper::Filter#on_*. based on the patch by
aycabta (Code Ahss) at [ruby-core... -
- * parse.y (ripper_state): add states of scanner to tokens from
Ripper.lex and Ripper::Filter#on_*. based on the patch by
aycabta (Code Ahss) at [ruby-core:81789]. [Feature #13686]
* ext/ripper/tools/preproc.rb (prelude, usercode):... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59895 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Coverage generates unique ID numbers for each branch and each method.
Use long instead of int for the IDs. I don't want to see 2^32 branches
and methods in one file, but just in case...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... -
- Applied in changeset trunk|r59893.
----------
fix the case High Sierra's mincore(2) may return -128 [Bug #13895] -
- TestVMDump#test_darwin_invalid_call fails with `Timeout::Error`
I can reproduce with `ruby -rfiddle -e "Fiddle::Function.new(Fiddle::Pointer.new(1), [], Fiddle::TYPE_VOID).call"`.
After that backtrace was stopped "C level backtrace i... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59893 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The decision here is surprising given https://bugs.ruby-lang.org/issues/13789#note-3
but nevertheless I'm very happy this got accepted. -
- Another reproduction code is here.
```
10.times do |i|
p i
t = Thread.new { Fiber.new { sleep }.resume }
Thread.new {}.join
t.run.join
end
``` -
- * compile.c (iseq_pop_newarray): optimize array literal in
condition.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59892 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59891 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Dir.children is available since Feature #11302. Find.find can
use of the new list (having no '.' neither '..' entries), making
now superflous an if statement.
This change can improve the performance of Find.find when the path
has l... -
- To measure coverage of C code:
`./configure --enable-gcov && make && make exam && make lcov`
To measure coverage of Ruby code:
`./configure && make && make exam COVERAGE=true && make lcov`
To measure coverage of both languages at a tim... -
- `unless` statement was a syntactic sugar for `if` statement,
which made the result of branch coverage hard to understand.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59888 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r59887.
----------
added workaround for APFS file format.
* TestFileExhaustive#test_atime: It fails with nano-sec precise.
I changed to use unixtime for this assertion for APFS.
* TestFileExhaustive#t... -
- * TestFileExhaustive#test_atime: It fails with nano-sec precise.
I changed to use unixtime for this assertion for APFS.
* TestFileExhaustive#test_expand_path: skip assertion when given
invalid charactor on APFS.
[Bug #13816]... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_3 r59884 merged revision(s) 59375.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59885 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:32 AM Revision ac6f2894 (git): merge revision(s) 59375: [Backport #13756]
- parse.y: empty hash in defined
* parse.y (command): NODE_ARRAY with NULL is invalid. traversal
in defined_expr0 is simplified than iseq_compile_each0.
[ruby-core:82113] [Bug #13756]
git-svn-id: svn+ssh://ci... -
- ruby_2_3 r59883 merged revision(s) 59763.
- 04:31 AM Revision 04667398 (git): merge revision(s) 59763: [Backport #13874]
- string.c: fix false coderange
* string.c (rb_enc_str_scrub): enc can differ from the actual
encoding of the string, the cached coderange is useless then.
[ruby-core:82674] [Bug #13874]
git-svn-id: svn+ssh://... - 04:26 AM Revision fdeb8dc2 (git): * ChangeLog: forgotten entries for r59880 and r59881.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_3 r59881 merged revision(s) 59644.
- 04:21 AM Revision 9b3e0ca6 (git): merge revision(s) 59644: [Backport #13836]
- parse.y: primary should not be 0
* parse.y (primary): should not be 0, since it can be a receiver.
[ruby-core:82447] [Bug #13836]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59881 b2dd03c8-39d4-4d8f-... -
- ruby_2_3 r59880 merged revision(s) 59613.
- 04:19 AM Revision ddda4baf (git): merge revision(s) 59613: [Backport #13817]
- vm_method.c: alias warning at refined method
* vm_method.c (rb_method_entry_make): suppress a warning at
refined method which will not be redefined.
[ruby-core:82385] [Bug #13817]
git-svn-id: svn+ssh://ci.ru... - 04:16 AM Revision 95c9c1dc (git): * ext/bigdecimal/bigdecimal.c (BigDecimal_hash): st_index_t may not be
- fixable on 64bit mswin/mingw.
* ext/date/date_core.c (d_lite_hash): ditto.
[Backport #13877]
* ext/openssl/ossl_bn.c (ossl_bn_hash): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59879 b2dd03c8-39d4-4d8f-98ff... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The old API:
Coverage.start
load "foo.rb"
p Coverage.result #=> {"foo.rb" => [1, 2, nil]}
The new API:
ENV["COVERAGE_EXPERIMENTAL_MODE"] = "true"
Coverage.start(lines: true)
load "foo.rb"
p Coverage.result ... -
- h.shirosaki (Hiroshi Shirosaki) wrote:
> `RbConfig::CONFIG["PATH_SEPARATOR"]` is `:` which is separator on msys2 shell building ruby.
> ...
Indeed, could you commit it? -
- * These are dbm, fcntl, io-console, sdbm, stringio, strscan, zlib,
cmath, scanf.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:00 AM Bug #9891: infinite fibers crash Ruby
- Hello again. I reported this bug 3 years ago. I'm happy to report that I can't reproduce this bug with recent Ruby trunk,
```
$ ruby -v
ruby 2.5.0dev (2017-09-11 trunk 59840) [x86_64-openbsd6.1]
```
In recent days, I wrote some ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59872 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This is needed for passing to the hook function the measuring target
type (line/branch/method) and the site of coverage event fired.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59871 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/13/2017
-
11:38 PM Bug #10222: require_relative and require should be compatible with each other when symlinks are used
- Akira, in those cases was the basename different among the real path and the symlink?
-
11:35 PM Bug #10222: require_relative and require should be compatible with each other when symlinks are used
- Here's an actual use case that we saw in Rails: https://github.com/rails/rails/pull/29638#issuecomment-321335175
The reporter says that it happened in Jenkins, but I guess the same situation may happen in any case where we put the .rb f... -
- I see, what you mean, if we simply add the expanded filenames to LOADED_PATH then that file would be loaded just once. Do you have any use cases where someone would symlink Ruby code for good usage?
-
- I'd expect b.rb and c.rb to be handled like separate files, so "b loaded" would be printed twice.
-
- Would you expect just directory names get expanded?
Or basename too?
For instance, 'b loaded' should be printed twice or just once,?
```
mkdir a
echo "p 'b loaded'" > a/b.rb
ln -s b.rb a/c.rb
ruby -I./a -ra -rb -e''
``` -
- Applied in changeset trunk|r59870.
----------
test_rubyoptions.rb: keep paths if necessary
* test/ruby/test_rubyoptions.rb (TestRubyOptions#test_search):
PATH must keep library loading paths on a platform where it is
used for that ... -
- My MinGW builds are very similar to rubyinstaller2 builds, and they also use a manifest. They use the rubyinstaller2 runtime.
Speaking of copying files, I do copy a file for another test, but I didn't note which test it affected...
... -
- I can reproduce this with msys2 build.
miniruby.exe and ruby.exe have dependency to libgmp-10.dll.
So path which contains libgmp-10.dll is needed to PATH environment variable.
I can avoid the issue by copying libgmp-10.dll to curren... -
- * test/ruby/test_rubyoptions.rb (TestRubyOptions#test_search):
PATH must keep library loading paths on a platform where it is
used for that purpose, for extra libraries.
[ruby-core:81178] [Bug #13569] [Fix GH-1616]
git-svn-id: svn... - 03:28 PM Revision e1ada191 (git): * 2017-09-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59869 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * configure.in, win32/Makefile.sub: set LIBPATHENV to PATH on
Windows, for extra DLLs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I don't recall having this issue in my builds, but with the patch, I have quite a few warnings. I could file a separate bug report. Try:
```
ruby -v -rwin32ole -e "module Word ; end ; w = WIN32OLE.new('Word.Application') ; WIN32OLE... -
01:25 PM Bug #13894 (Closed): win32ole/test_word.rb sometimes not quit Word
- Applied in changeset trunk|r59867.
----------
test/win32ole/test_word.rb: word quit without confirmation dialog to save
files. [Bug #13894] Thanks to h.shirosaki. -
- When I run test-all, Word does not quit sometimes and Word opens confirm dialog to save files.
I have to close Word manually.
I think that `w.quit(Word::WdDoNotSaveChanges)` may be better to quit word.
```patch
diff --git a/test/... -
- Thanks for reviewing. Added the patch, removed my copy command, and test passed in `make test-all`.
Maybe change
```
path = ::File.dirname(so) + ::File::PATH_SEPARATOR + path
```
to
```
path = path + ::File::PATH_SEPARATOR + ::... -
- `RbConfig::CONFIG["PATH_SEPARATOR"]` is `:` which is separator on msys2 shell building ruby.
Should we use `File::PATH_SEPARATOR` `;` on test?
~~~patch
diff --git a/test/-ext-/win32/test_dln.rb b/test/-ext-/win32/test_dln.rb
index ... -
- files. [Bug #13894] Thanks to h.shirosaki.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59867 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59866 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It's same as upstream permission.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/12/2017
-
- * test/fiddle/test_func.rb (test_string): this test break String buffer
by `strcpy` ("000" -> "123"). However, the string literal "000" with
`frozen_string_literal: true` returns a string object from frozen
string pool. So that aft... - 06:41 PM Revision 4ef5c754 (git): * 2017-09-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59860 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:41 PM Revision 73f3dfd3 (git): cont.c: update comment to match r59776 [ci skip]
- * cont.c (fiber_switch): th->fiber => th->ec.fiber in comment
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59859 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Another idea which is related to #13245 would be to have these as class methods on Fiber and Thread (Thread[:foo]; Thread[:foo] = :bar; Thread.keys; Thread.key? :foo),
which would limit only accessing variables of the current fiber/thre... -
- I agree this would be much nicer and consistent.
I can't evaluate the impact on compatibility, but it's likely quite big. -
- Ruby 3 API cleanup suggestion.
The Thread and Fiber classes have a very odd API for setting/getting thread local and fiber local variables. With Ruby 3 coming soon, this is a perfect opportunity to make this API more coherent and retu... -
- cremes (Chuck Remes) wrote:
> By default we would retain the existing behavior where the Fiber is "locked" to its originating Thread. But if you call `Fiber.new(migrate: true)` then the Fiber is free to float among multiple threads. Whe... -
- Added ticket 13893 (https://bugs.ruby-lang.org/issues/13893) to track a feature request to cleanup fiber-local and thread-local handling in the Fiber and Thread classes.
-
- I understand how this request could allow for race conditions between Fibers. Right now we are relying on the fact that they can only run on a single thread to enforce this particular semantic. I also agree that this is useful in certain...
-
- I think this is first of all a problem for semantics.
If we allow fibers to be resumed on another Thread, we allow multiple fibers originally from the same thread to execute concurrently
(so they no longer see the effects of each oth... -
- Early failure looks better in this case. Refs [Bugs #13885].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59858 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This is a combined patch of the following two commits in maint:
a09d8c78dd30 test/test_ssl: suppress warning in test_alpn_protocol_selection_cancel
de965374ee85 test/test_pair: disable compression
This hopefully fixes t... -
- This is a very specific regex failure that occurs when the final character of the string is matched by the end of a pattern that terminates with `.*\b`. For example:
~~~ ruby
"abc" =~ /c.*\b/
"abc" =~ /abc.*\b/
"abc" =~ /\b.*abc.*\... -
- I tried and it doesn't seem so easy.
ruby/spec seems to mostly pass, there are just 14 errors:
https://gist.github.com/eregon/36f15069d86fc98fe39ff490ab878e91
but test-all gets stuck in DRb tests due to
https://github.com/ruby/ru... -
- All of environments on Ruby CI are fails rdoc generation.
It may be caused by
https://github.com/ruby/rdoc/commit/8cfa11d6f1cc7e74e45e42fd8d1d76c5a0646a6e
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59856 b2dd03c8-39d4-4d8f-98... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59855 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/fiddle/closure.c: use directly declaration for standalone gem
without internal.h.
* Specify frozen string literal is true.
* Update gemspec configuration for release version.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tru... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59853 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59852 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59851 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59850 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * csv.gemspec: Update release version.
* lib/csv.rb: Remove superfluous private clause.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:08 AM Bug #13887: test/ruby/test_io.rb may get stuck with FIBER_USE_NATIVE=0 on Linux
- Another note, FIBER_USE_NATIVE segfaults with my work-in-progress
"thriber" implementation:
http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/82756
I guess I'll investigate tomorrow. -
- Eric Wrong <normalperson@yhbt.net> wrote:
> mame@ruby-lang.org wrote:
> > I believe that this feature should be introduced with another
> > name. I have no counterproposal, though. Sorry.
>
> What about Thriber? Or Fred?
>
>... -
- "lib/rdoc" is only workds on rdoc repository structure.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59848 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I think it is all a bit messy right now and a while ago. :)
See also other errors related to gems and compiling them, then them being in the wrong directory.
> I double checked, and I am placing the files (unpacked gems and *.gem) ... -
- I should have checked more thoroughly.
In the 'install package' `lib/ruby/gems/2.5.0` folder, the cache and specification folders are always loaded correctly, but the actual gems folder is not. It has a directory for each bundled gem... -
- I just noticed that my most recent build has no rake files in the bin folder. It does have bundle & rdoc files, which, unlike rake, are default gems. No other bundled gems have files located in bin.
I checked builds every few days g... - 03:42 AM Revision 997f230c (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:42 AM Revision 708afa47 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59846 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * This version changed lexer used Ripper from lexer based IRB.
see details: https://github.com/ruby/rdoc/pull/512
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59845 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The bug happens when an async error (from Thread#raise) interrupts a finalizer. Ruby seems to rescue errors from finalizers, so the error never reaches the main code. In the script by Joe Rafaniello, the Timeout::Error disappears, so the...
09/11/2017
-
- Applied in changeset trunk|r59844.
----------
console.c: set winsize on Windows
* ext/io/console/console.c (console_set_winsize): retry shrinking
window and screen buffer. [ruby-core:82741] [Bug #13888] -
- * ext/io/console/console.c (console_set_winsize): retry shrinking
window and screen buffer. [ruby-core:82741] [Bug #13888]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:10 PM Revision 896d0412 (git): * 2017-09-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59843 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/io/console/test_io_console.rb (test_set_winsize_console):
split from test_get_winsize_console and enable the case when
attached to a console already
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59842 b2dd03c8-39d4-4d8f-9... -
- ruby_2_4 r59841 merged revision(s) 59375.
-
- parse.y: empty hash in defined
* parse.y (command): NODE_ARRAY with NULL is invalid. traversal
in defined_expr0 is simplified than iseq_compile_each0.
[ruby-core:82113] [Bug #13756]
git-svn-id: svn+ssh://ci... -
04:13 PM Feature #13884: Reduce number of memory allocations for "and", "or" and "diff" operations on small arrays
- The fixed remark about comparison method. Added benchmarks and results.
After this benchmark, i've noticed there are no profits when array size between 17 and 32 elements, but some degradation of speed for "diff" operation.
## Resu... -
- Eregon (Benoit Daloze) wrote:
> Note that this would change the semantics as it uses #== and not #eql? to compare elements.
> ...
Yes, it is, I've missed this part, will fix.
-
- replace_real_basename() is called for same head plain paths because braces are expanded early before ruby_glob0().
Moving braces expansion to later phase in glob_helper() is a way to reduce replace_real_basename().
The idea is same a... -
- shyouhei (Shyouhei Urabe) wrote:
> これは特に反対ありません。
ありがとうございます。r59840 でコミットしました。（コミットログにチケット番号書き忘れた……） -
01:29 AM Bug #13885: Random.urandom と securerandom について
- mame (Yusuke Endoh) wrote:
> shyouhei (Shyouhei Urabe) wrote:
> ...
それってO_NBLOCKのディスクリプタをビジーループで読み込みってことですよね。ユーザーランドからへんにビジーループするよりカーネル側で適切に生成されてくるのをユーザーランド側はすなおにブロッキングIOしたほうがトータルのコンテキストスイッチが少なそうな気がするんですが、まあ気がするだけで定量的評価ではないです。
> > -... -
- `SecureRandom#gen_random` determines whether urandom is available or not
by trying `Random.urandom(n)`. But, when n = 0, `Random.urandom(0)`
always succeeds even if urandom is not available, which leads to a wrong
decision.
When failed... -
- Another interesting fact related to fiber-local variables is they are inherently racy when accessing fibers locals of another Thread.
By racy, I mean that it's unknown which Fiber of that other Thread will be the current/active one and ... -
- But this test is always fail on ruby core repository. Because
default gems is only availabled after installation of Ruby.
I ignored this test at https://github.com/rubygems/rubygems/pull/1986
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
09:35 AM Feature #13890: Allow a regexp as an argument to 'count', to count more interesting things than single characters
- Eregon (Benoit Daloze) wrote:
> I think the default should be no overlap, and increment the position by the length of the match.
That would be fine by me, too. -
- Should it behave the same as str.scan(regexp).size ?
I think the default should be no overlap, and increment the position by the length of the match. -
- Currently, String#count only accepts strings, and counts all the characters in the string.
However, I have repeatedly met the situation where I wanted to count more interesting things in strings.
These 'interesting things' can easily... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59837 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r59836.
----------
Remove commented out code of URI::HTTP.new.
[Misc #13871][ruby-core:82655] Patch by @aycabta -
- [Misc #13871][ruby-core:82655] Patch by @aycabta
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59835.
----------
Remove commented out code of SecureRandom.random_number.
[Misc #13870][ruby-core:82654] Patch by @aycabta. -
- [Misc #13870][ruby-core:82654] Patch by @aycabta.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This bug unfortunately prevents my organization from using 2.4.1 at the moment, we will have to downgrade to 2.3.4. Is there any chance we could get a bug fix release (2.4.2) out including this fix, in the near future? We could always co...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59834 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:41 AM Bug #13889: FileUtils.rmdir が Errno::ENOTEMPTY を無視している
- > 1.9から故意に無視するようになった
ちなみにこちらは何か理由があったのでしょうか？
> ...
はい、そのような挙動ならエラーに削除エラーに気づけて良いかと思います。 -
02:01 AM Bug #13889: FileUtils.rmdir が Errno::ENOTEMPTY を無視している
- 追記漏れに気付いたので追記しました。
* https://github.com/rurema/doctree/commit/c238a2cc3f77f5f500ea9b001379524438476b38
Errno::ENOTEMPTYについてはoptions[:verbose]がtrueの時だけ何か出力するくらいはしてもいいかもしれません。 -
- 1.9から故意に無視するようになったようでしたので日本語リファレンスの方を修正しました。そのうちWebの方も反映されるかと思います。
* https://github.com/rurema/doctree/commit/026eb146c07aa15b2914be905d49d80ef3b1c164 -
- 2.1 や最新のリファレンスには FileUtils.rmdir で削除対象のディレクトリが空ではない場合は Errno::ENOTEMPTY が発生すると書かれていますが、
FileUtils.rmdir を空でないディレクトリに対して呼んでもエラーにはならず、削除もされません。
~~~
irb(main):002:0> FileUtils.mkdir("dir")
=> ["dir"]
irb(main):003:0> FileUtils.touch(... -
- * rake-12.1.0 from 12.0.0
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59833 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59832 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/10/2017
-
11:33 PM Bug #13888 (Closed): Consistent error in IO::Console.winsize=
- When trying to change the console window size, an error is always thrown, but the column size gets changed if the new value is higher than old value.
This behaviour can be observed by running the following code :
~~~ ruby
require 'i... -
08:59 PM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- I see, now I understood what you meant. My approach was more to have a fixed-size buffer, read into it until full or socket is waiting, and then pass data to the parser. Your approach might be less resource-intensive though, thx for the ...
-
- Note that this would change the semantics as it uses #== and not #eql? to compare elements.
The comparison should always be done with #eql? to remain compatible.
It also does not call #hash but that is likely a much smaller problem. -
- * cont.c (rb_context_t): introduce saved_ec instaad of saved_thread.
We only need to transfer ec data (not all of thread data).
Introduce `thread_value` field to point creation thread.
To acccess this field, `cont_thread_value()` ... -
- * cont.c (fiber_store): move `cont_save_machine_stack()` timing to
avoid `fiber_verify()` false positive on `FIBER_USE_NATIVE == 0`
and `GC.stress = true`.
This patch is very dirty and it should be removed soon.
git-svn-id: svn+s... -
- * cont.c (cont_save_thread): clear only `stack_end`. Clearing tells
GC mark function to ignore this macine stack (not allocated yet).
`stack_start` will be used by machine stack store/restore phase
(on FIBER_USE_NATIVE == 0), so th... -
- Applied in changeset trunk|r59828.
----------
compile.c: pop coverage trace
* compile.c (iseq_compile_each0): pop trace for coverage only and
clear its corresponding line. [ruby-core:82726] [Bug #13886] -
- * compile.c (iseq_compile_each0): pop trace for coverage only and
clear its corresponding line. [ruby-core:82726] [Bug #13886]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59828 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59827 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:49 PM Revision ef037b1f (git): * 2017-09-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59826 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_core.h: move rb_thread_t::machine to rb_execution_context_t::machine.
* vm_core.h, gc.c (rb_gc_mark_machine_stack): accept ec instead of th.
it enables to call this func from rb_execution_context_mark() in vm.c.
* cont.c (fiber_... -
- shyouhei (Shyouhei Urabe) wrote:
> (まあループの中でエントロピー吸い出すなら当然ブロッキングIOということになるわけで、GVL放した方がいいんじゃないのとか思わなくもないのでパッチはやや大きそうではあると感じますが)
/dev/urandom はブロックしない（少なくとも最近の OS なら）、という前提があっても、GVL 放すべきですかね？
> ...
小崎さんと卜部さんの 2 人がそういうなら、大丈夫な気がしてきました... -
- kosaki (Motohiro KOSAKI) wrote:
> >1.Random.urandom は、getrandom(2) や (/dev/urandom に対する) read(2) システムコールを 1 回しか呼ばないようです。よって、要求量が大きくて 1 回では文字列を準備できないとき（例えば
> ...
昔のLinuxのmanに "Users should be very economical in the amount of seed materi... -
02:59 AM Bug #13885: Random.urandom と securerandom について
- 小崎です
このへんあんまり詳しくないんですが。
>1.Random.urandom は、getrandom(2) や (/dev/urandom に対する) read(2) システムコールを 1 回しか呼ばないようです。よって、要求量が大きくて 1 回では文字列を準備できないとき（例えば
> ...
そんな気がします。一瞬エントロピー枯渇について心配しましたが、Rubyの側で小さいurandomを大量に呼べばどうせ枯渇するんだし
>2.Random.... -
- Seems the code generated by gperf 3.1 without `-n` option has a problem with Apple clang.
```
defs/keywords:57:32: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorte... -
- Eric Wong wrote in https://bugs.ruby-lang.org/issues/13875#note-5 [ruby-core:82708]
> However, test/ruby/test_io.rb seems stuck when FIBER_USE_NATIVE is 0
> ...
I can reproduce with `make optflags="-DFIBER_USE_NATIVE=0 -O0" test-all TE... -
- * tool/merger.rb: separate each commit logs by an empty line.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59824 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r59823 merged revision(s) 59765.
-
- ruby.h: unnormalized Fixnum value
* include/ruby/ruby.h (ST2FIX): fix unnormalized Fixnum value bug
on mingw/mswin. [ruby-core:82687] [Bug #13877]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59823 b... -
- ruby_2_4 r59822 merged revision(s) 59763.
-
- string.c: fix false coderange
* string.c (rb_enc_str_scrub): enc can differ from the actual
encoding of the string, the cached coderange is useless then.
[ruby-core:82674] [Bug #13874]
git-svn-id: svn+ssh://... -
- * spec/bundler/bundler/cli_spec.rb: prefer BUNDLE_RUBY over env
hack. on macOS 10.11 or later, some system commands, e.g.
/bin/sh and /usr/bin/env, clear DYLD_LIBRARY_PATH environment
variable which is necessary to run not-yet ins... -
- ruby_2_4 r59820 merged revision(s) 59644.
-
- parse.y: primary should not be 0
* parse.y (primary): should not be 0, since it can be a receiver.
[ruby-core:82447] [Bug #13836]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59820 b2dd03c8-39d4-4d8f-... -
- ruby_2_4 r59819 merged revision(s) 59613.
-
- vm_method.c: alias warning at refined method
* vm_method.c (rb_method_entry_make): suppress a warning at
refined method which will not be redefined.
[ruby-core:82385] [Bug #13817]
git-svn-id: svn+ssh://ci.ru... -
10:04 AM Bug #13861: Performance regressoion in Hash literal in Ruby 2.5.0-dev
- Seems this regression was fixed by https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?revision=59744&view=revision
Thank you for fixing!!!
### before
```
$ ./miniruby -v -Ilib -I../benchmark-ips/lib ~/tmp/bench.rb
ruby 2.5.0dev (20... -
- I would like to sync rubygems on ruby_2_4 branch to trunk
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59818 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- gc.c: restore cfp at finalizer
* gc.c (run_finalizer): restore cfp for the case an exception
raised in a finalizer. [ruby-core:82432] [Bug #13832]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59817 b... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59816 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59815 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Backport #13842]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_4 r59812 merged revision(s) 59708.
-
- compile.c: ensure after toplevel return
* compile.c (iseq_compile_each0): toplevel returns should fire
ensures. [ruby-core:82492] [Bug #13844]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59812 b2dd0... -
- ruby_2_4 r59811 merged revision(s) 59624,59626.
-
- ruby.h: fix rb_scan_args_trail_idx
* include/ruby/ruby.h (rb_scan_args_trail_idx): fix the case both
of optional and rest arguments are defined.
[ruby-core:82427] [Bug #13830]
* include/ruby/ruby.h (... -
- default targets are all of bundler specs. if you run only
commands/add_spec.rb spec:
make test-bundler BUNDLER_SPECS=commands/add_spec.rb
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59810 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r59809 merged revision(s) 59322,59325.
-
- process.c: handle dynamic :rlimit_* symbols in spawn execopts
* process.c (rb_execarg_addopt_rlimit): hoist out of rb_execarg_addopt
(rlimit_type_by_sym): new wrapper for dynamic symbol
(rb_execarg_addopt): c... -
- ruby_2_4 r59808 merged revision(s) 57944,57977,58062.
-
- io.c: [DOC] IO#puts uses IO#write
io.c: [DOC] add missing `$`
io.c: [DOC] expand docs for IO#puts
[ruby-core:80081] [Bug #13306]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59808 b2dd03c8-39d4-... -
- ruby_2_4 r59807 merged revision(s) 58524,58525,58526,59333,59337.
-
- zlib.c: zstream_expand_buffer_non_stream
* ext/zlib/zlib.c (zstream_expand_buffer_non_stream): rename from
zstream_expand_buffer_without_gvl() and replace duplicate code
in zstream_expand_buffer().
zl... - 01:10 AM Revision 0b572d70 (git): * 2017-09-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@59806 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:10 AM Revision 97c6e393 (git): * lib/rubygems: fix several vulnerabilities in RubyGems; bump to version
- 2.4.5.3. [Backport #13842]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@59805 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I found to fail testcase on Ruby 2.2 used attached patch named "rubygems-2613-ruby22.patch".
I created additional patch for broken test.
It replaced `util_spec` to malicious `Gem::Specification` instance and invoke `Gem::Specificat...