Activity
From 09/05/2017 to 09/11/2017
09/11/2017
-
08:10 PM Bug #13888 (Closed): Consistent error in IO::Console.winsize=
- Applied in changeset trunk|r59844.
----------
console.c: set winsize on Windows
* ext/io/console/console.c (console_set_winsize): retry shrinking
window and screen buffer. [ruby-core:82741] [Bug #13888] -
08:10 PM Revision 65b11a04 (git): console.c: set winsize on Windows
- * ext/io/console/console.c (console_set_winsize): retry shrinking
window and screen buffer. [ruby-core:82741] [Bug #13888]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:10 PM Revision 896d0412 (git): * 2017-09-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59843 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:10 PM Revision b6bc45b9 (git): test_io_console.rb: test_set_winsize_console
- * test/io/console/test_io_console.rb (test_set_winsize_console):
split from test_get_winsize_console and enable the case when
attached to a console already
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59842 b2dd03c8-39d4-4d8f-9... -
05:27 PM Bug #13756: tDSTAR inside of defined causes [BUG]
- ruby_2_4 r59841 merged revision(s) 59375.
-
05:27 PM Revision a59b02c6 (git): merge revision(s) 59375: [Backport #13756]
- parse.y: empty hash in defined
* parse.y (command): NODE_ARRAY with NULL is invalid. traversal
in defined_expr0 is simplified than iseq_compile_each0.
[ruby-core:82113] [Bug #13756]
git-svn-id: svn+ssh://ci... -
04:13 PM Feature #13884: Reduce number of memory allocations for "and", "or" and "diff" operations on small arrays
- The fixed remark about comparison method. Added benchmarks and results.
After this benchmark, i've noticed there are no profits when array size between 17 and 32 elements, but some degradation of speed for "diff" operation.
## Resu... -
03:39 AM Feature #13884: Reduce number of memory allocations for "and", "or" and "diff" operations on small arrays
- Eregon (Benoit Daloze) wrote:
> Note that this would change the semantics as it uses #== and not #eql? to compare elements.
> ...
Yes, it is, I've missed this part, will fix.
-
02:28 PM Bug #13167: Dir.glob is 25x slower since Ruby 2.2
- replace_real_basename() is called for same head plain paths because braces are expanded early before ruby_glob0().
Moving braces expansion to later phase in glob_helper() is a way to reduce replace_real_basename().
The idea is same a... -
12:46 PM Bug #13885: Random.urandom と securerandom について
- shyouhei (Shyouhei Urabe) wrote:
> これは特に反対ありません。
ありがとうございます。r59840 でコミットしました。(コミットログにチケット番号書き忘れた……) -
01:29 AM Bug #13885: Random.urandom と securerandom について
- mame (Yusuke Endoh) wrote:
> shyouhei (Shyouhei Urabe) wrote:
> ...
それってO_NBLOCKのディスクリプタをビジーループで読み込みってことですよね。ユーザーランドからへんにビジーループするよりカーネル側で適切に生成されてくるのをユーザーランド側はすなおにブロッキングIOしたほうがトータルのコンテキストスイッチが少なそうな気がするんですが、まあ気がするだけで定量的評価ではないです。
> > -... -
12:44 PM Revision 3b08df64 (git): lib/securerandom.rb: test one byte to determine urandom or openssl
- `SecureRandom#gen_random` determines whether urandom is available or not
by trying `Random.urandom(n)`. But, when n = 0, `Random.urandom(0)`
always succeeds even if urandom is not available, which leads to a wrong
decision.
When failed... -
10:20 AM Feature #13245: [PATCH] reject inter-thread TLS modification
- Another interesting fact related to fiber-local variables is they are inherently racy when accessing fibers locals of another Thread.
By racy, I mean that it's unknown which Fiber of that other Thread will be the current/active one and ... -
09:44 AM Revision bfa3d672 (git): Backport test_realworld_default_gem test from Rubygems-2.6.13.
- But this test is always fail on ruby core repository. Because
default gems is only availabled after installation of Ruby.
I ignored this test at https://github.com/rubygems/rubygems/pull/1986
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
09:35 AM Feature #13890: Allow a regexp as an argument to 'count', to count more interesting things than single characters
- Eregon (Benoit Daloze) wrote:
> I think the default should be no overlap, and increment the position by the length of the match.
That would be fine by me, too. -
09:17 AM Feature #13890: Allow a regexp as an argument to 'count', to count more interesting things than single characters
- Should it behave the same as str.scan(regexp).size ?
I think the default should be no overlap, and increment the position by the length of the match. -
05:21 AM Feature #13890 (Open): Allow a regexp as an argument to 'count', to count more interesting things than single characters
- Currently, String#count only accepts strings, and counts all the characters in the string.
However, I have repeatedly met the situation where I wanted to count more interesting things in strings.
These 'interesting things' can easily... -
08:50 AM Revision b7127e63 (git): Follow latest VM changes
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:50 AM Revision 23b9093f (git): suppress unused argument warning
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59837 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:12 AM Misc #13871 (Closed): Remove commented out code of URI::HTTP.new
- Applied in changeset trunk|r59836.
----------
Remove commented out code of URI::HTTP.new.
[Misc #13871][ruby-core:82655] Patch by @aycabta -
06:12 AM Revision 21f6916b (git): Remove commented out code of URI::HTTP.new.
- [Misc #13871][ruby-core:82655] Patch by @aycabta
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:11 AM Misc #13870 (Closed): Remove commented out code of SecureRandom.random_number
- Applied in changeset trunk|r59835.
----------
Remove commented out code of SecureRandom.random_number.
[Misc #13870][ruby-core:82654] Patch by @aycabta. -
06:11 AM Revision f7b3d2be (git): Remove commented out code of SecureRandom.random_number.
- [Misc #13870][ruby-core:82654] Patch by @aycabta.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:35 AM Bug #13772: Memory leak recycling stacks for threads in 2.4.1
- This bug unfortunately prevents my organization from using 2.4.1 at the moment, we will have to downgrade to 2.3.4. Is there any chance we could get a bug fix release (2.4.2) out including this fix, in the near future? We could always co...
-
03:05 AM Revision 90a0917c (git): Fixed unterminated backquote for bundler sync task.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59834 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:41 AM Bug #13889: FileUtils.rmdir が Errno::ENOTEMPTY を無視している
- > 1.9から故意に無視するようになった
ちなみにこちらは何か理由があったのでしょうか?
> ...
はい、そのような挙動ならエラーに削除エラーに気づけて良いかと思います。 -
02:01 AM Bug #13889: FileUtils.rmdir が Errno::ENOTEMPTY を無視している
- 追記漏れに気付いたので追記しました。
* https://github.com/rurema/doctree/commit/c238a2cc3f77f5f500ea9b001379524438476b38
Errno::ENOTEMPTYについてはoptions[:verbose]がtrueの時だけ何か出力するくらいはしてもいいかもしれません。 -
01:45 AM Bug #13889: FileUtils.rmdir が Errno::ENOTEMPTY を無視している
- 1.9から故意に無視するようになったようでしたので日本語リファレンスの方を修正しました。そのうちWebの方も反映されるかと思います。
* https://github.com/rurema/doctree/commit/026eb146c07aa15b2914be905d49d80ef3b1c164 -
01:10 AM Bug #13889 (Closed): FileUtils.rmdir が Errno::ENOTEMPTY を無視している
- 2.1 や最新のリファレンスには FileUtils.rmdir で削除対象のディレクトリが空ではない場合は Errno::ENOTEMPTY が発生すると書かれていますが、
FileUtils.rmdir を空でないディレクトリに対して呼んでもエラーにはならず、削除もされません。
~~~
irb(main):002:0> FileUtils.mkdir("dir")
=> ["dir"]
irb(main):003:0> FileUtils.touch(... -
02:29 AM Revision 7cc057d3 (git): Update bundled gems.
- * rake-12.1.0 from 12.0.0
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59833 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:33 AM Revision dc75046d (git): Added [Feature #12733] to NEWS entry.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59832 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/10/2017
-
11:33 PM Bug #13888 (Closed): Consistent error in IO::Console.winsize=
- When trying to change the console window size, an error is always thrown, but the column size gets changed if the new value is higher than old value.
This behaviour can be observed by running the following code :
~~~ ruby
require 'i... -
08:59 PM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- I see, now I understood what you meant. My approach was more to have a fixed-size buffer, read into it until full or socket is waiting, and then pass data to the parser. Your approach might be less resource-intensive though, thx for the ...
-
08:20 PM Feature #13884: Reduce number of memory allocations for "and", "or" and "diff" operations on small arrays
- Note that this would change the semantics as it uses #== and not #eql? to compare elements.
The comparison should always be done with #eql? to remain compatible.
It also does not call #hash but that is likely a much smaller problem. -
07:00 PM Revision b53b3775 (git): store ec instead of thread in rb_context_t.
- * cont.c (rb_context_t): introduce saved_ec instaad of saved_thread.
We only need to transfer ec data (not all of thread data).
Introduce `thread_value` field to point creation thread.
To acccess this field, `cont_thread_value()` ... -
06:37 PM Revision 2a01ac89 (git): avoid false positive on fiber_verify().
- * cont.c (fiber_store): move `cont_save_machine_stack()` timing to
avoid `fiber_verify()` false positive on `FIBER_USE_NATIVE == 0`
and `GC.stress = true`.
This patch is very dirty and it should be removed soon.
git-svn-id: svn+s... -
05:30 PM Revision 525532ff (git): clear `stack_end`.
- * cont.c (cont_save_thread): clear only `stack_end`. Clearing tells
GC mark function to ignore this macine stack (not allocated yet).
`stack_start` will be used by machine stack store/restore phase
(on FIBER_USE_NATIVE == 0), so th... -
04:19 PM Bug #13886 (Closed): Seg Fault - eval - 59781 - MinGW
- Applied in changeset trunk|r59828.
----------
compile.c: pop coverage trace
* compile.c (iseq_compile_each0): pop trace for coverage only and
clear its corresponding line. [ruby-core:82726] [Bug #13886] -
04:19 PM Revision d446f15c (git): compile.c: pop coverage trace
- * compile.c (iseq_compile_each0): pop trace for coverage only and
clear its corresponding line. [ruby-core:82726] [Bug #13886]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59828 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:19 PM Revision 93272b35 (git): cont.c: fix typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59827 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:49 PM Revision ef037b1f (git): * 2017-09-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59826 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:49 PM Revision 4f0c9a5c (git): move th->machine to ec->machine.
- * vm_core.h: move rb_thread_t::machine to rb_execution_context_t::machine.
* vm_core.h, gc.c (rb_gc_mark_machine_stack): accept ec instead of th.
it enables to call this func from rb_execution_context_mark() in vm.c.
* cont.c (fiber_... -
02:52 PM Bug #13885: Random.urandom と securerandom について
- shyouhei (Shyouhei Urabe) wrote:
> (まあループの中でエントロピー吸い出すなら当然ブロッキングIOということになるわけで、GVL放した方がいいんじゃないのとか思わなくもないのでパッチはやや大きそうではあると感じますが)
/dev/urandom はブロックしない(少なくとも最近の OS なら)、という前提があっても、GVL 放すべきですかね?
> ...
小崎さんと卜部さんの 2 人がそういうなら、大丈夫な気がしてきました... -
12:24 PM Bug #13885: Random.urandom と securerandom について
- kosaki (Motohiro KOSAKI) wrote:
> >1.Random.urandom は、getrandom(2) や (/dev/urandom に対する) read(2) システムコールを 1 回しか呼ばないようです。よって、要求量が大きくて 1 回では文字列を準備できないとき(例えば
> ...
昔のLinuxのmanに "Users should be very economical in the amount of seed materi... -
02:59 AM Bug #13885: Random.urandom と securerandom について
- 小崎です
このへんあんまり詳しくないんですが。
>1.Random.urandom は、getrandom(2) や (/dev/urandom に対する) read(2) システムコールを 1 回しか呼ばないようです。よって、要求量が大きくて 1 回では文字列を準備できないとき(例えば
> ...
そんな気がします。一瞬エントロピー枯渇について心配しましたが、Rubyの側で小さいurandomを大量に呼べばどうせ枯渇するんだし
>2.Random.... -
02:41 PM Feature #13883: Change from gperf 3.0.4 to gperf 3.1
- Seems the code generated by gperf 3.1 without `-n` option has a problem with Apple clang.
```
defs/keywords:57:32: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorte... -
01:19 PM Bug #13887 (Closed): test/ruby/test_io.rb may get stuck with FIBER_USE_NATIVE=0 on Linux
- Eric Wong wrote in https://bugs.ruby-lang.org/issues/13875#note-5 [ruby-core:82708]
> However, test/ruby/test_io.rb seems stuck when FIBER_USE_NATIVE is 0
> ...
I can reproduce with `make optflags="-DFIBER_USE_NATIVE=0 -O0" test-all TE... -
12:35 PM Revision 83299c73 (git): merger.rb: separate logs
- * tool/merger.rb: separate each commit logs by an empty line.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59824 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:33 PM Bug #13877: BUG Unnormalized Fixnum value
- ruby_2_4 r59823 merged revision(s) 59765.
-
12:33 PM Revision cdf99310 (git): merge revision(s) 59765: [Backport #13877]
- ruby.h: unnormalized Fixnum value
* include/ruby/ruby.h (ST2FIX): fix unnormalized Fixnum value bug
on mingw/mswin. [ruby-core:82687] [Bug #13877]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59823 b... -
12:17 PM Bug #13874: String#valid_encoding? has side effects
- ruby_2_4 r59822 merged revision(s) 59763.
-
12:17 PM Revision 5edb9fab (git): merge revision(s) 59763: [Backport #13874]
- string.c: fix false coderange
* string.c (rb_enc_str_scrub): enc can differ from the actual
encoding of the string, the cached coderange is useless then.
[ruby-core:82674] [Bug #13874]
git-svn-id: svn+ssh://... -
11:52 AM Revision 73adee9d (git): cli_spec.rb: prefer BUNDLE_RUBY
- * spec/bundler/bundler/cli_spec.rb: prefer BUNDLE_RUBY over env
hack. on macOS 10.11 or later, some system commands, e.g.
/bin/sh and /usr/bin/env, clear DYLD_LIBRARY_PATH environment
variable which is necessary to run not-yet ins... -
10:28 AM Bug #13836: Null pointer dereference in defined_expr0()
- ruby_2_4 r59820 merged revision(s) 59644.
-
10:27 AM Revision 78c8ac46 (git): merge revision(s) 59644: [Backport #13836]
- parse.y: primary should not be 0
* parse.y (primary): should not be 0, since it can be a receiver.
[ruby-core:82447] [Bug #13836]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59820 b2dd03c8-39d4-4d8f-... -
10:10 AM Bug #13817: test/unit breaks Hash
- ruby_2_4 r59819 merged revision(s) 59613.
-
10:10 AM Revision c7754f58 (git): merge revision(s) 59613: [Backport #13817]
- vm_method.c: alias warning at refined method
* vm_method.c (rb_method_entry_make): suppress a warning at
refined method which will not be redefined.
[ruby-core:82385] [Bug #13817]
git-svn-id: svn+ssh://ci.ru... -
10:04 AM Bug #13861: Performance regressoion in Hash literal in Ruby 2.5.0-dev
- Seems this regression was fixed by https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?revision=59744&view=revision
Thank you for fixing!!!
### before
```
$ ./miniruby -v -Ilib -I../benchmark-ips/lib ~/tmp/bench.rb
ruby 2.5.0dev (20... -
06:15 AM Revision ba1820f2 (git): revert r59813 partially. TestGemRequire#test_realworld_default_gem is not contained in trunk.
- I would like to sync rubygems on ruby_2_4 branch to trunk
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59818 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:03 AM Revision 7adfa1a7 (git): merge revision(s) 59649: [Backport #13832]
- gc.c: restore cfp at finalizer
* gc.c (run_finalizer): restore cfp for the case an exception
raised in a finalizer. [ruby-core:82432] [Bug #13832]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59817 b... -
05:44 AM Revision db897cc3 (git): revert r59815 partially.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59816 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:36 AM Revision a2a0b976 (git): bump up RUBY_PATCHLEVEL
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59815 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:23 AM Revision 8ae151e7 (git): lib/rubygems: fix several vulnerabilities in RubyGems; bump to version 2.6.13.
- [Backport #13842]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:10 AM Revision fd41a384 (git): lib/rubygems: bump up RubyGems version to 2.6.12. [Backport #13842]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:54 AM Bug #13844: Toplevel returns should fire ensures
- ruby_2_4 r59812 merged revision(s) 59708.
-
04:53 AM Revision 1069d3f1 (git): merge revision(s) 59708: [Backport #13844]
- compile.c: ensure after toplevel return
* compile.c (iseq_compile_each0): toplevel returns should fire
ensures. [ruby-core:82492] [Bug #13844]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59812 b2dd0... -
03:49 AM Bug #13830: `rb_scan_args`'s result differs based on optimization level
- ruby_2_4 r59811 merged revision(s) 59624,59626.
-
03:49 AM Revision a1afdedf (git): merge revision(s) 59624,59626: [Backport #13830]
- ruby.h: fix rb_scan_args_trail_idx
* include/ruby/ruby.h (rb_scan_args_trail_idx): fix the case both
of optional and rest arguments are defined.
[ruby-core:82427] [Bug #13830]
* include/ruby/ruby.h (... -
03:21 AM Revision 42c2f3ee (git): BUNDLER_SPECS rquires a relative path with srcdir.
- default targets are all of bundler specs. if you run only
commands/add_spec.rb spec:
make test-bundler BUNDLER_SPECS=commands/add_spec.rb
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59810 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:58 AM Bug #13744: Spawn doesn't work with options of symbol keys generated dynamically
- ruby_2_4 r59809 merged revision(s) 59322,59325.
-
02:58 AM Revision 2d054e40 (git): merge revision(s) 59322,59325: [Backport #13744]
- process.c: handle dynamic :rlimit_* symbols in spawn execopts
* process.c (rb_execarg_addopt_rlimit): hoist out of rb_execarg_addopt
(rlimit_type_by_sym): new wrapper for dynamic symbol
(rb_execarg_addopt): c... -
02:46 AM Bug #13306: [DOC] rdoc for IO#puts
- ruby_2_4 r59808 merged revision(s) 57944,57977,58062.
-
02:46 AM Revision 428687e9 (git): merge revision(s) 57944,57977,58062: [Backport #13306]
- io.c: [DOC] IO#puts uses IO#write
io.c: [DOC] add missing `$`
io.c: [DOC] expand docs for IO#puts
[ruby-core:80081] [Bug #13306]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59808 b2dd03c8-39d4-... -
02:40 AM Bug #13616: Zlib::GzipReader#pos underflows after calling #ungetbyte or #ungetc at start of file
- ruby_2_4 r59807 merged revision(s) 58524,58525,58526,59333,59337.
-
02:40 AM Revision a935fe6f (git): merge revision(s) 58524,58525,58526,59333,59337: [Backport #13616]
- zlib.c: zstream_expand_buffer_non_stream
* ext/zlib/zlib.c (zstream_expand_buffer_non_stream): rename from
zstream_expand_buffer_without_gvl() and replace duplicate code
in zstream_expand_buffer().
zl... - 01:10 AM Revision 0b572d70 (git): * 2017-09-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@59806 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:10 AM Revision 97c6e393 (git): * lib/rubygems: fix several vulnerabilities in RubyGems; bump to version
- 2.4.5.3. [Backport #13842]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@59805 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:04 AM Bug #13842: Backport request: Rubygems-2.6.13
- I found to fail testcase on Ruby 2.2 used attached patch named "rubygems-2613-ruby22.patch".
I created additional patch for broken test.
It replaced `util_spec` to malicious `Gem::Specification` instance and invoke `Gem::Specificat...
09/09/2017
-
10:08 PM Revision 06af3b20 (git): runruby.rb: set envvars for bundler
- * tool/runruby.rb: set gem and bundler environment variables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59804 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:40 PM Bug #13886 (Closed): Seg Fault - eval - 59781 - MinGW
- While updating my doc site (https://msp-greg.github.io/) using 59781, I had a seg fault from an RDoc call to `eval`. I also tried with 59792, same seg fault.
Isolated to the offending string...
Log is attached. Code I used is:
... -
03:40 PM Bug #13885 (Closed): Random.urandom と securerandom について
- 遠藤です。
Random.urandom と securerandom の仕様について卜部さんと話していて、いくつか気になる点が出てきたので挙げておきます。
1. Random.urandom は、getrandom(2) や (/dev/urandom に対する) read(2) システムコールを 1 回しか呼ばないようです。よって、要求量が大きくて 1 回では文字列を準備できないとき(例えば Random.urandom(100_000_000) )、失... -
03:19 PM Revision 7451ec06 (git): Add a note to Random.urandom
- The method may return nil for some reasons.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59803 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:12 PM Revision 86d76173 (git): * 2017-09-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59802 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:12 PM Revision 782b2050 (git): Update a test of SecureRandom according to r57384
- SecureRandom uses urandom by default. So the test for a case where
openssl is unavailable makes no sense. Instead, a simple test for a
case where urandom is unavailable is added.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59801... -
02:22 PM Feature #13884 (Closed): Reduce number of memory allocations for "and", "or" and "diff" operations on small arrays
- Very often, arrays are used to filter parameters and to select interesting items from 2 collections and very often these collections are small enough, for example:
~~~ ruby
SAFE_COLUMNS = [:id, :title, :created_at]
def columns
... - 02:06 PM Revision 1433d433 (git): asn1: fix out-of-bounds read in decoding constructed objects
- * OpenSSL::ASN1.{decode,decode_all,traverse}: have a bug of
out-of-bounds read. int_ossl_asn1_decode0_cons() does not give the
correct available length to ossl_asn1_decode() when decoding the
inner components of a constructed objec... - 01:58 PM Revision 842d5cff (git): * ext/json: bump to version 1.8.3.1. [Backport #13853]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59799 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:57 PM Revision c01bca25 (git): * ChangeLog: forgotten to commit
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59798 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:50 PM Bug #13852: Backport r59693,59695 (Net::HTTP should raise error when CR/LF in a http header value)
- ruby_2_3 r59797 merged revision(s) 59693,59695.
- 01:50 PM Revision add06009 (git): merge revision(s) 59693,59695: [Backport #13852]
- A HTTP Header value must not contain CR or LF.
to_str -> to_s
* lib/net/http/header.rb (set_field): `val` can not have `to_str`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59797 b2dd03c8-39d4-4d8f-98... -
01:42 PM Bug #13850: backport r59584
- ruby_2_3 r59796 merged revision(s) 59584.
- 01:42 PM Revision dbe8e9c5 (git): merge revision(s) 59584: [Backport #13850]
- REXML: Fix a bug that unexpected methods can be called as a XPath function
[HackerOne:249295]
Reported by Andrea Jegher. Thanks!!!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59796 b2dd03c8-39d4-4d8f... - 01:37 PM Revision afc45931 (git): * lib/rubygems: fix several vulnerabilities in RubyGems; bump to version
- 2.5.2.1. [Backport #13842]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59795 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:09 PM Revision 0919c055 (git): Support LCOV visualization for both C and Ruby code
- `./configure --enable-gcov && make exam && make lcov` will create
`lcov-c-out/index.html` for coverage of C code of the interpreter.
`make exam COVERAGE=true && make lcov` will create
`lcov-rb-out/index.html` for coverage of Ruby stdlib ... - 12:24 PM Revision 366c5481 (git): * ext/psych/yaml: update libyaml to 0.1.7.
- * ext/psych/psych.gemspec: bump version to 2.0.8.1.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@59793 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:30 AM Revision 19ae6bc7 (git): spec/bundler/support: paths for ruby core
- * spec/bundler/support/path.rb (Spec::Path#for_ruby_core?): helper
method to tell whether running in Ruby Core or not.
* spec/bundler/support/helpers.rb (Spec::Helpers#bundle): use
Path.bindir for ruby core case.
* spec/bundler/sup... -
11:30 AM Revision 4054b123 (git): Makefile.in: test-bundler-prepare
- * Makefile.in (test-bundler-prepare): install with --install-dir
option instead of GEM_HOME and GEM_PATH environment variables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59791 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:20 AM Revision 85cb9231 (git): rubygems_ext.rb: use BUNDLE_GEM
- * spec/bundler/support/rubygems_ext.rb (install_gems): use
BUNDLE_GEM set in Makefile.in instead of the installed command.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59790 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:16 AM Revision 067d9e9c (git): sprintf.c: NULL as str
- * sprintf.c (ruby_vsnprintf, ruby_snprintf): allow NULL as str,
just count the expected buffer size.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59789 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:16 AM Revision 6c3c48e3 (git): compile.c: replaced switch by TYPE
- * compile.c (int_param): prefer FIXNUM_P and NIL_P to switch by
TYPE.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59788 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:34 AM Revision 0471781b (git): Sync .gitignore and svn:ignore and cleanup [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59787 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:16 AM Feature #13883 (Closed): Change from gperf 3.0.4 to gperf 3.1
- There are several places in Ruby where gperf 3.0.4 is assumed.
The newest version of gperf is 3.1. In the long term, we should update Ruby so that it can be compiled with gperf 3.1. -
02:06 AM Feature #13109: `using` in refinements is required to be physically placed before the refined method call
- Feature #13805 proposed to activate refinements across multiple files without an explicit `using` in every file.
09/08/2017
-
11:51 PM Bug #13875 (Closed): segfault in Enumerable#zip after GC - Applied in changeset trunk|r59785.
----------
fiber: fix machine stack marking when FIBER_USE_NATIVE is 0
* cont.c (cont_mark): mark Fiber machine stack correctly when
FIBER_USE_NATIVE is 0
* test/ruby/test_fiber.rb (test_mark_fiber)... -
06:41 AM Bug #13875: segfault in Enumerable#zip after GC
- Thank you both for the extra info, I think there's a different
bug for FIBER_USE_NATIVE=0 on my GNU/Linux system...
Anyways, for this segfault here is an updated v2 patch (for
r59776) which I'll commit soonish:
https://80x24.org... -
04:51 AM Bug #13875: segfault in Enumerable#zip after GC
- kernigh (George Koehler) wrote:
> Eric Wrong wrote:
> ...
Some additional background: the OpenBSD ports for ruby also skip this test. The fifo pthread fdlock bug has been in OpenBSD probably since it moved from userland threads to ker... -
02:48 AM Bug #13875: segfault in Enumerable#zip after GC
- Jeremy Evans wrote:
> Note that OpenBSD-current uses clang 4.0.0 as the system compiler, as opposed to OpenBSD 6.1 and previous versions, which use gcc 4.2.1.
Thanks for testing with clang. You showed that the bug wasn't only with gc... -
11:51 PM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- cardoso_tiago@hotmail.com wrote:
> Buffers are indeed attached per socket, but I wouldn't say
> they are short-lived. Also, I don't have guarantees that the
> same thread will handle the same socket after a wait, so I
> can't follow... -
11:00 AM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- > but I think my earlier note about using thread-local storage for short-lived buffers still applies. Per-socket buffers (which you seem to be using) would use more object slots in common situations.
Buffers are indeed attached per so... -
01:51 AM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- On 2017/09/08 06:11, Eric Wong wrote:
> cardoso_tiago@hotmail.com wrote:
>> So, after I found that out, I noticed something really
>> strange: Using the `IO#read_nonblock(nread, buffer, exception:
>> false)` reduces the throughput... - 11:51 PM Revision 4e61282c (git): * 2017-09-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59786 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:51 PM Revision 01fdd48f (git): fiber: fix machine stack marking when FIBER_USE_NATIVE is 0
- * cont.c (cont_mark): mark Fiber machine stack correctly when
FIBER_USE_NATIVE is 0
* test/ruby/test_fiber.rb (test_mark_fiber): new test
[Bug #13875] [ruby-core:82681]
This bug appears to be introduced with r59557.
("refactoring Fi... -
08:17 PM Bug #13882 (Closed): Exception in `ensure` stops threads from exiting
- When the Ruby process is gracefully exiting, if a thread has an exception during an `ensure` block it appears the Ruby process forgets it's attempting to exit and will keep running forever. Since there's still an alive thread, `rb_thread...
-
02:38 PM Bug #13796: Please backport r59567 (openssl: import v2.0.5)
- ruby_2_4 r59784 merged revision(s) 59567.
-
02:38 PM Revision f0129322 (git): merge revision(s) 59567: [Backport #13796]
- openssl: import v2.0.5
Import Ruby/OpenSSL 2.0.5. The full commit history since v2.0.4
(imported at r59081) can be found at:
https://github.com/ruby/openssl/compare/v2.0.4...v2.0.5
This will fix... -
02:27 PM Bug #13852: Backport r59693,59695 (Net::HTTP should raise error when CR/LF in a http header value)
- ruby_2_4 r59783 merged revision(s) 59693,59695.
-
02:27 PM Revision 48d78028 (git): merge revision(s) 59693,59695: [Backport #13852]
- A HTTP Header value must not contain CR or LF.
to_str -> to_s
* lib/net/http/header.rb (set_field): `val` can not have `to_str`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59783 b2dd03c8-39d4-4d8f-98... -
02:25 PM Bug #13850: backport r59584
- ruby_2_4 r59782 merged revision(s) 59584.
-
02:25 PM Revision 05bc6eb4 (git): merge revision(s) 59584: [Backport #13850]
- REXML: Fix a bug that unexpected methods can be called as a XPath function
[HackerOne:249295]
Reported by Andrea Jegher. Thanks!!!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59782 b2dd03c8-39d4-4d8f... -
09:13 AM Feature #13881: Use getcontext/setcontext on OS X
- I found `getcontext` on High Sierra(10.17) beta.
```
~ > grep getcontext /usr/include/ucontext.h
int getcontext(ucontext_t *) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_5, __MAC_10_6, __IPHONE_2_0, __IPHONE_2_0) __WATCHOS_PROHIBITED _... -
09:10 AM Feature #13881 (Open): Use getcontext/setcontext on OS X
- getcontext/setcontext is first appeared on OS X 10.5 but deprecated on 10.6.
It seems because POSIX removed them from recent specs.
IEEE Std 1003.1, 2004 Edition says makecontext's use of function declarators with empty parentheses
... -
08:50 AM Revision 5804d24f (git): Rollback to v1.15.4 version.
- In r59779, it contains current master version of bundler repository.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59781 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:45 AM Feature #12733 (Closed): Bundle bundler to ruby core
- Applied in changeset trunk|r59779.
----------
Merge bundler to standard libraries.
rubygems 2.7.x depends bundler-1.15.x. This is preparation for
rubygems and bundler migration.
* lib/bundler.rb, lib/bundler/*: files of bundler-... - 08:45 AM Revision 1bc6b966 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59780 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:45 AM Revision 8598f8c2 (git): Merge bundler to standard libraries.
- rubygems 2.7.x depends bundler-1.15.x. This is preparation for
rubygems and bundler migration.
* lib/bundler.rb, lib/bundler/*: files of bundler-1.15.4
* spec/bundler/*: rspec examples of bundler-1.15.4. I applied patches.
* h... -
08:03 AM Revision f2e04b77 (git): configure.in: moved flags
- * configure.in (-DRUBY_DEVEL): moved from debugflags to XCFLAGS.
this flags should be applied to the ruby core only.
* configure.in (-fno-fast-math): moved from optflags to CFLAGS.
this flag is not for optimization.
git-svn-id: svn... -
07:22 AM Revision b3907bb5 (git): fix up r59776
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59777 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:21 AM Revision 8e037913 (git): move th->fiber to ec->fiber.
- * vm_core.h (rb_thread_t::fiber): move fiber field to
rb_execution_context_t::fiber.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59776 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:33 AM Revision eb99ed16 (git): Update latest bundled-gems.
- * minitest 5.10.3
* test-unit 3.2.5
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59775 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:18 AM Revision 08c1dde4 (git): fix a label for bundled gems.
- "bundle gems" is a wrong name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59774 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:12 AM Bug #13878 (Third Party's Issue): I can't install ruby on kali linux
09/07/2017
-
11:05 PM Bug #13878: I can't install ruby on kali linux
- nobu (Nobuyoshi Nakada) wrote:
> sasatefa2009 (Mostafa Nafady) wrote:
> ...
Indeed that was the case, i un-installed it, and installed the latest version of ruby successfully and everything now works very well. Thank you very much.
-
06:50 AM Bug #13878: I can't install ruby on kali linux
- This is a very unusual gem, sasatefa2009.
https://rubygems.org/gems/make
It is meant for SQL.
Ruby itself comes bundled with a few internal gems; the "make" gem is not one of them.
You probably have another ruby version; th... -
06:04 AM Bug #13878: I can't install ruby on kali linux
- sasatefa2009 (Mostafa Nafady) wrote:
> ```
> ...
Uninstall this broken gem. -
04:44 AM Bug #13878: I can't install ruby on kali linux
- i got a new error after attempting to install after using "rvm cleanup all"
~~~ text
root@kali:~# \curl -sSL https://get.rvm.io | bash -s stable --ruby
Downloading https://github.com/rvm/rvm/archive/1.29.2.tar.gz
Downloading https:... -
04:38 AM Bug #13878 (Third Party's Issue): I can't install ruby on kali linux
- Greetings,
My ruby version is ruby 2.3.3p222 (2016-11-21) [x86_64-linux-gnu]
I had multiple error while trying to install ruby in Kali-linux
"\curl -sSL https://get.rvm.io | bash -s stable --ruby"
also "rvm install ruby-2.4.1" i... -
09:24 PM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- cardoso_tiago@hotmail.com wrote:
<snip>
Thanks for the followup, I'm glad we were able to help.
> I think this one is fixed. If I could complain about
> something, was that the error message wasn't very helpful. But
> I can't c... -
05:57 PM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- Again, false alarm... The problem was that I wasn't checking the return value of `IO#read_nonblock(nread, buffer, exception: false)`, thereby not checking if nil and terminating early (nil equals EOF). This was affecting the throughput s...
-
05:45 PM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- I've finally managed to isolate the issue, and found the issue: it was my error. Basically what was happening was that I was monitoring fds for read/write events; sometimes, the same fd returns for read/write, and in those loops, I was s...
-
07:41 PM Bug #13875: segfault in Enumerable#zip after GC
- Thanks, I can reproduce the bug on GNU/Linux with:
--- a/cont.c
+++ b/cont.c
@@ -57,6 +57,7 @@
# define FIBER_USE_NATIVE 1
# endif
#endif
+#undef FIBER_USE_NATIVE
#if !defined(FIBER_USE_NATIVE)
#define FIBER_USE_NATIVE ... -
01:53 AM Bug #13875: segfault in Enumerable#zip after GC
- normalperson (Eric Wong) wrote:
> xkernigh@netscape.net wrote:
> ...
No. It is set to 0 on OpenBSD.
> Does the problem go away if you flip that?
It doesn't compile, as ucontext.h is not available on OpenBSD:
cont.c:68:10: fat... -
01:04 AM Bug #13875: segfault in Enumerable#zip after GC
- In reply to Eric Wong:
FIBER_USE_NATIVE is 0. Flipping it to 1 causes compiler errors; OpenBSD doesn't have \<ucontext.h\>.
I'm using the system gcc, which is `gcc (GCC) 4.2.1 20070719`. I configured Ruby with `../ruby/configure --... - 05:45 PM Revision 7b2e74be (git): the working directory may not be srcdir
- * test/runner.rb (COVERAGE): should use require_relative instead of require,
because the working directory may not be srcdir.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59773 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:52 PM Bug #13857: frozen string literal: can freeze same string into two unique frozen strings
- I expect String#freeze to return the receiver. For example,
```ruby
str = "Content-Length".downcase
str.freeze # freezes and returns str
str.concat(": ") # raises RuntimeError: can't modify frozen String
```
I know that... - 03:40 PM Revision 97fbcdd0 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59772 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:40 PM Revision 899d6f9c (git): * 2017-09-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59771 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:40 PM Revision ccaf52e2 (git): Measure the test coverage without SimpleCov
- Now `make test-all COVERAGE=true` measures the test coverage by using
`coverage.so` directly, and visualize the result by simplecov-html.
There has been some problems in coverage measurement with SimpleCov.
(They are not SimpleCov's fau... -
01:33 PM Bug #13880 (Closed): `BigDecimal(string)` should raise on invalid values in `string`
- Right now `BigDecimal()` behaviour differs from `Integer()` and `Float()`:
```
2.4.1 :001 > require 'bigdecimal'
=> true
2.4.1 :002 > BigDecimal('1,')
=> 0.1e1
2.4.1 :003 > Integer('1,')
ArgumentError: invalid value for Integer... -
12:36 PM Revision 1a643bac (git): Remove unneeded trace instruction for coverage
- When no instruction is emitted in `iseq_compile_each0`
(i.e., when the line has no significant code), trace
instruction for `RUBY_EVENT_LINE` has been optimized out.
But trace for `RUBY_EVENT_COVERAGE` has not been removed.
Now, it is al... -
12:31 PM Revision af325705 (git): Use `%i`-literal instead of array of symbols
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59768 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:13 PM Feature #13770: Can't create valid Cyrillic-named class/module
- The whole patch is https://github.com/nobu/ruby/tree/feature/13770-nonascii-const-name
-
12:12 PM Feature #13770: Can't create valid Cyrillic-named class/module
- duerst (Martin Dürst) wrote:
> In the patch, I suggest adding something like
> ...
I changed these code as followings:
```c
if (rb_enc_isalpha(c, enc)) {
/* non-lower case alphabet should be upper/title case */
... -
11:57 AM Bug #13879 (Rejected): [Not sure if a bug or not] case/when menus and trailing ',' commas in when clauses
- That `when` clause continues by the last comma, so your example equals the following code syntactically.
```ruby
x = 'foobar'
case x
when 'a','b','c', x = 5
end
puts x
```
```ruby
x = 'foobar'
case x
when 'a','b','c', puts 5... -
10:51 AM Bug #13879: [Not sure if a bug or not] case/when menus and trailing ',' commas in when clauses
- I forgot to add - I assume that the puts invocation may lead to
trigger the above behaviour. My main confusion is why the ','
placed matters, depending on as to whether one does an assignment,
or invokes a method instead. I would hav... -
10:49 AM Bug #13879 (Rejected): [Not sure if a bug or not] case/when menus and trailing ',' commas in when clauses
- Hello,
I am not sure if the following is a bug or a feature.
```ruby
x = 'foobar'
case x
when 'a','b','c',
x = 5
end
puts x
```
Works fine.
But this here:
```ruby
x = 'foobar'
case x
when 'a','b','c',
puts 5... -
10:26 AM Feature #8499: Importing Hash#slice, Hash#slice!, Hash#except, and Hash#except! from ActiveSupport
- I just rebased it to trunk.
-
08:44 AM Feature #13109: `using` in refinements is required to be physically placed before the refined method call
- razum2um (Vlad Bokov) wrote:
> matz (Yukihiro Matsumoto) wrote:
> ...
I don't think Matz meant a specific already existing issue. I think it should be proposed as a new, separate issue. -
06:55 AM Feature #13109: `using` in refinements is required to be physically placed before the refined method call
- matz (Yukihiro Matsumoto) wrote:
> There may be an idea to use refinement without explicit `using`. But that's out of the scope of this issue.
> ...
Very interesting, @Matz, please, could you refer to the issue of non-explicit `using`? -
08:25 AM Bug #13854 (Closed): `make golf` broken
- Applied in changeset trunk|r59767.
----------
common.mk: fix golf
* common.mk (golf): MAINOBJ must be single object file name, so
moved golf_prelude to EXTOBJS. [ruby-dev:50214] [Bug #13854] -
08:25 AM Revision 99d989be (git): common.mk: fix golf
- * common.mk (golf): MAINOBJ must be single object file name, so
moved golf_prelude to EXTOBJS. [ruby-dev:50214] [Bug #13854]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59767 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:10 AM Bug #13864: Rinda multicast test failures due to missing default route
- shevegen (Robert A. Heiler) wrote:
> Well no surprise - the systemd guys know better than any standard ever written, too. ;)
Honestly, this might happen for Docker, real/virtual machines without network interface, real/virtual machin... -
03:24 AM Bug #13877 (Closed): BUG Unnormalized Fixnum value
- Applied in changeset trunk|r59765.
----------
ruby.h: unnormalized Fixnum value
* include/ruby/ruby.h (ST2FIX): fix unnormalized Fixnum value bug
on mingw/mswin. [ruby-core:82687] [Bug #13877] -
12:27 AM Bug #13877 (Closed): BUG Unnormalized Fixnum value
- enviroment
Windows 10 15063.540 x64
how to simulate it
~~~
require 'date'
Date.today.hash
~~~
reproducable on current trunk and ruby 2.4.1p111 (2017-03-22 revision 58053) [x64-mingw32]
can't reproduce on Linux
~~~
C:/Ru... - 03:24 AM Revision 1ba5d0e7 (git): * 2017-09-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59766 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:24 AM Revision 65b87de3 (git): ruby.h: unnormalized Fixnum value
- * include/ruby/ruby.h (ST2FIX): fix unnormalized Fixnum value bug
on mingw/mswin. [ruby-core:82687] [Bug #13877]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59765 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:10 AM Bug #13853: Backport request r58323
- > Vit
Thanks. I update my patch. -
12:26 AM Bug #13848: BigDecimal.new('200.') raises an exception
- `Float('200.')` also raises ArgumentError. In this way, BigDecimal.new seems consistent with Float. But it's strange that `Float('200hello world')` raises ArgumentError but `BigDecimal.new('200hello world')` succeeds.
-
12:19 AM Bug #13846: Openbsd possible memory leak when using Thread
- I can reproduce this bug in 2.3 and 2.4 but not in trunk. I am using 2.3 and 2.4 from OpenBSD packages. I compiled trunk from source.
```
$ dmesg | head -2
OpenBSD 6.1 (GENERIC.MP) #19: Thu Aug 3 14:59:44 CEST 2017
robert@sysp...
09/06/2017
-
11:08 PM Bug #13875: segfault in Enumerable#zip after GC
- xkernigh@netscape.net wrote:
> https://bugs.ruby-lang.org/issues/13875#change-66516
<snip>
> But this trick might not be the correct fix. I fear a problem
> with fibers, because there is a fiber switch when zip_i()
> calls Enum... -
08:54 PM Bug #13875: segfault in Enumerable#zip after GC
- The problem is with `VALUE tmp;` in enum.c zip_i(). The garbage collector frees tmp too early. I try to protect it with RB_GC_GUARD(tmp), but this doesn't fix the bug. Ruby still crashes.
```diff
diff --git a/enum.c b/enum.c
index 4... -
07:28 PM Bug #13875 (Closed): segfault in Enumerable#zip after GC
- There is a chance of segmentation fault in Enumerable#zip after garbage collection. This script reproduces the crash.
```ruby
GC.stress = true
up = 1.upto(10)
down = 10.downto(1)
up.zip(down) {|a, b| a + b == 11 or fail 'oops'}
... -
10:08 PM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- cardoso_tiago@hotmail.com wrote:
> > What operation(s) are you doing for "socket monitoring"?
>
> i'm using plain IO.select. So the idea is, I have a selector
> thread, which pushes ready descriptors to a queue; other
> threads pu... -
12:21 PM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- > What operation(s) are you doing for "socket monitoring"?
i'm using plain IO.select. So the idea is, I have a selector thread, which pushes ready descriptors to a queue; other threads pull from that queue, and read/write from descrip... -
09:15 PM Bug #13876 (Closed): Tempfile's finalizer can be interrupted by a Timeout exception which can cause the process to hang
- Ruby hangs if a Timeout is raised when a Tempfile's finalizer is run.
This also happens on ruby 2.3.4 on OSX. I could only recreate this on linux once but not reliably. Maybe the finalizer runs at a different and unpredictable time ... -
06:29 PM Bug #13872: Duplicate assignment no longer silences "assigned but unused variable" warning
- Well, the first could be solved if there is some way to also propagate (local) variables towards ERB
or other bindings. Like to have different binding "levels" available. Copy environments and stuff. :D
(Actually ... one could probably... -
03:43 PM Bug #13872: Duplicate assignment no longer silences "assigned but unused variable" warning
- Previously, `foo = foo = "bar"` was used as a workaround. Now that the workaround is "fixed", I see incoming PRs changing the workaround to `foo = "bar"; foo = foo`.
It would be nice if we had a way to handle these false positives dir... -
02:42 PM Bug #13874: String#valid_encoding? has side effects
- 2.2.6 and later need the backport.
-
01:11 PM Bug #13874 (Closed): String#valid_encoding? has side effects
- Applied in changeset trunk|r59763.
----------
string.c: fix false coderange
* string.c (rb_enc_str_scrub): enc can differ from the actual
encoding of the string, the cached coderange is useless then.
[ruby-core:82674] [Bug #13874] -
12:12 PM Bug #13874: String#valid_encoding? has side effects
- Also reproducible on `ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-linux]`
Not reproducible on `ruby 2.2.5p319 (2016-04-26 revision 54774) [x86_64-linux]`. Both calls result in `"\xE5"`
-
10:05 AM Bug #13874 (Closed): String#valid_encoding? has side effects
- I noticed the result of `String#encode` changes after a call to `String#valid_encoding?`. Other side effects were not visible so far.
Based on the documentation and intuition I would expect `#valid_encoding?` to be an operation withou... -
01:46 PM Revision 0f25c6d7 (git): Fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59764 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:11 PM Revision bd10ce16 (git): string.c: fix false coderange
- * string.c (rb_enc_str_scrub): enc can differ from the actual
encoding of the string, the cached coderange is useless then.
[ruby-core:82674] [Bug #13874]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59763 b2dd03c8-39d4-4d8f-98... -
01:06 PM Bug #13853: Backport request r58323
- The patch is not patching version in json.gemspec, but it should ...
~~~diff
--- ext/json/json.gemspec
+++ ext/json/json.gemspec
@@ -1,6 +1,6 @@
Gem::Specification.new do |s|
s.name = "json"
- s.version = "1.8.3"
+ s.vers... -
12:50 PM Revision faa26f55 (git): string.c: optimize enumerate_grapheme_clusters
- * string.c (rb_str_enumerate_grapheme_clusters): optimize when
single byte only.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59762 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:04 AM Feature #13770: Can't create valid Cyrillic-named class/module
- As mentioned at the last committers' meeting, I think the patch will not work e.g. for upper-case characters in three-byte EUC-JP (characters from JIS X 0212) because the necessary data isn't there (see #11859).
-
09:54 AM Feature #13770: Can't create valid Cyrillic-named class/module
- sb (Sergey Borodanov) wrote:
> Same error with module creating and same behavior in **irb** (please, see attachment). At the same time Cyrillic-named constants and methods work fine.
Methods indeed should work fine, because current... -
09:45 AM Feature #13770: Can't create valid Cyrillic-named class/module
- I have checked for upper-case letters without corresponding lower-case letters, with the following short script:
```
ruby -n -e 'l=$_.split(/;/); if l[2]=="Lu" && l[13]=="" then puts l[1];end' <UnicodeData.txt
```
Somewhat contr... -
09:31 AM Feature #8948: Frozen regex
- Now we can't run `make test-all` because `test/lib/test/unit.rb` defines singleton method for a regexp object.
```ruby
def non_options(files, options)
filter = options[:filter]
if filter
pos_pat = /... -
08:19 AM Feature #13685 (Closed): Update Unicode data to Unicode Version 10.0.0
- Applied in changeset trunk|r59761.
----------
add mention of upgrade to Unicode 10.0.0 to NEWS file
(this completes [Feature #13685]; [ci skip]) -
07:56 AM Feature #13685: Update Unicode data to Unicode Version 10.0.0
- Working on this now. Just some notes for future, similar issues:
At the moment, using gperf 3.0.4 (rather than gperf 3.1) seems to be important for smooth sailing.
Also, the important make target is `all-incs`. In addition, the tar... -
08:19 AM Revision 1704e7a6 (git): add mention of upgrade to Unicode 10.0.0 to NEWS file
- (this completes [Feature #13685]; [ci skip])
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59761 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:12 AM Revision df155f09 (git): remove Unicode 9.0.0-related files
- We don't need these files anymore because we upgraded to Unicode 10.0.0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59760 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:56 AM Revision 04547c7d (git): update Ruby to Unicode 10.0.0
- - In common.mk, set UNICODE_VERSION to 10.0.0
- Generate and add enc/unicode/10.0.0/casefold.h and
enc/unicode/10.0.0/name2ctype.h
- Update lib/unicode_normalize/tables.rb
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59759 b2dd0... -
07:46 AM Revision 3122b0ba (git): Update SimpleCov version (v0.10.0 -> v0.15.0)
- To suppress warnings of Fixnum.
Also simplecov-html updated (v0.10.0 -> v0.10.2).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59758 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:34 AM Feature #13847: Gem activated problem for default gems
- We discussed this issue on last Developer Meeting.
Matz has some concerns about ruby internal.
1. Conflicts versions of a shared library like libyaml-*., libssl-*, libffi, etc...
2. Order of LOADED_FEATURE
So, This feature is d... -
05:00 AM Feature #12733: Bundle bundler to ruby core
- vo.x (Vit Ondruch) wrote:
> I don't understand it. Why is it not simple bundled gem similartly to minitest, test-unit, rake, etc? This gems broken to Ruby directories were always the worst idea. It could make sense when Ruby have not sh... -
04:39 AM Feature #12733: Bundle bundler to ruby core
- I don't understand it. Why is it not simple bundled gem similartly to minitest, test-unit, rake, etc? This gems broken to Ruby directories were always the worst idea. It could make sense when Ruby have not shipped with Rubygems, but nowa...
-
02:37 AM Feature #12733: Bundle bundler to ruby core
- I update my working branch.
https://github.com/ruby/ruby/pull/1536
Changes in this branch:
#### Directory Structure
I organized bundler integration like this:
```
root -+- lib -+- bundler/*
| |
|... -
04:29 AM Bug #12036: Enumerator's automatic rewind behavior
- I don't want Ruby to change this behavior. Enumerable#next can't continue the iteration if it raises an exception. That's why it has the automatic rewind behavior.
Here's a quick example. In this script, we handle the oops and expect ... -
03:53 AM Revision ee0b1b20 (git): Fixed compilationn error with VMDEBUG=3.
- [fix GH-1690] Patch from @musaprg(Kotaro Inoue)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59757 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:39 AM Revision 7119de47 (git): accept ec instead of th.
- * vm.c: VM_EP_IN_HEAP_P() and vm_ep_in_heap_p_() only requires ec
pointed from th.
* vm.c (rb_execution_context_mark): GET_THREAD() returns current
running thread and we need to use marking thread here. Pass marking
thread's ec in... -
03:18 AM Revision e4139095 (git): th is not defined
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59755 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:51 AM Revision b95d9e66 (git): thread_context -> execution_context
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59754 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:47 AM Revision d687dc9c (git): * 2017-09-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59753 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:46 AM Revision 366157d3 (git): rb_execution_context_mark.
- * vm.c (rb_execution_context_mark): separate from thread_mark().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59752 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:19 AM Bug #13865 (Closed): Triggered segfault, on Ruby2.4/OSX.
- Per your request, I have closed this.
-
01:03 AM Bug #13865: Triggered segfault, on Ruby2.4/OSX.
- Hi.
This is fixed on 2.5.0:
```
2] pry(main)> _pry_.h.deprecate_method! Object.methods.map{|m| Object.method(m) }, "everything is deprecated"
Traceback (most recent call last):
5405: from bin/pry:12:in `<main>'
5404: from ../...
09/05/2017
-
08:11 PM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- cardoso_tiago@hotmail.com wrote:
> The problem is that I'm doing all socket monitoring in one
> thread, and read/write operations on another. Is there any
> thread-unsafety associated with such operations happening at
> the same tim... -
05:26 PM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- I've been struggling to create a self-contained script to reproduce the problem, but can't seem to.
The problem is that I'm doing all socket monitoring in one thread, and read/write operations on another. Is there any thread-unsafety... -
05:51 PM Feature #13873 (Closed): Optimize Dir.glob with FNM_EXTGLOB
- Rails often queries Dir.glob with complex pattern.
On accessing Rails site, it calls glob as follows on querying templates.
Note that Dir[] insists File::FNM_EXTGLOB.
```ruby
def find_template_paths(query)
Dir[quer... -
05:43 PM Feature #13821: Allow fibers to be resumed across threads
- Fibers still can't move across threads in
```
ruby 2.5.0dev (2017-09-04 trunk 59742) [x86_64-openbsd6.1]
```
Because of this, I can't take an Enumerator across threads:
```ruby
count = 1.step
puts count.next #=> 1
puts c... -
05:18 PM Bug #11147 (Closed): [SEGFAULT] While looping gets
- Closing since I was never able to reproduce the issue myself
-
05:17 PM Bug #13872 (Closed): Duplicate assignment no longer silences "assigned but unused variable" warning
- On ruby 2.4.1:
`ruby -W -e 'def a; var = var = "foo"; end'`
prints no warning
On ruby 2.5.0dev (2017-09-04 trunk 59742) [x86_64-darwin16]
`ruby -W -e 'def a; var = var = "foo"; end'`
prints warning `-e:1: warning: assigned... -
04:52 PM Misc #13871 (Closed): Remove commented out code of URI::HTTP.new
- It's treated as document for URI::HTTP#request_uri:
https://ruby-doc.org/stdlib-2.4.0/libdoc/uri/rdoc/URI/HTTP.html#method-i-request_uri
It's broken, so the commented out code should be removed.
It's the same type problem of htt... -
04:37 PM Misc #13870 (Closed): Remove commented out code of SecureRandom.random_number
- It's treated as document for Random::Formatter#uuid:
https://ruby-doc.org/stdlib-2.4.0/libdoc/securerandom/rdoc/Random/Formatter.html#method-i-uuid
The commented out code should be removed. -
02:30 PM Feature #13869 (Open): Filter non directories from Dir.glob
- Dir.glob is a tool to fetch filesystem entries with filtering.
On Rails, it often query files from template directories with braces (FNM_EXTGLOB)
https://github.com/rails/rails/blob/6f1c18308ebffc97d51440cdeed7be71de58f26a/actionview... -
11:51 AM Bug #13863: RUBYLIB にカレントディレクトリを設定した場合、-E cp932:utf-8 を指定するとスクリプトが全く実行されない
- > あとは、RUBYLIB の場合だけで、-I などでは問題ないようですね。なるほど。
そうですね。
a2.rb で -I. を使用する場合だと、require が失敗するだけで、
いきなり終了する現象は出ません。
require が失敗するケースも対策されるとうれしいです。
-
07:37 AM Bug #13863: RUBYLIB にカレントディレクトリを設定した場合、-E cp932:utf-8 を指定するとスクリプトが全く実行されない
- あー、再現しました。ありがとうございます。
> カレントディレクトに日本語を含む
これがすっぽ抜けてました。
あとは、`RUBYLIB` の場合だけで、`-I` などでは問題ないようですね。なるほど。 -
04:14 AM Bug #13863: RUBYLIB にカレントディレクトリを設定した場合、-E cp932:utf-8 を指定するとスクリプトが全く実行されない
- 仕事で使用している Windows 7 64bit の環境で試しましたが、現象発生します。
こちらで確認している条件は次の2点です。
* カレントディレクトに日本語を含む
* RUBYLIB に . 設定されている
ログを貼ります(プロンプトが2行になっています)が、どうでしょうか。
~~~
C:\usr\sandbox\ruby\req\テスト
$type a.rb
puts 'a'
require'./b'
C:\usr\sa... -
11:08 AM Feature #13867: Copy offloading in IO.copy_stream
- glass.saga@gmail.com wrote:
> In linux 4.5, the copy offloading feature with copy_file_range(2) was introduced.
> This patch enables IO.copy_stream to use it.
Cool.
> If "offload" keyword argument is specified, IO.copy_stream wi... -
09:06 AM Feature #13867 (Closed): Copy offloading in IO.copy_stream
- In linux 4.5, the copy offloading feature with copy_file_range(2) was introduced.
This patch enables IO.copy_stream to use it.
If "offload" keyword argument is specified, IO.copy_stream will try copy offloading.
```ruby
IO.copy_str... -
10:46 AM Bug #13412: Infinite recursion with define_method may cause silent SEGV or cfp consistency error
- Hmm... r59630 seems to be too hard to backport.
I had to cherry-pick r58328, r58353, r58354, r58374, r58377 and r58379 before cherry-picking r59630.
They are too many.
```
$ git checkout origin/ruby_2_4 && git checkout -B work &&
... -
10:18 AM Bug #13868 (Closed): Compile error on cygwin: No rule to make 'ossl_pkcs5.h', needed by 'ossl.o'
- usa (Usaku NAKAMURA) wrote:
> try `make clean`
That seems to have solved the problem, but it looks like a very heavy tool. -
09:42 AM Bug #13868: Compile error on cygwin: No rule to make 'ossl_pkcs5.h', needed by 'ossl.o'
- try `make clean`
-
09:40 AM Bug #13868: Compile error on cygwin: No rule to make 'ossl_pkcs5.h', needed by 'ossl.o'
- The file was deleted in r59734, at ext/openssl/ossl_pkcs5.h.
Except in doc/ChangeLog-1.9.3, I cannot find any traces of the string "ossl_pkcs5", while the strings "ossl_pkcs7" and "ossl_pkcs12" appear frequently. But the error still p... -
09:29 AM Bug #13868 (Closed): Compile error on cygwin: No rule to make 'ossl_pkcs5.h', needed by 'ossl.o'
- When I try to compile my latest checkout on cygwin, I repeatedly get the following error:
```
make[2]: Entering directory '/cygdrive/c/Data/ruby/ext/openssl'
make[2]: *** No rule to make target 'ossl_pkcs5.h', needed by 'ossl.o'. S... -
09:47 AM Revision d68a6b3e (git): openssl: merge test fixes from upstream
- Fix platform-dependent or fragile test cases added by r59734. This is a
combined patch of the three commits below:
4fc17977350a test/test_fips: skip if setting FIPS mode fails
b25179fbeebf test/test_asn1: fix possible fa... -
09:05 AM Feature #13866 (Rejected): Copy offloading in IO.copy_stream
- 間違えてruby-devに投げてしまったので、rejectします。
-
08:57 AM Feature #13866 (Rejected): Copy offloading in IO.copy_stream
- In linux 4.5, the copy offloading feature with copy_file_range(2) was introduced.
This patch enables IO.copy_stream to use it.
If "offload" keyword argument is specified, IO.copy_stream will try copy offloading.
```ruby
IO.copy_str... -
08:25 AM Revision 31a447d1 (git): Update credentials for Travis/Slack integration.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59750 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:15 AM Revision 8c592366 (git): Hide NotImplementedError for windows
- https://github.com/ruby/ruby/commit/440dc6b7e0b3b74db221eed81871516e301d4b3e#commitcomment-24074203
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59749 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:52 AM Revision 813ffb8b (git): st.c: fix num_entries
- * st.c (st_insert2): should manage num_entries when the key is
undefined, as well as st_insert().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59748 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:50 AM Revision 4a09333b (git): st.c: fix false assertions
- * st.c: split assertion conditions.
* st.c (rb_hash_bulk_insert): the number of arguments should be
even.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59747 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:28 AM Bug #11844: Please update unicode-licensed files (license issue)
- zeha (Christian Hofstaedtler) wrote:
> The non-free problem is with this line: "supplied in this file in the creation of products supporting the Unicode Standard" - which implies that you can't use this file to produce stuff not support... -
04:49 AM Revision ce7f3e13 (git): optimize rb_hash_bulk_insert to generally outperform 2.4.
- Specialized routine for small linear-probling hash instances to
boost creation of such things [Bug #13861]
Signed-off-by: Urabe, Shyouhei <shyouhei@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59746 b2dd03c8-39d4-4... - 04:48 AM Revision e06a6630 (git): * 2017-09-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59745 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:48 AM Revision 0eb7359c (git): add rb_hash_new_with_size()
- Sometimes, size of a hash can be calcluated a priori. By providing
such info to the constructor we can avoid unnecessary internal re-
allocations. This can boost for instance creation of hash literals.
[Bug #13861]
Signed-off-by: Urab... -
12:21 AM Bug #13864 (Assigned): Rinda multicast test failures due to missing default route