Activity
From 08/25/2017 to 08/31/2017
08/31/2017
-
10:21 PM Bug #13855: Hash#compact! returns nil if the hash is empty
- lucasbuchala (Lucas Buchala) wrote:
> Rather than a bug, I wonder if this is just a documentation omission.
> ...
Oh that's interesting - I hadn't noticed that returning nil if the object was unchanged was the actual behaviour there. I... -
06:44 PM Bug #13855: Hash#compact! returns nil if the hash is empty
- Hmm.
I had a look at class String and class Array what they do.
First Array:
array = [1,2,3] # => [1, 2, 3]
array.compact! # => nil
Next class String - it has no .compact but perhaps we can use
.delete! which may b... -
04:45 PM Bug #13855: Hash#compact! returns nil if the hash is empty
- Rather than a bug, I wonder if this is just a documentation omission.
In case of a documentation omission, I created a PR:
https://github.com/ruby/ruby/pull/1692 -
- This behaviour feels like a bug to me.
From the documentation (with my emphasis):
> compact! → hsh
> ...
However if the hash contains no keys, the method returns nil.
~~~
irb(main):001:0> {}.compact!
=> nil
# For Compariso... - 03:41 PM Revision 3541e365 (git): * 2017-09-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59707 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:41 PM Revision e896e9b9 (git): Skip test_open_tempfile_path on EINVAL
- Looks like File::Constants::TMPFILE could be defined even when not
supported on system. Just skip the test when we get EINVAL on open(2).
* test/ruby/test_file.rb(test_open_tempfile_path):
Skip when EINVAL occured on File.open.
git-... -
02:51 PM Feature #13581: Syntax sugar for method reference
- my idea for optimising `&obj.method(:symbol)`
is that it already creates a proc (object) without going over a `Method` object,
i don't know if that would be an good idea for that. -
02:31 PM Feature #13581: Syntax sugar for method reference
- k0kubun (Takashi Kokubun) wrote:
> Another idea: `&obj:method`
Consider more complex example, `&(obj.some.method(args)):method`, not only a simple reciever.
`&` and `:` are separated too far. -
- Hanmac (Hans Mackowiak) wrote:
> i am not sure about that:
> ...
It's different at all.
My example is a token `\.`, do not split.
> PS: when using "&obj.method(:symbol)" should that be optimized if able?
Probably, but it's not p... -
01:12 PM Feature #13581: Syntax sugar for method reference
- Oh, I'm so sad to hear `obj:method` (without `&`) is already valid. I still have hope to have it only when it's put with `&` in the last of arguments because that case is not valid for now.
```
irb(main):001:0> def obj(method); meth... -
- k0kubun (Takashi Kokubun) wrote:
> Another idea: `&obj:method`
> ...
hm i like that idea, but think that might be a bit conflicting, that depends on if obj is an object or not?
~~~ ruby
obj = Object.new
obj:method #=> syntax error... -
- Another idea: `&obj:method`
It just puts receiver between `&` and `:` from existing one. I'm not sure it conflicts with existing syntax or not but I feel it's consistent with `&:foo` syntax.
```ruby
roots = [1, 4, 9].map(&Math:sqr... -
12:10 PM Feature #13581: Syntax sugar for method reference
- > I am for adding syntax sugar for method reference. But I don't like proposed syntax (e.g. ->).
> ...
In my pet projects, I often alias `method` as `m`. It is readable enough, short enough and easy to remember, once you've seen it:
... -
- nobu (Nobuyoshi Nakada) wrote:
> `obj\.method`
i am not sure about that:
~~~ ruby
obj\
.method
~~~
is already valid ruby code, so i am not sure
PS: when using "`&obj.method(:symbol)`" should that be optimized if able? -
- `obj\.method`
-
06:31 AM Feature #13581: Syntax sugar for method reference
- I am for adding syntax sugar for method reference. But I don't like proposed syntax (e.g. `->`).
Any other idea?
Matz.
-
01:02 PM Feature #13784: Add Enumerable#filter as an alias of Enumerable#select
- matz (Yukihiro Matsumoto) wrote:
> Sounds OK. One concern left is `Hash#filter`.
> ...
I have added a bug to discuss the discrepancy in Hash's behavior: https://bugs.ruby-lang.org/issues/13795 -
- Sounds OK. One concern left is `Hash#filter`.
Matz.
-
06:37 AM Feature #13784: Add Enumerable#filter as an alias of Enumerable#select
- +1 because I like the name filter_map for #5663.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59705 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:16 AM Bug #13854 (Closed): `make golf` broken
- make golf が失敗します。
```
% make golf
...
compiling .../ruby/goruby.c golf_prelude.c
gcc: fatal error: cannot specify -o with -c, -S or -E with multiple files
compilation terminated.
uncommon.mk:951: ターゲット 'goruby.o' のレシピで失敗しました
``... -
- Applied in changeset trunk|r59704.
----------
File#path: Raise IOError when a file is O_TMPFILE
File#path for a file opened with O_TMPFILE has no meaning.
A filepath returned by this method isn't guarranteed about its accuracy,
but fi... -
- Nobu's patch at [ruby-core:81329] fails when fd is closed... Updated the patch.
* Raise IOError when fptr->pathv is Qnil on File#path
* Set Qnil to fptr->pathv when opening file with O_TMPFILE
* File#to_path and FIle#path behave sam... -
- I vote for raising exceptions (ENOENT?).
Matz.
-
- File#path for a file opened with O_TMPFILE has no meaning.
A filepath returned by this method isn't guarranteed about its accuracy,
but files opened with O_TMPFILE are known its recorded path has no
meaning. So let them not to return an... -
- I propose
* Signal::RTMIN
* Signal::RTMAX
instead.
Matz.
-
09:06 AM Feature #13770: Can't create valid Cyrillic-named class/module
- In the patch, I suggest adding something like
```c
if (rb_enc_islower(c, enc)) return FALSE;
```
immediately before or after
```c
if (rb_enc_isupper(c, enc)) return TRUE;
```
-
08:58 AM Bug #13769: IPAddr#ipv4_compat incorrect behavior
- Agreed with deprecating it. Other libraries like the ipaddress gem do not seem to have this, so I'll remove it by 2.5.
-
- Rejected. You can simply filter Dir entries. If you have concrete use-case of the method, reopen the issue, please.
Matz.
-
- I think it should be done in the gem. Templating need not to be a part of the core.
Matz.
-
08:42 AM Misc #13747: MinGW trunk build available on Appveyor
- Thank you for providing CI for mingw.
I and branch maintainers monitors CI results by http://rubyci.org/
If you output certain index and LTSV files,
The crawler of results is implemented at https://github.com/ruby/rubyci/blob/mas... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59703 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r59702.
----------
Add Socket::Ifaddr.vhid on supported platforms [Feature #13803]
patched by Alan Somers -
08:18 AM Feature #13803 (Assigned): Add Socket::Ifaddr.vhid on supported platforms
-
07:19 AM Feature #13803: Add Socket::Ifaddr.vhid on supported platforms
- Although I don't tested, it seems fine except the document should use Integer instead of Fixnum.
-
- patched by Alan Somers
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59702 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59701.
----------
io.c: shrink read buffer
* io.c (io_setstrbuf): return true if the buffer is newly created.
* io.c (io_set_read_length): shrink the read buffer if it is a new
object and is too large. [... -
- We discussed this in a developer meeting,
it is better to call realloc when outbuf is not given and
maxlen - len is bigger than 4K where len is the length actually read.
(if maxlen - len is too short, freeing memory is not worth than
... -
- I think that it's possible to call remalloc when
"outbuf" argument is not supplied to read_nonblock.
It makes possible to
automatically reduce memory with remalloc (without supplying "outbuf") and
reuse buffer without remalloc (wit... -
- * io.c (io_setstrbuf): return true if the buffer is newly created.
* io.c (io_set_read_length): shrink the read buffer if it is a new
object and is too large. [ruby-core:81370] [Bug #13597]
git-svn-id: svn+ssh://ci.ruby-lang.org/rub... -
- * string.c (rb_str_enumerate_grapheme_clusters): adjust indent.
[Feature #13780]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59700 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_syntax.rb (TestSyntax#test_return_toplevel):
suppress unreachable statement warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59699 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:44 AM Feature #13849: Show --dump options in help
- Changed as:
```
$ ./ruby --help
Usage: ./ruby [switches] [--] [programfile] [arguments]
-0[octal] specify record separator (\0, if no argument)
-a autosplit mode with -n or -p (splits $_ into $F)
-c ... -
- What about `--help=dump` (`--help=feature` and so on)?
-
- I removed old --dump=help, and --dump=usage, and changed --dump=help to show help messages of --dump.
https://github.com/ruby/ruby/pull/1688
```
$ ./ruby --help
Usage: ./ruby [switches] [--] [programfile] [arguments]
...
-... -
- Without any actual use case, there would be no effective definition of equality for enumerators.
FWIW, the initial design policy is, Enumerator is an abstract entity that only guarantees it responds to `each` for enumeration, and it's... -
07:34 AM Bug #13833: String#scanf("%a") incorrectly requires a sign on the (binary) exponent
- Hi, cabo.
I implemented to fix this bug and created PR:
https://github.com/ruby/ruby/pull/1689
Could you please check this? -
- It's OK as long as bundling bundler makes users happy (and I believe it would).
Matz.
-
- Though GB2312 seems still needed, but we may be able to remove GB12345.
-
-
-
- >junaruga
Thanks. We reopen issue about UCD license issue: https://bugs.ruby-lang.org/issues/12598
Without UCD license, This issue is resolved.
-
- Function composition should **not** be implemented by `yield_self`.
Matz.
-
- Applied in changeset trunk|r59698.
----------
String#each_grapheme_cluster and String#grapheme_clusters
added to enumerate grapheme clusters [Feature #13780] -
- `grapheme` sounds like an element in the grapheme cluster. How about `each_grapheme_cluster`?
If everyone gets used to the `grapheme` as an alias of `grapheme cluster`, we'd love to add an alias `each_grapheme`.
Matz.
-
- added to enumerate grapheme clusters [Feature #13780]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59698 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:26 AM Feature #6284: Add composition for procs
- Most languages do not define function composition in built-in operators, but provide them as function or method such as `compose`.
F.Y.I) https://rosettacode.org/wiki/Function_composition
In some few languages defined function comp... -
06:04 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- mame@ruby-lang.org wrote:
> I believe that this feature should be introduced with another
> name. I have no counterproposal, though. Sorry.
What about Thriber? Or Fred?
"Fread" might be confused with fread(3) function, and I ... -
-
- The update of the message is OK.
Matz.
-
05:47 AM Feature #13516 (Assigned): Improve the text of the circular require warning
-
- Your example is bit weak. Is there any **realistic** use-case for the method?
Matz.
-
-
- The trunk accepts a block after `[]` now.
-
-
- * test/ruby/test_syntax.rb (TestSyntax#test_return_toplevel):
assert expected output if given.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59697 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I picked commit from json-2.0.4 fixes.
Please backport attachment patch to ruby 2.2 and 2.3. -
- The behavior was intentional.
-
01:25 AM Bug #13412: Infinite recursion with define_method may cause silent SEGV or cfp consistency error
- It seems to be fixed at trunk. Thank you.
But I guess that it is not due to r59606, but rather to r59630 and r59676.
```
$ git checkout $(git log --grep "trunk@59606" origin/trunk --format="%h") && git checkout -B work &&
make m... -
- * doc/globals.rdoc: [DOC] `$=` is no longer effective.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59696 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/30/2017
-
10:23 PM Revision 7e8cdaa6 (git): to_str -> to_s
- * lib/net/http/header.rb (set_field): `val` can not have `to_str`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59695 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- cardoso_tiago@hotmail.com wrote:
> I can't unfortunately reproduce this in a deterministic way. I
> can only say that the `read` routine is called in multiple
> threads (different io's instances of that class). The errors
> come sel... -
10:37 AM Bug #13851 (Closed): getting "can't modify string; temporarily locked" on non-frozen instances
- I'm doing some nonblocking IO, and using a local string for buffering to avoid allocations. Roughly the following
```ruby
class A
def initialize
@buffer = String.new("", encoding: Encoding::BINARY)
end
def read(io)
... -
- This is a ticket for backport management. The issue was already fixed on trunk.
Let's treat r59693 as a bugfix and backport into stable branches. - 05:24 PM Revision 46180152 (git): * 2017-08-31
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59694 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59693 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It sounds `--dump=?` is troublesome, and also it is not easy to implement.
It looks `--dump=help` and `--help` is same. Can I drop the current `--dump=help`, and use `--dump=help` instead of `--dump=?` ? -
- bash also expand glob if files exist.
And bash with `shopt -s failglob` can raise error like zsh.
So I think users should not depend such behavior.
```
$ touch ./--dump=a
$ ruby --dump=?
ruby: warning: don't know how to dump `a',... -
- I feel splitting help to --dump=? is nice idea.
By the way, the current behavior is as:
bash
```
$ ./ruby --dump=?
./ruby: warning: don't know how to dump `?',
./ruby: warning: but only [version, copyright, usage, help, yydeb... -
- +1
The "--dump=?" may also work. I do however think that Naotoshi Sao's suggestion,
although more verbose, may be best, since people can simply read what these
options do in the short description, such as "dump YARV instructions". (... -
- Or add the message "try --dump=? to show valid arguments".
-
- elsewhere ... where are you supposed?
-
- sonots (Naotoshi Seo) wrote:
> version, copyright, usage, help, yydebug, syntax, parsetree, parsetree_with_comment, insns are available as an argument of --dump option.
> ...
Write detailed description elsewhere, and then just show the... -
version, copyright, usage, help, yydebug, syntax, parsetree, parsetree_with_comment, insns are available as an argument of --dump option.
I now wonder which I should support. I want yydebug, parsetree, and insns (parsetree_with_commen...-
- ruby 2.4.1 (actually, trunk)
-
- Current help does not show any helps for --dump options such as --dump=insns.
I want to get them.
```
$ ./ruby --help
Usage: ./ruby [switches] [--] [programfile] [arguments]
-0[octal] specify record separator (\0, if no ar... -
11:21 AM Bug #13848: BigDecimal.new('200.') raises an exception
- Robert, yes, I think it should be the same as BigDecimal.new('200.0'). The problem arises, not when a programmer is typing the number---requiring a programmer to be explicit is OK by me---but when strings are processed that come from a ...
-
- I propose following specification: `require 'foobar'`
If ENOENT occurs for all paths searched, raise LoadError with messages like below:
```
in `require': cannot load such file -- No such file or directory -- foobar (LoadError)
... -
-
- Note that BigDecimal class is defined in a standard library, but it is not built-in.
-
-
- * array.c (binomial_coefficient): get rid of bignums by division
after each multiplications.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59692 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * array.c (descending_factorial): reduce factorial multipication.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59691 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:44 AM Bug #13850 (Closed): backport r59584
- バックポート管理用のチケットです。
-
- Hi, we need a reproducible codes.
-
- MSP-Greg (Greg L) wrote:
> Regardless, in simplifying the code, I was left with one question regarding all of the sort/filter group methods in ruby.
> ...
As described below, this seems to lump together two different families of meth... - 05:37 AM Revision 6d5a4fef (git): * 2017-08-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59690 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * array.c (rb_ary_cycle_size, descending_factorial): use
rb_int_mul instead of rb_funcallv.
* array.c (binomial_coefficient): use rb_int_idiv instead of
rb_funcallv.
* array.c (rb_ary_repeated_permutation_size): use
rb_int_positi... -
03:16 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- I comment in compliance with hsbt's request.
Basically I agree with ko1; Thread is considered harmful. Casual Rubyists (including I) had better not use it.
However, I'm not against introducing the feature in question as a professi...
08/29/2017
-
06:40 PM Bug #13846: Openbsd possible memory leak when using Thread
- I installed 2.5.0-dev (from github) and seems that this bug does not occur or at least it is fixed. I believe that it might be related to #13772. My daemons started with low memory around 30mb and ended up after a week to 300mb with high...
-
02:14 PM Bug #13846: Openbsd possible memory leak when using Thread
- I've confirmed this also happens with the current version of OpenBSD and ruby 2.4.1. I'll have to write a C version to see if this is a problem with OpenBSD's thread library. If not, it's probably an issue with ruby. Hopefully I'll ha...
-
- On openBSD 5.9/6.1 running this code causes RSS memory to increase without limit. This does not happen in ubuntu or other linux.
~~~ ruby
loop do
thr = Thread.new { puts "thread test" }
thr.join
GC.start
end
~~~
This is... -
06:26 PM Bug #13844: Toplevel returns should fire ensures
- Oh also...IRB is a very weird beast. The code you enter isn't really running at toplevel; it's running in an eval that's likely within a block or method scope (I haven't looked recently). As a result, things you'd expect to work at tople...
-
- I do not assume it was intentional, but it was codified by tests added along with the toplevel return change. See test_syntax.rb in test_return_toplevel, where it tests that each of the following lines should exit silently:
```ruby
r... -
- This is indeed weird that the blocks are treated differently depending on whether they
are defined in a method or outside of it. I do not assume that this was intentional.
On a side note, interestingly, the last variant aka:
```ru... -
- I believe you mean for BigDecimal.new('200.') to be equivalent to BigDecimal.new('200.0')?
I could see both ways be ok; there may be use cases where the error is better because of
the user not being explicit enough; or the user does ... -
- BigDecimal.new('200.') raises an exception:
ArgumentError: invalid value for BigDecimal(): "200."
It should accept this as a valid decimal number.
This requires fixing numbers read in from the wild. -
- * array.c (ary_join_1): simplified by rb_check_array_type.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59688 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:52 AM Revision f32e46b7 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59687 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This version fixed strange behavior of ruby code parser.
We will list all of impromovement to Changelog when 6.0.0 releasing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59686 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * array.c (ary_join_1): ignore encodings in nested arrays as an
initial encoding.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59685 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > Also, in this use case, it seems to be enough to use [..]
> ...
Matz will decide but I wanted to comment on what Hiroshi Shibata wrote.
Kernel require presently accepts no additional arguments:
https://ruby-doc.org/core-2.4.... -
09:27 AM Feature #13847: Gem activated problem for default gems
- hsbt (Hiroshi SHIBATA) wrote:
> Unfortunately, since rubygems has required openssl before the bundler runs it will result in an activated error like this:
> ...
Off-topic, but in this specific case, the root of the problem is that bund... -
- If you try to use some default gems with a fixed version using Bundler, there are cases where the current RubyGems/Bundler/Ruby specification can not be used with the version specified by the user.
For example
```
$ ruby -v
ruby ... -
- * array.c (ary_join_1): copy the encoding of the converted string
of the first element by to_str too, as an initial encoding.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59684 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Reported by Eric Wong. Thank you.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59683 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:17 AM Bug #13794: Infinite loop of sched_yield
- Apologies for my delay in replying. I have not yet had an opportunity to fully test any of these patches (apart from my initial hack which did not work). I will aim to test your patch as soon as possible. Thank you for your assistance!
-
09:06 AM Bug #13769 (Assigned): IPAddr#ipv4_compat incorrect behavior
-
08:25 AM Bug #13769: IPAddr#ipv4_compat incorrect behavior
- I'd vote for marking it deprecated & fixing the bug in the original ticket. Despite the fact that the addresses are now deprecated, it may be useful for ruby code to interact with or check for legacy situations - that's how I found the bug
-
- RFC4291 says: '"IPv4-Compatible IPv6 address" is now deprecated.'
We can remove #ipv4_compat? or mark it as deprecated.
Section 2.5.5.1.
The "IPv4-Compatible IPv6 address" is now deprecated because the
current IPv6 transition ... -
- I couldn't reproduce this with RubyInstaller 2.4.1-2.
-
- I couldn't reproduce this.
```
C:\Users\hsbt>gem i sass
Fetching: sass-listen-4.0.0.gem (100%)
Successfully installed sass-listen-4.0.0
Fetching: sass-3.5.1.gem (100%)
Successfully installed sass-3.5.1
Parsing documentation for ... -
-
- It can't be reproduced.
```
% ruby -v -r "date" -e "p DateTime.parse == 'No End Date'"
ruby 2.5.0dev (2017-08-29 trunk 59656) [x86_64-darwin15]
false
``` -
- I am having similar issue. Even calling open3.capture2 which uses threads results into 250mb of rss memory after a day. 2.3.4 and all 2.3.x.. ,2.4.x
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59682 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59681 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * .gitignore: ignore run.gdb which is assumed to be generated
by make gdb and customized manually during development
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59680 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59679 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I couldn't reproduce FreeBSD 11.0 and Ruby 2.1.10.
08/28/2017
-
- charlie@atech.media wrote:
> Eric Wong <normalperson@yhbt.net> wrote:
> > How about checking owner_process before incrementing?
>
> I'm afraid this fix doesn't quite match up in my mind. To
> clarify, I am suggesting that timer_th... -
- Applied in changeset trunk|r59678.
----------
win32.c: fix function pointer
* win32/win32.c (rb_w32_set_thread_description): fix the condition
if the API function pointer is found.
[ruby-core:82494] [Bug #13845] -
08:26 PM Bug #13845 (Closed): thread_win32.c: set thread name breaking mswin builds on appveyor and at rubyci
- The commit [svn 59660 thread_win32.c: set thread name](https://github.com/ruby/ruby/commit/19d692920d2d207c3aa891fc79aa5a93c17f84c6) is breaking builds on both appveyor and at rubyci.
It appears to be using a function that is only sup... -
- * win32/win32.c (rb_w32_set_thread_description): fix the condition
if the API function pointer is found.
[ruby-core:82494] [Bug #13845]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59678 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- See https://github.com/jruby/jruby/issues/4761 for our placeholder bug for this missing feature.
-
- In the following contexts, a return always fires the ensure that wraps it:
```
[] ~/projects/ruby $ ruby -e 'def foo; return; ensure; p :x; end; foo'
:x
[] ~/projects/ruby $ ruby -e 'def foo; 1.times { begin; return; ensure; p :x... -
- Ahh great, thank you for the pointer, nobu!
-
- test/ruby/test_syntax.rb:test_return_toplevel
-
- Were any tests or specs added for this feature? I don't see anything recent added to language/return_spec.rb and the related commits don't show any additions to MRI's tests.
I believe we need at least one of these to be filled out. I'... - 04:05 PM Revision 9f675c5b (git): * 2017-08-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59677 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- On below env, miniruby requires 568 and ruby requires 838 to pass.
* ruby -v: ruby 2.5.0dev (2017-08-28 trunk 59670) [x86_64-freebsd10.3]
* gcc8 (FreeBSD Ports Collection) 8.0.0 20170828 (experimental)
git-svn-id: svn+ssh://ci.ruby-lang... -
- At rubygems/rubygems, the patch for resolver.rb was accepted first, then the patch to extend appveyor testing to include trunk was accepted.
[Appveyor results](https://ci.appveyor.com/project/segiddins/rubygems/build/634) and [Travis ... -
- Currently, the file `lib/rubygems/resolver.rb` differs between ruby/ruby and rubygems/rubygems in the `search_for` method.
Attached patch aligns them and adds the test for it, which is also missing from ruby/ruby. Tested against MinG... -
- * compile.c (compile_if): extract from iseq_compile_each.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59675 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59674 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * string.c (rb_str_split_m): fix potential bug when rb_memsearch()
matches a octet in the middle of a multi-byte character sequence.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59673 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- see details for this update:
http://blog.rubygems.org/2017/08/27/2.6.13-released.html
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59672 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Rubygems-2.6.13 has been released now.
Its version was required to backport all stable versions of Ruby.
I created patches about rubygems 2.6.13.
For Ruby 2.2 and 2.3: These patches contain only security fixes of rubygems-2.6.13
... -
- includes the patch from marshall-lee.
close #1168
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59671 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:48 AM Bug #13841 (Closed): Segmentation fault in Ruby CFUNC :to_s
- Hi, a segmentation fault was found in my environment.
~~~ text
E, [2017-08-25T16:21:37.798828 #632] ERROR -- : reaped #<Process::Status: pid 30125 SIGABRT (signal 6) (core dumped)> worker=2
I, [2017-08-25T16:21:37.826008 #30226] I... -
- ahorek (Pavel Rosický) wrote:
> There's no need to call it for each directory because the result will always be same.
It is not same.
Path components in middle also should be replaced.
08/27/2017
-
04:22 PM Bug #13167: Dir.glob is 25x slower since Ruby 2.2
- https://github.com/ruby/ruby/pull/1685
I reverted nobu's change and instead of recursion for simple patterns I want to call "replace_real_basename" only for results. There's no need to call it for each directory because the result wil... -
- * compile.c (compile_ensure): extract from iseq_compile_each.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59670 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (compile_resbody): extract from iseq_compile_each.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59669 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:04 PM Revision fc1714be (git): * 2017-08-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59668 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (compile_rescue): extract from iseq_compile_each.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59667 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I'm trying to fix some method code (`Gem::Resolver#search_for`) in rubygems.
Regardless, in simplifying the code, I was left with one question regarding all of the sort/filter group methods in ruby.
Which ones are considered stable... -
- The IMAP server of DOCOMO returns such continuation requests.
[ruby-list:50558]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59666 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/26/2017
-
11:39 PM Feature #13828 (Closed): Win32ole extension should support licensed COM servers
- Applied in changeset trunk|r59665.
----------
* ext/win32ole/win32ole.c (fole_initialize): support licensed COM server. Thanks to Gray Wolf. [Feature :#13828] -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59665 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/vcs.rb (VCS::GIT#commit): refresh until sync after dcommit.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59664 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:55 PM Revision 6de143f6 (git): * 2017-08-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59663 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59662 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:13 PM Feature #13839: String Interpolation Statements - Yes templating is not a key factor for large modern PHP projects, but you need to go back in late 90s. That was the start of the web. A lot of people wanted to publish their things, so they wrote HTML pages. Often they knew nothing about...
-
- > I was listening a talk by Rasmus Lerdorf, the creator of PHP.
> ...
I do not think that templating was the killer feature of PHP.
I have not systematically analyzed the codebase of phpBB, mediawiki,
drupal or wordpress but I doubt... - 02:14 AM Feature #13839: String Interpolation Statements
- k0kubun (Takashi Kokubun) wrote:
> Ah okay, so expected feature is only "%{3.times do}Hello #{'World'}%{end}" and a multi-line complex usage would be:
> ...
Yes, that's it! :) I just wanted to improve string interpolation with %{statem... -
- Ah okay, so expected feature is only "%{3.times do}Hello #{'World'}%{end}" and a multi-line complex usage would be:
~~~
<<EOS
%{if true}
Hello #{'world'}
%{end}
EOS
~~~ - 01:53 AM Feature #13839: String Interpolation Statements
- > You should write expected code in valid Ruby syntax. Guessing from "%{3.times do}Hello #{'World'}%{end}", probably you intended:
> ...
It was an idea that we could use a different notation: %{statement} instead of {% statement %} to b... -
- You wrote:
~~~
{% if true %}
Hello #{'World'}
{% end %}
Template.new('...').render(binding)
~~~
You should write expected code in valid Ruby syntax. Guessing from "%{3.times do}Hello #{'World'}%{end}", probably you intende... - 01:34 AM Feature #13839: String Interpolation Statements
- Thanks for your feedback Jeremy. :) (I have much gratitude for all your work in Ruby!)
Yes, I didn't think of this as a replacement for a full featured template engine (with cache, helpers and so), but more as a quick and powerful way... -
- * win32/win32.c (rb_w32_set_thread_description_str): return the
result when name is nil.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59661 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > I expect Set to act almost like Array [...]
But why? Aside from both being collections, there is no connection. Ruby's Set isn't even implemented with an Array.
The core mathematical definition of Set is based on element member... -
- * thread_win32.c (native_set_another_thread_name): set thread name
by SetThreadDescription.
* win32/win32.c (rb_w32_set_thread_description): dynamically try
SetThreadDescription.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59...
08/25/2017
-
- It might be better to compare this to Erubi, the current default ERB template processor in Rails and Tilt. While this approach is fast for small strings, it's actually slower for large strings (probably due to the use of `+=` instead of...
- 10:34 PM Feature #13839 (Rejected): String Interpolation Statements
- Hello!
Here is a KISS implementation of a template engine in Ruby:
~~~ ruby
class Template
attr_reader :input
def initialize(input)
@input = input
end
def output
"output = %\0" + @input.gsub("{%", "\0... - 03:47 PM Revision c150c787 (git): * 2017-08-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59659 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/English.rb: [DOC] `$IGNORECASE` is no longer effective.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59658 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:01 PM Bug #13757: TestBacktrace#test_caller_lev segaults on PPC
- BTW, very likely unrelated, but I noticed, that on PCC64 (BE), the C level backtrace is not correctly collected. It looks like:
~~~
-- C level backtrace information -------------------------------------------
[0x4ef7a734]
[0x4ef7a8... -
- Ok, so I did my homework :) It started with r59047 and it is issue for ppc64/ppc64le. No other Fedora architectures are affected. Since this release, the test suite always get stuck at TestBacktrace#test_caller_lev. Later, since r59159, ...
-
- * lib/csv.rb (CSV::Table#to_a, #to_csv): use Array#push instead of
Array#concat for performance improvement. This performance improvement is
proposed by zdennis <zach.dennis@gmail.com>. The patch is from
Mau Magnaguagno <maumagnagu... -
- * compile.c (iseq_peephole_optimize): remove unreachable chunk
which appeared by useless jump elimination.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59656 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (iseq_peephole_optimize): eliminate useless if/unless
just before jump.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59655 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:37 AM Revision 5ccf7b06 (git): * 2017-08-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59654 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (iseq_peephole_optimize): moved comments inside proper
blocks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59653 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:16 AM Feature #13801: Implement case equality test for Set#===
- Here's a counterexample with Array:
~~~ ruby
[1, 2, 3] === 2 #=> false
~~~
Array#=== doesn't look inside the array. I expect Set to act almost like Array, so it would be weird if Set#=== looked inside the container but Array#=== ... -
- Turns out that `open(temp_file, 'a')` works with the original open, but fails after loading open-uri.
This is because the instances of Tempfile respond to `to_path`, just like instances of File or Pathname. So `open(temp_file, 'a')` a... -
- It makes many conflicts with the current syntax.
I don't think it is easy to resolve. -
01:04 AM Feature #13667: Add Coverage.running? to quickly check if Coverage is enabled.
- I also think `running?` is better. And I feel `#test_coverage_running?` is good enough :)
-
- Sorry for the late reply. I'm positive for this proposal.
There is the same request #13838, which reminds me of this ticket. That issue proposes `Coverage.enabled?`. I'm unsure, but `running?` seems a bit better to me because the s... -
- Sorry I overlooked the issue :)
-
- I think this is a duplicate of #13667. Let us discuss this issue in that ticket. Thank you!
-
- ## Description
I want to detect current status of Coverage, which is enabled or not.
Now we can detect status only trying `Coverage.peek_result` or `Coverage.result` and catch RuntimeError.
Attached patch enable us to detect status ...