Activity
From 08/17/2017 to 08/23/2017
08/23/2017
-
04:47 PM Bug #13837: Class attributes get overshadowed by local variables
- shevegen (Robert A. Heiler) wrote:
> Even the old pickaxe mentions that ruby may behave slightly unexpected
> ...
I still can't consider this correct behavior. Aren't the multi-line and the single-line ways of writing `if` supposed to ... -
04:29 PM Bug #13837: Class attributes get overshadowed by local variables
- I think hanmac already gave the correct answer so there is no point in me adding
much to it. :)
Note that you could specifically point ruby to call the getter method in the
line hanmac pointed out, rather than using:
bar = 0... -
12:27 PM Bug #13837: Class attributes get overshadowed by local variables
- ruby does parse the lines before exceute them.
so when ruby does read this:
~~~ ruby
bar = 0 if bar.nil?
~~~
it finds that you assign a local variable bar in this contect.
now it does always use the local variable instead of me... -
- ~~~ ruby
irb(main):001:0> RUBY_VERSION
=> "2.4.1"
irb(main):002:0> class Foo
irb(main):003:1> attr_accessor :bar
irb(main):004:1> def initialize
irb(main):005:2> self.bar = 1
irb(main):006:2> end
irb(main):007:1> def ... -
04:01 AM Bug #13832 (Closed): cfp consistency error occurred in vm_call_cfunc on non-optimized ruby
- Applied in changeset trunk|r59649.
----------
gc.c: restore cfp at finalizer
* gc.c (run_finalizer): restore cfp for the case an exception
raised in a finalizer. [ruby-core:82432] [Bug #13832] -
- * gc.c (run_finalizer): restore cfp for the case an exception
raised in a finalizer. [ruby-core:82432] [Bug #13832]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59649 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59648 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * gc.c (run_finalizer): revert r59155 partially. finalizing loop
should continue even after an exception is rescued.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59647 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59644.
----------
parse.y: primary should not be 0
* parse.y (primary): should not be 0, since it can be a receiver.
[ruby-core:82447] [Bug #13836] - 02:23 AM Revision e96ba1d6 (git): * 2017-08-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59646 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:23 AM Revision e553df86 (git): remove debug code.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59645 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:09 AM Bug #13794: Infinite loop of sched_yield
- charlie@atech.media wrote:
> File sched_yield_1.patch added
> The patch above does not work because
> native_reset_timer_thread runs after fork in the parent.
> Attached an alternative patch that runs in gvl_atfork and
> appears ...
08/22/2017
-
09:35 PM Bug #13835: Using 'open-uri' with 'tempfile' causes an exception
- shevegen (Robert A. Heiler) wrote:
> Indeed, sounds like a bug; at the least it is somewhat surprising behaviour to me. Not
> ...
Hm, as I remember, the first argument to `open` should be a URl or a path, not a `Tempfile` instance, rig... -
- Indeed, sounds like a bug; at the least it is somewhat surprising behaviour to me. Not
that I think I would have ever found the above behaviour, I always used open-uri with
a remote URL so far. :) -
08:18 AM Bug #13835 (Closed): Using 'open-uri' with 'tempfile' causes an exception
- Hi there,
try this in your current ruby env:
~~~ ruby
require 'tempfile'
require 'open-uri'
temp_file = Tempfile.new
open(temp_file, 'a')
~~~
Get this:
~~~
/Users/~/.rvm/rubies/ruby-2.4.1/lib/ruby/2.4.0/tempfile.rb:14... -
- * parse.y (primary): should not be 0, since it can be a receiver.
[ruby-core:82447] [Bug #13836]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59644 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:36 PM Bug #13836 (Closed): Null pointer dereference in defined_expr0()
- After some fuzz testing I found a crashing test case.
To reproduce: miniruby ruby_null_ptr_defined_expr0
Context:
~~~
ruby_null_ptr_defined_expr0: [BUG] Segmentation fault at 0x0000000000000000
ruby 2.5.0dev (2017-08-03) [x86_... -
10:40 AM Bug #13834: RubyGems test suite occasionally changes working directory and breaks the rest of test suite
- So far, I think the test never reaches this [1] line for some reason. Or if it reaches it, it is not executed properly. Then the temporary directory is cleaned up and the test suite starts to fail.
[1]: https://github.com/rubygems/rub... -
- I think the github "ticket" is not as useful as the issue track here; I may mistakingly remember
but I think that some of the ruby core team said so. Where github may help of course are
patches and pull requests attached to.
The er... -
- I also opened RubyGems ticket:
https://github.com/rubygems/rubygems/issues/1991 -
- From time to time, RubyGems test suite changes working directory, which breaks rest of Ruby tests suite. It all starts like this:
~~~
[ 7096/17125] TestGemRemoteFetcher#test_do_not_allow_invalid_client_cert_auth_connection = 0.01 sLe... -
08:47 AM Bug #13832: cfp consistency error occurred in vm_call_cfunc on non-optimized ruby
- This is my configure options:
```
~/src/github.com/ruby/ruby/configure \
--prefix=$(echo ~/.rbenv/versions/trunk-o0) \
--with-opt-dir=$(brew --prefix) \
--with-dbm-dir=$(brew --prefix qdbm) \
--with-dbm-type=qdbm \
--w... -
- I can reproduce this bug with r59639.
-
- Seems something weird, r58053 is for 2.4.1 at 2017-03-22.
And I can't reproduce it with r59639.
Try checkout and `make up` again. -
06:57 AM Bug #11126 (Closed): CSV field converters doesn't attempt to convert nil value.
- Applied in changeset trunk|r59643.
----------
Fixed regression to convert blank value at r45497.
[Bug #11126][ruby-core:69088] -
- [Bug #11126][ruby-core:69088]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59643 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59642.
----------
Gracefully handle CSV IO when file descriptor closed.
[Bug #10504][ruby-core:66240] -
- [Bug #10504][ruby-core:66240]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59642 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59641.
----------
Fixed equality method fails when given the object that doesn't support table method.
[Bug #12422][ruby-core:75707] -
- [Bug #12422][ruby-core:75707]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59641 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59640.
----------
Fixed to write_headers option behavior when given no rows.
[Bug #9988][ruby-core:63375] -
- [Bug #9988][ruby-core:63375]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59640 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59639.
----------
Escape skip_lines string before convert to Regexp.
It ignored all of lines when given Regexp special characters.
[Feature #9147][ruby-core:58549] -
- It ignored all of lines when given Regexp special characters.
[Feature #9147][ruby-core:58549]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59639 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59638 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59637 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59636 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * template/insns.inc.tmpl (ASSERT_VM_INSTRUCTION_SIZE): static
assertion for VM instruction info tables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59635 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * signal.c (check_stack_overflow): raise fatal when the last tag
is in danger zone.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59634 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59633 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:41 AM Revision 59d8fefa (git): * 2017-08-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59632 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * cont.c: introduce `struct cont_saved_vm_stack` which was part of
`struct rb_context_struct`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59631 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/21/2017
-
05:50 PM Bug #13833 (Closed): String#scanf("%a") incorrectly requires a sign on the (binary) exponent
- ~~~
>> Float("0x1p9")
=> 512.0
> ...
=> 512.0
>> "0x1p+9".scanf("%a")
=> [512.0]
> ...
=> [0.0] # Oops
>> RUBY_VERSION
=> "2.4.1"
~~~
In scanf.rb, there are three regexps that say the equivalent o... -
- * gc.c: enable PREVENT_STACK_OVERFLOW.
* vm.c (invoke_iseq_block_from_c): prevent stack overflow.
* vm_eval.c (stack_check): raise preallocated exception instance.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59630 b2dd03c8-39d4-... -
01:38 PM Revision 29fa7a9f (git): Remove a meaningless local variable assignment
- * iseq.c (rb_iseq_disasm_insn): Remove a meaningless
local variable assignment. `insn` is never changed
in this function, so a result of `insn_op_types(insn)`
is also never changed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... - 06:46 AM Revision aaac3f8c (git): * 2017-08-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59628 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_core.h (ruby_special_exceptions): rename sysstack_gc as
stackfatal.
* eval.c (Init_eval): modified the message for stackfatal error as
"critical region".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59627 b2dd03c8-39d4-4d... -
06:00 AM Bug #13831: error when try to install
- MSP-Greg (Greg L) wrote:
> I'm not that familiar with encoding issues, but I believe CP720 is an older code page.
Yes indeed. CP720 is the DOS encoding for Arabic.
> ...
This should be `chcp 1256`. The command is "change code page... -
01:20 AM Bug #13831: error when try to install
- I'm not that familiar with encoding issues, but I believe CP720 is an older code page. IF you enter `cp 1252` in the console, then `gem install sass`, does the gem install?
Regardless, given the nature of your question, the best plac... -
- The following script occurs `[BUG] vm_call_cfunc: cfp consistency error` on ruby that is compiled with `-O0`.
```console
$ cat test.rb
def callback
p :callback
@non_existing_ivar
end
ObjectSpace.define_finalizer(Object.new... -
01:01 AM Feature #13828: Win32ole extension should support licensed COM servers
- nobu (Nobuyoshi Nakada) wrote:
> * use `rb_scan_args` and `rb_get_kwargs`
bug reported in #13830 was resolved, so now I can use `rb_scan_args` and `rb_get_kwargs`. Updated version attached.
08/20/2017
-
05:01 PM Bug #13831 (Closed): error when try to install
- ruby 2.4.1p111 (2017-03-22 revision 58053) [x64-mingw32]
C:\Users\K>gem install sass
C:/Ruby24-x64/lib/ruby/2.4.0/win32/registry.rb:72:in `find': unknown encoding name - CP720 (ArgumentError)
from C:/Ruby24-x64/lib/ruby/2.4.... -
- * class.c (rb_scan_args), include/ruby/ruby.h (rb_scan_args_set):
return non-keywords elements only in the last hash when keyword
arguments are extracted from it, as well as methods defined in
ruby level. [ruby-core:82427] [Bug #1...
08/19/2017
-
- Applied in changeset trunk|r59624.
----------
ruby.h: fix rb_scan_args_trail_idx
* include/ruby/ruby.h (rb_scan_args_trail_idx): fix the case both
of optional and rest arguments are defined.
[ruby-core:82427] [Bug #13830]
* includ... -
- Oh and in case it's relevant, here is table of how it behaves under `-O3`.
rb_scan_args|Function call |Result |
============|=======================|==================================|
... -
- I think I've found bug in `rb_scan_args` function. This is my testing script:
require_relative 'test'
Test.test "server", "host", "a", "b", license: "lic"
And this is implementation of my module:
#include <ruby.h>... - 11:39 PM Revision 9191d9e7 (git): * 2017-08-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59625 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/ruby.h (rb_scan_args_trail_idx): fix the case both
of optional and rest arguments are defined.
[ruby-core:82427] [Bug #13830]
* include/ruby/ruby.h (rb_scan_args_n_trail): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.or... -
10:02 AM Revision 9657a6c2 (git): gems/bundled_gems: Update to power_assert 1.1.0
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59623 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- nobu (Nobuyoshi Nakada) wrote:
> * adjust indents
Fixed
> ...
Do you mean via ":" in `rb_scan_args`? I tried that at first actually, but had some troubles getting it work (here is what happened: https://gist.github.com/anonymous/7... -
- * adjust indents
* use `rb_scan_args` and `rb_get_kwargs`
* don't mix a declaration with code -
- `$0` and `Process.setproctitle` ignore `\0` and the after.
Is it intentional?
```
$ ruby -e '$0 = "foo\0bar"; system("ps", "#$$"); Process.setproctitle("bar\0foo"); system("ps", "#$$")'
PID TT STAT TIME COMMAND
34931 s00... -
- What are `time1` and `time2`?
If `time1` is the time when DST starts at and `time2` is the time when it ends at, then `time1 > `time2` in the Southern Hemisphere?
And what will return in non-DST timezones? -
- * class.c (rb_keyword_error_new): get rid of an intermediate
string and check if keys are symbols.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59622 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:45 AM Revision 4179fada (git): * 2017-08-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59621 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59620 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/18/2017
-
- Current implementation doesn't support licensed COM servers. I've added keyword argument `:license` which when used switches to using `IClassFactory2::CreateInstanceLic` instead of `CoCreateInstance`.
Default behaviour was not touched... -
- * vm_insnhelper.c (vm_cfp_consistent_p): extracted the conditions
for cfp consistency.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59619 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- * vm_insnhelper.c (rb_threadptr_stack_overflow): rb_fatal is not
available during GC. raise the preallocated fatal error.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59618 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:59 AM Feature #13827 (Closed): Improve performance of `Base64.urlsafe_encode64`
- Improve performance of `Base64.urlsafe_encode64` by avoiding unnecessary memory allocations. This may seem insignificant, but for the web service I am working on this patch makes noticeable improvement.
### Benchmark
~~~ ruby
requ... -
10:01 AM Feature #13812: Refinements で定義した to_s を String interpolation が呼んでくれない
- そうですね。
先に答えを出しておくと、この場合のto_sは(そのコンテキストでの呼び出しと解釈できるので)refinementの対象になったほうが良いように思います。
Matz.
-
09:13 AM Feature #13812: Refinements で定義した to_s を String interpolation が呼んでくれない
- shugo さん
> Refinements導入時の議論で暗黙のメソッド呼び出しには影響しないようにするという判断が
> ...
なるほど。
> 仕様変更の議論は英語でやった方がよいですかね。
英語で新規にチケットを起票した方が良いでしょうか？
それともこのチケットの Title と Description を編集して英語に書き換えた方がいいですか？
-
08:18 AM Feature #13812: Refinements で定義した to_s を String interpolation が呼んでくれない
- 匿名ユーザー wrote:
> 既出だったらすみません。bugs.ruby-lang.org でも検索したんですが
> ...
Refinements導入時の議論で暗黙のメソッド呼び出しには影響しないようにするという判断が
ありましたが、その後一部の暗黙のメソッド呼び出しには影響するようになったので
string interpolationでも使えるようにしてもよいかもしれません。
最終的にはまつもとさんの判断になると思いますが、仕様変更の議論は英語でやっ... -
- Applied in changeset trunk|r59617.
----------
test/net/imap/test_imap.rb: Use Addrinfo.tcp in case localhost is ::1.
[ruby-dev:50208] [Bug #13825] -
- IMAPTest#test_starttls hangs.
See http://ci.rvm.jp/results/trunk@P895/4443 for details.
-
- [ruby-dev:50208] [Bug #13825]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59617 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- williamn (William Newbery) wrote:
> shevegen (Robert A. Heiler) wrote:
> ...
`??` is a string literal, and `//` is a regexp literal.
> ```ruby
> ...
Why not keyword arguments?
08/17/2017
-
- * method.h (rb_method_definition_t): rb_method_type_t should be
unsigned as it needs 5bits at least for signed extension.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59616 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:34 PM Revision 7b15bd95 (git): * 2017-08-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59615 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:34 PM Revision d067b263 (git): Add optimization for creating zerofill string
- ```
require 'benchmark'
n = 1 * 1024 * 1024 * 1024
Benchmark.bmbm do |x|
x.report("*") { 0.chr * n }
x.report("ljust") { String.new(capacity: n).ljust(n, "\0") }
end
```
Before
```% ./ruby test.rb
Rehearsal ------------------------... -
03:08 PM Bug #13794: Infinite loop of sched_yield
- The patch above does not work because native_reset_timer_thread runs after fork in the parent. Attached an alternative patch that runs in gvl_atfork and appears not to run in the parent. Again I do not believe this is necessarily the cor...
-
- I am now testing the following patch:
~~~
diff --git a/thread_pthread.c b/thread_pthread.c
index 4aa2d620a2..fe99524a54 100644
--- a/thread_pthread.c
+++ b/thread_pthread.c
@@ -1685,6 +1685,7 @@ native_stop_timer_thread(void)
s... -
- Applied in changeset trunk|r59613.
----------
vm_method.c: alias warning at refined method
* vm_method.c (rb_method_entry_make): suppress a warning at
refined method which will not be redefined.
[ruby-core:82385] [Bug #13817] -
- It's a ruby's bug.
"old <<" means a refined method, but it is not redefined actually.
```ruby
class C
def t; :t; end
def f; :f; end
end
module M
refine C do
alias foo t
end
end
class C
alias foo f
end
... -
- * vm_method.c (rb_method_entry_make): suppress a warning at
refined method which will not be redefined.
[ruby-core:82385] [Bug #13817]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59613 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * method.h (rb_method_definition_t): define type as an enum for
debugging.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59612 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parser_number_literal_suffix): keep token after numeric
suffix to show the value in an error message.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59611 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:31 PM Revision e60c38cb (git): * 2017-08-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59610 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:31 PM Revision 50df0467 (git): Use `*` instead of `**` in .editorconfig
- It seems `**` is same as `*` when no `/` exist.
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59609 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:28 AM Feature #9450: Allow overriding SSLContext options in Net::HTTP
- Being able to exclude versions of TLS and/or add additional option flags (without monkey patching) would indeed be quite useful, especially in the cases where TLS 1.0 needs to be excluded for compliance reasons. Hopefully this issue will...
-
03:47 AM Misc #13819 (Closed): removing issues... [p *local vars]
- OK, closing as per request.
-
- Andreas, it's easy to say "might be improved", but without the concrete design, it's worth nothing for us.
We designed for reasons, with the balance of features. Please submit the proposal, if you come up with the new idea.
Matz. -
12:01 AM Feature #13820: Add a nil coalescing operator
- williamn (William Newbery) wrote:
>
> ...
Not in perl ;)
>
> ...
Yes, short-circuit is handy. It's why I was a proponent of `&.`. Maybe it's okay to add `//` even if it's only used sometimes.