Activity
From 08/07/2017 to 08/13/2017
08/13/2017
-
10:52 PM Feature #13805: Make refinement scoping to be like that of constants
- jeremyevans0 (Jeremy Evans) wrote:
> You probably want to read the very long issue that introduced refinements (#4085), which contains the reasoning.
I thought there'd be one of these long discussions floating around, thanks for the ... -
09:45 PM Bug #13811 (Closed): Ruby 2.4.1 fails to compile inside qemu armhf - signal 11 (Segmentation fault)
- I'm using this Dockerfile to compile: https://github.com/docker-library/ruby/blob/ecbfdeb2b71e155222b1d3df0a33685247f00616/2.4/alpine3.6/Dockerfile, except with FROM resin/armhf-alpine (https://hub.docker.com/r/resin/armhf-alpine/) which...
-
02:48 PM Bug #13810 (Closed): Inconsistency between Date and Time.strftime("%v")
- This seems odd. Each function matches its documentation, but the document and implementation of `Date.strftime("%v")` differs from the documentation and implementations of `Time.strftime("%v")` and `DateTime.strftime("%v")`.
```
ruby... -
01:43 PM Bug #13809 (Closed): Unused variable warning does not occur when a method with the same name was called
- Applied in changeset trunk|r59585.
----------
parse.y: set used flag in gettable
* parse.y (dvar_defined_ref, dvar_defined): rename macros. only
gettable uses the former. assignable should not set LVAR_USED
flag.
* parse.y (gett... -
12:42 PM Bug #13809 (Closed): Unused variable warning does not occur when a method with the same name was called
- ## problem
~~~ ruby
a = 1
a()
~~~
`a` is unused, but `ruby -cw` does not add warning for this code.
~~~
$ ruby -cw test.rb
Syntax OK
~~~
## Cause
The parser changes mode by lvar definition. At that time, pars... -
- * spec/mspec/lib/mspec/utils/script.rb (entries): skip empty
directories so that at least one file would run.
Merged https://github.com/ruby/spec/issues/459
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59586 b2dd03c8-39d4-4d8f-9... -
- * parse.y (dvar_defined_ref, dvar_defined): rename macros. only
gettable uses the former. assignable should not set LVAR_USED
flag.
* parse.y (gettable_gen): set used flag on local/dynamic variables
instead of setting in lexer. ... - 12:14 PM Revision 2bbc3052 (git): REXML: Fix a bug that unexpected methods can be called as a XPath function
- [HackerOne:249295]
Reported by Andrea Jegher. Thanks!!!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59584 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/stringio/stringio.c (strio_read): suppress an
implicit-fallthrough warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59583 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/stringio/stringio.c (strio_gets): should return string with
the external encoding, at empty chomped result .
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59582 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/stringio/stringio.c (strio_gets): should return string with
the external encoding, at empty result.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59581 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- naruse (Yui NARUSE) wrote:
> ```diff
> ...
Why codepoints?
08/12/2017
- 05:41 PM Revision c5f66a37 (git): * 2017-08-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59580 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:41 PM Revision e389bf89 (git): Suppress warning: shadowing outer local variable - klass
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59579 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ```diff
diff --git a/NEWS b/NEWS
index 4bfca9240c..1e66e94879 100644
--- a/NEWS
+++ b/NEWS
@@ -94,6 +94,7 @@ with all sufficient information, see the ChangeLog file or Redmine
* String#delete_prefix! is added to remove prefix de... -
04:03 PM Feature #13795: Hash#select return type does not match Hash#find_all
- > In the worst case, ruby 3.x may accept backwards-incompatible changes so either way
> ...
I fully agree that changing Hash#select and #reject (or even #find_all) should not be a 2.x change! -
- > > Also, as a side note, it seems that Hash#select and #reject really are the only two methods that behave this way. And even inside Hash, methods like #collect, #collect_concat, #drop, #drop_while, #grep, #max, #max_by, #min, #min_by...
-
02:53 PM Feature #13795: Hash#select return type does not match Hash#find_all
- Changing the behavior of Hash#select/reject broke a lot of files, some in [very strange ways](https://travis-ci.org/ruby/ruby/builds/263508096?utm_source=github_status&utm_medium=notification).
This makes me think that such a change w... -
11:11 AM Feature #13795: Hash#select return type does not match Hash#find_all
- On 2017/08/11 01:12, david.n.arnold@gmail.com wrote:
> Also, as a side note, it seems that Hash#select and #reject really are the only two methods that behave this way. And even inside Hash, methods like #collect, #collect_concat, #... -
06:30 AM Feature #13795: Hash#select return type does not match Hash#find_all
- > Ruby has been not backwards-compatible in several releases, so I don't see that as
> ...
It all depends on matz, whether he agrees with the assessment or whether he does not.
I won't comment on the proposal and discussion as such, th... -
- It seems useless without method chain, i.e., variable `a` is too simple as an example.
That is, this is a variant of `yield_self`.
```ruby
foo.bar.zot.yield_self {|a| a.some_condition ? a : b}
```
or
```ruby
foo.bar.zot.ve... -
- I don't see any improvement. The new way that would be possible with the `verify` method is longer and more complicated than the simple and straightforward `a.some_condition ? a : b`.
-
- I have no particular pro or con opinion about your proposal, but I just
want to say that the last variant is not very pretty.
The lonely guy operator staring at the dot before him is pressed hard
against the wall behind him there, t... -
05:42 AM Bug #13808 (Closed): lib/ipaddr.gemspec includes `git ls-files -z`
- `git ls-files -z` in gemspec may occur error.
see https://bugs.ruby-lang.org/issues/13423 and/or https://bugs.ruby-lang.org/issues/12736 -
-
- Yes, works as the code specifies, not a bug, so misfiled.
I anyone wants to test via copy/paste into IRB, here is a slightly reformatted variant:
```ruby
y = 1
loop do
y += 1
next unless y % 2==0
puts y
break if y >... -
- I do not think that issue #4085 necessarily has to be the "one and only one true refinement", in
particular if we keep in mind that towards ruby 3.x, even syntax changes could happen if they
may make sense (and matz would approve).
... -
- Applied in changeset trunk|r59578.
----------
stringio.c: encoding at EOF
* ext/stringio/stringio.c (strio_read): should return string with
the external encoding, at EOF too.
[ruby-core:82349] [Bug #13806] -
- * ext/stringio/stringio.c (strio_read): should return string with
the external encoding, at EOF too.
[ruby-core:82349] [Bug #13806]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59578 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:34 AM Revision 201d0e7e (git): * 2017-08-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59577 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/stringio/test_stringio.rb (test_read): add assertions
of return value of read with a buffer string.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59576 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/11/2017
-
11:02 PM Bug #13806: StringIO encoding conversion
- naruse (Yui NARUSE) wrote:
> The 4th line's comment, 'reads "foo"' is wrong; it returns ''.
> ...
You're right about the value. I guess this explains the encoding ASCII-8BIT encoding, which is somehow consistent with the other EOF r... -
- > s = StringIO.new("foo", "w+") # => #<StringIO:0x007f879e81f268>
> ...
The 4th line's comment, 'reads "foo"' is wrong; it returns ''.
Therefore though it's not expected encoding, that's not so bad. -
- StringIO's doc page says:
> Pseudo I/O on String object.
> ...
As it turns out, this is precisely my use case, as I was writing some tests that boiled down to something like a (highly simplified) this:
~~~ ruby
s = StringIO.new("... -
08:38 PM Feature #13807 (Closed): A method to filter the receiver against some condition
- I frequently see code that uses some value if that value satisfies a certain condition, and something else otherwise.
```ruby
a.some_condition ? a : b
```
And in most cases, the value of `a` is non-nil when the condition is satis... -
02:07 PM Bug #13799: ENV.dup returns a plain Object
- Understood. But what about removing 'dup' and 'clone' from ENV altogether ?
The fact that ENV is an object with singleton methods is an implementation detail. ENV is obviously meaningful if there is only one per process, but right now... -
- You have to use `clone` to copy singleton methods.
http://ruby-doc.org/core-2.4.1/Object.html#method-i-dup-label-on+dup+vs+clone
But the subject of `ENV` is only one per process, it's useless. -
01:20 PM Bug #13802: break inside loop is not working as expected
- The code is working as expected.
There are many ways to provide your preferred output. One way is to place the `break` statement before the `puts` statement. -
- I made a pull request: https://github.com/ruby/ruby/pull/1674
-
05:42 AM Feature #13805: Make refinement scoping to be like that of constants
- You probably want to read the very long issue that introduced refinements (#4085), which contains the reasoning.
-
- Refinements are currently lexically scoped, which makes their use burdensome when one wants to apply a refinement to an entire project, requiring boiler plate at the top of every project file. I propose that there ought to be a method of...
-
- Created pull request: https://github.com/ruby/ruby/pull/1673
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59575 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It's intentional.
See https://bugs.ruby-lang.org/issues/7613#change-35118 -
- Applied in changeset trunk|r59574.
----------
re.c: options for sub-regexp
* re.c (rb_reg_to_s): needs embedded options to check syntax of
sub-regexp. [ruby-core:82328] [Bug #13798] -
- * re.c (rb_reg_to_s): needs embedded options to check syntax of
sub-regexp. [ruby-core:82328] [Bug #13798]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59574 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- nobu (Nobuyoshi Nakada) wrote:
> ```ruby
> ...
Sorry, this doesn't fix it. Use `Array.new` with a block. - 01:27 AM Revision 890ae326 (git): * 2017-08-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59573 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (compile_array_keyword_arg): separate keyword splat
inside hash literal from argument list.
* parse.y (rparen): flag hash literal.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59572 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/10/2017
-
11:11 PM Feature #13803: Add Socket::Ifaddr.vhid on supported platforms
- There was a copy/paste error in my transcript. It should've read
~~~
$ sudo ifconfig epair create
$ sudo ifconfig epair0a 192.0.2.2/24 vhid 99
$ irb
> require 'socket'
> ...
=> #<Socket::Ifaddr epair0a UP,BROADCAST,RUNNING,PROMI... -
- VHIDs are used in the failover process for interfaces using the CARP protocol. This patch adds support for getting the VHID of an interface address. Tested on FreeBSD 11.0 and FreeBSD 12.0-CURRENT
$ sudo ifconfig epair create
$ s... -
- In Ruby, the main reason you would use protected instead of private is because you want different instances of the same class lineage to be able to access the method.
However, the rules around protected (callable only where self of th... -
- Interesting.
https://ruby-doc.org/core-2.4.1/ENV.html does not mention #dup so perhaps this comes
from Hash or some other upstream object?
I also can not quite think of a use case for .dup there, perhaps someone can explain
why E... -
- Fair enough.
In this case, I would ideally expect #dup to not exist at all (since the result is not what #dup is expected to return, which is a functional copy of the receiver), or at least raise. -
02:42 PM Bug #13799: ENV.dup returns a plain Object
- the Problem:
ENV is an Hash-like Object with having singleton methods to look like an Hash, but isn't one
dup does make a copy of an object of the same class, in that case useless because you don't want an Object and the singleton meth... -
- I was doing ENV.dup to get a copy of the environment that can be modified without affecting ENV. However, ENV.dup returns a plain Object
~~~
irb(main):005:0> ENV.dup
=> #<Object:0x00000002024fc0>
irb(main):006:0> ENV.dup['PATH']
N... -
- I am having difficulties understanding your proposal.
If I understand it correctly, you propose to add one or more methods that
would return, e. g., all **files** or all **directories** or all **symlinks**
or all **pipes**, yes?
... -
08:35 PM Bug #13802 (Rejected): break inside loop is not working as expected
- Reproduce process:
1. Create a file (<filename>.rb)
2. Add the below code
3. Run with syntax - ruby <filename>.rb
your ruby version (ruby -v):
ruby 2.3.1p112 (2016-04-26) [x86_64-linux-gnu]
reproducible ruby script:
```ruby
... -
- In keeping with other class semantics, Set should implement an inclusion / membership test for #===.
For example with Range:
~~~ ruby
(1..3) === 2 #=> true
~~~
Desired behavior:
~~~ ruby
Set[1, 2, 3] === 2 #=> true
~~~
... -
05:27 PM Bug #13800 (Rejected): Possible regression of Object#method in Ruby 2.3+ for aliases
- The behavior of `Object#method` changed in 2.3 when using it to compare aliases. The change is best illustrated below:
~~~ ruby
module Foo
def foo
end
alias_method :foo_foo, :foo
end
class Bar
include Foo
alias_met... -
- I did some research to explore the idea that *more* Enumerable classes should implement #select (and even #collect, #drop, etc) to return their own type, since that sounds appealing on the surface.
While classes like Array, Hash, and ... -
- davidarnold (David Arnold) wrote:
> If there is a convention where every class that includes Enumerable has to have a set of functions that returns an instance of the same class, you wouldn't just have to implement #each, you'd have to ... -
02:46 PM Revision 28c02b9e (git): Fix types of function argument
- * doc/extension.ja.rdoc: Fix types of rb_ary_aref argument
* doc/extension.rdoc: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59571 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:47 PM Bug #13798 (Closed): Strange "invalid subexp call" warning happens inside of comment
- Attached script renders "invalid subexp call" warning.
```
zsh % ruby warn.rb
warn.rb:4: warning: invalid subexp call
```
This is strange in several ways:
- The warning is triggered by Regexp#to_s, not by the compilation.
... -
12:57 PM Revision f6e90bb9 (git): fix a typo in comment.
- * cont.c (typedef struct rb_context_struct): fix a typo in comment.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59570 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:37 PM Revision 8b8597e2 (git): Import ruby-electric.el version 2.3.1 from upstream
- It now supports [enh-ruby-mode](https://github.com/zenspider/enhanced-ruby-mode).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59569 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- You share the same array instance as sub-arrays.
```ruby
def initialize(totalSize)
@data_array = Array.new(totalSize,[])
end
```
Make different instances.
```ruby
@... -
11:39 AM Bug #13797 (Rejected): Using .push on an 2d array class-instance variable causes the whole array to be overwritten with the .push value; is this a bug?
- I was building a class to hold results for analysis 'cells' in a model; each 'cell' is a position in an array, with each result stored in a sub-array - this collates multiple results per cell which can then be iterated through later for...
-
- * vm_core.h (VM_UNREACHABLE): tell unreachable if possible.
suppress an invalid-noreturn warning at rb_fiber_start.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59568 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:46 AM Bug #13796 (Closed): Please backport r59567 (openssl: import v2.0.5)
- This fixes the "no OPENSSL_Applink" issue on mswin builds, a bug in the PEM passphrase callback, and the test failure on Debian sid (which has removed TLS 1.0 support).
-
- Import Ruby/OpenSSL 2.0.5. The full commit history since v2.0.4
(imported at r59081) can be found at:
https://github.com/ruby/openssl/compare/v2.0.4...v2.0.5
This will fix the test failure on latest Debian sid and the "no
OPENS... -
06:26 AM Revision c9bb3cae (git): use VM_UNREACHABLE() instead of rb_bug().
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59566 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * cont.c (fiber_restore_thread): added (separate from cont_restore_thread).
* cont.c (fiber_setcontext): call fiber_restore_thread() directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59565 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59564.
----------
ruby.c: ignore non-option in shebang line
* ruby.c (moreswitches): process all words as options only in
an environment variable, but not in a shebang line.
[ruby-core:82267] [Bug #13786] -
- * ruby.c (moreswitches): process all words as options only in
an environment variable, but not in a shebang line.
[ruby-core:82267] [Bug #13786]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59564 b2dd03c8-39d4-4d8f-98ff-823fe69... -
- * vm_core.h: Ruby processes run with two stacks, a machine stack and a
VM stack. To make it clear, this fix renames
rb_execution_context_t::stack(_size) to vm_stack(_size).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59563 b2... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59562 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59561 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * thread.c: "Thread#to_s" is not defined without any reason. So this fix
define "Thread#to_s" which returns a string with some thread information.
Also this fix makes alias "inspect" which refers "to_s". This manner is
same as othe... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59559 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * cont.c (fiber_to_s): return with block and status information.
* proc.c (proc_to_s_): removed and introduce rb_block_to_s() function
to return block information string.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59558 b2dd0... -
02:33 AM Bug #13791: `belongs_to': unknown keywords: required, anonymous_class (ArgumentError) since Revision 59519
- Verified it has been fixed. Thank you.
-
- Applied in changeset trunk|r59554.
----------
vm_args.c: prefer optarg to keyword splat
* vm_args.c (setup_parameters_complex): prefer optional argument
to splat keyword arguments for backward compatibility.
[ruby-core:82280] [Bug ... -
- * cont.c: revisit fiber status.
"FIBER_RUNNING" status represents fiber is resumed or suspended.
This fix separate these two status explicitly.
FIBER_CREATED: Just after Fiber.new. Not resumed yet.
FIBER_RESUMED (new): Fiber#resu... -
- Applied in changeset trunk|r59556.
----------
compile.c: fix KW_SPLAT flag condition
* compile.c (compile_array_keyword_arg): fix the condition of
KW_SPLAT flag. splat is value node only without key node,
simple assoc argument is ... -
- * compile.c (compile_array_keyword_arg): fix the condition of
KW_SPLAT flag. splat is value node only without key node,
simple assoc argument is not. [ruby-core:82291] [Bug #13793]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... - 12:32 AM Revision c20fe431 (git): * 2017-08-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59555 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_args.c (setup_parameters_complex): prefer optional argument
to splat keyword arguments for backward compatibility.
[ruby-core:82280] [Bug #13791]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59554 b2dd03c8-39d4-4d8f-98ff-8...
08/09/2017
-
11:56 PM Bug #13794: Infinite loop of sched_yield
- >> How about checking owner_process before incrementing?
> ...
Checking it before the while loop might work though. -
- > Can you also check the value of timer_thread_pipe.owner_process?
I don't have any broken processes available right now, but I will check as soon as I can.
> ...
I'm afraid this fix doesn't quite match up in my mind. To clarify, I... -
11:41 PM Bug #13794: Infinite loop of sched_yield
- Eric Wong wrote:
> https://80x24.org/spew/20170809232533.14932-1-e@80x24.org/raw
Also, a disclaimer: I've been far from my usual self lately.
Everything about my proposed patch could be wrong and bogus; too.
Extra eyes are, a... -
- charlie@atech.media wrote:
> Bug #13794: Infinite loop of sched_yield
> https://bugs.ruby-lang.org/issues/13794
> ----------------------------------------
> I have been encountering an issue with processes hanging in an infinite loo... -
- Thanks for the report. I'll take a look at it in a few hours.
-
- I have been encountering an issue with processes hanging in an infinite loop of calling sched_yield(). The looping code can be found at https://github.com/ruby/ruby/blob/v2_3_4/thread_pthread.c#L1663
while (ATOMIC_CAS(timer_thread_pip... -
- > I would like to suggest a third possible option: if Hash#select returning a Hash is useful, why not expand on this so that one of them always returns the input data structure?
So, I think people do like having a way to get the same ... -
- davidarnold (David Arnold) wrote:
> Ruby has been not backwards-compatible in several releases, so I don't see that as a reason per se to not entertain the two proposals.
You have a good point. This wouldn't be a big problem.
I wo... -
- > This might make the next version of Ruby not backwards-compatible in some instances. It might be better to leave the methods as they are.
Ruby has been not backwards-compatible in several releases, so I don't see that as a reason pe... -
- This might make the next version of Ruby not backwards-compatible in some instances. It might be better to leave the methods as they are.
There are instances where aliases to the same C functions act differently, such as lazy_super (a... -
- Enumerable#select and Enumerable#find_all are aliases. Hash is_a Enumerable, yet only Hash#select was overridden to return a Hash, with Hash#find_all still returning an Array. This is confusing since the message is that you can use sel...
-
06:00 PM Bug #13793: Compatible issue with keyword args behavior
- Minimal example:
```
def test(options={})
puts options
end
test **{foo: :bar}
```
-
06:09 AM Bug #13793 (Closed): Compatible issue with keyword args behavior
- I found breaking changes for keyword args with Ruby 2.5.1
Reproduction instructions:
* git clone git@github.com:bundler/bundler.git
* gem i rspec
* cd bundler && rspec spec/commands/viz_spec.rb:13
Ruby 2.4.1:
```
~/D/g/... -
- > I decided to update the pull request so that 'filter' and 'filter!' would work like 'select' and 'select!' for Array, Hash, Set, SortedSet, and ENV. I added spec and tests for filter to each of these, and given find_all's strange lack ...
-
- > No, please fix your bug. Your proposal and its title are explicitly to make filter an alias of select.
Not sure why this would be "my" bug to fix, I didn't have anything to do with the code that was written 10 years ago :) Also, my... -
- davidarnold (David Arnold) wrote:
> For the purpose of this feature request, I would leave the filter == find_all behavior the same. If the decision in the bug report is that Hash#find_all should match Hash#select, then an alias can be... -
- I think adding `filter` as an alias of `select` is a good idea, because indeed many languages use that name.
As for confusability with `reject`, everybody who already has seen `filter` in another language will assume it's an alias for... -
- > On another note, there is a small difference between 'find_all' and 'select', due to 'select' being overridden for hashes. (https://stackoverflow.com/questions/20999192/is-find-all-and-select-the-same-thing)
> ...
This is a very inter... -
- Opened https://github.com/rails/rails/issues/30160 to ask wider information at Rails side.
-
-
01:29 PM Bug #13690: next in once causes [BUG]
- ruby_2_3 r59553 merged revision(s) 59202.
- 01:29 PM Revision e55b415c (git): merge revision(s) 59202: [Backport #13690]
- compile.c: disallow next in once
* compile.c (iseq_compile_each0): turned dregx context in "once"
into "guarded" type from "block" type, to disallow `next`,
`break`, `redo` as well as outside "once".
... - 12:30 PM Revision 12474f03 (git): * test/ruby/test_process.rb (test_rlimit_{name,value}): test in UTF-8
- encoding. fix test failures introduced at r59531 on some platforms.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59552 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:17 PM Revision ecc889b1 (git): merge revision(s) 57634: [Backport #13150]
- marshal.c: revert r57631 partially
* marshal.c (rb_marshal_dump_limited): do not free dump_arg, which
may be dereferenced in check_dump_arg due to continuation, and
get rid of dangling pointers.
* ma... - 12:14 PM Revision 8bf48ec3 (git): * compile.c (iseq_compile_each): remove unused definition of unused
- variable derived from original patch.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59550 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r59549.
----------
ruby.c: origarg
* ruby.c (dladdr_path, ruby_set_argv): add guards for origarg.
[ruby-core:82272] [Bug #13788]
* ruby.c (proc_options, process_options, ruby_process_options):
set origar... -
- * ruby.c (dladdr_path, ruby_set_argv): add guards for origarg.
[ruby-core:82272] [Bug #13788]
* ruby.c (proc_options, process_options, ruby_process_options):
set origarg if not set yet.
* ruby.c (process_options): prefer argv in th... -
- ruby_2_3 r59548 merged revision(s) 58205.
- 10:45 AM Revision 81382143 (git): merge revision(s) 58205: [Backport #13380]
- Remove unused Init_frozen_strings declaration
Init_frozen_strings definition is removed in r51511.
https://bugs.ruby-lang.org/issues/11423
Patch by Kohei Suzuki <eagletmt@gmail.com>
* internal.h: Remove... -
- ruby_2_3 r59547 merged revision(s) 58262,58263.
- 10:43 AM Revision fd8fbe37 (git): merge revision(s) 58262,58263: [Backport #13369]
- fix TracePoint#return_value with non-local exits
* vm.c: get return_value from imemo_throw_data object (THROW_DATA_VAL()).
imemo_throw_data (TAG_BREAK) contains returned value.
However, imemo_throw_data (TAG_... -
- ruby_2_3 r59546 merged revision(s) 59368.
- 10:32 AM Revision 86024f70 (git): merge revision(s) 59368: [Backport #13753]
- random.c: ensure initialized
* random.c (get_rnd, try_get_rnd): ensure initialized to get rid
of crash in forked processes. [ruby-core:82100] [Bug #13753]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3... -
- ruby_2_3 r59545 merged revision(s) 59384.
- 10:30 AM Revision 6b330d8f (git): merge revision(s) 59384: [Backport #13759]
- strscan.c: fix segfault in aref
* ext/strscan/strscan.c (strscan_aref): fix segfault after
get_byte or getch which do not apply regexp.
[ruby-core:82116] [Bug #13759]
git-svn-id: svn+ssh://ci.ruby-lang.org/r... -
- ruby_2_3 r59544 merged revision(s) 58287.
- 10:28 AM Revision 3825bbfc (git): merge revision(s) 58287: [Backport #13411]
- configure.in: rpath with OPTDIR
* configure.in: add rpath flags which is needed for OPTDIR as well
as -L options, when it is given. [ruby-dev:50065] [Bug #13411]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/r... -
- ruby_2_3 r59543 merged revision(s) 59181.
- 10:14 AM Revision 1a150fe0 (git): merge revision(s) 59181: [Backport #13680]
- vm_insnhelper.c: break in once
* vm_insnhelper.c (vm_throw_start): size of catch table has been
included in iseq_catch_table struct, which could be NULL, since
2.2. e.g., proc-closure in `once'.
[r... - 10:12 AM Revision 048a82a9 (git): * ChangeLog: for the previous commit
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59542 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_3 r59541 merged revision(s) 58503.
- 10:09 AM Revision c2a7a82a (git): merge revision(s) 58503: [Backport #13523]
- node.h: sign-extend
* node.h (nd_line): should sign-extend. shifting `VALUE` extends
with zero bits if `sizeof(VALUE)` equals to `sizeof(int)`. the
zero bits are truncated if `sizeof(VALUE)` is bigger enoug... -
- r57971の単純なバックポートでいければよかったんですが、世の中はそんなに甘くありませんでした :-P
- 08:56 AM Revision 9ea6f49b (git): * compile.c (iseq_compile_each): the lifetime of new_opt have to be
- until this case block is end. this is a part of r57971.
[Backport #13766]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59540 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:40 AM Revision c3205d65 (git): [Backport #13150]
- this patch contains r54158, r57410, r57631 and r57954.
Prevent GC by volatile [Bug #13150]
test/ruby/test_marshal.rb test_context_switch (load) and test_gc (dump)
are failed on FreeBSD 10.3 and gcc7 (FreeBSD Por... -
- ruby_2_3 r59538 merged revision(s) 57415,57474.
- 08:31 AM Revision 2132fb9f (git): merge revision(s) 57415,57474: [Backport #13239]
- eval.c: copy special exception
* eval.c (setup_exception): make unfrozen copy of special
exception before setting up a cause.
test_io.rb: separate a test
* test/ruby/test_io.rb (test_closed_stream_in_r... -
- ruby_2_3 r59537 merged revision(s) 59307.
- 08:24 AM Revision f6d9f6fd (git): merge revision(s) 59307: [Backport #13284]
- a64: fix crash on register stack mark/sweep pass
* thread_pthread.c: move 'register_stack_start' earlier.
[ruby-core:79928] [Bug #13284] [Fix GH-1625]
Author: Sergei Trofimovich <slyfox@gentoo.org>
git-sv... -
- ruby_2_3 r59533 merged revision(s) 56576,56623.
- 08:17 AM Revision 8ed37cd4 (git): * 2017-08-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59536 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:17 AM Revision b709f59b (git): Missed `#` in usage
- * tool/generate-backport-changelog.rb (usage): missed `#` in usage
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59535 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:16 AM Revision 380a1e67 (git): * ChangeLog: forgotten to commit
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59534 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_3 r59533 merged revision(s) 56576,56623.
- 08:10 AM Revision 87cacf7e (git): merge revision(s) 56576,56623: [Backport #12678] [Backport #13429]
- * lib/net/smtp.rb (tlsconnect): support timeout for TLS handshake.
[ruby-core:76893] [Bug #12678]
* lib/net/protocol.rb (ssl_socket_connect): new method to implement
timeout for TLS handshake.
* lib/... -
- ruby_2_3 r59532 merged revision(s) 59333,59337.
- 08:08 AM Revision f4a8004e (git): merge revision(s) 59333,59337: [Backport #13616]
- Zlib::GzipReader#pos underflows after calling #ungetbyte or #ungetc at start of file [Bug #13616]
patched by Andrew Haines <andrew@haines.org.nz> [ruby-core:81488]
zlib.c: fix unnormalized Fixnum
* ext/zlib/zlib... -
- ruby_2_3 r59531 merged revision(s) 59322,59325.
- 08:03 AM Revision 640e708d (git): merge revision(s) 59322,59325: [Backport #13744]
- process.c: handle dynamic :rlimit_* symbols in spawn execopts
* process.c (rb_execarg_addopt_rlimit): hoist out of rb_execarg_addopt
(rlimit_type_by_sym): new wrapper for dynamic symbol
(rb_execarg_addopt): c... -
- ruby_2_3 r59530 merged revision(s) 59312.
- 07:56 AM Revision 177cb2c1 (git): merge revision(s) 59312: [Backport #13739]
- optparse.rb: get rid of eval
* lib/optparse.rb: try Float() and Integer() instead of eval,
which does too much things.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@59530 b2dd03c8-39d4-4d8f-98ff-823fe6... -
- This is consistency issue for ruby/spec.
Other ruby implementations use `spec/ruby` directory name.
* https://github.com/jruby/jruby/tree/master/spec/ruby
* https://github.com/graalvm/truffleruby/tree/master/spec/ruby
I think...
08/08/2017
-
- caller: https://github.com/rails/rails/blob/master/activerecord/lib/active_record/associations/builder/has_and_belongs_to_many.rb#L67
callee: https://github.com/rails/rails/blob/master/activerecord/lib/active_record/associations.rb#L168... -
- Since Revision 59519, Rails ActiveRecord unit test fails with this error.
> /home/yahonda/git/rails/activerecord/lib/active_record/associations.rb:1669:in `belongs_to': unknown keywords: required, anonymous_class (ArgumentError)
##... -
- A potential concern could be language bloat. Having too many aliases for the same methods could be confusing.
I was curious which underlying methods have the most aliases, so I wrote a quick script to look through the code.
[C method... -
04:22 PM Feature #13784: Add Enumerable#filter as an alias of Enumerable#select
- +1 to "filter". Martin Fowler refers to this method as "filter" in his articles about collection pipelines (https://martinfowler.com/articles/collection-pipeline/) and his post about the operation (https://martinfowler.com/articles/colle...
-
- > I understand that it is beneficial for people familiar with other languages that have a "filter" function like this, but I believe "filter" is confusing for people without that familiarity.
The great thing is that with aliases, you ... -
03:01 PM Feature #13784: Add Enumerable#filter as an alias of Enumerable#select
- I prefer not adding this alias. I understand that it is beneficial for people familiar with other languages that have a "filter" function like this, but I believe "filter" is confusing for people without that familiarity.
The word "fi... -
04:32 PM Bug #13788: libruby.so cannot be loaded by another program when --enable-load-relative is used
- It appears from the comment on `ruby_sysinit` that programs embedding ruby should NOT be calling it under normal usage:
/*! Initializes the process for ruby(1).
*
* This function assumes this process is ruby(1) and i... -
- To initialize a library properly is a responsibility of programs which use it, isn't it?
-
03:09 PM Bug #13790 (Closed): rubyspec.org domain seems to be expired
- ## Summary
Ruby codebase has http links to rubyspec.org, but the domain is likely owned by different person, and the web page shows completely different stuff.
Should we replace these URLs, so that we don't accidentally lead people t... -
-
-
- * dir.c (glob_helper): fix up r59527, dot files other than current
directory should not be included unless FNM_DOTMATCH is given.
[ruby-core:82266] [Bug #13785]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59529 b2dd03c8-39d4-4... -
- Applied in changeset trunk|r59527.
----------
dir.c: fix up r59481 for old kernels
* dir.c (glob_helper): fix up r59481 for old kernels, which
provide d_type member but just always set DT_UNKNOWN for any
entries. [ruby-core:82266]... - 08:34 AM Revision 9c69e0a8 (git): * 2017-08-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59528 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * dir.c (glob_helper): fix up r59481 for old kernels, which
provide d_type member but just always set DT_UNKNOWN for any
entries. [ruby-core:82266] [Bug #13785]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59527 b2dd03c8-39d4-... -
- Just use this Redmine project.
The most important feature of bug tracker is people can check info at only one place.
Distribute information multiple places is bad idea.
Moreover whether a feature is 2.x or 3.x is decided by Matz, ... -
- Ruby tries to parse options after "ruby" in a shebang line, and assumes there are only options.
So the last "ruby" is treated as "-ruby" option. -
06:07 AM Bug #13786: Unexpected behavior handling shebang
- shevegen (Robert A. Heiler) wrote:
> May I ask, what is the scl program doing with the shebang line?
Ok, lets use different shebangs, where the "scl" won't distract you:
~~~
$ cat <<EOF > foo
> ...
$ ruby foo
/usr/share/rubygem...
08/07/2017
-
09:31 PM Feature #13789 (Rejected): Dir - methods
- If having (new) Dir.entries, Dir.chidren, I would also add:
Dir.entries (includes all),
Dir.files Dir.dirs Dir.symlinks Dir.pipes (Dir.something_more?)
Dir.file?(filename); Dir.symlink[s]?(*symlinks), etc # give one or more names
... -
- --enable-load-relative causes `dladdr_path` in ruby.c to be called. This function assumes that `origarg` is set, but that global will only be set if `ruby_sysinit` is called. Normally that is done by the `ruby` executable, but not by oth...
-
- I didn't manage to compile Ruby v250 (because of other errrors), nice to see that this bug is fixed now.
(I mentioned it in a mailinglist some months ago).
Now I found in the changelog "r59074 | ko1 | 2017-06-13 11:52:33 +0900 (Tue, 13... -
- Hello everyone but especially so the whole ruby-core team,
This is very long, so if you just want the short gist, please
jump to the:
TL;DR line closer to the bottom.
Matz gave several presentations in the last ~3 years or so (... -
- May I ask, what is the scl program doing with the shebang line?
-
- Ruby exhibits unexpected behavior handling this shebang:
~~~
$ cat <<EOF > foo
> #!/usr/bin/scl enable rh-ruby22 -- ruby
> ...
$ ruby foo
/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such fi... -
- I noticed that travis-ci (https://travis-ci.org/ruby/ruby/builds) was red after I checked in r59521. I thought about reverting my commit, but realized that travis-ci had been red for trunk for a number of commits before mine. I hope we c...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59526 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59525 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:45 AM Revision c3f47622 (git): * 2017-08-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59524 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59523 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- :tada: