Activity
From 05/29/2017 to 06/04/2017
06/04/2017
-
11:56 PM Bug #13589: unmatched opening backtick / closing quote in NoMethodError: undefined method `name' for {}:Hash
- I'm curious what Matz thinks
-
10:51 PM Bug #13605: GC bug calling `ObjectSpace.each_object`
- robertgleeson (Robert Gleeson) wrote:
> The segfault no longer happens, since https://github.com/pry/pry/pull/1611/commits/94316852f5c1114f3073876558085835f2cf5377.
> ...
Spoke too soon, i think we just got lucky, it still happens when... -
- The segfault no longer happens, since https://github.com/pry/pry/pull/1611/commits/94316852f5c1114f3073876558085835f2cf5377.
if you want to reproduce a commit before that one should work, on the `respond_to-2.4-warnings` branch. -
- Another case:
Ruby v2.4.1 (ruby), Pry v0.10.4, method_source v0.8.2, CodeRay v1.1.1, Pry::Slop v3.4.0
/home/travis/build/pry/pry/spec/pry_output_spec.rb:119: warning: assigned but unused variable - custom_io
........................... -
- robertgleeson (Robert Gleeson) wrote:
> znz (Kazuhiro NISHIYAMA) wrote:
> ...
I realise my comment isn't clear, here's very simple code to show what i mean:
deprecated_constants = [:Fixnum, :TimeoutError, :Bignum, :FALSE, :TRUE, :NI... -
- znz (Kazuhiro NISHIYAMA) wrote:
> How about `class Object; deprecate_constant :Fixnum, :Bignum; end`?
> ...
It would be nice to have `constant_deprecated?`.
To avoid all of these warnings while supporting <2.4 and >=2.4 i track ... -
05:06 PM Feature #12589: VM performance improvement proposal
- normalperson (Eric Wong) wrote:
>
> ...
Yes, I know about GNULighting, Eric. It is an old project. It is
just a portable assembler.
Using it for JIT, it is like building a car having only a wheel. To
get a good perfor... -
07:29 AM Revision 86ae6129 (git): load.c: encode to OS path outside PUSH_TAG
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59013 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_require.rb (test_require_with_unc): remove extra
slash. the result of File.expand_path has a slash just follows
the drive letter.
https://github.com/ruby/ruby/commit/4ef849bd9014746821402e21053a53ea61b3690d#commit...
06/03/2017
-
11:38 PM Feature #9323: IO#writev
- I think this is a great idea. It avoids a ton of string issues - e.g. concatenating strings in Ruby before writing them out. It would be great if #write could take an array, and if possible, call writev.
-
- Thanks for that idea.
If that's the case, when appending to the write buffer:
~~~
write_buffer = String.new.b
unicode_string = "\u1234".force_encoding("UTF-8")
write_buffer << unicode_string
write_buffer.encoding # Changed from... -
12:32 AM Feature #13626: Add String#byteslice!
- samuel@oriontransfer.org wrote:
> https://bugs.ruby-lang.org/issues/13626
I used to want this, too; but then I realized IO#read and
similar methods will always return a binary string when given a
length limit.
So String#slice! ... -
- It's a common pattern in IO buffering, to read a part of a string while leaving the remainder.
~~~
# Consume only part of the read buffer:
result = @read_buffer.byteslice(0, size)
@read_buffer = @read_buffer.byteslice(size, @read_b... -
10:17 PM Misc #12935: Webrick: Update HTTP Status codes, share them
- Could the namespaces be open, thereby allowing me to only require this file instead of the whole of `net/http`? It seems to me that, if I require this file without the `Net::HTTP` constant be defined, that this will fail.
-
08:17 PM Revision 7c8a060b (git): array.c: docs for Array#{sort,sort!}
- * array.c: [DOC] make example in the docs for Array#{sort,sort!}
match the call-seq and description by using the same block vars.
Based on a patch by Roque Pinel (repinel). [Fix GH-1628]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... - 05:11 PM Revision 4bf1fc3a (git): * 2017-06-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59010 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_require.rb (test_require_with_unc): ignore EPERM.
GetFileAttributes and CreateFile with backup semantics fail at a
symlink in a shared folder to another shared folder.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tru... -
04:39 PM Feature #13630: :[] method should accept block in nice syntax
- I agree. I always wondered about this too.
I did not make a suggestion like this because I suspect that one reason may be a parser issue, as otherwise it would most likely have been done already.
In particular for elements without ... -
12:24 PM Feature #13630 (Closed): :[] method should accept block in nice syntax
- ~~~ ruby
# given
module Bam
def self.[](bam)
yield bam
end
end
# SyntaxError: unexpected keyword_do_block
Bam['bam'] do |b|
puts b
end
# SyntaxError: unexpected { arg, expecting end-of-input
Bam['bam'] { |b|
... -
02:45 PM Bug #13631 (Closed): Cannot disable site and vendor directories
- (Related to bug #12392?)
mkconfig.rb deletes directory settings passed to configure if they are set to "no". Perhaps verconf.h.tmpl should check to see if a setting is missing
instead of if it's set to "no"?
This patch corrects th... -
- * file.c (path_check_0): preserve encoding of path name in warning
message.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59008 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The ext subdirectory Makefile's don't seem to invoke the "install-rb" rule during a static build.
As a workaround I ran this command before "make install":
find ext -name Makefile | xargs -L 1 sed -i "s/static: \\$/static: install-rb... -
- wanabe (_ wanabe) wrote:
> I guess the code snippet is from pry. https://github.com/pry/pry/blob/c18601d6a4ff97d1b6599ccd9ffc8c63b8d8fccb/lib/pry/input_completer.rb#L172
> ...
Thanks wanabe.
shyouhei (Shyouhei Urabe) wrote:
> What ... -
- * ruby.c (dladdr_path): dladdr is provided on recent cygwin, but
GetModuleFileNameW is used instead of it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59007 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Nothing changed actually.
-
09:54 AM Bug #13629 (Rejected): Improve performance for copying array elements
- ary_memcpy0() has calculated the cache line size every time when copy array elements.
This patch will replace it with pre calculated value of cache line size.
Array#+ will be faster around 2%.
### Before
~~~
Array#+(other)... -
-
- The docs for Proc#call have been fixed with above workaround in r57767 and related backports; the bug still exists, though.
I also opened an issue on GitHub: https://github.com/rdoc/rdoc/issues/452. -
10:07 AM Revision 26864584 (git): * vm_core.h: remove VM_FRAME_MAGIC_LAMBDA and introduce
- VM_FRAME_FLAG_LAMBDA. So that lambda block frame is
VM_FRAME_MAGIC_BLOCK | VM_FRAME_FLAG_LAMBDA.
* vm_core.h: remvoe VM_FRAME_MAGIC_PROC because nobody uses it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59006 b2dd03c8-39d4-4... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59005 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_require.rb (assert_require_insecure_path): get
rid of setting Encoding.default_internal, which affects load
path conversion.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59004 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- `module` statement requires a **name**, not a constant object.
-
06:43 AM Bug #13623: meta-programming, adding sub-module fails with syntax error
- So you are saying this is how it should work and not a bug? If that is true, I should close this. What do you mean when you say that `Object::const_get('Foo')::Bar` is syntactically a constant. Its contains characters that are not approp...
-
05:08 AM Bug #13619 (Rejected): Unable to configure on Cygwin i686 environment
- It's my mistake. I forgot to install `make` package of i686 environment.
`configure` detected msys `make. It's caused by this issue.
After installing cygwin-i686 make, I'm done to build with cygwin i686.
Thanks nobu for your advice. -
- Attached full log of stdout
-
04:12 AM Bug #13624: MinGW - TestIO#test_copy_stream_no_busy_wait - new failure
- Eric,
Thanks for the patch. I'll build tomorrow, isolate the test, then run it a few hundred times...
> And yeah, maybe you can figure out a way to improve Process.times for other Windows users.
After I learn c, I'll get right... -
- Greg.mpls@gmail.com wrote:
> Thanks for the response. Reminder (which I try to mention from time to time) - I'm not a c type, and I essentially just use Windows.
Maybe you'll become a "c type" anyways :)
I never set out to be, ei... -
04:11 AM Bug #13628 (Closed): rdoc json.gz files differ across builds
- lib/rdoc/generator/json_index.rb inserts the build time
into generated .gz files,
so they differ across each build,
making it hard for distributions like openSUSE's
to create bit-identical binary packages when those are using rdoc.
... -
- rdoc.rb inserts the current time into created.rid
so the file differs across each build,
making it hard for distributions like openSUSE's
to create bit-identical binary packages when those are using rdoc.
See https://reproducible-b... -
- vmakarov@redhat.com wrote:
> I've updated README.md of the project. I added performance (wall, CPU time, memory consumption) comparison of the current state of MJIT with some other MRI versions (v2.0, base) and implementations (JRuby,... -
01:07 AM Bug #12642: Net::HTTP populates host header incorrectly when using an IPv6 Address
- Is there a workaround for this? How should we connect to ipv6 servers?
- 01:04 AM Revision e6e29212 (git): test: attempt to reduce failures in assert_cpu_usage_low
- Try to make this test less fragile by taking into account
the worst case kernel timing resolution.
[ruby-core:81540]
* test/lib/test/unit/assertions.rb (assert_cpu_usage_low):
clamp measurement to minimum measurable time and warn
ab...
06/02/2017
-
- eregontp@gmail.com wrote:
> This is interesting work, I am curious to see how it will work out.
Thanks for the interest.
> This looks similar to what Crystal has [1].
Right. But actually I would use MRI 1.8 green threads as
... -
06:05 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- This is interesting work, I am curious to see how it will work out.
This looks similar to what Crystal has [1].
Does Kernel#puts potentially yields to another auto-Fiber?
I think that would be very counter-intuitive, but it would ... -
- eregontp@gmail.com wrote:
> Issue #13620 has been updated by Eregon (Benoit Daloze).
>
>
> normalperson (Eric Wong) wrote:
> > Honestly, this proposal seems so wrong and outlandish that I
> > wonder if I am misreading or misun... -
01:31 PM Feature #13620: Simplifying MRI's build system: always make install
- Just a word of encouragement here.
The ways in which ruby seems to differ between installed and in-tree testing has bitten me doing Ruby+OMR work a number of times, and I'd love to see some simplification. (In particular, I load Ruby... -
- normalperson (Eric Wong) wrote:
> Honestly, this proposal seems so wrong and outlandish that I
> ...
I see your point, but I think we have a rather different view on this question.
Let me show you my opinion to understand better.
... -
09:43 PM Bug #13548: miniruby SEGV while building with non-default CFLAGS (caused by __builtin_setjmp)
- nobu (Nobuyoshi Nakada) wrote:
> It is not assigned since r43522.
I'm sorry. What I wrote was not what I meant.
The opengroup docs say setjmp should be used as "entire controlling expression" (with slight possible modifications), ... -
- Eric,
Thanks for the response. Reminder (which I try to mention from time to time) - I'm not a c type, and I essentially just use Windows.
> Curious, do you know what the kernel timer resolution is on your system?
No idea. But... -
- Greg.mpls@gmail.com wrote:
> Bug #13624: MinGW - TestIO#test_copy_stream_no_busy_wait - new failure
> https://bugs.ruby-lang.org/issues/13624
<snip>
> Today's MinGW build had a new failure, one that I don't recall seeing before.... -
- Today's MinGW build had a new failure, one that I don't recall seeing before.
Code is (located [here](https://github.com/ruby/ruby/blob/trunk/test/ruby/test_io.rb#L535-L546)):
```ruby
def test_copy_stream_no_busy_wait
msg = 'r5... -
- Applied in changeset trunk|r59002.
----------
string.c: docs for String#split
* string.c: [DOC] clarify docs for String#split when called
with limit and capture groups.
Reported by Cichol Tsai. [ruby-core:81505] [Bug #13621] -
- * string.c: [DOC] clarify docs for String#split when called
with limit and capture groups.
Reported by Cichol Tsai. [ruby-core:81505] [Bug #13621]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59002 b2dd03c8-39d4-4d8f-98ff-823f... -
- Eregon (Benoit Daloze) wrote:
> Or do we have a way to test CI (Travis + rubyci.org) before committing?
As you know, Travis will run on a PR.
A few people seem to state that trunk builds and tests fine on mswin, but Appveyor doesn... -
- Ran a MinGW build on `ruby 2.5.0dev 2017-06-02 58998`. Ran tests three ways:
1. `make test-spec` - pkg/install bin folder in path
2. `make test-spec` - pkg/install bin folder not in path
3. `mspec` - pkg/install bin folder in path
... -
- I'll try a MinGW build shortly.
Re `IO.copy_stream`, I believe it has existed since [Ruby 1.9.3](http://ruby-doc.org/core-1.9.3/IO.html#method-c-copy_stream), which should be far enough back for current test code. Also, I've only pai... -
- Here is a version of the spec_helper.rb working on MRI 2.2 to trunk on Linux (and I would expect macOS as well).
@Greg and @nobu:
Could you test it on Windows?
Then should I commit it?
Or do we have a way to test CI (Travis + rub... -
- Sounds good, I did not know IO.copy_stream can be used with 2 path Strings as well. It's a bit of a strange name for "cp".
But I think I slightly prefer the current implementation, it uses only well-known basic functionality such as Fil... -
- Eregon (Benoit Daloze) wrote:
> MSpec's #cp should use "rb"/"wb" modes obviously.
Why not `IO.copy_stream`?
-
04:40 PM Bug #13593: Addrinfo#== behaves oddly
- I wonder if naive comparison like this is advisable?
-
04:13 PM Feature #13625 (Rejected): BigDecimal short form / shorthand
- Add a shorthand for creating a BigDecimal, similar to how 1.2r creates a Rational.
~~~ ruby
> 3.1d
=> #<BigDecimal:7fde9def71c0,'0.31E1',18(18)>
~~~
- 03:38 PM Revision cd4cbc7b (git): * 2017-06-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59001 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59000 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:28 PM Feature #3719 (Closed): open-uri should allow redirects from http to https
- OK, Closing. Thank you.
-
03:23 PM Feature #3719: open-uri should allow redirects from http to https
- (I have no idea why I deleted the parent task, sorry about that.)
-
- With #859 fixed (thank you!), can this now be closed?
-
- Well `const_get('Foo')` is syntactically a non-constant while `const_get('Foo')::Bar` is. This is the ultimate reason why working_meta works but failing_meta fails. If you want to meta-program you have to be explicit like `const_get('F...
-
- ~~~ruby
module Foo
end
# Failing with syntax error is the code below
module Object::const_get( 'Foo' )
module Bar
end
end
~~~ -
- The goal is to add a sub-module to a higher level module. The higher level module is derived from its name in a string. This works in one case and gives an unexpected syntax error in another case.
```
failing_meta:4: syntax error, un... -
- * test/ruby/test_require.rb (assert_require_insecure_path): more
tests for loading insecure path.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58999 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:08 PM Misc #13622 (Assigned): Documentation missing
- In documentation for method IO.nread important information is missing: you must do 'require "io/wait"' before using it. May be some other methods of IO in 'io/wait' are missed this IMPORTANT notice.
-
09:26 AM Bug #13616: Zlib::GzipReader#pos underflows after calling #ungetbyte or #ungetc at start of file
- Here's an attempt at a patch to check if pos will be negative and handle that scenario accordingly.
-
- @nobu Any update on this? I think your patch is OK.
-
- * test/ruby/test_require.rb (assert_require_nonascii_path):
fallback when LANG=C.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58998 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_require.rb (assert_require_nonascii_path): the
path in error message is converted to filesystem encoding.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58997 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * file.c (rb_find_file_safe): preserve encoding of path in
SecurityError messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58996 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Can you try with Ruby 2.4.1?
And `second run` is caused by rspec specification. It's not interpreter's bug.
-
- I attached result of `bash -x /path/to/configure`
06/01/2017
-
- eregontp@gmail.com wrote:
> https://bugs.ruby-lang.org/issues/13620
> Hello all,
>
> I've been bitten recently when modifying ruby/spec or in #13570 by the sheer number of different configurations to build and test in MRI.
> Cur... -
05:17 PM Feature #13620: Simplifying MRI's build system: always make install
- nobu (Nobuyoshi Nakada) wrote:
> Let's zap in-source-dir builds first.
I don't agree.
I hadn't see a software which denies in-source-dir builds.
> ...
Before changing something in editor, I must wait running current code.
I don'... -
- naruse (Yui NARUSE) wrote:
> I object this.
> ...
Actually the numbers above are for building just after a pull.
And if any file is touched, it takes longer than install-nodoc.
> But on developing, you need to compare with null bui... -
01:23 PM Feature #13620: Simplifying MRI's build system: always make install
- nobu (Nobuyoshi Nakada) wrote:
> Let's zap in-source-dir builds first.
I want to agree with you, but every users of tarball packages run `configure` in the directory where it exists. -
- Let's zap in-source-dir builds first.
-
- I object this.
You are counting only full build.
But on developing, you need to compare with null build.
```
% time make -j8 main
CC = clang
LD = ld
LDSHARED = clang -dynamiclib
CFLAGS = -O3 -march=native -gdwarf -fno-fa... -
- I think runruby is needed for cross compilations.
By theory you can't test a cross-compiled ruby binary so I guess it might make sense to install before test. But I'm quite skeptical about the possibility of deleting runruby. -
- Hello all,
I've been bitten recently when modifying ruby/spec or in #13570 by the sheer number of different configurations to build and test in MRI.
Currently, I know 4 of them, and I can tell you it is a big headache to make it work... -
- ko1@atdot.net wrote:
> My opinion is opposite. I think "For human being using threading is too hard to use correctly" or "Rubyist shouldn't care about threading difficulties". I agree my opinion is extreme and many "advanced" programme... -
- normalperson (Eric Wong) wrote:
> I disagree. I do not recall Ruby 1.8 Threads being a big problem
> ...
...
> However, I do not believe it
> ...
...
> And yes, I think native threading bugs are trickier to track down
> ...
...
... -
- ko1@atdot.net wrote:
> Issue #13618 has been updated by ko1 (Koichi Sasada).
>
>
> Thank you for your great work.
You're welcome :)
> # summary of this comment
>
> Recent days I'm thinking about this feature's "safety" or... -
- Another idea is change this name from Fiber but thread-related name, but implementation is based on Fiber. It means resurrection of ruby 1.8 green thread without time based preemption (actually, implementation is similar).
Personally ... -
- Thank you for your great work.
# summary of this comment
Recent days I'm thinking about this feature's "safety" or "dependability".
Because of this issue, I think it is difficult to employ this feature right now.
# Non-auto-fib... -
- Pull request below for non-"git am" users...
I tried my best to add many comments throughout the code.
I realize this is a lot of new code; and not a typical or common
usage of kqueue or epoll. The kqueue code ended up being ver... -
- ```
auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
Implement automatic Fiber yield and resume when running
rb_wait_for_single_fd and rb_waitpid.
The Ruby API changes for Fiber are named after existing Thread
method... -
- MSP-Greg (Greg L) wrote:
> I checked on MinGW, and there is not an issue with `File.rename` with `src` and `dest` being on different drives. Where I got that from, I don't know...
It's the semantics of the rename(2) syscall on Linux... -
- I checked on MinGW, and there is not an issue with `File.rename` with `src` and `dest` being on different drives. Where I got that from, I don't know...
Hence, on MinGW/Windows, rename will work in all situations.
> MSpec's #cp sh... -
- MSP-Greg (Greg L) wrote:
> Benoit,
> ...
Oh, wow, thanks and nice find!
MSpec's #cp should use "rb"/"wb" modes obviously.
Would it work with that?
> Hence, since we know the `src` and `dest` are on the same partition/drive, I used... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58995 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * A system port might be taken by another process at any time.
* There are no useful expectations in this spec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58994 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Avoids failing the spec if rubyspec_temp is not empty.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58992 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * See https://bugs.ruby-lang.org/issues/13570.
* Found by MSP-Greg (Greg L).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * dir.c (dir_data_type): set RUBY_TYPED_WB_PROTECTED.
Insert WBs for dir_data::path.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58990 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:12 PM Revision 44396dbe (git): * 2017-06-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58989 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * proc.c (ruby_binding_data_type): set RUBY_TYPED_WB_PROTECTED.
Insert write barriers (WBs) to all of writes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- A documentation issue.
the `limit` limits only split fields, not separators. -
01:14 PM Bug #13621 (Closed): String#split returns an array longer than given limit, when passing a regexp with groups
- The String#split documentation(http://ruby-doc.org/core-2.4.1/String.html#method-i-split) described:
> If pattern is a Regexp, str is divided where the pattern matches. Whenever the pattern matches a zero-length string, str is split i... -
- * load.c (rb_require_internal): convert to path name with the
given safe level, without setting global safe level.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58986 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- When I invoke `configure` with cygwin i686 environment, I got following error:
```
config.status: creating Makefile
/usr/bin/sed: -e expression #1, char 18: unterminated `s' command
make: *** No rule to make target 'info-program'. ... -
- * vm_eval.c (check_funcall_missing): revert r58984. should call
method_missing if respond_to_missing is not redefined.
* vm_eval.c (rb_check_funcall_default): return the default value
if respond_to_missing and method_missing are no... -
- * vm_eval.c (check_funcall_missing): basic_obj_respond_to_missing
returns Qundef if respond_to_missing is not redefined.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58984 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58983 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * debug.c (ruby_dummy_gdb_enums): add enums for RObject, RModule,
RString, RArray.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58982 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:38 AM Revision d0e7329d (git): improve English for a warning message
- On DOSish systems, there is a warning message for \r\n line endings on shebang line.
Improve this message from "shebang line ends with \r may cause a problem"
to "shebang line ending with \r may cause problems".
git-svn-id: svn+ssh://ci... -
- `require` searches a library across load paths.
When many unreadable files matched, do you want all of them to be reported?
I think it would not make sense unless reporting the full path name.
Maybe warnings for existent but unloadabl... -
- Could you file this issue to https://github.com/ruby/psych ?
-
- I've updated README.md of the project. I added performance (wall, CPU time, memory consumption) comparison of the current state of MJIT with some other MRI versions (v2.0, base) and implementations (JRuby, Graal, OMR) on different bench...
-
- 12:05 AM Revision eb59047e (git): * 2017-06-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58980 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_core.h: rename absolute_path to realpath because it is expected name.
external APIs (#absolute_path methods) are remained.
* vm_core.h: remove rb_iseq_location_struct::path and
rb_iseq_location_struct::absolute_path and introdu...
05/31/2017
-
- I believe a solution exists at [Issue #13570](https://bugs.ruby-lang.org/issues/13570).
Please close. -
- Benoit,
After screwing around with quite a bit of make code, I found the (simple) issue. The code in [Object.cp](https://github.com/ruby/ruby/blob/trunk/spec/mspec/lib/mspec/helpers/fs.rb#L3-L11) does not properly copy binary files on... -
06:14 PM Bug #13617 (Closed): ruby 2.3.4 will not run nor install on same disk but different machine
- Following a hardware problem, I moved a HD to a slightly older machine. It boots up, but my rails environment crashes (https://stackoverflow.com/questions/43872146/ruby-not-accessible-on-same-disk-different-machine). I attempted to ins...
-
- After calling `#ungetbyte` or `#ungetc` at the start of file, `Zlib::GzipReader#pos` should be negative. However, the calculation uses unsigned integers, and underflow occurs.
Instead of the expected -1, the below outputs 184467440737... -
12:41 PM Feature #12694: Want a String method to remove heading substr
- \A is correct. I updated the description, thanks.
-
12:37 PM Feature #12694: Want a String method to remove heading substr
- > `str.sub(/^#{Regexp.escape(substr)}/, '') #=> 'def'`
I think `^` should be `\A` in description of this ticket. (and maybe in handle_tag_name_mixin.rb of fluentd too)
Which is expected?: first prefix of string only or prefix of ea... -
- Applied in changeset trunk|r58978.
----------
Improve performance of implicit type conversion
To convert the object implicitly, it has had two parts in convert_type() which are
1. lookink up the method's id
2. calling the method
S... -
- To convert the object implicitly, it has had two parts in convert_type() which are
1. lookink up the method's id
2. calling the method
Seems that strncmp() and strcmp() in convert_type() are slightly heavy to look up
the method's id... -
- Would be nice - the better error messages are, the easier it may be to solve problems related
from that. We had the did_you_mean gem from Yuki Nishijima, perhaps we will one day have a
do_you_want_to_fix_this_problem_that_way, like in... -
- sonots (Naotoshi Seo) wrote:
> It is not correct. The error class is still LoadError, only error message is changed.
OK, I see what you want. -
- It is not correct. The error class is still LoadError, only error message is changed.
-
- Mmm, this is my private feeling but it seems introducing whole Errno::Efoobar set into require seems to be a drastic change. If we do such change, a formely-legal script like this:
```ruby
begin
require 'foo'
rescue LoadError
... -
- I am thinking to apply a patch like:
```
diff --git a/load.c b/load.c
index 75ac4df..a8175ca 100644
--- a/load.c
+++ b/load.c
@@ -708,7 +708,7 @@ rb_f_load(int argc, VALUE *argv)
path = rb_find_file(fname);
if (!path)... -
- > you mean Errno::EPERM?
Ah, Errno:: EACCES
> ...
Right, I think other errno also should be given. -
- There's no such thing like PermissionError. Do you want to introduce one?
Or perhaps you mean Errno::EPERM? Then it sounds slightly odd to me, because other Errno errors such as Errno::ENOENT can be thought of. -
- * debug_counter.h: add the following counters:
* lvar_get: counter for lvar get.
* lvar_get_dynamic: counter for lvar get from upper frames.
* lvar_set: coutner for lvar set.
* lvar_set_dynamic: coutner for lvar set from upper fr... -
- * win32/Makefile.sub (LIBRUBY_LDSHARED): mswin build always
enables shared.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58976 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (lldb, lldb-ruby): add targets to debug with lldb.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58975 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- rovf (Ronald Fischer) wrote:
> nobu (Nobuyoshi Nakada) wrote:
> ...
Various distributions have various delays because they want to make sure they only ship widely used code, or because they don't have the time to follow every new relea... -
03:14 AM Bug #13615 (Third Party's Issue): YAML parser stops processing at the first newline when byte order mark is present
- When the input has byte order mark, the YAML parser stops processing the input upon seeing the first newline.
I believe this is a violation of YAML specification. [[http://www.yaml.org/spec/1.2/spec.html#id2771184]]
~~~
[1] pry(ma... -
- * misc/lldb_cruby.py (lldb_rp): evaluate without frames when no
process is running, and show error messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
05/30/2017
- 06:17 PM Revision e003725f (git): * 2017-05-31
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58973 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * object.c: [DOC] add an example for Object#yield_self that
better illustrates its purpose; other small improvements.
Reported by Vitaly Tatarintsev (ck3g). Patch by Marcus Stollsteimer.
[Fix GH-1637]
* object.c: [DOC] improve do... -
- It crashes in `fox16c.so`, not in ruby interpreter.
You should report this issue to the maintainers of FXRuby. -
02:55 PM Bug #13614 (Third Party's Issue): IFMapper v2.0.4 crashes on Windows FXRuby
- IFMapper v2.0.4 works perfectly on OSX and Linux, but on Windows it crashes under ruby2.4/2.3/2.2.
Here's the backtrace:
PS C:\tools\ruby24\bin> .\IFMapper
NOTE: RubyInstaller.add_dll_directory is deprecated; use "require 'ruby_in... -
03:11 PM Feature #13602: Optimize instance variable access if $VERBOSE is not true when compiling
- OK, here's a slightly revised benchmark that just measures
instance variable access without allocation:
~~~
require 'benchmark/ips'
$stderr.reopen('/dev/null')
class A
def initialize
@c = @d = @e = @f = nil
end
def... -
02:55 PM Bug #13612: Segmentation Fault
- There is one more observation I would like to add; I don't know whether or not this is important:
When the segmentation fault occured the first time in our original application with Cygwin MRI Ruby, I reexecuted the whole application ... -
- I just made a minor change, which shows better where the error occurs (segf_test_improved.rb). The program needs to be operated in the same way as segf_test.rb which I described before.
Two things are notable:
1. Like in the backt... -
- nobu (Nobuyoshi Nakada) wrote:
> And 2.3.3 has been outdated, try 2.3.4, 2.4.1, or trunk.
I just verified: There is no newer port available for Cygwin, at least not on those mirrors, which Cygwin offers.
However, I have included a... -
- rovf (Ronald Fischer) wrote:
> Aside from the fact that my company unfortunately does not allow me to send you the whole application, as this is a strategic product, I think you wouldn't be too happy to debug with it anyway, as it is ro... -
- nobu (Nobuyoshi Nakada) wrote:
> Please show the whole code to reproduce, not a part.
> ...
Aside from the fact that my company unfortunately does not allow me to send you the whole application, as this is a strategic product, I think ... -
- Please show the whole code to reproduce, not a part.
And 2.3.3 has been outdated, try 2.3.4, 2.4.1, or trunk. -
- I got a segmentation fault, fllowed by the message "You may have encountered a bug in the Ruby interpreter or extension libraries.". See attachment.
The exception occured in this piece of code:
```ruby
class EXPERT
FIND_C... -
- * enum.c (cmpint_reenter_check): extract from nmin_cmp and
nmin_block_cmp.
* enum.c (nmin_cmp): check if reentered before rb_cmpint.
[Feature #13437]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58971 b2dd03c8-39d4-4d8f-98ff-8... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58970 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Eregon (Benoit Daloze) wrote:
> When debugging/monitoring with TracePoint, it seems useful to know in which thread the event happens.
`Thread.current` is not enough?
> ...
I understand this side. But this issue doesn't solve perfo... -
- ko1 (Koichi Sasada) wrote:
> use case?
When debugging/monitoring with TracePoint, it seems useful to know in which thread the event happens.
It's also a trivial way to implement manually #13483, although not efficiently. -
- ko1 (Koichi Sasada) wrote:
> use case?
In which thread the event was happened.
Just thread id or something is also OK. -
- ### Background
https://github.com/google/google-api-ruby-client/issues/205
We've ever met a situation that read-permissions of files in released google-api-client gem were lost as:
```
$ ls -l ~/.rbenv/versions/2.1.3/lib/ruby/g... -
- ko1 (Koichi Sasada) wrote:
> Disadvantage is backtrace will be long for main script.
This only applies to the main script, and none of the other files so I think it's worth the gain in consistency.
Backtraces in anything but small s... -
- After consideration, I changed my proposal.
* Rename `#absolute_path` to `#real_path` (or `#realpath`) and make `#aboluste_path` as alias of `#real_path`.
* change `absolute_path` (`real_path`) on `eval` with given file name.
# su... -
09:56 AM Feature #13563: Implement Hash#choice method.
- Thanks reply, saturnflyer.
And I totally agree your propose.
Even if, this porpose is rejected.
I will fix code, and re-push it.
-
- Applied in changeset trunk|r58968.
----------
Improve performance of Enumerable#{sort_by,min_by,max_by,minmax_by}
This is totally same approach with r58964.
enum.c (sort_by_cmp): use OPTIMIZED_CMP() to compare the objects inste... -
- This is totally same approach with r58964.
enum.c (sort_by_cmp): use OPTIMIZED_CMP() to compare the objects instead of
`<=>' method dispatching for Fixnum/Float/String object.
enum.c (nmin_cmp): ditto.
enum.c (min_by_i): ditto.
enu... -
- * vm_core.h: add parameter names for rb_iseq_new*.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- http://rubyci.s3.amazonaws.com/unstable10x/ruby-trunk/log/20170527T221806Z.diff.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- On 2017/05/27 18:49, eregontp@gmail.com wrote:
>> However, this proposal breaks this expectation.
> Could you explain it?
>
> Is it because trace.enable { code } does not behave like
> begin; trace.enable; code; ensure; trace.disa... -
-
- In enc/utf_8.c, change maximum byte length of UTF-8 to 4 bytes (from 6)
to conform to definition of UTF-8. This closes issue #13590.
(This is a retry of r58954, after issue #13590 has been addressed.)
git-svn-id: svn+ssh://ci.ruby-lang.... -
- Applied in changeset trunk|r58964.
----------
Improve performance of Range#{min,max}
range.c (range_min): use OPTIMIZED_CMP() to compare the objects instead of
`<=>' method dispatching for Fixnum/Float/String object inside Range ob... -
- range.c (range_min): use OPTIMIZED_CMP() to compare the objects instead of
`<=>' method dispatching for Fixnum/Float/String object inside Range object.
range.c (range_max): ditto.
Range#min -> 34 % up
Range#max -> 44 % up
... -
- If you can modify MRI source code, please try to change `RGENGC_CHECK_MODE` in gc.c to `2` and run your program on your modified MRI again.
It will inserts many assertions and it may help.
Thanks,
Koichi -
01:05 AM Bug #13605: GC bug calling `ObjectSpace.each_object`
- I guess the code snippet is from pry. https://github.com/pry/pry/blob/c18601d6a4ff97d1b6599ccd9ffc8c63b8d8fccb/lib/pry/input_completer.rb#L172
Here are Dockerfile and patch for pry to reproduce the issue.
33 / 100 are aborted on my e...
05/29/2017
-
06:56 PM Feature #13378: Eliminate 4 of 8 syscalls when requiring file by absolute path
- Thank you for the feedback! I've attached an updated patch to address the issues.
As for testing it, I haven't been able to think of a reasonable method to verify the behaviour without using dtrace/strace, since the only observable ef... -
06:46 PM Feature #13604: Exposing alternative interface of readline
- I think I managed to simplify it quite a bit, if you would take a look :)
Also I'm thinking about exposing the add_hist setting, since it's saved on mReadline anyway, it would allow user to dynamicly enable/disable auto-adding of hist... - 05:56 PM Revision afa0e3c9 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58963 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58962 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58961 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Benoit,
Sorry, never set this to 'watch'. I'll try a build with MinGW.
FWIW, I just got one of the spec c files to compile with only the following --
```ruby
require 'mkmf'
Dir.chdir('src/build-x86_64/spec/rubyspec/optional/c... -
-
- I attach here the current version of the spec_helper.rb doing the compilation of extensions.
It seems to now work correctly for out-of-source builds,
and with an extra hack uses the right ruby in the Makefile
(RbConfig.ruby in ./rbcon... -
- Thanks for the fix nobu!
-
- Applied in changeset trunk|r58959.
----------
Run in separate process/pgrp [Bug #13609] -
- It occurs sporadically in these days.
It seems a race condition between `getpriority` and `setpriority` in a process group.
```ruby
# bug-13609.rb
Process.setpgrp
pr = Process.getpriority(Process::PRIO_PGRP, 0)
fork {Process.ge... -
- Trying to make a commit (r58954) for issue #13590, I got a CI error at https://travis-ci.org/ruby/ruby/builds/237086017. Reverting at r58955, the problem persisted at https://travis-ci.org/ruby/ruby/builds/237090520.
The error looked ... - 03:34 PM Revision ab86387a (git): * 2017-05-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58960 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58959 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:50 PM Feature #13606: Enumerator equality and comparison
- duerst (Martin Dürst) wrote:
> Actually, I wonder if there's any difference between what the OP wants and
> ...
The above allocates Arrays, Enumerator equality would not. -
- MSP-Greg (Greg L) wrote:
> Could be helpful, but some `Enumerators` are not ordered.
All `Enumerators` are ordered. The order is defined by the `each` method, or alternatively by the `to_a` method.
Actually, I wonder if there's an... -
02:50 PM Bug #13537: ruby crash in rb_gc_mark
- I can confirm having the same issue. It's intermediate but reproducible, and affects both 2.4.0 and 2.4.1 versions.
The setup is simple:
- OS X (macOS 10.12.5 with latest patches)
- XCode command line tools (also latest)
- rbenv ... -
- For the last two weeks, I have been successfully running `make test-spec` in [MinGW builds](https://msp-greg.github.io/file.mingw_test-all.html#test-spec-Failure-Error-Summary). Over this past weekend, there were several changes to the ...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58958 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:53 AM Revision fc7241ff (git): rubyspec: Fix method redefinition warning
- ruby/spec/rubyspec/library/erb/run_spec.rb:63: warning: method redefined; discarding old main
ruby/spec/rubyspec/library/erb/result_spec.rb:53: warning: previous definition of main was here
ruby/spec/rubyspec/library/erb/run_spec.rb:76: ... -
- ruby/test/erb/test_erb.rb:575: warning: assigned but unused variable - foo
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58956 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:16 AM Bug #13597: Does read_nonblock call remalloc for the buffer if does it just set the size attribute
- Hi Eric
Thank you so much for your response - it provided a lot of useful information I didn't know otherwise. I've pointed the user who opened the pull request to your response so he has the chance to update his code based on the new... -
09:57 AM Feature #13610 (Assigned): IPAddr doesn't provide helpful methods to get the subnet or IP address
- I've implemented it myself using some "wild" code around the .inspect or default return from an IPAddr object from ipadr.rb
It would be nice to, once having loaded an IP range, to then be able to get its subnet, its IP and its CIDR.
... -
- Revert change to maximum of 4 bytes for UTF-8 characters at r58954 temporarily.
This failed spec at https://travis-ci.org/ruby/ruby/builds/237086017, but it
is totally unclear why.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58955... -
- In enc/utf_8.c, change maximum byte length of UTF-8 to 4 bytes (from 6)
to conform to definition of UTF-8. This closes issue #13590.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58954 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- shyouhei (Shyouhei Urabe) wrote:
> domaio (Dorian M) wrote:
> ...
Well, to be precise, English quotations use ‘…’ and “…” in high-quality typography. The use of \`…' is a fallback convention on some systems. See https://en.wikipedia.org/... -
- haines (Andrew Haines) wrote:
> phluid61 (Matthew Kerwin) wrote:
> ...
Not true. There are quite a few East Asian encodings with max length of 2, 3, or 4. E.g. Shift_JIS, EUC_JP, GB18030,... But it's still true that the maximum size is... -
- * spec/mspec/lib/mspec/helpers/fs.rb (Object#mkdir_p): rescue
File.stat when the target does not exist.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * spec/mspec/lib/mspec/helpers/fs.rb (Object#mkdir_p): fix race
condition when multi_exec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58952 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58950 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:25 AM Bug #9993: x86_64 linux + i686 os = 32bit ruby, but `RUBY_PLATFORM=x86_64`
- I had similar issue
----
Environment info:
OS: FreeBSD 10.3 STABLE
rvm:
version: "rvm 1.29.1 (latest) by Michal Papis, Piotr Kuczynski, Wayne E. Seguin [https://rvm.io/]"
updated: "2 months 9 days 18 hours 28 minutes 46 seconds... -
- use case?
-
- rb_trace_arg_t, TracePoint's internal struct, already stores the thread which the event happened at,
but there's not API to fetch it.
How about adding an API to get the info.
```diff
diff --git a/test/ruby/test_settracefunc.rb b/te... -
- * spec/default.mspec: removed -I options for useless or non-
existent paths from flags. there is no library scripts and .ext
directory in the source directory.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58949 b2dd03c8-39d4-4... -
- What is `to_ignore` and `candidates` in your script? Is it possible for you to show us a step to reproduce your situation?
-
- I can't point a finger on the exact location where the script fails but it seems to be a memory corruption.