Activity
From 05/14/2017 to 05/20/2017
05/20/2017
-
11:32 PM Feature #13396: Net::HTTP has no write timeout
- naruse@airemix.jp wrote:
> Only supports Linux:
...And only with sockets where O_NONBLOCK is not set, because
the O_NONBLOCK flag will ignore SO_*TIMEO.
Anyways, I don't think using SO_*TIMEO for Ruby is worth it.
I think Rub... -
10:01 PM Feature #13396: Net::HTTP has no write timeout
- Only supports Linux:
```diff
@@ -10372,11 +10383,23 @@ static int
nogvl_wait_for_single_fd(int fd, short events)
{
struct pollfd fds;
+ struct timespec ts, *tsp = NULL;
fds.fd = fd;
fds.events = events;
... -
- The concept Net::HTTP#write_timeout sounds fine.
> However adding a Timeout.timeout call around req.exec did work.
Timeou.timeout should be avoided because it sometimes caused trouble and now eliminated.
(see also https://github.c... -
08:42 PM Feature #8631: Add a new method to ERB to allow assigning the local variables from a hash
- I would already suggest a new name when I read about the problems with overriding the current method, so I would agree that 2 would be a better approach, I'm just not sure which name would be best. I like result_with_hash, but it could b...
-
05:41 PM Feature #8631 (Feedback): Add a new method to ERB to allow assigning the local variables from a hash
-
08:01 PM Feature #13583: Adding `Hash#transform_keys` method
- I think the names are good, both #transform_keys and #transform_values.
Seem quite clear to me from the names.
On the linked older issue (-3 years), the names were different,
Hash#map_keys and Hash#map_values. Matz said that the n... -
08:56 AM Feature #13583: Adding `Hash#transform_keys` method
- I don't think you missed anything, except I would just point out to also add `Hash#transform_keys!`. I don't know if it's worth mentioning or just kinda automatically assumed.
-
01:49 AM Feature #13583: Adding `Hash#transform_keys` method
- Thank you for issuing this. I see there is an obvious needs for this transformation (stringify_keys) so I'm :+1: to the feature.
Let's have a concrete definition of this requested method:
- Its name is Hash#transform_keys.
- It r... -
06:55 PM Bug #13566 (Assigned): A process freezes at the beginning of C level backtrace when a certain SEGV is occurred
- This issue is not only for NULL but also the other address such as 0x00000000000001.
```
$ ruby -r fiddle -e 'Fiddle::Function.new(Fiddle::Pointer.new(1), [], Fiddle::TYPE_VOID).call'
-e:1: [BUG] Segmentation fault at 0x000000000000... -
- Hanmac (Hans Mackowiak) wrote:
> as Sorah did there: https://github.com/aws/aws-sdk-ruby/pull/1516
> ...
Yeah.
It should use pread if it can or simply read then restore the pos. -
- to unify a behavior with r58823 and r58825.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58826 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r58825.
----------
erb.rb: Allow explicit trimming carriage return
when trim_mode is "-", for Windows environments.
[ruby-core:39625] [Bug #5339] -
- when trim_mode is "-", for Windows environments.
[ruby-core:39625] [Bug #5339]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58825 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The current maintainer suggested this in ruby-dev:50113.
Please ping me if an issue happens in ERB.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58824 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r58823.
----------
erb.rb: Allow trimming carriage return
when trim_mode is "<>", for Windows environments.
[Bug #11464] -
- when trim_mode is "<>", for Windows environments.
[Bug #11464]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58823 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:36 PM Bug #13586 (Closed): Ruby hangs when accessing array which is modified in instance_eval after Coverage.start
- The following code will hang ruby:
~~~
# main.rb
require "coverage"
Coverage.start
require_relative "./foo"
# Perhaps we need more repetition to reproduce
1000.times do
Foo.new.count
end
~~~
~~~
# foo.rb
class ... -
- of LoadError in some method calls, not from `require "strscan"`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58822 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:58 PM Revision 9aa33d5d (git): * 2017-05-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58821 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58820 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Original `SimpleScanner` was used only in tests.
Since `SimpleScanner` and `SimpleScanner2` work in the same way, I want
to drop the one which can't be used in a normal situation.
The only difference was `SimpleScanner` can be loaded wi... -
02:07 PM Bug #13312: String#casecmp raises TypeError instead of returning nil
- > Can you handle this?
Ok. - 01:00 PM Revision f1e10bd2 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58818 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:00 PM Revision 33710d45 (git): Add coverage measurement mode by using gcov
- This experimental feature is only for Ruby-core team, not for casual users.
Usage: `./configure --enable-gcov && make && make exam && make gcov`
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58817 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:51 PM Feature #13568: File#path for O_TMPFILE fds has no meaning
- shyouhei (Shyouhei Urabe) wrote:
> At the meeting we discussed the use case of `File#path` and we thought there are 2 kinds:
> ...
A correction; The method which `open` calls is `to_path`, not `path`.
These are different.
> Do you ... -
07:20 AM Feature #13568: File#path for O_TMPFILE fds has no meaning
- like i said, open with write mode is the problem.
because it didn't fail with the nonexistent path
an way for it to make it work for `printf` or logger would be to make it's `#inspect` working (with not using path in that case)
ab... -
- At the meeting we discussed the use case of `File#path` and we thought there are 2 kinds:
- Pass it to `open()`
- Pass it to `printf()` or variant
We considered both and concluded it is best to return a nonexistent path, not `nil`... -
- The order of sed commands in Makefile of ripper was wrong: it tries to
replace `y.tab.c` with `ripper.c`, but before that, ytab.sed replaced
`y.tab.c` with `parse.c`, which led to a wrong result.
git-svn-id: svn+ssh://ci.ruby-lang.org/r... -
- * compile.c (compile_branch_condition, iseq_compile_each0):
eliminate unreachable branches in NODE_IF.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58815 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (compile_branch_condition): turn recursion at binary
logical operator into loop by goto, and check the result of RHS
of NODE_OR.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/test_prime.rb: remove alias after timeout test.
* lib/prime.rb: fix typo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r58812
-
09:47 AM Feature #9632 (Closed): [PATCH 0/2] speedup IO#close with linked-list from ccan - Applied in changeset trunk|r58812.
----------
speed up IO#close with many threads
Today, it increases IO#close performance with many threads:
Execution time (sec)
name trunk after
vm_thread_close 4.276 3.018
Sp... - 09:47 AM Revision 508091d9 (git): speed up IO#close with many threads
- Today, it increases IO#close performance with many threads:
Execution time (sec)
name trunk after
vm_thread_close 4.276 3.018
Speedup ratio: compare with the result of `trunk' (greater is better)
name ... -
- @marcandre
I actually was working on the essentially same fix for the test case and about to commit; only I did want to fix the test for Math.sqrt first (which could be backported) and then switch to Integer.sqrt. -
12:39 AM Bug #13492 (Closed): Integer#prime? and Prime.each might produce false positives
- Good catch.
I tweaked the timeout test by patching `Integer.sqrt`.
-
09:23 AM Bug #13343 (Closed): Improve Hash#merge performance
- Applied in changeset trunk|r58811.
----------
Improve Hash#merge performance
* hash.c (rb_hash_merge): use rb_hash_dup() instead of rb_obj_dup() to duplicate
Hash object. rb_hash_dup() is faster duplicating function for Hash object... -
- * hash.c (rb_hash_merge): use rb_hash_dup() instead of rb_obj_dup() to duplicate
Hash object. rb_hash_dup() is faster duplicating function for Hash object
which got rid of Hash#initialize_dup method calling.
Hash#merge will ... -
08:34 AM Bug #13191: sample/pty/shl.rb がうまく動かない
- ruby 2.4.2p131 (2017-05-10 revision 58637) [x86_64-linux] で試してみたところ、 r57530 も backport しないと C-z がきかないようです。
exit したときに shl.rb のプロンプトに戻ってこないので trunk で試してみたら同じ状態でした。
具体的には以下のように exit の後、操作が効かなくなるので C-z で止めて、再度 0 で選ぶと ThreadError になって sh... -
05:14 AM Bug #13578: Another iseq_set_sequence: adjust bug
- Thank you. While your test code does NOT repro under 2.4.1p111, it does under trunk. I've verified that this and my original code all compile fine under latest trunk.
-
-
05:03 AM Feature #13585 (Rejected): select! and reject! do not returns the same array in specific situations
- This can be surprising, but it's in line with many other destructive methods. It can be very useful when writing a loop that continues until there's no change anymore. Avoiding destructive methods leads to a better programming style anyw...
-
- FYI it is intentional for this feature being automatically enabled right now, instead of some configuration like the OP requests.
The reason behind this is that stderr is expected to be passed to other processes (like some logging inf... -
- * compile.c (remove_unreachable_chunk): do not eliminate chunks
followed by labels in catch-table entries.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58810 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:36 AM Revision 68354c35 (git): lib/prime: Fix primality of some large integers [#13492].
- * lib/prime.rb: Use accurate sqrt to insure all factors are tested.
Patch by Marcus Stollsteimer.
* test/test_prime.rb: Adapt test for timeout
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58809 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:27 AM Feature #13581: Syntax sugar for method reference
- Why the version with symbol (`Math->:sqrt`) needs to be supported?
05/19/2017
-
11:39 PM Revision 825a1e93 (git): Merge gemspec from ruby/fileutils.
- * Replaced homepage option to source code location as github.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58808 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:32 PM Feature #13585: select! and reject! do not returns the same array in specific situations
- It's pretty clearly documented:
"If changes were made, it will return `self`, otherwise it returns `nil`." -
09:48 PM Feature #13585 (Rejected): select! and reject! do not returns the same array in specific situations
- When all elements are returned on select!, the method returns nil.
~~~
(main) normal> [1,2,3].select! { |x| x == 0 }
=> []
(main) normal> [1,2,3].select! { |x| x == 1 }
=> [1]
(main) normal> [1,2,3].select! { |x| x == 1 || x == 2... - 09:34 PM Revision c018d464 (git): fix off-by-one in r58806
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58807 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:33 PM Revision b9f8fc51 (git): test/ruby/test_io.rb: new test for IO.select exception set
- Ensure this rarely-used feature of IO.select continues
to work properly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58806 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- watson1978 (Shizuo Fujita) wrote:
> naruse (Yui NARUSE) wrote:
> ...
Though I reported to clang when it breaks build like https://bugs.llvm.org//show_bug.cgi?id=8319
Clang is considered still development at performance like other inli... -
07:53 PM Bug #13584 (Third Party's Issue): Crash in logging (os_log) on MBP
- .rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/httpclient-2.7.1/lib/httpclient/session.rb:597: [BUG] Segmentation fault at 0x00000110ecca3a
-
07:04 PM Bug #13542: MinGW trunk Builds - Summary of Issues
- Built `ruby 2.5.0dev (2017-05-20 trunk 58803) [x64-mingw32]` and removed all encoding related settings, and also any patches affecting that. Test results [here](https://msp-greg.github.io/file.mingw_test-all.html).
* test-all has an ... - 06:53 PM Feature #13552 (Closed): [PATCH 0/2] reimplement ConditionVariable, Queue, SizedQueue using ccan/list
- Applied in changeset trunk|r58805.
----------
thread_sync.c: rewrite the rest using using ccan/list
The performance improvement increases as the number of waiters
increases, due to avoiding the O(n) behavior of rb_ary_delete on
the wai... -
- ko1@atdot.net wrote:
> > https://80x24.org/spew/20170519034419.GA29820@whir/raw
>
> Thank you. Adding `const` helps us to recognize.
>
> ```
> PACKED_STRUCT_UNALIGNED(struct rb_queue {
> struct list_head waitq;
> const... -
06:39 AM Feature #13552: [PATCH 0/2] reimplement ConditionVariable, Queue, SizedQueue using ccan/list
> https://80x24.org/spew/20170519034419.GA29820@whir/raw
Thank you. Adding `const` helps us to recognize.
```
PACKED_STRUCT_UNALIGNED(struct rb_queue {
struct list_head waitq;
const VALUE que;
int num_waiting;
})...-
- ko1@atdot.net wrote:
> Sorry for late response.
No problem.
> Only one comment (maybe you passes all of tests, right?)
Of course :)
> New data type should be RUBY_TYPED_WB_PROTECTED (they need to use write barriers correctl... -
- Sorry for late response.
Only one comment (maybe you passes all of tests, right?)
New data type should be RUBY_TYPED_WB_PROTECTED (they need to use write barriers correctly).
Do you want to try or should I modify?
Thanks,
Koic... - 06:53 PM Revision ea1ce47f (git): thread_sync.c: rewrite the rest using using ccan/list
- The performance improvement increases as the number of waiters
increases, due to avoiding the O(n) behavior of rb_ary_delete on
the waiting thread. Uncontended queues and condition variables
performance is not altered significantly.
Fu... -
- As mentioned in [13542](https://bugs.ruby-lang.org/issues/13542), I have not had a failure with this for a while, even when using -j3, which is when the issue typically occurred.
Please close, as I cannot. -
- 06:34 PM Revision 44e48eca (git): thread_sync.c: rename mutex_waiter struct to sync_waiter
- We will reuse this struct for ConditionVariable, Queue, and SizedQueue,
so it is no longer Mutex-specific.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58804 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- In 2.4, new useful method `Hash#transform_values` was added. I would like to propose also adding matching method `Hash#transform_keys`.
```ruby
{a: 1, b: 2}.transform_keys { |k| k.to_s }
=> {"a"=>1, "b"=>2}
```
What needs to be ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58803 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This is intended. If a method accepts keyword arguments and if its last argument is a hash object, it is considered for keyword arguments. If you want to pass a hash as the first parameter, you need to explicitly pass a hash for keywor...
-
- mame-san: what do you think about it?
-
- Umm, I noticed that actually the length of "ERB.new(*).result(locals: {a: b})" is the same as "ERB.new("aaa").result_with_hash(a: b)". So the long name of 2 seems not a problem compared to 3.
Then, my final personal preference is Sek... -
- I found that my suggestion is a little hard to implement to avoid argument modification. It got a little ugly https://github.com/ruby/ruby/pull/1618/commits/ed1c1e520eec6cb96f1eae88bef2fa4ac54a3e6c.
Anyway, currently we have 3 possibl... -
- Applied in changeset trunk|r58801.
----------
Net::HTTP::STATUS_CODES is added as HTTP Status Code Repository [Misc #12935]
Note that 418 I'm a teapot doesn't exist because RFC 2324 and
RFC 7168 are not registered in IANA repository.
h... - 04:06 PM Revision 83af1c6a (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58802 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Note that 418 I'm a teapot doesn't exist because RFC 2324 and
RFC 7168 are not registered in IANA repository.
https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@5... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58800 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:16 PM Bug #13582 (Closed): IMAPTest#test_append_fail always errors on Windows
- r58792で追加されたテストですが、Windowsでは毎回Errorになります。
assertion自体は通過してるっぽいですが、テストメソッドから抜ける際に
@receiver_thread の中でErrno::ECONNRESETになる[1]か、もしくは、
最後のimap.logoutでErrno::ECONNRESETになるか[2]、どちらかが常に
発生しています。
rubyciを見ると、Debian 7.5 i686やUbuntu armv7l ... -
- Applied in changeset trunk|r58798.
----------
Net::HTTP#start now pass :ENV to p_addr by default [Bug #13351]
To avoid this, pass nil explicitly. - 03:13 PM Revision 61bbe32c (git): * 2017-05-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58799 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- To avoid this, pass nil explicitly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58798 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (dump_disasm_list_with_cursor): improve disassemble
list. show whole elemetns and mark the current element.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58797 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- my current thinking is if that short form should do symbol support.
if `Math->sym` should be supported, than the normal variant need to be `Math->:sqrt`
i currently think if we also could abuse the call method.
so we could harne... -
- The **`->`** was just a suggestion... Could be another symbol or combination of symbols like **`Math->>sqrt`**, **`Math=>>sqrt`**, **`Math+>sqrt`**, **`Math$>sqrt`**, **`Math:>sqrt`**, etc
I just think could have another way to write it... -
- that might collide with `-> {}` a lambda syntax
so i think the chances are low that ruby gets something like that.
so ruby probably does think its "`Math(->sqrt)`" and thats a Syntax error. -
- Some another programming languages (even Java, in version 8) has a cool way to refer a method as a reference.
I wrote some examples here: https://gist.github.com/americodls/20981b2864d166eee8d231904303f24b
I miss this thing in ruby... -
- Applied in changeset trunk|r58796.
----------
Merge latest dtoa.c [Bug #13545]
Apply some part of http://www.netlib.org/fp/dtoa.c with my eyes... -
- Apply some part of http://www.netlib.org/fp/dtoa.c with my eyes...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58796 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thank you for your confirming.
I enforced https on all of lists.ruby-lang.org.
If you faced some issue, Please reopen or submit issue ticket. - 12:44 PM Revision a4d51619 (git): Of course, opened file is not able to unlink on Windows
- * test/test_tempfile.rb (test_create_with_block): close the tempfile before
unlink. fixed a failure on Windows introduced at r58791.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58795 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- as Sorah did there: https://github.com/aws/aws-sdk-ruby/pull/1516
i would suggest that Digest should try to read file objects directly giving to the #file method if able. -
- Digest::SHA256.file()'s first argument is file path name but it accidentally accepts file object.
But for file objects created with O_TMPFILE to_path returns the directory of the temporary file and this File.open will fail.
```
cl... -
- i think returing an unexisting path whould be way problematic if it isnt checked if it exist.
other functions might depend on it.
and trying to open `"/tmp/#165106976 (deleted)"` in (read)/writing mode might result in unexpected resul... -
09:17 AM Feature #13568 (Assigned): File#path for O_TMPFILE fds has no meaning
- We discussed about this today in [DevelopersMeeting20170519Japan](https://bugs.ruby-lang.org/projects/ruby/wiki/DevelopersMeeting20170519Japan). Conclution in this meeting is:
- Return unexist path with informational message, like in... -
10:49 AM Bug #13580: bug
- on second run
~~~
~/projects/ngrx-todolist with_jsonapi_suite clear; rspec spec/api/comments/create_spec.rb
1) comment#create valid
Failure/Error: let!(:task) { create :task, task: task }
SystemStackErro... -
- https://pastebin.com/raw/NJ6QCggq
repository state when bug occurred https://github.com/BjornMelgaard/ngrx-todolist/tree/ecc321e149f45ddb512334a3af845941f922ff5e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58794 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:35 AM Bug #13492: Integer#prime? and Prime.each might produce false positives
- The patch seems good.
-
- Further reduced via IRC:
~~~ ruby
def process_defn
if false
case 42
when s {} then
when 42 then
return
end
end
return
end
~~~ -
- This seems to be related to #12613
~~~ ruby
#!/usr/bin/env ruby -w
def process_defn
if true then
# nothing needed here
else
if true then
case 42
when 42 then
return 42 # BOOM
when s { ... -
09:29 AM Bug #13315: Single "%" at the end of `printf` format string appears in the result
- When I wrote the original code, it was intentional, but without any specific reason.
It's OK for me to raise an error for this case.
Matz.
-
- 09:25 AM Revision 940f32eb (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58793 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:25 AM Revision 84c15963 (git): net/imap: Net::IMAP#append should not block when NO response is received
- [ruby-dev:50129] [Bug#13579]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58792 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Net::IMAP#append blocks when a NO response is received.
For example, if the destination mailbox doesn't exist, Net::IMAP#append blocks:
```ruby
require "net/imap"
imap = Net::IMAP.new("localhost")
imap.login("username", "passwor... -
- * lib/tempfile.rb (Tempfile.create): should not fail even if the
temporary file has been removed in the block, just ignore.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58791 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Looks good to me.
Matz.
-
- Sounds good.
Matz.
-
- +1 for Dir.children
-
- There is `Pathname#children` and `Pathname#each_child`.
How about `Dir.children` and `Dir.each_child` ? -
- I think it would make generator happy.
-
- It should be done by gem.
This will depends Unicode CLDR, and it's beyond Ruby itself's scope. -
- [Feature #13568] sheds light on situations where a File might not have its corresponding path. I understand that this is a nature of a file in general, that it might or might not have such thing. I don't argue that fact.
Problem is ... -
- I reject the proposal.
It may be useful for some application, I admit, but it is not the language matter.
Matz. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58790 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- How about that matching indentation of `=begin` and `=end`?
```ruby
=begin
in a comment
=end
still in a comment
=end
# end of the comment
``` -
- vp (Vladimir Pavlov) wrote:
> Particularly, you assign the result of setjmp() call to a variable.
It is not assigned since r43522.
Maybe newer `__builtin_setjmp` has changed the format of saved registers.
-
- Today, it increases IO#close performance with many threads:
Execution time (sec)
name trunk after
vm_thread_close 4.276 3.018
Speedup ratio: compare with the result of `trunk' (greater is better)
name ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58789 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * method.h (rb_method_definition_t#type): specify unsigned explicitly.
Some compilers (includes VC) returns negative value.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58788 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- keysen (Jérémy Carlier) wrote:
> When connecting using TLS to an unresponsive SMTP server, Net::SMTP can hang until 10 minutes.
In Ruby 2.4, open_timeout affects TLS handshake.
I'm not sure whether it should be backported to 2.3.
... -
- I will insert warning.
I will not change the current behavior.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58787 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Matz approved it.
-
-
- I think there is no problem with time.rb.
I don't want to change the day format in time.rb
because the current behavior is valid according to RFC 2822 and
needless behavior change can cause incompatibility.
Also, time.rb's -0000 ... -
- @stomar
It should return nil same as other comparison methods. Can you handle this? -
- Applied in changeset ruby-trunk:trunk|r58786.
----------
eval_error.c: enrich backtrace
* eval_error.c (print_backtrace): add frame number when printing
in reverse order. [Feature #8661] -
-
- Applied in changeset ruby-trunk:trunk|r58785.
----------
Add NEWS about [Feature #8661] -
- We expect some people may object this.
Therefore we're gathering feedback now (so thank you for your feedback).
To gather feedback wider, we'll give final decision after preview 1, including rspec and Rails will follow this change or... -
- * eval_error.c (print_backtrace): add frame number when printing
in reverse order. [Feature #8661]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58786 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Could you tell us more details? Your sample code and acquired errors (or output).
-
- Fundamentally, we can't control machine stack overflow.
We will improve the situation (but can't solve completely).
-
- This is specification.
(1) parse `example` method and define `foo`.
(2) In `eval` method, compile given string (`"foo"`) and defined `foo` was used (without any problem).
So it is documentation issue.
Can anyone write about it?
-
- Thank you. I'll commit it.
-
- ```
def foo
puts caller(0) # (1)
end
def bar
p 0
begin # (3)
p 1
raise
p 2
rescue
foo # (2)
end
end
bar # (4)
#=>
0
1
(1) t.rb:2:in `foo'
(2) t.rb:12:in `rescue in bar'
(3) t.rb:7:in `b... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58785 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Agreed with better message description.
Matz.
- 06:00 AM Feature #13494 (Closed): [PATCH] pack rb_method_definition_t struct
- Applied in changeset trunk|r58784.
----------
method.h: pack rb_method_definition_t struct
We only have 12 method types, so 4 bits is enough for
rb_method_type_t.
Size reductions:
- x86-64 48 => 40 bytes
- x86 28 => 24 byt... -
- Sorry for late response.
No problem.
Thanks,
Koichi - 06:00 AM Revision f82a9304 (git): method.h: pack rb_method_definition_t struct
- We only have 12 method types, so 4 bits is enough for
rb_method_type_t.
Size reductions:
- x86-64 48 => 40 bytes
- x86 28 => 24 bytes
* method.h (enum method_optimized_type): split out for CPP
(struct rb_method_definition... -
- I reject this ticket with the reason #5.
-
- Sorry for late response.
Unfortunately I have no enough disk to run docker. Try later when I get new machine.
-
-
- I close this ticket because we need long-time effort.
> Also, can we introducing it in 2.5?
> ...
If we can.
-
- Sorry for late response.
Basically, TracePoint should be implementation independent.
(so that `:c_call, :c_return` are not good events)
The list of "basic operation" is highly implementation dependent information.
-
- Sorry for late response.
> we may want to drop OpenBSD <5.2 support
On https://bugs.ruby-lang.org/projects/ruby-trunk/wiki/SupportedPlatforms
You can decide it. I don't have any idea we should or we shouldn't. Could you decide ... -
- Backport r57248.
-
- I think Ruby 2.4.x on Mac 10.5.x is not a supported combination. The proposed patch _seems_ fine though. I no longer own a PPC Mac so cannot test it.
-
- graywolf (Gray Wolf) wrote:
> You said
> ...
Thank you, please file a separate issue that requests this method. -
12:25 AM Feature #13574: Method redefinition warning
- As there's no other way to silence the redefinition warning (apart from removing the method first, which isn't atomic), the fact aliases silence it is very useful.
As a special case, aliasing it back to itself is particularly helpful ... -
12:07 AM Feature #13574 (Open): Method redefinition warning
- Hi,
If I redefine a method like this, I get a warning:
~~~ruby
class Foo
def bar
end
end
class Foo
def bar
end
end
~~~
If I alias the method to a different name, I don't get a warning:
~~~ruby
class Foo
...
05/18/2017
-
- I think emulating the behaviour of
```ruby
[2] pry(main)> Hash[{ a: 1, b: 2 }.map { |key, value| [:s, value] }]
=> {:s=>2}
```
is reasonable. It's also the same thing `Hash#transform_keys` from rails does (afaict).
You said
... -
- This issue has no move so far. I think you need to start discussing about transform_keys if you want that. It has one problem though; what happens when the transformed keys conflict is not intuitive. Is that an exception? Or the latte...
-
07:25 PM Bug #13573 (Closed): Compilation on Mac OS X 10.5.8 fails because of missing _fgetattrlist
- When compiling Ruby 2.3.x and 2.4.x on Mac OS X 10.5.8, compilation fails with:
~~~
linking miniruby
Undefined symbols for architecture ppc:
"_fgetattrlist", referenced from:
_glob_helper in dir.o
ld: symbol(s) not found ... -
- normalperson@yhbt.net wrote:
> thread_sync.c: rename mutex_waiter struct to sync_waiter
> thread_sync.c: rewrite the rest using using ccan/list
Any comment? Rebased patches against current trunk (r58783) available here... -
- > Whitespace isn't the issue here
That's wrong. Definitely whitespace matters. If you change to use a following template, you'll get an expected result and ERB and Erubis will work in the same way.
~~~ erb
<% return_block { %><... -
- which I introduced at r58773.
Hard tabs and spaces are mixed...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58783 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:06 PM Revision 0ea0f07f (git): * 2017-05-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58782 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * common.mk (parse.c): replace source file name in #line pragmas
with the path in the source directory, so that binary utilities,
e.g. gcov, can find it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58781 b2dd03c8-39d4-4d8f-98f... -
- There's a problem that a receiver is unclear and not configurable if argument is only a Hash object. To address the problem, we need to have both anything for a receiver (of course Binding is okay) and a Hash object in arguments.
Even... -
01:55 PM Bug #13040: syslog/logger uses "require 'logger'" which is interpreted as circular dependency
- Am I the only person having this problem? This is in different code sources we are maintaining. Here is the latest. In a new project I setup test with minitest/spec
1. added pp $LOAD_PATH to my test_helper.rb
2. rake test
$> rake ... -
- Yet another proposal: https://twitter.com/yancya/status/865070681213386756
```ruby
just do it.! end
``` -
- * dir.c (rb_dir_getwd): get rid of potential memory leak.
* util.c (ruby_getcwd): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58780 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- marked
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58779 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:42 AM Revision 83b7e0bd (git): * 2017-05-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58778 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Patch by @joshpencheon (Josh Pencheon)
[fix GH-1607]
#### benchmark-ips results
```
trunk:
Warming up --------------------------------------
4.000 i/100ms
Calculating -------------------------------...
05/17/2017
-
- What's the status on this? In #12512, only Hash#transform_values was added, should I bother making patch adding Hash#transform_keys (and maybe Hash#transform_pairs)? Or is this (#9970) still in the process based on last comment from matz...
-
09:46 PM Bug #13572 (Closed): Please backport r53400 to 2.3
- r53400 fixes a bug in which `includedir`, instead of `oldincludedir`, is inappropriately prefixed with `SDKROOT`. This bug was introduced in 2.3.0preview1, and fixed in 2.4.0preview1. If there will be a 2.3.5, please backport this to the...
-
- The following is windows/MinGW specific.
I have been patching around a failure in [TestRubyOptions#test_command_line_progname_nonascii](https://github.com/ruby/ruby/blob/trunk/test/ruby/test_rubyoptions.rb#L742-L758) for a while, and ... -
- * spec/rubyspec/command_line/dash_upper_s_spec.rb: enable tests on vboxsf
(VirtualBox shared directory) and change tests to match /success$/ to
ignore warnings. This technique is suggested by @unak.
git-svn-id: svn+ssh://ci.ruby-la... -
02:14 PM Feature #12996: Optimize Range#===
- I updated the patch (range_eqq2.patch).
It optimize only special cases.
---
# Range with Fixnum
~~~
i = 0
while i < 10_000_000
case i
when 1..1000
end
i += 1
end
~~~
## Before
~~~
$ time ./miniruby t.rb... -
- for future backport to ruby/spec repository.
See r58772 r58773 r58774.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58775 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58774 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- to make it compatible with ERB::Util.url_encode.
ext/cgi/escape/escape.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58773 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r58772.
----------
erb.rb: Don't encode tilde in #url_encode
Based on patch by madeofcode (Mark Dodwell).
[ruby-core:46168] [Bug #6696] [Fix GH-54]
`~` is a unreserved character.
https://tools.ietf.org/html/... -
- It's now close to 19 years since RFC 2396, so please fix this issue, thanks!
-
- Based on patch by madeofcode (Mark Dodwell).
[ruby-core:46168] [Bug #6696] [Fix GH-54]
`~` is a unreserved character.
https://tools.ietf.org/html/rfc3986#section-2.3
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58772 b2dd03c8-39d4... -
10:45 AM Feature #13396: Net::HTTP has no write timeout
- > I would also like to add native timeout support to IO.copy_stream
That would be the best indeed. -
- * spec/rubyspec/command_line/dash_upper_s_spec.rb:
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58771 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r58770.
----------
Optimize CSV#shift.
[Bug #12373][ruby-core:75462]
Patch by Yuki Kurihara.
Benchmark:
```
Warming up --------------------------------------
csv_shift 1.000 i/100ms... -
- @hsbt
Good, Thank you for confirming and managing. -
- Ah,
>Should we use @double_quote_char instead of @quote_char ?
`@quote_char` is wrong. I intended to write `@quote_char * 2`
And, I confirmed csv-shift-3.patch again. It has no problem for me.
Thank you for your explanation.... -
- @hsbt
Thank you for responding.
csv-shift-hsbt.patch looks good to me.
> Should we use @double_quote_char instead of @quote_char ?
> ...
@double_quote_char and @quote_char are different values. It can not be used instead.
@doubl... -
- [Bug #12373][ruby-core:75462]
Patch by Yuki Kurihara.
Benchmark:
```
Warming up --------------------------------------
csv_shift 1.000 i/100ms
new_csv_shift 1.000 i/100ms
Calculating -----------------... -
- Applied in changeset trunk|r58769.
----------
Treat NULL reference case [Bug #13566] -
- It can be reproducible on Ruby 2.2.7, too.
```
$ RBENV_VERSION=2.2.7 ruby -rfiddle -e 'Fiddle::Function.new(Fiddle::NULL, [], Fiddle::TYPE_VOID).call'
-e:1: [BUG] Segmentation fault at 0x00000000000000
ruby 2.2.7p470 (2017-03-28 re... -
- I confirmed that it is reproducible on Ruby 2.3.3.
```
$ RBENV_VERSION=2.3.3 ruby -r fiddle -e 'Fiddle::Function.new(Fiddle::NULL, [], Fiddle::TYPE_VOID).call'
-e:1: [BUG] Segmentation fault at 0x00000000000000
ruby 2.3.3p222 (2016... -
- A small code to reproduce this issue is here:
```ruby
require 'fiddle'
Fiddle::Function.new(Fiddle::NULL, [], Fiddle::TYPE_VOID).call
``` -
12:27 AM Bug #13566: A process freezes at the beginning of C level backtrace when a certain SEGV is occurred
- mrkn (Kenta Murata) wrote:
> r15: 0x00007fff577eb7d0 rip: 0x0000000000000000 rfl: 0x0000000000010246
rb_dump_machine_register() shows "rip: 0x0000000000000000".
And lldb on my environment shows that `uctx->uc_mcontext->__ss.__rip[-... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58769 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- https://github.com/k-takata/Onigmo/commit/1364ae3488cac0acbf2d61ef3ce2b62fe0c0f528
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58768 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ruby.c (process_options): encode script name to locale encoding
instead of associate, if UTF-8 path.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58767 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * .gdbinit (nd_tree): use rb_str_tmp_new to get rid of
`__extension__'.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58766 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Name proposal - cede
```ruby
url.cede { |u| open(u).read } # return "itself -> fetch from the network"
``` -
- Well, I know everyone don't like the name yield_self but, it seems that's a separate issue than this one. Can we focus? I guess we need another 5 years to find an "ideal" name of it and that's too off topic to what is requested here.
-
- * test/ruby/test_dir_m17n.rb (test_entries_compose): read in
filesystem encoding instead of default external encoding on
Windows too. these two encodings may differ on some
environments.
git-svn-id: svn+ssh://ci.ruby-lang.org/rub...
05/16/2017
- 11:59 PM Revision 8dbf0f2a (git): Revert "test/test_extilibs.rb: do not check the existence of fiddle"
- This reverts r58761 since fiddle is considered critical.
[ruby-core:81201] [ruby-core:81203]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58764 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:15 PM Revision 6e7dfec8 (git): ENV["HOME"] is prior as home on Windows
- * spec/rubyspec/core/dir/home_spec.rb: ENV["HOME"] is prior as home on Windows.
reported by ko1.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58763 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * defs/gmake.mk (TEST_DEPENDS): check and more tests targets need
all to be built.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58762 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:05 PM Revision c836e8dd (git): test/test_extilibs.rb: do not check the existence of fiddle
- libffi is not installed on all systems, and is not needed
for most of the tests.
Tested on a fresh FreeBSD 11.0 VM
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58761 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > Does mkmf works well on Windows?
I'm not a c type. With MinGW builds, I've got 89 mkmf.log files in the build dir, and [test-all results](https://msp-greg.github.io/file.mingw_test-all.html) are consistent and reasonable low. I'm ... -
12:47 PM Feature #13570 (Closed): Using mkmf for ruby/spec C API specs
- Hello all,
I am thinking to use mkmf to compile the C API specs.
https://github.com/ruby/ruby/blob/trunk/spec/rubyspec/optional/capi/spec_helper.rb
is getting pretty complex and hard to maintain.
I have a few questions:
* Does... - 04:16 PM Revision b1d57ac6 (git): Should require at spec file, not fixture file
- Fixed ERRORs at non-Windows platforms.
* spec/rubyspec/library/win32ole/fixtures/classes.rb (require): removed.
* spec/rubyspec/library/win32ole/win32ole/ole_get_methods_spec.rb (require):
forgotten to require 'win32ole'.
git-svn-i... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58759 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:45 PM Revision 10f713e4 (git): Should require WIN32OLE
- * spec/rubyspec/library/win32ole/fixtures/classes.rb: should require WIN32OLE
here because this file causes NameError in parallel spec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58758 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:17 PM Revision ec5e5c09 (git): * 2017-05-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58757 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/lib/test/unit.rb (_run_parallel): flush job tokens after
quitting workers when normally finished too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58756 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_process.rb (test_execopts_open_chdir_m17n_path):
compare directory name in UTF-8. encoding of `Dir.pwd` is
affected by filesystem encoding.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58755 b2dd03c8-39d4-4d8f... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58754 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58753 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58752 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:50 PM Revision 8dd82a3e (git): * common.mk (help): get rid of make error with nmake.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58751 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58750 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58749 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58748 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Avoids a race between finding an available port and another process starting a server on it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58747 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:15 PM Revision 35da88e6 (git): Rename rubyspec to spec
- * common.mk (*-rubyspec): rename to *-spec because rubyspec is historical name.
of course, *-rubyspec are still available for compatibility.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58746 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- sorah (Sorah Fukumori) wrote:
> it would be happier if we can get all of source locations where a class opened?
I hope `Module#source_locations`, too. Like below:
```ruby
# Just a PoC
class Module
attr_reader :source_location... -
- * dir.c (rb_dir_getwd): convert from UTF-8.
* win32/win32.c (w32_getcwd): codepage aware getcwd using
GetCurrentDirectoryW.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58745 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Patch by @cllns. [Fix GH-957]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58744 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r58743.
----------
Added accessor of original line when parsing.
[Feature #11865][ruby-core:72452][fix GH-1170] -
- [Feature #11865][ruby-core:72452][fix GH-1170]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58743 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- @ksss
I confirmed your patch and benchmark results.
```
Warming up --------------------------------------
csv_shift 1.000 i/100ms
new_csv_shift 1.000 i/100ms
Calculating -----------------------------... - 08:03 AM Revision 59faac61 (git): Search SSL libraries by testing various filename patterns
- * ext/openssl/extconf.rb (find_openssl_library): should search by more flexible
method, especially for LibreSSL on Windows.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58742 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I've confirmed that this issue isn't reproduced on x86_64-linux.
-
- Hanmac (Hans Mackowiak) wrote:
> shyouhei (Shyouhei Urabe) wrote:
> ...
Thank you. Issue updated to refer the changeset.
-
- shyouhei (Shyouhei Urabe) wrote:
> The patch seems okay to me, but honestly I don't see any practical use case of it. Do you nedd this?
the pr was already merged, but this ticket was not closed because of that -
- The patch seems okay to me, but honestly I don't see any practical use case of it. Do you nedd this?
-
- * lib/rubygems/ext/ext_conf_builder.rb (build): needs to close
before unlink on Windows.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58741 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58740 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I guess it was fixed at r41853 before v2_1_0_preview1 and backported to ruby2_0_0 at r41946 [Backport #8633].
-
- It seems that original issue is resolved https://github.com/gurgeous/teleport/issues/22.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58739 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:59 AM Feature #13563: Implement Hash#choice method.
- At first, I overlook Hash#slice method. Sorry...
And, I reconsider about it.
I feel that Hash#slice is wrong name and Hash#pick is better name.
If key is not exist, key omit or return nil.
It is difficult problem.
I think ea... -
- On 2017/05/15 20:31, eregontp@gmail.com wrote:
> I think using Exception#cause for this would be a better way to address this problem.
> However, there is a long-standing bug of the cause not being shown in Exception#inspect and neith... -
- Supporting this kind of behavior doesn't make sense to me. Suppose following erb template:
~~~ erb
foo <% # comment1 %> bar <% # comment2 %> baz
~~~
If such a feature is supported, I would expect this template to render "foo bar... -
- Applied in changeset trunk|r58737.
----------
enable ruby_w32_codepage on cygwin
* debug.c, localeinit.c: enable ruby_w32_codepage on cygwin too.
[ruby-core:81163] [Bug #13567] - 12:15 AM Revision 1fc689d9 (git): * 2017-05-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58738 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * debug.c, localeinit.c: enable ruby_w32_codepage on cygwin too.
[ruby-core:81163] [Bug #13567]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58737 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
05/15/2017
-
- Agreed, but my PR sent to aws-sdk-ruby includes different fix to remove incorrect usage of `File#path`, so it's necessary.
-
- yeah your fix for aws does looks good, but i think that should be done in `Digest` directly if able. (for another ticket)
-
- fix proposed for aws-sdk-ruby gem https://github.com/aws/aws-sdk-ruby/pull/1516 but I still think returning `nil` from `File#path` when path is surely known of its unavailability is happier than current behavior.
-
- yeah your points should be done in extra issues i think.
for `Digest` i think it should first check if its an (direct) instant of `IO`, or has a `to_io` method.
if yes then it should read the file directly instead of trying to open w... -
- Few additional things pointed out by some conversations:
- We miss a way to retrieve a directory path used to create tmpfile
- Although file system can be identified by `File#stat`
- `Digest::*.file` don't expect a `File` object, ... -
- Hanmac (Hans Mackowiak) wrote:
> now i am pro this change.
> ...
I think we don't have one yet. But I'm not positive to give side effect on `File#path`.
> hm about `Tempfile`, does it already use `O_TMPFILE` internal, or can it mayb... -
- Reopening due to closed via r58734, a document change.
-
- Applied in changeset trunk|r58734.
----------
[DOC] `File#path` result can be inaccurate
* file.c(rb_file_path): [DOC] Note that the pathname returned by this
method can be inaccurate, for instance file gets moved, renamed,
... -
- i see your change and did read the man page of `O_TMPFILE`
to check if there is any useful path this could return. (there isn't)
now i am pro this change.
does ruby has a way to use `linkat` like to seen there?
http://man7.org/linu... -
- Hanmac (Hans Mackowiak) wrote:
> not pro or against it but what do you think of that part?
I don't have strong opinion on the style for lines you pointed out... -
- Let me explain about the background bit detail.
The example I put in the previous post https://github.com/aws/aws-sdk-ruby/blob/v2.9.17/aws-sdk-core/lib/aws-sdk-core/checksums.rb#L15 is from aws-sdk-ruby gem. The core part of this exa... -
- not pro or against it but what do you think of that part?
~~~ C
#ifdef O_TMPFILE
if (!(oflags & O_TMPFILE))
#endif
{
fptr->pathv = pathv;
}
~~~
you might leaveout the {} but i think its more readable that... -
- By using File::TMPFILE (O_TMPFILE) allows us to create a file without directory entries.
While open(2) with O_TMPFILE don't create a file without directory entries, it still requires a directory name to determine a file system to crea... -
03:55 PM Feature #13516: Improve the text of the circular require warning
- Thanks for the response, Robert. It would be great if the error message provided that level of detail. However, that may be difficult to implement. So, maybe we should focus on simply improving the text of the existing warning. My goal i...
-
- [TestRubyOptions#test_search](https://github.com/ruby/ruby/blob/trunk/test/ruby/test_rubyoptions.rb#L299) replaces `ENV['PATH']`, which causes a failure under Windows. PR appends, rather than replacing.
See [GitHub PR 1616](https://g... -
- I'm now running both of the following with my daily builds:
```
make -ij1 "MSPECOPT=-Vfs command_line language library core optional/capi" test-rubyspec
```
and
```
..\mspec\bin\mspec -Vfs :command_line :language :library :core
... -
- * lib/rubygems/test_case.rb (teardown): call `Gem::refresh()` at the
end of `teardown`.
On parallel test sometimes fails test process. The reason
is:
(1) previous tests remains `Gem::Specification@@stubs` value
which points... -
-
- After discovering that Meta/Alt key combinations can also be done via an [ESC] then [key] press, I've verified that all Meta/Alt combinations work with the readline package when done via [ESC]. So, it may be that readline.c is not recog...
-
- to optimize String concatenation on rendering.
[fix GH-1612]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58735 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * file.c(rb_file_path): [DOC] Note that the pathname returned by this
method can be inaccurate, for instance file gets moved, renamed,
deleted or is created with File::TMPFILE option.
Relates to [Feature #13568]
git-svn-id: svn+s... -
- * spec/rubyspec/optional/capi/spec_helper.rb (compile_extension):
use LIBRUBYARG_SHARED for LDSHARED.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58733 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I think using Exception#cause for this would be a better way to address this problem.
However, there is a long-standing bug of the cause not being shown in Exception#inspect and neither by the top-level handler: https://bugs.ruby-lang.o... -
- We can modify `Exception#message` if given String is not frozen.
Should we continue this specification?
Now, we can modify exception message with message string modification.
```
begin
raise 'foo'
ensure
$!.message.replace... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58732 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58731 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * configure.in: mingw also uses MSVCRT accepts negative time_t.
c.f. r58681.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58730 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58729 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * spec/rubyspec/optional/capi/spec_helper.rb (compile_extension):
LIBRUBYARG is always necessary unless dynamic lookup is allowed.
strip $(DEFFILE) from DLDFLAGS on mingw.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58728 b2dd... -
- I get the following when compiling localeinit.c on cygwin. Please fix, thanks!
```
compiling localeinit.c
localeinit.c: In function ‘locale_charmap’:
localeinit.c:50:18: error: ‘ruby_w32_codepage’ undeclared (first use in this func... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58727 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- You ran old system version with newer extension library.
```
ruby 2.0.0p648 (2015-12-16 revision 53162) [universal.x86_64-darwin16]
``` -
07:42 AM Bug #13565 (Rejected): Segmentation fault with rails (4.1.0) and ruby (2.2.7)
- ```
➜ rsportz git:(install-sidekiq) ✗ rails -v
ruExpected string default value for '--rc'; got false (boolean)
Rails 4.1.0
➜ rsportz git:(install-sidekiq) ✗ ruby -v
ruby 2.2.7p470 (2017-03-28 revision 58194) [x86_64-darwin16]
... -
- Note that I use CPython 3.6 that is built with `--with-shared` configure option.
-
- I found the issue that a process freezes at the beginning of C level backtrace printing when a certain SEGV is occurred.
I've made a reproducible code in the freeze_on_segv branch of pycall project.
You can check it by the following ... - 07:35 AM Revision a852853f (git): Should call `ln_s` only when symlink is available
- * test/fileutils/test_fileutils.rb (test_ln_s): skip if symlink is not
available.
* test/fileutils/test_fileutils.rb (test_ln_s): remove created symlink
certainly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58726 b2dd03c8-3... - 07:33 AM Revision fba0b81e (git): test/socket/test_basicsocket.rb (socks): bind explicitly to localhost
- Binding to a potentially public IP in a test can cause problems
if hit by a random port scanner or something...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58725 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58724 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58723 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:17 AM Revision 51c2feee (git): * 2017-05-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58722 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58721 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- note: https://github.com/tenderlove/racc/issues/85
-
05/14/2017
-
- FWIW, ActiveSupport calls this `Hash#slice` -- http://api.rubyonrails.org/classes/Hash.html#method-i-slice
(With one small behavioural difference: keys not present in the source hash are also omitted from the result, so the second exa... -
- I am neutral about the suggestion, neither pro or con.
I think the only thing that I want to point out is that .choice() is perhaps not
completely clear. Perhaps .pick() would be better?
We have quite some methods already that all... -
- Hi,
I propose Hash#choice method.
It pick up key and value pairs in Hash like a below code.
~~~
{ :a => 1, 2 => "2", "c" => true }.choice(:a, 2) # => { :a => 1, 2 => "2" }
{ :a => 1, 2 => "2", "c" => true }.choice("c", 10000) ... -
- What would perhaps be nice would be to have a way to initialize these to nil, upon
attr_* definition, but I guess that would require another name - it would probably
be bad in general to change the attr_* default behaviour at this poin... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58720 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:09 PM Revision f91ed43d (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58719 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58718 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:09 PM Revision d593aed7 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58717 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58716 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * thread_sync.c (rb_mutex_num_waiting): suppress warning C4700 by
VC, uninitialized local variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58715 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:51 AM Feature #10674: Net::HTTP retries idempotent requests once after a timeout, but its not configurable
- Can confirm on 2.4.1.
The responsible code is here: https://github.com/ruby/ruby/blob/v2_4_1/lib/net/http.rb#L1468
I'm thinking of making a simple patch adding a boolean "#retry=". Application or higher-level gems can then implement a... -
- * object.c (rb_obj_size): The #yield_self Enumerator instance
always has a #count of `1`. This provides a lazy #size of `1`
to match the count instead of `nil`. [Fix GH-1615]
Author: Shannon Skipper <shannonskipper@gmail.com>
... -
- To avoid reading `core` file on reading core/ specs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58713 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- jphelps (Jeremy Phelps) wrote:
> Eregon, I have no idea what you're talking about. All the examples of Fiber usage over on ruby-doc.org shows identical behavior to Python's yield statement. The only difference is that in Python, "resume... -
- On 2017/05/14 4:40, jeremy.phelps@instacart.com wrote:
> Eregon, I have no idea what you're talking about. All the examples of Fiber usage over on ruby-doc.org shows identical behavior to Python's yield statement. The only difference i... -
06:55 AM Feature #13562: Use a sized enumerator with #yield_self
- I'm not at all sure about my implementation, but here is a pull request with my attempt: https://github.com/ruby/ruby/pull/1615
-
- The #yield_self Enumerator instance always has a #count of `1`. I think it might be nice to provide a lazy #size of `1` to match the #count for parity.
Currently:
~~~ ruby
42.yield_self.count #=> 1
42.yield_self.size #=> nil
~~~... -
- * spec/rubyspec/optional/capi/ext/fixnum_spec.c: suppress
unused-but-set-variable warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58712 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * template/exts.mk.tmpl: get rid of making multiple rubies
simultaneously. it can cause making libruby in parallel.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58711 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.in: get rid of unreliable tgamma() implemented of
mingw, which returns NaN unexpectedly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58710 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (rb_external_str_new_with_enc): cut down intermediate
string for conversion source, by appending with conversion.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58709 b2dd03c8-39d4-4d8f-98ff-823fe69b080e