Activity
From 03/14/2017 to 03/20/2017
03/20/2017
-
08:30 PM Bug #10944 (Closed): Documentation of Array.new w.r.t. element index available to a block
- Applied in changeset r58037.
----------
docs for creating arrays
* array.c: [DOC] add example for Array.new with block and index.
Reported by Don Cruickshank. [ruby-core:68442] [Bug #10944] -
- Although it's already documented in Array.new, an additional example in the class documentation cannot hurt; so I'll add one.
- 08:30 PM Revision d6a197ca (git): * 2017-03-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58038 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * array.c: [DOC] add example for Array.new with block and index.
Reported by Don Cruickshank. [ruby-core:68442] [Bug #10944]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58037 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:28 PM Bug #13339 (Closed): Assertion Failed: string.c:2061:rb_str_change_terminator_length:capa >= len
- This makes ruby 2.4.0 crash on my system (log attached):
```ruby
('a' * 23).encode('utf-16').encode!('utf-8')
```
If you change the length of the string (from 23 to 22 or 24), everything's fine. -
07:42 PM Bug #13338 (Closed): MinGW SEGV in test/ruby/test_keyword.rb svn 58034, ok in svn 58021.
- In a MinGW / MSYS2 64 bit build, the following line generates a SEGV in svn 58034 [test/ruby/test_keyword.rb:L373](https://github.com/ruby/ruby/blob/57d6dd5a461202f9824c3d1b8d3e5304aca2d21c/test/ruby/test_keyword.rb#L373). With 373 comm...
-
07:30 PM Bug #13321: String#codepoints for one-byte encodings
- Thanks!
-
06:36 PM Bug #13337 (Closed): Eval and Later Defined Local Variables
- I've noticed the following behavior with eval:
~~~ ruby
def example
eval("foo") # => nil, but would expect a NameError
eval("bar") # => NameError
foo = 1
end
~~~
I'm assuming this behavior is expected, since "eval" exec... -
05:34 PM Bug #13336 (Closed): Default Parameters don't work
- ```ruby
def funny(a = true, b: nil)
p a
end
funny([1,2,3]) # => [1,2,3]
funny({k:1}) # => in `funny': unknown keyword: k (ArgumentError)
``` -
12:26 PM Bug #12405: Queue doesn't work inside of trap
- ruby_2_3 r58036 merged revision(s) 57477,57478,57479.
-
- use TRUE/FALSE.
define rb_thread_sleep_deadly_allow_spurious_wakeup().
* thread.c, thread_sync.c: define new function
rb_thread_sleep_deadly_allow_spurious_wakeup() and use it instead of
using sleep_... -
11:45 AM Bug #13326: Forwarding methods to :method_missing produces a warning
- Ah, hadn't known about `respond_to_missing?`, thanks for the advise.
-
07:07 AM Feature #13335 (Closed): Gemify mathn
- Applied in changeset r58035.
----------
Added initial gemspec for mathn.
[Feature #13335] -
- mathn is deprecated [Feature #10169] from 2 years ago.
We should extract from stdlib at Ruby 2.5.0. -
- [Feature #13335]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58035 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
-
- `mathn/complex` and `mathn/rational` is deprecated from 2008. We should remove it before Ruby 3.0 release.
https://github.com/ruby/ruby/pull/1542/files
-
04:53 AM Feature #13333 (Open): block to yield
- Currently, blocks can take a block by `do |&block| end` construct.
But the only way to pass a block or a bloc argument is making a `Proc` and calling `Proc#call` with a blockarg.
I think `yield` should take a block or a block argument ... -
- merged https://github.com/mruby/mruby/commit/ff03a9a61c62340cff62f8e0fdc1a1e8775b6f17
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58034 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * sprintf.c (ruby__sfvwrite): use long instead of size_t due to
string limits.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58033 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/19/2017
-
- When you define `method_missing` method, you should define `respond_to_missing?` method too.
-
- It would need a special care, I think.
-
- I wonder how common such case is.
And you can override delegator/accessor methods by yourself. -
10:52 PM Feature #13332 (Feedback): Forwardable#def_instance_delegator nil
- I'd like to suggest an extension to the signature of stdlib Forwardable#def_instance_delegator
currently (ruby 2.3.3) it is declared as:
```ruby
def_instance_delegator(accessor, method, ali = method)
```
I'd like to add a ni... -
- ruby_2_3 r58032 merged revision(s) 57517.
-
- doc: Fix error for escape sequences in string literals
Backslash goes first in escape sequences, so it must be
"any other character following a backslash is interpreted as ...",
while the doc says "...followed by... -
- ruby_2_3 r58031 merged revision(s) 57522.
-
- doc: restore class documentation for Struct
* struct.c: restore class documentation for Struct
that disappeared with r46663.
Due to r46663, the class documentation for Struct disappeared.
(The revision... -
- ruby_2_3 r58030 merged revision(s) 57434.
-
- Enumerable#{min,min_by,max,max_by} [ci skip]
* enum.c: [DOC] Enumerable#{min,min_by,max,max_by} return a sorted
array when +n+ argument is used.
* enum.c: Small typo : minimum -> maximum
[Bug #13161]
... -
- ruby_2_3 r58029 merged revision(s) 54785.
-
- * ruby.c (process_options): convert -e script to the encoding
given by a command line option on Windows. assume it is the
expected encoding. [ruby-dev:49461] [Bug #11900]
git-svn-id: svn+ssh://ci.ruby-lang.org/rub... -
- I very much think the _output_ record separator was meant, and I suggest the following:
``` diff
diff --git a/io.c b/io.c
index cd615fb..fabd5d5 100644
--- a/io.c
+++ b/io.c
@@ -7185,15 +7185,17 @@ io_puts_ary(VALUE ary, VALUE ou... -
- ruby_2_3 r58028 merged revision(s) 57539.
-
- rational.c: fix rdoc [ci skip]
* rational.c (rb_rational_plus): [DOC] fix an example.
A patch by Trygve Flathen <at.ruby-lang AT flathen.net> in
[ruby-core:71755]. [Bug #11752]
git-svn-id: svn+ssh://ci.ruby... -
- ruby_2_3 r58027 merged revision(s) 57595.
-
- check thread deadness correctly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@58027 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_3 r58026 merged revision(s) 56125,56150.
-
- * thread.c (rb_threadptr_raise): set cause from the called thread,
but not from the thread to be interrupted.
[ruby-core:77222] [Bug #12741]
* test/ruby/test_exception.rb: fix thread issues.
* use Q... -
- ruby_2_3 r58025 merged revision(s) 57767,57944.
-
- io.c: documentation for puts
* io.c: [DOC] clarify that the 'record separator' between
arguments passed to 'puts' is always a newline.
Based on a patch by Mark Amery. [ruby-core:65801] [Misc #10403]
i... -
06:55 PM Bug #13331 (Closed): Inconsistent conversion of Float into Decimal
- One would reasonably expect the equality 1.to_d * f == f.t_d to hold for every Float value f, i.e. multiplying by DigDecimal's unit can be viewed as an alternative way of casting Float into Decimal; or simply one could expect that BigDec...
-
- Applied in changeset r58023.
----------
improve docs for URI::Generic
* lib/uri/generic.rb: [DOC] expand docs for URI::Generic#normalize
to clarify what normalization means here.
Reported by Robert Gleeson. [ruby-core:58430] [Bug ... - 03:01 PM Revision f956ed10 (git): * 2017-03-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58024 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/uri/generic.rb: [DOC] expand docs for URI::Generic#normalize
to clarify what normalization means here.
Reported by Robert Gleeson. [ruby-core:58430] [Bug #9127]
* lib/uri/generic.rb: [DOC] fix indent for correct code block de... -
02:29 PM Bug #13325: Block is not passed to Symbol proc if using refinements
- ruby_2_4 r58022 merged revision(s) 58015.
-
- vm_args.c: pass block
* vm_args.c (refine_sym_proc_call): pass block to the method when
using refinements. [ruby-core:80219] [Bug #13325]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@58022 b2dd03c8-3... -
- * sprintf.c (rb_str_format): use FILL and FILL_ macros instead of
while loop.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58021 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:20 AM Bug #13330: Array.include? is slow for symbols
- Created PR with a fix https://github.com/ruby/ruby/pull/1540
-
- Looking at the code I noticed that [:test].include?(:test) goes through a general path instead using an optimised version making searching slower than for strings:
Benchmark available at https://github.com/pawelniewie/benchmark-set-ar... -
- Fixed. The actually used format is "%FT%T%:z".
-
- Applied in changeset r58020.
----------
date_core.c: fix error in DateTime docs
* ext/date/date_core.c: [DOC] fix format string for DateTime#rfc3339.
Reported by Andreas Rayo Kniep. [ruby-core:68418] [Bug #10936]
* ext/date/date_co... -
- * ext/date/date_core.c: [DOC] fix format string for DateTime#rfc3339.
Reported by Andreas Rayo Kniep. [ruby-core:68418] [Bug #10936]
* ext/date/date_core.c: [DOC] ditto for DateTime#iso8601 and
DateTime#xmlschema; other small impro... -
08:11 AM Misc #13329 (Closed): Creating a German ruby mailinglist on ruby-lang.org?
- Hi everyone,
I have emailed webmaster@ruby-lang.org and opened [a ticket on the website's GitHub repo](https://github.com/ruby/www.ruby-lang.org/issues/1551) without a reply, so I'll try it here again. The main German Ruby forum [goes... -
05:10 AM Feature #11302: Dir.entries and Dir.foreach without [".", ".."]
- red (Arnaud Rouyer) wrote:
> Basing myself on the GNU ls util, I propose supporting an `:ignore` key in the optional hash argument.
I very much like this. I just ran into this issue myself today having to remove `.` and `..` from `Di... -
05:05 AM Bug #13235: [BUG] Segmentation fault at 0x00000000000038
- If required...
~~~
~/Library/Logs/DiagnosticReports $ cat ruby_2017-03-19-084425_Geordees-MacBook-Pro.crash
Process: ruby [23949]
Path: /usr/local/Cellar/ruby/2.4.0/bin/ruby
Identifier: ru... -
- I can confirm the same error. Ruby 2.4.0, Mongo 2.4.1, Darwin. While looping through CSV file to load data into MongoDB.
-
- This bug predates 1.0, so it will be fixed by 2.5 but won't be backported.
-
01:37 AM Bug #13328 (Third Party's Issue): Implement OpenSSL::SSL::SSLContext#initialize_copy
- Please open an issue at https://github.com/ruby/openssl when reporting bugs of ext/openssl.
This is however not a bug. Cloning OpenSSL::SSL::SSLContext have never worked properly and left the copy in an inconsistent state in previous ... -
- A bug in ffi-aspell or (less probably) aspell library.
FFI can very easily cause segfault. -
- Applied in changeset r58019.
----------
vm_args.c: arity check of lambda
* vm_eval.c (rb_yield_lambda): new function which yields an array
to a proc and splat to a lambda. mainly for Enumerable only.
* vm_args.c (setup_parameters_c... -
- * vm_eval.c (rb_yield_lambda): new function which yields an array
to a proc and splat to a lambda. mainly for Enumerable only.
* vm_args.c (setup_parameters_complex): remove special lambda
splatting for [Bug #9605]. [ruby-core:770...
03/18/2017
-
08:48 PM Bug #13328 (Third Party's Issue): Implement OpenSSL::SSL::SSLContext#initialize_copy
- Starting in Ruby 2.4, an `OpenSSL::SSL::SSLContext` cannot be dup'ed or cloned:
```
[1] pry(main)> require 'openssl'
=> true
[2] pry(main)> OpenSSL::SSL::SSLContext.new.dup
NoMethodError: undefined method `initialize_copy' for #<O... -
06:43 PM Bug #13327 (Third Party's Issue): Segfault on OSX when using ffi-aspell
- Issue: Segfault on OSX when using ffi-aspell set method
Reproducable test case:
~~~ ruby
require 'ffi/aspell';speller = ::FFI::Aspell::Speller.new('en_US');speller.set('mode', 'html');puts speller.correct?('foo');
~~~
Expected... -
- Since 2.4 forwarding methods to private methods is deprecated (https://bugs.ruby-lang.org/issues/12782) and `method_missing` is private one, so something like
```ruby
require 'forwardable'
class PostOffice
def method_missing(*a... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58018 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:30 PM Revision a633115f (git): * 2017-03-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58017 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_lambda.rb (test_lambda_as_iterator): refine a
test for the intention of the original report.
[ruby-core:61340] [Bug #9605]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58016 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r58015.
----------
vm_args.c: pass block
* vm_args.c (refine_sym_proc_call): pass block to the method when
using refinements. [ruby-core:80219] [Bug #13325] -
- The following code raises a `LocalJumpError` at the last line on 2.4 and trunk.
2.3 and earlier work fine.
```ruby
module M
refine String do # or any class
end
end
class C
def call(a, x, &b)
b.call(a, &x)
end
end... -
- * vm_args.c (refine_sym_proc_call): pass block to the method when
using refinements. [ruby-core:80219] [Bug #13325]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58015 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm.c (invoke_iseq_block_from_c): fix stack region length.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58014 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:50 PM Bug #13276: Dir.glob returns empty array when OS has no more file handles (expected exception)
- Bump?
-
- ruby_2_4 r58013 merged revision(s) 57972.
-
- Fix bug of Tempfile#size if nothing is written [Bug #13198]
* lib/tempfile.rb (Tempfile#size): Fix its behavior when nothing
is written. Tempfile#size should return 0 in this case.
The patch is from nobu <nob... -
- * vm.c (invoke_iseq_block_from_c): guard arguments on stack, not
to be clobbered during splatting.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58012 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * .gdbinit (rp): check number of instance variables to get rid of
"Invalid number 0 of repetitions." message at an empty object.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58011 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * .gdbinit (rp): put the contents of RArray in value history, for
later use.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58010 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:50 AM Bug #13321: String#codepoints for one-byte encodings
- InfraRuby (InfraRuby Vision) wrote:
> Please update the documentation for `String#codepoints` too.
That says "This is a shorthand for `str.each_codepoint.to_a`".
> ...
Well, yes, and for almost all encodings, the returned values a... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58009 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/17/2017
-
- @duerst, @normal
r58000 accidentally reverts r57997 ("deduplicate static rb_str_format format strings") for `string.c`. -
- Please update the documentation for `String#codepoints` too.
`String#codepoints` does return (Unicode) codepoints for US-ASCII and ISO-8859-1 as those encodings are the basis of Unicode.
Maybe add `Encoding#unicode_codepoints?` whi... -
- I tried to improve the documentation with r58000. Please tell me if that helps, or if further explanations are needed.
-
- That's surprising to me but I can see that. Thanks!
-
- 0x20AC is euro sign in Unicode, it is 0x80 in Windows-1252.
-
- steenslag (siep korteling) wrote:
> Documentation for IO#read claims resulting string is always ASCII-8BIT encoding.
This statement refers only to the case that an integer `length` argument is provided; then binmode is used and the r... -
- * io.c: [DOC] improve and harmonize docs for IO#read and ARGF#read;
fix invalid example code for IO#read to make it syntax highlighted.
* io.c: [DOC] various improvements for docs of IO, ARGF, and Kernel:
fix indent to ensure correc... - 07:59 PM Revision b15f8473 (git): * 2017-03-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58007 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:59 PM Revision cad45910 (git): remove branches in dmark and dfree GC callbacks
- dmark and dfree callbacks are never called in gc.c for NULL
DATA_PTR values, not even for zombie objects.
* compile.c (ibf_loader_mark): remove branch for pointer validity
* compile.c (ibf_loader_free): ditto
* cont.c (cont_free): ditto... -
04:02 PM Bug #13324: IRB Segmentation Fault from eval infinite loop
- The command I use to run it directly on the ruby interpreter is ruby -e "a = \"eval a\"; eval a"
-
- I am not sure if this has already been taken care of or not but I am using ruby 2.3.0 and irb 0.9.6(09/06/30) and when I run the below code I get a segmentation fault
```ruby
a = "eval a"; eval a
```
when running the same code with... -
03:25 PM Bug #13107: def_delegators causes random errors in MRI 2.4.0
- twalpole@gmail.com (Thomas Walpole) wrote:
> This appears to be fixed in latest trunk now. Is there any info on when a 2.4.1 will be released - seems like a pretty serious issue.
I am in the same situation actually. Locked because o... -
01:32 PM Bug #13323 (Third Party's Issue): bug - workers - postgresql listen/notify
- xxxxxxxxxxxxxx.rb:148: [BUG] Segmentation fault at 0x0055f42ff34a70
ruby 2.3.3p222 (2016-11-21 revision 56859) [x86_64-linux]
-- Control frame information -----------------------------------------------
c:0005 p:---- s:0023 e:000022... -
01:24 PM Revision 3a55e8a4 (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58005 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm.c (invoke_iseq_block_from_c): check stack overflow before
pushing arguments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58004 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r58003 merged revision(s) 57968,57969,57970.
-
- thread.c: thread_do_start
* thread.c (thread_do_start): extract from a macro in
thread_start_func_2 for debugger.
thread.c: Thread.start with Symbol
* thread.c (thread_do_start): fix segfault at start ... -
05:00 AM Feature #12973: [RFC] net/http: use require_relative to reduce syscalls
- I remember there was a similar issue https://bugs.ruby-lang.org/issues/8781.
-
01:08 AM Feature #12973: [RFC] net/http: use require_relative to reduce syscalls
- normalperson@yhbt.net wrote:
> https://bugs.ruby-lang.org/issues/12973
Comments? Maybe I'll commit this, soon.
Thanks. -
-
- Raise error if spec is nil
With parallel test-all, the spec is sometimes nil.
To debug it raise more detailed error.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@58002 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r58001 merged revision(s) 57523,57998.
-
- rubygems-2.6.10 has a regression for installation of a beta version.
https://github.com/rubygems/rubygems/pull/1856
I created patch for above issue for ruby_2_4 branch. -
- test_gem.rb: exclude default gems
* test/rubygems/test_gem.rb: check difference to exclude default
gems from the expected results. [Feature #13186]
Merge rubygems-2.6.11
This version fixed regressio... -
- Make sure it's clear that the returned values are not Unicode codepoints
for encodings other than UTF-8/UTF-16(BE|LE)/UTF-32(BE|LE).
[ci skip] [Bug #13321]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58000 b2dd03c8-39d4-4d8f-98ff... - 01:29 AM Revision 77e1c20b (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57999 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This version fixed regression of rubygems-2.6.10.
https://github.com/rubygems/rubygems/pull/1856
See details of changelogs for 2.6.11 release:
https://github.com/rubygems/rubygems/blob/adfcf40502716080bd9cdfdd2e43bd4296872784/Hist... - 12:55 AM Revision 9eb94b4d (git): deduplicate static rb_str_format format strings
- Anybody who hits these code paths can hit them again in the
future, so try deduplicating across multiple runs of these
methods to reduce garbage.
* string.c (str_upto_each): fstring on "%.*d"
* strftime.c (rb_strftime_with_timespec): fs... - 12:55 AM Revision 312ac7f0 (git): deduplicate File::NULL string
- "/dev/null" is a common sight for pre-1.9.3-compatible code
targeting *nix systems, so deduplicate it here, as well.
* file.c (Init_File): use fstring for File::NULL
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57996 b2dd03c8-39d4... - 12:55 AM Revision 05404cba (git): deduplicate "/", ":" and "\n" strings
- "/" and ":" are always statically registered in symbol.c (Init_op_tbl),
and "\n" is a commonly seen in source code.
* file.c (Init_File): fstring on File::SEPARATOR and File::PATH_SEPARATOR
* io.c (Init_IO): fstring on rb_default_rs ("\... -
12:35 AM Bug #13271: Clarifications on refinement spec
- Gondolin (Damien Robert) wrote:
> shugo (Shugo Maeda) wrote:
> ...
Yes. I'll update doc/syntax/refinements.rdoc after investigating 2) further.
03/16/2017
- 11:17 PM Revision adce0ea9 (git): NEWS: document shorter opt_str_freeze usage
- Users do not read commit messages, but maybe they read NEWS.
r57828 ("compile.c: apply opt_str_freeze to String#-@ (uminus)")
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57994 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- On many versions of Ruby, including 2.4.0:
"\x80".force_encoding("WINDOWS-1252").codepoints.first # => 0x80
I expected 0x20AC: https://en.wikipedia.org/wiki/Windows-1252
See:
https://github.com/ruby/ruby/blob/v2_4_0/strin... -
09:20 PM Bug #13271: Clarifications on refinement spec
- shugo (Shugo Maeda) wrote:
> The behavior was changed by Feature #8571.
Well I prefer that this feature remains so that's nice! But this probably means that the spec should be updated then? -
- shugo (Shugo Maeda) wrote:
> Gondolin (Damien Robert) wrote:
> ...
Sorry, it's wrong:(
The behavior was changed by Feature #8571.
-
- Gondolin (Damien Robert) wrote:
> > The behavior of my first proposal was what you expected, but it was changed to reduce implicit effects of refinements.
> ...
Yes.
> > This behavior seems strange, and may be a bug of the implement... - 08:58 PM Revision ec039905 (git): * 2017-03-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57992 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:50 PM Bug #13223: `File.join` will segv if File::SEPARATOR and File::Separator are set.
- shyouhei (Shyouhei Urabe) wrote:
> I'd personally like to vote for ignoring redefinitions of constants. In general redefinitions prevent optimizations. That doesn't make me happy.
I agree in that it is good to not change basic funct... -
- I'd personally like to vote for ignoring redefinitions of constants. In general redefinitions prevent optimizations. That doesn't make me happy.
-
06:46 PM Feature #13208: Vector.zero(n) and vector.zero?
- Martin is exactly right. See https://en.wikipedia.org/wiki/Vacuous_truth
-
06:31 PM Bug #13320 (Closed): rescue blocks get an entry in backtrace locations
- ```ruby
def foo
puts caller(0)
end
def bar
raise
rescue
foo
end
bar
```
foo
rescue in bar
bar
this does not seem to make sense, conceptually a rescue block is not a separate callable entity, but just a section... -
- Could you try the recent trunk?
-
12:50 PM Bug #13319 (Closed): GC issues seen with GCC7
- It looks like there is a latent GC issue somewhere that I can for example reproduce with ruby 2.3.3 and 2.2.6 when building with `-O2 -g`.
valgrind reports a lot of cases like
```
==24537== Invalid read of size 4
==24537== at 0x... -
12:05 PM Bug #13305: Occasional segfaults after defining methods while running coverage
- mame (Yusuke Endoh) wrote:
> I think I could fix the issue. Nikita, thank you for the very useful report!
Awesome! Thank you, can confirm, I tested the latest trunk in the environment where I had found the issue and the build passed... -
- It's a bug in BTCRuby which uses FFI.
Please report it to BTCRuby authors. -
09:50 AM Bug #13318 (Third Party's Issue): Segmentation fault at 0x00000000000018
- I was running straight-server and use straight-server-kit command to create an order, then encountered an error. Output displayed on screen is:
```
[seven@localhost straight-server]$ bundle exec bin/straight-server -p 9696
/home/sev... -
- stomar (Marcus Stollsteimer) wrote:
> * I think `rb_str_cat_cstr(mesg, ": ");` in the while-loop doesn't work; ":" must be added before the loop, in the loop only " " to separate different entries
Woops, good catch. Fixed in a new at... -
- * rational.c (read_num): `n` was used uninitialized when the
string started with a period.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r57990.
----------
rational.c: float denom
* rational.c (parse_rat): allow float as a denominator as well as
a numerator. [ruby-core:79104] [Bug #13134] -
- * rational.c (parse_rat): allow float as a denominator as well as
a numerator. [ruby-core:79104] [Bug #13134]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57990 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * rational.c (read_num): use rb_int_parse_cstr to parse integer
parts, and make String#to_r consistent with #to_i and #to_f.
[ruby-core:80098] [Bug #13105]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57989 b2dd03c8-39d4-4d8f-9... -
- * bignum.c (rb_int_parse_cstr): extend rb_cstr_parse_inum with
flags.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r57987.
----------
test_rational.rb: invalid exponent
* test/ruby/test_rational.rb (test_parse): more checks for invalid
exponent. [ruby-core:80098] [Bug #13105] -
- * test/ruby/test_rational.rb (test_parse): more checks for invalid
exponent. [ruby-core:80098] [Bug #13105]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_rational.rb (test_parse): remove duplicate
assertions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57986 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * rational.c (read_rat_nos): denominator cannot be 0, raise zero
division in that case.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57985 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:43 AM Revision 1e07906a (git): * 2017-03-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57984 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_rational.rb (test_parse): reduce repeated
arguments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57983 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > ```
> ...
It happens just in byebug extension.
Please report it to byebug.
03/15/2017
-
- Granted, in the case of #zero? returning true might suggest itself, but is "nothing" really the same as "zero"...? If there was a method Vector.one with Vector.one(3) => Vector[1, 1, 1], should Vector.one(0).one? be true? (All the values...
-
- stomar (Marcus Stollsteimer) wrote:
> Just curious:
> ...
Definitely `true`. More generally,
``` ruby
Vector.zero(x).zero? # => true
```
for any value of `x`.
Colloquially, all the values in the vector are zero, even if there... -
02:53 PM Bug #13317 (Third Party's Issue): Console Segmentation fault at 0x00000000000038
- First: It's been 3 years I'm daily using Ruby, and that's the first time I encounter such a bug, so, thank you for all the hard work. That's awesome.
Here is the bug report :
I don't have much to add, was querying my DB with AR. (I... -
02:42 PM Feature #13303: String#any? as !String#empty?
- > and understand there's Array#any?.
This is a misconception, `Array#any?` does not check if the array is empty, but if there is a true-ish value in the array:
```ruby
irb(main):001:0> [false, nil].any?
=> false
```
This is d... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57982 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:30 AM Misc #13283: Disable `&' interpreted as argument prefix warning when passing symbol to Enumerable#map
- Great! Thanks for the update Martin!
-
- First, for `&` immediately before a `:symbol` (without any space inbetween), Nobu already has removed the warning as approved by Matz, so I'm closing this issue.
urbanautomaton (Simon Coffey) wrote:
> Bitwise AND isn't the only int... -
- > Just looking in stdlib, `Set#&` means set intersection, and anyone can define `#&` on any class they like to mean whatever makes sense to them - that's the joy of ruby.
Now I understand where the conflict is. Thank you for pointing ... -
- Thanks for the answers!
shugo (Shugo Maeda) wrote:
> The behavior of my first proposal was what you expected, but it was changed to reduce implicit effects of refinements.
So should I expect that in future ruby versions `using M` ... -
- Gondolin (Damien Robert) wrote:
> 1) As I was expecting, '`using M1`' not only activate the refinements of `M1` but also the refinements of the included module `M2`.
> ...
The behavior of my first proposal was what you expected, but it... - 08:25 AM Revision 0ddb77a4 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57981 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:25 AM Revision 10b80013 (git): add several counters to analyze ivar inline caches.
- * debug_counter.h: add (and renamed) several counters:
ivar_get_ic_hit
ivar_get_ic_miss
ivar_get_ic_miss_serial
ivar_get_ic_miss_unset
ivar_get_ic_miss_noobject
ivar_set_ic_hit
ivar_set_ic_miss
ivar_set_ic_miss_serial
i... -
-
- Applied in changeset r57979.
----------
object.c: make String#to_f consistent with literal
* object.c (rb_cstr_to_dbl): stop at successive underscores, as
well as Float literals. [ruby-core:80098] [Bug #13105]
* `_` should be wit... -
- * object.c (rb_cstr_to_dbl): stop at successive underscores, as
well as Float literals. [ruby-core:80098] [Bug #13105]
* `_` should be within digits
* only one `_` allowed between digits
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
- * string.c (str_casecmp, str_casecmp_p): split to skip argument
check when it is a String certainly.
* string.c (sym_casecmp, sym_casecmp_p): shortcut argument checks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57978 b2dd03c8-... -
- >I'd like to gemify matrix & ostruct
marcandre, Thank you for your attention.
I try to clarify to gemification process for you. I will create issue of matrix and ostruct gemification. -
-
- You run `/usr/bin/gem`.
Is `gem` command in `/Users/Stuart/.rvm/gems/ruby-2.4.0/bin` directory, and excutable? -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57977 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/14/2017
-
11:55 PM Misc #13283: Disable `&' interpreted as argument prefix warning when passing symbol to Enumerable#map
- mojavelinux (Dan Allen) wrote:
> The alternative, a bitwise operation on a symbol, makes little sense. That's especially when the bitwise operator is directly adjacent to the symbol.
Bitwise AND isn't the only interpretation of infix... -
11:04 PM Bug #12642: Net::HTTP populates host header incorrectly when using an IPv6 Address
- # Missing brackets from Host header for IPv6 addresses
This is a regression from Ruby 2.1. The bug appears to have been introduced in ruby 2.2.0 by this commit: https://github.com/ruby/ruby/commit/70a2eb63999265ff7e8d46d1f5b410c8ee3d3... -
08:57 PM Feature #5481: Gemifying Ruby standard library
- hsbt (Hiroshi SHIBATA) wrote:
> Thank you for your information. I have never seen jruby patches in jruby/ruby repository.
> ...
Many of these changes could be merged back into MRI. I can start this process if you think it would be a go... -
- I'd like to gemify matrix & ostruct, but it's not clear to me what needs to be done besides creating the gemspec and how future versions are meant to be released.
-
- Just curious:
``` ruby
Vector.zero(0).zero? # => true or false?
```
Not sure what I would expect in this case. -
-
- Thanks for the patch.
Committed.
PS: I allowed `Vector.zero(0)`. - 08:09 PM Revision 666df145 (git): * lib/matrix.rb: Add Vector.zero and Vector#zero?
- Patch by Chia-sheng Chen [#13208]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57976 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:40 PM Feature #13166: Feature Request: Byte Arrays for Ruby 3
- My original use case was for creating an array of data that essentially
contained ``1|0`` data to represent ``true|false`` flags.
In the C version of my program I just created an array of bytes (char)
because they are fast, and wast... -
06:50 PM Misc #13316 (Third Party's Issue): gem startup and Path order OS X
- I'm having great trouble getting gem to reliably start on OS X 10.11.6. This has only started to happen recently. The problem appears to be in getting the Path order correct due to the requirements of Ruby and rvm. Attached is the gem cr...
- 03:14 PM Revision 31e74d51 (git): * 2017-03-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57975 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:14 PM Revision a4d6fb55 (git): Stop a global server of Rinda test
- This server seemed to cause "leaked file descriptor" warnings.
Moved it into the setup/teardown framework.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57973 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- shyouhei (Shyouhei Urabe) wrote:
> Nobu already made changes but, yes we looked at this issue in today's developer meeting.
> ...
It is *much* better to not leave semantics to be implementation-defined, as it's essentially the same as ... -
- normalperson (Eric Wong) wrote:
> Ah, thanks. I forgot this :x I saw you already made r57634.
> ...
I guess `Fiber` would too. -
12:55 PM Feature #13314: dig=
- you can do that, as example
~~~ ruby
a = {key1: { key2: { key3: { key4: '4' }}}};
a.dig(:key1, :key2, :key3)[:key4] = 4
=> {:key1=>{:key2=>{:key3=>{:key4=>4}}}}
~~~
-
- Assignment to method call has been a challenge in the last couple of years, but not possible yet,
-
06:40 AM Feature #13314: dig=
- Was this syntactically not allowed? If so, sorry.
-
- We have `Hash#dig`, and when we want to assign a key-value at a deep level, it is tempting to do:
```ruby
hash.dig(:key1, :key2, :key3, :key4) = "value
```
when we actually needed to do:
```ruby
hash.dig(:key1, :key2, :key3)&... -
12:53 PM Bug #13198 (Closed): Tempfile#size is nil when nothing is written, expected 0 - Applied in changeset r57972.
----------
Fix bug of Tempfile#size if nothing is written [Bug #13198]
* lib/tempfile.rb (Tempfile#size): Fix its behavior when nothing
is written. Tempfile#size should return 0 in this case.
The patch ... -
12:53 PM Revision 279d31f1 (git): Fix bug of Tempfile#size if nothing is written [Bug #13198]
- * lib/tempfile.rb (Tempfile#size): Fix its behavior when nothing
is written. Tempfile#size should return 0 in this case.
The patch is from nobu <nobu@ruby-lang.org>.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57972 b2dd03c8-3... -
- I think I could fix the issue. Nikita, thank you for the very useful report!
-
- Applied in changeset r57971.
----------
Fix a consistency bug of ISEQ_COVERAGE [Bug #13305]
There is an invariant that ISEQ_COVERAGE(iseq) must be Qnil if and only
if option->coverage_enabled is false. This invariant was broken by
NOD... -
- There is an invariant that ISEQ_COVERAGE(iseq) must be Qnil if and only
if option->coverage_enabled is false. This invariant was broken by
NODE_PRELUDE which updates option->coverage_enabled but not
ISEQ_COVERAGE(iseq).
git-svn-id: svn... -
-
- Is this intentional?
```ruby
printf("%") #=> "%"
```
`printf` in glibc does print nothing, gcc warns though.
```c
#include <stdio.h>
int main(void)
{
printf("%");
return 0;
}
```
```sh
$ gcc fmt.c && ./a.out
... -
- * thread.c (rb_vm_proc_local_ep): added.
* cont.c (rb_fiber_start): use rb_vm_proc_local_ep().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57970 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r57969.
----------
thread.c: Thread.start with Symbol
* thread.c (thread_do_start): fix segfault at start with Symbol.
proc created by Symbol#to_proc does not have environment unless
using refinements. [ruby-c... -
- * thread.c (thread_do_start): fix segfault at start with Symbol.
proc created by Symbol#to_proc does not have environment unless
using refinements. [ruby-core:80147] [Bug #13313]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57... -
- * thread.c (thread_do_start): extract from a macro in
thread_start_func_2 for debugger.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57968 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/envutil.rb (EnvUtil.diagnostic_reports): diagnostic
report file uses base name only. [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_core.h (vm_proc_block): assert before accessing.
* vm_core.h (vm_proc_iseq): remove duplicate assertion.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (rb_str_cmp_m): use rb_check_string_type for check and
conversion, instead of calling the conversion method directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Using a 1-bit greater initial estimate than for **bbm** makes Newton's nth-root implementation
significantly faster across the board than before (with seemingly correct answers).
```
def irootn2(n) # Newton's method for nth root
... -
- I couldn't reproduce the problem in any of 2.2.4p230 (x86_64-linux), 2.3.3p222 (x86_64-linux),
2.4.0p0 (x86_64-linux), and 2.3.3p222 (x64-mingw32).
Could you send us debug output by setting Net::FTP#debug_mode to true?
Make sure the...