Project

General

Profile

Activity

From 12/09/2016 to 12/15/2016

12/15/2016

10:05 PM Feature #6647: Exceptions raised in threads should be logged
Shyouhei Urabe wrote:
> We looked at this issue at developer meeting today and John's proposal sounded reasonable. So there quite are possibilities to accept it I think.
Fantastic! Any chance this will make it into the 2.4 release?
backus (John Backus)
07:11 PM Bug #13040 (Rejected): syslog/logger uses "require 'logger'" which is interpreted as circular dependency
while using the 'syslog/logger' require from Ruby it works well, however if one tries to use it via "test" it complaints about circular require and the constant "Logger" not defined. After a little digging, I realized that 'syslog/logger... lemsx1 (Luis Mondesi)
07:02 PM Bug #13039 (Rejected): build warning on 2.4-rc1
When calling autoreconf -f -i, the following warning is generated:
aclocal-1.15: warning: autoconf input should be named 'configure.ac', not 'configure.in'
Renaming configure.in to configure.ac should do it and should be harmless.
swills (Steve Wills)
06:46 PM Bug #13037: Segmentation fault on "\n".lines(chomp: true)
I believe a fix for this is:
~~~
Index: string.c
===================================================================
--- string.c (revision 57085)
+++ string.c (working copy)
@@ -7409,8 +7409,9 @@
if (rb_enc_is_newline(prev...
asterite (Ary Borenszweig)
02:35 PM Bug #13037 (Closed): Segmentation fault on "\n".lines(chomp: true)
$ irb
irb(main):001:0> RUBY_DESCRIPTION
=> "ruby 2.4.0dev (2016-12-15 trunk 57084) [x86_64-darwin15]"
irb(main):002:0> "\n".lines(chomp: true)
(irb):2: [BUG] Segmentation fault at 0x00000000000000
ruby 2.4.0dev (2016-12-15 trunk 570...
asterite (Ary Borenszweig)
04:28 PM Bug #13038: ruby 2.4 rc1 fails to build on FreeBSD due to failure to find crypt.h
I think this may have been initially introduced in r55237. swills (Steve Wills)
03:50 PM Bug #13038 (Closed): ruby 2.4 rc1 fails to build on FreeBSD due to failure to find crypt.h
When trying to build ruby 2.4 on FreeBSD, it fails with error:
string.c:33:11: fatal error: 'crypt.h' file not found
swills (Steve Wills)
04:08 PM Revision 17c28285 (git): * 2016-12-16
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57087 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:08 PM Revision 9f5a161d (git): NEWS: Fix the default rounding mode
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57086 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Kenta Murata
02:56 PM Bug #13036: Date.parse mishandling spanish months "Abril y Agosto"
AFAIK, Date.parse was NEVER intending to parse anything except English/American dates in English/American formats. Parsing dates internationally is waaaay harder than making dictionaries of month names: different cultures have different ... zverok (Victor Shepelev)
02:52 PM Bug #13036: Date.parse mishandling spanish months "Abril y Agosto"
I don't think this is a bug, Ruby only parses English month names, it can't possibly try to check all languages in the world. When it can't deduce a month, it uses the current month, which right now is december. asterite (Ary Borenszweig)
02:49 PM Bug #13036: Date.parse mishandling spanish months "Abril y Agosto"
## UPDATE:
I tracked the problem to dates_international.rb (https://gist.github.com/jackrg/2927162)
The problem is solved replacing line 37.
From:
37: month_from = string[/[^\s\d,]+/i]
To:
37: month_from = string[/[a-...
greutter (Gonzalo Reutter)
02:11 PM Bug #13036 (Rejected): Date.parse mishandling spanish months "Abril y Agosto"
### Steps to reproduce
$ irb
2.3.0 :003 > Date.parse("01-Agosto-2016")
=> 01 Dec 2016
2.3.0 :004 > Date.parse("01-Abril-2016")
=> 01 Dec 2016
### Expected behavior
2.3.0 :003 > Date.parse("01-Agosto-2016")
=> 01 Aug 201...
greutter (Gonzalo Reutter)
12:58 PM Revision 2d6538a7 (git): parse.y: newline in heredoc identifier
* parse.y (parser_heredoc_identifier): warn newline in here
document identifier.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57085 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
11:00 AM Revision def2a2cb (git): Added entry of psych 2.2.2
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57084 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
11:00 AM Revision f9ee1409 (git): Update psych-2.2.2
* It fixed only JRuby dependency issue.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57083 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
10:41 AM Feature #12719: `Struct#merge` for partial updates
Scala has "copy" for this purpose: some_case_class_object.copy(field: new_value) Eregon (Benoit Daloze)
10:34 AM Feature #12745: String#(g)sub(!) should pass a MatchData to the block, not a String
Maybe this functionality should just be an extra keyword argument to these methods?
Like
str.gsub!(/\[(\w+)\]/, md: true)
Not as concise, but much better on compatibility and clarity of the intent.
Eregon (Benoit Daloze)
09:41 AM Feature #13017: Switch SipHash from SipHash24 to SipHash13
@ko1 , I think, a ball is yours. funny_falcon (Yura Sokolov)
05:48 AM Feature #13017: Switch SipHash from SipHash24 to SipHash13
Who has a ball? ko1 (Koichi Sasada)
07:00 AM Bug #13035 (Third Party's Issue): Segmentation fault when using Rails 5.0.0.1 console
Thank you reporting, this is a known 3rd party issue. shyouhei (Shyouhei Urabe)
06:52 AM Bug #13035 (Third Party's Issue): Segmentation fault when using Rails 5.0.0.1 console
Following along with the new Rails blog intro, I ran into a segfault when I attempted to run a query from the Rails console.
2.3.3 :001 > Post.first.comments
/Users/ksapp/.rvm/gems/ruby-2.3.3@blog/gems/activerecord-5.0.0.1/lib/activ...
kevinsapp (Kevin Sapp)
06:22 AM Revision b5345673 (git): parse.y: one warning, one line [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57082 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
05:40 AM Feature #13009: Implement fetch for Thread.current
2.4? 2.5? ko1 (Koichi Sasada)
04:25 AM Bug #10613: SNI is not optional when using TLS
Unfortunately, I don't know any details about the server. It's not a box that we own.
I am connecting over an SSH tunnel, so the hostname being used for SNI is 127.0.0.1. The server simply returns a 400; my best guess is that it's n...
bschmeck (Ben Schmeckpeper)

12/14/2016

05:53 PM Revision 836794f2 (git): Removed the obstacle to running test-all with VC14.
* test/fiddle/test_import.rb (LIBC.fprintf): VC14's `fprintf` is very distinct
name, then, just ignore this test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57081 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
05:49 PM Bug #13033 (Closed): 2.4.0-rc1, build error with VS2015
Applied in changeset r57079.
----------
Fixed link error with VC14.
* win32/mkexports.rb (Exports::Mswin#each_exports): should ignore `vsprintf_s_l`
and the like just like `vsprintf_l`.
[ruby-dev:49899] [Bug #13033]
usa (Usaku NAKAMURA)
05:45 PM Bug #13033: 2.4.0-rc1, build error with VS2015
Yui NARUSE wrote:
> Could you try following patch?
I'd tried same patch and it seemed OK.
I'll commit it later.
usa (Usaku NAKAMURA)
05:15 PM Bug #13033: 2.4.0-rc1, build error with VS2015
Could you try following patch?
```diff
diff --git a/win32/mkexports.rb b/win32/mkexports.rb
index d26acbb107..8fc7d9ddb5 100755
--- a/win32/mkexports.rb
+++ b/win32/mkexports.rb
@@ -114,7 +114,7 @@ def each_export(objs)
...
naruse (Yui NARUSE)
02:37 AM Bug #13033 (Closed): 2.4.0-rc1, build error with VS2015
I got following error message when building 2.4.0-rc1 with Visual Studio 2015 update 3. Attached "rc1_output.txt" is full-length nmake output.
2.4.0-preview3 doesn't have this error.
`linking shared-library x64-vcruntime140-ruby240.d...
Anonymous
05:49 PM Revision 7fd3da32 (git): * 2016-12-15
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57080 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
05:49 PM Revision ca25a970 (git): Fixed link error with VC14.
* win32/mkexports.rb (Exports::Mswin#each_exports): should ignore `vsprintf_s_l`
and the like just like `vsprintf_l`.
[ruby-dev:49899] [Bug #13033]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57079 b2dd03c8-39d4-4d8f-98ff-823...
U.Nakamura
03:42 PM Feature #12944: Change Kernel#warn to call Warning.warn
In order to handle embedded arrays (similar to how puts handles them), the attached patch flattens the array, processes each string individually making sure it ends in a newline, then joins the array with the empty string. jeremyevans0 (Jeremy Evans)
07:56 AM Feature #12944: Change Kernel#warn to call Warning.warn
Seems `warn ["foo\n", "bar"]` would print `"foo\n\nbar\n"`. nobu (Nobuyoshi Nakada)
12:32 PM Bug #13034 (Closed): rb_enc_ascget() does not handle 'needmore' error from rb_enc_procise_mbclen()
Applied in changeset r57078.
----------
encoding.c: handle needmore error from rb_enc_precise_mbclen()
rb_enc_ascget() erroneously reports success even if the given byte
sequence is incomplete, for non-ASCII compatible encoding strings...
Anonymous
12:20 PM Bug #13034 (Closed): rb_enc_ascget() does not handle 'needmore' error from rb_enc_procise_mbclen()
rb_enc_ascget() stores the return value from rb_enc_procise_mbclen() that may return a negative value on error to 'unsigned int', and thus it overlooks errors due to incomplete UTF-16/32 byte sequence.
This bug is visible from Ruby; f...
rhenium (Kazuki Yamaguchi)
12:32 PM Revision 201972ac (git): encoding.c: handle needmore error from rb_enc_precise_mbclen()
rb_enc_ascget() erroneously reports success even if the given byte
sequence is incomplete, for non-ASCII compatible encoding strings.
rb_enc_precise_mbclen() may return a negative value on error, and thus
rb_enc_ascget() must not store ...
rhenium (Kazuki Yamaguchi)
08:26 AM Bug #13032 (Closed): building capi docs with doxygen seems broken in 2.4-rc1
Applied in changeset r57077.
----------
vcs.rb: no ext/date in vcs.rb
* tool/vcs.rb (VCS::GIT#export_changelog): do not require date
extension library so that miniruby can run.
[ruby-core:78641] [Bug #13032]
nobu (Nobuyoshi Nakada)
02:54 AM Bug #13032: building capi docs with doxygen seems broken in 2.4-rc1
This looks to be a recurrence of bug 10161, which was created by r43888 then reverted in r47248 and now triggered again in r56670. swills (Steve Wills)
02:18 AM Bug #13032 (Closed): building capi docs with doxygen seems broken in 2.4-rc1
When building 2.4-rc1 with the --enable-install-capi option passed to configure, I get lots of messages of this form:
~~~
Version of /wrkdirs/usr/ports/lang/ruby24/work/ruby-2.4.0-rc1/id.c : /wrkdirs/usr/ports/lang/ruby24/work/ruby-2...
swills (Steve Wills)
08:25 AM Revision 72c1b322 (git): vcs.rb: no ext/date in vcs.rb
* tool/vcs.rb (VCS::GIT#export_changelog): do not require date
extension library so that miniruby can run.
[ruby-core:78641] [Bug #13032]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57077 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
08:06 AM Revision 1407e52b (git): constify
* vm_dump.c (rb_vmdebug_debug_print_pre): constify pc argument for
VMDEBUG.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57076 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
07:30 AM Revision 07e7981d (git): parse.y: curtail scanning
* parse.y (parser_yyerror): curtail scanning range, not to exceed
the max margin.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57075 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:35 AM Revision 2027ad60 (git): * 2016-12-14
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57074 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:35 AM Revision bc44acb5 (git): parse.y: fix yyerror message
* parse.y (parser_yyerror): show the error line even if the error
is at the end.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57073 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:11 AM Bug #12548 (Open): Rounding modes inconsistency between round versus sprintf
Reopening.
The fix was reverted due to issue #12958. This issue is now back alive.
shyouhei (Shyouhei Urabe)
12:33 AM Bug #13031: Error in Ruby on Rails
Hiroshi SHIBATA wrote:
> >c:0005 p:0115 s:0022 e:000021 METHOD /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55
> ...
What does that mean?
higginni (Niall Higgins)
12:21 AM Bug #13031 (Rejected): Error in Ruby on Rails
>c:0005 p:0115 s:0022 e:000021 METHOD /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55
You mixed Ruby 2.0 and 2.2 on rvm.
hsbt (Hiroshi SHIBATA)

12/13/2016

11:31 PM Bug #13031 (Rejected): Error in Ruby on Rails
Below is the error found in the terminal. I usually would not copy and paste the entire error message but it told me to do so.
I didn't update anything, I just found it like this after logging in after roughly 2 weeks away.
My Ra...
higginni (Niall Higgins)
08:25 PM Bug #13030 (Closed): Unexpected T_IMEMO object when building with VMDEBUG
Hello,
I'm trying to build Ruby 2.4.0-rc1 with VMDEBUG=3 for research purposes, but I'm getting this error.
~~~
/home/user/.rubies/ruby-2.4.0-rc1/lib/fileutils.rb:90:in `<module:FileUtils>': method `inspect' called on unexpected T_I...
jesus_castello (Jesus Castello)
08:23 PM Bug #13029 (Closed): Update doc/contributors.rdoc
As the file says "Feel free to add your name if your patch was accepted into Ruby".
Some of my patches:
HTML5 tag maker patch: #6637 and #7110
documentation patches: #12311, #12246, #12228, #10576, and others;
and main committer ...
stomar (Marcus Stollsteimer)
04:27 PM Feature #12944: Change Kernel#warn to call Warning.warn
The attached patch uses `rb_ary_join` to create the string to pass to `Warning.warn`, which should do a better job of handling corner cases such as `warn ["foo", "bar"]`. jeremyevans0 (Jeremy Evans)
05:34 AM Feature #12944: Change Kernel#warn to call Warning.warn
One thing to be confirmed, this patch lets `warn ["foo", "bar"]` print one line while two lines are printed now.
Is this OK?
nobu (Nobuyoshi Nakada)
05:08 AM Feature #12944: Change Kernel#warn to call Warning.warn
Jeremy Evans wrote:
> This didn't make 2.4.0rc1, but as matz has already accepted it, it should probably be committed before 2.4.0 final. If further changes are needed to the patch, please let me know.
OK.
nobu, could you handle this?
naruse (Yui NARUSE)
02:27 PM Bug #13028 (Closed): Binding#irb upon exiting makes _ retain the value of the last expression and never change it
Given an open `irb` session. After exiting from `binding.irb` the `_`, which is the last value of the current context, somehow retains the value of the last expression evaluated in the context of `binding.irb` and then doesn't change it.... dskecse (Dzianis Dashkevich)
08:21 AM Bug #12997: Out-of-bounds read in regcomp.c
Sure, created https://github.com/k-takata/Onigmo/issues/81. rhenium (Kazuki Yamaguchi)
05:17 AM Bug #12994 (Closed): Embedded ruby vs2015 build crashes
Applied in changeset r57072.
----------
declare `rb_w32_sysinit` in header.
* include/ruby/win32.h (rb_w32_sysinit): declare.
[ruby-core:78444] [Bug #12994]
* ruby.c (ruby_sysinit): follow above change.
usa (Usaku NAKAMURA)
05:17 AM Revision 42d9712e (git): declare `rb_w32_sysinit` in header.
* include/ruby/win32.h (rb_w32_sysinit): declare.
[ruby-core:78444] [Bug #12994]
* ruby.c (ruby_sysinit): follow above change.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57072 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
03:55 AM Revision 5dad4ef8 (git): require "irb/output-method" for StdioOutputMethod
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57071 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
03:55 AM Revision 8270a493 (git): make-snapshot: fix circular dependency
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57070 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
02:01 AM Revision 910848f2 (git): Update description of XMLRPC section.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57069 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)

12/12/2016

10:54 PM Bug #12830 (Closed): OpenSSL 1.1.0+ support?
Yes, I don't expect any further action. vo.x (Vit Ondruch)
06:00 PM Bug #12830: OpenSSL 1.1.0+ support?
This looks resolved. naruse (Yui NARUSE)
06:39 PM Bug #12852: URI.parse can't handle non-ascii URIs
Matthew Kerwin wrote:
> Your thinking here seems confused. If a String contains non-ASCII characters then it's not a URI. If it is a URI then it strictly matches the definition of a URI. If a String contains a valid IRI, then yeah, you'...
naruse (Yui NARUSE)
06:05 PM Bug #12997: Out-of-bounds read in regcomp.c
Could you report it to Onigmo?
https://github.com/k-takata/Onigmo
naruse (Yui NARUSE)
06:04 PM Bug #12994 (Assigned): Embedded ruby vs2015 build crashes
naruse (Yui NARUSE)
06:02 PM Bug #9974 (Rejected): Regression: URI.parse allows invalid URIs
Larry Kyrala wrote:
> The URI abstraction speaks to RFC3986 (DNS) more directly than RFC952 (hostnames). The confusion is understandable.
> ...
JavaScript's `new URL("http://test_example")` accepts underscore.
Therefore I don't think...
naruse (Yui NARUSE)
04:18 PM Revision e12265da (git): get rid of a test failure with VC10.
* numeric.c (round_half_up, round_half_down): use `round` always because it's
defined in this file even if doesn't exist.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57068 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
03:43 PM Feature #12802: Add BLAKE2 support to Digest
> Nobuyoshi Nakada wrote:
> ...
Kazuki Yamaguchi wrote:
> Is there still a supported environment without 64-bit integer support? ext/digest/sha2/sha2.c is already using 64-bit integers. It is compiled only when OpenSSL (or CommonCrypto...
naruse (Yui NARUSE)
03:36 PM Bug #12666: Fatal error: glibc detected an invalid stdio handle
George Koehler wrote:
> For both BSD and Linux, I want to suggest
> ...
It breaks FreeBSD.
```
irb(main):001:0> require"fiddle"
=> true
irb(main):002:0> Fiddle.dlopen("libc.so")
Fiddle::DLError: /usr/lib/libc.so: invalid file fo...
naruse (Yui NARUSE)
03:33 PM Feature #12882: Add caller/file/line information to internal Kernel#warn calls
matz, can you update this ticket and let me know which of these four options you prefer:
1) Add :caller keyword argument to Kernel#warn (not backwards compatible API-wise).
2) Change Kernel#warn to automatically prepend caller(1,1) (...
jeremyevans0 (Jeremy Evans)
03:24 PM Bug #10774 (Closed): Regression: URI::MAilTo#to_mailtext - undefined method unescape for URI::RFC3986_Parser
Applied in changeset r57066.
----------
Use URI.decode_www_form_component [Bug #10774]
`parser` refered RFC2396_Parser, but it is separated.
test is contributed by Dominik Menke
naruse (Yui NARUSE)
03:24 PM Revision e29f932c (git): * 2016-12-13
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57067 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:24 PM Revision 6c0aece5 (git): Use URI.decode_www_form_component [Bug #10774]
`parser` refered RFC2396_Parser, but it is separated.
test is contributed by Dominik Menke
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57066 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)
03:24 PM Feature #12944: Change Kernel#warn to call Warning.warn
This didn't make 2.4.0rc1, but as matz has already accepted it, it should probably be committed before 2.4.0 final. If further changes are needed to the patch, please let me know. jeremyevans0 (Jeremy Evans)
03:05 PM Bug #13024: Confusing error message matching a non-ASCII string with ASCII-regex
Hmm, maybe the error message express /.../n is ASCII-8BIT (binary) regexp... naruse (Yui NARUSE)
02:55 PM Revision 31f17f88 (git): st: Add 'static const'
patched by Ken Takata [ruby-core:78558]
https://github.com/k-takata/Onigmo/commit/44e3c0a16da1116be641ea807c1202434b743ace
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57065 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)
02:43 PM Misc #13027 (Closed): Release Engineering 2.4
META ticket for Release Engineering 2.4.
see also version#33
* current status: feature freeze
* Q: Can I add a new feature?
* A: No. Its status is already "feature freeze".
* Q: Can I fix a bug?
* A: Yes
* Q: I want to com...
naruse (Yui NARUSE)
01:37 PM Revision 8f21d921 (git): fix command
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57062 b2dd03c8-39d4-4d8f-98ff-823fe69b080e naruse (Yui NARUSE)
01:20 PM Revision 325c8362 (git): Use 7z if exist
7z can compress with higher ratio than gzip/zip.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57060 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)
01:12 PM Revision c45bf662 (git): NEWS: Add String#match? and Symbol#match? [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57059 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
01:12 PM Revision 908edb0d (git): NEWS: Use spaces instead of tab [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57058 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
01:12 PM Revision aa91e864 (git): NEWS: Sort entries [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57057 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
11:30 AM Feature #8158: lightweight structure for loaded features index
I've tried to simplify patch: remove `struct feature_str` and use just pointer with len.
https://bugs.ruby-lang.org/attachments/download/6295/load.c-loaded_features_numindex.patch
https://github.com/ruby/ruby/compare/trunk...funny-...
funny_falcon (Yura Sokolov)
10:44 AM Feature #8158: lightweight structure for loaded features index
I've uploaded fixed patch:
https://bugs.ruby-lang.org/attachments/download/6293/0001-load.c-reduce-memory-usage-of-loaded_features_index.patch
Github branch and diff:
https://github.com/funny-falcon/ruby/tree/loaded_features_strings...
funny_falcon (Yura Sokolov)
08:05 AM Feature #8158: lightweight structure for loaded features index
I'll fix patch today. funny_falcon (Yura Sokolov)
07:20 AM Feature #8158: lightweight structure for loaded features index
Usaku NAKAMURA wrote:
> In message "[ruby-core:78595] Re: [Ruby trunk Feature#8158] lightweight structure for loaded features index"
> ...
Other compilers fail, IIRC, Solaris, AIX, HP-UX, or something.
nobu (Nobuyoshi Nakada)
06:41 AM Feature #8158: lightweight structure for loaded features index
Hi,

In message "[ruby-core:78595] Re: [Ruby trunk Feature#8158] lightweight structure for loaded features index"
on Mon, 12 Dec 2016 06:06:13 +0000, normalperson@yhbt.net wrote:
> I'm not sure about the portability of initializing ...
usa (Usaku NAKAMURA)
06:09 AM Feature #8158: lightweight structure for loaded features index
funny.falcon@gmail.com wrote:
> So patch now is shorter.
> https://bugs.ruby-lang.org/attachments/download/6182/0001-load.c-reduce-memory-usage-of-loaded_features_index.patch

Thanks; this got broken by trivial whitespace change in ...
normalperson (Eric Wong)
11:03 AM Feature #13026 (Open): Public singleton methods
Abstract
---------
I would like to propose the implementation of:
```
Object#public_singleton_methods
```
`Object#public_singleton_methods` should return a list of public singleton methods.
Background
------------
Curr...
subtileos (Daniel Ferreira)
07:18 AM Feature #13025 (Feedback): String equality operator does not perform implicit conversion
What documentation do you refer?
The document of 2.3 says:
> If `obj` is not an instance of String but responds to `to_str`, then the
> ...
(the method to be called is wrong, though)
Do you suggest changing the fallback method?
nobu (Nobuyoshi Nakada)
06:03 AM Feature #13025 (Feedback): String equality operator does not perform implicit conversion
According to the documentation, String#== should perform implicit conversion of non-strings, but this is not happening.
~~~ruby
class SomeClass
def initialize(value)
@value = value
end
def to_str
@value.to_s
e...
johncarney (John Carney)
07:12 AM Revision c95388a5 (git): string.c: fix method name in rdoc [ci skip]
* string.c (rb_str_equal): [DOC] fix fallback method name. the
peer's == method will be used, not ===.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57056 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
05:39 AM Misc #12976 (Closed): Update example of Hash#value? and Hash#has_value?
Thank you. shyouhei (Shyouhei Urabe)
03:19 AM Revision 9f379854 (git): test for Symbol#match? [Feature #12898]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57055 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
03:07 AM Revision e2583b17 (git): test_m17n.rb: escape
* test/ruby/test_m17n.rb (test_regexp_ascii_none): escape regexp
meta characters.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57054 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:56 AM Feature #12898 (Closed): String#match? method in addition to Regexp#match?
Applied in changeset r57053.
----------
String#match? and Symbol#match?
* string.c (rb_str_match_m_p): inverse of Regexp#match?. based on
the patch by Herwin Weststrate <herwin@snt.utwente.nl>.
[Fix GH-1483] [Feature #12898]
nobu (Nobuyoshi Nakada)
02:56 AM Revision 6dd5ee75 (git): String#match? and Symbol#match?
* string.c (rb_str_match_m_p): inverse of Regexp#match?. based on
the patch by Herwin Weststrate <herwin@snt.utwente.nl>.
[Fix GH-1483] [Feature #12898]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57053 b2dd03c8-39d4-4d8f-98f...
nobu (Nobuyoshi Nakada)
02:38 AM Revision 3f3fc018 (git): * 2016-12-12
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57052 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
02:38 AM Revision 2800e6a0 (git): re.c: char boundary
* re.c (rb_reg_match_m_p): consider char boundary. rb_str_subpos
does not adjust to the boundary if len == 0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57051 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)

12/11/2016

07:28 PM Bug #13024 (Closed): Confusing error message matching a non-ASCII string with ASCII-regex
```ruby
irb(main):001:0> "\u2603".match(/./n)
(irb):1: warning: regexp match /.../n against to UTF-8 string
=> #<MatchData "☃">
```
I actually had to read the source to discover the intention of this error (partly because I copied...
herwin (Herwin W)
02:40 PM Bug #13022 (Rejected): Nested array syntax error returns nil
marcandre (Marc-Andre Lafortune)
01:08 PM Feature #12898: String#match? method in addition to Regexp#match?
Accepted.
Matz.
matz (Yukihiro Matsumoto)
09:20 AM Misc #12976: Update example of Hash#value? and Hash#has_value?
This has been integrated, so this ticket can be closed herwin (Herwin W)
09:20 AM Revision 7e8b910a (git): parse.y: zero codepoints
* parse.y (parser_tokadd_utf8): relax restriction to allow zero or
more codepoints.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57050 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:13 AM Revision 1d51f427 (git): fix Zlib.gzip/gunzip document
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57049 b2dd03c8-39d4-4d8f-98ff-823fe69b080e naruse (Yui NARUSE)
03:24 AM Bug #13023 (Rejected): missing library when trying to install 2.3 via rvm - pointing to directory on someone computer
nobu (Nobuyoshi Nakada)

12/10/2016

10:18 PM Bug #13019: Fix st_hash* functions
It passes SMHasher (at least, little-endian variant). funny_falcon (Yura Sokolov)
09:36 PM Bug #13023 (Rejected): missing library when trying to install 2.3 via rvm - pointing to directory on someone computer
I don;t know who the Travis is but literally I cannot make 2.3.3 to work with rvm and gem.
See screenshot attached.
Didn't know where to post this.
If this is wrong group delete it.
Beyo (Sebastian Szwarc)
06:34 PM Revision 5ec23b52 (git): Updated documentation examples for Hash#value?
The same code is used for has_value? and value?, but according to
http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/43765
has_value is deprecated. Use the non-deprecated syntax in the examples.
by Herwin Weststrate <herwin@snt....
naruse (Yui NARUSE)
06:23 PM Revision 66c9bb11 (git): Add missing :nodoc: comment
We were missing a `:nodoc:` magic comment that was making automated tools show
that this method was missing documentation, when it really didn't need to be
documented.
by Devon Estes <devon.c.estes@gmail.com>
https://github.com/ruby/ruby...
naruse (Yui NARUSE)
05:47 PM Revision 548ec36c (git): * 2016-12-11
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57046 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
05:47 PM Revision 2873edea (git): Merge Onigmo 6.0.0
* https://github.com/k-takata/Onigmo/blob/Onigmo-6.0.0/HISTORY
* fix for ruby 2.4: https://github.com/k-takata/Onigmo/pull/78
* suppress warning: https://github.com/k-takata/Onigmo/pull/79
* include/ruby/oniguruma.h: include onigmo.h.
* ...
naruse (Yui NARUSE)
05:28 PM Bug #13022: Nested array syntax error returns nil
Yes, this is expected behavior. Ruby parses this as:
~~~ ruby
[[1,3], [5,6].[](11, 15), [17,22]]
~~~
And Array#[] returns nil if the starting index (11) is out of range.
jeremyevans0 (Jeremy Evans)
05:07 PM Bug #13022 (Rejected): Nested array syntax error returns nil
If you leave out a comma in a nested array, ruby returns `nil` instead of raising a SyntaxError. Is this expected behavior?
1. Create a nested array with a missing comma:
[[1,3], [5,6] [11, 15], [17,22]] #=> [[1, 3], nil, [17, 22]]
harrywhelchel (Harry Whelchel)
01:16 PM Bug #12348 (Closed): PKey::EC.public_key returns EC::Point
There is an inconsistency with other OpenSSL::PKey classes in #public_key method. However I don't think it's worth breaking backwards compatibility in order to align the behavior with the other classes, as OpenSSL::PKey::{RSA,DSA,DH}#pub... rhenium (Kazuki Yamaguchi)
01:06 PM Feature #12085 (Closed): [PATCH] openssl: document `exception: false' for *_nonblock
Applied as 5c31e7233476 at the new repository:
https://github.com/ruby/openssl/commit/5c31e7233476bec184cac239b5d36de68dbd997e
and is already imported to trunk as a part of openssl v2.0.0.
rhenium (Kazuki Yamaguchi)
01:03 PM Bug #12952 (Closed): Incompatibility of a method signature between `Float#round` and `BigDecimal#round`
mrkn (Kenta Murata)
01:03 PM Bug #12952: Incompatibility of a method signature between `Float#round` and `BigDecimal#round`
I've fixed this in bigdecimal version 1.3.0.pre, which has already been imported in trunk. mrkn (Kenta Murata)
12:37 PM Bug #8831 (Closed): test-all error: OpenSSL::SSL::SSLError: SSL_write: bad write retry
#12126 should have fixed the root cause. r42790 is already reverted (EDIT: by f542fb60add7 at GitHub ruby/openssl and imported to trunk by r56946) and RubyCI seems to be happy with this. rhenium (Kazuki Yamaguchi)
12:28 PM Bug #10166 (Closed): Problem with openssl and ext/openssl - ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-linux]
rhenium (Kazuki Yamaguchi)
12:25 PM Feature #12254 (Closed): Add SSLCiphers option to webrick ssl.rb
The patch has already been merged by r54669. rhenium (Kazuki Yamaguchi)
08:56 AM Revision 42a677c8 (git): bigdecimal: version 1.3.0.pre.2
Import bigdecimal version 1.3.0.pre.2. The full commit log is here:
https://github.com/ruby/bigdecimal/compare/v1.3.0.pre...v1.3.0.pre.2
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57044 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Kenta Murata
08:54 AM Revision 30540c56 (git): stringio.c: chomp CR
* ext/stringio/stringio.c (strio_getline): chomp CR not only LF,
as well as String#chomp.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57043 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
08:26 AM Bug #13021 (Closed): `Zlib.gunzip` modifies argument String
Applied in changeset r57042.
----------
zlib.c: replace with substring
* ext/zlib/zlib.c (zstream_discard_input): replace with unread
portion substring, not modifying the input buffer directly.
[ruby-core:78567] [Bug #13021]
nobu (Nobuyoshi Nakada)
03:48 AM Bug #13021: `Zlib.gunzip` modifies argument String
```patch
diff --git i/ext/zlib/zlib.c w/ext/zlib/zlib.c
index 78860132df..0ce14198cc 100644
--- i/ext/zlib/zlib.c
+++ w/ext/zlib/zlib.c
@@ -879,9 +879,8 @@ zstream_discard_input(struct zstream *z, long len)
z->input = Qnil;
...
nobu (Nobuyoshi Nakada)
02:00 AM Bug #13021 (Closed): `Zlib.gunzip` modifies argument String
```
% irb -r irb/completion --simple-prompt
>> RUBY_DESCRIPTION
=> "ruby 2.4.0dev (2016-12-10 trunk 57036) [x86_64-linux]"
> ...
=> true
>> gz=Zlib.gzip('test')
=> "\x1F\x8B\b\x00\xBF`KX\x00\x03+I-.\x01\x00\f~\x7F\xD8\x04\x00\x00\x...
znz (Kazuhiro NISHIYAMA)
08:26 AM Revision f46a1377 (git): zlib.c: replace with substring
* ext/zlib/zlib.c (zstream_discard_input): replace with unread
portion substring, not modifying the input buffer directly.
[ruby-core:78567] [Bug #13021]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57042 b2dd03c8-39d4-4d8f-98f...
nobu (Nobuyoshi Nakada)
08:12 AM Revision 0c83666c (git): openssl: import v2.0.1
Import Ruby/OpenSSL 2.0.1. The full commit history since 2.0.0 (imported
at r56946) can be found at:
https://github.com/ruby/openssl/compare/v2.0.0...v2.0.1
This release contains only bug fixes. Note, the first two commits since
v2.0...
rhenium (Kazuki Yamaguchi)
07:49 AM Revision 8e129373 (git): bigdecimal: import version 1.3.0.pre
Import bigdecimal version 1.3.0.pre. The full commit log of this
changes can be found at:
https://github.com/ruby/bigdecimal/compare/5c43a9e...v1.3.0.pre
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57040 b2dd03c8-39d4-4d8f-9...
Kenta Murata
07:23 AM Bug #9192 (Closed): Inconsistent comparison between Float and BigDecimal
mrkn (Kenta Murata)
07:23 AM Bug #9192: Inconsistent comparison between Float and BigDecimal
This is fixed in the latest master branch of [ruby/bigdecimal](https://github.com/ruby/bigdecimal). mrkn (Kenta Murata)
07:19 AM Bug #9689 (Closed): (BigDecimal + Float) no longer commutative due to #7176
This is fixed in the latest master branch of [ruby/bigdecimal](https://github.com/ruby/bigdecimal). mrkn (Kenta Murata)
07:14 AM Feature #12161 (Closed): Friendly BigDecimal#inspect
This is fixed in the latest master branch of [ruby/bigdecimal](https://github.com/ruby/bigdecimal). mrkn (Kenta Murata)
07:13 AM Bug #10286 (Closed): BigDecimal - inconsistency with other numeric classes
This was fixed in the latest master branch of [ruby/bigdecimal](https://github.com/ruby/bigdecimal). mrkn (Kenta Murata)
07:01 AM Bug #10613: SNI is not optional when using TLS
Which server? TLS servers conforming to the TLS/TLS extensions specification should simply ignore the extension if it is not supported. rhenium (Kazuki Yamaguchi)
06:36 AM Bug #11947 (Closed): BigDecimal#coerce: unexpected behavior with Float
This fixed on the current master branch of [ruby/bigdecimal](https://github.com/ruby/bigdecimal) repository.
So I close this issue.
mrkn (Kenta Murata)
06:25 AM Revision 2dd99307 (git): Fix grammer [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57039 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
02:36 AM Bug #12958 (Closed): Breaking change in how `#round` works
Applied in changeset r57038.
----------
internal.h: change the default rounding mode to half-up
* internal.h (ROUND_DEFAULT): changed to RUBY_NUM_ROUND_HALF_UP.
[Bug #12958] [ruby-core:78204]
* test/ruby/test_integer.rb: fix asserti...
mrkn (Kenta Murata)
02:20 AM Bug #12958: Breaking change in how `#round` works
OK, the default behavior should be kept unchanged.
Matz.
matz (Yukihiro Matsumoto)
02:36 AM Revision f72be814 (git): internal.h: change the default rounding mode to half-up
* internal.h (ROUND_DEFAULT): changed to RUBY_NUM_ROUND_HALF_UP.
[Bug #12958] [ruby-core:78204]
* test/ruby/test_integer.rb: fix assertions for the above change.
* test/ruby/test_rational.rb: ditto.
* test/test_mathn.rb: ditto.
git...
Kenta Murata
02:16 AM Revision adc9c71f (git): Fix document of gunzip and gzip [ci skip]
- fix a typo (`GzipReadr` -> `GzipReader`)
- `Zlib::GzipReader.new` does not take block
- fix encoding
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57037 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
znz (Kazuhiro NISHIYAMA)
12:21 AM Feature #13020: Zlib.gzip and Zlib.gunzip
naruse@airemix.jp wrote:
> I added Zlib.deflate/inflate [Feature #4180] before, but writing/reading gzip is still too complex.
> It should have shorthand method.

I like the convenience, but I think encouraging use of
potentially l...
normalperson (Eric Wong)

12/09/2016

10:45 PM Feature #13020 (Closed): Zlib.gzip and Zlib.gunzip
Applied in changeset r57035.
----------
Zlib.gzip and Zlib.gunzip [Feature #13020]
Encode and Decode gzip data without creating files.
naruse (Yui NARUSE)
10:37 PM Feature #13020 (Closed): Zlib.gzip and Zlib.gunzip
I added Zlib.deflate/inflate [Feature #4180] before, but writing/reading gzip is still too complex.
It should have shorthand method.
naruse (Yui NARUSE)
10:45 PM Revision 5ae717f2 (git): * 2016-12-10
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57036 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
10:45 PM Revision 583b6dc3 (git): Zlib.gzip and Zlib.gunzip [Feature #13020]
Encode and Decode gzip data without creating files.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57035 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)
10:45 PM Revision 1f63c0fc (git): Suppress warning: this use of "defined" may not be portable
Use of defined() in macro expansion is considered non portable.
https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01577.html
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57034 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)
07:25 PM Bug #12958: Breaking change in how `#round` works
I would echo 100% of what mathew murphy wrote, and also add that this negatively affects ergonomics for the vast majority of cases where one wants to not use banker's rounding. I now need to know that Ruby rounds Floats differently than ... chrisccerami (Chris Cerami)
03:31 PM Bug #12958: Breaking change in how `#round` works
For the record, I think that the new choice of default is poor.
People have a normal everyday expectation for how numbers are rounded. I claim that the expectation is that >= .5 rounds up, <.5 rounds down.
I cite as evidence:
...
meta (mathew murphy)
07:14 PM Bug #13019: Fix st_hash* functions
Yura Sokolov wrote:
> Previous implementation had an issues:
> ...
Although performance of MRI hash benchmarks are not improved by this patch, I confirm a bad behaviour of the current variant of murmur hash in MRI. A half year ago, I...
vmakarov (Vladimir Makarov)
02:02 PM Bug #13019 (Closed): Fix st_hash* functions
Previous implementation had an issues:
- macros murmur1 assumes murmur_step takes rotation value
as a second argument
- but murmur_step second argument is "next block"
- this makes st_hash_uint and st_hash_end to not mix high bits ...
funny_falcon (Yura Sokolov)
06:48 PM Feature #13017: Switch SipHash from SipHash24 to SipHash13
Since we removed recently the code switching weak/strong hashes, the speed of the strong hash (siphash24) became important.
According to my measurements on i7-4790K, Switching from siphash24 to siphash13 improves MRI hash table benchm...
vmakarov (Vladimir Makarov)
08:19 AM Feature #13017: Switch SipHash from SipHash24 to SipHash13
Eric, you are right. Excuse me for that.
Just uploaded right version.
funny_falcon (Yura Sokolov)
01:11 AM Feature #13017: Switch SipHash from SipHash24 to SipHash13
funny.falcon@gmail.com wrote:
> Feature #13017: Switch SipHash from SipHash24 to SipHash13
> https://bugs.ruby-lang.org/issues/13017

I think the wrong patch was uploaded to redmine:

> ---Files--------------------------------
> ...
normalperson (Eric Wong)
06:14 PM Bug #10613: SNI is not optional when using TLS
Is there any chance of this patch getting merged?
We're encountering this bug and are currently monkeypatching the Net::HTTP#connect method to disable SNI for the connections where it's problematic.
bschmeck (Ben Schmeckpeper)
11:07 AM Feature #12142: Hash tables with open addressing
I think the array `features` should be `static const`.
https://github.com/k-takata/Onigmo/commit/44e3c0a16da1116be641ea807c1202434b743ace
k_takata (Ken Takata)
03:25 AM Revision c047f58d (git): ruby.h: add prefix
* include/ruby/ruby.h (RB_TEST, RB_NIL_P): prefix RB to get rid of
name conflicts with other headers.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57033 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:59 AM Revision d8761cf2 (git): Adjust indent [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57032 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
02:57 AM Revision b8095e59 (git): * 2016-12-09
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57031 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
02:57 AM Revision e9a8e8ab (git): remove core#hash_merge_ary
* compile.c (compile_array_): remove m_core_hash_merge_ary which
seems unreachable, and wrong number of arguments.
* vm.c (m_core_hash_merge_ary): removed because it is never used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57...
nobu (Nobuyoshi Nakada)
01:28 AM Feature #12982: ruby 2.3.1 got crash on macos

here is the detail procedure.
https://github.com/padrino/padrino-framework/issues/2097
hunterhu (Hunter Hu)
 

Also available in: Atom