Activity
From 12/01/2016 to 12/07/2016
12/07/2016
-
11:47 PM Revision d8bcfd2b (git): Add volatile to a suppress warning.
- Without the fix, the following warning is shown:
compiling cont.c
cont.c: In function ‘rb_callcc’:
cont.c:949:39: warning: passing argument 1 of ‘cont_capture’ discards ‘volatile’ qualifier from pointer target type [-Wdiscar... -
- Applied in changeset r57020.
----------
Add clang volatile fixes from FreeBSD and NetBSD.
Use volatile instead of optnone to avoid optimization which causes
segmentation faults.
Patch by Dimitry Andric. [ruby-core:78531] [Bug #13014] -
10:03 PM Bug #13014: Adding clang volatile fixes from FreeBSD and NetBSD
- Ok, I also tested this on x86_64-freebsd12, and there it still got a segfault in `cont_capture()`. This was caused by the `stat` parameter being a pointer to a volatile int, while it should have been a volatile pointer to an int.
Here... -
- Referring to bug #12893, where segfaults were observed when compiling with recent versions of clang. In particular in cont.c, about which Shugo Maeda noted that he could reproduce this on FreeBSD. These segfaults are most likely caused...
-
- Use volatile instead of optnone to avoid optimization which causes
segmentation faults.
Patch by Dimitry Andric. [ruby-core:78531] [Bug #13014]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57020 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Dimitry Andric wrote:
> > > NetBSD pkgsrc and FreeBSD ports were fixed by adding volatile.
> ...
Adding the latter version to cont_capture() didn't work, but your full patch set did work.
Thank you!
-
- Shugo Maeda wrote:
> Yui NARUSE wrote:
> ...
Did you add it as `volatile rb_context_t *cont`, or as `rb_context_t *volatile cont`? Only the latter is correct.
Please refer to #13014 for the full patch set, including fix for `cont_n... -
04:18 PM Bug #13013: Segmentation fault
- Yes thank you. I just came back to report that. Thank you for your time.
-
04:13 PM Bug #13013 (Rejected): Segmentation fault
- You are mixing Ruby 2.0.0 and Ruby 2.3.
You are running Ruby 2.0.0 with a gem built with Ruby 2.3. -
- Using ruby 2.3.0 with rvm. Running a very basic script, with the gems in attached file. Generates the crash report, also attached. Happy to provide any more details needed to help solve this.
Tried a fresh ruby install, same problem. - 03:30 PM Revision e8914fb3 (git): * 2016-12-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57019 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:30 PM Revision 0fe7dc7a (git): fix typo in `IO#write_nonblock` example [ci skip]
- This example explains when writing a value greater than 65536,
so the value specify must be greater than 65536.
This seems to be wrong in cee7f69
Patch by: Yuji Yaginuma <yuuji.yaginuma@gmail.com>
[Fix GH-1496]
git-svn-id: svn+ssh://c... -
02:39 PM Revision 1db7b0ad (git): ruby.c: dump option
- * ruby.c (process_options): dump specified informations all, not
only first one.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57017 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/test/unit/assertions.rb (FailDesc): allow to defer
message generation, as well as other assertion methods.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57016 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r57014.
----------
Delay Utils.getservername until needed.
There is no need to call Utils.getservername when the :ServerName option is
specified, so delay Utils.getservername until needed to avoid unnecessary
DNS l... -
08:27 AM Bug #13007: Webbrick takes 5s to start when machine name looks like a real domain
- Hmm, I see. No objection for the approach then.
-
- Shyouhei Urabe wrote:
> Sad news is gethostbyname blocks under the hood in the system library, not in ruby's code.
> ...
It seems not a reverse lookup issue, but a forward lookup issue.
It sounds reasonable to delay the call of Util... - 12:59 PM Revision 06a9b6bd (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57015 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- There is no need to call Utils.getservername when the :ServerName option is
specified, so delay Utils.getservername until needed to avoid unnecessary
DNS lookups. [ruby-core:78492] [Bug #13007]
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
- * compile.c (DECL_ANCHOR, INIT_ANCHOR): make anchor name an array
and unassignable.
* compile.c (iseq_compile_each): ret is never 0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57013 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:54 AM Bug #13012 (Closed): irb fails to define a method with a reserved-word-ish keyword argument
- For example
```
def a(if:) end
```
is a valid ruby code but this doesn't work on irb.
This seems to be happening for all keywords that are listed in `RubyLex::ENINDENT_CLAUSE` -
- FYI if there are people who need this functionality: so far we have not found an appropriately sounding name of this method. It should be a method of Enumerable (not only Hash), that takes a block, and returns a Hash.
-
- * hash.c (any_hash): should return `long', because ruby assumes
the hash value of the object id of an object is `long'.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57012 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * win32/win32.c (rb_w32_home_dir): suppress sequence-point
warning, REALLOC_N re-assigns the variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57011 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- http://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable10s/ruby-trunk/log/20161206T181910Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57010 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r57009.
----------
file.c: cygwin behavior
* file.c: recent cygwin hides NTFS specific features.
[ruby-core:78497] [Bug #13008] -
- * file.c: recent cygwin hides NTFS specific features.
[ruby-core:78497] [Bug #13008]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57009 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:03 AM Revision 2201331d (git): * 2016-12-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57008 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:03 AM Revision 3826f177 (git): const pointer is not able to be free.
- * win32/file.c (rb_default_home_dir): should not be marked as const.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57007 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Martin Dürst wrote:
> @matz: Is there a good reason that `o.a = 1 rescue $!.class` is interpreted as `o.a = (1 rescue $1.class)`, while it looks to me as if `o.a = 1 if $!.class` is `(o.a = 1) if $!.class`?
> ...
I guess issue #12402 i... -
- Ryan R wrote:
> Complete removal and reinstall of openssl resolved the issue.
Good to hear that. Thank you reporting anyway.
12/06/2016
-
- based on the patch by W <wolf@wolfsden.cz>
[Fix GH-1497]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57006 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57005 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- `Thread.current` just returns a `Thread` instance, so it should be `Thread#fetch` method.
https://github.com/ruby/ruby/compare/trunk...nobu:feature/Thread%23fetch -
01:26 PM Feature #13009: Implement fetch for Thread.current
- I can not say whether this feature is important or not, but on the syntax suggestion - I like the above (on the premise that it behaves as .fetch on Hash does; I have not checked this either).
-
12:45 AM Feature #13009 (Closed): Implement fetch for Thread.current
- It's a common idiom to use a fiber-local variable, but return a default value if it hasn't been assigned. Here's an example of Ruby code I would expect to be able to write:
~~~ ruby
def feature_enabled?
Thread.current.fetch(:featu... -
02:13 PM Bug #12945: Use-after-free in vm_trace.c
- The patch is now in trunk! :)
-
- I think the issue I just reported (https://bugs.ruby-lang.org/issues/13011) might be a duplicate of this one. Jeremy Evans, could you try the patch I attached in there and see if it fixes your issue as well?
Regards. -
- Wow, that was fast, thank you Nobu! :)
-
- Applied in changeset r57002.
----------
Make `trace_running` an integer flag again
* vm_core.h (rb_vm_struct): trace_running should be a counter but
not a bit flag. [ruby-core:78514] [Bug #13011]
Author: David Rodríguez <deivid.rod... -
- After https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/55038, byebug's tests started to segfault. See, for example, https://travis-ci.org/deivid-rodriguez/byebug/jobs/130941967.
I investigated a bit and it seems to ... - 01:57 PM Revision 35573c18 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57004 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:57 PM Revision b23eac69 (git): rexml: REXML::Element#[] accepts String or Symbol as attribute name
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57003 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_core.h (rb_vm_struct): trace_running should be a counter but
not a bit flag. [ruby-core:78514] [Bug #13011]
Author: David Rodríguez <deivid.rodriguez@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57002 b2dd03c8-3... -
01:45 PM Feature #12871: Using the algorithm like math.fsum of Python for Array#sum
- Takeshi Nishimatsu wrote:
> Julia can do it, too.
> ...
Thank you for pointing the information.
I referred the paper written by A. Klein [1], and employed the algorithm in that paper.
It is the same algorithm of sum_kbn in Julia.
... -
- Applied in changeset r57001.
----------
array.c, enum.c: change sum algorithm
* array.c (rb_ary_sum): change the algorithm to Kahan-Babuska balancing
summation to be more precise.
[Feature #12871] [ruby-core:77771]
* enum.c (sum_i... - 01:40 PM Revision 48f5f591 (git): array.c, enum.c: change sum algorithm
- * array.c (rb_ary_sum): change the algorithm to Kahan-Babuska balancing
summation to be more precise.
[Feature #12871] [ruby-core:77771]
* enum.c (sum_iter, enum_sum): ditto.
* test_array.rb, test_enum.rb: add an assertion for the ... -
12:58 PM Feature #12813: Calling chunk_while, slice_after, slice_before, slice_when with no block
- After consideration, I accept this proposal.
Matz. - 12:54 PM Revision 0cb1a2b8 (git): numeric.c: fix exception message for nil rounding
- * numeric.c (rb_num_get_rounding_option): fix exception message
for the case of nil rounding mode.
* test_float.rb: add an assertion for the above change.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57000 b2dd03c8-39d4-4d8f-98f... -
- Patch by: Koichi ITO <koic.ito@gmail.com>
[Fix GH-1498]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56999 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:57 AM Revision 769b83f6 (git): Update latest bundled gems.
- * Rake 12.0.0
* minitest 5.10.1
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56998 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:34 AM Bug #13010: Tried utilizing RBENV & now RVM...from 2.3.0 to 2.3.1 to 2.3.3 - same errors over and over
- Complete removal and reinstall of openssl resolved the issue.
-
- Removed version managers just using brew for Ruby management. See below...2.3.3.
yojimbo:~ yojimbo$ gem install rails
/usr/local/Cellar/ruby/2.3.3/lib/ruby/2.3.0/net/http.rb:933: [BUG] Illegal instruction at 0x00000103af69fb
ruby 2.... -
10:56 AM Bug #13010 (Feedback): Tried utilizing RBENV & now RVM...from 2.3.0 to 2.3.1 to 2.3.3 - same errors over and over
- Judging from the backtrace, it seems something went wrong in the openssl library.
```
-- Crash Report log information --------------------------------------------
See Crash Report log file under the one of following:
* ~/Library/... -
- I've tried two different ruby managers on my new MacBook pro (sierra) and have encountered the same error over and over with the only differences in version. Can someone shed some light on this - there's nothing I could find via Google.
... -
- All right. Sounds rational. Thank you for the explanation, Mame-san and akr-san!
-
07:48 AM Bug #12994: Embedded ruby vs2015 build crashes
- Ok, but the rb_w32_sysinit function is not declared in a header file.
-
- Freddy Jilderda wrote:
> Also the function `ruby_sysinit` in ruby.c (which is the one calling `rb_w32_sysinit`) mentions in the header comment that this function should not be called by programs embedding the CRuby interpreter.
Not t... -
- * test/ruby/test_file.rb (test_realpath_encoding): EPERM can raise
on cygwin.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56997 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:28 AM Bug #13005 (Open): Inline rescue is inconsistent when rescuing NoMethodError
- @matz: Is there a good reason that `o.a = 1 rescue $!.class` is interpreted as `o.a = (1 rescue $1.class)`, while it looks to me as if `o.a = 1 if $!.class` is `(o.a = 1) if $!.class`?
(Backwards compatibility might be a reasonable go... -
- * file.c (isADS): add macro to tell if Alternate Data Stream
separator, to distinguish from drive letter.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56996 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Martin Dürst wrote:
> Nobu - One thing I don't understand is why there wasn't any test failure on CI because there is a test that checks for bug #9318.
`strong_p` argument was used only for `String`s, but the test covered only specia... -
- Applied in changeset r56992.
----------
switching hash removal
* st.h (struct st_hash_type): Remove strong_hash.
(struct st_table): Remove inside_rebuild_p and curr_hash.
* st.c (do_hash): Use type->hash instead of curr_hash.
(make... -
- Hello Victor,
Thanks for clearing up my confusing re. Bug #9381. It's too bad that that means we can't switch hashing methods.
Nobu - One thing I don't understand is why there wasn't any test failure on CI because there is a test t... -
- * test/ruby/test_file_exhaustive.rb (symlinkfile): EPERM can raise
on cygwin.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56995 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Follow r16757 ("* re.c: fix SEGV by Regexp.allocate.names,
Match.allocate.names, etc.", 2008-06-02). Don't do null dereference if
MatchData#hash or #== is called against an uninitialized instance.
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
- Avoid "ambiguous first argument; put parentheses or a space even after
`-' operator" warning in assert_in_out_err. Fixes r56992.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * st.h (struct st_hash_type): Remove strong_hash.
(struct st_table): Remove inside_rebuild_p and curr_hash.
* st.c (do_hash): Use type->hash instead of curr_hash.
(make_tab_empty): Remove setting up curr_hash.
(st_init_table_with_s... -
- * st.c (do_hash): remove unnecessary variable and cast.
* hash.c, numeric.c, st.c: adjust style and indent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * random.c (seed_keys_t, init_seed): pack seed for rb_hash_start and
rb_memhash, and fill them at once.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56990 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I did think so, but on recent cygwin, `touch c.d:12` makes a file "c.d\u{F03A}12".
Seems `:` is mapped to that Private Use Area character.
I'm not sure if we should support it now. -
- 1) Pre-2.4 usage: Killed thread can still be joined. If you call join to a killed thread, that should raise an exception. Its backtrace contains the info you want.
2) Starting from 2.4, in addition to the above, you can set Thread.r... -
- Sad news is gethostbyname blocks under the hood in the system library, not in ruby's code.
But webrick's issue might be resolved already by issue #6559. Can you try the latest trunk to see if that fixed your problem?
12/05/2016
- 11:37 PM Revision 41a7549b (git): * 2016-12-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56989 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:44 PM Bug #13002: Hash calculations no longer using universal hashing
- Martin Dürst wrote:
>
> ...
That what I thought until I saw the test you mentioned
```ruby
def test_wrapper_of_special_const
bug9381 = '[ruby-core:59638] [Bug #9381]'
wrapper = Class.new do
def initialize(obj)... -
- In Bug #9381, it claims that st searches/inserts only on hash values and equalities.
Switching hash functions hiddenly from ruby space can't be compatible with Bug #9381.
The candidates would be:
1. revert hash switching,
2. reve... -
- Hello Victor, others,
On 2016/12/04 15:28, vmakarov@redhat.com wrote:
> Issue #13002 has been updated by Vladimir Makarov.
> ...
Over the weekend, I started to think about this issue some more and to
write an email. First, I shou... -
02:59 PM Bug #13008: File::basename fails if extension contains a colon
- I don't think this is a bug. `:` is the file stream separator in NTFS (https://blogs.technet.microsoft.com/askcore/2013/03/24/alternate-data-streams-in-ntfs/). On *nix systems, you do get `c.d:12`.
-
01:41 PM Bug #13008 (Closed): File::basename fails if extension contains a colon
- ~~~
File.basename('a/b/c.d:12')
~~~
returns
~~~
c.d
~~~
but should return
~~~
c.d:12
~~~ -
- As a workaround I copy/pasted this code to the start of the _pioinfo function in win32.c (line 2462):
```C
#if RUBY_MSVCRT_VERSION >= 140
if (!__pioinfo) {
set_pioinfo_extra ();
}
#endif
-
- I'm sorry I was not clear, what I mean is I'm updating a C++ application from VS2010 to VS2015. This application embeds a ruby engine (version 1.8.6), so that users of the application can uses ruby scripting to add custom functionality t...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56986 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r56985.
----------
Don't insert an entry to loading_tbl if another thread succeed to load.
If rb_thread_shield_wait() returns Qfalse, the file has been successfully
loaded by another thread, so there is no need to ... -
- If rb_thread_shield_wait() returns Qfalse, the file has been successfully
loaded by another thread, so there is no need to insert a new entry into
loading_tbl. [ruby-core:78464] [Bug #12999]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
05:44 AM Bug #13007 (Closed): Webbrick takes 5s to start when machine name looks like a real domain
- sudo scutil --set HostName foo.local
ruby -r socket -e "Socket.gethostbyname(Socket.gethostname)"
or much simpler:
ruby -r socket -e "Socket.gethostbyname('foo.local')"
called from webrick/config.rb:24 ... Utils::getservername
... -
02:13 AM Feature #10912: Add method(s) to IPAddr for determining whether an address is link local
- Is there any progress?
In RFC 4291 2.4, the type of an IPv6 address is defined, as follows:
Address type Binary prefix IPv6 notation Section
------------ ------------- ------------- --... -
- * random.c (rb_random_ulong_limited): do not call private method
rand. [ruby-dev:49892] [Misc #13003]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56984 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/04/2016
- 11:14 PM Revision 4509b366 (git): * 2016-12-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56983 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:14 PM Revision cc2075cd (git): Increase timeout of TestRequire#test_require_with_loaded_features_pop
- unstable10s fails it because of timeout
http://rubyci.s3.amazonaws.com/unstable10s/ruby-trunk/log/20161201T161908Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56982 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Vladimir Makarov wrote:
> Although strong/weak hash approach gave about 5-6% improvement out of 45% on Ruby hash table benchmarks, I think we should not use it for Ruby. I will provide a patch to get rid of it in 2 days.
The follo... -
- Nobuyoshi Nakada wrote:
> `test_wrapper_of_special_const` failed, that is, it's impossible to emulate switching weak and strong versions under the hood.
> ...
You are right, the behavior with strong/weak hashes is wrong for Ruby. This... -
- Nobuyoshi Nakada wrote:
>
> ...
Sorry, if I understand Ruby documentation wrongly. But it (http://ruby-doc.org/core-2.3.3/Object.html#method-i-hash) says "The hash value for an object may not be identical across invocations or implem... -
- `test_wrapper_of_special_const` failed, that is, it's impossible to emulate switching weak and strong versions under the hood.
I think this behavior is quirky. -
- Vladimir Makarov wrote:
> Instead of using siphash (a secure hash function) all the time, the new hash tables use faster hash functions and when they recognize an ongoing denial attack, they are **rebuilt and switches to secure hash fun... -
- The new hash table implementation uses a different approach to deal with the denial attacks.
Instead of using siphash (a secure hash function) all the time, the new hash tables use faster hash functions and when they recognize an on... -
- When preparing for my lecture on hash tables last week, I found that Ruby trunk doesn't do universal hashing anymore. See http://events.ccc.de/congress/2011/Fahrplan/attachments/2007_28C3_Effective_DoS_on_web_application_platforms.pdf fo...
-
- ```
o.a = 1 rescue $!.class
```
is parsed as
```
o.a = (1 rescue $!.class)
```
Try
```
(o.a = 1) rescue $1.class
```
Matz. -
05:20 PM Bug #13005 (Closed): Inline rescue is inconsistent when rescuing NoMethodError
- ```ruby
o = "some object"
class << o
private
attr_accessor :a
end
# GETTER can be rescued in a begin-block or inline
begin o.a
rescue; $!.class # => NoMethodError
end
o.a rescue $!.class # => NoMethodE... -
05:43 PM Feature #13006 (Open): backtrace of thread killer
- Hello, I am right now having difficulties to understand why one thread I have is dead. Seems been killed by something (rails/puma). But there is no way I can see to understand what and why did it.
That's why I'm proposing a new featur... -
05:40 PM Feature #12745: String#(g)sub(!) should pass a MatchData to the block, not a String
- I posted this link to IRC (#ruby on freenode), just to see if anyone had a good name suggestion. The suggestions `#matchsub` and `#msub` were offered. I don't really like them, `#matchsub` sounds like it tries to subtitute a match (exact...
-
- バグでしょう。
https://github.com/ruby/ruby/compare/trunk...nobu:bug/calling-private-rand
https://github.com/ruby/spec/compare/master...nobu:bug/calling-private-rand -
04:46 AM Bug #13003 (Closed): About not Random instance of random: keyword ardument of Array#shuffle!
- Array#shuffle! の random: キーワード引数で、Randomのインスタンスでないような
任意のオブジェクトを渡してしまっていても、（最終的に）rb_random_ulong_limited 中の
rb_funcallv(obj, id_rand, 1, &lim) という呼び出しによりグローバルの rand が
呼び出されて、それっぽく動いてしまいます。
わざわざ random: キーワード引数で渡していながら、変なオブジェクトを渡してし... -
- Applied in changeset r56980.
----------
extension.rdoc: fix rb_get_kwargs [ci skip]
* doc/extension.rdoc: [DOC] optional keyword arguments are
defaulted to Qundef. ignored keys are kept in the hash but a
new Hash is not created. ... -
- きしもとです
拡張ライブラリで `rb_get_kwargs` を使おうとしたところ、いくつか変に
感じた点がありましたので、確認をお願いしたくこちらにメイルします。
もしバグでしたらチケットにまとめます。
(1) `values`を渡すと、全て変更（初期化）される。
extension(.ja).rdoc には、
> ```
> ...
とあるが、コードでは、
```C
1866 if (values) {
1867 ... -
- * class.c (rb_get_kwargs): when values are stored, corresponding
keys have been remove from the keyword hash, and the hash should
be empty in that case. [ruby-dev:49893] [Bug #13004]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... -
- * doc/extension.rdoc: [DOC] optional keyword arguments are
defaulted to Qundef. ignored keys are kept in the hash but a
new Hash is not created. [ruby-dev:49893] [Bug #13004]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56980... -
05:40 AM Revision b16d1968 (git): Revert changes on rb_frame_method_id_and_class()
- r56593 introduced backwards incompatible changes in the API.
[ruby-core:78471] [Feature #12747]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56979 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56978 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56977 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Martin Dürst wrote:
> A short additional note: If cases like these increase with future versions of Unicode, I plan to change the special treatment of U+03B9/U+03BC/U+A64B to something more data-based.
I have just done that with r569... -
- * enc/unicode.c: Remove special processing for U+03B9/U+03BC/U+A64B
(GREEK SMALL LETTERs IOTA/MU, CYRILLIC SMALL LETTER MONOGRAPH UK)
from onigenc_unicode_case_map and simplify code.
* enc/unicode/case-folding.rb: Remove check for U... -
01:49 AM Feature #12996: Optimize Range#===
- Yes, I tryed alias way.
But it was vary slow.
```
$ time ./miniruby t.rb
./miniruby t.rb 1.80s user 0.02s system 98% cpu 1.842 total
```
And another issue appeared.
```
$ make test-all TESTS="test/ruby/test_range.rb"
CC ... -
- * enc/unicode/case-folding.rb: Reorder codepoints so that the upper-case
mapping comes first.
* enc/unicode/9.0.0/casefold.h: Codepoints reordered, upper-case mapping
flag added.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@569... -
- Dump all the things! \o/
12/03/2016
- 03:41 PM Revision 1fa8bd75 (git): * 2016-12-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I hope this fix makes tests faster on Windows.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56973 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (rb_str_enumerate_lines): implement chomp option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56972 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thanks Yamaguchi-san, good catch.
I'll revert rb_frame_method_id_and_class.
-
- r56593 changed the signature of rb_frame_method_id_and_class() which is exposed to C extensions. For example, this broke ruby-prof gem. Is this intentional?
-
-
- I think this is duplicated of #12977.
And this patch cannot apply now. -
-
- Always add a space between a comma and the next element. These spaces
were there sometimes, but not always. This keeps to code consistent.
Patch by: Herwin Weststrate <herwin@snt.utwente.nl>
[ruby-core:78297] [Misc #12977] [GH-1492]
g... -
- * ext/stringio/stringio.c (strio_getline): implement chomp option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56970 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/stringio/test_stringio.rb (test_gets, test_each):
assertions for paragraph mode.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/enc/test_case_mapping.rb: Add method test_reorder_unfold to test against
problems when reordering codepoints in some entries in
CaseUnfold_11_Type CaseUnfold_11_Table.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56... - 05:09 AM Revision fc410343 (git): * 2016-12-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/enc/test_case_comprehensive.rb: Change test class name from
TestComprehensiveCaseFold to TestComprehensiveCaseMapping because the
tests are about mapping in general, not only folding
git-svn-id: svn+ssh://ci.ruby-lang.or... -
-
- In r56965, load_lock() was changed as follows:
```
switch (rb_thread_shield_wait((VALUE)data)) {
case Qfalse:
data = (st_data_t)ftptr;
st_insert(loading_tbl, data, (st_data_t)rb_thread_shield_new());
...
12/02/2016
-
09:23 PM Feature #13001 (Closed): Add `full` option to `ObjectSpace.dump_all`
- I would like to include T_NONE slots in the `ObjectSpace.dump_all` outpout so that I can visualize heap fragmentation. I've attached a patch that adds a "full" option to `dump_all` so that all slots are dumped to the JSON output, includ...
-
04:25 PM Feature #13000 (Feedback): Implement Set#include? with Hash#include?
- Why does `Set#include?` not call `Hash#include?`? Currently it calls `Hash#[]`.
The protocol of Set already use `Hash#include?` for `==`.
```diff
diff --git a/lib/set.rb b/lib/set.rb
index 43c388c..f3dbe2d 100644
--- a/lib/set.r... -
03:34 PM Bug #12507: random SEGV in kernel.system when called with long parametre list
- The issue can be reproduced with old trunk, r45357 ... r51492.
So I think it is a GC issue of ALLOCV_N, similar to [Bug #11418]. -
- Yuki Kurihara wrote:
> ## Important point
> ...
Use alias.
```C
rb_define_alias(rb_cRange, "===", "include?");
```
instead of
```C
rb_define_method(rb_cRange, "===", range_include, 1);
```
-
- The proposal is that Range#=== optimize by reducing method calls.
## Benchmark
~~~shell
$ cat t.rb
i = 0
while i < 1_000_000
case i
when 1..1000
end
i += 1
end
~~~
~~~
$ time ./miniruby -e 1
./miniruby -e 1 0... -
- TestRequire#test_require_with_loaded_features_pop fails by increasing the number of threads,
so it seems that there still exist race conditions in require.
```
lexington:ruby$ cat t/require_test.rb
require "tempfile"
Tempfile.cr... -
- With this lines.rb:
```ruby
lines = "abc\n\n\n\ndef\n"
p IO.pipe{|r,w|w.print lines; w.close; r.each_line("").to_a}
p lines.each_line("").to_a
```
```
$ ./ruby -v lines.rb
ruby 2.4.0dev (2016-12-02 trunk 56965) [x86_64-darwin15... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Valgrind reports out-of-bounds memory access while creating a Regexp object with an invalid byte sequence:
~~~
$ valgrind ruby -e'Regexp.new("\\\xD3\xD5\xBE\x1E+".force_encoding("euc-jp"))'
==21986== Memcheck, a memory error detecto... -
- * parse.y (parser_tokadd_codepoint): move error checks and add
char.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56964 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parser_tokadd_utf8): relax restriction spaces inside
"\u{...}".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56963 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Don't discard the hash value computed for the regexp object. It seems it
was simply missed out in r24754, when MatchData#hash was initially
implemented.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56962 b2dd03c8-39d4-4d8f-98ff-823...
12/01/2016
- 05:43 PM Revision cf3ff02e (git): * 2016-12-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56961 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56960 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:05 PM Feature #12871: Using the algorithm like math.fsum of Python for Array#sum
- Julia can do it, too.
~~~
julia> sum_kbn([1.0e10, 1.0e-10, -1.0e10])
1.0e-10
~~~
The source code is https://github.com/JuliaLang/julia/blob/master/base/reduce.jl .
-
- A quick hack.
* Elongation (or reallocation) of the array of partials[] when nn exeeds NUM_PARTIALS.
* Tests.
* Name of this algorithm. Kahan-Babuska-Neumaier?
are required.
~~~ diff
diff --git a/array.c b/array.c
index b99a... -
- It would be beneficial if one could do:
my_method(**hash_with_string_keys)
This for example you can read a hash from MongoDB and pass it as parameters to your method without additional processing. For example to implement per... -
- Applied in changeset r56959.
----------
String#unpack1 [Feature #12752]
Returns the first value of String#unpack. -
- Akinori MUSHA wrote:
> With a qualifier or multiple directives given, would it raise an ArgumentError or just go ahead with the process and only return the first value?
Just after processing the first value, it returns. -
10:25 AM Feature #12752: Unpacking a value from a binary requires additional '.first'
- With a qualifier or multiple directives given, would it raise an ArgumentError or just go ahead with the process and only return the first value?
-
- Go ahead.
Matz.
-
- Returns the first value of String#unpack.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56959 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Motohiro KOSAKI wrote:
> Modern OS don't have such mistake.
I can't make it sure but if environment variables are in fact kept secure for all platforms that run ruby, then I'm happy to withdraw my concern about security in ENV['http... -
12:41 PM Feature #12921: Retrieve user and password for proxy from env
- > Yuri Samoilenko wrote:
>> What do you mean when say "insecure"? Storing login and password in filesystem and then read it and pass to http request manually is secure? Insecure is availability to pass login/password in plain form like... - 01:20 PM Revision b6e137e9 (git): Remove `offset:` from `Array#pack`
- * pack.c (pack_pack): can use `@` instead of `offset:`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56958 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r56957.
----------
Supports `buffer` and `offset` in `Array#pack`
* pack.c (pack_pack): Supports `buffer` and `offset` in `Array#pack`.
[Feature #12754] [ruby-dev:49798] - 01:08 PM Revision 0dd9c302 (git): Supports `buffer` and `offset` in `Array#pack`
- * pack.c (pack_pack): Supports `buffer` and `offset` in `Array#pack`.
[Feature #12754] [ruby-dev:49798]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56957 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:15 PM Feature #12995: Conditional expression taking a receiver outside the condition
- You can do that with #tap. A very stupid example:
```ruby
array = [true]
res = array.to_a.tap do |obj|
if obj[0]
obj.replace([['true', :val]])
else
obj.replace([['false', :val]])
end
end.to_a.to_h
p res
```
... -
07:00 AM Feature #12995 (Rejected): Conditional expression taking a receiver outside the condition
- Since a conditional expression has a return value, we can continue a method chain after a conditional expression like this:
```ruby
if hoge
foo1.foo2.foo3
else
bar1.bar2
end
.baz1.baz2.baz3.baz4
```
```ruby
case hoge
w... -
- Shugo Maeda wrote:
> IBM InfoSphere and MS FoxPro have BITTEST(), but its second argument is the bit position
> ...
I didn't mean to propose this behavior.
I just meant to point out that `bittest?` may not be suitable for the proposed... -
- Yui NARUSE wrote:
> Herwin W wrote:
> ...
IBM InfoSphere and MS FoxPro have BITTEST(), but its second argument is the bit position
to be tested.
http://www.ibm.com/support/knowledgecenter/SSZJPZ_11.3.0/com.ibm.swg.im.iis.ds.basic.d... -
- Herwin W wrote:
> ```ruby
> ...
Above one.
> > There's two AND, bitwise and logical.
> ...
I can't show a use case of `|`.
`^` is maybe useful but the name is difficult. -
- * parse.y (parser_tokadd_codepoint): reject invalid codepoint,
surrogate blocks and surrogate pair, as well as mruby.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56956 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * minitest-5.10.0
* test-unit-3.2.3
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56955 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Because RubyCI on Solaris 10 failed as follows:
1) Failure:
TestProcess#test_execopts_redirect_open_fifo_interrupt_raise [/export/home/rubyci/unstable10s/tmp/build/20161130T201909Z/ruby/test/ruby/test_process.rb:646]:
<"ok\n"> e... -
- Import the following two commits from upstream:
commit 72126d6c8b88abd69c3565fc3bbbd5ed1e401611
Author: Kazuki Yamaguchi <k@rhe.jp>
Date: Thu Dec 1 22:27:03 2016 +0900
pkey: check existence of EVP_PKEY_get0()
EVP_P... -
03:55 AM Feature #12901: Anonymous functions without scope lookup overhead
- It would also be very useful for making ObjectSpace#define_finalizer easier to use (to avoid the common memory leak passing a regular proc in can cause).
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56952 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e