Activity
From 11/20/2016 to 11/26/2016
11/26/2016
-
09:13 PM Feature #12786: String#casecmp?
- Martin Dürst wrote:
> I gave an implementation in Ruby, but can somebody provide an equivalent patch in C?
The attached patch implements `#casecmp?` by calling `#casecmp` and checking whether the return value is zero. I think this p... -
- Yukihiro Matsumoto wrote:
> `casecmp?` accepted.
> ...
Thank you! -
08:45 PM Feature #12745: String#(g)sub(!) should pass a MatchData to the block, not a String
- What about `sub_md` as a name?
-
02:54 PM Feature #12982 (Feedback): ruby 2.3.1 got crash on macos
- ```
VM Regions Near 0x7fff5920fc68:
MALLOC_TINY 00007fd315800000-00007fd315a00000 [ 2048K] rw-/rwx SM=PRV
--> STACK GUARD 00007fff55a10000-00007fff59210000 [ 56.0M] ---/rwx SM=NUL stack guard for thread 0
... -
- ```ruby
if n.bittest?(0b10100000)
```
If I encountered that code without having the context of this case, I wouldn't know what what the equivalent behaviour would be:
```ruby
if n & 0b10100000 != 0 #=> Is at least one ... -
01:33 PM Bug #12981 (Closed): Date.parse raises an Argument error under a specific condition
- Date.parse cannot accept incomplete strings whose delimiter is a hyphen like: "2016-12", although it can accept if a delimiter is a slash like: "2016/12"
I'm not really sure if this is a bug or an expected behavior, but a maintainer o... -
12:08 PM Bug #12950: irb: 'input-method.rb:151: [BUG] Segmentation fault' / 'malloc(): smallbin double linked list corrupted'
- _ wanabe wrote:
> after r42402, Readline.input in IRB::ReadlineInputMethod#gets causes "Too many open files - dup (Errno::EMFILE)".
Sorry, it is not reproduced on real console. I have confirmed it on PTY.spawn only.
Ctrl-c doesn't ... -
- after r42402, Readline.input in IRB::ReadlineInputMethod#gets causes "Too many open files - dup (Errno::EMFILE)".
after r43439, the method causes SEGV.
Everything goes well without `set enable-keypad on` with any commits.
-
11:37 AM Feature #12695 (Closed): File.expand_path should resolve ~/ using /etc/passwd when HOME is not set
- Applied in changeset r56902.
----------
file.c: home directory from system
* file.c (rb_default_home_dir): resolve home directory from the
system database when HOME is not set. [Feature #12695] -
- * file.c (rb_default_home_dir): resolve home directory from the
system database when HOME is not set. [Feature #12695]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56902 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * win32/win32.c (rb_w32_home_dir): move from win32/file.c to try
special folders.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56901 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56900 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:29 AM Revision 2e2fa3dd (git): * 2016-11-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56899 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:29 AM Revision 473d0d32 (git): net/ftp: support timeout for TLS handshake.
- Net::FTP inherits ssl_socket_connect from Net::Protocol to implement timeout.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56898 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:47 AM Feature #12944: Change Kernel#warn to call Warning.warn
- Here's an updated patch that uses str_end_with_asciichar instead of just manually checking the last byte for \n.
-
- You can't compare and append the last byte simply in wide character encodings.
E.g., `str_end_with_asciichar` in io.c. -
- Here's an updated patch that uses rb_str_dup before calling rb_str_cat, so it doesn't modify a passed in string, and works with frozen strings.
-
06:16 AM Bug #12938: forwardable.rb is no longer compatible with any alternative implementation
- This is great, thanks nobu!
-
- matz, did you want to modify the Kernel#warn API? Currently, I don't think modifying the Kernel#warn API can be done in a backwards compatible way, as Kernel#warn accepts an arbitrary number of arguments and converts them all to strings...
11/25/2016
-
10:05 PM Bug #12970: == Equality of recursive sets fails
- Took me a while to understand what was going on.
The issue is that the Set would need to be rehashed. Indeed, when you add it to itself, the element you are adding is modified too.
This is, in a way, similar to:
```
a = []
s =... -
- It would help if you explained what is meant by "safe".
There is currently no valid usage of `chunk_while`, `slice_after`, `slice_before` or `slice_when` without a block and an argument, as they all raise an exception. So "extending" ... -
02:04 PM Feature #12813 (Assigned): Calling chunk_while, slice_after, slice_before, slice_when with no block
- We briefly looked at this issue in todays developer meeting but had no time to fully agree that the proposed extension is safe. We just did not reach a conclusion.
-
-
- We looked at this issue at todays developer meeting and no one (including matz who was there) was against it. I believe this is accepted.
-
03:01 PM Feature #12753: Useful operator to check bit-flag is true or false
- Herwin Quarantainenet wrote:
> I can't say the usage of `bittest?` is directly clear to me. Does it test if resulting integer is not equal to `0`? And would we have to use it this way?
> ...
Like
```ruby
if n.bittest?(0b10100000)
`... -
07:59 AM Feature #12753: Useful operator to check bit-flag is true or false
- I can't say the usage of `bittest?` is directly clear to me. Does it test if resulting integer is not equal to `0`? And would we have to use it this way?
```ruby
if (n & 0b10100000).bittest?
```
I think a name like `Integer#binar... -
07:45 AM Feature #12753: Useful operator to check bit-flag is true or false
- `bittest?` sounds reasonable. Accepted.
Matz.
-
- What about `bittest?`
-
- I understand the demand. But `and?` is an unacceptable name.
Any idea?
Matz.
-
- We looked at this issue today. It turned out that ruby do not fully implement what was needed originally now. Reopened the ticket to assign ko1.
-
-
- We (mainly mrkn and matz) discussed why Fixnum#round returns Integer today. The answer is because (unlike other languages, namely C's round(3)) in ruby we can safely store all possible return value that round can theoretically generate,...
-
- We looked at this issue at todays developer meeting. We referred issue #6539 and now we remember that each method (not the "Module meta programming" at once) should have separate considerations.
While Matz do not like `String.include... -
- We looked at this issue in todays developer meeting and had 2 feelings in common.
1. The autoload should not render NameError. It definitely is a bug that must be fixed. Ko1 is assigned.
2. Besides, we want to discourage people fr... -
-
01:31 PM Bug #12980: Time - Time to return a Rational
- I think of one philosophical reason and one practical reason.
A philosophical reason: many Time objects are inherently inexact. Since a Rational is considered exact, returning a Rational might convey the wrong message that the Time o... -
09:25 AM Bug #12980 (Feedback): Time - Time to return a Rational
-
- It is because ruby-dev:38446 by mame-san.
http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-dev/38446 -
08:26 AM Bug #12980: Time - Time to return a Rational
- Well, my assumption seems wrong.
0.5r.round also becomes 0, so this isn't really related to #12952
Still I'm wondering why Time - Time isn't Rational though. -
- Currently subtracting a Time from a Time returns a Float, which I guess causes #12952
Is there any reason this doesn't return a Rational? -
- `rb_str_cat` modifies the argument, it is unexpected to `Kernel#warn`, I think.
Also it doesn't work on a frozen string. -
- Accepted.
Matz.
-
- ping nobu.
-
- We looked at this issue at todays developer meeting but a "random subset with random size" still does not sound familiar to the attendees.
Can you show us in code how do you use such array? -
- We looked at this issue in todays developer meeting and assigned it to Yui. But no one there had implementation of this. It might need some time. Stay tuned!
-
-
- Of course it changes behaviour. A change always is. The problem is how vital this (rounding an inexact number to a yet more inexact number) is.
As far as I can see the Rails breakage only happens in views, where 30secs is shown "les... -
09:42 AM Bug #12958: Breaking change in how `#round` works
- Tests are not the only problem. I believe this change is dangerous because this code may change behavior in production without being easily noticed.
-
-
- LGTM, as long as we add a functionality to `warn` to include those info.
Matz.
-
- LGTM.
Matz.
-
- Below is PoC; it may have a path which raises an exception.
```diff
diff --git a/object.c b/object.c
index 05bef4d..5d63803 100644
--- a/object.c
+++ b/object.c
@@ -2750,17 +2750,60 @@ static VALUE
rb_f_integer(int argc, VALUE ... -
- Is there any problem with the following code?
```
Integer(str) rescue default_value
```
Matz. -
09:21 AM Misc #11904: Why was Thread.exclusive deprecated?
- shyouhei@ruby-lang.org wrote:
> P.S. we have /#{@mutex=Mutex.new}/o, so we already have such thing, to some extent at least.
Awesome, ROFL; you almost made me choke on my food!
Yes, //o is awesome, but this really takes the cake.... -
- I feel that Thread.exclusive is too big a primitive to merely initialize a mutex at a process startup. We could perhaps introduce pthread_once_t analogous more fine-grained light-weight control structure that does the job.
P.S. we ha... -
09:11 AM Feature #12612: Switch Range#=== to use cover? instead of include?
- I encountered the problem in production code, it was not strings, but specialized IPAddress class, to filter "if IP is in range" -- it was SUDDENLY 0.4 sec on each request to server spent just to `(IPAddress.new(from)..IPAddress.new(to))...
-
- I see no real-world use-case for `Range#===` with strings.
Besides that, using `cover?` behavior for string ranges would introduce incompatibility.
Matz. -
- I don't think it's worth adding which is easily done by `sub/gsub`.
Matz.
-
-
- I want to see a real-world use-case for the feature.
In addition, I don't think the name `merge` is the best for the functionality.
Matz.
-
- I'd like to keep compatibility rather than reducing confusion slightly.
In any way, modifying $LOAD_PATH on the fly is not encouraged in modern Ruby.
Matz.
-
08:47 AM Feature #12786 (Feedback): String#casecmp?
- I gave an implementation in Ruby, but can somebody provide an equivalent patch in C?
-
- I gave an implementation in Ruby, but can somebody provide an equivalent patch in C?
-
- `casecmp?` accepted.
Matz.
-
- Well, I should say `yield_self` is not very readable in context (it raises question which is "self" in that context?):
~~~ruby
construct_url(*params)
.yield_self(&method(:open))
.read
.yield_self(&JSON.method(:parse))
.to... -
- `yield_self` is OK, but I don't think we are going to add `object.{|x| ... }`.
Matz.
-
- Do you want to treat nils specially? If so, the name `left_merge` does not indicate the intention.
Besides that, you don't explain why you need `a.left_merge(b)` when we can `b.merge(a)`.
If you have additional opinions, ideas or whate... -
- Reject because it is too similar to string literals.
Matz.
-
- As the developers' meeting today, proposed syntax extension `key::"value"`.
https://github.com/ruby/ruby/compare/trunk...nobu:feature/symbol-after-keyword -
- FIY both append and prepend are in ActiveSupport: https://github.com/rails/rails/blob/master/activesupport/lib/active_support/core_ext/array/prepend_and_append.rb
-
- Accepted.
Matz.
-
- I found that a rubygems test ,`TestGemSpecification#test_initialize_copy_broken` in test/rubygems/test_gem_specification.rb, depends on this exception.
And rubyspec fails as usual.
```diff
diff --git i/object.c w/object.c
index 05b... -
- If we don't care about dup-ability much, the proposal sounds reasonable.
And I agree this dup-ability matters less than confusion caused by exceptions.
Accepted.
Matz. -
- This is a proposal resulting from a discussion in Bug #11929. Because this is proposing a different solution from #11929, it has a new number.
#11929 shows that people are confused that e.g. 3.dup throws an exception (but Integer#dup ... -
- `unpack1` looks so ad-hoc but surely is attractive.
Matz.
-
- How about `Array#unpack1` ?
-
- Accepted.
Matz.
-
07:26 AM Feature #12871 (Assigned): Using the algorithm like math.fsum of Python for Array#sum
-
- The issue closed by #12979
Matz.
-
- 1. ability to be duped cannot be checked by `respond_to?`. It's simply wrong.
2. the "fail silently" proposal is attractive, but it should be a separate proposal (for the sake of bookkeeping).
Matz.
-
- Out of Shyouhei's 4 options,
1. not acceptable for compatibility's sake
2. not excited, may cause compatibility problem. besides that, `String#scan` cannot be enhanced by this option
3. looks nice but I have performance concern
4.... -
- I understand your proposal, but I don't see what it is for.
Do you have any no-artificial use-case for this feature?
If you come up with real-world use-case, please re-open the issue.
Matz.
-
- For the time being, use `math-tau` gem.
I will add it after (and only after) it became time-proven major, probably due to Python's tau.
Matz.
-
- Accepted.
Matz.
-
- * numeric.c (round_half_down, int_round_half_down): support
round-down mode.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Agreed.
Matz.
-
- Since ?up gives a string "up", it cannot be a replacement for :up symbol.
If someone come up with an use-case for this multi-character ? string literal, I will reinvestigate.
Matz.
11/24/2016
- 08:51 PM Revision b6d10b6c (git): * 2016-11-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56896 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:51 PM Revision f6f158c6 (git): use `rb_struct_ptr` for `RSTRUCT_PTR` macro
- * include/ruby/ruby.h (RSTRUCT_PTR): at r55788, `rb_struct_const_ptr` had been hidden and `rb_struct_ptr` had been implemented for backward compatiblity. but the definition of `RSTRUCT_PTR` was not modified to use it, probably by mistak...
-
- https://github.com/ruby/ruby/pull/1492
Alway add a space between a comma and the next element. These spaces were there sometimes, but not always. This keeps to code consistent.
-
- https://github.com/ruby/ruby/pull/1491
The same code is used for has_value? and value?, but according to http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/43765 has_value is deprecated. Use the non-deprecated syntax in the... -
02:09 PM Feature #12968: Allow default value via block for Integer(), Float() and Rational()
- Nobuyoshi Nakada wrote:
> Only "invalid value for Integer()" from a string?
I don't have a strong opinion on this. -
11:44 AM Feature #12921: Retrieve user and password for proxy from env
- > Why don't you use open-uri?
Because open-uri can't treat POST, HEAD, etc.
I think it is natural that net/http gets the same parameters from env for default unspecified parameters as open-uri does.
-
- Applied in changeset r56894.
----------
marshal.c: fix infinite recursion
* marshal.c (check_userdump_arg): marshal_dump should not return
an instance of the same class, otherwise it causes infinite
recursion. [ruby-core:78289] [B... -
- ```
zsh % lldb -- ./miniruby -v tmp.rb
(lldb) target create "./miniruby"
Current executable set to './miniruby' (x86_64).
(lldb) settings set -- target.run-args "-v" "tmp.rb"
(lldb) run
Process 91881 launched: './miniruby' (x86_64... -
- ```ruby
Hash.include Module.new {
def marshal_dump
dup
end
def marshal_load this
initialize_copy this
end
}
p Marshal.load(Marshal.dump(foo:"bar"))
```
This script dumps core. -
- * marshal.c (check_userdump_arg): marshal_dump should not return
an instance of the same class, otherwise it causes infinite
recursion. [ruby-core:78289] [Bug #12974]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56894 b2dd03c8... -
- * marshal.c (w_object): should not decrement negative limit which
means unlimited.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56893 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:19 AM Bug #12975 (Closed): Edit documentation for IO#print function
- Important changes made:
* Delete a duplicate sentence relating to a description of global variable $_
* Split the whole paragraph into three semantically related smaller ones.
To make it easier to digest the content.
* Emphasize name... -
- * test/fileutils/test_fileutils.rb (assert_output_lines): ensure
that write pipe is closed, not the reader thread to deadlock
when an exception raised in the given block.
[ruby-core:78053] [Bug #12910]
git-svn-id: svn+ssh://ci.rub... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56891 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:41 AM Bug #12910: TestFileUtils#test_chown_R_force might get stuck when process has no supplementary groups
- Thx for fixing this. But is there chance to improve my first point? I.e. why the test suite gets stuck? It should just fail. The assert apparently failed, so the test case should fail ....
-
- Shugo Maeda wrote:
> ```ruby
> ...
It might be better to swap `dst_*` and `src_*`.
11/23/2016
- 11:57 PM Revision 214eecd3 (git): resolv: use safe navigation operator to avoid extra hash lookups
- @addr2name is a private Hash and never changes its default_proc,
so only pay the hash lookup cost once; we know missing entries
in the hash will be nil.
* lib/resolv.rb (each_name): use safe navigation operator
git-svn-id: svn+ssh://ci... - 11:14 PM Revision 376e57fe (git): webrick/server: use symbol proc
- Symbol proc is less code and avoids confusion from variable
naming.
* lib/webrick/server.rb (shutdown): use symbol proc
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- require_relative speeds up loading of files by reducing path
lookups. On a clean install with RubyGems-enabled,
"ruby -rnet/http -e exit" shows a reduction in failed open(2)
syscalls from 410 to 350 (x86-64 GNU/Linux).
I could not... -
08:48 PM Bug #12910: TestFileUtils#test_chown_R_force might get stuck when process has no supplementary groups
- ruby_2_3 r56888 merged revision(s) 56884.
-
- Applied in changeset r56884.
----------
test_fileutils.rb: Use primary group too
* test/fileutils/test_fileutils.rb (TestFileUtils#setup): Use
primary group as well as supplementary groups. based on the
patch by Vít Ondruch at [ru... -
- > For some reason, the test expects there will be some supplementary groups available, but there are non in the container. The following patch makes the test suite pass, although it apparently doesn't test everything, since some tests ex...
-
- test_fileutils.rb: Use primary group too
* test/fileutils/test_fileutils.rb (TestFileUtils#setup): Use
primary group as well as supplementary groups. based on the
patch by Vit Ondruch at [ruby-core:78053]. [Bug #12910]
... -
- ruby_2_3 r56887 merged revision(s) 56881.
-
- Fixed in r56881.
-
- TestDir_M17N#test_glob_encoding if the current locale is neither C nor *.UTF-8:
```
$ make test-all TESTS="test/ruby/test_dir_m17n.rb -n /test_glob_encoding/" LC_ALL=en_US
(snip)
[1/1] TestDir_M17N#test_glob_encoding = 0.00 s
1)... -
- Don't encode to UTF-8 if it's unnecessary.
If the file system encoding is ISO-8851-1 or if the encoding of the target
string is invalid, don't encode to UTF-8. [ruby-core:78271] [Bug#12972]
git-svn-id: svn+ssh://ci.rub... -
07:16 PM Feature #3944: Add Fiber#root? method
- I also need Fiber#root?. My Scenario looks similar to the ones above, but I'm not using EM:
I have a loop watching sockets. This loop runs in a fiber. Each time a socket is readable another fiber is created to handle the request.
S... -
05:37 PM Bug #11531: IPAddr#== implements wrong logic
> IPAddr represents an IP address, not an IP network, so it does not consider a difference in netmasks as significant.
I disagree that IPAddr represents an IP address (I think a more accurately represents a CIDR block). To add to B...- 03:10 PM Revision d7f6ef94 (git): * 2016-11-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56885 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- sole box wrote:
> can we implement support for fxp ? its an extension of the ftp protocol , looks like a legit thing to have no?
Do you have a specific interface in mind?
I came up with the following interface, but there may be a be... -
- sole box wrote:
> Martin Dürst wrote:
> ...
Great!
> btw , who do i assign it to then?
See https://bugs.ruby-lang.org/projects/ruby/wiki/MaintainersStdlib.
-
03:28 AM Feature #12966: net/ftp to include fxp support?
- Martin Dürst wrote:
> sole box wrote:
> ...
ok martin,
ill implement it gladly , btw , who do i assign it to then?
-
- * test/fileutils/test_fileutils.rb (TestFileUtils#setup): Use
primary group as well as supplementary groups. based on the
patch by Vít Ondruch at [ruby-core:78053]. [Bug #12910]
It might happen in certain environments (systemd-nsp... -
10:37 AM Bug #10774: Regression: URI::MAilTo#to_mailtext - undefined method unescape for URI::RFC3986_Parser
- This is still happening on trunk/2.4 previews. Any news of getting this fixed after over two years? After all, it makes this function fail in all cases. This blocks migration of an existing codebase from Ruby 2.1 for me.
- 08:10 AM Revision c0bc825b (git): lib/net/ftp: fix typo
- * lib/net/ftp.rb (shutdown): fix typo
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56883 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r56882.
----------
rescue Errno::EPROTOTYPE in FTPTest#test_list_read_timeout_exceeded.
Errno::EPROTOTYPE is sometimes raised on Mac OS X 10.10.
[ruby-core:78066] [Bug #12914] -
- Errno::EPROTOTYPE is sometimes raised on Mac OS X 10.10.
[ruby-core:78066] [Bug #12914]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- If the file system encoding is ISO-8851-1 or if the encoding of the target
string is invalid, don't encode to UTF-8. [ruby-core:78271] [Bug#12972]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56881 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- Only "invalid value for Integer()" from a string?
`Integer` can raise exceptions other than `ArgumentError` against a string, for example.
```ruby
Integer(nil) #=> can't convert nil into Integer (TypeError)
Integer(Objec... -
- I'd consider it a bug.
https://github.com/nobu/ruby/tree/bug/12926-chomp-l -
-
- In that case, BufferedSSLSocket#read in FTP#close exceeded timeout because
BufferedSSLSocket#shutdown did nothing. So BufferedIO#rbuf_fill is
overridden in BufferedSSLSocket to raise an EOFError if the connection is
shut down.
git-svn-... -
- Applied in changeset r56879.
----------
Add a new optinal argument pathname to FTP#stat.
Based on the patch by soleboxy.
[Fix GH-1478] [ruby-core:78240] [Feature #12965] -
- Based on the patch by soleboxy.
[Fix GH-1478] [ruby-core:78240] [Feature #12965]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56879 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/22/2016
-
11:44 PM Revision 5660bb92 (git): Use `&.` instead of `if` and `? :`
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (parse_qmark): warn `?` with unbalanced space, which is
interpreted as a conditional operator.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:11 PM Revision 200d9c06 (git): * 2016-11-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- You have to define the instance method, not setting instance variables on `Observable` module.
For example:
```ruby
module Initializer
def initialize(*)
@observer_peers ||= {}
@observer_state ||= false
su... -
07:21 PM Feature #12971: (Refactoring) Remove `defined?` checks from observer.rb
- can be closed also =\
-
- Github Pull Request: https://github.com/ruby/ruby/pull/1489
-
- Remove `defined?` checks from observer.rb
- Contains less code
- Easier to understand Observable logic
- No performance downgrade -
10:21 PM Feature #12901: Anonymous functions without scope lookup overhead
- ko1 mentioned a similar possibility in his RubyConf talk about Guilds. An "isolated proc" would be a good option to pass between guilds (since it doesn't depend on its binding).
https://youtu.be/mjzmUUQWqco?t=34m26s -
- Shouldn't this produce Symbol keys?
-
06:48 PM Misc #11904: Why was Thread.exclusive deprecated?
- I came here cause I was curious why Thread.exclusive was deprecated, and didn't find an answer!
But for anyone else curious about the answer to Tony's original question (Tony has probably long since figured it out), I think you can _c... -
-
- I found that this is fixed by r55123
-
04:42 PM Bug #12970 (Closed): == Equality of recursive sets fails
- Comparing recursive arrays and hashes with equal? contents (save for the recursive element) using == succeeds.
However, using == to compare two recursive sets with equal? contents fails. I expect that to succeed.
See the attached scr... -
- * IOError does not happen even if another thread closes io
* Use symbol proc
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56874 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:40 AM Bug #3648 (Closed): Bignum Incomparable with Float::INFINITY
-
- The concrete use case that I got was that I wanted to replace all trailing whitespace, but leave tabs/newlines etc untouched. The current code looks like this:
```ruby
newstr = str.sub(/ +$/, '')
```
I tried to see if there was a... -
- I think it's possible. Just wonder if there are cases where it is useful.
-
- `String#strip` and related methods have a hardcoded match on whitespace, defined as "null, horizontal tab, line feed, vertical tab, form feed, carriage return, space". It would be nice to allow a parameter to specify the characters you w...
-
- +1 I like this idea. It must also be backwards compatible.
-
- Alexei Matyushkin wrote:
> To make it possible to fallback to e.g. `#to_i` it would be great to receive an actual argument as block parameter:
Absolutely, I've mentioned that in the last sentence. -
10:07 AM Feature #12968: Allow default value via block for Integer(), Float() and Rational()
- Stefan Schüßler wrote:
> ```ruby
> ...
To make it possible to fallback to e.g. `#to_i` it would be great to receive an actual argument as block parameter:
```ruby
# ⇓⇓⇓⇓⇓
Integer('foo') { |val| val.to_i }
``` -
- `Kernel` provides the global conversion functions `Integer()`, `Float()` and `Rational()`. Each one convert its argument to the respective type.
Parsing errors are signaled by raising a `TypeError` or an `ArgumentError`.
I often us... -
- I don't really see how this would be any different from `match?`
Beside that, the semantics are a bit ambiguous. `"foo".sub(/bar/, 'x')` does work, it just doesn't replace anything because there is no match for the regex. So would `su... -
- Sorry, I feel difficulty understanding your request. What is wrong with normal regexp matches? Be a bit more descriptive about what is wanted.
-
- sole box wrote:
> can we implement support for fxp ? its an extension of the ftp protocol , looks like a legit thing to have no?
Probably yes. Why don't you (or somebody else) go ahead and implement it, maybe as a gem, and then we ca... -
- can we implement support for fxp ? its an extension of the ftp protocol , looks like a legit thing to have no?
-
06:08 AM Feature #12967 (Rejected): Add a default for RUBY_GC_HEAP_GROWTH_MAX_SLOTS out-of-the-box
- As it stands Ruby heaps grow at a rate that is too fast for the vast majority of applications that use Ruby.
```
def rss
_,rss = `ps ax -o pid,rss | grep '#{Process.pid} '`.split(/\s+/)
rss.to_i
end
def heap_length
G... - 05:21 AM Revision b920d954 (git): complex.c: optimize f_gt_p some cases
- * complex.c (f_gt_p): optimize f_gt_p for specific types of arguments.
* internal.h (rb_int_gt, rb_float_gt, rb_rational_cmp): exported.
* numeric.c (rb_float_gt): rename from flo_gt and be exported.
* numeric.c (rb_int_gt): rename fr... -
- SSLSocket#send is not defined, so use #write instead. flags and dest are
ignored.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56871 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:54 AM Revision 5a5cc211 (git): complex.c: optimize Kernel#Complex
- * complex.c (nucomp_f_complex): use nucomp_s_convert directly.
* complex.c (id_convert): removed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56870 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:16 AM Revision 3dd92421 (git): webrick/server: simplify Daemon.start
- Process.daemon exists since Ruby 1.9.1 and does most of what we need.
* lib/webrick/server.rb (Daemon.start): simplify
[Misc #12937]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56869 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/21/2016
- 11:50 PM Revision 6d7dc8f7 (git): resolv: use symbol proc when possible
- This reduces both human code and bytecode.
lib/resolv.rb (sender_for, Config.parse_resolv_conf): use symbol proc
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:50 PM Revision 0514a747 (git): socket: use symbol proc for IO#close loops
- Made possible by r56795, this reduces human and byte code size.
* ext/socket/lib/socket.rb (self.ip_sockets_port0,
self.tcp_server_sockets_port0,
self.tcp_server_sockets,
self.udp_server_sockets): use symbol proc
git-svn-id: svn+... - 11:13 PM Revision e3c28856 (git): lib/open3: favor symbol proc when possible
- It reduces both human and machine code; as well as reducing
the confusion from variable naming.
* lib/open3.rb (popen_run, pipeline, pipeline_run): avoid capture
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56866 b2dd03c8-39d4-4d8... - 11:05 PM Revision f845a9ef (git): lib/*: remove closed checks
- Follow r56795. Since Ruby 2.2, calling #close on a closed
socket no longer raises exceptions.
* lib/cgi/session.rb (update): remove closed? check
* lib/net/http.rb (finish, transport_request): ditto
* lib/net/imap.rb (disconnect): ditt... - 10:45 PM Revision 8e4c8e96 (git): * 2016-11-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y: tCHAR can be concatenated.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- hey , in the ftp rfc one can choose to use "STAT" raw command with a path as a parameter.
the result is the same as list only faster and over the control plane (i.e the same tcp session)
this feature can help developers make faster im... -
09:28 PM Feature #12964 (Feedback): Add sub? and gsub? method to string class.
- The sub? and gsub? method would allow you to check if you can sub or gsub the string.
-
- nobu@ruby-lang.org wrote:
> It's intentional that many objects (classes, methods, etc) are not freed.
> Probably it's better to tell valgrind not to report such things.
> Patches are welcome.
100% agreed, valgrind suppression file... -
- Attached results of valgrind on openSUSE 13.2 and Ruby 2.1 package.
-
- It's intentional that many objects (classes, methods, etc) are not freed.
Probably it's better to tell valgrind not to report such things.
Patches are welcome. -
- I'm working on it in https://github.com/ruby/bigdecimal/pull/15
-
- I think the current behavior is the correct one.
```
$ ruby -rbigdecimal -ve 'p Gem::Dependency.new("bigdecimal").to_spec.version.to_s; puts ("0.50"..."0.60").map {|x| [x, BigDecimal(x).round(0, BigDecimal::ROUND_HALF_DOWN).to_s("F")... -
- I'm working on it in https://github.com/ruby/bigdecimal/pull/14
-
- Now Symbol as keyword argument is often used, but a space is required between the label and the symbol literal.
```ruby
x.round(half: :up)
```
Or using a String argument,
```ruby
x.round(half:"up")
```
Both don't feel nic... -
- * lib/net/ftp.rb (Net::FTP#initialize): [DOC] fix type in option
name, :username is used but :use is not.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56860 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_3 r56858 merged revision(s) 53668.
-
- * lib/tempfile.rb (Tempfile#initialize): [DOC] the first parameter
`basename` is optional and defaulted to an empty string since
[GH-523]. [Fix GH-1225]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3... -
05:02 AM Revision 4081b34d (git): net/http: avoid writing/reading from unstarted SSL socket
- When net/http connects to an HTTPS server through a CONNECT proxy, it
writes the CONNECT request to an unconnected OpenSSL::SSL::SSLSocket.
OpenSSL::SSL::SSLSocket traditionally fallbacks to a method call on the
underlying IO object if ... -
-
- * parse.y (strings): tCHAR is not a subject of string literal
concatenation and string interpolation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56856 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:17 AM Revision fd87a1c1 (git): * 2016-11-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56855 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * numeric.c (rb_num_get_rounding_option): refine error message at
invalid rounding mode.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56854 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/20/2016
-
- Problem is, when you allow LambdaProc.new, that have to accept non-lambda procs, like LambdaProc.new(&nonlambda). This way, a proc would be converted from/between lambda and non-lambda.
This is not a good idea. Right now a lambda is... -
- * proc.c (proc_to_s): move just after the rdoc comment.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56853 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * proc.c (NO_CLOBBERED): suppress clobbered warning which appears
only on mingw.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56852 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56851 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/win32ole/win32ole.c (g_ole_initialized): compare with 0
instead of cast to get rid of pointer-to-int-cast warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56850 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:19 AM Revision 935f8255 (git): get rid of test failures introduced at r56848
- * ext/rubyvm/lib/forwardable/impl.rb: remove an unused variable definition to
get rid of a warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r56848.
----------
forwardable/impl.rb
* lib/forwardable/impl.rb (_valid_method?, _compile_method):
extract to separate implementation specific part.
[ruby-core:78138] [Bug #12938] -
- * lib/forwardable/impl.rb (_valid_method?, _compile_method):
extract to separate implementation specific part.
[ruby-core:78138] [Bug #12938]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56848 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Because @sock.remote_address fails if @sock is an SSLSocket.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- dota? =op dota? =op wrote:
> ok i traced down the problem to this line on my .inputrc
> ...
I could reproduce it by the inputrc with recent 2.3 and trunk.
And libreadline7 seems same.
```
-- Machine register context --------------... -
- SSLSocket#stop is a private method and cannot be called, but explicit calls
are not necessary because SSL_shutdown() is called from SSLSocket#close.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56846 b2dd03c8-39d4-4d8f-98ff-823fe69...