Activity
From 11/14/2016 to 11/20/2016
11/20/2016
-
01:38 PM Feature #12957: A more OO way to create lambda Procs
- Problem is, when you allow LambdaProc.new, that have to accept non-lambda procs, like LambdaProc.new(&nonlambda). This way, a proc would be converted from/between lambda and non-lambda.
This is not a good idea. Right now a lambda is... -
10:52 AM Revision 2a546caa (git): proc.c: enable Proc#to_s rdoc
- * proc.c (proc_to_s): move just after the rdoc comment.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56853 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * proc.c (NO_CLOBBERED): suppress clobbered warning which appears
only on mingw.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56852 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:11 AM Revision 714d72c9 (git): Remove an unused variable to suppress a warning.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56851 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/win32ole/win32ole.c (g_ole_initialized): compare with 0
instead of cast to get rid of pointer-to-int-cast warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56850 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:19 AM Revision 935f8255 (git): get rid of test failures introduced at r56848
- * ext/rubyvm/lib/forwardable/impl.rb: remove an unused variable definition to
get rid of a warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r56848.
----------
forwardable/impl.rb
* lib/forwardable/impl.rb (_valid_method?, _compile_method):
extract to separate implementation specific part.
[ruby-core:78138] [Bug #12938] -
- * lib/forwardable/impl.rb (_valid_method?, _compile_method):
extract to separate implementation specific part.
[ruby-core:78138] [Bug #12938]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56848 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Because @sock.remote_address fails if @sock is an SSLSocket.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- dota? =op dota? =op wrote:
> ok i traced down the problem to this line on my .inputrc
> ...
I could reproduce it by the inputrc with recent 2.3 and trunk.
And libreadline7 seems same.
```
-- Machine register context --------------... -
- SSLSocket#stop is a private method and cannot be called, but explicit calls
are not necessary because SSL_shutdown() is called from SSLSocket#close.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56846 b2dd03c8-39d4-4d8f-98ff-823fe69...
11/19/2016
-
11:51 PM Bug #12959 (Closed): win32ole has a libgcc dll dependency when newer GCC version use
- Applied in changeset r56844.
----------
* ext/win32ole/win32ole.c: independent of libgcc_s_seh-1.dll [Bug #12959]
Thanks to Tsuyoshi Morita for bug report. -
01:29 AM Bug #12959 (Closed): win32ole has a libgcc dll dependency when newer GCC version use
- win32oleだけが、libgcc_s_seh-1.dllに依存してしまいます。
以下はMinGW-w64 の環境での確認結果です。
~~~~
tsuyoshi@jupiter MINGW64 ~/ruby24_build
$ find . \( -name "*.dll" -o -name "*.so" \) | while read -r f; do \
echo "Checking: $f"; \
objdump -x $f | eg... - 11:51 PM Revision 279deb60 (git): * 2016-11-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56845 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Thanks to Tsuyoshi Morita for bug report.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:21 PM Bug #12950: irb: 'input-method.rb:151: [BUG] Segmentation fault' / 'malloc(): smallbin double linked list corrupted'
- dota? =op dota? =op wrote:
> Nobuyoshi Nakada wrote:
> ...
it does happen on 2.3.2 too:
`ruby 2.3.2p217 (2016-11-15 revision 56796) [x86_64-linux]` -
11:09 PM Feature #12962: Feature Proposal: Extend 'protected' to support module friendship
- Robert A. Heiler wrote:
> The terminology is a bit peculiar - friendly modules? Do we have unfriendly modules as well?
> ...
It has slightly different semantics (more in line, IMO, with ruby's existing definitions of private & protecte... -
05:34 PM Feature #12962: Feature Proposal: Extend 'protected' to support module friendship
- The terminology is a bit peculiar - friendly modules? Do we have unfriendly modules as well?
Is that a new terminology altogether? I never read friend-methods before.
However had, leaving aside the choice of names, I do not like synt... -
- Draft implementation:
```diff
diff --git a/include/ruby/intern.h b/include/ruby/intern.h
index 8776a59..fa5b1dc 100644
--- a/include/ruby/intern.h
+++ b/include/ruby/intern.h
@@ -588,6 +588,7 @@ VALUE rb_any_to_s(VALUE);
VALUE ... -
- When working on a larger library, with many classes that have both official API methods and internal supporting methods, it can be hard to distinguish between them.
In Rails, for example, we currently do this using `:nodoc:` -- if a m... -
- I am not sure how easy it is for the ruby core team to reproduce it.
-
- Also see the discussion in https://bugs.ruby-lang.org/issues/12548 - ruby version changed
from 2.3.x to 2.4.x, so I think the change is fine. Default similar behaviour can be expected
e. g. from 2.3.1 to 2.3.9 and such. Otherwise you'... -
12:20 PM Bug #12961 (Closed): Bad value for range using infinity for Date or Time
- How to reproduce:
~~~ ruby
-Float::INFINITY...Float::INFINITY # works
Date.today...Float::INFINITY # works
-Float::INFINITY...Date.today # fails with "ArgumentError: bad value for range"
Time.now...Float::INFINITY #fails with "Arg... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56843 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:51 AM Feature #12960: [psych] new visitor class to generate custom object instead of Hash
- makoto kuwata wrote:
> (I can't find any button to close this issue. Please close this.)
The status is already "Third Party's Issue". You can think about this as a subcategory of "Closed". -
08:38 AM Feature #12960: [psych] new visitor class to generate custom object instead of Hash
- Nobuyoshi Nakada wrote:
> Please send to the [upstream](https://github.com/ruby/psych).
I understand. Thx.
(I can't find any button to close this issue. Please close this.)
-
- Please send to the [upstream](https://github.com/ruby/psych).
-
- I create a patch to define new useful visitor class for Psych.
It generates custom object as mapping data instead of Hash.
Normally, you must access YAML document data like `ydoc["foo"]["bar"]["baz"]`.
Using this class, you can acce... -
07:32 AM Bug #12956: require a native library that yields the error 'incompatiable library version' shuts down the interpreter fatally
- Thanks Nobuyoshi Nakada.
That was really fast. Looking forward to the next release containing this patch :)
Do you have an eta for this? -
- Applied in changeset r56832.
----------
dln.c: raise LoadError
* dln.c (dln_load): raise LoadError instead of fatal error on
recent OSX, dlclose seems fixed in El Capitan or later.
[ruby-core:78200] [Bug #12956] -
- Thank you for heading up.
I found that it works on OS X El Capitan too.
It was OS X Yosemite when I added that line (May 2015), and probably `dlclose` was fixed in El Capitan. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56842 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:24 AM Bug #12938: forwardable.rb is no longer compatible with any alternative implementation
- This should be fixed before 2.4, so JRuby does not have to ship an old version of forwardable.rb.
-
05:25 AM Bug #12927: SIGSEGV during GC marking of sym procs
- I ask ko1 and nobu to review the pull request and there's no objection.
I've merged it into ruby_2_3 branch at r56841.
Emiliano, thank you for your report and investigations in detail. -
- [ruby-core:78100] [Bug #12927]
Based on the patch provided by Emiliano Ritiro.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56841 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * include/ruby/ruby.h (RBIGNUM_SIGN): use a wrapper function to
return the sign bit, instead of comparing with 0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56840 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56839 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Backported r56267 and r56268 (based on a patch provided Aaron) into ruby_2_3 at r56838.
-
- based on a patch provided by Aaron Patterson.
assertions.rb: success option
* test/lib/test/unit/assertions.rb (assert_in_out_err): add
success option to check the exit status.
* iseq.c (iseqw_s_compile_file):... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56837 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:29 AM Revision 1029d32c (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- If the :ssl options is specified, the control connection is protected with
TLS in the manner described in RFC 4217. Data connections are also
protected with TLS unless the :private_data_connection is set to false.
git-svn-id: svn+ssh:/... -
- * math.c (exp1, exp2): use immediate 0 instead of rb_mMath, which
is never used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56833 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * dln.c (dln_load): raise LoadError instead of fatal error on
recent OSX, dlclose seems fixed in El Capitan or later.
[ruby-core:78200] [Bug #12956]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56832 b2dd03c8-39d4-4d8f-98ff-823... -
12:09 AM Feature #12901: Anonymous functions without scope lookup overhead
- On 19/11/2016, justcolin@gmail.com <justcolin@gmail.com> wrote:
> Issue #12901 has been updated by Colin Fulton.
>
> This would be a fantastic feature. I second the idea of something like
> `function { }`, `func { }`, `<> { }`, `-->...
11/18/2016
-
- Please report it to the [upstream](https://github.com/flori/json).
-
03:31 PM Bug #12955 (Third Party's Issue): BigDecimal::INFINITY and BigDecimal::NAN to_json and as_json should error out similar to Float::INFINITY and Float::NAN
- Currently, `Float::INFINITY` and `Float::NAN` error out when we try to convert them into JSON representation using `as_json` or `to_json` based on the following code from /ruby/ext/json/generator.c
~~~ c
if (!allow_nan) {
... -
09:53 PM Bug #12958: Breaking change in how `#round` works
- Thank you for the links. While I agree with the reasoning in #12438, I believe changing the default behavior is dangerous in a minor version.
The downside of changing the default behavior is that now applications using `round` without... -
08:43 PM Bug #12958: Breaking change in how `#round` works
- This is an intended change, see #12548 and
https://github.com/ruby/ruby/blob/8d7c380216809ba5bd4a3eec41d7dda61f825ffa/NEWS#L73-L74 -
- We noticed in the Rails test suite that there is a breaking change in how `#round` works between 2.3 and 2.4
https://github.com/rails/rails/pull/27091
Is that desirable?
I think it is may cause a lot of problem if the behavior o... -
07:09 PM Feature #12957 (Feedback): A more OO way to create lambda Procs
- Currently to create a lambda Proc one has to use `lambda { }` or `-> { }`. For doing metaprogramming it would be nice to have a more OO way to generate them. Something like `LambdaProc.new`. That way one could write:
```ruby
class Me... -
- This would be a fantastic feature. I second the idea of something like `function { }`, `func { }`, `<> { }`, `--> { }`, `->> { }`, or `<-> { }`.
Would these behave like regular Procs or lambda Procs when it comes to return semantics a... -
- I would like to rescue from this in ruby-code.
Looking at the source in dln.c around line 1334 shows, that there is a special APPLE define with a comment that suggests, that properly cleaning up with dlclose crashes.
Disabling the spec... -
03:46 PM Feature #12676: Significant performance increase, and code conciseness, for prime_division method in prime.rb
- I refactored the last version, prime_division9, to make it simpler, which
also makes it a litlle faster. I put the base_primes factors testing in a
new int_generator2 version, which DRYs out that process into one place.
init_genera... -
- Nobuyoshi Nakada wrote:
> I can't reproduce it with recent 2.3 and libreadline6-6.3-8ubuntu8.
> ...
in a few days, yes -
- ok i traced down the problem to this line on my .inputrc
```
set enable-keypad on
```
i couldnt reproduce the issue after commenting it out. tested about ten tiems commenting/uncommenting and it was consistent.
inputrc attached. -
- I can't reproduce it with recent 2.3 and libreadline6-6.3-8ubuntu8.
Could you try 2.3.2? -
03:31 PM Revision 8d7c3802 (git): * NEWS: Added entry for optimized Rational. [Feature #12484] [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56831 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:17 PM Revision c151aa88 (git): complex.c: optimize f_negate
- * complex.c (f_negate): optimize for special numeric types.
* complex.c (nucomp_expt): use rb_int_uminus instead of f_negate for
fixnum value.
* internal.h (rb_float_uminus, rb_rational_uminus): exported.
* numeric.c (rb_float_uminu... - 03:04 PM Revision 63262273 (git): * 2016-11-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56829 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:04 PM Revision 608c44e0 (git): rational.c: optimization and refactoring
- * rational.c (nurat_s_new_bang, nurat_canonicalize): small optimization
by using rb_int_uminus instead of f_negate.
* rational.c (nurat_canonicalize): add assertions for parameters.
* rational.c (f_negate, id_negate): removed.
git-s... -
02:51 PM Bug #12954 (Closed): valgrind shows memory leaks
- I found that ruby itself is leaking plenty memory
in ruby2.2, ruby2.1 and ruby1.9
The only version without such leakage was ruby1.8.
Steps To Reproduce on openSUSE Tumbleweed:
zypper mr -e repo-debug
zypper in --no-recommends valg... - 02:24 PM Revision a94b625f (git): complex.c: refactoring
- * complex.c (nucomp_abs): use rb_math_hypot directly.
* complex.c (nucomp_arg): use rb_math_atan2 directly.
* complex.c (imp2, m_{atan2,hypot}_bang, m_hypot): removed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56827 b2dd03c8-3... -
11:05 AM Revision d723bfc0 (git): objspace.c:: indent [ci skip]
- * ext/objspace/objspace.c (memsize_of_m): adjust indent of comments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56826 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56825 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It is a very delicate question if this is a bug. According to RFC7159 section 9 https://tools.ietf.org/html/rfc7159#section-9, a JSON parser is explicitly allowed to extend JSON. So this could perhaps be an extension made by the JSON p...
-
04:42 AM Bug #12951 (Third Party's Issue): JSON.parse allows invalid string escapes
- According to jq and jsonlint, the following JSON is invalid:
~~~
{"x":"\$"}
~~~
but JSON.parse will parse it without complaint:
~~~
irb(main):002:0> JSON.parse('{"x":"\$"}')
=> {"x"=>"$"}
~~~ -
- https://github.com/ruby/ruby/compare/trunk...nobu:feature/round-down
-
- I learned that The Japanese Ministry of Health, Labor and Welfare requires that the insured burden amount of employment insurance be calculated in round half down mode. Details: http://www.mhlw.go.jp/topics/2005/04/tp0425-2.html
Give... -
- We can not call `BigDecimal("0.5").round(half: :up)`.
This prevents us from duck typing Float objects and BigDecimal objects.
```ruby
irb(main):001:0> require "bigdecimal"
=> true
irb(main):002:0> 0.5.round(half: :up)
=> 1
irb(m... -
- * internal.h (ROUND_FUNC, ROUND_CALL): macros wrapping round
functions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56824 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:34 AM Revision d9035a8f (git): * 2016-11-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56823 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/extmk.rb (compiled?): removed.
* ext/win32/extconf.rb: try to install libraries regardless
fiddle.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56822 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/17/2016
-
- Copy of actually i just got:
```
*** Error in `irb': malloc(): smallbin double linked list corrupted: 0x0000556762bac3d0 ***
```
on plain irb, no rails. log attached -
- actually i just got:
```
*** Error in `/usr/bin/ruby': malloc(): smallbin double linked list corrupted: 0x0000560f0e10b090 ***
```
from just hitting CTRL+C a few tiems on rails console. could reproduce too, log attached. -
- oh yea, my readline version: `readline-6.3.008`
-
- i'm getting stuff liek this:
```
/usr/lib/ruby/2.3.0/irb/input-method.rb:151: [BUG] Segmentation fault at 0x00000000000000
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux]
```
and this:
```
*** Error in `/usr/bin/ruby': m... -
06:11 PM Bug #9822: Ruby doesn't respect system OpenSSL configuration
- much needed patch, I often used gost-crypt
-
01:05 PM Revision 53ca8de3 (git): Remove webhook notification to Travis CI [skip ci]
- As travis-rubies now uses 3 Mac jobs to create archives for various OS
releases.
This is a bit wasteful if multiple builds pass in a short period.
Instead, Travis CI is now running a nightly build of ruby-head
(around 22:30 UTC... -
- * ext/readline/readline.c (str_subpos): make string instance only
if necessary.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56820 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:50 AM Revision 998d1c6c (git): numeric.c: get rid of a compile error on mingw64
- * numeric.c (rb_fix2str): typo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56819 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ASCII-8BIT is suggested by naruse-san.
-
- Applied in changeset r56817.
----------
mkconfig.rb: add a magic comment to rbconfig.rb
* tool/mkconfig.rb: add a magic comment to rbconfig.rb in case the command
line option -K is specified. [ruby-core:78181] [Bug #12949] -
- TestRubyOptions#test_kanji fails on icc-x64 chkbuild.
From http://rubyci.org/logs/rubyci.s3.amazonaws.com/icc-x64/ruby-trunk/log/20161117T010002Z.fail.html.gz:
```
1) Failure:
TestRubyOptions#test_kanji [/home/chkbuild/chkbuild... - 07:19 AM Revision b53bebab (git): * 2016-11-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56818 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/mkconfig.rb: add a magic comment to rbconfig.rb in case the command
line option -K is specified. [ruby-core:78181] [Bug #12949]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56817 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Attila Györffy wrote:
> I'm opening this issue for further discussion. In my honest opinion, a reasonable default (not nil) would be a good idea to have so that we can make sure processes won't hang.
I have the following concerns:
...
11/16/2016
-
- Tiago Cardoso wrote:
> I guess we can close this.
Done. -
09:51 PM Bug #12946: net-http is breaking valid http headers like HTTP2-Settings
- You are right. I just tried with http://nghttp2.org, which supports upgrade-to-http2 http1 requests, and it worked well also with "Http2-Settings". I guess we can close this.
-
- Tiago Cardoso wrote:
> It breaks because it sends the wrong-cased http header over the wire. From plaintext upgrade-to-http2:
> ...
No they won't. From [RFC 7231](https://tools.ietf.org/html/rfc7230#section-3.2) (i.e. HTTP/1.1):
> ... -
- It breaks because it sends the wrong-cased http header over the wire. From plaintext upgrade-to-http2:
https://hpbn.co/http2/#upgrading-to-http2
If you tcpdump the sent payload from a net-http client, it is sending "Http2-Settings"... -
06:40 PM Bug #12943: Backport r56268 to Ruby 2.3
- No problem! I wasn't sure about how to open backports, so I just created a ticket. :)
-
- Thank you for your report!
I'll check r56268 later.
I close this ticket but it's because we (stable maintainers) track closed tickets with Backport REQUIRED field. Please don't worry. -
04:54 PM Feature #12928: Use socket conect_timeout in net stdlib for open_timeout
- I got it. It is not simple to fix as I expected before. Thank you.
-
03:06 PM Feature #11665: Support nested functions for better code organization
- Yukihiro Matsumoto wrote:
> But at least, the current behavior of nested method definition is useless. It should be made obsolete to open up the future possibility (I'd vote for warning).
~~~ ruby
# nested methods allow enforcing ... -
- ruby_2_3 r56816 merged revision(s) 56694,56698.
-
- OMG I've confirmed with the script in the description (prepend and using with Integer) and it cannot reproduce NoMethodError on 2.3.2. But it's because Time.now doesn't use Integer#+ but Fixnum#+.
I've confirmed https://bugs.ruby-lang.o... -
- vm_eval.c: fix refined method when prepended
* vm_eval.c (vm_call0_body): refined module should not be skipped
as prepended. [ruby-core:78073] [Bug #12920]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56816 ... -
02:21 PM Feature #12921: Retrieve user and password for proxy from env
- > You have to understand that environment variables are in fact insecure. It is a very bad idea to store passwords there. Surprising or not, insecure is insecure. We shall not introduce this.
Well, less point this to me. Since r5... -
- You have to understand that environment variables are in fact insecure. It is a very bad idea to store passwords there. Surprising or not, insecure is insecure. We shall not introduce this.
-
08:41 AM Misc #12935: Webrick: Update HTTP Status codes, share them
- > Can you point to some of these examples? If there is actual use of this code in a somewhat uniform way, then it should be possible to register it. Also, if there are other, similar codes, then the same applies.
Well, except for Goog... -
08:19 AM Bug #11831: Undefined behavior issues
- It looks like the issue popped up again.
Both ruby-2.3.2 and ruby-2.2.6 defined PLATFORM_UNALIGNED_WORD_ACCESS
unconditionally on __x86_64__.
This is wrong and invokes undefined behavior. -
- Applied in changeset r56815.
----------
logger.rb: fix next rotate time
* lib/logger.rb (Logger::LogDevice#initialize): calculate next
rotate time based on the mtime of the last existing file.
[ruby-dev:49881] [Bug #12948]
Author:... -
06:02 AM Bug #12948 (Closed): Logger does not rotate even if there is a past file to rotate.
- Logger shift_age is "daily".
"log" file's timestamp is yesterday or earlier.
Logger does not rotate the file.
Ruby version is 2.1 or older, Logger rotates the file.
~~~ruby
require 'time'
require 'logger'
File.open("log", "w... -
- * lib/logger.rb (Logger::LogDevice#initialize): calculate next
rotate time based on the mtime of the last existing file.
[ruby-dev:49881] [Bug #12948]
Author: Tsukasa Oishi <tsukasa.oishi@gmail.com>
git-svn-id: svn+ssh://ci.ruby-la... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * misc/ruby-additional.el (ruby-insert-heredoc-code-block): make
code between "begin;" and "end;" unquoted. still quotable
before "begin;".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r56812.
----------
configure.in: compressed debug section option
* configure.in: make compressed debug section optional.
[ruby-core:78121] [Bug #12934] -
- * configure.in: make compressed debug section optional.
[ruby-core:78121] [Bug #12934]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56812 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r56811.
----------
test_flip.rb: r56316
* test/ruby/test_flip.rb (test_input_line_number_range): test for
r56316. [ruby-core:78162] [Bug #12947] -
- * test/ruby/test_flip.rb (test_input_line_number_range): test for
r56316. [ruby-core:78162] [Bug #12947]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56811 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:25 AM Revision 558c362f (git): math.c: remove needless ifdef clause
- * math.c (ifdef M_PI): M_PI is eventually defined in missing.h even if math.h
doesn't supply it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56810 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:25 AM Revision affa0f84 (git): complex.c: optimize Numeric#polar and Numeric#arg
- * complex.c (numeric_polar): optimize for Integer, Float, and Rational.
* complex.c (numeric_arg): directly create the value of pi.
* complex.c (f_negative_p): optimize for Integer, Float, and Rational.
* rational.c (INT_NEGATIVE_P): ... - 04:25 AM Revision ab9b7890 (git): rational.c: optimize Rational#abs
- * rational.c (rb_rational_abs): optimize Rational#abs with the
specialized implementation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56808 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- https://github.com/ruby/psych/commit/18d13b1df09504548feb4cb9b259fed552d6a4d5
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56807 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Picked from upstream: https://github.com/ruby/psych/commit/66fb7fb77533d0606748940288858794752d95cb
[ci skip][ruby-dev:49879][Bug #12942]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56806 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/15/2016
-
11:35 PM Bug #12947: Multiline if statements behave differently than inline if statements for flip flop
- s/it behaves like a regex/it behaves like a range/
-
- For an inline if statement, a numerical range literal in a conditional behaves like flip flop matching against `$.`
Parsed [here](https://github.com/ruby/ruby/blob/0fe793cf9d400fdcc1f904e59d39c9b030758f42/parse.y#L1229-L1237).
```
... -
- Tiago Cardoso wrote:
> The Net::HTTPHeader can't process the `HTTP2-Settings` header, which is a valid header destined to pass base64-encoded settings to a soon-to-be-upgraded-to-http2 connection.
Aren't HTTP header names case-insens... -
- The Net::HTTPHeader can't process the `HTTP2-Settings` header, which is a valid header destined to pass base64-encoded settings to a soon-to-be-upgraded-to-http2 connection.
~~~ruby
req=Net::HTTP::Get.new
req["Upgrade"] = "h2c"
re... -
10:28 PM Bug #11531: IPAddr#== implements wrong logic
- > it does not consider a difference in netmasks as significant
IPAddr.new isn't consistent with this principle:
```ruby
IPAddr.new("1.2.3.4/24") == IPAddr.new("1.2.3.4/32") # => false
```
1.2.3.4/24 is valid notation for a hos... -
- >README.rdoc も README.md もないようですが、良いのでしょうか?
default gem なのでそういうものだと思います。
> ...
upstream の問題なので https://github.com/ruby/psych/ で対応後に ruby にマージします。 -
03:14 PM Bug #12942 (Third Party's Issue): about psych 2.2.0
- r56773 https://github.com/ruby/ruby/commit/4e70bae2bc9253fb91ae6c95bbe8e01e38d8d3df の ext/psych/psych.gemspec の差分には README.rdoc から README.md への変更が含まれていますが、 ext/psych 以下には README.rdoc も README.md もないようですが、良いのでしょうか?
typo 修正が戻ってしまっているっぽい... -
- Thoroughness aside, what would be the best approach? Having it in a gem is the easiest way, but it's an extra dependency to resolve (unless it's bundled with ruby, like openssl or net-telnet). I'd aim at availability, as this is a common...
-
- Martin Dürst wrote:
>
> ...
I know, and I guess you also know, that "418 I'm a Teapot" comes from traditional April 1 RFCs:
* https://tools.ietf.org/html/rfc2324#section-2.3.2
* https://tools.ietf.org/html/rfc7168#section-2.3.3
... -
- On 2016/11/15 04:03, zverok.offline@gmail.com wrote:
> Issue #12935 has been updated by Victor Shepelev.
> * Now, what would be an authoritative source? http://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml (like... -
08:31 PM Bug #12945 (Closed): Use-after-free in vm_trace.c
- When running ruby 2.4's tests on OpenBSD amd64, I've been getting occasional bus errors. I've only been getting them when running the full test suite, and they don't happen every time, and lowering the optimization level and adding debu...
-
- Currently, Kernel#warn is basically the same as $stderr.puts. With the new Warning.warn support in ruby 2.4, it makes sense for Kernel#warn to call Warning.warn, otherwise you will not be able to use Warning.warn to filter/process warni...
-
I changed the codes. Removed TCPSocket.for_fd and used socket directly now.
But I am no idea for DNS resolution timeout. How to fix it?-
- r56268 fixes a bug in the way `RubyVM::InstructionSequence.compile_file(path)` deals with syntax errors. I'm trying to use the Yomikomu gem with Ruby 2.3, but running in to this bug. I've attached a patch that backports the commit (wit...
- 03:04 PM Revision 0fe793cf (git): * 2016-11-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56805 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56804 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:47 PM Feature #12898: String#match? method in addition to Regexp#match?
- I just opened a pull request to add this behaviour: https://github.com/ruby/ruby/pull/1483
It surprised me that his behaviour wasn't implemented. -
01:41 PM Bug #12920: Strange NoMethodError in Time.now
- This problem happens with Ruby 2.3.2.
~~~
% cat a.rb
Fixnum.prepend(Module.new)
Module.new do
refine Fixnum do
define_method(:+) {}
end
end
Time.now
~~~
~~~
% ruby -v a.rb
ruby 2.3.2p217 (2016-11-15 revision 5679... - 01:41 PM Revision acec934e (git): * version.h: Bump up version to 2.2.7.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@56803 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Samuel Williams wrote:
> If that's the only issue holding back this feature.
Sadly no. The reason why this is not accepted is matz do not like the idea. You have to persuade him.
> ...
What's wrong with a gem, in that case? Rai... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56802 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:42 PM Revision ed83af60 (git): Use rb_mod_name instead of classname
- classname() is static function.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56801 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- You mixed Ruby 2.0.0 and 2.3.0. Do check your environment with rvm.
-
08:07 AM Bug #12940 (Rejected): MAC OS Sierra - RUBY RVM not working
- Its very critical I am to work with any gems in my mac.
**Below is the terminal error:**
-- Control frame information -----------------------------------------------
[13:30:49] c:0139 p:-17528882266936 s:0610 e:000609 TOP ... -
10:19 AM Bug #12941 (Closed): malloc: *** error for object 0x7fb4a88d2320: pointer being freed was not allocated
- I am _occasionally_ seeing issues like this:
~~~
ruby /Users/plundberg/.rvm/gems/ruby-2.3.1/bin/rspec(63837,0x7fffd90c33c0) malloc: *** error for object 0x7fb4a88d2320: pointer being freed was not allocated
*** set a breakpoint in m... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56799 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:33 AM Bug #11810: [PATCH] OpenSSL::SSL::SSLcontext#{alpn,npn}_select_cb= does not work properly
- ruby_2_2 r56798 merged revision(s) 53064.
- 06:33 AM Revision 30238f96 (git): merge revision(s) 53064: [Backport #11810]
- * ext/openssl/ossl_ssl.c (ssl_npn_select_cb_common): fix parsing
protocol list.
The protocol list from OpenSSL is not null-terminated.
patched by Kazuki Yamaguchi [Bug #11810] [ruby-core:72082]
git-svn-id:... -
- * complex.c (f_eqeq_p): use rb_equal.
* complex.c (nucomp_eqeq_p): limit return value to true or false,
instead of the result of the other as-is.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56797 b2dd03c8-39d4-4d8f-98ff-823fe69... -
- It is not a bug, and easy to extend the parser to allow that syntax, but doesn't look nice to me.
-
05:55 AM Feature #12931: Add support for Binding#instance_eval
- Nobuyoshi Nakada wrote:
> Since local variables and constants depend on the context, it won't be able to be "cached," as a `Proc` compiled other place.
> ...
That makes sense.
So, to clarify, you are saying that there is no way to r... -
- * ext/socket/lib/socket.rb: remove unnecessary closed checks,
close on closed socket no longer raises an exception.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56795 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/net/ftp.rb (sendport, makeport, makepasv, BufferedSocket):
use Addrinfo interfaces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56794 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:36 AM Bug #12939: MRI crashes when a hash table becomes huge
- Thanks, committed as r56793
-
12:27 AM Bug #12939 (Closed): MRI crashes when a hash table becomes huge - Applied in changeset r56793.
----------
st.c: fix crashes on huge hash tables
From: Vladimir Makarov <vmakarov@redhat.com>
By Vladimir's estimation, this requires at least 64 GB of memory
to reproduce this bug due to the hash sizes re... - 12:27 AM Revision f46a43fc (git): st.c: fix crashes on huge hash tables
- From: Vladimir Makarov <vmakarov@redhat.com>
By Vladimir's estimation, this requires at least 64 GB of memory
to reproduce this bug due to the hash sizes required. So there
is no new test case (and I am unable to test it, myself).
* s...
11/14/2016
-
11:03 PM Bug #12939 (Closed): MRI crashes when a hash table becomes huge
- Checking huge hash tables on the trunk, I found a bug in my code.
Here is the test case:
```
h = {}; 0x100000000.times{|i| h[i] = i}
```
MRI diagnostics for the test case is at the report end.
You need a machine with huge mem... -
- The following commits have made forwardable.rb unusable on any implementation except MRI, because they use YARV-specific RubyVM module and features. I believe all of these changes were done by nobu.
These introduce uses of RubyVM::Ins... -
- Process.daemon exists since Ruby 1.9.1 and does most of what we need.
* lib/webrick/server.rb (Daemon.start): simplify
Just a cleanup patch, will commit in a few days/weeks.
-
- xiewenwei@gmail.com wrote:
> net/http, net/pop, net/smtp and net/ftp use `Timeout.timeout` to calculate connect_timeout.
> Timeout.timeout is slow. It creates and destroys a thread every time.
> Timeout.timeout is also dangerous. see... -
- The codes are updated. I use Socket.tcp now. Socket.tcp returns Socket instance. So I need to convert it to TCPSocket instance using TCPSocket.for_fd.
-
- reach expected state before proceeding.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56792 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:27 PM Revision 20ea1279 (git): * 2016-11-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56791 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ordered.
* test/ruby/test_struct.rb: Ditto.
* test/ruby/test_thread.rb: Thread locals are not guaranteed to be
ordered.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56790 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- My 5c:
* It seems really reasonable to have centralized repo of status codes;
* I am not sure it should be in stdlib, why we not just do a gem?.. (With, probably, _automatic_ update from an _authorative_ source);
* Now, what would b... -
- I was looking for a common source of http status-to-reason map in ruby, and I've found many sources that address the same, some of them overlapping, most of them clearly copy-pasting from each other. In the process, I also found that the...
-
- ruby_2_2 r56789 merged revision(s) 56559,56582,56584,56585.
-
- ruby_2_3 r56785 merged revision(s) 56559,56582,56584,56585.
- 06:58 PM Revision 3c61aab9 (git): merge revision(s) 56559,56582,56584,56585: [Backport #12903]
- * test/ruby/test_file.rb (TestFile#test_stat): fix noatime case.
[ruby-core:77943] [Bug #12903]
* ext/-test/file/fs.c (get_atime_p): Updating of file access times
is enabled or not.
git-svn-id: svn+ssh://ci... -
- ruby_2_2 r56788 merged revision(s) 56625.
-
- ruby_2_3 r56784 merged revision(s) 56625.
-
- バックポート管理用のチケットです。
FreeBSD 11.0 での Rinda のテストの失敗の修正です。
- 06:54 PM Revision 49e1e456 (git): merge revision(s) 56625: [Backport #12936]
- * test/rinda/test_rinda.rb (test_make_socket_ipv6_multicast,
test_make_socket_ipv6_multicast_hops): skip if IPv6 multicast
address is not available.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@5678... -
- ruby_2_2 r56787 merged revision(s) 56596.
-
- ruby_2_3 r56782 merged revision(s) 56596.
- 06:40 PM Revision bb5114bc (git): merge revision(s) 56596: [Backport #12890]
- * lib/net/http.rb (transport_request): other than HTTPContinue
in 1xx (HTTPInformation) also needs to continue. [Bug #12890]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@56787 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- ruby_2_2 r56786 merged revision(s) 56766,56767.
-
- ruby_2_3 r56781 merged revision(s) 56766,56767.
-
- Refinements and aliases are red herring.
All versions have this bug.
```
$ ruby1.9 -e 'class Exception; undef backtrace; end' -e 'raise "hello"'
Illegal instruction: 4
$ ruby2.0 -e 'class Exception; undef backtrace; end' -e 'raise... - 06:37 PM Revision 6140b395 (git): merge revision(s) 56766,56767: [Backport #12925]
- error.c: rb_get_backtrace
* error.c (rb_get_backtrace): move from eval_error.c to call
exc_backtrace directly. [ruby-core:78097] [Bug #12925]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@56786 b2dd03c8-39d4-... -
- * test/ruby/test_file.rb (TestFile#test_stat): fix noatime case.
[ruby-core:77943] [Bug #12903]
* ext/-test/file/fs.c (get_atime_p): Updating of file access times
is enabled or not.
git-svn-id: svn+ssh://ci... -
- * test/rinda/test_rinda.rb (test_make_socket_ipv6_multicast,
test_make_socket_ipv6_multicast_hops): skip if IPv6 multicast
address is not available.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@5678... -
- ruby_2_3 r56783 merged revision(s) 56520.
-
- * vm_eval.c (vm_call0_body): follow the original class, not to
loop the prepended module. [ruby-core:77784] [Bug #12876]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56783 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/net/http.rb (transport_request): other than HTTPContinue
in 1xx (HTTPInformation) also needs to continue. [Bug #12890]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56782 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- error.c: rb_get_backtrace
* error.c (rb_get_backtrace): move from eval_error.c to call
exc_backtrace directly. [ruby-core:78097] [Bug #12925]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56781 b2dd03c8-39d4-... -
03:37 PM Bug #12934: Make compressed debug section optional
- I am just extracting some bits of discussion in the RPM [1] ticket:
```
--- Additional comment from Mark Wielaard on 2016-11-14 13:36:50 CET ---
--compress-debug-sections=zlib doesn't really make sense when using dwz. And various ... -
- Forgot to link the RPM ticket: https://bugzilla.redhat.com/show_bug.cgi?id=1394759
-
- r56445 introduces "--compress-debug-sections=zlib" flag to compress the debug section. Unfortunately, it seems that the compressed sections are not well handled by RPM. Ruby package build log now contains plenty of messages such as:
`... -
- I think r55766 introduces too big changes and I cannot backport it to the stable branches.
https://github.com/ruby/ruby/pull/1479/files seems reasonable to me. ko1 san, nakada san, What do you think of the patch? -
09:30 AM Feature #12929: ternary should look ahead w/in a block (and not care about newlines)
- Martin Dürst wrote:
> In Ruby, all operators have to be written at the end of the line to make it possible to distinguish between complete statements (with a missing semicolon) and continuations.
> ...
I think that this is what he mean... -
- In Ruby, all operators have to be written at the end of the line to make it possible to distinguish between complete statements (with a missing semicolon) and continuations.
The only exception is the '.' operator, which is allowed to ... -
- * lib/net/ftp.rb (Net::FTP#open_socket): use keyword argument.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56780 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/net/protocol.rb (Net::BufferedIO#initialize): add keyword
arguments for initial attributes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56779 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/socket/lib/socket.rb (connect_{from,to}, connect): let use
keyword arguments.
* ext/socket/lib/socket.rb (Socket.tcp): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56778 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:19 AM Feature #12933: Add Some and Optional
- Change to feature from bug
-
- What if we have Optional and None as a class, and which we can use like this:
```ruby
have_data = Optional(5).get # returns 5
have_data = Some(nil) # raise error
have_data = Some(operation).expect("cannot be nil") # raise cannot be... -
06:16 AM Bug #12932 (Third Party's Issue): [BUG] Segmentation fault at 0x00000000000078
- After runing Sidekiq and Elasticsearch-rb in 10 threads, I got this page
~~~
-- Crash Report log information --------------------------------------------
See Crash Report log file under the one of following:
* ~/Library/Log... -
- Applied in changeset r56777.
----------
vm_eval.c: fstring instance_eval
* vm_eval.c (singleton_class_for_eval): enable fstring singleton
class for instance_eval. [ruby-core:78116] [Bug #12930] -
- A string literal with `.freeze` reveals the object in the shared frozen string literal pool.
I think that shared objects should not be modified, like `Integer` and `Float`.
Any idea? -
- * vm_eval.c (singleton_class_for_eval): enable fstring singleton
class for instance_eval. [ruby-core:78116] [Bug #12930]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56777 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Since local variables and constants depend on the context, it won't be able to be "cached," as a `Proc` compiled other place.
So I think it isn't worth. -
- Many people would probably like to use `binding.instance_eval` when executing templates. The reason for this is because `binding.eval` is slow.
The use case is template rendering, e.g. systems like ERB.
In my template renderer, I d... -
- * complex.c (f_negative_p): use rb_num_negative_p instead of funcall.
* complex.c (f_kind_of_p, f_numeric_p): cast down to int because
rb_obj_is_kind_of is safe.
* complex.c (f_signbit, f_tpositive_p): remove f_boolcast.
git-svn-id:... -
- * rational.c (f_kind_of_p): rb_obj_is_kind_of returns Qtrue or
Qfalse always, and is safe to cast down to int.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56775 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Nobu, thanks for that clarification. I was not aware of that.
If that's the only issue holding back this feature, I'm sure a workaround can be found that works appropriately.
It might be as simple as going with the more common opti... - 12:40 AM Revision ce48ef2b (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56774 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Merge libyaml-0.1.7 for bundled-libyaml option.
* Update canonical url to https://github.com/ruby/psych.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56773 b2dd03c8-39d4-4d8f-98ff-823fe69b080e