Project

General

Profile

Activity

From 09/27/2016 to 10/03/2016

10/03/2016

09:06 PM Revision ee1acb55 (git): * 2016-10-04
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56334 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
09:06 PM Revision 5d9b95a5 (git): * regcomp.c (onig_print_compiled_byte_code): make the shown address
look relative.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56333 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)
09:06 PM Revision e342418e (git): * regexec.c (OPCODE_EXEC_HOOK): op is p-1 because p is already
incremented.
* regexec.c (OPCODE_EXEC_HOOK): use the exact end address.
* regexec.c (match_at): don't call OPCODE_EXEC_HOOK in CASE()
when it comes from goto fail.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56332 b2dd03c8-39d...
naruse (Yui NARUSE)
05:26 PM Revision 54b80158 (git): merge revision(s) 56281,56282:
strscan.c: use S_RESTLEN
* ext/strscan/strscan.c (strscan_getch, strscan_peek),
(strscan_rest_size, inspect2): use S_RESTLEN consistently.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56331 b2dd03c8-39d4-4d8f...
nagachika (Tomoyuki Chikanaga)
01:23 PM Bug #12805 (Closed): MRI BigDecimal#div produces grossly wrong result
### Expected
(It works in JRuby-9.1.5.0)
~~~
# ruby -e 'require "bigdecimal"; (1...50).each do |i| puts (BigDecimal.new("1").div(BigDecimal.new("0.22E0"),i)).to_s; end'
0.5E1
0.45E1
0.455E1
0.4545E1
0.45455E1
0.454545E1
0.4...
felixvf (Felix von Ferey)
12:39 PM Revision 011e45c6 (git): use rb_locale_str_new
* ext/readline/readline.c (readline_char_is_quoted): use
rb_locale_str_new with the length. [Feature #12659]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56330 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:26 PM Revision da66234e (git): * NEWS: mention Readline.quoting_detection_proc{,=}. [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56329 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
12:21 PM Revision 81ac73c0 (git): [DOC] Fix default value of shift_age [ci skip]
`LogDevice#initialize` treats shift_age: nil as 7, but
Logger#initialize has the default value of shift_age as 0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56328 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
znz (Kazuhiro NISHIYAMA)
12:18 PM Revision 787e8788 (git): Add prefix to FIX2LONG in include/ruby/ruby.h
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56327 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
10:19 AM Bug #12804 (Third Party's Issue): rails console crashes on accessing db after upgrading to mac sierra
According to the attached crash report it dies inside of sqlite3. Please contact its authors. shyouhei (Shyouhei Urabe)
07:31 AM Bug #12804 (Third Party's Issue): rails console crashes on accessing db after upgrading to mac sierra
Encountered a bug when trying to use Rails Console to quesry and interact with activerecord. Everything had been working fine, only system change has been to upgrade to MacOS this past week.
Rails 5.0.0
ruby 2.3.1p112 (2016-04-26 re...
link2prasad@gmail.com (Rama Prasad)
08:20 AM Feature #12659 (Closed): Readline: expose rl_char_is_quoted_p setting
Applied in changeset r56326.
----------
rl_char_is_quoted_p
* ext/readline/readline.c (readline_s_set_quoting_detection_proc):
support rl_char_is_quoted_p. [Feature #12659]
* ext/readline/readline.c (readline_s_get_quoting_detection...
nobu (Nobuyoshi Nakada)
07:03 AM Feature #12659: Readline: expose rl_char_is_quoted_p setting
> Could you add a few tests?
Sorry, I missed the patch.
You may be able to use `rb_str_sublen()` instead of `byte_index_to_char_index()`.
```c
static int
readline_char_is_quoted(char *text, int byte_index)
{
VALUE proc, ...
nobu (Nobuyoshi Nakada)
06:46 AM Feature #12659: Readline: expose rl_char_is_quoted_p setting
Could you add a few tests?
And these functions should be `static`, and don't seem need forward declarations if the latter function is defined before the former.
```C
int readline_char_is_quoted(char *text, int index);
long byte_i...
nobu (Nobuyoshi Nakada)
08:20 AM Revision 402f0426 (git): rl_char_is_quoted_p
* ext/readline/readline.c (readline_s_set_quoting_detection_proc):
support rl_char_is_quoted_p. [Feature #12659]
* ext/readline/readline.c (readline_s_get_quoting_detection_proc):
ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/...
nobu (Nobuyoshi Nakada)
07:10 AM Revision d3c62924 (git): * 2016-10-03
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56325 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
07:10 AM Revision 5d8acb25 (git): readline.c: mustbe_callable
* ext/readline/readline.c (mustbe_callable): extract to check a
given argument to be callable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56324 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:11 AM Feature #12039: Fixnum#infinite?/Bignum#infinite or Numeric#infinte, consistent with Float#infinite? and BigDecimal#infinite?
Thank you for your hard work :) ioquatix (Samuel Williams)

10/02/2016

03:09 PM Feature #12659: Readline: expose rl_char_is_quoted_p setting
Robert A. Heiler wrote:
> If I understand it correctly then you provide a wrapper that is currently not part of ruby readline module yes?
> ...
Yes, that's exactly what this patch does.
Anything I can do to move this forward?
georgebrock (George Brocklehurst)
03:32 AM Revision 91430022 (git): numeric.c: adjust type
* numeric.c (rb_fix2str): cast to a pointer to adjust argument
type for the format.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56323 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:52 AM Feature #12676: Significant performance increase, and code conciseness, for prime_division method in prime.rb
IMHO the current version has an inconsistency in outputs between 1 and -1.
```
> 1.prime_division8 => []
> ...
```
For logical consistency, and mathematical correctness, -1 output should be the same as 1.
```
> 1.prime_divisi...
jzakiya (Jabari Zakiya)

10/01/2016

11:22 PM Revision 432a0750 (git): ruby.h: add prefix
* include/ruby/ruby.h (RB_INT2FIX, RB_LONG2FIX): prefix RB to
global symbols to get rid of name conflicts with other headers.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56322 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
10:51 PM Revision 63d77c2a (git): string.c: negative hash
* string.c (rb_str_hash_m): hash values may be negative.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56321 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
09:12 PM Feature #12803 (Closed): Improve Logger.new option documentation
Logger.new: http://ruby-doc.org/stdlib-2.3.0/libdoc/logger/rdoc/Logger.html#new-method
From only looking at the docs, it's not obvious what the default value is for Logger.new shift_age or shift_size, nor what value disables the shift...
spacemunkay (Jason Denney)
05:49 PM Feature #12802 (Open): Add BLAKE2 support to Digest
BLAKE2 is a fast, modern hash function, based on improvements to the BLAKE function, which was a SHA3 finalist. BLAKE2 performs about twice as fast in software as SHA3 winner Keccak:
https://blake2.net/
BLAKE2 has received an infor...
bascule (Tony Arcieri)
05:06 PM Revision 7a440190 (git): * string.c (rb_str_hash_m): st_index_t is not guaranteed as the same
size with int, and of course also not guaranteed the value can be
Fixnum.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56320 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
05:04 PM Revision 318ecff4 (git): * 2016-10-02
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56319 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
05:04 PM Revision ae55ecc2 (git): * numeric.c (rb_fix2str): detect unnormalized Fixnum value.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56318 b2dd03c8-39d4-4d8f-98ff-823fe69b080e U.Nakamura
02:12 PM Revision 9c9c46e5 (git): * ext/date/date_parse.c (date_zone_to_diff): it's nonsence and really
harm that to use unary minus operator with unsigned value.
get rid of test failures introduced at r56312.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56317 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
01:17 PM Revision 1b944201 (git): compile.c: literal range
* compile.c (iseq_compile_each): move numeric literal range
optimization from fixup_nodes() in parse.y.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56316 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:28 PM Misc #12756 (Closed): Increase test coverage and stylistic changes for URI::HTTP
hsbt (Hiroshi SHIBATA)
10:19 AM Revision 8c401de5 (git): compile.c: optimize flip-flop
* compile.c (compile_flip_flop): simplify generated code.
* compile.c (compile_branch_condition): flip-flop can appear only
in coditional expressions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56315 b2dd03c8-39d4-4d8f-98ff-823...
nobu (Nobuyoshi Nakada)
09:04 AM Bug #12728: Negative lookahead does not work for "+" even though works for "@"
Yui NARUSE wrote:
> In case 2, the regexp just behave as if
> ...
Argh! Stupid me. Yes, the negative lookahead will also match with the closing bracket.
> Maybe use should `[a-zA-Z0-9]*` or something instead of `.*`.
I included...
rklemme (Robert Klemme)
09:00 AM Revision 4bb74854 (git): date_parse.c: str_end_with
* ext/date/date_parse.c (str_end_with): extract to tell if a
string ends with the other string.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56314 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
08:52 AM Revision d618f7b7 (git): zonetab.h: use strncmp
* ext/date/zonetab.h (zonetab): use strncmp.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56313 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
08:52 AM Revision c943e596 (git): date_parse.c: refactor
* ext/date/date_parse.c (date_zone_to_diff): refactor without
allocating strings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56312 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)

09/30/2016

09:57 PM Bug #12728 (Rejected): Negative lookahead does not work for "+" even though works for "@"
In case 2, the regexp just behave as if
```
t %r{
(?<!\\)\( # outer bracket
o\+
(?<!\\) ([+*]|\{\d+,\}) (?!\+) # inner repetition, non possessive
.*
(?<!\\)\) ...
naruse (Yui NARUSE)
05:03 PM Revision fbe91115 (git): * 2016-10-01
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56311 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
05:03 PM Revision c82d8744 (git): * win32/win32.c (poll_child_status): rb_w32_wait_events_blocking() sets
errno internally, then should not set it here.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56310 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
04:07 PM Bug #12742: backport r56117 (fix private constant message) and r56118 (fix deprecated constant message)
ruby_2_2 r56309 merged revision(s) 56117.
ruby 2.2 doesn't warn deprecated constants, then we don't have to (or, can't) backport r56118.
usa (Usaku NAKAMURA)
04:05 PM Revision a6bc3808 (git): merge revision(s) 56117: [Backport #12742]
* variable.c (rb_const_search): raise with the actual class/module
name which defines the private constant.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@56309 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
03:58 PM Revision 768cdfb2 (git): merge revision(s) 56030,56035: [Backport #12711]
* vm_dump.c (backtrace): use rip in the saved context for the case
the SIGSEGV is received when the process is in userland.
Note that ip in the stack should be used if the signal is received
when it is in ke...
U.Nakamura
03:57 PM Bug #12766: Backport r56166 (Don't include bad password in URI exception output)
ruby_2_2 r56307 merged revision(s) 56166. usa (Usaku NAKAMURA)
03:57 PM Revision 16310405 (git): merge revision(s) 56166: [Backport #12766]
* lib/uri/generic.rb (def check_password): don't include bad password
in URI exception output
* test/uri/test_generic.rb (def test_set_component): test for behavior
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branche...
U.Nakamura
03:55 PM Bug #12713: backport r56036
ruby_2_2 r56306 merged revision(s) 56036,56041. usa (Usaku NAKAMURA)
03:55 PM Revision 6468b9be (git): merge revision(s) 56036,56041: [Backport #12713]
* io.c (nogvl_fsync, nogvl_fdatasync): on Windows, just ignore if the
fd is associated to non-disk device. if call fsync and/or fdatasync
with such fds, it causes Errno::EBADF exception and the behavior is
...
U.Nakamura
03:54 PM Bug #12738: Array#flattenで特異クラスが引き継がれる
ruby_2_2 r56305 merged revision(s) 56111. usa (Usaku NAKAMURA)
03:54 PM Revision 4af941c7 (git): merge revision(s) 56111: [Backport #12738]
* array.c (flatten): use rb_obj_class instead of rb_class_of
because rb_class_of may return a singleton class.
[ruby-dev:49781] [Bug #12738]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@56305 b2dd03...
U.Nakamura
03:52 PM Bug #12692: remove RUBYLIB_PREFIX from man/irb.1
ruby_2_2 r56304 merged revision(s) 55984. usa (Usaku NAKAMURA)
03:52 PM Revision f0608fca (git): merge revision(s) 55984: [Backport #12692]
* man/irb.1: remove useless -width option.
[ruby-dev:49767] [Bug #12692]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@56304 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
03:50 PM Bug #12183: require "win32ole" すると終了ステータスが必ず 0 になる
ruby_2_2 r56303 merged revision(s) 49495. usa (Usaku NAKAMURA)
03:50 PM Revision d5e55668 (git): merge revision(s) 49495: [Backport #12183]
* ext/win32ole/win32ole.c (Init_win32ole): should not use atexit to
free allocated hash table to avoid error on Cygwin.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@56303 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
03:44 PM Bug #12537: Fiddle::TestPointer#test_to_s and test_to_str destroy literal string data
ruby_2_2 r56302 merged revision(s) 55554. usa (Usaku NAKAMURA)
03:44 PM Revision 71e009ed (git): merge revision(s) 55554: [Backport #12537]
* test/fiddle/test_pointer.rb (test_to_str, test_to_s, test_aref_aset):
Attempt to use independent strings for destructive tests that
directly modify values on memory by using Fiddle::Pointer.
[Bug #12537] [...
U.Nakamura
03:42 PM Bug #12536: SIGABRT during GC on Debian GNU/Linux 8 (x86_64) due to insufficient string buffer allocation related with term fill
ruby_2_2 r56301 merged revision(s) 55547,55551,55552,55555,55557,55559,55568,55575,55691. usa (Usaku NAKAMURA)
03:42 PM Revision 63e4f212 (git): merge revision(s) 55547,55551,55552,55555,55557,55559,55568,55575,55691: [Backport #12536]
* string.c: Fix memory corruptions when using UTF-16/32 strings.
[Bug #12536] [ruby-dev:49699]
* string.c (TERM_LEN_MAX): Macro for the longest TERM_FILL length,
the same as largest value of rb_enc_mbminlen(e...
U.Nakamura
03:03 PM Bug #12660: [PATCH] openssl: avoid undefined behavior on empty SSL_write
ruby_2_2 r56300 merged revision(s) 55822. usa (Usaku NAKAMURA)
03:03 PM Revision c880452b (git): merge revision(s) 55822: [Backport #12660]
* ext/openssl/ossl_ssl.c (ossl_ssl_write_internal):
avoid undefined behavior
* test/openssl/test_pair.rb (test_write_zero): new test
[ruby-core:76751] [Bug #12660]
git-svn-id: svn+ssh://ci.ruby-lang.org/rub...
U.Nakamura
12:46 PM Revision ed2af78b (git): test_flip.rb: add
* test/ruby/test_flip.rb (test_flip_flop): basic test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56299 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
10:06 AM Revision 107ba65f (git): * lib/uri/http.rb: Documentation and code style imrovements.
* test/uri/test_http.rb: Added test for coverage.
[fix GH-1427][ruby-core:77255][Misc #12756]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56298 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
09:43 AM Revision 377f69e4 (git): * doc/syntax/control_expressions.rdoc: Add missing 'as'
[ci skip][fix GH-1448] Patch by @jsyeo
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56297 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
05:47 AM Feature #12790: Better inspect for stdlib classes
That the object id is displayed also used to confuse me. I adjusted to it
so it is fine but I don't think I ever really needed to know the object
id. Perhaps it visually looks cuter if the object id is shown. :)
On a slightly relate...
shevegen (Robert A. Heiler)
05:41 AM Feature #12786: String#casecmp?
I think .eql? is not a good name because it chops away characters.
Imagine if we would have .sz or .sz? rather than .size. Or .lngth
rather than .length. :D
.casecmp? does chop away characters too but at least it is a bit
easier ...
shevegen (Robert A. Heiler)
04:02 AM Revision 64f11d81 (git): * 2016-09-30
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56296 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:02 AM Revision d84d0f27 (git): test_range.rb: all assertions
* test/ruby/test_range.rb (test_range_bsearch_for_floats): test
all assertions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56295 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
03:11 AM Feature #841: Object#self
このチケット、2.2でObject#itselfが導入されたことで肯定的に解決されたという理解であってるでしょうか。
https://ruby-doc.org/core-2.2.0/Object.html#method-i-itself
(検索したらこのチケットが出てきたので参考情報として書いておきます)
takahashim (Masayoshi Takahashi)
01:09 AM Bug #12801 (Feedback): Bug while developing a Rails app
Thank you. The output shows it died inside of GC.
Note however that it is highly possibly not a GC's fault. It just detected a priori failure of other parts. It seems your application loads several thousands of external libraries s...
shyouhei (Shyouhei Urabe)

09/29/2016

11:44 PM Feature #12138: Support `Kernel#load_with_env(filename, cbase: SomeMod, cref: someMod, binding: SomeMod) # => obj`
Yukihiro Matsumoto wrote:
> I understand the need for load() with context, but this proposal has
> ...
I don't understand what "proven sufficient" entails. Is there a metric I could use to know it was achieved?
josh.cheek (Josh Cheek)
09:00 PM Bug #12801 (Closed): Bug while developing a Rails app
I don't what happened and I'm not investigating also. The reason I'm reporting is because I read the message in the end that said "Bug reports are welcome.".
app_1 | Started GET "/assets/url(%22bootstrap.min.css.map%22)" for 172.1...
silaspedrosa (Silas Pedrosa)
07:29 PM Feature #12142: Hash tables with open addressing
I still don't like open-addressing here. But code looks clearer.
And it is better to have common than different when Christmas is so close.
Ruby team will accept (or not accept) whatever they like to accept (or to not accept).
I don...
funny_falcon (Yura Sokolov)
03:50 PM Feature #12142: Hash tables with open addressing
Yura Sokolov wrote:
> Good day, everyone.
> ...
Yura, I am glad that finally you accepted open address tables. Now
there is no major differences between my original table proposal and
your current implementation. Although there are...
vmakarov (Vladimir Makarov)
02:40 PM Revision c249453c (git): * lib/yaml/store.rb (YAML::Store#dump): use table argument instead of @table directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56294 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
01:56 PM Revision a0a6fd73 (git): update call-seq of YAML::Store#initialize [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56293 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
01:43 PM Bug #12800 (Closed): YAMLStoreTest#test_thread_safe hang
Applied in changeset r56291.
----------
fix YAML::Store
* lib/yaml/store.rb (YAML::Store#initialize): Fix arguments.
[ruby-dev:49821] [Bug #12800]
* test/yaml/test_store.rb: Add tests from test/test_pstore.rb.
* test/yaml/test_stor...
Anonymous
01:39 PM Bug #12800 (Closed): YAMLStoreTest#test_thread_safe hang
`lib/yaml/store.rb` のテストがなかったので、`test/test_pstore.rb` を元に `test/yaml/test_store.rb` を作ってみたところ、`YAMLStoreTest#test_thread_safe` で止まってしまいました。
原因を調べてみたところ、
- `PStore` は `def initialize(file, thread_safe = false)`
- `YAML::Store` は `d...
znz (Kazuhiro NISHIYAMA)
01:43 PM Revision b9814bee (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56292 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:43 PM Revision 158cf62b (git): fix YAML::Store
* lib/yaml/store.rb (YAML::Store#initialize): Fix arguments.
[ruby-dev:49821] [Bug #12800]
* test/yaml/test_store.rb: Add tests from test/test_pstore.rb.
* test/yaml/test_store.rb (YAMLStoreTest#test_with_options): Add options test.
...
znz (Kazuhiro NISHIYAMA)
12:08 PM Revision 2eb0ad76 (git): checksum algorithm is not MD5 only [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56290 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
11:33 AM Revision 46bbb62b (git): parse.y: deferred_dots_gen
* parse.y (deferred_dots_gen): extract for tDOT2 and tDOT3.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56289 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
10:38 AM Revision 15686d6e (git): appveyor.yml: use mirror for zlib
* appveyor.yml (install): try sourceforge.net mirror to download
zlib source.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56288 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
10:34 AM Revision 325587ee (git): thread_sync.c: Document exception types
* thread_sync.c (rb_queue_pop, rb_szqueue_push, rb_szqueue_pop):
Document exception types, ThreadError, raised by Queue and
SizedQueue. [Fix GH-1451]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56287 b2dd03c8-39d4-4d8f-98ff-8...
nobu (Nobuyoshi Nakada)
10:21 AM Revision b1d24240 (git): * 2016-09-29
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56286 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
10:21 AM Revision 084487a3 (git): thread_sync.c: Remove confusing comments
* thread_sync.c (Init_thread_sync): Remove confusing doc comments,
which are picked up by rdoc unexpectedly, from Queue and
SizedQueue. [Fix GH-1450]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56285 b2dd03c8-39d4-4d8f-98ff-8...
nobu (Nobuyoshi Nakada)
07:36 AM Feature #12020: Documenting Ruby memory model
As the previous comments mention we had a meeting to discus memory
model at RubyKaigi. There were about fifteen Ruby implementers siting around the
table from MRI, JRuby, JRuby+Truffle, and OMR.
The first meeting started by exchangi...
pitr.ch (Petr Chalupa)
05:41 AM Feature #12093: Eval InstructionSequence with binding
I discovered an old [patch] for this issue.
This enables the following code, but doesn't seem useful to me.
```ruby
obj = Struct.new(:a, :b).new(1, 2)
bind = obj.instance_eval {binding}
RubyVM::InstructionSequence.compile("a + b")...
nobu (Nobuyoshi Nakada)

09/28/2016

05:52 PM Bug #12799 (Closed): IPAddr#== throws an exception with objects that can't be converted to IPAddr
I accidentally deleted issue #12779. It was created by https://bugs.ruby-lang.org/users/11301
----
Description
IPAddr#== uses IPAddr#coerce_other to attempt to convert the 'other' object into an IPAddr for comparison.
If this c...
hsbt (Hiroshi SHIBATA)
02:29 PM Bug #12793: Warning.warn with non-string object
While `Kernel#warn` should be generous since it is a public API,
`Warning.warn` is a method called by the internal and should be strict.
nobu (Nobuyoshi Nakada)
01:44 PM Bug #12793: Warning.warn with non-string object
`Kernel#warn` accepts `nil` and `1`, but `Warning.warn` raises `TypeError`.
Is this difference expected?
```
% ruby -ve 'warn nil; Warning.warn nil'
ruby 2.4.0dev (2016-09-28 trunk 56281) [x86_64-linux]
-e:1:in `warn': wrong arg...
znz (Kazuhiro NISHIYAMA)
02:14 PM Feature #6943 (Closed): pstore in FIPS mode
Applied in changeset r56284.
----------
PStore: select checksum algorithm
* lib/pstore.rb (PStore::CHECKSUM_ALGO): find available hashing
algorithm for checksum. MD5 is not available in FIPS mode.
[Feature #6943]
nobu (Nobuyoshi Nakada)
02:14 PM Revision 9f9add3e (git): PStore: select checksum algorithm
* lib/pstore.rb (PStore::CHECKSUM_ALGO): find available hashing
algorithm for checksum. MD5 is not available in FIPS mode.
[Feature #6943]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56284 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:12 PM Revision d90b767d (git): test_pstore.rb: use queues
* test/test_pstore.rb (PStoreTest#test_thread_safe): handshake by
queues, and reduce sleeping time.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56283 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:19 PM Bug #12797 (Third Party's Issue): Crash after rails test
Please report to the sqlite3-ruby project. nobu (Nobuyoshi Nakada)
11:51 AM Bug #12797: Crash after rails test
spring stop also helps... otherwise rails test crashes again. bginnhh (Ingo Kaiser)
10:56 AM Bug #12797 (Third Party's Issue): Crash after rails test
While running rails test for the second or further times, the command line reports a crash - every time. Restarting the command line allows me to run a test.
I'm sure that this is not a bug, but I can't find a solution for my problem....
bginnhh (Ingo Kaiser)
07:40 AM Bug #8221 (Closed): 2 AES-128-GCM (probably same in AES-256-GCM) bug?
Fixed by the following commits at ruby/openssl.
1. AES-GCM ciphers does not have uppercase short name
https://github.com/ruby/openssl/commit/2ed10db12deb114066443b4a0f1ffd49a8f612b2
2. The ordering issue of key and IV
...
rhenium (Kazuki Yamaguchi)
07:23 AM Bug #12794 (Rejected): Invalid ASN1 from OpenSSL::X509::Requests
It's not a bug. Calling #to_der against an empty OpenSSL::X509::Request has always returned invalid DER encoding of a CSR, because the mandatory parameters are missing.
It's OpenSSL 1.0.1i that changed the behavior by the way (your 1....
rhenium (Kazuki Yamaguchi)
05:26 AM Bug #12796 (Closed): Segmentation fault at ~/.rvm/gems/ruby-2.3.0@global/gems/did_you_mean-1.0.0/lib/did_you_mean/spell_checkers/name_error_checkers/variable_name_checker.rb:10: [BUG]
It's an already fixed bug, and 2.3.1 has been released. nobu (Nobuyoshi Nakada)
05:07 AM Bug #12796 (Closed): Segmentation fault at ~/.rvm/gems/ruby-2.3.0@global/gems/did_you_mean-1.0.0/lib/did_you_mean/spell_checkers/name_error_checkers/variable_name_checker.rb:10: [BUG]
Hi,
This is my first bug report so am sorry for missing out any wanted data.
I am using Ruby 2.3.0p0 with Rails 4.2.5. The ruby process crashes when running minitest tests for ActiveJob. The line causing the issue is
`user.update...
prasadsurase (Prasad Surase)
05:11 AM Revision 0b149ab5 (git): strscan.c: minl
* ext/strscan/strscan.c (minl): extract to reduce repeated S_LEN.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56282 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
05:11 AM Revision 604ae2e1 (git): strscan.c: use S_RESTLEN
* ext/strscan/strscan.c (strscan_getch, strscan_peek),
(strscan_rest_size, inspect2): use S_RESTLEN consistently.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56281 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:00 AM Revision 6c8fc79f (git): Update Signal.signame doc [ci-skip]
* signal.c (sig_signame): [DOC] Add documentation in the case of
return nil. [Fix GH-1449]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56280 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:49 AM Revision ca17c5d1 (git): * .travis.yml: delete comments. They were outdated. [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56279 b2dd03c8-39d4-4d8f-98ff-823fe69b080e shyouhei (Shyouhei Urabe)
01:26 AM Bug #12795 (Third Party's Issue): Bug when using Rails Console to query ActiveRecord - Segmentation fault
Please report to the sqlite3-ruby project.
nobu (Nobuyoshi Nakada)
01:13 AM Bug #12795 (Third Party's Issue): Bug when using Rails Console to query ActiveRecord - Segmentation fault
Encountered a bug when trying to use Rails Console (with Pry gem) to quesry and interact with activerecord. Everything had been working fine, only system change has been to upgrade to MacOS this past week.
steps to reproduce:
Enter...
suprTony (tony c)
01:16 AM Revision b6139464 (git): rubygems 2.6.7
* lib/rubygems.rb, lib/rubygems/*, test/rubygems/*: Update
rubygems to 2.6.7, not the master, with r56225.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56278 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:57 AM Revision 69934aeb (git): rubygems 2.6.7
* lib/rubygems.rb, lib/rubygems/*, test/rubygems/*: Update
rubygems to 2.6.7.
Release note of 2.6.7: https://github.com/rubygems/rubygems/commit/60f35bd1d2359fc30301d2d4cd72bc6833e8d12a
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr...
nobu (Nobuyoshi Nakada)
12:57 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
Are we going to add this method under OpenSSL namespace? If so "secure" describes almost nothing.
My suggestion is to add `String#casecmp?` (proposed in #12786) first, then introduce this one with `OpenSSL.memcmp?` naming.
shyouhei (Shyouhei Urabe)

09/27/2016

09:11 PM Bug #12794 (Rejected): Invalid ASN1 from OpenSSL::X509::Requests
Running #to_der and #to_pem when linked to OpenSSL 1.0.1g+ outputs invalid ASN1. It seems to output valid ASN1 with 1.0.1f. It appears that the last object identifier field is missing in the invalid output. Output from the openssl too... cfoo (Chris Foo)
06:09 PM Revision cc00f5bf (git): * ChangeLog: fix typo of r56271. [ci skip]
* NEWS: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56276 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nagachika (Tomoyuki Chikanaga)
03:21 PM Bug #12793 (Closed): Warning.warn with non-string object
Applied in changeset r56274.
----------
error.c: check argument of Warning.warn
* error.c (rb_warning_s_warn): the argument must be an
ASCII-compatible string. [ruby-core:77430] [Bug #12793]
nobu (Nobuyoshi Nakada)
02:58 PM Bug #12793 (Closed): Warning.warn with non-string object
`Warning.warn` with non-string argument causes SEGV.
For example, `Warning.warn nil`.
znz (Kazuhiro NISHIYAMA)
03:21 PM Revision cdd5a94a (git): * 2016-09-28
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56275 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:21 PM Revision d28bac1c (git): error.c: check argument of Warning.warn
* error.c (rb_warning_s_warn): the argument must be an
ASCII-compatible string. [ruby-core:77430] [Bug #12793]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56274 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:22 PM Revision 3d2e45d3 (git): parse.y: fix up r56198
* parse.y (symbol, dsym, parser_set_number_literal): set state to
ENDARG, so that `do` after a literal should be `do_block` and
bound to the outer method. [ruby-core:72482] [Bug #11873]
* parse.y (parse_ident): revert r56198.
* pars...
nobu (Nobuyoshi Nakada)
02:19 PM Revision 0e547e63 (git): test_syntax.rb: more test_warn_balanced
* test/ruby/test_syntax.rb (test_warn_balanced): more assertions
for a symbol literal and a local variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56272 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:01 PM Revision e9fa5495 (git): * NEWS: news about Warning.warning. [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56271 b2dd03c8-39d4-4d8f-98ff-823fe69b080e shyouhei (Shyouhei Urabe)
01:37 PM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
`secure` sounds vague, and `compare` doesn't address the point by shyouhei, I think. nobu (Nobuyoshi Nakada)
12:44 PM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
Rack and Rails uses `secure_compare`.
- http://www.rubydoc.info/github/rack/rack/Rack/Utils.secure_compare
- http://api.rubyonrails.org/classes/ActiveSupport/SecurityUtils.html#method-c-secure_compare
znz (Kazuhiro NISHIYAMA)
12:20 PM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
Ok, here are couple suggestions, to keep the carriage rolling.
~~~
#safe_eql?
#secure_eql?
#timesafe_eql?
#timingsafe_eql?
~~~
aledovsky (Aleksandrs Ļedovskis)
09:07 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
(Just to be clear) what is bad about the word "memcmp" is that the "cmp" part implies returning integers, rather than true/false. One of such example that returns integer is String#casecmp. But almost nobody wants integers for timing-s... shyouhei (Shyouhei Urabe)
12:53 PM Bug #12792 (Closed): cannot open https://bugs.jruby.org/4176
https://bugs.jruby.org/4176 in r56260.
But I cannot open it because connection refused.
znz (Kazuhiro NISHIYAMA)
12:13 PM Revision 078dcd26 (git): * test/ripper/test_ripper.rb: fix squiggly heredoc identifier
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56270 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
10:25 AM Feature #12299: Add Warning module for customized warning handling
Sorry, I was too busy to merge this before preview2. shyouhei (Shyouhei Urabe)
09:19 AM Feature #12299 (Closed): Add Warning module for customized warning handling
Applied in changeset r56269.
----------
* error.c: This makes all warnings raised call Warning.warn, which
by default does the same thing it does currently
(rb_write_error_str). You can override Warning.warn to change
the beha...
shyouhei (Shyouhei Urabe)
09:54 AM Feature #12790: Better inspect for stdlib classes
Maybe it would be nice to use a formatting like sprintf's %g?
So numbers without a huge exponent would print just like floats.
Actually, following how Float are printed would be consistent (1.234e+57, 12.34, etc),
while keeping the ex...
Eregon (Benoit Daloze)
09:00 AM Feature #12790: Better inspect for stdlib classes
> https://github.com/ruby/ruby/compare/trunk...nobu:feature/12790-bigdecimal%23inspect
So, you decided to leave scientific notation for any amounts? Could we talk about that?.. It is really hard not to make small mistakes comparing va...
zverok (Victor Shepelev)
08:37 AM Feature #12790: Better inspect for stdlib classes
> As for Date and DateTime, do you still need/use them?
Why not? It is a common pattern seen everywhere to use `Date` when you need, just, err, date (e.g. emphasize the fact that "this variable is granulated to days").
About `Date...
zverok (Victor Shepelev)
02:13 AM Feature #12790: Better inspect for stdlib classes
I agree about `BigDecimal` almost.
`Prec` may be useful but `MaxPrec` would be rarely.
And for huge `BigDecimal`, I prefer `_` separated representation like `Integer`.
https://github.com/ruby/ruby/compare/trunk...nobu:feature/12790-bi...
nobu (Nobuyoshi Nakada)
09:19 AM Revision 4e60f998 (git): * error.c: This makes all warnings raised call Warning.warn, which
by default does the same thing it does currently
(rb_write_error_str). You can override Warning.warn to change
the behavior. [ruby-core:75016] [Feature #12299]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@562...
shyouhei (Shyouhei Urabe)
08:42 AM Bug #12588: When an exception is re-raised in the "rescue" clause, the back trace does not contain the line in that clause
Hiro Asari wrote:
> I am not sure how I can use `Exception#cause`.
Exception#cause makes sense when you raise another exception from inside of a rescue clause. Take a look at this example:
```ruby
def foo
raise 'raised in #f...
shyouhei (Shyouhei Urabe)
08:35 AM Revision a38b2f84 (git): iseq.c: syntax error in compile_file
* iseq.c (iseqw_s_compile_file): deal with syntax error as well as
compile, and should not abort when rescued.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56268 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
08:35 AM Revision 2ca58e42 (git): assertions.rb: success option
* test/lib/test/unit/assertions.rb (assert_in_out_err): add
success option to check the exit status.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56267 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
08:32 AM Bug #12787 (Feedback): Stackoverflow over when alias_method and prepend are used in combination
Which version of ruby are you using? because I can't reproduce the stack overflow using 2.3.1 on my machine.
```
% ruby -v ~/Downloads/stackoverflow_with_alias_and_prepend
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin15]...
shyouhei (Shyouhei Urabe)
07:06 AM Feature #12142: Hash tables with open addressing
tiny fix for string hash function.
branch is updated with force.
mbox re-uploaded: https://bugs.ruby-lang.org/attachments/download/6160/hash_improvements_and_st_array_with_open_addressing.mbox
funny_falcon (Yura Sokolov)
06:23 AM Revision b15f7655 (git): iseq.c: kwarg to compile
* iseq.c (iseqw_s_compile, iseqw_s_compile_file): allow keyword
arguments as the options.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56266 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
05:34 AM Revision 802e5677 (git): iseq.c: file name encoding
* iseq.c (iseqw_s_compile): keep the encoding of file name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
05:26 AM Revision eb937455 (git): ChangeLog: remove extra line
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56264 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
03:50 AM Revision 17901bbc (git): fix a typo [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56263 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
03:17 AM Bug #12791 (Closed): Don't allow ,-separator for cookie
Applied in changeset r56262.
----------
* lib/cgi/cookie.rb (parse): don't allow , as a separator. [Bug #12791]
* lib/webrick/cookie.rb (parse): ditto.
naruse (Yui NARUSE)
03:11 AM Bug #12791 (Closed): Don't allow ,-separator for cookie
RFC2965 allowed both ; and , as a separator for cookie, but RFC6265 only allows ;.
Moreover CVE-2016-7401 uses , as a separator to overwrite CSRF-token.
https://gist.github.com/mala/457a25650950d4daf4144f98159802cc
naruse (Yui NARUSE)
03:17 AM Revision 5f33c6b0 (git): * lib/cgi/cookie.rb (parse): don't allow , as a separator. [Bug #12791]
* lib/webrick/cookie.rb (parse): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56262 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)
 

Also available in: Atom