Activity
From 09/23/2016 to 09/29/2016
09/29/2016
-
11:44 PM Feature #12138: Support `Kernel#load_with_env(filename, cbase: SomeMod, cref: someMod, binding: SomeMod) # => obj`
- Yukihiro Matsumoto wrote:
> I understand the need for load() with context, but this proposal has
> ...
I don't understand what "proven sufficient" entails. Is there a metric I could use to know it was achieved? -
09:00 PM Bug #12801 (Closed): Bug while developing a Rails app
- I don't what happened and I'm not investigating also. The reason I'm reporting is because I read the message in the end that said "Bug reports are welcome.".
app_1 | Started GET "/assets/url(%22bootstrap.min.css.map%22)" for 172.1... -
07:29 PM Feature #12142: Hash tables with open addressing
- I still don't like open-addressing here. But code looks clearer.
And it is better to have common than different when Christmas is so close.
Ruby team will accept (or not accept) whatever they like to accept (or to not accept).
I don... -
03:50 PM Feature #12142: Hash tables with open addressing
- Yura Sokolov wrote:
> Good day, everyone.
> ...
Yura, I am glad that finally you accepted open address tables. Now
there is no major differences between my original table proposal and
your current implementation. Although there are... -
02:40 PM Revision c249453c (git): * lib/yaml/store.rb (YAML::Store#dump): use table argument instead of @table directly.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56294 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56293 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:43 PM Bug #12800 (Closed): YAMLStoreTest#test_thread_safe hang - Applied in changeset r56291.
----------
fix YAML::Store
* lib/yaml/store.rb (YAML::Store#initialize): Fix arguments.
[ruby-dev:49821] [Bug #12800]
* test/yaml/test_store.rb: Add tests from test/test_pstore.rb.
* test/yaml/test_stor... -
- `lib/yaml/store.rb` のテストがなかったので、`test/test_pstore.rb` を元に `test/yaml/test_store.rb` を作ってみたところ、`YAMLStoreTest#test_thread_safe` で止まってしまいました。
原因を調べてみたところ、
- `PStore` は `def initialize(file, thread_safe = false)`
- `YAML::Store` は `d... - 01:43 PM Revision b9814bee (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56292 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/yaml/store.rb (YAML::Store#initialize): Fix arguments.
[ruby-dev:49821] [Bug #12800]
* test/yaml/test_store.rb: Add tests from test/test_pstore.rb.
* test/yaml/test_store.rb (YAMLStoreTest#test_with_options): Add options test.
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56290 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:33 AM Revision 46bbb62b (git): parse.y: deferred_dots_gen
- * parse.y (deferred_dots_gen): extract for tDOT2 and tDOT3.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56289 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * appveyor.yml (install): try sourceforge.net mirror to download
zlib source.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56288 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread_sync.c (rb_queue_pop, rb_szqueue_push, rb_szqueue_pop):
Document exception types, ThreadError, raised by Queue and
SizedQueue. [Fix GH-1451]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56287 b2dd03c8-39d4-4d8f-98ff-8... - 10:21 AM Revision b1d24240 (git): * 2016-09-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56286 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * thread_sync.c (Init_thread_sync): Remove confusing doc comments,
which are picked up by rdoc unexpectedly, from Queue and
SizedQueue. [Fix GH-1450]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56285 b2dd03c8-39d4-4d8f-98ff-8... -
07:36 AM Feature #12020: Documenting Ruby memory model
- As the previous comments mention we had a meeting to discus memory
model at RubyKaigi. There were about fifteen Ruby implementers siting around the
table from MRI, JRuby, JRuby+Truffle, and OMR.
The first meeting started by exchangi... -
- I discovered an old [patch] for this issue.
This enables the following code, but doesn't seem useful to me.
```ruby
obj = Struct.new(:a, :b).new(1, 2)
bind = obj.instance_eval {binding}
RubyVM::InstructionSequence.compile("a + b")...
09/28/2016
-
05:52 PM Bug #12799 (Closed): IPAddr#== throws an exception with objects that can't be converted to IPAddr
- I accidentally deleted issue #12779. It was created by https://bugs.ruby-lang.org/users/11301
----
Description
IPAddr#== uses IPAddr#coerce_other to attempt to convert the 'other' object into an IPAddr for comparison.
If this c... -
- While `Kernel#warn` should be generous since it is a public API,
`Warning.warn` is a method called by the internal and should be strict. -
- `Kernel#warn` accepts `nil` and `1`, but `Warning.warn` raises `TypeError`.
Is this difference expected?
```
% ruby -ve 'warn nil; Warning.warn nil'
ruby 2.4.0dev (2016-09-28 trunk 56281) [x86_64-linux]
-e:1:in `warn': wrong arg... -
- Applied in changeset r56284.
----------
PStore: select checksum algorithm
* lib/pstore.rb (PStore::CHECKSUM_ALGO): find available hashing
algorithm for checksum. MD5 is not available in FIPS mode.
[Feature #6943] -
- * lib/pstore.rb (PStore::CHECKSUM_ALGO): find available hashing
algorithm for checksum. MD5 is not available in FIPS mode.
[Feature #6943]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56284 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/test_pstore.rb (PStoreTest#test_thread_safe): handshake by
queues, and reduce sleeping time.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56283 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Please report to the sqlite3-ruby project.
-
11:51 AM Bug #12797: Crash after rails test
- spring stop also helps... otherwise rails test crashes again.
-
- While running rails test for the second or further times, the command line reports a crash - every time. Restarting the command line allows me to run a test.
I'm sure that this is not a bug, but I can't find a solution for my problem.... -
07:40 AM Bug #8221 (Closed): 2 AES-128-GCM (probably same in AES-256-GCM) bug?
- Fixed by the following commits at ruby/openssl.
1. AES-GCM ciphers does not have uppercase short name
https://github.com/ruby/openssl/commit/2ed10db12deb114066443b4a0f1ffd49a8f612b2
2. The ordering issue of key and IV
... -
- It's not a bug. Calling #to_der against an empty OpenSSL::X509::Request has always returned invalid DER encoding of a CSR, because the mandatory parameters are missing.
It's OpenSSL 1.0.1i that changed the behavior by the way (your 1.... -
- It's an already fixed bug, and 2.3.1 has been released.
-
05:07 AM Bug #12796 (Closed): Segmentation fault at ~/.rvm/gems/ruby-2.3.0@global/gems/did_you_mean-1.0.0/lib/did_you_mean/spell_checkers/name_error_checkers/variable_name_checker.rb:10: [BUG]
- Hi,
This is my first bug report so am sorry for missing out any wanted data.
I am using Ruby 2.3.0p0 with Rails 4.2.5. The ruby process crashes when running minitest tests for ActiveJob. The line causing the issue is
`user.update... -
- * ext/strscan/strscan.c (minl): extract to reduce repeated S_LEN.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56282 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/strscan/strscan.c (strscan_getch, strscan_peek),
(strscan_rest_size, inspect2): use S_RESTLEN consistently.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56281 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * signal.c (sig_signame): [DOC] Add documentation in the case of
return nil. [Fix GH-1449]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56280 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:49 AM Revision ca17c5d1 (git): * .travis.yml: delete comments. They were outdated. [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56279 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Please report to the sqlite3-ruby project.
-
01:13 AM Bug #12795 (Third Party's Issue): Bug when using Rails Console to query ActiveRecord - Segmentation fault
- Encountered a bug when trying to use Rails Console (with Pry gem) to quesry and interact with activerecord. Everything had been working fine, only system change has been to upgrade to MacOS this past week.
steps to reproduce:
Enter... -
- * lib/rubygems.rb, lib/rubygems/*, test/rubygems/*: Update
rubygems to 2.6.7, not the master, with r56225.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56278 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/rubygems.rb, lib/rubygems/*, test/rubygems/*: Update
rubygems to 2.6.7.
Release note of 2.6.7: https://github.com/rubygems/rubygems/commit/60f35bd1d2359fc30301d2d4cd72bc6833e8d12a
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr... -
- Are we going to add this method under OpenSSL namespace? If so "secure" describes almost nothing.
My suggestion is to add `String#casecmp?` (proposed in #12786) first, then introduce this one with `OpenSSL.memcmp?` naming.
09/27/2016
-
09:11 PM Bug #12794 (Rejected): Invalid ASN1 from OpenSSL::X509::Requests
- Running #to_der and #to_pem when linked to OpenSSL 1.0.1g+ outputs invalid ASN1. It seems to output valid ASN1 with 1.0.1f. It appears that the last object identifier field is missing in the invalid output. Output from the openssl too...
-
06:09 PM Revision cc00f5bf (git): * ChangeLog: fix typo of r56271. [ci skip]
- * NEWS: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56276 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r56274.
----------
error.c: check argument of Warning.warn
* error.c (rb_warning_s_warn): the argument must be an
ASCII-compatible string. [ruby-core:77430] [Bug #12793] -
- `Warning.warn` with non-string argument causes SEGV.
For example, `Warning.warn nil`. - 03:21 PM Revision cdd5a94a (git): * 2016-09-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56275 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * error.c (rb_warning_s_warn): the argument must be an
ASCII-compatible string. [ruby-core:77430] [Bug #12793]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56274 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (symbol, dsym, parser_set_number_literal): set state to
ENDARG, so that `do` after a literal should be `do_block` and
bound to the outer method. [ruby-core:72482] [Bug #11873]
* parse.y (parse_ident): revert r56198.
* pars... -
- * test/ruby/test_syntax.rb (test_warn_balanced): more assertions
for a symbol literal and a local variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56272 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56271 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- `secure` sounds vague, and `compare` doesn't address the point by shyouhei, I think.
-
- Rack and Rails uses `secure_compare`.
- http://www.rubydoc.info/github/rack/rack/Rack/Utils.secure_compare
- http://api.rubyonrails.org/classes/ActiveSupport/SecurityUtils.html#method-c-secure_compare -
12:20 PM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
- Ok, here are couple suggestions, to keep the carriage rolling.
~~~
#safe_eql?
#secure_eql?
#timesafe_eql?
#timingsafe_eql?
~~~
-
- (Just to be clear) what is bad about the word "memcmp" is that the "cmp" part implies returning integers, rather than true/false. One of such example that returns integer is String#casecmp. But almost nobody wants integers for timing-s...
-
- https://bugs.jruby.org/4176 in r56260.
But I cannot open it because connection refused. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56270 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Sorry, I was too busy to merge this before preview2.
-
- Applied in changeset r56269.
----------
* error.c: This makes all warnings raised call Warning.warn, which
by default does the same thing it does currently
(rb_write_error_str). You can override Warning.warn to change
the beha... -
09:54 AM Feature #12790: Better inspect for stdlib classes
- Maybe it would be nice to use a formatting like sprintf's %g?
So numbers without a huge exponent would print just like floats.
Actually, following how Float are printed would be consistent (1.234e+57, 12.34, etc),
while keeping the ex... -
09:00 AM Feature #12790: Better inspect for stdlib classes
- > https://github.com/ruby/ruby/compare/trunk...nobu:feature/12790-bigdecimal%23inspect
So, you decided to leave scientific notation for any amounts? Could we talk about that?.. It is really hard not to make small mistakes comparing va... -
- > As for Date and DateTime, do you still need/use them?
Why not? It is a common pattern seen everywhere to use `Date` when you need, just, err, date (e.g. emphasize the fact that "this variable is granulated to days").
About `Date... -
- I agree about `BigDecimal` almost.
`Prec` may be useful but `MaxPrec` would be rarely.
And for huge `BigDecimal`, I prefer `_` separated representation like `Integer`.
https://github.com/ruby/ruby/compare/trunk...nobu:feature/12790-bi... -
- by default does the same thing it does currently
(rb_write_error_str). You can override Warning.warn to change
the behavior. [ruby-core:75016] [Feature #12299]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@562... -
- Hiro Asari wrote:
> I am not sure how I can use `Exception#cause`.
Exception#cause makes sense when you raise another exception from inside of a rescue clause. Take a look at this example:
```ruby
def foo
raise 'raised in #f... -
- * iseq.c (iseqw_s_compile_file): deal with syntax error as well as
compile, and should not abort when rescued.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56268 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/test/unit/assertions.rb (assert_in_out_err): add
success option to check the exit status.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56267 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Which version of ruby are you using? because I can't reproduce the stack overflow using 2.3.1 on my machine.
```
% ruby -v ~/Downloads/stackoverflow_with_alias_and_prepend
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin15]... -
- tiny fix for string hash function.
branch is updated with force.
mbox re-uploaded: https://bugs.ruby-lang.org/attachments/download/6160/hash_improvements_and_st_array_with_open_addressing.mbox -
- * iseq.c (iseqw_s_compile, iseqw_s_compile_file): allow keyword
arguments as the options.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56266 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * iseq.c (iseqw_s_compile): keep the encoding of file name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56264 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56263 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:17 AM Bug #12791 (Closed): Don't allow ,-separator for cookie
- Applied in changeset r56262.
----------
* lib/cgi/cookie.rb (parse): don't allow , as a separator. [Bug #12791]
* lib/webrick/cookie.rb (parse): ditto. -
- RFC2965 allowed both ; and , as a separator for cookie, but RFC6265 only allows ;.
Moreover CVE-2016-7401 uses , as a separator to overwrite CSRF-token.
https://gist.github.com/mala/457a25650950d4daf4144f98159802cc -
- * lib/webrick/cookie.rb (parse): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56262 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/26/2016
- 09:12 PM Revision f0137ba8 (git): * 2016-09-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56261 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:12 PM Revision fbaa8233 (git): * test/ripper/test_ripper.rb: add a test for dedent_string.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56260 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:37 PM Feature #12790: Better inspect for stdlib classes
- I agree, I'd also love to have a better inspect representation for big decimals and dates.
-
- `#inspect` is important for understanding "what I have" in irb/pry, and in [puts-debugging](https://tenderlovemaking.com/2016/02/05/i-am-a-puts-debuggerer.html), and in ton of other cases.
Sadly, some of important stdlib classes (in m... -
- Good day, everyone.
I'm adding alternative patch version for st_table.
It is my compromise with Vladimir and his proposals.
I really count and mention Vladimir Makarov as co-author of this version.
- It uses open-addressing with ... -
06:27 PM Feature #12075: some container#nonempty?
- I know `any?` works on some use cases, but I'm positive to have a proposed method because using `any?` has a pitfall. We have to guarantee an array doesn't have only false or nil. Also I'm worrying users who started to use `any?` for thi...
-
- See also #9725, my issue/request relating to NameError's behavior of carrying the target object and causing huge inspect-driven memory bloat when attempting to print the message.
-
- reopen as per request (seems like it is no longer a bug ticket but a feature request?)
-
- ruby_2_3 r56259 merged revision(s) 56117,56118.
-
- * variable.c (rb_const_search): raise with the actual class/module
name which defines the private constant.
* variable.c (rb_const_search): warn with the actual class/module
name which defines the deprecated ... -
- * ext/openssl/ossl_pkcs12.c (ossl_pkcs12_initialize): pop errors
leaked by PKCS12_parse(). This is a bug in OpenSSL, which exists
in the versions before the version 1.0.0t, 1.0.1p, 1.0.2d.
git-svn-id: svn+ssh://ci.r... -
02:26 PM Bug #11133: Wrong Hyperlink representation in man page
- Akinori MUSHA wrote:
> Sorry for the delay, and thanks for spotting it.
> ...
Yes, it should be fixed, there was this [1] ticket referenced in the original gnome-terminal bug [2]. Testing on Fedora Rawhide with:
$ rpm -q gnome-termi... -
- ruby_2_3 r56257 merged revision(s) 56030,56035.
-
- * vm_dump.c (backtrace): use rip in the saved context for the case
the SIGSEGV is received when the process is in userland.
Note that ip in the stack should be used if the signal is received
when it is in ke... -
02:04 PM Feature #12788: Improve String lstrip and strip performance
- Ary Borenszweig wrote:
> Thank you Nobu-san for reviewing and accepting this. Matsuda-san also mentioned a "patch monster" in his talk, I think now I know what he means :-)
🤘🏻 -
12:51 PM Feature #12788: Improve String lstrip and strip performance
- Thank you Nobu-san for reviewing and accepting this. Matsuda-san also mentioned a "patch monster" in his talk, I think now I know what he means :-)
-
- Applied in changeset r56250.
----------
string.c: fast path of lstrip_offset
* string.c (lstrip_offset): add a fast path in the case of single
byte optimizable strings, as well as rstrip_offset.
[ruby-core:77392] [Feature #12788] -
- This adds a fast path for lstrip_offset in the case of single byte optimizable strings. This optimization already exists in rstrip_offset but I noticed it was missing in rstrip.
I made sure to only remove ascii space, not '\0', to pre... - 12:39 PM Revision c2e59df3 (git): Remove Ns before puctuation
- * man/erb.1, man/irb.1, man/ri.1, man/ruby.1: Remove Ns before
puctuation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56256 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:35 PM Bug #5244 (Closed): Continuation causes Bus Error on Debian sparc
- > This may still be a problem on Solaris sparc64 where the link stage fails thus :
No, different issue from the original report.
The error message shows that the symbol "asm" is not found.
With "-Xc" option (strict ISO C mode), "a... -
- (Just reopening... Sorry I don't have this specific hardware so can't reproduce)
-
11:41 AM Bug #12789 (Closed): syntax error keyword_do_block at ruby 2.4.0dev (2016-09-26 trunk 56254)
- ruby 2.4.0dev (2016-09-26 trunk 56254) にて、ブロック付きの特異メソッド呼び出しの前に、
同名の変数への代入があると syntax error になりました。以下、サンプルコードです。
```
% cat syntax_error.rb
class A
def self.foo(&block)
puts 'hello'
end
foo = nil
foo do
end
e... -
- * tool/downloader.rb: revert workarounds.
* tool/gem-unpack.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56255 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Let me change this ticket's status to be a third party's issue for a while. Please just reopen this if it turns out to be a ruby's fault.
-
- OK, closing as per request.
-
- Would you mind if I close this ticket?
-
- Let me reject this (a FAQ).
-
- * test/ruby/test_exception.rb (test_throw_false): test the thrown
tag. [Bug #12743]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56254 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/stringio/stringio.c (strio_seek): Avoid signed integer overflow.
It's not harmful in practice here, but is still undefined behavior.
* ext/stringio/stringio.c (strio_extend): Check that the new length does
not exceed LONG_MAX.... - 06:43 AM Bug #12743 (Closed): throw(false) does not work as expected
- Applied in changeset r56252.
----------
eval_intern.h: make TH_PUSH_TAG() initialize rb_vm_tag::tag with Qundef
* eval_intern.h (TH_PUSH_TAG): Initialize struct rb_vm_tag::tag with
Qundef rather than 0 which is equal to Qfalse. Since... -
- * eval_intern.h (TH_PUSH_TAG): Initialize struct rb_vm_tag::tag with
Qundef rather than 0 which is equal to Qfalse. Since Kernel#throw(obj)
searches a tag with rb_vm_tag::tag == obj, throw(false) can
accidentally find an unrelated ... -
05:55 AM Feature #11965: provide default basename parameter Tempfile.create
- I also wanted to have default basename parameter for Tempfile.create as Tempfile.new, and found this issue.
I believe nobody have objections to this change, so committed to trunk.
If anyone has any objections, please let me know.
Th... -
- Applied in changeset r56251.
----------
* lib/tempfile.rb: provide default basename parameter
for Tempfile.create. [Feature #11965] Patch by Yuki Kurihara
* test/test_tempfile.rb: ditto. -
- for Tempfile.create. [Feature #11965] Patch by Yuki Kurihara
* test/test_tempfile.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Even though it's a bug, the behavior change could break existing applications. I won't backport into ruby_2_3 branch.
-
- * string.c (lstrip_offset): add a fast path in the case of single
byte optimizable strings, as well as rstrip_offset.
[ruby-core:77392] [Feature #12788]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56250 b2dd03c8-39d4-4d8f-98ff... -
- * gems/bundled_gems: update to minitest-5.9.1.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56249 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/rbinstall.rb (gem): Don't install gemspec if no files will be
installed for the gem. This happens when the extension library is not
compiled.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56248 b2dd03c8-39d4-4d8f-98ff-823... -
- wanabe san, thank you for your great investigation!
Sasada san, could you take a look at the lines wanabe san pointed out? -
-
- * string.c (enc_strlen, rb_enc_strlen_cr): Avoid signed integer
overflow. The result type of a pointer subtraction may have the same
size as long. This fixes String#size returning an negative value on
i686-linux environment:
s... -
12:56 AM Bug #12588: When an exception is re-raised in the "rescue" clause, the back trace does not contain the line in that clause
- The current stacktrace is misleading. Without line 4 in it, the implication is that the exception was found on line 2, and was not caught by `rescue`. In this simple case, the stack trace should contain lines `[4,7]`, not `[2,7]`.
I a...
09/25/2016
- 10:29 PM Revision b1de2a16 (git): * 2016-09-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56246 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/-ext-/win32/test_dln.rb (test_check_imported): use toplevel
constants explicitly to get rid of constants under the scope.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56245 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- workaround for certificate expiration of minitest-5.8.3.gem.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56244 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_3 r56243 merged revision(s) 56166.
-
- * lib/uri/generic.rb (def check_password): don't include bad password
in URI exception output
* test/uri/test_generic.rb (def test_set_component): test for behavior
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branche... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56242 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:23 PM Revision fe5e7688 (git): * 2016-09-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56241 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- workaround for certificate expiration of minitest-5.8.3.gem.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56240 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_args.c (make_unknown_kw_hash, make_rest_kw_hash): split
make_unused_kw_hash for key_only parameter.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56239 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/erb.rb (ERB::Compiler::TrimScanner#stag): The :stag accessor
has already been available because it is defined in parent
Scanner class. [Fix GH-1445]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56238 b2dd03c8-39d4-4d8f-9... -
- * proc.c (rb_proc_arity): reduce repeated GetProcPtr.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:23 AM Revision 55ce57d8 (git): * 2016-09-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56236 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:23 AM Revision dd3ccb8b (git): * node.c (dump_array): remove duplicate header of NODE_ARRAY/
- NODE_VALUES.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56235 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_3 r56234 merged revision(s) 56036,56041.
-
- * io.c (nogvl_fsync, nogvl_fdatasync): on Windows, just ignore if the
fd is associated to non-disk device. if call fsync and/or fdatasync
with such fds, it causes Errno::EBADF exception and the behavior is
... -
- ruby_2_3 r56233 merged revision(s) 56111.
-
- * array.c (flatten): use rb_obj_class instead of rb_class_of
because rb_class_of may return a singleton class.
[ruby-dev:49781] [Bug #12738]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56233 b2dd03... -
- ruby_2_3 r56232 merged revision(s) 55984.
-
- * man/irb.1: remove useless -width option.
[ruby-dev:49767] [Bug #12692]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56232 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:43 AM Bug #12778 (Closed): Segmentation Fault in win32ole on Ruby 2.3.1p112 [x64-mingw32] when creating Windows Share
-
- Thank you for your reporting.
This issue is same as #11880.
And I confirmed it works in ruby 2.3.2p182.
09/24/2016
-
06:47 PM Bug #12787 (Closed): Stackoverflow over when alias_method and prepend are used in combination
- With Ruby 2.0 Module#prepend was used to overcome the drawbacks of alias_method_chaining. Most of the gems/projects still use alias_method_chain since they support 1.9.3 and with upcoming gems/projects using prepend for the method that i...
-
- Thank you for report. But tk has been extracted trunk branch.
Can you submit your patch to https://github.com/ruby/tk via pull request?
Thank you. -
- * appveyor.yml (install): extract zlib source under ext/zlib and
build within the build process.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56231 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/extmk.rb (extract_makefile, extmake, configuration): store
extra libraries to be installed.
* tool/rbinstall.rb (ext-arch): install extra libraries.
* ext/zlib/extconf.rb: install zlib if built.
git-svn-id: svn+ssh://ci.ruby-lan... -
- * appveyor.yml (install): use pre-installed OpenSSL-Win64.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56229 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56228 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * appveyor.yml (install): use AppVeyor command-line utility to
download files, instead of Start-FileDownload cmdlet which no
longer works more than once.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56227 b2dd03c8-39d4-4d8f-98f... -
- Did anybody saw this?..
-
08:35 AM Feature #12786: String#casecmp?
- Some thoughts on method naming...
* New method: `#casecmp?`
* **PROS:** Nice symmetry with `Fixnum`'s `#<=>` & `#equal?` methods. 'casecmp' seems to imply case-insensitivity (see `String#casecmp` or C's `strcasecmp`)
* **CONS:**... -
- Martin Dürst wrote:
> Does it only compare for equality (after case folding)?
Yep. All it would do is check if the return value of `#casecmp` is equal to zero. I'm sure there are plenty of clever uses for `#casecmp`, but I've only ... -
02:53 AM Feature #12786: String#casecmp?
- Can you describe exactly what `String#casecmp?` method would do? Does it only compare for equality (after case folding)?
This proposal is interesting, because `String#upcase`/`downcase`/`capitalize`/`swapcase` now work for all of Unic... -
- Description
I would find String#casecmp? convenience method handy. I don't believe I've ever called String#casecmp without chaining #zero? to the result.
```ruby
'abc'.casecmp?('ABC') #=> true
'abc'.casecmp?('DEF') #=> false
``` -
- Martin Dürst wrote:
> I'm confused. You only give arguments for rejection, but then reopen the issue.
My private opinion is I don't need this.
But I don't want to rule out my being wrong-headed.
The OP might have other use-case whe... -
- Shyouhei Urabe wrote:
> Reopened.
> ...
I'm confused. You only give arguments for rejection, but then reopen the issue. -
- Reopened.
Though I have never needed to write such long regexp literals inline, privately.
Whenever I wanted multine superb regexps they are named, most likely become constants.
For variable/constant assignments, %r perfectly works.... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56226 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * fix typos, "a" before "Integer" to "an". [Fix GH-1438]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56225 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Great. I'm looking forward.
-
- Applied in changeset r56224.
----------
test_ruby_mode.rb: fix for Emacs 25.1
* test/misc/test_ruby_mode.rb (assert_indent): since write-region
in Emacs 25.1 no longer displays the "Wrote file" message, shows
the explicit message t... -
- * test/misc/test_ruby_mode.rb (assert_indent): since write-region
in Emacs 25.1 no longer displays the "Wrote file" message, shows
the explicit message to check if successfully finished.
[ruby-core:77355] [Bug #12785]
git-svn-id: ... - 01:18 AM Revision 1181ecbb (git): * 2016-09-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56223 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/misc/test_ruby_mode.rb (EXPR_SAVE): use a numeric prefix
argument of 0, not to make the previous version into a backup
file, instead of backup-inhibited.
* test/misc/test_ruby_mode.rb (run_emacs): always save the buffer
if m...
09/23/2016
-
- I check with following diff, file is saved.
```diff
diff --git a/test/misc/test_ruby_mode.rb b/test/misc/test_ruby_mode.rb
index a91e1c2..36009f8 100644
--- a/test/misc/test_ruby_mode.rb
+++ b/test/misc/test_ruby_mode.rb
@@ -35,6... -
- Does `save-buffer` in Emacs 25.1 print nothing?
Or did it fail? -
02:59 PM Revision 5a121a4f (git): * vm_method.c (make_method_entry_refined): fix wrong use of ||.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56221 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/zlib/extconf.rb: no feature checks when building zlib from
the source, assume it is recent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56220 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/zlib/extconf.rb: fix directory to install zlib library.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56219 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > It successfully runs for less than 50 dots, and then one of the threads errors out. I don't think it should.
Ok, I can't count...it does run through one full iteration and then probably fails because the autoload doesn't actually lo... - 12:40 PM Revision 9d5bc13f (git): Add support for the `Lk` macro to tool/mdoc2man.rb
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56218 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56217 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56216 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r56213.
----------
* eval.c (rb_mod_refine): refine modules as well.
[ruby-core:76199] [Feature #12534] - 11:46 AM Revision 47ebf735 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56215 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:46 AM Revision 415d7a03 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56214 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [ruby-core:76199] [Feature #12534]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56213 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:31 AM Bug #11133 (Feedback): Wrong Hyperlink representation in man page
- Sorry for the delay, and thanks for spotting it.
I've replaced the use of the `Pa` macro with `Lk` in r56211. The `Lk` macro was added to mdocml a long time ago, which I didn't notice when I committed r39640.
As for the original p... - 11:21 AM Revision 0b5a4e68 (git): Update the paragraphs in "Rich Libraries" which included a dead link
- * man/ruby.1: Update the paragraphs in "Rich Libraries" which
included a dead link.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56212 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:21 AM Revision 7c30df71 (git): Use the `Lk` macro for hyperlinks
- * man/ruby.1, man/erb.1, man/irb.1, man/ri.1: Use the `Lk` macro
for hyperlinks, which has been available since mdocml 1.5.1
(released more than seven years ago).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56211 b2dd03c8-39d4... -
- Hi Shyouhei, sorry for not doing it so far, I took vacation to travel Japan right after the conference. It is already on my todolist when I get back.
-
- Can someone summarize the off-line discussion mentioned earlier? I was not there.
-
- Yes, it sounds serious. But so far I'm not successful in reproducing the error. Can you show us a bit more detailed instruction how to actually see this bug on my machine?
-
- Sorry, this platform (arch and libc) is not actively supported officially I think.
I'm happy to introduce a fix if someone have one. -
- Thanks for reporting!
Fixed at upstream by commit:
https://github.com/ruby/openssl/commit/0e49794521db899ab25774e932f83d6ce452a8ec -
- Applied in changeset r56210.
----------
forwardable.rb: private methods
* lib/forwardable.rb (_delegator_method): allow private methods to
be delegated, with warnings. [ruby-core:77341] [Bug #12782] -
- * lib/forwardable.rb (_delegator_method): allow private methods to
be delegated, with warnings. [ruby-core:77341] [Bug #12782]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56210 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/fileutils/test_fileutils.rb: use Dir.mktmpdir instead of
fixed name for temporary directory.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56209 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (iseq_peephole_optimize): enable tail call
optimization inside a conditional block.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:32 AM Revision 9ec75a25 (git): * 2016-09-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56207 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- .gitignore: ignore all versions of unicode data.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e