Activity
From 09/07/2016 to 09/13/2016
09/13/2016
-
11:49 PM Bug #12758: Error when passing Hash construction to function
- This is in FAQ.
Please see http://ruby-doc.org/docs/ruby-doc-bundle/FAQ/FAQ.html#s6 : "6.7 Why can't I pass a hash literal to a method: p {}?"
And you can pass a hash to method without braces when it is last argument.
```
irb(mai... -
05:11 PM Bug #12758 (Rejected): Error when passing Hash construction to function
- I apologize if this is a known issue but I couldn't find it in the search.
If you have a function that can take a Hash, it behaves correctly if you pass a variable that contains the Hash compared to when you pass in a Hash construct... - 10:22 PM Revision 202bbda2 (git): * 2016-09-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56159 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:22 PM Revision d51aea54 (git): * hash.c (each_pair_i_fast): use rb_yield_values2 to avoid var args.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56158 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:55 PM Bug #12548: Rounding modes inconsistency between round versus sprintf
- Ah - looks like the ReXML docs don't need to change. The round-even mode Ruby uses is still referred to as "round to nearest, ties to even" - https://en.wikipedia.org/wiki/IEEE_floating_point#Roundings_to_nearest
-
05:12 PM Feature #12744: Add str.reverse_each_char and str.reverse_chars
- Shyouhei Urabe wrote:
> I doubt if we can make a reverse_each_char which is faster than reverse.each_char. It ls not always clear where is a boundary between a character and another, especially when scanning backwards. We might end up... -
12:21 AM Feature #12744: Add str.reverse_each_char and str.reverse_chars
- I doubt if we can make a reverse_each_char which is faster than reverse.each_char. It ls not always clear where is a boundary between a character and another, especially when scanning backwards. We might end up scanning whole string fr...
-
03:51 PM Feature #12752: Unpacking a value from a binary requires additional '.first'
- There is more concise way:
length, = str.unpack('C')
You cannot use this in a method chain, though.
I actually understand your frustration, but I feel no difference between `str.unpack('C', 0)` and `str.unpack('C')[0]`.
-... -
12:46 PM Feature #12754: Want to use prepared buffer with `Array#pack`
- `Array#pack` provides `@` for `offset`.
-
12:33 PM Revision 00fcd967 (git): string.c: avoid signed integer overflow
- The behavior on signed integer overflow is undefined. On platform with
sizeof(long)==4, it's fairly easy that 'len + termlen' overflows, where
len is the string length and termlen is the terminator length.
So, prevent the integer overfl... -
- Use PRIuSIZE instead of PRIdSIZE. This fixes the exception message shown
on too large xmalloc2. This commit also fixes other incorrect use of
PRIdSIZE in other functions; though most of them are debug print.
* gc.c (heap_extend_pages, g... -
- * string.c (STR_EMBEDDABLE_P): Renamed from STR_EMBEDABLE_P(). And use
it in more places.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56155 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:26 PM Revision df1c68b2 (git): README{,.ja}.md: Drop support for BeOS now that Haiku is stable since 2.3.0. [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56154 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56152 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * string.c (STR_EMBEDABLE_P): extract the predicate macro to tell
if the given length is capable in an embedded string, and fix
possible integer overflow.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56151 b2dd03c8-39d4-4d8f-98... -
09:39 AM Revision d4faa101 (git): * test/ruby/test_exception.rb: fix thread issues.
- * use Queue instead of a local variable for synchronization.
* join created thread to soleve leaking threads warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56150 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (rb_str_change_terminator_length): fix integer overflow
in the case growing the terminator length and the string length
is around LONG_MAX.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56149 b2dd03c8-39d4-4d8f-98ff-8... -
07:36 AM Feature #6647: Exceptions raised in threads should be logged
- Responding to 2.4.0-preview2 announcement on ruby-core. I have the opinion that a good default for Thread.report_on_exception is $VERBOSE, with this mapping:
nil - no reporting
false (-W1) - report exception on thread GC which is l... -
07:10 AM Feature #12694: Want a String method to remove heading substr
- Naotoshi Seo wrote:
> Python lstrip http://www.tutorialspoint.com/python/string_lstrip.htm takes character classes as an argument, so providing a substring as an argument will introduce confusion.
"character classes" may be confusi... -
07:08 AM Bug #12757 (Closed): Wrong overflow check in rb_str_set_len() - Applied in changeset r56148.
----------
string.c: fix buffer overflow check condition in rb_str_set_len()
* string.c (rb_str_set_len): The buffer overflow check is wrong. The
space for termlen is allocated outside the capacity return... -
- string.c:
~~~c
void
rb_str_set_len(VALUE str, long len)
{
long capa;
const int termlen = TERM_LEN(str);
str_modifiable(str);
if (STR_SHARED_P(str)) {
rb_raise(rb_eRuntimeError, "can't set length of sh... -
- * string.c (rb_str_set_len): The buffer overflow check is wrong. The
space for termlen is allocated outside the capacity returned by
rb_str_capacity(). This fixes r41920 ("string.c: multi-byte
terminator", 2013-07-11). [ruby-core:... -
- * test/openssl/test_ssl.rb (test_ctx_options): Add a workaround for
patched OpenSSL to fix the Ruby CI failure on Ubuntu 16.04.
http://rubyci.s3.amazonaws.com/ubuntu/ruby-trunk/log/20160913T033003Z.fail.html.gz
This commit is a che...
09/12/2016
-
09:11 PM Misc #12756 (Closed): Increase test coverage and stylistic changes for URI::HTTP
- Hello,
I increase test coverage for URI::HTTP class. Also I added some stylistic changes to code and documentation.
You can find PR in github:
https://github.com/ruby/ruby/pull/1427
Thanks. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56146 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Martin Dürst wrote:
> What about using
> ...
I don't really have a use case for reverse_chars, but I added it for symmetry with the other methods. I meant str.reverse_each_char, I typo'd it in the issue but it's correct in the patch. T... - 03:40 PM Feature #12364 (Closed): Copy superclass serial number to singleton subclasses for better IMC hits
- Applied in changeset r56144.
----------
Copy the serial number from the super class to the singleton class
This helps hit inline method caches more frequently. Before this
commit:
```
[aaron@TC ruby (trunk)]$ time ./ruby -v benchmark... - 03:40 PM Revision 332723a2 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56145 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:40 PM Revision c4c53310 (git): Copy the serial number from the super class to the singleton class
- This helps hit inline method caches more frequently. Before this
commit:
```
[aaron@TC ruby (trunk)]$ time ./ruby -v benchmark/bm_vm2_poly_singleton.rb
ruby 2.4.0dev (2016-09-12 trunk 56141) [x86_64-darwin15]
real 0m3.679s
user 0m3.... - 03:16 PM Revision fd8fa1b2 (git): * 2016-09-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56143 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:16 PM Revision 774442d2 (git): * time.c (time_arg): guard for mswin64 CI.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56142 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I'd like to propose Ruby to have a infrastructure optimizing its execution.
My implementation and detailed explanation of how it works can be found at
https://github.com/ruby/ruby/pull/1419
I guess, I don't necessarily think that ab... -
06:59 AM Feature #12754 (Closed): Want to use prepared buffer with `Array#pack`
- `Array#pack` always returns new allocated `String`, but sometimes users want to use prepared buffer, especially the packed size is too large.
I often uses `Fiddle` to call OS APIs, and encounter this problem as every time.
I recommend ... -
06:47 AM Feature #12753 (Closed): Useful operator to check bit-flag is true or false
- Ruby's 0 is truthy value. It's useful for many cases, but it's confusing and I made many bugs when I'm writing code to handle binary data, because my thought is almost same with one to write C code in such situation.
```ruby
n = get_... -
- When I parsed a binary protocol (msgpack) by `String#unpack`, there are many similar expressions, like below:
```ruby
str = io.read(1)
length = str.unpack('C').first
case length
when 4
data = io.read(4).unpack('N').first
# ...... -
- META ticket for Ruby 3's breakages
* Encoding on Windows
* [Feature #12654]
* [Feature #12650] -
-
- Vit Ondruch wrote:
> Not only this, but the test suite also needs connection to internet to succeed. No other test needs this so far and I hope it will stay like that.
There are many parts in Ruby that (would) need connection to th... -
04:50 AM Misc #12750 (Closed): Increase test coverage for URI::MailTo
- Fixed at r56139
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:46 AM Revision 5ffc89f6 (git): * 2016-09-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56140 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- with class method.
* test/uri/test_mailto.rb: Added tests for coverage.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56139 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09/11/2016
-
10:51 PM Bug #12749: 2.4 preview で gem をインストールできません
- Preview はRuby本体だけで、zlibなどは別途用意する事と理解しました。
お手数ですが close にしていただけますか。
-
- gem をインストールしようとするとエラーになります。
zlib が足りないようですが、対処方法がわかりませんでした。
preview はやはり敷居が高いですね。
~~~
> gem list
*** LOCAL GEMS ***
bigdecimal (default: 1.2.8)
did_you_mean (1.0.2)
io-console (default: 0.4.6)
json (defau... -
09:05 PM Feature #12142: Hash tables with open addressing
- > So hypothetically, even
an attacker spends huge CPU time
Why not GPU time? Why not FPGA? It is really not that expensive.
Edit: and there is no real need in exact 64bit match to forge python style open addressing.
> ...
And I t... -
08:50 PM Feature #12142: Hash tables with open addressing
- Yura Sokolov wrote:
> > Still I can make a patch quickly which completely eliminates this issue
> ...
After some thoughts, I believe the security issue (collision
exploitation) we are discussing is not a problem for my implementation.... -
- Hello,
I increase test coverage for URI::MailTo class. You can find PR in github:
https://github.com/ruby/ruby/pull/1426
Thanks. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56138 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56137 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56136 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56135 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r56134.
----------
* ChangeLog: added refs. [Bug #12748] [ruby-dev:49786] -
-
- あー、なるほど、バグですね。
これは2.4から入ったコードなので2.3以前で起きないのも納得です。
直しておきます。 -
- io.c の io_fwrite() に問題があるようです。
この関数内で #ifdef _WIN32 内の、rb_w32_write_console() と、その下の io_binwrite() の両方が呼び出されるために、2回出力されています。
リダイレクトすると片方だけになります。
~~~
> ruby -e 'p 1'
# io_fwrite: rb_w32
handle: 14c ... -
- あ、ソースをいじってコンパイルが試せるのであれば話が早いかもです。
`win32/win32.c`の`rb_w32_write_console`の中にある、7123行目または7132行目の
`WriteConsleW`が実際の出力処理になります。
そのどっちが呼ばれてるか、またその時引数`ptr`および`len`(または`curlen`)がどうなってるか、
というあたりを観察すると、何かわかるかもしれません。 -
- 現在の環境で
ruby 2.3.0p0 (2015-12-25 revision 53290) [i386-mingw32]
を常用していますが、この問題は始めてです。
なお、io.c の rb_io_puts() の string: ラベル以降を
~~~
string:
puts("# before");
rb_io_write(out, line);
puts("# end");
~~~
と書き換えたとこ... -
- 残念ながら、当方の手元(Win7, Win10 / vc10, vc12, vc14 / x86, x64)では再現することができませんでした。
そちらの環境では、例えば過去のバージョンのrubyでは問題はなかったのでしょうか？ -
- irb ではなく、ruby の出力そのものがおかしいようです。
~~~
*****@*****-PC C:\usr\local\bin
> type test.rb
STDOUT.puts 'stdout.hello'
STDERR.puts 'stderr.hello'
*****@*****-PC C:\usr\local... - 10:17 AM Revision 96046868 (git): * ChangeLog: added refs. [Bug #12748] [ruby-dev:49786]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56134 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:08 AM Revision 73bbccf4 (git): * 2016-09-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56133 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:08 AM Revision ee0a79b3 (git): * win32/win32.c (rb_w32_write_console): should set writen length as the
- return value.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56132 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/10/2016
-
- irbを実行すると次のように評価結果が2回表示されます。
副作用のある呼び出しをしても副作用そのものは1回だけ実行されているので、表示上だけの問題でないかと思います。
作成： Visual Studio 2015 Community
実行： Windows 10 Pro 64bit
~~~
*****@*****-PC C:\usr\local\bin
> irb ... -
08:28 AM Bug #12554 (Rejected): yamlに渡すファイルポインタを自分でcloseしないと動作が変
- そういうときのためにブロック付きメソッドがあるので、次のように書いてください。
open( file , 'w') {|f| YAML.dump(data , f ) } - 08:16 AM Revision d432af3d (git): * 2016-09-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56131 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * doc/extension.rdoc (rb_check_arity): described.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56130 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:36 AM Feature #12747 (Closed): Add TracePoint#callee_id
- # Abstract
I propose to add TracePoint#callee_id which returns the called name of the method.
~~~ruby
def m
end
alias am m
TracePoint.new(:call) do |tp|
p [tp.method_id, tp.callee_id] #=> [:m, :am]
end.enable do
am
end... -
- I tried [this], found rake defines `Fixnum::MAX` which seems useless, and submitted a [PR] to rake.
But it fails on ruby 2.2 or earlier, due to incompatibility of Bundler 1.13.0.
[this]: https://github.com/ruby/ruby/compare/trunk...n... -
-
- What about using
`str.reverse.chars` for `string.reverse_chars`?
It allocates some memory, but compared to all the memory allocated for the individual characters, the memory for the overall reversed string is not a big deal. Also, ...
09/09/2016
-
08:59 PM Feature #12746 (Closed): class Array: alias .prepend to .unshift ?
- This code works:
array = %w( b c ) # => ["b", "c"]
array.unshift "a"
array # => ["a", "b", "c"]
I would like for .prepend to also work on class Array.
Rationale:
I found myself to sometimes .prepen... -
07:20 PM Feature #12734: `Array#flat?`
- This is pretty trivial to implement yourself:
~~~ruby
class Array
def flat?
none?{|e|e.is_a?(Array)}
end
end
[1,2,3].flat?
=> true
[1,[2,3]].flat?
=> false
~~~
I have to agree with Nobuyoshi Nakada that I don't re... -
- Just news share:
Python landed same dict algo for 3.6
https://mail.python.org/pipermail/python-dev/2016-September/146327.html
(same to Vladimir's approach)
And PyPy did it more than year ago
https://morepypy.blogspot.ru/2015/01... -
- > Still I can make a patch quickly which completely eliminates this issue
without any slowdown in my hashing for numbers
Please, do it now. So no one will ever argue.
> ...
hash of integers it will take several months on modern su... -
- A simplified (and stupid) example: replace some placeholders in a string with function calls
~~~ruby
def placeholder(val)
raise 'Incorrect value' unless val == 'three'
'3'
end
str = '1.2.[three].4'
str.gsub!(/\[(\w+)\]/) {... -
04:48 PM Feature #12733: Bundle bundler to ruby core
- Hiroshi SHIBATA wrote:
> * bundler uses rspec for test suites. How to use rspec on ruby core repository?
Not only this, but the test suite also needs connection to internet to succeed. No other test needs this so far and I hope it w... -
- This patch adds `str.reverse_each` and `str.reverse_chars`. It's currently not really possible to iterate a Ruby string in reverse while guaranteeing that you're not accidentally introducing an O(N^2) bug, without encoding to a fixed-len...
-
- I expect UncaughtThrowError for these examples:
~~~
$ ruby -e'throw false'
-e: unexpected throw
$ ruby -e'Fiber.new{throw false}.resume'
$ ruby -e'Thread.new{throw false}.join'
-e:1: [BUG] thread_join: THROW_DATA should not reach... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56127 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:09 PM Bug #12742 (Closed): backport r56117 (fix private constant message) and r56118 (fix deprecated constant message)
- バックポート管理用チケットです。
-
- * test/json/json_generator_test.rb (test_broken_bignum): get rid
of use of Bignum, obsolete name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56126 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r56125.
----------
thread.c: set cause by Thread#raise
* thread.c (rb_threadptr_raise): set cause from the called thread,
but not from the thread to be interrupted.
[ruby-core:77222] [Bug #12741] -
- * thread.c (rb_threadptr_raise): set cause from the called thread,
but not from the thread to be interrupted.
[ruby-core:77222] [Bug #12741]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56125 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * doc/extension.rdoc, doc/extension.ja.rdoc: fix file name.
pointed out by @takkanm in the RubyKaigi talk.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56124 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56123 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:08 AM Feature #12086: using: option for instance_eval etc.
- Charles Nutter wrote:
> > Yes, you'll get unexpected results in this case.
> ...
Ah, I was wrong...in both cases you get *expected* results because cref is newly created by each call of instance_eval(using:).
I tried the following c... -
01:20 AM Feature #12086: using: option for instance_eval etc.
- > Yes, you'll get unexpected results in this case.
I think you'd get unexpected results in my original case too, wouldn't you? Both of those two blocks still have the same prev_cref, which is where the refinements collection comes fro... -
- * object.c (InitVM_Object): update rdoc of NIL/TRUE/FALSE, and use
rb_deprecate_constant.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56120 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * variable.c (rb_deprecate_constant): new function to deprecate a
constant by the name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56119 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * variable.c (rb_const_search): warn with the actual class/module
name which defines the deprecated constant.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56118 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * variable.c (rb_const_search): raise with the actual class/module
name which defines the private constant.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56117 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:49 AM Revision bef96f5a (git): * 2016-09-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56116 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/e2mmap.rb (Exception2MessageMapper::E2MM.def_exception):
remove legacy code. Symbol is no longer a number already.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56115 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/08/2016
-
- Charles Nutter wrote:
> Yes, it appears that every call to instance_eval(using: Foo ...) blows away the global method cache by calling rb_using_module. So one library using instance_eval+using *will* hurt performance for every method ca... -
- Charles Nutter wrote:
> I have threading concerns.
> ...
Do you mean the following case?
```ruby
b = Proc.new { 1 + 1 }
Thread.new { eval_with_my_refinements(X, &b) }
Thread.new { eval_with_my_refinements(Y, &b) }
```
> I don... -
- Thomas Enebo wrote:
> What is the scope of instance_eval here? Can I do:
The answer is yes, in my original proposal. But It may be possible to prohibit these uses.
If we add such a restriction, the following way suggested by Cha... -
08:23 PM Bug #12741 (Closed): Timeout with specified exception class sets cause on error if timeout block is handling an exception when timeout occurs
- If `Timeout.timeout` is called with an exception class explicitly specified in the second argument, then if a timeout does occur while the underlying code wrapped by the Timeout block is handling an exception, that exception will bubble ...
-
- Thank you for reporting! There are already RDoc comments but it looks like RDoc couldn't find them.
Now they show up in the generated HTML:
OpenSSL::SSL::SSLContext#servername_cb: http://ruby.github.io/openssl/OpenSSL/SSL/SSLContex... -
02:44 PM Misc #12740 (Closed): Document OpenSSL::SSL::SSLSocket hostname attribute for SNI (Server Name Indication) Support
- I've been adding SNI support to the MongoDB Ruby driver and I've had to use the *hostname* attribute of a SSLSocket. It's not in the documentation but I think it should be so that others can find out how to added SNI support as well.
... -
- How about `class Object; deprecate_constant :Fixnum, :Bignum; end`?
* naruse supports: https://twitter.com/nalsh/status/773800491671101441
* akr objects: https://twitter.com/tanaka_akr/status/773817391218249729
I don't mind either... -
- * io.c (rb_file_initialize): check if fd is an Integer but not a
Fixnum.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56112 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r56111.
----------
* array.c (flatten): use rb_obj_class instead of rb_class_of
because rb_class_of may return a singleton class.
[ruby-dev:49781] [Bug #12738] -
- Array#flattenで生成されたオブジェクトがflattenのレシーバと特異クラスを共有してしまっています。
~~~ruby
a = []
class << a
def m; :m; end
end
p a.flatten.m #=> :m
~~~
-
- because rb_class_of may return a singleton class.
[ruby-dev:49781] [Bug #12738]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56111 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/rbinstall.rb (gem): use the bindir of each gemspec instead
of hardcoded 'bin', since rdoc 5.0.0 overrides it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56110 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r56109.
----------
* eval.c (rb_mod_s_used_modules): rename Module.used_refinements to
Module.used_modules. [Feature #7418] [ruby-core:49805] -
- Shugo Maeda wrote:
> `Module.used_modules` might be a better name, because a module can have more than one refinement:
Matz said that he thinks so too at https://twitter.com/yukihiro_matz/status/773787246990196736, so I'll change the... -
- > Module.used_refinements accepted.
`Module.used_modules` might be a better name, because a module can have more than one refinement:
```
module M
refine A
end
refine B
end
end
using M
p Module.used_modules #=> ... -
- Module.used_modules. [Feature #7418] [ruby-core:49805]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56109 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- https://github.com/ruby/ruby/compare/trunk...nobu:feature/12695-homedir
-
- This issue will be addressed by #9451 and #11476.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56107 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- How about to provide Module#defined_refinements, which returns the refinements defined in the receiver as a Hash, as follows:
```
module M
refine String do
$M_String = self
end
refine Integer do
$M_Integer = self... -
- * enc/unicode/data/9.0.0 (svn:ignore): ignore downloaded files.
see r55716 for 8.0.0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56105 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r56104.
----------
* ext/psych/psych.gemspec, lib/rdoc/rdoc.gemspec: Use file list instead of
git output. It shows warning message when invoke `make install`
[Bug #12736][ruby-dev:49778] -
- rubygemsにこれを行うメソッドを追加すべきなんじゃないでしょうかね。
-
- 数が多くて厳しいのですがハードコードする方向に修正します。
-
- git output. It shows warning message when invoke `make install`
[Bug #12736][ruby-dev:49778]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56104 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:57 AM Revision 577de1e9 (git): replace fixnum by integer in documents.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56102 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Please explain the use-case.
It doesn't seem useful to me. -
- Applied in changeset r56101.
----------
* insns.def (setclassvariable, setconstant): warn when self is a
refinement. [Bug #10103] [ruby-core:64143] -
- refinement. [Bug #10103] [ruby-core:64143]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56101 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:34 AM Revision 0a764c0b (git): NEWS: Add Hash#transform_values
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56100 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:33 AM Feature #12512 (Closed): Import Hash#transform_values and its destructive version from ActiveSupport
- Applied in changeset r56099.
----------
hash.c: map_v -> transform_values
* hash.c (rb_hash_transform_values, rb_hash_transform_values_bang):
Rename map_v to transform_values.
[Feature #12512] [ruby-core:76095]
* test/ruby/test_ha... - 02:33 AM Revision eaa0a27f (git): hash.c: map_v -> transform_values
- * hash.c (rb_hash_transform_values, rb_hash_transform_values_bang):
Rename map_v to transform_values.
[Feature #12512] [ruby-core:76095]
* test/ruby/test_hash.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56099 b2dd0... -
- * {ext,test}/openssl: Import Ruby/OpenSSL 2.0.0.beta.2. The full commit
history since v2.0.0.beta.1 can be found at:
https://github.com/ruby/openssl/compare/v2.0.0.beta.1...v2.0.0.beta.2
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/t...
09/07/2016
-
- Fixed ri parse defect with left-hand matched classes.
https://github.com/rdoc/rdoc/pull/420
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56097 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r56094.
----------
* eval.c (rb_mod_s_used_refinements): new method
Module.used_refinements. based on the patch by Charlie
Somerville. [Feature #7418] [ruby-core:49805] -
07:14 AM Feature #7418: Kernel#used_refinements
- `Module.used_refinements` accepted.
Matz.
- 04:15 PM Revision bf51c067 (git): * 2016-09-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56096 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:15 PM Revision 806eb7e1 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56095 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Module.used_refinements. based on the patch by Charlie
Somerville. [Feature #7418] [ruby-core:49805]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56094 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Yes, it appears that every call to instance_eval(using: Foo ...) blows away the global method cache by calling rb_using_module. So one library using instance_eval+using *will* hurt performance for every method call, in the same way that ...
-
- I have threading concerns.
```ruby
module X; refine Fixnum do; def +(x); puts "X refined"; super; end; end; end
module Y; refine Fixnum do; def +(y); puts "y refined"; super; end; end; end
def eval_with_my_refinements(refinemen... -
- Is this thread-safe? Would it be possible for two threads to refine the same block in different ways and step on each other?
I see that instance_eval (yield_under) creates a new cref for each instance_eval call...but if I'm reading it... -
- I'll echo Tom's comments...this is dynamically-scoped refinements all over again, which we discussed heavily. There's two big reasons why this is a risk:
* Performance. We decided that refinements would be lexical *only* in order to l... -
08:10 AM Feature #12086: using: option for instance_eval etc.
- What is the scope of instance_eval here? Can I do:
~~~ ruby
instance_eval(using: MyRefinements), &a_block_from_somewhere)
~~~
Or how about?
~~~ ruby
instance_eval(using: MyRefinements), &objectWhichhasToProc)
~~~
Either ... -
02:12 PM Feature #12299: Add Warning module for customized warning handling
- Matz accepted this mechanism about a month ago, and shortly thereafter I added a patch with his requested change. Can this be patch be applied before 2.4.0-preview2?
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56093 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56092 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- `make install` の時に `fatal: Not a git repository (or any of the parent directories): .git` というメッセージが2回出ます。
ext/psych/psych.gemspec と lib/rdoc/rdoc.gemspec の
```
s.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(tes... -
10:55 AM Feature #12735 (Feedback): TCP Server documentation improvement
- Between version 2.0.0 and 2.3.1, documentation has shrunk a lot.
It could be useful to keep the original content
and add the example TCPServer.new('0.0.0.0', 2000) to receive a connection from any PC connected to the network -
10:35 AM Feature #12695: File.expand_path should resolve ~/ using /etc/passwd when HOME is not set
- Bash seems to do that:
% bash -c 'unset HOME; echo ~'
/home/knu
As far as I tested most other known shells like tcsh, zsh, ash, dash and pdksh do not, but we could follow the best.
Through my testing, I found fish unique in tha... -
- Makes sense. Ruby knows how to resolve ~user, so you may well expect it to resolve ~ as well given that the login name is identified.
-
- I think its good idea.
Although POSIX doesn't specify it for shell, we can define it in Ruby.
-
10:29 AM Feature #12734 (Closed): `Array#flat?`
- It might be useful to have a method that determines whether an array is flat, i.e. one-dimensional.
~~~ruby
[1, 2, 3].flat? #=> true
[1, [2, 3]].flat? #=> false
~~~
The result should be equivalent to `ary == ary.flatten` (with... -
- We can find if the commit cause SEGV...
-
-
- Unfortunately `ailas bar2 bar` is totally valid Ruby code. I recommend using syntax highlighting.
Matz.
-
- Even though OpenSSL uses the name `memcmp`, I re-considered it is a bad name.
Therefore this is back to naming issue. -
- * include/ruby/util.h (setenv): remove POSIX-noncompliant
definition with 2 arguments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56091 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Use `%r`.
Matz.
-
- removing directories/files related to Unicode version 8.0.0
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56090 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I don't see any "reasonable expectancy". Use-case? Probably you want to use `Exception#cause`?
Matz.
-
- Applied in changeset r56089.
----------
timeout.rb: custom error message
* lib/timeout.rb (Timeout#timeout): add custom error message
argument. [Feature #11650] -
- Accepted.
Matz.
-
- * lib/timeout.rb (Timeout#timeout): add custom error message
argument. [Feature #11650]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56089 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r56087.
----------
* common.mk: Updated Unicode version to 9.0.0 [Feature #12513]
* unicode/9.0.0/casefold.h, name2ctype.h, unicode/data/9.0.0:
new directories/files for Unicode version 9.0.0 - 08:13 AM Revision 62e8ceae (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56088 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * unicode/9.0.0/casefold.h, name2ctype.h, unicode/data/9.0.0:
new directories/files for Unicode version 9.0.0
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56087 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I understand the implementation difficulty. If we prohibit `super` in refined methods in Modules, is it possible to refine modules?
If it's reasonably possible, I'd like to accept this.
Matz.
-
07:51 AM Feature #12694: Want a String method to remove heading substr
- PHP has ltrim and rtrim (which is an alias of chop), but they are for removing a character list, not removing a substring http://php.net/manual/en/function.ltrim.php
```
ltrim('foaofe', 'foa'); #=> 'e'
```
Elixir has trim_leading... -
- It seems python, perl does not have similar methods (which removes heading substr)
-
- We discussed about this ticket on ruby development meeting.
Python lstrip http://www.tutorialspoint.com/python/string_lstrip.htm takes character classes as an argument, so providing a substring as an argument will introduce confusion.... -
- This method removes prefix string, so I propose `remove_prefix` or `deprefix` (means remove prefix).
-
-
-
- Unlike `included` and `inherited`, `using` is static operation. I don't think hooks work well with refinement.
Matz.
-
- Below example shows 2nd thread overwrites 1st thread's regexp match result.
```sh
% ruby -e 'P = proc {|s| p [s, $~]; sleep 1; /foo.*/=~s; sleep 1; p [s,$~] }; def foo; Thread.new{P.call("foobar")}; sleep 0.2; Thread.new{P.call("foo"... -
- Accepted.
The current behavior is according to the direct interpretation of the refinement spec. But many people expect `send` to be another form of a method call (including refinement). And now I agree with it.
Matz -
- * class.c (ins_methods_i, ins_methods_prot_i, ins_methods_priv_i),
(ins_methods_pub_i): check for each conditions to match.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56086 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I now think it's OK to accept this proposal. But I don't know how difficult to implement the issue.
Matz.
-
07:28 AM Feature #12733: Bundle bundler to ruby core
- Won't this make it harder to update bundler?
-
- rubygems team has plan to migrate bundler into rubygems at rubygems 3.0.
ref. https://github.com/rubygems/rubygems/issues/1681
In current status, rubygems only use `Bundler` module on test suites.
But we should track rubygems upst... -
- Applied in changeset r56085.
----------
lib/open-uri.rb: Allow http to https redirection.
* lib/open-uri.rb: Allow http to https redirection.
Note that https to http is still forbidden.
[ruby-core:20485] [Feature #859] by Roman Sht... -
- * lib/open-uri.rb: Allow http to https redirection.
Note that https to http is still forbidden.
[ruby-core:20485] [Feature #859] by Roman Shterenzon.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56085 b2dd03c8-39d4-4d8f-98ff-... -
- committed at r56083.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56084 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Adding a slide to show code I'm actually writing vs want to write
-
- I would like to be able to pass an option to `Integer()` and `Float()` so that they don't raise an exception, but return `nil` instead. For example:
~~~
Integer(string, exception: false)
~~~
The reason I want this function is so... -
- Ok, I will introduce `transform_values` (not `map_v` nor `map_values`).
I wanted a `Hash` generation method in `Enumerable` (e.g. `map_kv`), and the proposed method name to be consistent with the name.
But I found out that they are n... -
- if no block is given. [ruby-core:75346] [Feature #11058]
* test/csv/test_row.rb: add test for above.
* test/csv/test_table.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56083 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56082 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This version fixed following pull requests.
https://github.com/tenderlove/psych/pull/284
https://github.com/tenderlove/psych/pull/276
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56081 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:51 AM Revision 2861d8b1 (git): * 2016-09-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56080 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This version is mostly same as r56072. It contains to remove code
for Ruby 1.8
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56079 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:03 AM Feature #3511: rb_path_to_class should call custom const_defined? methods
- Thanks for considering!
I've opened a new ticket and described my concrete use case, as I don't see a way to reopen this one.
https://bugs.ruby-lang.org/issues/12731
-
- (This is a continuation of #3511, as I don't see a way to reopen the ticket, as Matz requested there.)
I'm sorry to be a pain, but I've given this more thought and I think this is still worth considering.
My current use case is a R...