Activity
From 05/08/2016 to 05/14/2016
05/14/2016
-
11:21 PM Revision 6d4fb98e (git): random.c: clear seed
- * random.c (rand_init): clear packed seed value explicitly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55004 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:43 PM Revision 9be98516 (git): * 2016-05-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55003 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:43 PM Revision 3b4e68cf (git): * iseq.h (struct iseq_compile_data): use struct rb_id_table
- instead of st_table.
* iseq.c (prepare_iseq_build): don't allocate ivar_cache_table
until it has at least one element.
* iseq.c (compile_data_free): free ivar_cache_table only if it
is allocated.
* compile.c (get_ivar_ic_value): a... -
05:47 PM Bug #12379: mkmf.rb `pkg-config --exists`と`pkg-config --libs`の呼び出し方法が異なり期待した結果にならない(OS X)
- ruby_2_3 r55001 merged revision(s) 54999.
-
12:04 AM Bug #12379 (Closed): mkmf.rb `pkg-config --exists`と`pkg-config --libs`の呼び出し方法が異なり期待した結果にならない(OS X)
- Applied in changeset r54999.
----------
lib/mkmf.rb: use xsystem to pkg-config --exists
* lib/mkmf.rb (pkg_config): use xsystem consistently to set up
library path environment variable as well as latter pkg-config
calls. [ruby-dev... -
05:46 PM Revision 97888037 (git): merge revision(s) 54999: [Backport #12379]
- * lib/mkmf.rb (pkg_config): use xsystem consistently to set up
library path environment variable as well as latter pkg-config
calls. [ruby-dev:49619] [Bug #12379]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branche... -
12:00 PM Bug #12382 (Closed): Deprecated constants will not print out warning when accessed directly
- Hi,
the current behavior of `deprecate_constant` is a little confusing:
```ruby
module Namespace
module Deprecated
end
deprecate_constant :Deprecated
end
puts "Referenced access:"
Namespace::Deprecated # warning: c... -
11:14 AM Bug #12381 (Closed): ext/openssl classes' dup/clone don't work well
- They don't copy the underlying C level structures.
~~~ruby
ssl_ctx = OpenSSL::SSL::SSLContext.new
ssl_ctx.ciphers = "aNULL"
p ssl_ctx.ciphers
# => [["ADH-AES256-GCM-SHA384", "TLSv1.2", 256, 256], .. aNULL cipher suites ..]
new_... -
11:07 AM Bug #6567: Let OpenSSL::PKey::EC follow the general PKey interface
- I want to work on this before the release of openssl gem.
- EC#public_key returns an EC::Point, not an EC
I think it's better to add new #dup_public (or #public_pkey ?) method for each PKey types, rather than changing EC#public... -
08:28 AM Feature #12380: `Struct` as a subclass of `Class`
- Jeremy Evans wrote:
> You can't subclass Class in ruby:
I see.
> ...
At the moment, my motivation is only conceptual. We are able to do things the way it is now, but from OOP point of view, it is not desirable. It is just as goo... -
07:18 AM Feature #12380: `Struct` as a subclass of `Class`
- Tsuyoshi Sawada wrote:
> I propose that either `Struct` should be redefined as a subclass of `Class`, or a new class `StructClass` should be introduced as a subclass of `Class`, and take over the functionality of `Struct`.
You can't ... -
06:22 AM Feature #12380 (Open): `Struct` as a subclass of `Class`
- This issue is somewhat of the same flavor as #12374.
`Struct` has a constructor that creates a class:
~~~ruby
Struct.new(:foo)
# => #<Class:0x007f605f892cb0>
~~~
and this is the same situation with `Class`.
~~~ruby
Class.... -
01:09 AM Revision 005ee0e4 (git): ChangeLog: GitHub reference
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55000 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:04 AM Revision f37f881a (git): lib/mkmf.rb: use xsystem to pkg-config --exists
- * lib/mkmf.rb (pkg_config): use xsystem consistently to set up
library path environment variable as well as latter pkg-config
calls. [ruby-dev:49619] [Bug #12379]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54999 b2dd03c8-39d...
05/13/2016
-
05:15 PM Bug #12379 (Closed): mkmf.rb `pkg-config --exists`と`pkg-config --libs`の呼び出し方法が異なり期待した結果にならない(OS X)
- OS X 10.11.4上で
- rubyが/opt/localにインストールされている
- /opt/local/lib/libiconv.dylibがある
とき、gem ffiのインストールに失敗します。
~~~
% gem2.4 install --user-install ffi
:
Building native extensions. This could take a while...
ERROR: Error inst... -
04:44 PM Feature #12378 (Open): arbitrary size Random.new_seed
- https://github.com/ruby/ruby/compare/trunk...nobu:feature/Random.new_seed-prec
Related to #12357, a proposal to add an optional parameter, `precision` in bits, to `Random.new_seed`. -
04:36 PM Revision fc9bc883 (git): test_rand.rb: tests for seeds
- * test/ruby/test_rand.rb: tests for Random.raw_seed and
Random.new_seed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54998 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:28 PM Bug #12376: No error for elseif condition
- You may want to use a code lint tool, such as [rubocop](https://github.com/bbatsov/rubocop).
BTW, next quiz:
~~~
> a = 1
> ...
0
=> nil
~~~
--
Yusuke Endoh <mame@ruby-lang.org> -
12:40 PM Bug #12376: No error for elseif condition
- Of course.
Makes perfect sense.
I would say the way to handle this bugs in a pro-active way would be to use 100% coverage in the test suite.
I can not see how the bug would be missed with that.
TDD as a must in ruby like always.
Tha... -
11:51 AM Bug #12376 (Rejected): No error for elseif condition
-
11:37 AM Bug #12376: No error for elseif condition
- And most editors can high-light keywords, but not `elseif`, as shown in this page, FYI.
-
10:59 AM Bug #12376 (Closed): No error for elseif condition
- it's parsed like
``` ruby
a = 1
if a == 2
puts 2
elseif(a==1)
puts 1
else
puts 0
end
```
and the method `elseif` is not called in the false condition.
But you can find this kind of bugs using rubocop or other tool... -
10:59 AM Bug #12376: No error for elseif condition
- It is parsed as
~~~ruby
if a == 2
puts 2
elsif a == 3
puts 3
elseif(a == 1)
puts 1
else
puts 4
end
~~~
With `elseif` being just a method call. With this branch not evaluated, there is no problem with unknown met... -
10:41 AM Bug #12376 (Rejected): No error for elseif condition
- Something I have been for a long time wondering about.
I don't know if this is a parsing problem or not but for me it seems like it is.
Replication:
``` ruby
$ irb
> RUBY_VERSION
=> '2.3.0'
> ...
0
=> nil
```
Shouldn't ... -
03:16 PM Revision d009cebf (git): random.c: no local copy of the seed
- * random.c (make_seed_value): append leading-zero-guard and get
rid of making a local copy of the seed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54997 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:16 PM Revision 00a371c2 (git): * 2016-05-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54996 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:16 PM Revision 79850a08 (git): random.c: fill_random_seed size
- * random.c (fill_random_seed): move the seed size to an argument.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54995 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:56 PM Revision 678c39dc (git): random.c: clear buf
- * random.c (random_seed): clear temporary buffer explicitly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54994 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:01 PM Revision be33635c (git): fix typos [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:06 AM Bug #12377 (Closed): recipe for target 'do-install-nodoc' failed
- When compiling with
make up; make install-nodoc
I get the following error
```
installing default gems: /usr/local/lib/ruby/gems/2.4.0 (build_info, cache, doc, extensions, gems, specifications)
bi... -
09:34 AM Bug #12370: require 'mkmf' changes Object#respond_to? behaviour
- In this situation we have Module#public_method_defined? returning different things for classes and modules which makes sense from its definition where it gets all ancestors when called in a class.
Ex:
``` ruby
$ irb
> require 'mkmf... -
09:11 AM Bug #12370: require 'mkmf' changes Object#respond_to? behaviour
- Understood.
So what really makes sense to do is something like this:
``` ruby
$ irb
> require 'mkmf'
> ...
=> true
> YAML.public_methods.select {|m| m.to_s == 'configuration' }
=> [:configuration]
```
-
09:04 AM Feature #12375: Net::HTTP.post
- Usaku NAKAMURA wrote:
> Shugo Maeda wrote:
> ...
Ah, I forgot to consider consistency with Net::HTTP.get.
> Of course, to implement it is not so hard, so I believe you will do it before committing the patch :-)
It's easy to imple... -
08:22 AM Feature #12375: Net::HTTP.post
- Shugo Maeda wrote:
> * The first argument must be a URI object, but it might be better to accept a String.
It should accept the hostname and the path parameters, like Net::HTTP.get.
Of course, to implement it is not so hard, so I be... -
07:56 AM Feature #12375 (Closed): Net::HTTP.post
- Net::HTTP.post_form is convenient, but it's dedicated to application/x-www-form-urlencoded.
Why not provide Net::HTTP.post for other media types?
```
res = Net::HTTP.post(URI('http://www.example.com/api/search'),
... -
06:44 AM Feature #12275 (Open): String unescape
- Thank you. That makes sense to me because String#dump has no corresponding undump method now.
-
03:52 AM Bug #12371: Windows Nano Server WIN32OLE compatibility
- In Window Nano Server TP5, Microsoft has temporarily changed the behavior of `OleInitialize` internally to use `CoInitializeEx(NULL, COINIT_MULTITHREADED)` as a compatibility fix, despite what the spec / documentation says. It is unders...
05/12/2016
-
11:46 PM Revision da696ae7 (git): drop FreeBSD < 4 support
- * NEWS: drop FreeBSD < 4 support.
The most recent version affected by this is 3.5 and was released
in 2000.
https://www.freebsd.org/releases/3.5R/announce.html
https://en.wikipedia.org/wiki/History_of_FreeBSD#Version_history
git... -
11:39 PM Bug #12370 (Closed): require 'mkmf' changes Object#respond_to? behaviour
- `Module#public_method_defined?` is for instance methods.
`Object#respond_to?` is for its own methods.
They have no relationship. -
10:25 AM Bug #12370: require 'mkmf' changes Object#respond_to? behaviour
- Hi Nobu.
I discovered due to this bug in capybara-screenshot gem: [[https://github.com/mattheworiordan/capybara-screenshot/issues/162]]
And your right. I also think they should not use
``` ruby
require 'mkmf'
```
But when ... -
11:35 PM Revision 8cd05857 (git): extmk.rb: failures format
- * ext/extmk.rb: show extension failures in compilation-mode
friendly format.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:35 PM Revision 3bdf613a (git): defines.h: avoid redefinition
- * include/ruby/defines.h (GCC_VERSION_SINCE): get rid of
re-definition.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54990 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:21 PM Bug #12371: Windows Nano Server WIN32OLE compatibility
- In my tests `OleInitialize(NULL)` succeeded on Nano Server TP5 and reverse forwarders installed. Then it already is basically equivalent to `CoInitializeEx(NULL, COINIT_MULTITHREADED)` (everything else it does is printing two debugging m...
-
04:20 PM Bug #12371: Windows Nano Server WIN32OLE compatibility
- Yes, the behavior of `OleInitialize` is generally additive and per the docs at https://msdn.microsoft.com/en-us/library/windows/desktop/ms690134(v=vs.85).aspx, it is necessary to call before using any COM functions that use:
* Clipboa... -
01:58 AM Bug #12371 (Assigned): Windows Nano Server WIN32OLE compatibility
- Doesn't `CoInitialize` differ than `OleInitialize`?
-
06:30 PM Feature #12374: SingletonClass
- Sorry, for the last example, I meant:
~~~ruby
A = SingletonClass.new
~~~ -
06:28 PM Feature #12374 (Closed): SingletonClass
- I propose to have a class `SingletonClass`, a subclass of the class `Class`, to which all singleton classes belong. It should be the owner of all the properties that are specific to singleton classes. Also, the methods defined on `Single...
-
06:27 PM Revision 4e080d26 (git): fix typo in r54988
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54989 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:12 PM Revision b207e7cd (git): include/ruby/defines.h (GCC_VERSION_SINCE): moved from internal.h
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:12 PM Revision 07dd6fcc (git): * 2016-05-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:12 PM Revision ac11f944 (git): Use HAVE_BUILTIN___BUILTIN_CONSTANT_P
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54986 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:12 PM Revision 91e3c8b3 (git): * configurein: use alternative keyword
- to avoid macros conflicts with them.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54985 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:07 PM Feature #11090: Enumerable#each_uniq and #each_uniq_by
- Why introduce one more method if we can just implement `#uniq` (with or without block, sticking to `Array#uniq` semantics) for `Enumerable` and `Enumerator::Lazy`? With `Enumerator::Lazy` we do not need to create an array.
```ruby
mo... -
03:43 PM Feature #12275: String unescape
- I think yes, inverse of String#dump. I have user inputed string without qoutes, but it don't metter much.
-
02:12 PM Bug #12373: Optimize CSV#shift
- I update patches.
csv-shift-1.patch: Use **s1.start_with?(s2)** instead of **s1[0] == s2** and use **s1.end_with?(s2)** instead of **s1[-1] == s2**.
~~~
$ ruby csv-benchmark.rb
Warming up --------------------------------------
... -
07:10 AM Bug #12373: Optimize CSV#shift
- Thank you for your reply.
> You can replace str1[-1] == str2 with str1.end_with?(str2) too, three places.
Yes, That is my next plan.
I'm writing benchmark carefully.
Should I collect patches in this issue? -
02:05 AM Bug #12373: Optimize CSV#shift
- You can replace **`str1[-1] == str2`** with **`str1.end_with?(str2)`** too, three places.
-
12:45 AM Bug #12373 (Closed): Optimize CSV#shift
- I think that **`str1.start_with?(str2)`** is faster than **`str1[0] == str2`**.
Because **`str1.start_with?(str2)`** just call **`String#start_with?`**, But **`str1[0] == str2`** call **`String#[]`**, make new `String` object and call *... -
01:01 PM Revision b69cc4cc (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54984 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:19 AM Revision 2b7c7214 (git): extmk.rb: failed messages at the end
- * ext/extmk.rb: output failed configurations at the end, not to be
scrolled out.
TODO: show the message at the end of the whole build.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54983 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:12 AM Feature #12364: Copy superclass serial number to singleton subclasses for better IMC hits
- I don't have any objection about this change because it is not big change.
Did you measure not micro-benchmarks?
-
01:06 AM Bug #9569: SecureRandom should try /dev/urandom first
- @naruse Do you think it's inadequate for Linux users to fall back to getrandom(2)? If so, why?
-
12:48 AM Bug #10558 (Third Party's Issue): failing require digest.so on OSX statically compiled ruby
05/11/2016
-
07:23 PM Bug #12372 (Closed): Resolv::DNS does not fetch authority section resources when calling getresource(s)
- In some cases, for example, when trying to retrieve the nameservers of a domain, you need to ask authoritative servers:
~~~
> dig ns org
(...)
;; ANSWER SECTION:
org. 13729 IN NS a0.org.afilias-nst.info.
org. 13729 IN NS a2.o... -
05:58 PM Bug #12371 (Closed): Windows Nano Server WIN32OLE compatibility
- The `OleInitialize()` call used in WIN32OLE is not supported on Nano Server due to the fact that the STA COM model is not available:
https://github.com/ruby/ruby/blob/32674b167bddc0d737c38f84722986b0f228b44b/ext/win32ole/win32ole.c#L8... -
05:03 PM Bug #12370: require 'mkmf' changes Object#respond_to? behaviour
- The behavior of `Object#respond_to?` isn't changed.
Simply mkmf.rb defines `configuration` method.
```
$ ruby -rmkmf -e 'p method(:configuration)'
#<Method: Object(MakeMakefile)#configuration>
```
Just do not mix mkmf.rb unnece... -
02:25 PM Bug #12370 (Rejected): require 'mkmf' changes Object#respond_to? behaviour
- Replication steps:
``` ruby
$ irb
> RUBY_VERSION
=> '2.3.0'
> ...
=> false
> YAML.respond_to?(:configuration)
=> false
> ...
=> false
> YAML.respond_to?(:configuration)
=> true
```
``` ruby
Object.constants do |constant|... -
04:54 PM Revision 6ff3a8e3 (git): mkmf.rb: fix conflict in have_library
- * lib/mkmf.rb (try_func): get rid of conflict of declarations of
main(). checking local symbol reference does not make sense.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54982 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:39 PM Revision d6d8ea91 (git): win32: qsort_s
- * win32/Makefile.sub (HAVE_QSORT_S): disable on VS2012 too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54981 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:21 PM Revision 98c084b8 (git): * win32/Makefile.sub (HAVE_QSORT_S): use qsort_s only for Visual Studio
- 2012 or later, because VS2010 seems to causes a SEGV in
test/ruby/test_enum.rb.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54980 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:08 PM Revision cb459dbe (git): fix typo at ChangeLog
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54979 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:04 PM Revision 313f9694 (git): * 2016-05-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54978 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:04 PM Revision 0b8f8ac5 (git): * vm_insnhelper.c (vm_getivar): describe fast-path explicit
- (compiler frindly). [Bug #12274].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54977 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:50 PM Bug #12274 (Closed): accessing to instance variable should be fast.
- Applied in changeset r54976.
----------
* compile.c (iseq_compile_each): share InlineCache during same
instance variable accesses. Reducing memory consumption,
rasing cache hit rate and rasing branch prediction hit rate
are exp... - 12:50 PM Revision 44916ec4 (git): * compile.c (iseq_compile_each): share InlineCache during same
- instance variable accesses. Reducing memory consumption,
rasing cache hit rate and rasing branch prediction hit rate
are expected. A part of [Bug #12274].
* iseq.h (struct iseq_compile_data): introduce instan... -
12:38 PM Bug #12353: Regression with Marshal.dump on ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin15]
- Nobuyoshi Nakada wrote:
> I can't reproduce it.
> ...
The regression appears to be specific to ActiveSupport 4.1.15. If I try ActiveSupport 4.2.6, `Marshal.dump` behaves as expected. -
12:24 PM Revision ac8c23f1 (git): test_minitest_unit.rb: fix "random" sort
- * test/minitest/test_minitest_unit.rb (test_test_methods_random):
hack to fix the order by avoiding duplicate keys.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54975 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:31 AM Bug #9569 (Open): SecureRandom should try /dev/urandom first
- In general SecureRandom should work as it works on OpenBSD.
It uses arc4random_buf, which gathers entropy from /dev/urandom.
A problem of this direction is the risk of the vulnerability of arc4random_buf.
Other than recent BSDs incl... -
05:55 AM Bug #9569: SecureRandom should try /dev/urandom first
- George Koehler: you're missing the point: the OS RNG should be used instead of OpenSSL's. That isn't necessarily /dev/urandom on every platform. Clearly /dev/urandom is a poor candidate for Windows (CryptGenRandom or RtlGenRandom should ...
-
08:18 AM Revision be4b1c1e (git): util.c: qsort_s
- * util.c (ruby_qsort): use qsort_s if available, for Microsoft
Visual Studio 2005 (msvcr80.dll) and mingw.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:13 AM Revision d22cf0de (git): fix file name [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54973 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:35 AM Bug #12369 (Rejected): optionparseで引数の文字列が受け取れなくなる
-
06:10 AM Bug #12369 (Rejected): optionparseで引数の文字列が受け取れなくなる
- ```ruby
#test.rb
require "optparse"
OptionParser.new do |opt|
opt.on('-a', '--aaa=VAL') {|v| p "aaa", v }
opt.on('-b', '--bbb[=VAL]') {|v| p "bbb", v }
opt.on('-c', '--ccc(=VAL)') {|v| p "ccc", v }
opt.parse! ARGV
end
```
... -
05:42 AM Bug #12368 (Rejected): default encoding of Integer#chr
- 現状、`Integer#chr`は引数なしの場合には、
1. default internalが設定されていればそれを使う
2. default internalが`nil`ならASCII(-8BIT)とみなす
という挙動になっていますが、2の部分についてはかつてscript encodingのデフォルトがUS-ASCIIだった時代の名残のような気がします。
というわけで、2の場合にはscript encodingとみなすのが正しいのではないでしょうか。 - 01:33 AM Revision a3d2c119 (git): * 2016-05-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54972 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:33 AM Revision 4e3a98d3 (git): * ChangeLog: Remove trailing-whitespaces.
- [ci skip][fix GH-1348]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54971 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
05/10/2016
-
06:44 PM Bug #12359: Named captures "conflict" warning is unnecessary and limits uses of named captures
- I have worked around this for now in JRuby by modifying the warning to *only* fire if a named capture was previously declared as something other than a named capture.
The commit to JRuby is here: https://github.com/jruby/jruby/commit/... -
05:08 PM Bug #12359: Named captures "conflict" warning is unnecessary and limits uses of named captures
- Related Ruby issue: https://bugs.ruby-lang.org/issues/9623
I think the warning needs to be softened to allow repeat use in literal regexp at the very least.
-
12:46 PM Bug #12367 (Closed): [PATCH] Declaring an already defined class with Object as the new superclass does not raise an error
- Applied in changeset r54970.
----------
* insns.def (defineclass): Also raise an error when redeclaring the
superclass of a class as Object and it has another superclass.
[Bug #12367] [ruby-core:75446]
* test/ruby/test_class.rb: tes... -
11:54 AM Bug #12367 (Assigned): [PATCH] Declaring an already defined class with Object as the new superclass does not raise an error
-
11:26 AM Bug #12367 (Closed): [PATCH] Declaring an already defined class with Object as the new superclass does not raise an error
- For example:
~~~ ruby
class SuperclassIgnoresObject < A
end
SuperclassIgnoresObject.superclass # A
class SuperclassIgnoresObject < Object # Should raise a superclass mismatch but it doesn't.
end
SuperclassIgnoresObject.supercl... -
12:46 PM Revision 06dd20f7 (git): * insns.def (defineclass): Also raise an error when redeclaring the
- superclass of a class as Object and it has another superclass.
[Bug #12367] [ruby-core:75446]
* test/ruby/test_class.rb: test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54970 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:36 AM Feature #12357: Random#initialize with a String
- Nobuyoshi Nakada wrote:
> I found that rubyspec fails.
> ...
I think it's fine to change the ruby/spec to adapt for this.
The test just intends to verify that argument checking is performed,
but of course a compatible evolution of th... -
09:55 AM Feature #12357: Random#initialize with a String
- This proposal is not described about "external sources" in detail, and use cases.
If this proposal want to pass data to init_by_array, the intention is clear.
But string is still ambiguous because of its endian.
http://www.math.sci.... -
07:54 AM Feature #12357: Random#initialize with a String
- I found that rubyspec fails.
Maybe, an alternative is an optional parameter of `Random.new_seed` for the precision. -
07:41 AM Feature #12357: Random#initialize with a String
- Yes!
-
10:55 AM Bug #12363 (Rejected): URI::Generic.build allows invalid input
- URI::Generic.new has 11th argument named arg_check even though its default is false.
```
irb(main):006:0> uri = URI::Generic.new('http', invalid_userinfo, invalid_host, 80, nil, '/', nil, nil, nil,nil, true)
URI::InvalidComponentEr... -
10:30 AM Misc #12362: Redmine Forum Board signup
- Instead of forum, we use mailing lists:
https://www.ruby-lang.org/en/community/ -
02:40 AM Misc #12362 (Rejected): Redmine Forum Board signup
- We didn't provide a function of the forum board.
-
10:12 AM Misc #12365: [DOC] Suggestion to change FileUtils.compare_file
- I think the author considered BusyBox.
Therefore it is not a good example.
I think /dev/null and /dev/random is better... -
07:37 AM Misc #12365 (Closed): [DOC] Suggestion to change FileUtils.compare_file
- Hello.
The documentation at:
http://ruby-doc.org/stdlib-2.3.1/libdoc/fileutils/rdoc/FileUtils.html#method-c-compare_file
shows the "return" value in the second example to be:
#=> maybe false
I am not sure what this mea... -
09:43 AM Feature #12361: Proposal: add Geo::Coord class to standard library
- You see, my point was not "I created a cool code, lets add it to stdlib!"
My point was "We need standard Geo Coordinates type in stdlib" (because of `<reasons>`).
I've just thought it would be easier to discuss with some sample code (b... -
09:16 AM Feature #12361: Proposal: add Geo::Coord class to standard library
- Victor Shepelev wrote:
> I referenced "gem question" in original proposal: "This type is too "small" to be defined by separate gem, so, all of existing geo gems (GeoKit, RGeo, GeoRuby, Graticule etc.) define their own LatLng, or Locat... -
08:11 AM Feature #12361: Proposal: add Geo::Coord class to standard library
- Robert A. Heiler wrote:
> Would it actually not be better to instead add one or two methods to time, date or datetime?
> ...
I'm not sure how coordinates processing can be added to Time/Date classes. Could you explain please?..
On o... -
08:02 AM Feature #12361: Proposal: add Geo::Coord class to standard library
- Martin Dürst wrote:
> On rubygems, I see a lot of gems with 'geo' in their name. Which one is yours? How popular is it? These days, it's easy to use something as a gem, so it's not that necessary to include things into the standard libr... -
07:40 AM Feature #12361: Proposal: add Geo::Coord class to standard library
- Would it actually not be better to instead add one or two methods to time, date or datetime?
I guess your proposal would add a default new toplevel namespace Geo, which I am not sure
is a good idea per se since other projects may wan... -
04:19 AM Feature #12361: Proposal: add Geo::Coord class to standard library
- On rubygems, I see a lot of gems with 'geo' in their name. Which one is yours? How popular is it? These days, it's easy to use something as a gem, so it's not that necessary to include things into the standard library.
You make a lot ... -
08:36 AM Bug #12366: optionparseで引数の文字列が受け取れなくなる
- フラグと分けてもオプショナル引数を置きたいときは、`'--foo [VAL]'`を使ってください。
-
08:33 AM Bug #12366 (Rejected): optionparseで引数の文字列が受け取れなくなる
- `[=VAL]` は、直接か`=`かでフラグに続いているものだけオプショナル引数とみなします。
```ruby
require "optparse"
OptionParser.new do |opt|
opt.on('-a', '--foo[=VAL]') {|v| p v }
opt.parse! ARGV
end
p ARGV
```
```
$ ruby bug-12366.rb -a hoge
nil
["ho... -
08:12 AM Bug #12366 (Rejected): optionparseで引数の文字列が受け取れなくなる
- ```ruby
require "optparse"
OptionParser.new do |opt|
opt.on('-a', '--foo[=VAL]') {|v| p v }
opt.parse! ARGV
end
```
```
> ./test.rb -f foge
nil
```
となり、引数を受け取れない。
`'--foo(=VAL)'`、`'--foo=VAL'`
とすると受け取れる
-
07:50 AM Feature #12360: More useful return values from bang methods
- I think this proposal is to change the return value *if* actual rejection happened, but not the case nothing was rejected, and the result doesn't need to be `self` to know if it happened or not.
A drawback is a cost to create an array... -
07:12 AM Feature #12360: More useful return values from bang methods
- `reject!` returns `nil` in case nothing was rejected at all. This is useful when a programmer wants to know if actual rejection happened or not, by using single `if` statement.
Returning rejected elements can be handy on some scenarios... -
07:44 AM Misc #12283: Obsolete ChangeLog and commit message in Git-style
- I personally have no preference either way.
I should however had also note that I like the current changelog format:
https://github.com/ruby/ruby/blob/trunk/ChangeLog
It sort of is easy for me to read what is new, what is chan... -
06:46 AM Revision 15fbd05e (git): random.c: reuse bits
- * random.c (random_ulong_limited): reduce calling bytes methods by
reusing dropped bits.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:45 AM Bug #12324: Support OpenSSL 1.1.0 (and drop support for 0.9.6/0.9.7)
- Vit Ondruch wrote:
> > even 0.9.8/1.0.0 series are no longer supported[1]
> ...
Yes, that's exactly why I didn't drop them in this series, and it didn't reduce code greatly compared to dropping 0.9.6/0.9.7. -
05:29 AM Bug #12324: Support OpenSSL 1.1.0 (and drop support for 0.9.6/0.9.7)
- > even 0.9.8/1.0.0 series are no longer supported[1]
If I am not mistaken, 0.9.8 is still part of RHEL5/CentOS5 and they are still supported, although not by upstream. -
05:57 AM Revision b402cc71 (git): random.c: use bytes
- * random.c (obj_random_bytes): base on bytes method instead of
rand method, not to call toplevel rand method.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54968 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:36 AM Revision 518713fd (git): * configure.in (-fexcess-precision=standard): before r54895 -std=c99
- is specified and it implied -fexcess-precision=standard.
Now with -std=gnu99, it should be explicitly specified.
https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54967 b2dd03... -
12:33 AM Feature #12364 (Closed): Copy superclass serial number to singleton subclasses for better IMC hits
- Hi,
I've attached a patch that copies the serial number from the superclass to newly created singleton subclasses. For example:
~~~
class Foo
def x; end
end
def bar(v)
v.x
end
a = Foo.new
bar(a)
a.singleton_class
...
05/09/2016
-
09:59 PM Bug #12346 (Closed): Ruby 2.3.0 64-bit (mingw64-32) WIN32OLE_TYPE.typelibs seg faults on Windows 10 64-bit
-
06:38 PM Bug #12346: Ruby 2.3.0 64-bit (mingw64-32) WIN32OLE_TYPE.typelibs seg faults on Windows 10 64-bit
- patch from https://bugs.ruby-lang.org/issues/11880 fixes this issue. it's also fixed in ruby_2_3 head.
Ruby 2.3.0:
```
.\sandbox\devkit\mingw\bin\gdb.exe --args .\sandbox\ruby23_mingw\bin\ruby.exe -d -v -e "require 'win32ole'" -e ... -
08:45 PM Bug #12363 (Rejected): URI::Generic.build allows invalid input
- Reproduce:
~~~
require 'uri'
invalid_host = 'ex_ample.com'
invalid_userinfo = 'uuuu:pp/pp'
uri = URI::Generic.new('http', invalid_userinfo, invalid_host, 80, nil, '/', nil, nil, nil)
uri.to_s
#=> "http://uuuu:pp/pp@ex_ample.com... -
08:37 PM Misc #12362 (Rejected): Redmine Forum Board signup
- How do I sign up on Redmine's Forum? I'm asking here, because there are NO instructions on the redmine site. http://www.redmine.org/projects/redmine/boards
Thanks for any assistance you can provide. -
05:26 PM Feature #12361 (Rejected): Proposal: add Geo::Coord class to standard library
- ## Proposal
Add `Geo::Coord` class to Ruby standard library, representing `[latitude, longitude]` pair + convenience methods. Add `Geo` standard library with additional calculations and convenience methods.
## Rationale
In moder... - 04:25 PM Revision fbf22f2d (git): * 2016-05-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:25 PM Revision a6b221f2 (git): random.c: compare by rb_equal
- * random.c (random_equal): compare seeds by rb_equal.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:23 PM Feature #12360 (Rejected): More useful return values from bang methods
- It would be nice if bang methods returned results that where of some additional use. Presently most just return the effected receiver.
For example, currently Array#reject! works as follows:
a = [1,2,3,4]
a.reject!{ |x| x %... -
02:51 PM Bug #12359: Named captures "conflict" warning is unnecessary and limits uses of named captures
- See https://github.com/jruby/jruby/issues/3865 for a related issue in JRuby.
-
02:46 PM Bug #12359 (Closed): Named captures "conflict" warning is unnecessary and limits uses of named captures
- There's currently a warning whenever a named capture in a regular expression has the same name as an already-declared local variable:
```
$ ruby23 -v -e 'x = 1; /(?<x>foo)/ =~ "foo"'
ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-... -
02:30 PM Revision bc7a845a (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54964 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:39 PM Bug #12324: Support OpenSSL 1.1.0 (and drop support for 0.9.6/0.9.7)
- Thanks! I'd be happy to maintain ext/openssl.
I have read #5481 and #9612 before, so I know that gemifying ext/openssl is in progress. -
07:39 AM Bug #12324: Support OpenSSL 1.1.0 (and drop support for 0.9.6/0.9.7)
- Zachary Scott wrote:
> I'm happy for your help with Ruby's OpenSSL!
> ...
@zzak Could you explain him (or add explanation to README.rd of ruby/openssl) the relation and status between openssl gem and Ruby repo. -
07:32 AM Bug #12324: Support OpenSSL 1.1.0 (and drop support for 0.9.6/0.9.7)
- I'm happy for your help with Ruby's OpenSSL!
This is a rather large change, and would like to see it land in the (To Be Released) openssl gem:
https://github.com/ruby/openssl
If you're interested, I can give you commit to the open... -
04:24 AM Bug #12324 (Assigned): Support OpenSSL 1.1.0 (and drop support for 0.9.6/0.9.7)
- I think you become a committer and commit it by yourself. (and maintain it)
-
07:39 AM Bug #12358 (Closed): TestProcess#test_threading_works_after_exec_fail random test failures
- Ruby 2.3.1 builds randomly fail quite often on Fedora Rawhide [1] with following error:
```
1) Error:
TestProcess#test_threading_works_after_exec_fail:
Timeout::Error: execution expired
/builddir/build/BUILD/ruby-2.3.1/test/... -
04:57 AM Bug #9569: SecureRandom should try /dev/urandom first
- I made myself a benchmark:
https://gist.github.com/kernigh/d169895a700c6511d08511c005a28d88
RAND_bytes() from OpenSSL seems to be faster than /dev/urandom on my computer. I'm running OpenBSD, and OpenSSL is really LibreSSL. At first ... -
04:27 AM Revision 8610bd03 (git): random.c: consitify
- * random.c (init_by_array): consitify initializing keys.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54963 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:52 AM Revision ad949e8f (git): random.c: seed conversion
- * random.c (rand_init): random_seed() always returns an Integer,
no conversion for it.
* random.c (random_init, rb_f_srand): convert the given seed to an
Integer.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54962 b2dd03c8-39d... -
01:52 AM Revision 639bfd6d (git): thread.c: GET_THREAD once in rb_thread_atfork
- * thread.c (rb_thread_atfork_internal): move th to an argument.
* thread.c (rb_thread_atfork): do not repeat GET_THREAD().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54961 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:46 AM Revision a46df859 (git): thread.c: clear atfork functions
- * thread.c (rb_thread_atfork, rb_thread_atfork_before_exec): do
nothing unless working fork is available.
* thread_sync.c (rb_mutex_abandon_all): define only if working
fork is available.
* thread_sync.c (rb_mutex_abandon_keeping_mut... -
12:05 AM Revision e6709f0a (git): openssl/extconf.rb: NO SSL macros first
- * ext/openssl/extconf.rb: check OPENSSL_NO_SSL{2,3} macros before
checking related functions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54959 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:05 AM Revision abfc0b18 (git): webrick/utils.rb: suppress messages
- * test/webrick/utils.rb (TestWEBrick#start_server): suppress
progress messages from WEBrick::Utils#create_self_signed_cert.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54958 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:05 AM Revision 4a46404a (git): test_ssl_server.rb: assert_self_signed_cert
- * test/webrick/test_ssl_server.rb (assert_self_signed_cert):
extract common assertion.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54957 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
05/08/2016
- 10:20 PM Revision 2cb362b5 (git): * include/ruby/{defines,ruby}.h: need to define function attributes
- alternatives in defines.h instead of ruby.h, because they are used
in oniguruma.h and the header used without including ruby.h at
encoding library sources.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54956 b2dd03c8-39d4-4d8f-... - 09:31 PM Revision a8e1070d (git): * include/ruby/ruby.h (CONSTFUNC, PUREFUNC): fixed build errors on
- non-gcc build environments introduced at r54952.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54955 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:52 PM Revision b3935f17 (git): * gc.c (rb_gc_unprotect_logging): throw rb_memerror when it cannot
- allocate memory. This is pointed out by Facebook's Infer.
* gc.c (gc_prof_setup_new_record): ditto.
* regparse.c (parse_regexp): ditto.
* util.c (MALLOC): use xmalloc and xfree like above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... - 05:44 PM Revision 6db71fb1 (git): * 2016-05-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:44 PM Revision 28f5e12c (git): * configure.in: check function attirbute const and pure,
- and define CONSTFUNC and PUREFUNC if available.
Note that I don't add those options as default because
it still shows many false-positive (it seems not to consider
longjmp).
* vm_eval.c (stack_check): get rb_thread_t* as an argume... -
02:36 PM Revision 94419c16 (git): fix typos [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:10 PM Revision 93767f7a (git): * ext/openssl/extconf.rb: asume it doesn't have SSLv2 related
- functions when OPENSSL_NO_SSL2 is defined.
Usually openssl's header and the library (libssl) have the same
set of functions, but on some environment the library has functions
whose headers doesn't declare. (openssl/opensslconf.h an... -
10:06 AM Feature #12226 (Open): Dir.home with valid named user raises ArgumentError on Windows
-
09:51 AM Feature #12226 (Closed): Dir.home with valid named user raises ArgumentError on Windows
- Applied in changeset r54947.
----------
file.c: home dir fall back
* file.c (rb_home_dir_of): return the default home path if the
user name is the current user name, on platforms where struct
pwd is not supported. a temporary meas... -
09:59 AM Revision 6cd2c905 (git): win32ole_error.h: add attributes
- * ext/win32ole/win32ole_error.h (ole_raise): add attributes,
NORETURN and PRINTF_ARGS.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54949 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:59 AM Revision d7d64d91 (git): objspace_dump.c: fix format
- * ext/objspace/objspace_dump.c (dump_append_string_content),
(dump_object): fix the format specifiers.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54948 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:51 AM Revision f0355ae7 (git): file.c: home dir fall back
- * file.c (rb_home_dir_of): return the default home path if the
user name is the current user name, on platforms where struct
pwd is not supported. a temporary measure against
[Bug #12226].
git-svn-id: svn+ssh://ci.ruby-lang.org/r... -
05:52 AM Bug #9569: SecureRandom should try /dev/urandom first
- Daira Hopwood wrote:
> Many competent cryptographers and engineers have told you that using the OpenSSL RNG is significantly less safe than directly using /dev/urandom. They are right. Even better would be to use libsodium's RNG API, wh... -
03:21 AM Revision 65bbd088 (git): intern.h: suppress warnings
- * include/ruby/intern.h (rb_disable_super, rb_enable_super):
remove NORETURN. these do nothing but just return.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54946 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:31 AM Feature #12357 (Feedback): Random#initialize with a String
- https://github.com/ruby/ruby/compare/trunk...nobu:feature/Random%23initialize-string
Currently `Random#initialize` only accepts an `Integer`.
It would be useful to accept a `String` to feed the seed from external sources, I think. -
12:55 AM Revision f2535e14 (git): * configure.in: add -Wsuggest-attribute=format and suppress warnings.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54945 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:55 AM Revision 4e0e7219 (git): * 2016-05-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:55 AM Revision a6c8e8d1 (git): * configure.in: add -Wsuggest-attribute=noreturn and suppress warnings.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54943 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:55 AM Revision 644c36e9 (git): * configure.in: add -Werror=implicit-int to avoid missing type of
- function declaration.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54942 b2dd03c8-39d4-4d8f-98ff-823fe69b080e