Activity
From 11/22/2015 to 11/28/2015
11/28/2015
-
10:29 PM Feature #11741: Migrate Ruby to Git from Subversion
- me@jonathanmoss.me wrote:
> I think it's unreasonable to ask a website to degrade and work
> normally without any GUI or use of Javascript -- these are the core
> foundations of the web today, and in order to use the web, you must
>... -
04:20 PM Feature #11741: Migrate Ruby to Git from Subversion
- Hi Eric,
I think it's unreasonable to ask a website to degrade and work normally without any GUI or use of Javascript -- these are the core foundations of the web today, and in order to use the web, you must use these technologies. I ... -
06:30 PM Bug #11613: test_aspawn_too_long_path creates too many processes
- Backporrted r52222,r52229,r52273,r52277,r52357 into `ruby_2_2` branch at r52779.
-
- limit the number of FDs in a process for stress test
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@52779 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Backported r51242 into `ruby_2_2` branch at r52778.
-
- * gc.c (__has_feature): move into internal.h.
* internal.h (__has_feature): ditto.
* internal.h (__has_extension): new macro.
* internal.h (STATIC_ASSERT): use _Static_assert with
clang. [ruby-core:69... -
05:37 PM Feature #9098: Indent heredoc against the left margin by default when "indented closing identifier" is turned on.
- Right. I guess what I'm saying is that tabs shouldn't be treated as equivalent to spaces at all, since the number of spaces they are "equivalent" to is different for every developer, depending on what they have their editor set to displa...
-
03:37 AM Feature #9098: Indent heredoc against the left margin by default when "indented closing identifier" is turned on.
- Because we can not distinguish tabs and spaces on most editors, while we can distinguish 4 spaces and 8 spaces.
It's weird but has historical reason.
Matz.
-
- I'm confused. Why are tabs being treated as equivalent to spaces at all? E.g. If I write:
```ruby
def hello
puts <<~README.inspect
<tab>Hello
<space><space><space><space><space><space><space><space>World!
README
end
e... -
01:31 AM Feature #9098: Indent heredoc against the left margin by default when "indented closing identifier" is turned on.
- I updated the patch to treat tabs as equal to 8 spaces.
This seems to work fine with the indentation produced by popular text editors (only tabs, only spaces, or tabs-then-spaces), with only one corner case I noticed, which is demonst... -
02:38 PM Feature #11747: "bury" feature, similar to 'dig' but opposite
- > inferred from the what the user is passing (such as a symbol or string for a hash or an integer for an array)
I don't think this is a good idea. I think it should rather depend on the class of the receiver.
{}.bury(:users, 0... -
10:33 AM Revision 448d1d14 (git): parse.y: last content of heredoc
- * parse.y (parser_here_document): store dispatched result of
on_tstring_content at the last fragment of a here document.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52777 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:56 AM Feature #11737: Pass in expression to then block in `case expression`
- Nobuyoshi Nakada wrote:
> It reminded me a rejected proposal:
> ...
I don't think so. It's not too different from what already works if you create a variable beforehand.
~~~ruby
e = Enumerator.new do |y| y << 1; y << 2; y << 3; en... -
- It reminded me a rejected proposal:
~~~ruby
case expr
when matcher => result
...
end
~~~
-
- * ext/ripper/lib/ripper/lexer.rb: alias same methods instead of
eval for each events.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52776 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/ripper/lib/ripper/sexp.rb (SexpBuilderPP): share scanner
event handlers and most of parser event handlers with
SexpBuilder.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52775 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/ripper/lib/ripper/core.rb: alias same methods instead of
eval for each events.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52774 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/27/2015
-
- How can it know what should be created, hash, array, or struct?
-
08:16 PM Feature #11747 (Rejected): "bury" feature, similar to 'dig' but opposite
- In Matz's recent Rubyconf talk, he used this example for the new 'dig' feature coming in Ruby 2.3:
~~~ruby
# we want this
data[:users][0][:name]
# we can do this w/o nil errors
data.dig(:users, 0, :name)
~~~
What I'm proposi... -
- Backported into `ruby_2_2` branch at r52773.
-
- * parse.y (literal_concat_gen, evstr2dstr_gen): keep literal
encoding beginning with an interpolation same as the source file
encoding. [ruby-core:70703] [Bug #11519]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/bra... -
- Backported r52227 and (partially) r52228 into `ruby_2_2` branch at r52772.
-
- * ext/openssl/ossl_ssl.c (ssl_npn_select_cb): explicitly raise error
in ext/openssl instead of OpenSSL itself because LibreSSL
silently truncate the selected protocol name by casting the length
from int to u... -
- Backported into `ruby_2_2` branch at r52771.
The `MISSING_NOENTRY` was introduced at r50743. I replaced `MISSING_NOENTRY` it to `0` to backport. -
- * vm_eval.c (send_internal): set method_missing_reason before
invoking overriding method_missing method so that the default
method_missing can achieve it properly.
[ruby-core:68515] [Bug #10969]
git-svn-id... -
- Backported r49813 and r52140 into `ruby_2_2` branch at r52770.
-
- * test/ruby/test_symbol.rb: avoid a false positive in AIX.
* test/ruby/test_symbol.rb (test_symbol_fstr_leak): add a warm-up
code and check RSS to avoid false positive on AIX and false
negative on Mac OS X. [... -
- Backported into `ruby_2_2` branch at r52769.
-
- * test/objspace/test_objspace.rb
(test_trace_object_allocations_start_stop_clear): clear object
allocation table first to get rid of erronous detection for obj3.
[ruby-dev:49095] [Bug #11271]
alloc... -
- Backported into `ruby_2_2` branch at r52768.
The patch to vm_insnhelper.c (vm_defined) in r52768 was applied to insns.def (defined) on `ruby_2_2`. -
- * insns.def (defined): skip respond_to_missing? when
a method is available.
[Bug #11211]
* test/ruby/test_defined.rb: add a test for this fix.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@5... -
06:16 PM Bug #11744 (Closed): Open files being GC'ed while still in use
- Great!
I'm glad to hear that. -
04:35 PM Bug #11744: Open files being GC'ed while still in use
- Actually, @nurse you are right!
It turns out that rb-inotify uses `IO.fd_for` in its code. At some point, the system starts recycling FD numbers, so we got the same FD number on our file as the rb-inotify object waiting to be GC'ed. W... -
- > We have found the issue
Looks like I spoke too soon! The issue is back with listen 3.0.5.
> ...
I don't *think* that's the case here, but I could be completely wrong.
In the [simplified reproduction script](https://github.com/... -
- In my experience, such false closing is caused by IO.for_fd without specifying autoclose: false.
You know Ruby's IO object automatically closes their fd on finalize.
It happens even when the object is created by IO.for_fd(fd) (or IO.... - 03:03 PM Revision b08bfaf6 (git): * 2015-11-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52767 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52766 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ripper/test_parser_events.rb (test_warn_cr_in_middle):
remove unused variable to suppress assigned-but-unused-variable
warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52765 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- If the server closes a keep-alive http connection, the client socket
reaches EOF. To avoid an EOFError, detect the closed connection and
reconnect.
Added test to ensure HTTP#post succeeds even if the
keep-alive-connection has bee... -
12:31 PM Feature #11745: saving bits
- dam i wanted to make a request to add a #[]= method similar to the #[] one, until i noticed that Bignum like others are fixed, so thats not so easily possible ...
but you can wrote a wrapper class that does have #[] and #[]= and store... -
10:26 AM Feature #11745: saving bits
- Yui NARUSE wrote:
> Keep a string and store/manipulate those bits in it.
I also recommend to use Bignum if you don't have to change the table frequently.
Bignum#[] is really useful for the use case.
--
Yusuke Endoh <mame@ruby-l... -
- Eike, we have done that kind of optimization for decades.
Matz.
-
- Keep a string and store/manipulate those bits in it.
-
01:49 AM Feature #11745 (Closed): saving bits
- Hi at the ruby team,
Sometimes we are still working with bits: these yes/no things.
But even a bit is an object, this is ruby!
I'm not even sure how bits are save in mri,
I believe they are all objects (which is good)
I believ... -
12:07 PM Bug #11746 (Closed): RDoc incorrect example call method on heredoc
- The sample code for a call on a heredoc at http://ruby-doc.org/core-2.3.0_preview1/doc/syntax/literals_rdoc.html#label-Here+Documents
for
**To call a method on a heredoc place it after the opening identifier:**
I think it should ... -
- * parse.y (dispatch_ignored_scan_event, has_delayed_token): more
macros to reduce ifdefs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52763 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/26/2015
-
- We have found the issue – apparently, listen 3.0.4 and below [doesn't actually teardown the inotify watchers](https://github.com/guard/listen/issues/353). Upgrading to 3.0.5 (which implemented the teardown) fixes the issue for us.
How... -
- Hello!
We recently added a feature on Rails that uses the [`listen` gem](https://github.com/guard/listen) under-the-hood. Since we enabled those tests, we have been seeing random failures on Travis CI like [these](https://travis-ci.or... -
- 証明書に問題を検出しているからこけているわけで、このよう場合に自動でfallbackするのはダメでしょう。
根本解決をせずに回避したいならば、wgetなりcurlなりで別に手で取ってきてtool下に置くなりするべきです。
さておき、gcc.gnu.orgは経験的にあまり強くないので、この機会にGitHubのmirrorから取得するようにしました。
もしかしたらこれでエラーが出なくなるかもしれません。 -
01:40 PM Bug #11743 (Closed): r52758 以降 config.guess がダウンロードできない
- r52758 以降、以下のエラーで configu.guess がダウンロードできず、./configure できなくなりました。
~~~
./configure --prefix=/XXXXX
downloading config.guess ... downloader.rb:168:in `rescue in download': failed to download config.guess (RuntimeError)
SSL_connect re... - 03:41 PM Revision 37e6b8af (git): * 2015-11-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52762 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- https://gcc.gnu.org/wiki/GitMirror
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52761 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- On recent my environment, it must be more than 11.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52760 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (iseq_peephole_optimize): enable tail call
optimization for specialized indexers.
* compile.c (iseq_compile_each): blockiseq should be NULL, but not
Qnil.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52759 b2dd03c8-... -
- * tool/downloader.rb (Downloader.https): extract a method instead
of a global variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52758 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:31 AM Revision 4afebfd2 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52757 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Merge Onigmo 58fa099ed1a34367de67fb3d06dd48d076839692
+ https://github.com/k-takata/Onigmo/pull/52
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52756 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- OpenSSL's SHA1 struct name is SHA_CTX (which is also used for SHA-0),
but function name is SHA1_Transform.
http://openssl.org/docs/man0.9.8/crypto/SHA1.html
also note that LibreSSL 2.3 remove the SHA-0 support but still support SHA-1.
... -
08:20 AM Bug #11704 (Assigned): Refinements only get "used" once in loop
- Daniel P. Clark wrote:
> I wrote a benchmark for testing different ways of implementing a `uniq` method and I chose to do it using refinements. I looped over the results in the benchmark and refined the method with 6 different refineme... -
- RubyCI上にて、たまに以下のFailureが発生しています。
~~~
1) Failure:
TestNetHTTP_v1_2_chunked#test_set_form [/home/rubyci/unstable11s/tmp/build/20151126T012513Z/ruby/test/net/http/test_http.rb:679]:
Expected /\A--(?<boundary>\S+)/ to match "<!DOCTYP... -
- me@jonathanmoss.me wrote:
<snip>
> * Solution: Gitlab is a tool with great documentation and a great
> API, so learning should be quick. Gitlab is also much more visually
> appealing (IMO) as compared to Redmine.
Disclaim... -
- Hi Yui,
I apologize for not finding previous Git to SVN discussions on the Redmine issue tracker. I did search for 'git subversion' on the Redmine issue tracker, but only 12 results came back, and none of them were the above mentioned... -
- Tony Arcieri wrote:
> It seems like this issue addresses at least some of the points raised in #10547, namely the initial steps of a plan to migrate to Git from SVN.
> ...
Why this is periodically discussed is because anyone doesn't fo... -
12:35 AM Feature #11741: Migrate Ruby to Git from Subversion
- It seems like this issue addresses at least some of the points raised in #10547, namely the initial steps of a plan to migrate to Git from SVN.
It also seems like this is an issue that should be periodically discussed, especially if a... -
12:29 AM Feature #11741: Migrate Ruby to Git from Subversion
- You should read discussion of ruby-core archive at https://bugs.ruby-lang.org/issues/10547#note-5
-
- Why you don't read previous discussion when you want to discuss about history management.
-
- Ruby 2.2.0 is already released :)
-
-
-
- [Misc #11732][ruby-dev:49379]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52754 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- without Coverage.start. [Misc #11726][ruby-core:71622]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52753 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/25/2015
-
- # Git to SVN
Converting Ruby wholesale from Subversion to Git (not necessarily Github!) has been a long time coming, and I think it's finally time to make the switch. Ruby already has an official Git repo up on Github, and the main co... - 10:24 PM Revision 717e60c7 (git): * 2015-11-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52752 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:23 PM Revision 14920f93 (git): test/openssl/test_ssl.rb (test_copy_stream): new test
- I was worried r52750 would break IO.copy_stream with things like
OpenSSL sockets which wrap IOs, but require data to be run through
through encryption/decryption filters. Apparently my worry
was unfounded, but perhaps this test will ens... -
- Since https://bugs.ruby-lang.org/issues/11734#note-3 has informed me the `_` is an IRB feature and Minitest uses `_()` in its test suite perhaps we should not use `_` for the case/when/then.
How about `__case__`
~~~ruby
case Enum... -
05:03 PM Feature #11735: Porting String#squish and String#squish! from Ruby on Rails' Active Support
- I don't think the two features are the same, and would find both of them useful.
-
- First, indented heredoc will be achieved by [Feature #9098], this will not be needed.
Second, `squish!` feels to return `nil` if no white spaces, to me, like as `sub!` and so on.
Last, it's prohibited in C89 to initialize an aggreg... -
- That was fast, Nobu! Thanks!!
-
- Applied in changeset r52750.
----------
io.c: try to_io first
* io.c (copy_stream_body): try to_io conversion before read,
readpartial, and write methods. [ruby-dev:49008] [Bug #11199] -
01:06 PM Bug #11602: Compile error on CentOS: Segmentation fault after "linking miniruby"
- Robb Kidd wrote:
> The fix in r51626 for Bug #11457 applied directly to my working copy of 2.2.3 fixed the segfault on the CentOS 5 node I'd seen the error on in my environment.
> ...
Thanks for your reply. This solution is works for m... -
- Yurko Bregey wrote:
> Hans Mackowiak wrote:
> ...
you might did something wrong because on "ruby 2.3.0dev (2015-11-25 trunk 52749) [x86_64-linux]" it doesn't show any warning for me -
10:23 AM Feature #11734: Improved ternary operator - Nobuyoshi Nakada wrote:
> Maybe `some_long_expression&.to_s || 'foobar'` ?
@Nobuyoshi, thanx! safe navigation from 2.3 solves such tasks. - 10:06 AM Feature #11734: Improved ternary operator
- Hans Mackowiak wrote:
> why not:
> ...
think it's not good. Ruby 2.2.3p173 shows warning:
~~~
warning: found = in conditional, should be ==
~~~ -
- Maybe `some_long_expression&.to_s || 'foobar'` ?
-
- @Daniel: _ with previous line result is a feature of IRB and PRY not ruby itself
-
- * io.c (copy_stream_body): try to_io conversion before read,
readpartial, and write methods. [ruby-dev:49008] [Bug #11199]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52750 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:25 AM Bug #11740 (Closed): ObjectSpace.each_object exposes internal metaclasses
- ObjectSpace.each_object exposes internal metaclasses and
this might result in assumptions being violated since the metaclass structure is not well preserved.
See the attached script for an example.
The #bla method should always be d... -
- * iseq.h (rb_compile_option_struct): rename the member
frozen_string_literal_debug as debug_frozen_string_literal.
[Feature #11725]
* ruby.c (proc_options): do not set $DEBUG and $VERBOSE only if no
arguments is given.
git-svn-id... -
07:39 AM Revision 9b7d4d47 (git): add NEWS entry about --debug=frozen-string-literal
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52748 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:39 AM Bug #11739 (Rejected): OpenSSL::SSL::SSLServer doesn't negotiate ECDHE-* ciphersuites
- I'm trying to configure an instance of OpenSSL::SSL::SSLServer that supports Elliptic curve Diffie–Hellman. No matter what combination of Ruby and OpenSSL versions I try the negotiation with the client fails.
Proof of concept:
https... -
- * configure.in: pass --color to ifchange from CONFIGURE_TTY for
reconfig.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52747 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_objectspace.rb (test_each_object): incorporated
from rubyspec.
* test/ruby/test_objectspace.rb (test_each_object_enumerator):
ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52746 b2dd03c8-39d4-4d8f-98ff-8... -
- Eric Wong wrote:
> 1.9.3, 2.0.0, and 2.1 branches segfault for me, even.
> ...
Thanks for your check.
I've fixed the bug in trunk, and have set the Backport field of this ticket.
-
- Applied in changeset r52745.
----------
* io.c (argf_getpartial): should not resize str if the second
argument is not given.
[ruby-core:71668] [Bug #11738] -
- 1.9.3, 2.0.0, and 2.1 branches segfault for me, even.
Current bug is 2.2+
I might have time to look at this tomorrow if nobody beats me to it. -
- ARGF.readpartial raises a RuntimeError when EOF is detected more than twice:
```
lexington:ruby$ cat t.rb
p ARGF.readpartial(16) rescue nil
p ARGF.readpartial(16)
lexington:ruby$ ruby t.rb /dev/null
t.rb:2:in `readpartial': can't... -
- argument is not given.
[ruby-core:71668] [Bug #11738]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52745 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:56 AM Feature #10251: URI: Support wildcards (globbing) in no_proxy
- +1 to resolve this.
11/24/2015
-
- Hi!
We run into this here: https://github.com/janko-m/shrine/commit/399adcecad64c66ca4ffb1b1619777ff8551e761. That test passes in 2.2.3 but fails in 2.3.0.preview1, apparently due to this issue. Is fixing this planned for 2.3.0?
Th... -
- Please fix the when scenario in the last example
~~~ruby
case Enumerator.new do |y| y << 1; y << 2; y << 3; end
when ->e{ 2.times{e.next}; true}
then _.peek
end == 3
~~~ -
- Ruby's `case <expression>` scenario allows the expression to be tested in the `when` test with `:===`, but in the then block the expression is not accessible. Only if the expression has been assigned to a variable beforehand can it be c...
-
- > ~~~diff
> +static VALUE
> +rb_str_squish_bang(VALUE str)
> +{
> + static const char before_regex_source[] = "\\A[[:space:]]+";
> + static const char after_regex_source[] = "[[:space:]]+\\z";
> + static const char ... -
07:38 PM Feature #11735: Porting String#squish and String#squish! from Ruby on Rails' Active Support
- I also just created a GitHub PR in case that will be easier to give feedback to the code: https://github.com/ruby/ruby/pull/1113
Thank you,
Prem -
- Hi,
I have been using this `String#squish` method so many time when I'm using Rails, and I think it should be a useful addition to core.
Here's the method on Rails' documentation: http://api.rubyonrails.org/v4.2.5/classes/String.ht... -
- `&` is associated more with proc. I think `_` would be closer to the kind of thing you're looking for.
~~~ruby
some_long_expression = :baz
_ ? _.to_s : 'foobar'
# => "baz"
~~~
Although I tried in-lining it with a semicolon and... -
- why not:
```ruby
(x = some_long_expression) ? x.to_s : 'foobar'
``` - 02:33 PM Feature #11734 (Closed): Improved ternary operator
- In ternary operator it would be nice to be able to pass expression result from *condition* into *value_if_true/value_if_false* in such way:
`some_long_expression ? &.to_s : 'foobar'`
where `&` refers to `some_long_expression`
Ins... -
08:10 PM Bug #11736 (Closed): Float(arg) not consistent with documentation
- Float(arg) → float
Returns arg converted to a float. Numeric types are converted directly, the rest are converted using arg.to_f. Converting nil generates a TypeError.
Strings are NOT converted using arg.to_f
~~~
'123_INVALID'.to... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@52744 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/digest/sha1/sha1ossl.c: fix defs.h path to catch up changes in
r52739.[Bug #3231]
* ext/digest/rmd160/rmd160ossl.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@52743 b2dd03c8-39d4-4d8f-9... -
- Backported into `ruby_2_2` branch at r52742.
-
- * parse.y (kwd_append): fix segv after invalid keyword argument,
preceding keyword list is NULL when syntax error is there.
[ruby-core:71356] [Bug #11663]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_... -
- r52244 and (partially) r50727 were backported into `ruby_2_2` branch at r52741.
-
- * lib/ipaddr.rb, test/test_ipaddr.rb: Reject invalid address contained
EOL string. Patch by @kachick [fix GH-942][Bug #11513]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@52741 b2dd03c8-39d4-4d8f-98ff-823fe69... -
- Backported into `ruby_2_2` branch at r52740.
-
- * compile.c (iseq_build_from_ary_body): register cdhash to the
iseq constant body instead of compile time mark array, not to
get GCed. [ruby-core:70708] [Feature #8543]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/b... -
- Backported into `ruby_2_2` branch at r52739.
Add similar patch to ext/digest/sha2_sha2ossl.c. -
- * ext/digest/*/*.[ch]: include ruby.h before digest.h to avoid
includeing ext/digest/extconf.h. [Bug #3231]
https://msdn.microsoft.com/library/36k2cdd4.aspx
* ext/digest/*/extconf.rb: remove ext/digest from i... -
- Backported into `ruby_2_2` branch at r52738.
-
- Backported into `ruby_2_2` branch at r52738.
-
- Applied in changeset backport22:r52738.
----------
merge revision(s) 52683,52684: [Backport #11719] [Backport #11722]
* lib/net/http.rb: Fixed regression for Net::HTTP::PUT with "Expect-100"
header.
* test/net/http/test_http.rb: ... -
- * lib/net/http.rb: Fixed regression for Net::HTTP::PUT with "Expect-100"
header.
* test/net/http/test_http.rb: added test.
* Added missing reference of GitHub
header. [fix GH-949]
git-svn-id: svn+s... - 03:03 PM Revision ff838167 (git): * 2015-11-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52737 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- when _FILE_OFFSET_BITS=64 is defined (= when 32-bit compile).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52736 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:12 PM Revision 17f2a12f (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52735 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This is a (intentional) bug. Because I expect nobody reveal such code :p
-
- * parse.y (parser_yylex): deal with magic comment warnings also in
ripper.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52734 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (dispatch_scan_event): fix wrong macro at r52547.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52733 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:20 AM Feature #11181: Add a line directive to Ruby
- I have changed the assignee from ruby-core (all committers) to Matz to make sure this doesn't show up in everybody's todo list.
-
- [ci skip][fix GH-1108] Patch by @jwworth
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52732 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:58 AM Bug #11733: Compile of ruby 2.2.3 fails on AIX 6.1 TL07 SP03
- Another set of errors (why I gave up on modifying fs.c were these:
compiling /usr/work/src/ruby-2.2.3/ext/-test-/file/fs.c
/usr/work/src/ruby-2.2.3/ext/-test-/file/fs.c: In function 'get_fsname':
/usr/work/src/ruby-2.2.3/ext/-test-/... -
- The build on AIX fails in the ext/-test-/file directory with errors such as
compiling /usr/work/src/ruby-2.2.3/ext/-test-/file/fs.c
/usr/work/src/ruby-2.2.3/ext/-test-/file/fs.c: In function 'get_fsname':
/usr/work/src/ruby-2.2.3/ex... -
- * beos: Drop support for BeOS now that Haiku is stable.
[Fix GH-1112]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52731 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * internal.h (rb_gc_for_fd): move to export, as referred by
ext/socket.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52730 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * file.c: [DOC] add a missing period to File docs, to terminate
the sentence and separate from the next sentence. [Fix GH-1111]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52729 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/23/2015
-
- * NEWS: Fix the issue number of `Struct#dig`, which should be
[Feature #11688]. [Fix GH-1110]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52728 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:57 PM Revision d51743af (git): ext/socket/init.c (rsock_accept): handle ENOMEM
- accept(2) documents ENOMEM as a possible error, handle it
consistent with all of our other FD-allocating wrappers.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52727 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:50 PM Revision 61e5fe06 (git): use rb_gc_for_fd for more callers
- * dir.c (dir_initialize): use rb_gc_for_fd for ENOMEM
* ext/socket/init.c (rsock_socket): ditto
* ext/socket/socket.c (rsock_socketpair): ditto
* internal.h (rb_gc_for_fd): prototype
* io.c (rb_gc_for_fd): remove static
[ruby-core:7162... - 09:57 PM Feature #11727 (Closed): [PATCH] io.c (rb_gc_for_fd): wrapper for retrying FD creation
- Applied in changeset r52725.
----------
io.c (rb_gc_for_fd): wrapper for retrying FD creation
This simplifies callers and makes error handling more consistent
between our pipe, open, fdopen, and dup wrappers.
This adds missing ENOMEM ... - 09:57 PM Revision a936bd5c (git): io.c (rb_gc_for_fd): wrapper for retrying FD creation
- This simplifies callers and makes error handling more consistent
between our pipe, open, fdopen, and dup wrappers.
This adds missing ENOMEM handling as documented in the open(2),
pipe(2freebsd), and fdopen(3posix) manpages on my system.... -
09:37 PM Feature #11599: Dump entries of hash in ObjectSpace
- Aaron Patterson wrote:
> We should probably get Aman's opinion on this since he wrote the initial heap dumping code. Personally, I would like to see this feature enabled with a flag. It seems like it will significantly increase the si... -
09:34 PM Feature #11599: Dump entries of hash in ObjectSpace
- We should probably get Aman's opinion on this since he wrote the initial heap dumping code. Personally, I would like to see this feature enabled with a flag. It seems like it will significantly increase the size of the dump file, and a...
- 09:24 PM Revision 1946607b (git): * 2015-11-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52724 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:21 PM Feature #11607 (Closed): [PATCH] fiddle: release GVL for ffi_call
- Applied in changeset r52723.
----------
fiddle: release GVL for ffi_call
Some external functions I wish to call may take a long time
and unnecessarily block other threads. This may lead to performance
regressions for fast functions as... -
- On Fri, Nov 13, 2015 at 05:08:36AM +0000, Eric Wong wrote:
> So, should I commit the patch as-is, or perhaps add a new
> option/method for releasing the GVL?
>
> Naming new options/methods hard for me :<
Yes, please commit it! :... - 09:20 PM Revision 15476c69 (git): fiddle: release GVL for ffi_call
- Some external functions I wish to call may take a long time
and unnecessarily block other threads. This may lead to performance
regressions for fast functions as releasing/acquiring the GVL is not
cheap, but can improve performance for ... -
04:44 PM Feature #11731: Make ruby gem install to user-install by default
- https://github.com/rubygems/rubygems/issues/1394 opened to track. Sorry for putting it in the wrong place.
Haiku is a little special. /boot represents the os "boot" drive (and not where only the kernel lives)
https://www.haiku-os.o... -
- Rubygems upstream is https://github.com/rubygems/rubygems.
Maybe to fallback to user-install when no permission to the default place.
BTW, is ruby installed under `/boot` filesystem, on Haiku? -
- I don't think it's intended, that commit should not introduce new behavior except on singleton class constants.
@ko1: Could you confirm this is a bug? -
02:25 PM Bug #11718: Constant access on `nil`
- looks like it's somehow intended behavior
https://github.com/ruby/ruby/blob/trunk/insns.def#L179-L190
/**
@c variable
@e
Get constant variable id. If klass is Qnil, constants
are searched... -
01:34 PM Feature #11630: possibility to serialize Proc or Lambda
- In my mind, there is no perfect behavior when it comes to serializing closures with bind variables. This being said, it should not prevent us from serializing pure functions.
Since the behavior of a serialized proc with closure can ea... -
11:17 AM Bug #11729: String#split(nil) incorrectly uses $;
- I think this is intended.
[Comment of MRI](https://github.com/ruby/ruby/blob/6965964df65c1c3679b92b92101225e4a709ba73/string.c#L6583)
and
[rubyspec](https://github.com/ruby/rubyspec/blob/d439436f9c73e491e6b137eb41bcd1e9b9de9b4c/... -
- Coverageのrestart後に新しいファイルをrequireしたときの挙動がテストに記述されていなかったので、`test_restarting_coverage`に追記しました。
-
- in $ansi_options is often also needed in CPPFLAGS,
because some feature definitions vary depending on such
standards options.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52722 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52721.
----------
Haiku now best effort support
* configure.in: remove obsolete workarounds for Haiku.
* dln.c, file.c, io.c: remove obsolete Haiku workarounds.
* thread_pthread.c: add stack bounds detection for H... -
- * configure.in: remove obsolete workarounds for Haiku.
* dln.c, file.c, io.c: remove obsolete Haiku workarounds.
* thread_pthread.c: add stack bounds detection for Haiku.
* signal.c: get stack pointer from signal context on Haiku.
[rub... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52720 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/22/2015
- 11:55 PM Revision 165cc0d9 (git): * 2015-11-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52719 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52718 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Shouldn't site-wide installations use packaged gem files as they install to /usr?
Installing non-packaged files to /usr violates the LSB.
A few linux distros seem to also set --user-install as default:
https://projects.archlinux.o... -
11:18 PM Feature #11731: Make ruby gem install to user-install by default
- On 23 November 2015 at 08:56, <kallisti5@unixzen.com> wrote:
> Issue #11731 has been updated by Alexander von Gluck.
>
>
> yeah, the large number of workarounds show this is a pretty default
> workflow for people. Thus raises the... -
- yeah, the large number of workarounds show this is a pretty default workflow for people. Thus raises the question on why it isn't the default behavior.
-
09:40 PM Feature #11731: Make ruby gem install to user-install by default
- Aren't most people using rvm or rbenv/bundler to address this need?
-
- There would be a few minor logic issues around gem looking for --install-dir + --user-directory and erroring out... that check would need to be changed to --no-user-directory + --install-dir
This definitely would need some discussion... -
- Installing gem's system-wide doesn't make sense 99% of the time...
* Linux -- Need root access via sudo
* Windows -- Need administrator
* Max OS X -- Need root access via sudo
* Haiku -- /boot/system read-only
gem currently inst... -
- Even shorter `Kernel#with`
~~~ruby
my_hash = {}
my_hash.with.update, b, c = ->{ {a: 1}, 5, 6 }.call
~~~ -
- This issue is resolved via the pull-request here:
https://github.com/ruby/ruby/pull/1109 -
- Backported into `ruby_2_2` branch at r52717.
-
- * vm_insnhelper.c (vm_invoke_block): we should not expect ci->argc is
stable after invoking a block. [Bug #11451]
* test/ruby/test_yield.rb: add a test. This test script is given by
Alex Dowad.
git-svn-id: ... - 01:41 PM Revision 88376e63 (git): * gc.c (rb_raw_obj_info): fix compile errors when USE_RGENGC
- is 0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52716 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52715.
----------
* lib/cmath.rb: methods which has suffix '!' are now deprecated.
Re-apply r52469 made by Kazuki Tanaka, with fixing bug about
mathn.rb compatibility. [ruby-core:68528] [Feature #10974] -
- Re-apply r52469 made by Kazuki Tanaka, with fixing bug about
mathn.rb compatibility. [ruby-core:68528] [Feature #10974]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52715 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [ci skip][fix GH-1007] Patch by @arthurnn
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52714 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- AC_TRY_CPP and AC_TRY_COMPILE pass, because some options
(e.g. -std=iso9899:1999) are not set when running C preprocessor
or building ext.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52713 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- `IO#write_nonblock` call-seq has `[, options]`, but `IO#read_nonblock` does not.
In prelude.rb:
~~~
# call-seq:
# ios.read_nonblock(maxlen) -> string
# ios.read_nonblock(maxlen, outbuf) -> outbuf
~... -
- * compile.c (iseq_compile_each): vals is NULL here, show the
position of the parent node.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52712 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (iseq_peephole_optimize): remove unreachable code
chunk after jump/leave.
* parse.y: move dead code elimination of logical operation to
compile.c. not to warn logical operation of literal constants.
git-svn-id: svn+ssh:... -
- * compile.c (iseq_peephole_optimize): eliminate always/never
branches after a literal object and when the value is used after
the branch.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52710 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * template/fake.rb.in: move shell code inside a block comment.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52709 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (validate_labels): free labels table before raising an
exception.
* compile.c (rb_iseq_build_from_ary): wrap labels table to ensure
freeing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52708 b2dd03c8-39d4-4d8f-98f... -
- * compile.c: use rb_compile_bug instead of rb_bug to show error
position precisely.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52707 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c: use COMPILE_ERROR to save an exception to be raised
at cleanup_iseq_build.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52706 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (dump_disasm_list): flush disassembled list.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52705 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (iseq_setup): check return values of each steps.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52704 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:14 AM Bug #11729 (Closed): String#split(nil) incorrectly uses $;
- Hi,
Is this intentional?
```
$; = "@"
"a@b".split(nil) # => ["a", "b"]
```
I expect `["a@b"]` because I found the following sentence in the Japanese documentation.
```
1 バイトの空白文字 ' ' か nil
先頭と末尾の空白を除いたうえで、空白文字列で分割する。
``...