Activity
From 10/23/2015 to 10/29/2015
10/29/2015
-
10:43 PM Revision f363bbdf (git): * insns.def (getinlinecache/setinlinecache): compare ic->ic_cref and
- current cref only when cached CREF list includes singleton class.
Singleton classes have own namespaces, so that we need to check
cref as a key (#10943).
However, if current CREF list does not include singleton class,
no need t... -
- * vm_insnhelper.c (rb_vm_get_cref): use NULL instead of 0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52370 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52369 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52368 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52367 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- VM_FRAME_FLAG_BMETHOD type frame.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52366 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:08 PM Revision 4c42213c (git): * 2015-10-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52365 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:08 PM Revision 9033ed10 (git): show signal mask on solaris
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52364 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52363 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:08 PM Feature #11537: Introduce "Safe navigation operator"
- `a..b` already means something in ruby
I'm happy with Matz's acceptance of `.?` especially in light of all the
discussions that lead up to it.
-
07:32 PM Feature #11537: Introduce "Safe navigation operator" - The same discussion happens to be on TypeScript and ES6 worlds.
Using `..` instead of `?.` or `.?` because it's way more clear when you are using the ternary `? :` operator on the same line.
If it's not a conflict in Ruby syntax perh... -
08:11 PM Feature #11634 (Open): [PATCH] variable.c (rb_global_tbl): convert to id_table
- variable.c (rb_global_tbl): convert to id_table
Mainly this is to reduce casting a tiny amount; and
probably nothing depends on the order of globals.
Likely no measurable memory usage improvement as globals
are not common, but mayb... -
05:13 PM Bug #11564 (Third Party's Issue): Segementation fault while doing rake db:migrate
- Seems a bug in bcrypt gem, maybe missing GC guards.
-
- GC Yang wrote:
> Got it, I should have set the pointer to NULL.
No, you should not depend on the content of `malloc`ed buffer. -
02:56 PM Bug #11572: Urnary operator causing references to unreachable objects in 2.1.x ?
- ruby_2_1 r52362 merged revision(s) 45576.
- 02:56 PM Revision a6b6f9bb (git): merge revision(s) 45576: [Backport #11572]
- * string.c (sym_to_proc), proc.c (rb_block_clear_env_self): clear
caller's self which is useless, so that it can get collected.
[Fixes GH-592]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@52362 b2dd... - 02:41 PM Revision 24d44aeb (git): * ChangeLog: fixed wrong version number of rubygems. reported by Rob Braden.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@52361 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_1 r52360 merged revision(s) 52244.
- 02:36 PM Revision a4e761b7 (git): merge revision(s) 52244: [Backport #11513]
- * lib/ipaddr.rb, test/test_ipaddr.rb: Reject invalid address contained
EOL string. Patch by @kachick [fix GH-942][Bug #11513]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@52360 b2dd03c8-39d4-4d8f-98ff-823fe69... -
- * encoding.c (ENC_ASSERT): make an expression, and prevent the
argument from further expansions.
* encoding.c (rb_enc_check_str): assert before using.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52359 b2dd03c8-39d4-4d8f-98ff-82... -
- ruby_2_1 r52358 merged revision(s) 52229,52273,52277,52357.
- 02:28 PM Revision ba3b4e0a (git): merge revision(s) 52229,52273,52277,52357: [Backport #11613]
- Add rlimit_nproc to avoid to create many process [Bug #11613]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@52358 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:21 PM Revision 78e43667 (git): * test/ruby/test_io.rb (ruby): check the existence of the constant instead of
- checking platform. see also r52277.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52357 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_1 r52356 merged revision(s) 52227,52228.
ruby 2.1 doesn't have alpn_select_cb, so r52228 is not necessary. but I backported a part of it for keep the base of code as same with trunk as possible. - 02:07 PM Revision 9008fda6 (git): merge revision(s) 52227,52228: [Backport #11369]
- * ext/openssl/ossl_ssl.c (ssl_npn_select_cb): explicitly raise error
in ext/openssl instead of OpenSSL itself because LibreSSL
silently truncate the selected protocol name by casting the length
from int to u... -
- * encoding.c (enc_compatible_latter): adjust indent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52355 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_1 r52354 merged revision(s) 52124.
- 01:56 PM Revision d35c9eeb (git): merge revision(s) 52124: [Backport #11591]
- * configure.in: check for libunwind.h, which is not available in
very old OS X SDK. [ruby-core:71080] [Bug #11591]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@52354 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_1 r52353 merged revision(s) 51916.
- 01:54 PM Revision 694463ba (git): merge revision(s) 51916: [Backport #11543]
- * test/drb/test_drb.rb: Run Rinda/DRb tests on localhost. [Fix GH-1027]
patch by voxik.
* test/rinda/test_rinda.rb: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@52353 b2dd03c8-39d4-4d8f-98ff-82... -
01:25 PM Feature #11627: make `nonzero` an alias of `nonzero?`
- When you say "for historic reasons nonzero? returns self or nil", it sounds like it was a mistake that can't be fixed for compatibility reason. I don't believe this to be true.
Also, do you also want `Module#<` and al. to be renamed?
... -
01:01 PM Revision 7b9b1e0e (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52352 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:44 PM Feature #11630: possibility to serialize Proc or Lambda
- about external variables, how do you see `@vars`?
for sample
~~~ruby
a = 4
proc { a = 5 }.call
p a
~~~
does change a local variable and cant be serialized because of that and the binding
~~~ruby
@a = 4
proc { @a = 5 }.cal... -
11:32 AM Feature #11630: possibility to serialize Proc or Lambda
- The python API around lambda and function objects makes possible to implement serialization of lambda, for instance with https://github.com/apache/spark/blob/master/python/pyspark/cloudpickle.py. I'm looking for a ruby equivalent feature...
-
- immediately when obj is not a markable object.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52351 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:24 AM Bug #11492: TracePoint API report extra return for defined method
- Hi, this is indeed a regression in 2.2.3, but also a bug present in 2.1.7. Could we get it backported to 2.1 as well? Thanks!
-
- This function only accept T_STRING (and T_REGEXP).
This patch improves performance of a tiny_segmenter benchmark
(num=2) 2.54sec -> 2.42sec on my machine.
https://github.com/chezou/TinySegmenter.jl/blob/master/benchmark/benchmark.... -
- because some extensions include internal.h.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52349 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * gc.c (newobj_init): separate event hook call and remove the
argument for it.
* gc.c (newobj_slowpath): call event hook after initialized the
new object.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52348 b2dd03c8-39d4-4d8f-9... -
- * gc.c (rb_wb_protected_newobj_of): add more assertions.
* gc.c (rb_wb_unprotected_newobj_of): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52347 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- rb_wb_protected_newobj_of(), pass the WB_PROTECTED
information explicitly.
* internal.h: use introduced functions by NEWOBJ_OF().
`flag' is immediate value, so that C compilers can
solve them at compile time.
* include/ruby/ruby.... -
- * gc.c (gc_event_hook_needed_p): UNLIKELY makes no sense for
boolean flag value.
* gc.c (gc_event_hook, newobj_init): use in conditions instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52345 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- * gc.c: add gc_event_hook_available_p(objspace) to check that flag.
* gc.c (newobj_of): use gc_event_hook_available_p() instead of
checking gc_event_hook_needed_p(objspace, RUBY_INTERNAL_EVENT_NEWOBJ).
for performance.
* gc.c (newo... -
- * vm_insnhelper.c (VM_PROFILE_UP): use enum.
* vm_insnhelper.c (vm_profile_show_result): fix typo, "r->c" at
the last should be "c->c".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52343 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_core.h (rb_thread_struct): move forward declarations before
used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52342 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * Makefile.in (probes.h): prefix RUBY to include guard.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52341 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * internal.h (RUBY_DTRACE_CREATE_HOOK): macro to call hook at
object creation.
* vm.c (rb_source_location, rb_source_loc): retrieve source path
and line number at once.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52340 b2dd03... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52339 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm.c (ruby_th_dtrace_setup): extract setup for calling dtrace
hook from RUBY_DTRACE_HOOK macro.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52338 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52337 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52336 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:09 AM Bug #11384: multi-threaded autoload sometimes fails
- Eric Wong wrote:
> shugo@ruby-lang.org wrote:
> ...
It's still running beyond 49,000 times on my notebook, which sleeps at night.
I'll inform you if any error occurs.
- 01:14 AM Revision fc87b3b7 (git): variable.c: reduce heap usage for autoload_data_i
- For the loader (first thread which hits autoload, it is wasteful
to have extra elements on the stack. For the lifetime of the
process, it is wasteful to waste 2 words for every autoload
entry. So this makes full use of existing stack o... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52334 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:24 AM Revision c621f471 (git): ChangeLog: fix commit message for r52332 [ci skip]
- Oops, been away from ruby too long :x
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52333 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/28/2015
- 11:59 PM Bug #11384 (Closed): multi-threaded autoload sometimes fails
- Applied in changeset r52332.
----------
variable.c: additional locking around autoload
[ruby-core:70075] [ruby-core:71239] [Bug #11384]
Note: this open-coding locking method may go into
rb_mutex/rb_thread_shield types. It is smaller ... -
- Eric Wong <normalperson@yhbt.net> wrote:
> shugo@ruby-lang.org wrote:
> > The script causes an error within 100 times on My Ubuntu 14.04 box,
> > but it runs over 10,000 times with your patch.
>
> Is my patch still running beyond ... -
- shugo@ruby-lang.org wrote:
> The script causes an error within 100 times on My Ubuntu 14.04 box,
> but it runs over 10,000 times with your patch.
Is my patch still running beyond 10,000 times?
Without the patch, I can't reproduc... -
- shugo@ruby-lang.org wrote:
> > Eric Wong <normalperson@yhbt.net> wrote:
> > > http://80x24.org/spew/m/94541be0225540e34f0196e9754ae0eb5c07a4b7.txt
>
> Your patch looks good to me, and at least it solves the race condition
> of aut... -
- Eric Wong wrote:
> Eric Wong <normalperson@yhbt.net> wrote:
> ...
TestAutoload#test_threaded_accessing_constant has failed often since r52139,
and it seems to be the same problem.
I could reproduce the problem easily by the following... - 11:59 PM Revision cdc251c6 (git): variable.c: additional locking around autoload
- [ruby-core:70075] [ruby-core:71239] [Bug #11384]
Note: this open-coding locking method may go into
rb_mutex/rb_thread_shield types. It is smaller and simpler and
based on the wait queue implementation of the Linux kernel.
When/if we g... -
10:01 PM Bug #11632: Resolv::DNS::Message.encode fails to encode messages larger than 16383 byte
- I've created a small script to demonstrate the behavior. The following script should print "test" but it prints some gibberish bytes in ruby 2.1.7 and 2.2.3.
~~~ruby
require 'resolv'
msg = Resolv::DNS::Message.new
# this generate... -
- Hello Rubyists
The ruby dns message encoder automatically remembers _all_ label addresses to be reused later ( see https://github.com/ruby/ruby/blob/v2_2_3/lib/resolv.rb#L1470 ). The address field however is limited to 14 bits ( see h... -
- Aaron Patterson <tenderlove@ruby-lang.org> wrote:
> On Tue, Oct 27, 2015 at 08:54:07AM +0000, Eric Wong wrote:
> > Yes, user must check if the function is MT-safe. Probably fine
> > for most library functions...
> >
> > Maybe rel... -
02:48 PM Feature #11607: [PATCH] fiddle: release GVL for ffi_call
- On Tue, Oct 27, 2015 at 08:54:07AM +0000, Eric Wong wrote:
> Yes, user must check if the function is MT-safe. Probably fine
> for most library functions...
>
> Maybe releasing GVL can be optional, but I would rather avoid
> expos... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52331 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52330 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:27 PM Bug #11626: fprintf in c extension keep adding memory usage
- Nobuyoshi Nakada wrote:
> Nothing related to ruby, you just collapse the heap by repeatedly appending strings to the same area.
> ...
Got it, I should have set the pointer to NULL. Commenting out fprintf works fine made me think it is ... -
- Nothing related to ruby, you just collapse the heap by repeatedly appending strings to the same area.
It will depend on the platform, if `malloc` returns the same pointer as just `free`d. -
03:43 PM Bug #10004 (Closed): lack of "http 80/tcp" in /etc/inet/services in Solaris 10 causes error during make test-all
- Applied in changeset r52329.
----------
* test/rubygems/test_gem_commands_server_command.rb
(test_handle_options_port): change port from http to discard.
Solaris does not include "http 80/tcp" in its default
/etc/inet/services. AF... -
- (test_handle_options_port): change port from http to discard.
Solaris does not include "http 80/tcp" in its default
/etc/inet/services. AFAIK, discard (9/tcp) is older than http
and it is expected that all OS can resolve the servic... -
- depending on the content of /etc/inet/services, and skipping the
assertion by using RUBY_PLATFORM is generally a bad idea.
In addition, no ChangeLog is given with the commit.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52328 b2dd... -
03:14 PM Feature #11633 (Closed): NilLogger class
- I'd like to have a NilLogger class in ruby which have the same api as the stdlib Logger object, but where all logging methods is just noop:s.
- 03:11 PM Revision c8a7e854 (git): * 2015-10-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52327 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52326 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- @zzak: This seems like an issue with the XMLRPC client, not openssl?
It seems like XMLRPC should take an http object as a parameter to initialize like:
~~~
http = Net::HTTP.new *args
http.ca_path = ca_path
rpc = XMLRPC::Client.n... -
- On Wed, Oct 28, 2015 at 09:07:17AM +0000, Eric Wong wrote:
> Юрий Соколов <funny.falcon@gmail.com> wrote:
> > What's about other hashsum algos? MD5, SHA2, etc
>
> Not speaking for Aaron, but I assume he was just testing the waters
... -
- Юрий Соколов <funny.falcon@gmail.com> wrote:
> What's about other hashsum algos? MD5, SHA2, etc
Not speaking for Aaron, but I assume he was just testing the waters
and would follow-up with additional changes once/if the SHA1 change... -
05:18 AM Feature #11625: Unlock GVL for SHA1 calculations
- What's about other hashsum algos? MD5, SHA2, etc
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52325 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:37 PM Bug #11631 (Closed): OpenURI.redirectable? が http -> https の時もfalseを返す
- コメントによると
# https to http redirect is also forbidden intentionally.
# It avoids sending secure cookie or referer by non-secure HTTP protocol.
となっていますが、
この変更がされた時にリダイレクト先のチェックでも https を禁止してしまっています。
http to https を禁止する理由は無さそうなんですが、この動作... -
- It would create a reliable alternative to gems like https://github.com/ngty/sourcify and thus makes much easier to implement the ruby-spark gem (https://github.com/ondra-m/ruby-spark).
I assume that it implies the Proc API to include ... -
10:38 AM Feature #11629 (Open): Implement Enhanced Mail System Status Codes (rfc1893)
- Here is a list of exceptions raised by `net/smtp.rb`
~~~
def exception_class
case @status
when /\A4/ then SMTPServerBusy
when /\A50/ then SMTPSyntaxError
when /\A53/ then SMTPAuthenticationE... -
- The documentation for Net::SMTPServerBusy says _Represents SMTP error code 420 or 450, a temporary error_ (http://ruby-doc.org/stdlib-2.2.0/libdoc/net/smtp/rdoc/Net/SMTPServerBusy.html)
However the code for that is:
~~~
def ... -
- * test/ruby/test_file.rb (test_realpath_encoding): get rid of name
clash on case-insensitive filesystem in ascii only environment.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52324 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_{exception,module,object}.rb: inspect result
depend on the default external encoding. [Feature #10881]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52323 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * error.c (rb_name_err_new): store the receiver directly.
* error.c (name_err_receiver): return directly stored receiver.
[Feature #10881]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52322 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Corin Langosch wrote:
> If ruby cannot find a class in the specified scope it uses the top-level constant of the same name if it exists and emits a warning:
(snip)
> ...
How should the following code behave?
```ruby
class Foo
X... -
- * error.c (name_err_mesg_to_str): quote the name if unprintable.
* object.c (check_setter_id): use rb_check_id to convert names.
* variable.c (uninitialized_constant): use NameError::message to
keep the receiver of uninitialized consta... -
- * error.c (rb_name_err_new): new function to create NameError
exception instance. [Feature #10881]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52320 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52319 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:30 AM Feature #11575: Blocks in ERB don't work as intended?
- Anyway, you can take a workaround to dup block value like `result = block.call.dup`. Just for reference.
-
- Hello, Rohit.
Thank you for your report.
I don't know it's a bug or s spec, but I've found that the $results[0] and $results[1] is the same object.
$results[0].object_id = $results[1].object_id # => return true at the last lin... -
- * parse.y (new_attr_op_assign): fix op_assign type, which is
already an ID since r52284. [Feature #11537]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52318 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ripper/test_parser_events.rb (test_opassign): test parsed
event tokens too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52317 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This reverts commit r52314.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52316 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52315 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10/27/2015
- 11:00 PM Feature #11627 (Assigned): make `nonzero` an alias of `nonzero?`
- for historic reasons `nonzero?` returns self or nil. (according to https://bugs.ruby-lang.org/issues/9123)
I like the expectation that `method?` returns true and false.
That `nonzero?` returns only truthy/falsy values would be fine,... -
- guchen.yang@fugawi.com wrote:
> `fprintf` will keep adding memory usage without releasing it.
>
> I was doing it in rails console, not sure if it makes any different. The code like this:
>
> ~~~c
> VALUE leak (VALUE self,... -
- `fprintf` will keep adding memory usage without releasing it.
I was doing it in rails console, not sure if it makes any different. The code like this:
~~~c
VALUE leak (VALUE self, VALUE in) {
char *str = StringValuePtr(in);
... -
- Hi Eric,
Thanks for the feedback. I've updated the patch will your suggestions. Thank you!
sha1.h exports SHA1_Transform, so I was worried about touching that one. -
- tenderlove@ruby-lang.org wrote:
> --- a/ext/digest/digest.c
> +++ b/ext/digest/digest.c
> @@ -624,6 +624,7 @@ rb_digest_base_update(VALUE self, VALUE str)
> TypedData_Get_Struct(self, void, &digest_type, pctx);
>
> Str... -
- I'm trying to calculate many sha1 checksums, but the current sha1 implementation doesn't unlock the GVL, so I can't do it in parallel. I've attached a patch that unlocks the GVL when calculating sha1sums so that I can do them in paralle...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52314 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52313 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52312 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52311 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:18 PM Revision 75a9a6ee (git): * 2015-10-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52310 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- some CI uses ENV['MAKE'] to specify gmake
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52309 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Commenting here just to confirm that this change fixes the SEGVs that [this patch](https://github.com/deivid-rodriguez/byebug/pull/160) introduces in byebug's test suite.
-
04:26 PM Feature #11624 (Rejected): ERB deserves its own commenting token
- ## Problem
- ERB is a DSL but commenting out code is not the easy workflow feature in ERB that it is in other languages.
- ERB elements were cleverly designed to look like a special kind of html element so it makes programmers unhapp... -
03:33 PM Bug #11623 (Closed): BUG] Segmentation fault at 0x00000000000000 ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-darwin14]
- Ruby crashed right after I interrupted the rspec process.
-
- Backported into `ruby_2_2` branch at r52308.
-
- * vm.c (hook_before_rewind): prevent kicking :return event while
finishing vm_exec func because invoke_block_from_c() kick a :return
event for bmethods.
[Bug #11492]
* test/ruby/test_settracefunc.rb... -
- Backported into `ruby_2_2` branch at r52307.
-
- * configure.in: check for libunwind.h, which is not available in
very old OS X SDK. [ruby-core:71080] [Bug #11591]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@52307 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_marshal.rb (test_no_internal_ids): test for
r52304, no internal IDs should be exposed by Marshal.dump.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52306 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Backported into `ruby_2_2` branch at r52305.
-
- * test/drb/test_drb.rb: Run Rinda/DRb tests on localhost. [Fix GH-1027]
patch by voxik.
* test/rinda/test_rinda.rb: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@52305 b2dd03c8-39d4-4d8f-98ff-82... -
02:31 PM Feature #11537: Introduce "Safe navigation operator"
- I don't think `u && .profile && .thumbnails && .large` is acceptable for some reasons:
* it's longer
* unclear
than proposed `.?`. Instead, `&.` or `.&` can be alternatives. But my concern for the idea is `&&` does handle false ... -
12:45 PM Feature #11537: Introduce "Safe navigation operator"
- Rodrigo Rosenfeld Rosas wrote:
> Everyday learning a new hidden feature from Ruby ;)
Me too. Ruby has infinite possibilities.
--
Yusuke Endoh <mame@ruby-lang.org> -
12:31 PM Feature #11537: Introduce "Safe navigation operator"
- Thanks for pointing me that. Everyday learning a new hidden feature from Ruby ;)
-
- "?." is a valid code. Try: `p ?. + "foo"`
--
Yusuke Endoh <mame@ruby-lang.org>
-
- I believe you are referring to implementation details and in this case I can't really opinionate, but with regards to syntax, since "?." is not a valid code, it should be interpreted as "?.+" and "foo" would be parsed as its argument.
... -
- Rodrigo Rosenfeld Rosas wrote:
> ~~~
> ...
Consider a method `+`.
`str.?+"foo"` causes no conflict, but `str ?.+"foo"` will be parsed as `str(?. + "foo")`.
--
Yusuke Endoh <mame@ruby-lang.org> -
- On the other hand, the problem with using "u?.profile" is that "u?" is a valid method, but if Ruby required an space for using the new operator, we could get it working very similarly to Groovy and CoffeeScript:
~~~
u ?.profile ?.thu... -
09:13 AM Feature #11537: Introduce "Safe navigation operator"
- Thomas Sawyer wrote:
> In this way is more an extension of the ternary operator -- the initial dot on the method signals the difference. This should also allow:
> ...
Although I agree that .? is not that intuitive to read, the extended... -
- * defs/id.def: enable anonymous IDs not to expose internal IDs for
frozen-string-literal-debug by Marshal.dump.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52304 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52303 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52302 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52301 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:17 AM Bug #11621: Date.- and Date.+ methods inconsistencies
- Right, that is clear now for me.
Thanks for explaining.
I don't know how to close the bug, so whomever has access, please close -
- If you were use `-w` option, you were warned.
~~~
$ ruby -wc -e 'Date.today -7' -e 'now = Date.today' -e 'p now -7'
-e:1: warning: ambiguous first argument; put parentheses or a space even after `-' operator
-e:3: warning: `-' afte... -
- Andrei Balcanasu wrote:
> Good point, but this still does not explain why in some cases ` -7` works:
> ...
If `x` is a reference to a local variable, `x -y` is interpreted as `x - y`.
Otherwise, `x -y` is interpreted as `x(-y)`.
... -
- Yes, user must check if the function is MT-safe. Probably fine
for most library functions...
Maybe releasing GVL can be optional, but I would rather avoid
exposing implementation detail or new APIs... -
- Calling function is really always MT-safe?
The user of fiddle must check whether the function is MT-safe and maintain fine grained lock if it's not MT-safe? -
- * defs/id.def: move internal IDs for frozen-string-literal-debug.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52300 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * error.c (rb_error_frozen_object): use rb_attr_get instead of
rb_ivar_get to get rid of warnings for string objects created
when frozen-string-literal-debug is disabled.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52299 b2dd0... -
- http://ruby-mswin.cloudapp.net/vc10-x64/ruby-trunk/log/20151023T062322Z.log.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52298 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied at r52140.
-
- Applied in changeset r52297.
----------
logger.rb: end of week should be Saturday
* lib/logger.rb (Logger::Period#previous_period_end): as weekly
rotation shifts the log file on Sundays, the end date of the
previous period should b... -
- logger.rbで weekly rotation を指定したとき、日曜日での書き込みでログファイルが切り替えられますが、古いログファイル名に着く日付が前週の金曜日のものになっていますが、土曜日のものになるべきではないでしょうか。
以下のコードを実行すると、一回目の書き込み(`"2015-12-19 12:34:56 UTC hello-1"`)は log.20151218 に入っていて、最後に書き込まれた時刻よりも古いファイル名になっています。
~~~rub... -
- * lib/logger.rb (Logger::Period#previous_period_end): as weekly
rotation shifts the log file on Sundays, the end date of the
previous period should be Saturdays. fix r45072.
[ruby-dev:49314] [Bug #11622]
git-svn-id: svn+ssh://ci.... -
- http://rubyci.s3.amazonaws.com/unstable11s/ruby-trunk/log/20151027T043311Z.log.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52296 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:21 AM Bug #11544 (Rejected): ArgumentError: Enumerable#to_set(klass, *args, &block) if specify *args.
- This is not a bug. Extra arguments are reserved for Set's subclasses.
-
-
- * proc.c (rb_block_clear_env_self): removed as deprecated at
r52129.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52295 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- r45576
-
02:34 AM Bug #11572: Urnary operator causing references to unreachable objects in 2.1.x ?
I can confirm that this happens in the latest 2.1.x tag and that applying 2f3b28c682fe3010ed3b8803199616c12b52512d was able to fix this issue.-
- Applied in changeset r52293.
----------
logger.rb: fix weekly rotation
* lib/logger.rb (Logger::Period#next_rotate_time): get rid of
adding to mday not to exceed the days of the month.
[ruby-core:71185] [Bug #11620] - 03:01 AM Revision 6b78bfcf (git): * 2015-10-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52294 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/logger.rb (Logger::Period#next_rotate_time): get rid of
adding to mday not to exceed the days of the month.
[ruby-core:71185] [Bug #11620]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52293 b2dd03c8-39d4-4d8f-98ff-823fe69... -
- Hello, Lingaraj.
It seems that the response contains invalid byte-stream or the content encoding was wrongly detected or so.
For more investigation, please show us the sample code to reproduce this error.
10/26/2015
-
09:27 PM Feature #11607: [PATCH] fiddle: release GVL for ffi_call
- Nevermind. I did misinterpret your code. I'm ok either.
-
- KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> On Tue, Oct 20, 2015 at 6:28 PM, <normalperson@yhbt.net> wrote:
> > Issue #11607 has been updated by Eric Wong.
> >
> > File fiddle-release-GVL-for-ffi_call-v2.patch added
> >
... -
- On Tue, Oct 20, 2015 at 6:28 PM, <normalperson@yhbt.net> wrote:
> Issue #11607 has been updated by Eric Wong.
>
> File fiddle-release-GVL-for-ffi_call-v2.patch added
>
> v2 fixes a warning I did not notice before, interdiff:
> ~~... -
05:59 PM Bug #11621: Date.- and Date.+ methods inconsistencies
- Those examples are not ambiguous. `Date.today -7` *is* ambiguous because `Date.today` takes an optional argument specifying, essentially, which calendar to use‒one of `ITALY`, `ENGLAND`, `JULIAN`, or `GREGORIAN`, if you're using the meth...
-
- Good point, but this still does not explain why in some cases ` -7` works:
```ruby
now = Date.today
=> #<Date: 2015-10-26 ((2457322j,0s,0n),+0s,2299161j)>
now -7
=> #<Date: 2015-10-19 ((2457315j,0s,0n),+0s,2299161j)>
Date.new(2... -
- This has nothing to do with `Date` in particular; observe:
```ruby
def foo n = nil
n || 48
end
p foo-6 # => 42
p foo -6 # => -6
p foo - 6 # => 42
```
This is simply a consequence of parentheses for method invocation b... -
- I noticed today some inconsistencies when using `-` and `+` methods of the `Date` class, that makes the whitespace relevant:
~~~
irb(main):001:0> require 'date'
=> true
irb(main):002:0> Date.today - 7
=> #<Date: 2015-10-19 ((24573... -
03:41 PM Bug #11620: Logger throws "ArgumentError: argument out of range" with weekly rotation when switch to standard time (DST) and last day of the week is 1st of next month
- Local timezone is CET (Europe/Germany/Berlin)
-
- What timezone are you using?
-
- We discovered a bug within the Ruby Logger. Having 'weekly' as Argument for shift_age in this year (2015) when returned from summer time to standard time (DST).
Creating a new Logger results in throwing a "ArgumentError: argument out of... -
- * lib/logger.rb ({next,previous}_rotate_time): dispatch by exact
matching shift_age instead of regexp matching.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52292 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/logger.rb: freeze constant strings and array.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52291 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Yehuda Katz wrote:
> As shorthand for:
> ...
Actually, it would be a shorthand for something like:
~~~
u && (tmp1 = u.profile) && (tmp2 = tmp1.thumbnails) && tmp2.large
~~~
But I still prefer the syntax implemented in trunk as ... -
- What does sole `.profile` do?
If it requires `&&` just before it, a space should not be between them. -
12:25 PM Feature #11537: Introduce "Safe navigation operator"
- Yukihiro Matsumoto wrote:
> I like the idea. My remaining concern is ".?" is too similar to "?." which is chosen by other languages.
> ...
I agree with this concern. I also agree with the idea of trying to make it more like a tradition... -
05:10 AM Feature #11537: Introduce "Safe navigation operator"
- Yukihiro Matsumoto wrote:
> I like the idea. My remaining concern is ".?" is too similar to "?." which is chosen by other languages.
> ...
Maybe there is a better syntax by requiring a space:
u ? .profile ? .thumbnails ? .larg... -
- * test/ruby/test_module.rb (test_method_defined): Add test cases
for `public/protected/private _method_defined?`
These methods accept string as argument, so add string argument
cases. [Fix GH-1067]
git-svn-id: svn+ssh://ci.ruby-l... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52289 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/racc/rdoc/grammar.en.rdoc: Grammatical errors fixed.
[Fix GH-1070]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52288 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:10 PM Misc #11548 (Closed): FileUtils#remove_tailing_slash is a poor method name
-
09:38 AM Revision 9b425061 (git): * vm_method.c(rb_method_entry_make):
- [DOC] [ci skip] Remove a needless space from comment
[Fixes GH-1069] Patch by @yui-knk
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52287 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52286 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Misc #11548]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52285 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (call_op, call_op2): fix values on ripper. [Feature #11537]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52284 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ChangeLog: remove duplicated entry, caused by a conflict.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52283 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (call_op2): separate from call_op and also allow "::",
while dot_or_colon should not allow ".?". [Feature #11537]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52282 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/25/2015
- 04:08 PM Revision 42a0bf55 (git): * 2015-10-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52281 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:07 PM Revision f2d679c7 (git): * thread_pthread.c: fix compile erros when
- USE_SLEEPY_TIMER_THREAD is disabled.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52280 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52279.
----------
io.c: fix typo [ci skip]
* io.c (io_readpartial): fix typo, "later" to "latter".
[ruby-core:71181] [Bug #11619] -
06:27 AM Bug #11619 (Closed): IO documentation typo
- IO documentation has the phrase "The later means that readpartial...".
typo: later -> latter -
- * io.c (io_readpartial): fix typo, "later" to "latter".
[ruby-core:71181] [Bug #11619]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52279 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_io.rb (test_dup_many, test_set_lineno): use
assert_separately for more descriptive messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52278 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_io.rb (test_dup_many): limit FD only if possible.
* test/ruby/test_process.rb (assert_fail_too_long_path): fix the
condition for platform specific feature
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52277 b2dd0... -
- * symbol.c (op_tbl): add DOTQ for ripper. [Feature #11537]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52276 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext: use rb_check_arity and rb_error_arity to raise
ArgumentError. [Feature #9025]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52275 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * error.c (ArgumentError): [DOC] update document following
[Feature #9025]
* proc.c (proc_call, proc_curry): [DOC] ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52274 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/24/2015
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52273 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:36 PM Revision a5301722 (git): * 2015-10-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52272 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52271 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:51 PM Feature #11599: Dump entries of hash in ObjectSpace
- What is the status of the patch? Is this ok? something to fix?
-
- I am not going to add safe navigation for aref and aset.
Maybe you can use `a.?[](x)` (method call of an operator).
Matz.
-
07:21 AM Bug #11618 (Rejected): Safe call syntax with aref or aset is
- This test pass
```ruby
# ruby -v: ruby 2.3.0dev (2015-10-24 trunk 52128) [x86_64-darwin14]
# test/ruby/test_call.rb
def test_safe_call_aref_aset
s = Struct.new(:x, :y)
o = s.new({a: 10})
assert_equal(10, o.x.?s... -
- [fix GH-984] Patch by @kallisti5
* ext/socket/getaddrinfo.c: ditto.
* ext/socket/getnameinfo.c: ditto.
* ext/socket/rubysocket.h: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52270 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/fileutils/test_fileutils.rb (test_uptodate): relax error
message format. [Feature #9025], [ruby-core:71178] [Bug #11617]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52269 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Reverted r45640 at r52267. Hmm...
-
- Applied in changeset r52267.
----------
* lib/mkmf.rb: Revert r45640 because it may lead to link
with different libruby. [Bug #9760] - 12:11 PM Revision 623403fa (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52268 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- with different libruby. [Bug #9760]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52267 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_method.c (rb_undef): remove code almost common to proc.c.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52266 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52265.
----------
relax error message format
* bootstraptest/test_method.rb: relax error message format.
* test/ruby/test_arity.rb (err_mess): ditto.
[Feature #9025], [ruby-core:71178] [Bug #11617] -
03:49 AM Bug #11617 (Closed): Fix tests for Feature 9025
- I tried to fix the tests for this, too, but I didn't find them anywhere, sorry. Or just tell me where they are, so that I can fix them
-
- * bootstraptest/test_method.rb: relax error message format.
* test/ruby/test_arity.rb (err_mess): ditto.
[Feature #9025], [ruby-core:71178] [Bug #11617]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52265 b2dd03c8-39d4-4d8f-98ff-8... -
- Applied in changeset r52264.
----------
vm_insnhelper.c: improved error message for "wrong number
of arguments", distinguishing given and expected argument
numbers clearly. [Feature #9025] -
- of arguments", distinguishing given and expected argument
numbers clearly. [Feature #9025]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52264 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- vm_call_handler.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52263 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/23/2015
-
- * common.mk (incs): remove extra slash before
vm_call_iseq_optimized.inc. as nmake vpath syntax includes a
separator, don't append it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52262 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (incs): generate vm_call_iseq_optimized.inc too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52261 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parser_magic_comment): intern canonical name.
InstructionSequence.compile_options are case-sensitive while
pragma names are case-insensitive.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52260 b2dd03c8-39d4-4d8f-98ff... -
- Applied in changeset r52259.
----------
forwardable.rb: full qualify names
* lib/forwardable.rb (def_instance_delegator, def_single_delegator):
match backtraces against ::Forwardable in case the target class
is a subclass of BasicO... -
- I think that backtrace cleanup should be removed as well as delegate.rb, [Bug #11461].
-
09:17 PM Bug #11616 (Closed): Forwardable fails to adjust backtrace when Forwardable is not reachable from the target class
- as follows:
```
$ cat t.rb
require "forwardable"
class Foo < BasicObject
extend ::Forwardable
def_delegator :bar, :baz
end
Foo.new.baz
$ ruby t.rb
/Users/guest/.rbenv/versions/trunk/lib/ruby/2.3.0/forwardable.rb:1... -
- * lib/forwardable.rb (def_instance_delegator, def_single_delegator):
match backtraces against ::Forwardable in case the target class
is a subclass of BasicObject and does not include Kernel.
[ruby-core:71176] [Bug #11616]
git-svn-... -
- in a made option value.
* vm_opts.h: forgot to add OPT_FROZEN_STRING_LITERAL_DEBUG
at last commit.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52258 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- If this option is enabled, the modify error will be:
can't modify frozen String (RuntimeError) =>
can't modify frozen String, created at test.rb:3 (RuntimeError)
* iseq.h: add compile option frozen_string_literal_debug.
* compi... - 05:53 PM Revision 31f21aed (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52256 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:53 PM Revision 593cf11a (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52255 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- vm_call_iseq_setup_normal_0start() is simple, however it has
some loops/conditions depends on ISeq::param.size and
ISeq::local_size (in vm_push_frame(), inlined into this function).
There are many simple methods which has a few pa... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52253 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- from vm_insnhelper.h to vm_core.h.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52252 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:53 PM Revision 1b5dce5a (git): * NEWS: [DOC] In the new safe call syntax, arguments are evaluated
- only if a call is made.
* doc/syntax/calling_methods.rdoc: Fix a typo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52249.
----------
* lib/forwardable (def_instance_delegator, def_single_delegator):
rescue ::Exception instead of Exception in case Exception is
defined under the target class.
[ruby-core:71175] [Ruby trunk -... -
- Forwardable fails to adjust backtrace when Exception is defined in the target class as follows:
```
$ cat t.rb
require "forwardable"
class Foo
extend Forwardable
def_delegator :bar, :baz
class Exception
end
end
... - 03:41 PM Revision 4daa1cf7 (git): * 2015-10-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52250 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- rescue ::Exception instead of Exception in case Exception is
defined under the target class.
[ruby-core:71175] [Ruby trunk - Bug #11615]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52249 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * error.c (name_err_mesg_to_str): use fake string as rb_str_format
does not require T_STRING to be cannonical VALUE.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52248 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * error.c (name_err_mesg_to_str): separate class names from the
receiver description.
* vm_eval.c (make_no_method_exception, raise_method_missing): add
format specifiers for class names.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/t... -
- sorry i missed #1 comment written by wanabe-san.
if it can be reproduced yet, please reopen this ticket.
-
09:36 AM Bug #7758: Ruby on Windows crashes when active codepage is codepage 65001 and outputting unicode character
- Has this patch been applied?
Because I'm getting pretty much the same crash on 32bit 2.1.7p400 running on Win7 64x and I can reproduce. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52246 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- when irb.rb loaded. It's affected to IDE such as Jetbrain.
[fix GH-864] Patch by @os97673
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52245 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52244.
----------
* lib/ipaddr.rb, test/test_ipaddr.rb: Reject invalid address contained
EOL string. Patch by @kachick [fix GH-942][Bug #11513] -
- EOL string. Patch by @kachick [fix GH-942][Bug #11513]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52244 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52243 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_string.rb: indent. [fix GH-975]
[ci skip] These patches are contributed from @yui-knk
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52242 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- with `gsub` method signature.
[ci skip][fix GH-1023] Patch by @danielevans
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52241 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52240 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- navigation operator.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52239 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test_call.rb (test_safe_call): Add test cases for safe
navigation operator assignment. [Fix GH-1064]
Validate:
* can assign an attribute which is `nil`
* can "or assign" an attribute which is `nil`
git-svn-id: svn+ssh://ci.ru... -
03:58 AM Feature #11537: Introduce "Safe navigation operator"
- Thanks for the thoughtful replies guys! That definitely helps clarify the `.?` operator
Matthew Kerwin wrote:
> On 23/10/2015 2:46 AM, <merch-redmine@jeremyevans.net> wrote:
> ...
-
- * compile.c (iseq_peephole_optimize): optimize lengthy safe
navigation method chain. [Feature #11537]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:09 AM Revision 4f9ded5c (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52236 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- indentation to avoid a warning when the command line option -w of
ruby is specified.
* lib/matrix/eigenvalue_decomposition.rb (hessenberg_to_real_schur):
change the name of a block parameter to avoid a warning when the
command lin... -
- * compile.c (iseq_compile_each): support safe navigation of simple
attribute assignment. [Feature #11537]
* parse.y (mlhs_node, lhs, attrset_gen): ditto. keep mid
non-attrset as the sign of safe navigation.
git-svn-id: svn+ssh://c... -
- * compile.c (compile_massign_lhs): just insert topn insn instead
of popping and adding. [Feature #11537]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52233 b2dd03c8-39d4-4d8f-98ff-823fe69b080e