Activity
From 07/22/2015 to 07/28/2015
07/28/2015
-
09:48 PM Bug #11396: Bad performance in ruby >= 2.2 for Hash with many symbol keys
- Eric Wong <normalperson@yhbt.net> wrote:
> I am also working on more improvements, rb_objid_hash seems weak.
Maybe this:
http://80x24.org/spew/m/88e7b6dcf59adf35c5c292c91c54cb7b986bd4a4.txt
+ Benchmarks:
http://80x24.org/spew/m... -
- Thanks for testing. A backporter will backport it to 2.2 since this
is a regression.
I am also working on more improvements, rb_objid_hash seems weak. -
03:13 PM Bug #11396: Bad performance in ruby >= 2.2 for Hash with many symbol keys
- I can report patch is functional and seems to be working also on current ruby_2_2 branch [ruby 2.2.3p147 (2015-07-04 revision 51143)] .
What about pushing commit also to this branch ? More testing needed ?
The speed-up is drastic, te... -
09:13 PM Bug #11058: [PATCH] Net::HTTPResponse#read_body raises TypeError when receiving empty gzipped response body
- Almost are ok.
One thing in 0002-lib-net-http-response.rb-Net-HTTPResponse-Inflater.patch, use @inflate.total_in instead of @bytes_read.
After fix that, please commit them by yourself -
- Since you're using SSLSocket, I recommend dumping a backtrace when you
rescue since gets is implemented in Ruby in the OpenSSL::Buffering module
(ext/openssl/lib/openssl/buffering.rb in the Ruby source) -
12:11 PM Bug #11400: IO.gets(/\x0d?\x0a\x0d?\x0a/, 4096) raises comparison of Fixnum with nil failed
- Further Testing show that this happens (less so) when Regexp is not used, as in IO.gets("\r\n\r\n")
-
- This is my code, "socket" is a SSLSocket this is why it allows a Regexp in gets
`begin
http_response[:http_headers] = WEBrick::Utils.timeout(3){
socket.gets(/\x0d?\x0a\x0d?\x0a/, 4096) #\r?\n\r?\n
}
rescue Errno::E... -
08:03 PM Bug #11397 (Closed): rubygems tests slow after r51384 - Applied in changeset r51414.
----------
test/rubygems/test_gem_remote_fetcher.rb: pre-generate test key
OpenSSL::PKey::DH.new(2048) takes forever, and we pre-generate
test keys for other SSL-using tests anyways.
* test/rubygems/test_g... -
11:38 AM Bug #11397: rubygems tests slow after r51384
- Thank you Eric.
We discussed this issue today.
Your solution is good to me.
Please commit it. -
- Attached is a proposed patch to memoize the tmp_dh_callback result for RubyGems,
similar to what existing OpenSSL, DRb, Net::HTTP tests already do.
Without this patch,
make test-all TESTS='test/rubygems/ -v -j4'
Runs for seve... - 08:02 PM Revision de816650 (git): * 2015-07-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51415 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:02 PM Revision 83fc43f8 (git): test/rubygems/test_gem_remote_fetcher.rb: pre-generate test key
- OpenSSL::PKey::DH.new(2048) takes forever, and we pre-generate
test keys for other SSL-using tests anyways.
* test/rubygems/test_gem_remote_fetcher.rb: pre-generate test key
[ruby-core:70151] [Bug #11397]
git-svn-id: svn+ssh://ci.rub... -
03:23 PM Bug #11402 (Closed): Seg Fault on intensive numeric calculation
- Occur several times:
~~~
[BUG] Segmentation fault at 0x00000000000000
ruby 2.1.4p265 (2014-10-27 revision 48166) [x86_64-darwin13.0]
-- Crash Report log information --------------------------------------------
See Crash Repor... -
- Could you report to upstream?
https://github.com/flori/json -
-
11:44 AM Bug #11401 (Closed): Net::HTTP SSL session resumption does not send SNI
- See https://github.com/ruby/ruby/pull/964
## Problem
When an initial SSL request is done, Net::HTTP stores the OpenSSL::SSL::Session object in @ssl_session.
When (after the http-keep-alive timeout has expired, or the connection ... -
09:22 AM Bug #11399 (Rejected): Regexp's free-spacing mode adding whitespace to character classes
- The *free-spacing* mode (x-option) does not ignore whitespace within character classes:
~~~
r = /[a
# comment
b]/x
" \nab".scan(r)
#=> [" ", "\n", "a", "b"]
~~~
I would expect a regular expression that's equivalent to `/[... -
07:57 AM Feature #11398: deprecate constants
- It seems a good idea, for example, we have TimeoutError (instead of Timeout::Error).
Matz.
-
07:34 AM Feature #11398 (Closed): deprecate constants
- Sometimes old constants are deprecated but still remained for backward compatibilities.
It is not noticed and will be kept forever, with no warnings, though.
So I propose a method `Module#deprecate_constant` to mark a constant obsolete... -
- It changes the concept of private methods a little. It's OK to merge the patch if the document is updated at the same time..
Matz.
-
- It looks good to me.
Matz.
-
- It looks good to me.
Matz.
-
02:16 AM Bug #9244: unexpected behaviour of 'require' when $LOAD_PATH gets changed
- ~~~
$ ruby -v
ruby 2.1.6p336 (2015-04-13 revision 50298) [x86_64-darwin14.0]
$ cat test.rb
$LOAD_PATH.unshift File.join(Dir.pwd, 'a')
require 'test.rb'
$LOAD_PATH.unshift File.join(Dir.pwd, 'b')
require 'test.rb'
$ ruby te... -
- * internal.h (struct RClass): moved from ruby/ruby.h to hide the
internals.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51413 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/27/2015
-
- * configure.in (RUBY_TYPE_ATTRIBUTE): attribute declaration for
types.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51412 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/test/unit.rb (Test::Unit::Parallel::Worker#died): show
terminated signal when a worker died.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51411 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thanks for testing, committed as r51410 and 2.2 backport requested.
The only downside is slightly increased dynamic symbol registration
time because of the redundant call to rb_str_hash, but I doubt anybody
would notice. There's n... - 10:26 PM Bug #11396 (Closed): Bad performance in ruby >= 2.2 for Hash with many symbol keys
- Applied in changeset r51410.
----------
symbol.h: memoize hashval for RSymbol
This speeds up the hash function for dynamic symbols.
[ruby-core:70129] [Bug #11396], nearly up to Ruby 2.1 levels
Power-of-two hash sizing [Feature #9425] ... -
07:51 PM Bug #11396: Bad performance in ruby >= 2.2 for Hash with many symbol keys
- Eric Wong wrote:
> Possible fix is to memoize hashval inside struct RSymbol:
> ...
Hi Eric, I compiled the ruby_2_2 branch with your patch and got the following results
ruby 2.1.6p336 (2015-04-13 revision 50298) [x86_64-darwin14.0]
... -
- Possible fix is to memoize hashval inside struct RSymbol:
http://80x24.org/spew/m/1437992270-20549-1-git-send-email-e@80x24.org.txt
Much better than before, but still slower than 2.1, I think.
Only lightly-tested, and on hardwa... - 10:25 PM Revision 442b77e7 (git): symbol.h: memoize hashval for RSymbol
- This speeds up the hash function for dynamic symbols.
[ruby-core:70129] [Bug #11396], nearly up to Ruby 2.1 levels
Power-of-two hash sizing [Feature #9425] speeds up cases where we
have a good hash, but this means we can no longer hide ... -
08:52 PM Bug #11048: blocks raise on missing and extra keyword args
- another use case for this is hash destructuring
```
array_of_hashes.each do |key1:, key2:|
end
```
it would be much better if this code did not raise on extra or missing keys, otherwise this type of destructuring is almost compl... - 06:29 PM Bug #10910 (Closed): NoMethodError when opening SSL connection with OpenSSL::SSL::VERIFY_PEER set and anonymous ciphers allowed
- Applied in changeset r51409.
----------
* ext/openssl/lib/openssl/ssl.rb (module OpenSSL): raise a more
helpful exception when verifying the peer connection and an
anonymous cipher has been selected. [ruby-core:68330] [Bug #10910]
... -
06:29 PM Revision dc9ca079 (git): * ext/openssl/lib/openssl/ssl.rb (module OpenSSL): raise a more
- helpful exception when verifying the peer connection and an
anonymous cipher has been selected. [ruby-core:68330] [Bug #10910]
Thanks to Chris Sinjakli <chris@sinjakli.co.uk> for the patch.
* test/openssl/test_ssl.rb (class OpenSSL)... - 03:18 PM Revision 6d98fba2 (git): * 2015-07-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51408 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:17 PM Revision 41b6c0aa (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51407 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51406 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/lib/test/unit.rb (MiniTest::Unit::TestCase.test_order): get
rid of warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51405 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/test/unit.rb (setup_options): add --test-order option
to override the test order.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51404 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:25 AM Revision 747b7b73 (git): * template/id.h.tmpl (ID2ATTRSET): remove an unused macro.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51403 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/fiddle/depend (distclean-libffi): clean dot directory too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51402 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/fiddle/extconf.rb: use LIBFFI_DIR instead of expanding it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51401 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (distclean-local): clean preludes in the build
diretory, not by realclean.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51400 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (clean, distclean): clean local files before platform
directory, some files may exist there.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51399 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (clean-local): remove added files and a directory.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51398 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:22 AM Revision 08be34a9 (git): commit miss
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51397 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:21 AM Revision f294fe3d (git): * test/openssl/tset_ssl.rb: run tests on non-Unix platforms.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51396 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/io/console/extconf.rb: fix typo, $nmake is "m" for MS, not
"n". check sys/ioctl.h iff necessary for tty.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51395 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:56 AM Revision cf337a62 (git): * 2015-07-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51394 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * win32/Makefile.sub (clean-ext): fix usage of for /R, and adjust
messages as other platforms.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51393 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/26/2015
-
- This started out as an issue on stackoverflow, where I found strange performance anomalies when comparing Set.include? and Array.include? in different ruby versions: http://stackoverflow.com/questions/31631284/performance-anomaly-in-ruby...
-
- a patch is following:
```diff
diff --git a/ChangeLog b/ChangeLog
index 23f82a7..83ae426 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+Sat Jul 25 22:33:40 2015 NARUSE, Yui <naruse@ruby-lang.org>
+
+ * io.c (rb_io_ex... -
-
- I see. I'm not sure what I did wrong because it seems to be behaving correctly now. Maybe I was running an older version of openssl. Anyway, the patch looks good to me. I just wish there was an easier way to get a list of the default ...
-
- * ext/openssl/ossl_ssl.c (ossl_ssl_alpn_protocol): fix condition
to compile, needs ALPN to be available. [Feature #9390]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51392 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_insnhelper.c (vm_setivar): cast to long both side of a
conditional expression to suppress a sign-compare warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51391 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- seems that rb_bug_errno() is called in sigpipe() intentionally.
https://gist.github.com/sorah/831169
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51390 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * signal.c (default_handler, Init_signal): discard SIGSYS, ENOSYS
should raise a SystemCallError always instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51389 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * load.c (rb_construct_expanded_load_path): use enum for the
purpose.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51388 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- `ENOSYS` should be for that purpose.
~~~
$ ./x86_64-linux/bin/ruby -v -e 'syscall(9999)'
ruby 2.3.0dev (2015-07-26 trunk 51386) [x86_64-linux]
-e:1: warning: We plan to remove a syscall function at future release. DL(Fiddle) provid... -
- object returned by the servername callback on to the socket as an
instance variable. If the callback allocated a new context object
and didn't keep a reference to it, it could be GC'd out from under
the socket object.
* test/open... -
- OpenSSL::SSL::SSLContext#servername_cb
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51386 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51385 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/25/2015
-
- change for OpenSSL key length. see detail to
https://github.com/rubygems/rubygems/pull/1290
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51384 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:36 PM Revision 0b9387aa (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51383 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- DEFAULT_1024 constants in Ruby.
* ext/openssl/lib/openssl/ssl.rb (module OpenSSL): Ask PKey for the
default DH callback since it aleady must check whether openssl has
been compiled with DH support.
* ext/openssl/ossl_pkey_dh.c (OSS... -
11:24 PM Bug #11118: Unable to build Ruby with Visual Studio 2015 RC
- Now that RTM is out, is any progress being made on this?
-
- specifically setting the tmp_dh_callback to nil.
* ext/openssl/ossl_ssl.c (Init_ossl_ssl): ditto
* test/openssl/test_pair.rb (module OpenSSL): add a test
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51381 b2dd03c8-39d4-4d8f-98ff-... -
- tmp_dh_callback Ruby code and set it as a default in `initialize`.
* ext/openssl/ossl_pkey_dh.c (static unsigned char DEFAULT_DH_512_GEN):
move this constant to Ruby.
* ext/openssl/ossl_pkey_dh.c (static unsigned char DEFAULT_DH_1024... -
- callback is used when no DH callback is specified.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51379 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- instance variables to squash warnings with alpn.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51378 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:45 PM Revision c62785b9 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51377 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:45 PM Revision ea474f5d (git): * 2015-07-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51376 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- OpenSSL::SSL::SSLContext#initialize implementation to pure Ruby.
* ext/openssl/ossl_ssl.c (ossl_sslctx_initialize): ditto
* ext/openssl/ossl_ssl.c (Init_ossl_ssl): ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51375 b2dd03c8... -
02:26 PM Bug #10910: NoMethodError when opening SSL connection with OpenSSL::SSL::VERIFY_PEER set and anonymous ciphers allowed
- Just rebased against trunk, and the test still fails on my machine if I remove the changes to `ext/openssl/lib/openssl/ssl.rb`.
For a little more context, I'm running the test on OS X Yosemite, linking against OpenSSL from Homebrew (v... -
12:48 PM Bug #11395: ruby gets stuck when entropy_avail is 0
- Will `syscall` return `ENOSYS` if the given syscall number is not available?
If so, I guess the current patch will work well.
--
Yusuke Endoh <mame@ruby-lang.org> -
- Sorry, r51374 may lead to a problem under the following situation.
* the system uses a new libc that knows `SYS_getrandom`, but
* the system uses an old linux kernel that does not know `getrandom` syscall.
I guess it is not a good... -
- Applied in changeset r51374.
----------
random.c: get rid of blocking
* random.c (fill_random_bytes_syscall): get rid of blocking when
no entropy is available. based on the patch by mame in
[ruby-core:70114]. [Bug #11395] -
- Nobuyoshi Nakada wrote:
> Does this header exist?
Yes.
~~~~
compiling random.c
random.c: In function 'fill_random_bytes_syscall':
random.c:528:43: error: 'GRND_NONBLOCK' undeclared (first use in this function)
ret = syscall(... -
- Does this header exist?
-
- Well, my system has `SYS_getrandom` but not `GRND_NONBLOCK` even in `linux/random.h`.
I'm using musl libc. It might be a fault of the library.
--
Yusuke Endoh <mame@ruby-lang.org. -
- including `<linux/random.h>`?
And checking `errno` with `EAGAIN` doesn't seem necessary since the return value should not equal to `size`.
~~~diff
diff --git i/random.c w/random.c
index 6452456..bea5f85 100644
--- i/random.c
++... -
- * random.c (fill_random_bytes_syscall): get rid of blocking when
no entropy is available. based on the patch by mame in
[ruby-core:70114]. [Bug #11395]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51374 b2dd03c8-39d4-4d8f-98f... -
10:58 AM Bug #10803: Similar issue/stack trace as above in 2.1.5, 2.1.6
- Hi,
since the upgrade of our chef client on ubuntu 14.04 LTS x64, we are facing a similar (same?) issue -
- * iseq.c (rb_iseq_disasm, iseq_data_to_ary): fix loop counter type
for array length.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51373 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (str_replace_shared_without_enc): fill the terminator
of embedded strings in wide char encodings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51372 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (str_replace): remove redundant coderage copy as
str_replace_shared already copys it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51371 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (fstring_cmp, rb_str_hash_cmp): compare lengths first,
then encodings, and contents at last.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51370 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/24/2015
-
- * rb_call_info_t::index
* rb_iseq_constant_body::stack_max
* rb_iseq_constant_body::local_size
* rb_iseq_constant_body::param::size
* rb_iseq_constant_body::local_table_size
* rb_iseq_constant_body::is_size
* rb_iseq_constant... -
- * iseq.c: catch up this fix.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51368 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- rb_iseq_constant_body::param::keyword.
* compile.c: catch up this fix.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51367 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:49 PM Revision 18ef8181 (git): * 2015-07-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51366 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (iseq_set_exception_table): catch up this fix.
* iseq.c: ditto.
* vm.c (vm_exec): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51365 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:00 PM Bug #11385: `==` with bidirectional/cyclic dependency
- #1448 and the specs in
https://github.com/ruby/rubyspec/blob/master/core/array/shared/eql.rb
convinced me this is desirable behavior. -
- When `/proc/sys/kernel/random/entropy_avail` is 0, Ruby gets stuck during initialization.
$ ruby -v
(stuck)
This is caused by r51182. I think that the `GRND_NONBLOCK` flag should be set to `getrandom` syscall.
The foll... -
- * st.c (EQUAL, st_delete_safe): fix arguments order to compare
function, searching key is the first and stored key is the
second always.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51364 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (fstr_update_callback): fstring must not be a shared
string, or the content without RSTRING_FSTR may be freed.
[ruby-dev:49188] [Bug #11386]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51363 b2dd03c8-39d4-4d8f-98ff-... -
11:30 AM Bug #11394 (Closed): Error in test/rinda/test_rinda.rb when IPv6 address is only ::1 assigned to the loopback device
- Applied in changeset r51362.
----------
* test/rinda/test_rinda.rb (RingIPv6#prepare_ipv6): prevent to use
IPv6 loopback interface for
Rinda::TestRingFinger#test_make_socket_ipv6_multicast and
Rinda::TestRingFinger#test_make_socke... -
- システム上に存在するIPv6アドレスが、ループバックデバイスに割り当てられた ::1 だけの場合、test/rinda/test_rinda.rb で以下のエラーが発生します。
Linux (Debian wheezy）の場合 。
~~~
# ifconfig eth0 inet6 del fe80::XXXX:XXXX:XXXX:XXXX/64
% ruby test/runner.rb test/rinda/test_rinda.rb
Run op... -
- IPv6 loopback interface for
Rinda::TestRingFinger#test_make_socket_ipv6_multicast and
Rinda::TestRingFinger#test_make_socket_ipv6_multicast_hops.
The tests are skipped if there are no IPv6 devices other than the
loopback device. ... -
- Applied in changeset r51360.
----------
string.c: pool only bare strings in fstring
* string.c (fstr_update_callback): pool bare strings only.
* string.c (rb_fstring): return the original string with sharing a
fstring if it has extra... -
05:25 AM Bug #11386: taint flag about rb_fstring()
- やっぱそうなりますよねー。
ぼくもそれがいいと思います。 -
- 昨日笹田さんとも話した結果、「内容だけをfstringに保存する」という方針がいいのではないか、ということになりました。
https://github.com/nobu/ruby/tree/bug/fstring-extra - 07:38 AM Revision 0ee5c9b7 (git): * 2015-07-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51361 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * string.c (fstr_update_callback): pool bare strings only.
* string.c (rb_fstring): return the original string with sharing a
fstring if it has extra attributes, not the fstring itself.
[ruby-dev:49188] [Bug #11386]
git-svn-id: svn+... -
- * file.c (rb_file_s_extname): [DOC] add an example.
* test/ruby/test_path.rb (test_extname): add tests. [Fix GH-978]
* path starts with dot ('.a.rb')
* path includes dir name ('a/b/d/test.rb')
* path includes dir name and dir name... -
- 2.1.2 is too old version. Please try with Ruby 2.1.6
-
- Eric Wong <normalperson@yhbt.net> wrote:
> Currently testing this in a loop:
> http://80x24.org/spew/m/94541be0225540e34f0196e9754ae0eb5c07a4b7.txt
Nope, the original failure still happens with this, so there's
some other place wh...
07/23/2015
-
- Currently testing this in a loop:
http://80x24.org/spew/m/94541be0225540e34f0196e9754ae0eb5c07a4b7.txt
Subject: [PATCH] variable.c: additional locking around autoload
[ruby-core:70075] [Bug #11384]
Note: this open-coding locki... -
- Hi,
When I apply just the test, it doesn't fail. Are you sure the bug is still present? If it's still present, can you make a test that fails without changes to the implementation? -
- Note that the file "abc" intentionally doesn't exist.
-
- ~~~c
#include <ruby.h>
#include <stdio.h>
int main()
{
ruby_setup();
rb_load_file("abc"); // AV here
ruby_cleanup(0);
}
~~~
~~~
rbtest1.exe!rb_vm_bugreport(const void * ctx) Line 1024 C
rbtest1.exe!rb_bug_context(co... -
08:31 PM Bug #11392 (Third Party's Issue): proj4_c_impl.bundle: [BUG] Segmentation fault at 0x00000000000440
- ~~~
DOTs-MacBook-Pro:sims moboyle$ rails s
/Users/moboyle/.rvm/gems/ruby-2.2.2/gems/rgeo-0.3.20/lib/rgeo/coord_sys/proj4_c_impl.bundle: [BUG] Segmentation fault at 0x00000000000440
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-dar... -
08:01 PM Bug #10968: [BUG] object allocation during garbage collection phase in /opt/rubies/ruby-2.2.1/lib/ruby/2.2.0/openssl/ssl.rb:177
- Problem still happens.
Any news with it?
It happens only on one machine on Debian 7.
Does not reproduce on same machine with same OS. -
- richard.schneeman@gmail.com wrote:
> You've mentioned the case statement optimization previously in a patch I sent to Rack. I agree that the difference is pretty negligible. Although I'm able to consistently see one running `benchmark/... -
06:45 PM Feature #11375: Decreased Object Allocation in Pathname.rb
- Thanks for reviewing! I added a new patch above: https://bugs.ruby-lang.org/attachments/download/5400/ruby-changes.patch
You've mentioned the case statement optimization previously in a patch I sent to Rack. I agree that the differenc... -
07:40 PM Bug #11389: Regression in method parameter parsing
- Thank you, it works fine now! <3
-
- Applied in changeset r51350.
----------
parse.y: pop cmdarg
* parse.y (lambda_body): pop cmdarg stack for lookahead
token. [ruby-core:70067] [Bug #11380] -
05:55 PM Feature #10949: Time is WB unprotected
- @Koichi Sanada: could you guide me some hints to make Time WB-protected ? I really can't figure it out from the current documentation...
-
- Ping ? Still happening on ruby 2.1.2p95
-
05:14 PM Feature #11390: Allow symbols starting with numbers
- But it goes against the principle of least surprise that ruby follows throughout the language. It's counter-intuitive and IMO from a layman ruby programmer's point of view the solution you propose does not confirm to the elegance of the ...
- 09:53 AM Revision a34343b3 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51358 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- rb_iseq_param_keyword::table and
rb_iseq_param_keyword::default_values.
* compile.c: catch up this fix.
* iseq.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51357 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- rb_control_frame_t::pc.
* compile.c (rb_iseq_translate_threaded_code): catch up this fix.
* iseq.c: ditto.
* vm_exec.c (vm_exec_core): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51356 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:31 AM Bug #11383: Infinite loop in str_buf_cat triggered by str_gsub
- Nobuyoshi Nakada wrote:
> Very interesting.
> ...
I'll submit the content of `*(struct RString *)str` as soon as the issue reproduces. I'm sure it will since it has happened many times for those last weeks.
I had to kill the previou... -
08:18 AM Bug #11391 (Closed): chopped_length should return early for empty strings
- The current implementation only tries to check if the beginning of the string isn't coming after its end (I'm not even really sure if that's possible actually, is there case where RSTRING_LEN returns a negative number?).
In any case, ... -
07:38 AM Feature #10903: [PATCH] Matrix#zip returns a matrix
- Marc-Andre Lafortune wrote:
> Hi, sorry I missed your proposal until now, and thanks for the patch.
> ...
No worries! Thanks for taking a look.
Matrix#zip is useful for simply implementing any binary (or n-ary) operation on matrices... -
- * string.c (fstr_update_callback): create new string for fake
string, and pool shared target unless substring.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51355 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (rb_str_new_frozen, str_make_independent_expand):
trivial peephole optimizations.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51354 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- むむ、早い。
で、このパッチだと、Stringのサブクラスのインスタンスだったり特異メソッドがあったりインスタンス変数を持ってたりするとfstringにならなくなってるわけですが、そもそもtaintフラグが立ってるものもfstringにならなくてもいいんじゃない？ 的なことも思ったりします。
というわけで、やっぱり、「fstringって本質的にはなんなの？」という仕様の問題に立ち返る気がするのですが、これを説明できるのは誰でしょう？
最初は笹田さんかと思っ... -
- ほいさ
-
- * include/ruby/ruby.h: add raw FL macros, which assume always the
argument object is not a special constant.
* internal.h (STR_EMBED_P, STR_SHARED_P): valid only for T_STRING.
* string.c: deal with taint flags directly across String in... -
- * string.c (str_shared_replace): split from rb_str_shared_replace
without argument check.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51352 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/openssl/ossl_ssl.c (ossl_sslctx_setup): fix argument types
to suppress shorten-64-to-32 and shorten-64-to-32 warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51351 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r51350.
----------
parse.y: pop cmdarg
* parse.y (lambda_body): pop cmdarg stack for lookahead
token. [ruby-core:70067] [Bug #11380] -
- * parse.y (lambda_body): pop cmdarg stack for lookahead
token. [ruby-core:70067] [Bug #11380]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51350 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/22/2015
-
- なるほど、とは思ったのですが、
「次にぼくは『特異メソッドを定義したStringオブジェクトをrb_fstring()に渡すと問題がある』と言うッ！」
という感じです。(そして次はインスタンス変数) -
- tainted/untaintedのfstringを分けるようにするパッチです。
-
- r51261以降、mswinのtest-allでfailureが出るようになった件を調査していて発見したのですが、
rb_fstring()にはtaintフラグを保存しないという問題があります。
原因は2つあって、
1. sharedなStringオブジェクトを登録する際にtaintフラグをコピーしないバグがある
2. 既に同じバイト列・エンコーディングで表現可能なStringオブジェクトが登録されている場合それを返すが、
引数のtaintフラグ... -
- This bug is a duplicate of #11380.
-
- The issue can be fixed by reverting r50402 which was introduced by #11107.
-
- There is a regression in parameter parsing with current ruby-2.2-head and ruby-head:
```ruby
# ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-darwin14]
def foo fn, options, █ end
=> :foo
foo -> {}, foo: :bar do; end
=> n... -
09:13 PM Feature #11390: Allow symbols starting with numbers
- Permitting such syntax would needlessly complicate the parser for virtually no gain, and potentially break existing code that uses a numerical literal as the alternative of a non-padded ternary expression (`foo?1:2`). Just use `:'1twothr...
-
- Currently it is not possible to create a symbol that looks like `:1twothree`.
Converting to a string and then symbolizing causes hash lookup problems and proves counter-intuitive. What's also surprising is that ruby allows symbols to ... -
- OpenSSL [copies the string returned by the pointe](https://github.com/openssl/openssl/blob/9f040d6decca7930e978784c917f731e5c45e8f0/ssl/t1_lib.c#L1800-1809), so it should be safe to just return a pointer to the string object and not set ...
- 06:35 PM Feature #11356 (Closed): Add ECDH support to OpenSSL wrapper
- Applied in changeset r51348.
----------
* ext/openssl/ossl_ssl.c: add ECDH callback support. [Feature #11356]
* test/openssl/test_pair.rb: test for ECDH callback support -
- * test/openssl/test_pair.rb: test for ECDH callback support
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51348 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:32 PM Feature #9390 (Closed): Support for the ALPN TLS extension
- Applied in changeset r51347.
----------
* ext/openssl/ossl_ssl.c: add ALPN support. [Feature #9390]
* ext/openssl/extconf.rb: detect ALPN support in OpenSSL
* test/openssl/test_ssl.rb: test for ALPN -
- * ext/openssl/extconf.rb: detect ALPN support in OpenSSL
* test/openssl/test_ssl.rb: test for ALPN
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51347 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:29 PM Feature #11388 (Open): SMTP Service Extension for Delivery Status Notifications
- Considering https://tools.ietf.org/html/rfc1891 and http://www.sendmail.org/~ca/email/dsn.html
TD;DR
SMTP session via Telnet:
`R: 220 Pure-Heart.ORG SMTP server here
S: EHLO Pure-Heart.ORG
R: 250-Pure-Heart.ORG
R: 250-DSN
R: 25... - 03:16 PM Revision 3b0d4905 (git): * 2015-07-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51346 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51345 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r51344.
----------
string.c: fix coderange of reverse
* string.c (rb_str_reverse): reversed string is not a substring,
and should not set coderange of the original string.
[ruby-dev:49189] [Bug #11387] -
12:53 PM Bug #11387 (Closed): String#force_encoding と String#reverse の後にSEGV
- 以下のコードでSEGVします。
```ruby
broken_str = "abcd\xf0"
broken_str.force_encoding("utf-8").reverse
p broken_str.reverse
```
また、以下のコードでは `String#split` で `ArgumentError (invalid byte sequence in UTF-8)` が
発生することが期待されますが、実際は例外が発生しません。
... -
- * string.c (rb_str_reverse): reversed string is not a substring,
and should not set coderange of the original string.
[ruby-dev:49189] [Bug #11387]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51344 b2dd03c8-39d4-4d8f-98ff-823f... -
01:43 PM Bug #11379: Difference in `Array#sort_by` method between Ubuntu Linux and OS X
- All clear, thank you.
-
- Because `qsort_r()` of glibc is used instead of `ruby_qsort()`.
-
- > You may not expect order is same even with two subsequent sort invocation.
Non deterministic algorithm... makes sense. Is that somewhere stated in documentation?
Just curious, do you happen to know what has changed in ruby 2.2 li... -
12:50 PM Bug #11379: Difference in `Array#sort_by` method between Ubuntu Linux and OS X
- > I understand that the order cannot be guaranteed but I would expect it to work the same on all platforms.
And you will be wrong.
You may not expect order is same even with two subsequent sort invocation.
Every "same order" produce... -
01:26 PM Revision 7389ac15 (git): * ChangeLog: fix a typo for r51324. [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51343 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/ruby.h (ASSUME): hint for optimization, the
expression is assumed to be true always.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51342 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Move frequent accesssing fields to upper part.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51341 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- iseq_compile_data_ensure_node_stack.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51340 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- rb_iseq_variable_body (rb_iseq_t::variable_body).
rb_iseq_variable_body can be modified after compilation.
* compile.c: use rb_iseq_t::variable_body.
* iseq.c: ditto.
* thread.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr... - 09:04 AM Revision 2f5897e6 (git): * test/webrick/test_utils.rb (TestWEBrickUtils#test_nested_timeout_outer): seems
- to be too short for mswin CI. fixed occasional failure introduced at r51235.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51338 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:56 AM Bug #11385: `==` with bidirectional/cyclic dependency
my version is "ruby 2.3.0dev (2015-07-21 trunk 51319) [x86_64-linux]"
and it does return true for me too-
- Should the result not be **false** instead?
These two instances each have a different @friend and it cannot be determined if they are equal so "false" seems a much safer answer.
Also, this seems inconsistent to how Comparable#== trea... -
07:16 AM Bug #11385: `==` with bidirectional/cyclic dependency
- Hi Nakada-san:
~~~
D:\> ruby -v
ruby 2.2.3p147 (2015-07-04 revision 51143) [x64-mswin64_120]
D:\> ruby test.rb
test.rb:8:in `==': stack level too deep (SystemStackError)
from test.rb:8:in `=='
from test.rb:8:in... -
- `true` is the expected result, and the same with x64-mswin64_120.
-
02:54 AM Bug #11385 (Rejected): `==` with bidirectional/cyclic dependency
- ```ruby
class Something
attr_accessor :friend
def initialize(friend)
self.friend = friend
end
def ==(other)
friend == other.friend
end
end
a = Something.new([])
b = Something.new([a])
a.friend = [b]
... -
- [fix GH-959][ci skip] Patch by @bogdanvlviv
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51337 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- Very interesting.
An empty string is usually embedding, and I can't tell why there is an empty non-embed string.
Couldn't you show its content, `*(struct RString *)str`? -
- * common.mk: fix macro name, exec but not EXEC. pointed by
@nagachika.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51336 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- exclude_end true case. [fix GH-968] Pach by @yui-knk
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51335 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ~~~
I get this failure once in a blue moon:
#8 test_autoload.rb:46:in `<top (required)>':
open("zzz.rb", "w") {|f| f.puts "class ZZZ; def self.ok;:ok;end;end"}
autoload :ZZZ, "./zzz.rb"
t1 = Thread.new {ZZZ.ok}
... -
- * numeric.c (num_coerce): [DOC] fix doc for Numeric#coerce,
missing '+'. [Fix GH-974]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51334 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * Makefile.in (lex.c): make position independent table.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51333 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parse_ident): call rb_intern2 with the known length
instead of strlen().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51332 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk: add exec to quoted commands.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51331 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread.c (rb_wait_for_single_fd): return the error when ppoll
failed. fix r51319.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51330 b2dd03c8-39d4-4d8f-98ff-823fe69b080e