Activity
From 05/08/2015 to 05/14/2015
05/14/2015
- 11:27 PM Revision a4344cb5 (git): * lib/cgi/cookie.rb: Implement HttpOnly flag for cookies.
- [fix GH-887] Patch by @martinpovolny
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50496 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:58 PM Feature #11140 (Closed): Allow rubygems' `require` to handle `autoload` calls - Applied in changeset r50494.
----------
* variable.c: Change autoload to call `require` through Ruby rather
than directly calling `rb_require_safe`. This allows things like
RubyGems to intercept file loading done though `autoload`.... -
07:29 AM Feature #11140: Allow rubygems' `require` to handle `autoload` calls
- Accepted. Could you apply the patch, Aaron?
Matz.
- 09:57 PM Revision d4011b3a (git): * 2015-05-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50495 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:57 PM Revision cd465d55 (git): * variable.c: Change autoload to call `require` through Ruby rather
- than directly calling `rb_require_safe`. This allows things like
RubyGems to intercept file loading done though `autoload`.
[Feature #11140]
* test/ruby/test_autoload.rb: Test for change.
git-svn-id: svn+ssh://ci.ruby-lang.org/rub... -
08:32 PM Bug #11101: Forking is killing my memory when running GC
- I have looked at the thing closely and it seems that the GC is not CoW friendly for sparse arrays. If I create an array of undefined size and populate it with random numbers in string format, the GC will launch the CoW in the fork. Howev...
-
08:13 PM Bug #10933: [BUG] object allocation during garbage collection phase
- Backported into `ruby_2_2` branch at r50493.
-
- * symbol.c (Init_sym): make dsym_fstrs a hash compared by identity
as the keys are unique fstrings, to get rid of running hash and
compare methods and causing new object allocation during garbage
collection ... -
07:48 PM Feature #11146: [PATCH] variable.c: initialize generic_iv_tbl at start
- SASADA Koichi <ko1@atdot.net> wrote:
> On 2015/05/14 5:15, Eric Wong wrote:
> > That's one, but I think generic ivar is common enough. I'll also
> > work on using ivar index + array (like T_OBJECT) to reduce hash table
> > entries ... -
10:48 AM Feature #11146: [PATCH] variable.c: initialize generic_iv_tbl at start
- On 2015/05/14 5:15, Eric Wong wrote:
> That's one, but I think generic ivar is common enough. I'll also
> work on using ivar index + array (like T_OBJECT) to reduce hash table
> entries for most generic cases.
This is just curiou... -
07:07 PM Bug #11149 (Assigned): URI.parse keeps '?' for query and '#' for fragment even if they are empty
- As URL Standard, current behavior is correct.
https://url.spec.whatwg.org/
But Google Chrome's behavior is like what you say.
I keep watching how W3C/WHATWG decide this behavior. -
06:18 PM Bug #10871: Sclass thread unsafe due to CREF sharing
- I recently opened bug #11153 which may be related. When using threads, methods defined inside `class << obj` sometimes fail to work. Feel free to close mine as a duplicate if it is the same underlying cause. In any case I would also appr...
-
- This may be a duplicate of #10871.
-
- Defining singleton methods using this syntax occasionally produces unexpected results when run in parallel with multiple threads:
~~~
class << obj
def method_one
end
def method_two
end
end
~~~
Sometimes not all of th... -
- FYI:
Kazuki Tanaka-san proposed a library Kasen.
[ruby-list:50120] [ANN] Kasen(下線) v0.1.1
Github: https://github.com/gogotanaka/_
Rubygems: https://rubygems.org/gems/kasen
It introduces special method "_" (underscore, Kasen in J... -
10:44 AM Feature #11049 (Closed): Enumerable#grep_v (inversed grep)
- Thanks, committed at r50491, r50492.
-
- `grep_v` seems OK. Accepted.
Matz.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50492 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Implement Enumerable#grep_v.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50491 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I am not positive about this syntax mostly because it appears to be set syntax, or old style hash in 1.8.
Once ES6 syntax become more popular, there will be chance for this change in the future.
Matz.
-
09:15 AM Feature #11105: ES6-like hash literals
- Nobuyoshi Nakada wrote:
> > lexington:ruby$ ./ruby x.rb
> ...
Because I don't come up with any use case of such ugly key names.
I believe code like {a, @a} should not be used in real world applications.
-
- Realistic use-case is written. Accepted.
But it should recognize complex numbers (should raise exception).
Matz.
-
01:20 AM Feature #11151: Numeric#positive? and Numeric#negative?
- > You probably mean Integer and Float. And possibly also Rational.
Yeah.
For what I could see, probably we'll just need to publish two functions that we are already using internally. https://github.com/ruby/ruby/blob/d77f4934f8ede1... -
- It's because ** tries to pass keyword hash (this caes empty) as an argument, so that old style
```ruby
def foo(h)
end
foo(**{})
```
to work. In anyway, passing keyword arguments to a method that does not take any keyword ... -
- We haven't thought of self as a receiver. Agreed to remove warnings.
Matz.
-
06:54 AM Feature #11082 (Closed): Remove condition of RUBY_VERSION <= 1.9
- Applied in changeset r50490.
----------
* ext/pathname/lib/pathname.rb: Remove condition of RUBY_VERSION <= 1.9.
[Feature #11082] -
- [Feature #11082]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50490 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Accepted. Go ahead.
Matz.
05/13/2015
-
10:22 PM Bug #11152 (Closed): Resolv::DNS should use Search Domains provided in /etc/resolv.conf by default
- For some reason Resolv::DNS does not use search domains. Many downstream projects rely on Resolv, and this appears broken. I'm showing this below in Kubernetes, but it's based on the search domain(s), rather than a cluster issue.
~~~
... -
10:19 PM Feature #11151: Numeric#positive? and Numeric#negative?
- On 14/05/2015, rafaelmfranca@gmail.com <rafaelmfranca@gmail.com> wrote:
> Issue #11151 has been updated by Rafael França.
>
>
> Right. Thank you for the explanation.
>
> So maybe just to `Fixnum` and `Float`?
>
You probably me... -
- Right. Thank you for the explanation.
So maybe just to `Fixnum` and `Float`? -
07:07 PM Feature #11151: Numeric#positive? and Numeric#negative?
- In #5113, matz said
* We can use `> 0` and `< 0` for the purpose.
* Complex is Numeric, but we cannot define positive? and negative? for it.
The latter is just appropriate comment, I think.
-
- We just added [`Interger#positive?` and `Interger#negative?` to Active Support](https://github.com/rails/rails/commit/e54277a45da3c86fecdfa930663d7692fd083daa).
I was wondering if we could get that implemented in Ruby itself and searc... -
10:17 PM Feature #5480: remove GServer from stdlib
- For those that absolutely need to use GServer, it's also available on rubygems.
* https://rubygems.org/gems/gserver
* https://rubygems.org/gems/rubysl-gserver
However, GServer isn't being maintained, so users should migrate to an ... - 10:01 PM Revision f51a964d (git): * 2015-05-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50489 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:01 PM Revision 6fefba37 (git): variable.c: no intermediate IDs
- * variable.c (rb_set_class_path_string, rb_set_class_path): get
rid of creating intermediate IDs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50488 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- nobu@ruby-lang.org wrote:
> Probably, due to `@gem_prelude_index` of `$LOAD_PATH` elements?
That's one, but I think generic ivar is common enough. I'll also
work on using ivar index + array (like T_OBJECT) to reduce hash table
en... -
- Probably, due to `@gem_prelude_index` of `$LOAD_PATH` elements?
-
- I'm biased here since we already implemented part of Option #5 on Ruby on Rails but I prefer its explicitness over concision. It is not clear to me what `rekey` and `revalue` does.
-
05:57 PM Feature #11148: Add a way to require files, but not raise an exception when the file isn't found
- Aaron Patterson wrote:
> @Benoit yes, for performance, and to avoid catching load errors. If my plan is successful, rubygems would stop adding directories to the load path. That means searching *should* be relatively fast (since the l... -
- @nobu I was thinking the same, but this was the smallest patch that would accomplish what I need
@Benoit yes, for performance, and to avoid catching load errors. If my plan is successful, rubygems would stop adding directories to the... -
- Why is that exception problematic?
For performance (the cost of the search is already large I suppose)
or to only catch the LoadError from require and not accidentally from somewhere else? (this could potentially affect compatibility) -
- Although I had an idea to separate `require` into "search" and "load", this may be simpler.
-
- Backported into `ruby_2_2` branch at r50487.
-
- * parse.y (lambda): push and reset cmdarg_stack in lambda body.
[ruby-core:69017] [Bug #11107]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@50487 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r50410, r50412, r50413, r50414, r50415 and r50416 were backported into `ruby_2_2` at r50486.
-
- dln.c: use EXPORT_PREFIX
* configure.in (EXPORT_PREFIX): define exported symbol prefix
string in config.h.
* dln.c (FUNCNAME_PREFIX): use configured EXPORT_PREFIX, not
hardcoded condition.
* dln.c (dln_load)... -
- Backported into `ruby_2_1` branch at r50485.
-
- * lib/fileutils.rb (FileUtils#mv): show the exact target path in
the error message instead of the destination parent directory
name. patched by Joao Britto <jabcalves AT gmail.com> at
[ruby-core:68706]. [B... -
- Backported into `ruby_2_2` branch at r50484.
-
- * thread_pthread.c (reserve_stack): keep sp safe zone to get rid
of crash by -fstack-check. [ruby-core:68740] [Bug #11030]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@50484 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:04 PM Feature #11141: new syntax suggestion for abbreviate definition on block parameters in order
- Hans Mackowiak wrote:
> my problem i got with that new syntax is what does it do when i have blocks inside of blocks, specially with different arity count ...
I'd say, such a implicit block parameters should only be possible for the ... -
06:34 AM Feature #11141: new syntax suggestion for abbreviate definition on block parameters in order
- my problem i got with that new syntax is what does it do when i have blocks inside of blocks, specially with different arity count ...
like
~~~
{key1 => value1, key2 => value2}.each { |key, value|
[obj1, obj2, obj3].each { |ob... -
08:25 AM Bug #11130: Re: [ruby-changes:38376] glass:r50457 (trunk): * enum.c (enum_to_a): Use size to set array capa when possible.
- 再入チェックを入れてパフォーマンスを比較した結果、改善が見られなかったのでrevertしました。
再入チェック付の最適化:
ruby-dev bm_enum_to_a_sized.rb 19.46s user 1.29s system 99% cpu 20.760 total
ruby-dev bm_enum_to_a_sized.rb 19.46s user 1.29s system 99% cpu 20.754 total
ruby-dev bm_e... - 08:19 AM Bug #11130 (Closed): Re: [ruby-changes:38376] glass:r50457 (trunk): * enum.c (enum_to_a): Use size to set array capa when possible.
- Applied in changeset r50483.
----------
* enum.c (enum_to_a): revert r50457.
it requires recursion check.
then, it doesn't make performance improvement.
[Bug #11130] [Feature #9118] - 08:19 AM Feature #9118 (Closed): In Enumerable#to_a, use size to set array capa when possible
- Applied in changeset r50483.
----------
* enum.c (enum_to_a): revert r50457.
it requires recursion check.
then, it doesn't make performance improvement.
[Bug #11130] [Feature #9118] -
- it requires recursion check.
then, it doesn't make performance improvement.
[Bug #11130] [Feature #9118]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50483 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:33 AM Revision 0cddf1b4 (git): merge revision(s) 49095: [Backport #11144]
- * lib/resolv.rb (Resolv::DNS::Label::Str#==): Check class equality.
(Resolv::DNS::Name#initialize): Normalize labels as
Resolv::DNS::Label::Str objects.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@... -
- Why do you need such assignment?
-
03:04 AM Revision 0579576d (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50481 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (parse_gvar): separate message for gvar without
non-space characters from message for invalid identitirs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50480 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:11 AM Revision 5b80ca1d (git): * 2015-05-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50479 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_parse.rb (test_dstr_disallowed_variable): fix
duplicate variable name to be tested.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50478 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
05/12/2015
-
11:32 PM Bug #11149 (Rejected): URI.parse keeps '?' for query and '#' for fragment even if they are empty
- ~~~
p = URI.parse('http://example.com/path?query#fragment')
p.query = ''
p.fragment = ''
puts p.to_s
~~~
will output "http://example.com/path?#" but I think it should be "http://example.com/path" without '?' and '#'
-
- Hi,
I'm trying to make is so that RubyGems doesn't need to put directories on $LOAD_PATH (which is why I submitted Feature #11140). I would like the `require` implemented in RubyGems to look up the file from a cache generated when th... -
10:21 PM Bug #11147 (Closed): [SEGFAULT] While looping gets
- $ pod install
Analyzing dependencies
/Users/ssoffes/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/cocoapods-0.37.1/lib/cocoapods/executable.rb:83: [BUG] Segmentation fault at 0x00000000000000
ruby 2.2.2p95 (2015-04-13 revision 50295)... -
- Even miniruby creates one generic ivar (plain "ruby" creates 9),
so there's no point in lazily allocating the table and increasing
lines of code.
I'll commit in a few days unless there's objections.
I dumped generic ivar counts w... -
- MSG_DONTWAIT is enough to force non-blocking I/O under Linux,
so avoid changing the state of a socket. This will allow certain
threads to do a non-destructive non-blocking "peek" while others
block (without relying on an extra ppoll ... -
06:41 PM Bug #10871: Sclass thread unsafe due to CREF sharing
- I also would very much like a backport of this, as it effectively makes certain bits of "idiomatic" ruby inherently (and very unexpectedly) completely thread-unsafe - see https://github.com/puma/puma/issues/647
-
05:42 PM Bug #11143 (Closed): it should always be possible to return from an if
- ```
irb(main):001:0> def foo; a = if true then return end end
SyntaxError: (irb):1: void value expression
```
it should not matter that you are not producing a value for the if expression, since you are leaving the method immediate... -
- SHIBATA Hiroshi <shibata.hiroshi@gmail.com> wrote:
> Eric Wong <normalperson@yhbt.net> wrote:
> > Is it OK to email patches directly to maintainers (perhaps Cc:
> > ruby-core?). If so, can this be stated explicitly?
>
> It's ok,... -
- > How are users who refuse to use proprietary websites or refuse the
> terms-of-service expected to contribute to this (and other extracted
> gems?)
I understood your opinion.
> Is it OK to email patches directly to maintainers ... -
04:09 PM Bug #11142 (Assigned): Command line argument parser on windows handles double quotes inconsistently.
- I believe the issue is with https://github.com/ruby/ruby/blob/trunk/win32/win32.c#L1671 through 1673.
C:\Users\ksubrama>ruby -e "puts ARGV" "foo""bar"
foo"bar
C:\Users\ksubrama>ruby -e "puts ARGV" "foo"" bar"
foo"
bar
I belie... -
- Nobuyoshi Nakada wrote:
> What about `@1`?
I liked this one at first glance, but it might confuse people, because you could think the scoping would be similar to `@instance` variables.
Some brainstorming:
~~~ruby
->{ puts $a, ... -
03:08 PM Feature #11141: new syntax suggestion for abbreviate definition on block parameters in order
- It gets a bit more line-noisy, but why not a couple of sigils? Maybe:
```ruby
x.method { @[1] - @[2] }
```
---
Austin Ziegler * halostatue@gmail.com * austin@halostatue.ca
http://www.halostatue.ca/ * http://twitter.com/halostatue -
- Arnold Roa wrote:
> On method definition we can use `*args` for multiple arguments, so what about `*1`, `*2`, `*3`?
> ...
It has obvious ambiguity.
How will you interpret `foo(*1)`, a splat or the short-hand syntax? -
01:53 PM Feature #11141: new syntax suggestion for abbreviate definition on block parameters in order
- Yukihiro Matsumoto wrote:
> We cannot use `$1` etc. as they are already taken for `Regexp` match.
> ...
Yes, I just use `$1` as an example to explain the idea, by no means I think `$1` would be a good choice as `$` is for global variab... -
- What about `@1`?
-
- We cannot use `$1` etc. as they are already taken for `Regexp` match.
Short hand notation for block parameter itself is a nice idea though.
Matz.
-
- One of the most commons things I do in Ruby are small block definitions:
~~~ruby
x.each{|a| a}
~~~
One useful syntax introduced was the **`&:method`** that allows calling a method on a block if only one param is expected. It's a ... -
- Masaki Matsushita wrote:
> Enumerable#countは、実際にイテレーションを回してみて回った数を数える実装となっています。
> ...
Enumerable#countでなく自前の実装があるならそれを使い、そうでないならないものとみなせ、というくらいの意図でした。
> Enumerator#sizeがFixnumを返す場合に限っては、それに依拠して配列のサイズを決めてしまって問題ないのではないかと思います。
自前の... -
02:33 PM Bug #11130 (Assigned): Re: [ruby-changes:38376] glass:r50457 (trunk): * enum.c (enum_to_a): Use size to set array capa when possible.
- 議論は #9118 にあります。
そこでも指摘していますが、この最適化は def size; to_a.size; end という手抜きな size 実装で無限再帰になります（そういう実装はいくつも実在します）。再入チェックを入れてもなお高速か、確かめる必要があるでしょう。
まずは revert に一票です。
--
Yusuke Endoh <mame@ruby-lang.org> -
- Enumerable#countは、実際にイテレーションを回してみて回った数を数える実装となっています。
pull request ( https://github.com/ruby/ruby/pull/444 )の狙いはEnumerable#to_aの高速化なので、countは不向きです。
Enumerator#sizeがFixnumを返す場合に限っては、それに依拠して配列のサイズを決めてしまって問題ないのではないかと思います。 -
- そもそも、本件、githubのpull request以外のどこかで議論はあったのでしょうか？
sizeという、多義性のある(と実際に確認された)メソッドに依拠するのはそもそも危険なのでは、という気がしないでもないのですが、lengthやcountでなくsizeが対象として選ばれた経緯はなんでしょう？ -
- 互換性を壊すのは私の本意ではないので、以前と同じ挙動になるよう修正しました。
ご迷惑をおかけしました。 - 01:25 PM Bug #11130 (Closed): Re: [ruby-changes:38376] glass:r50457 (trunk): * enum.c (enum_to_a): Use size to set array capa when possible.
- Applied in changeset r50477.
----------
* enum.c (enum_to_a): fix incompatibility introduced in r50457.
[Bug #11130]
* test/ruby/test_enum.rb: test for above. -
10:10 AM Bug #11130: Re: [ruby-changes:38376] glass:r50457 (trunk): * enum.c (enum_to_a): Use size to set array capa when possible.
- 最適化のヒントとして使えるなら使うというのを超えて、ドキュメントなしに互換性を壊してしまったらバグではないでしょうか。
sizeがINFINITYを返すときも、eachを呼ぶことなくRangeErrorが発生します。（そのようなコードが足を撃たんとしている蓋然性は高いですが） -
- [Bug #11130]
* test/ruby/test_enum.rb: test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50477 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50476 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_dump.c (preface_dump): move the statement to include crash
report log file from REPORTBUG_MSG in error.c.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50475 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:15 AM Revision dd4cf6bb (git): * ext/tk/extconf.rb: support Tcl/Tk8.6.
- * ext/tk/tcltklib.c, ext/tk/lib/tk.rb: get rid of SEGV with Tcl/Tk8.6.
[Backport #10401]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@50474 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:50 AM Revision 7f2c079e (git): * 2015-05-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50473 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_dump.c (preface_dump): highlight very important but very
ofhen ignored message like a Xmas tree.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50472 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_dump.c (preface_dump): move platform specific preface.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50471 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- On 2015/05/12 12:57, Eric Wong wrote:
> nobu@ruby-lang.org wrote:
>> After requiring 'io/nonblock', no needs to see if `nonblock=` method is available.
>
> Doesn't that raise NotImplementedError on some platforms?
>
> I see this... -
- nobu@ruby-lang.org wrote:
> After requiring 'io/nonblock', no needs to see if `nonblock=` method is available.
Doesn't that raise NotImplementedError on some platforms?
I see this in ext/io/nonblock/nonblock.c:
#define rb_io_... -
- After requiring 'io/nonblock', no needs to see if `nonblock=` method is available.
And `IO#close_on_exec=` is older than `IO#nonblock=`.
-
- It sounds reasonable as `-r` option also calls `Kernel#require` method now.
-
12:46 AM Feature #11140: Allow rubygems' `require` to handle `autoload` calls
- Considering #5653, should we be making any changes to autoload to make it easier to use, if the intention is to remove it in ruby 3.0? I think before any improvements to autoload should be considered, we first need a firm decision from ...
-
- Right now, rubygems can't handle calls to `autoload` because `autoload` will directly call `rb_require_safe` rather than sending to `Kernel::require`.
For example:
~~~ruby
class A
autoload :B, 'a/b' # this is in a different Gem... -
- djberg96@gmail.com wrote:
> How about just :block ?
>
> a.accept(block: false)
> a.accept_nonblock(block: true)
I don't think that helps convey it affects the newly-accepted socket,
not the socket performing the accept.... -
12:25 AM Feature #11139: [PATCH] socket: support accept `sock_nonblock: (true|false)'
- How about just :block ?
a.accept(block: false)
a.accept_nonblock(block: true) -
- An application wanting to do non-blocking accept may want to
create a blocking accepted socket, allow it with a kwarg while
preserving default behavior.
This is analogous to the SOCK_NONBLOCK flag in the Linux `accept4'
syscall.
... -
- > How about objspace/allocation_tracer.rb?
I think that is fine.
> ...
Any reason why not? Usually I don't know where to include it while I'm debugging, and doing `ObjectSpace.allocation_sourcefile` is a lot to type. If including... -
- [PATCH 1/2] ext/socket/init.c: use SOCK_NONBLOCK if available
This saves a system call by allowing us to use SOCK_NONBLOCK in
Linux when accept4 is available.
Note: I do not agree accept_nonblock should always make accepted
socke...
05/11/2015
-
- Same for drb.
If no response, I'll commit this along with patch in #11136 in a week unless
there's some reason to keep compatibility in stdlib with old Rubies.
-
- * lib/webrick/server.rb: avoid redundant fcntl call
Sockets are close-on-exec by default since Ruby 2.0, so it
is redundant to set it again.
-
- lib/webrick/utils.rb: simplify by avoiding fcntl
IO#nonblock= and IO#close_on_exec= methods are simpler-to-use
and potentially more portable to for future OSes.
IO#nonblock= and IO#close_on_exec= are also smart enough to avoid
redu... -
03:02 PM Bug #11135 (Third Party's Issue): [BUG] Segmentation fault at 0x000000000000b0
- The following happens whenever I try to install *any* gem (I usually use the http source due to SSL restrictions at work)
```
gem install serverspec --source=http://rubygems.org
/Users/mxl2/.rvm/rubies/ruby-2.2.2/lib/ruby/2.2.0/net/... - 02:40 PM Bug #11134 (Closed): resolution of "localhost" in windows server 2012 (ipv6 over ipv4)
- I've just installed ruby 2.2 on Windows Server 2012 and i'm seeing this strange behaviour:
The server:
~~~
require "socket"
server = TCPServer.new("::1", 2000)
loop do
client = server.accept
client.puts "Hello !"
clie... -
- It's a spec, but seems there is no docs about it.
This is a documentation issue. -
08:48 AM Bug #11132 (Closed): String#sub and character sequence \' in replacement string
- Hi,
I don't know if this is intentional but substitution of `\'` and `` \` `` in the replacement string was rather unexpected for me:
~~~
2.2.2 :001 > "this is a test".sub(/this/, "some text \\'")
=> "some text is a test is a t... -
11:50 AM Misc #11079: missing LICENCE
- 取り込まれる元の "RubyPKI" を savannah.nongnu.org で見つけました。
http://savannah.nongnu.org/projects/rubypki
LICENCE ファイルが確かにあり、中身は r4128 当時の Ruby の COPYING と同じ内容のようです。
（厳密には見ていません。すみません）
http://cvs.savannah.gnu.org/viewvc/ossl2/LICENCE?root=... -
11:37 AM Bug #11133 (Closed): Wrong Hyperlink representation in man page
- There was pointed out recently, that Ruby's man pages are not represented correctly in gnome-terminal [1]. But as per discussion with Gnome folks [2], it might be more widespread then just gnome-terminal [2]. Would you mind to revert r39...
-
- 02:15 AM Revision 297344e1 (git): * ChangeLog: typo(?)
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50470 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_1 r50469 merged revision(s) 50416.
- 02:12 AM Revision 14c7be2e (git): merge revision(s) 50416: [Backport #11111]
- dln.c: fix EXTERNAL_PREFIX
* configure.in (EXPORT_PREFIX): revert r50410.
* dln.c (EXTERNAL_PREFIX): define by predefined macros.
configured EXPORT_PREFIX is different thing.
* win32/Makefile.sub: r50414-5041... -
- ruby_2_1 r50468 merged revision(s) 50402.
- 02:01 AM Revision 4a680e81 (git): merge revision(s) 50402: [Backport #11107]
- * parse.y (lambda): push and reset cmdarg_stack in lambda body.
[ruby-core:69017] [Bug #11107]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@50468 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50467 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/ruby.h (Data_Make_Struct, TypedData_Make_Struct):
make statement-expression to get rid of strict-aliasing warnings
by old GCC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50466 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
05/10/2015
-
06:01 PM Misc #11131 (Closed): Unexpected splatting of empty kwargs
- ~~~ruby
def foo(); :ok end
foo(*[]) #=> :ok
foo(**{}) #=> ArgumentError: wrong number of arguments (1 for 0)
foo(*[], **{}) #=> ArgumentError: wrong number of arguments (1 for 0)
~~~
I was expecting kwargs splatting to work the s... -
03:43 PM Bug #11130: Re: [ruby-changes:38376] glass:r50457 (trunk): * enum.c (enum_to_a): Use size to set array capa when possible.
- 実際のケースはgtk3 gemという中のコードで複数の子ウィジェットを持つウィジェットオブジェクトで発生しました。このGTK+のウィジェットではeachで子ウィジェットを繰り返し、sizeでは[width, height]という配列を返していました。GTK+のウィジェットの文脈ではsizeが横幅と縦幅を返すのはおかしいことではないのですが、この場合はEnumerableを使わないほうがよさそうでしょうか。
* 失敗するテスト: https://github.com... -
- そもそもsizeがnilでも整数でもない値を返すのはどうにもバグっぽいので、新しい挙動でバグが発見されたと考えそうな気がしますが、sizeに手を付けずこの挙動を維持してほしい(後方互換性の維持以外の)理由ってのがあれば教えてください。
Matz.
-
-
- 須藤です。
~~~diff
+ if (NIL_P(size) || size == Qundef) {
+ ary = rb_ary_new();
+ }
+ else {
+ ary = rb_ary_new_capa(NUM2LONG(size));
+ }
~~~
を
~~~c
if (FIXNUM_P(size)) {
ary = rb_ary_new_capa(NUM2LONG(size)... - 03:20 PM Revision a1ee941e (git): * 2015-05-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50465 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/ruby.h (Data_Make_Struct, TypedData_Make_Struct):
allocate wrapper data object before allocating DATA_PTR to get
rid of possible memory leak when the former failed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50... -
- * proc.c (proc_binding): fix possible memory leak of rb_env_t when
TypedData_Wrap_Struct failed.
* vm.c (vm_make_env_each): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50463 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * gc.c (gc_mark_children): call dmark function for non-NULL
pointers only, so that DATA_PTR can be NULL safely now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50462 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:29 AM Revision 280d4c37 (git): * proc.c (proc_binding): fix segmentation fault on marking phase.
- envptr of newenvval should not be NULL.
You can reproduce by
make test-all TESTS='--gc-stress -n test_to_proc_binding ruby/test_method.rb'
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50461 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:43 AM Feature #10900 (Closed): GzipReader does not define `#external_encoding`
- Applied in changeset r50460.
----------
* ext/zlib/zlib.c (rb_gzreader_external_encoding):
define GzipReader#external_encoding.
[Bug #10900]
* test/zlib/test_zlib.rb: test for above. -
- define GzipReader#external_encoding.
[Bug #10900]
* test/zlib/test_zlib.rb: test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50460 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- the patch is from davydovanton <antondavydov.o at gmail.com>.
[fix GH-892]
* lib/rubygems/indexer.rb: ditto.
* test/rubygems/test_gem_indexer.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50459 b2dd03c8-39d4-4d8f-98ff... -
- I don't think this should be rejected completely, Nobu. As I mentioned in
my analysis, it appears that NoMethodError#message is calling #inspect on
the object that raised the error, only to discard *most* of the item in
favour of *ju... -
- Your objects are consist of very large networks with complex recursive references.
Even with omission of the recursions, it makes tons of hundreds MB strings.
You should define `inspect` methods for your purpose. -
- The data structure in question is large and has some slightly pathological recursiveness. There are 3,204 objects marshalled. Most of these (3,088) are referenced exactly once. Of the remaining:
* 52 appear between 2x and 9x.
* 17 ap... - 02:49 AM Bug #10988 (Closed): [PATCH] Raise ArgumentError when string passed to String#crypt contains null
- Applied in changeset r50458.
----------
* string.c (rb_str_crypt): Raise ArgumentError when
string passed to String#crypt contains null.
the patch is from jrusnack <jrusnack at redhat.com>.
[Bug #10988] [fix GH-853]
* test/ruby/t... -
- string passed to String#crypt contains null.
the patch is from jrusnack <jrusnack at redhat.com>.
[Bug #10988] [fix GH-853]
* test/ruby/test_string.rb: test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50458 b2dd03c... -
- the patch is from HonoreDB <aweiner at mdsol.com>.
[fix GH-444]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50457 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It's my fault.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50456 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It's my fault.
This reverts commit 5e17fc6bc7cb8b0e58b05fa9ebf2c47ec73ecbb3.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50455 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This reverts commit 3482910fc4ca8515b38f56bdd9fa0db7002413ad.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50454 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:06 AM Revision fe123a8b (git): * 2015-05-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50453 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50452 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50451 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
05/09/2015
-
07:02 AM Bug #11088: On Exception too expensive inspect is called on recursive object graph with 3000 elements in it, swallows memory and ultimately doesn't deliver exception
- Hi Jurgen,
I executed bug_hunt.rb and I was able to reproduce this issue. But when I tried a simple test (attached in 11088_test.rb) I did not see this bug. Can you tell us how you generated the ruby_object.dump? Do you have code for ... -
- Possibly shortest code.
~~~ruby
def doit
yield nil
end
doit(&proc {doit {}}.method(:call))
~~~
But it doesn't happen, if the inner block has a single argument or arbitrary number arguments `*`.
Oppositely, it's similar bu... -
12:40 AM Feature #6647: Exceptions raised in threads should be logged
- Eric Wong wrote:
> I have an actual patch which is only 2 lines, but there's some test
> ...
Hot diggity! I bet there's several of these that indicate bugs to be fixed. At the very least, they indicate exceptions that are being raised ...
05/08/2015
- 10:31 PM Revision 933e586e (git): * 2015-05-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50450 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:31 PM Bug #11123 (Closed): [PATCH] bsock_recmvsg_internal needs GC guard for control buffer
- Applied in changeset r50449.
----------
ext/socket/ancdata.c (bsock_recvmsg_internal): GC guard
The control buffer may be used throughout the function, so
prevent the string from being lost to GC.
* ext/socket/ancdata.c (bsock_recvmsg... - 10:31 PM Revision c3d826bb (git): ext/socket/ancdata.c (bsock_recvmsg_internal): GC guard
- The control buffer may be used throughout the function, so
prevent the string from being lost to GC.
* ext/socket/ancdata.c (bsock_recvmsg_internal): GC guard
[Bug #11123]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50449 b2dd0... -
- I have an actual patch which is only 2 lines, but there's some test
failures and MANY warnings I don't feel motivated to fix just yet
unless matz approves the feature:
http://80x24.org/spew/m/0a12f5c2abd2dfc2f055922a16d02019ee70739... -
05:26 PM Feature #6647: Exceptions raised in threads should be logged
- Not sure if a +1 would do anything, but I like the idea of
`Thread#report_on_exception` defaults to true.
For quick and one time scripts, it's tedious to write
`Thread.current.abort_on_exception = true` all the time,
and it shouldn... -
09:00 PM Bug #11120: Unexpected behavior when mixing Module#prepend with method aliasing
- I gave some more thought to this but I can't really find a way to improve the migration path from aliases to prepend without creating new problems.
I think this issue should be closed. -
- * test/matrix/test_matrix.rb (test_determinant): refactor test on
Matrix#determinant, by merging with test_det for an alias method
det. [Fix GH-897]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50448 b2dd03c8-39d4-4d8f-98ff-82... -
- * ext/io/console/extconf.rb: only nmake needs remove style VPATH.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50447 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/io/console/depend: remove nmake style VPATH, for normal makes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50446 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Shugo Maeda wrote:
> ```
> ...
Why they make the same symbol?
`a`, `@a` and `$a` are irrelevant, separate variables.
I'd expect `{:a=>1, :@a=>2, :$a=>3}` without any warnings. -
- This reverts commit 0d3797f8b62394f5634f4b2b529d28cb46bebf8a.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50445 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r50444.
----------
* lib/net/imap.rb (body_ext_mpart): should work even if body-fld-dsp
is omitted. [ruby-core:69093] [Bug #11128] -
-
- patch is here https://github.com/ruby/ruby/pull/895
-
- is omitted. [ruby-core:69093] [Bug #11128]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50444 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50443 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Is there this issue on Ruby 2.1 or 2.2? Ruby 1.9.3 is EOL.
-
-
- [fix GH-888][ci skip] Patch by @riffraff
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50442 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:11 AM Revision db336692 (git): * 2015-05-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50441 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_eval.c (rb_method_call_status): resolve refined method entry
to check if undefined. [ruby-core:69064] [Bug #11117]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50440 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Yukihiro Matsumoto wrote:
> I am interested why referencing the target object could cause problem. The target object must be existed before the exception, and exception should disappear soon after handling.
Oh I see, you were asking ... -
- Yukihiro Matsumoto wrote:
> I am interested why referencing the target object could cause problem. The target object must be existed before the exception, and exception should disappear soon after handling.
I'm not sure it's the refe... -
02:05 AM Feature #11129: block-level hash destructuring only works for the last argument
- I'd rename this bug to something like "block-level hash destructuring only works for the last argument" if Redmine let you rename bugs...
-
- ```ruby
[{a: 2}].each_with_index{ |a:, index| }
SyntaxError: unexpected tIDENTIFIER
[{a: 2}].each_with_index{ |(a:), index| }
SyntaxError: unexpected tLABEL
[{a: 2}].each_with_index.map{ |hash, index| [index, hash] }.map{ |index...