Activity
From 11/20/2014 to 11/26/2014
11/26/2014
-
11:40 PM Misc #10547: How to move the ruby project to git
- Martin Dürst wrote:
> Shyouhei Urabe wrote:
> ...
Yes. His offer is great. I didn't intend to reject that; I just wanted to say it is much difficult than it seems. It took Eric Raymond's full year of preparation plus his full 8 week... -
09:38 PM Misc #10547: How to move the ruby project to git
- The outcome of "move the ruby project to git" probably means
different things to the Ruby community at large,
you (as GitLab CEO), or I...
But first, with Matz's concerns:
> 1. Incremental numbering
"git describe" does output... -
11:28 AM Misc #10547: How to move the ruby project to git
- Shyouhei Urabe wrote:
> The situation is that no one in ruby-core is actively willing to do any dirty work to get things move to git. I think we are all OK when someone else did so.
Hello Shyouhei,
I think Sytse is offering to he... -
- I have to say sorry about this: matz do not understand the situation. The situation is that no one in ruby-core is actively willing to do any dirty work to get things move to git. I think we are all OK when someone else did so. Right?...
-
08:33 AM Misc #10547 (Rejected): How to move the ruby project to git
- I'm posting this on the bugtracker as suggested by Koichi, feel free to move or close this if I've posted in the wrong project.
During rubyconf 2013 I briefly discussed the migration of ruby from svn to git with the core team. During ... -
10:47 PM Bug #10538 (Feedback): Error when trying to update gem rake
- Hello,
Can you confirm details of your environment?
For example, which command processor (cmd.exe, PowerShell) are you using?
Can you also confirm the locale setting of your Windows installation? For reference, similar problem a... -
07:39 AM Bug #10538: Error when trying to update gem rake
- This issue can be reproduced on Windows 7 Home Basic Edition. It seems OK on Windows 8.1 Pro.
-
10:43 PM Bug #10550: Resolv::DNS.getaddresses returns no IPs when nameserver returns in differing case than query
- My pasting got stripped:
Here is the message returned
~~~
#<Resolv::DNS::Message:0x007f3eff488a88 @id=26224, @qr=1, @opcode=0, @aa=0, @tc=0, @rd=1, @ra=1, @rcode=0, @question=[[#<Resolv::DNS::Name: sendgrid.com.>, Resolv::DNS::Res... -
- Our servers are hosted with Rackspace and following patching of BIND, their DNS servers started returning different casing for the ANSWER. For example, here is me resolving sendgrid.com. You'll see the first command returns "sendgrid.com...
-
10:33 PM Bug #10460: Segfault instead of stack level too deep
- Ran into this issue today when I accidentally created a stack overflow in my RSpec tests:
* ruby 2.1.5p273 (2014-11-13 revision 48405, [i686-linux]
* rspec 2.13.1
Attached is code which (sometimes) reproduces the problem (run with... - 10:12 PM Revision 06b582a0 (git): * 2014-11-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48594 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:11 PM Revision b65c6190 (git): compile.c (iseq_calc_param_size): hoist out of iseq_set_arguments
- This will be reused for iseq loading.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48593 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:14 PM Feature #10544: Time#to_i(:millisecond)
- How about a more general `Time#to_i(scale=1)`?
Examples:
* Passing `1` for `scale` (or passing nothing) would return seconds.
* Passing `1000` for `scale` would return milliseconds.
* Passing `1/60r` for scale would return minute... -
05:41 AM Feature #10544: Time#to_i(:millisecond)
- I want this feature to give unix time to other languages like JavaScript.
Some languages expect unix time in milliseconds. -
02:43 AM Feature #10544: Time#to_i(:millisecond)
- Do you need unix time in milliseconds so often?
-
- Currently, we have to take an indirect way to get unix_time in milliseconds.
~~~ruby
time = Time.now
milliseconds = (time.to_i * 1000) + (time.usec / 1000.0).round
~~~
I think it would be convenient if `Time#to_i` accepts unit p... -
04:12 PM Feature #10549 (Assigned): Deprecate each_with_index and each_with_object in favor of with_index and with_object
- I wonder if we can deprecate `each_with_index` and `each_with_object` and fully recommend `with_index` and `with_object` instead.
I personally like the shorter forms because they hint that they can be used with more methods than simpl... -
02:54 PM Misc #10541: Remove shorthand string interpolation syntax
- As for the argument that it should simply be used more: The interpolation shorthand has been around for a long time. The fact that it is still rarely used is a good indicator of its lack of usefulness to the community as a whole.
-
- I agree with Daniel Morrison and Richard Schneeman. This interpolation shorthand is clever but unnecessary. While being unnecessary may not be reason enough to deprecate a feature, this particular feature also has the potential for unexp...
-
08:12 AM Misc #10541: Remove shorthand string interpolation syntax
- > It has been the cause of real problems. http://status.cloudamqp.com/incidents/vj62pnp62tj9
I'd say the "cause" of the problem described in that article is that they deployed code to production without any testing or review. It's not... -
- Eric Wong wrote:
> Perhaps it needs to be used more so more Rubyists know about it...
And perhaps better editor's support.
"Anybody Must Not Use What I don't Use/Understand" is not a fair behavior. -
02:33 PM Feature #10548: remove callcc (Callcc is now going obsoleted. Please use Fiber.)
- That's a bummer!
Callcc is the most exciting toy for the functional programmers.
If Ruby had no callcc, I couldn't have been interested in Ruby.
No one think it production ready.
When callcc is used, the user is (or should be) no... -
11:52 AM Feature #10548 (Open): remove callcc (Callcc is now going obsoleted. Please use Fiber.)
-
- Applied in changeset r48588.
----------
* ext/continuation/continuation.c (Init_continuation): obsolete callcc.
first step of [Feature #10548]. -
We are paying a lot of costs for callcc's consistency.
and currently, we can use Fiber in many situation.
In https://bugs.ruby-lang.org/projects/ruby/wiki/DevelopersMeeting20140517Japan,
matz agreed to remove callcc.
If there i...- 01:31 PM Revision 18a7dade (git): * test/ruby/test_autoload.rb (class TestAutoload): change load target
- from Continuation to Date. Becouse Continuation is no longer quiet.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48592 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:28 PM Revision 2128f208 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48591 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/ruby.h (rb_get_kwargs, rb_extract_keywords): export
keyword argument functions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48590 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:38 PM Bug #10488 (Closed): Consistency of Module#const_defined? and constant lookup
- Indeed, it looks consistent with `const_get` and it seems difficult to be more consistent while keeping the same API.
Let's close this then. -
12:18 PM Revision 3f37ba11 (git): * test/inlinetest.rb: removed unused test helper.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48589 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:50 AM Revision 262245b0 (git): * ext/continuation/continuation.c (Init_continuation): obsolete callcc.
- first step of [Feature #10548].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48588 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:32 AM Revision 307198a3 (git): Fix typo
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48587 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:03 AM Bug #10491: TestGc#test_latest_gc_info often fails on mswin CI
- ぱっと見た感じよくわからなかったので、
ちょっと r48586 でプロセス分けてみましたが、どうでしょうか。
-
- to avoid mysterious behavior.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48586 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r48585.
----------
win32.c: for non-standard console
* win32/win32.c (constat_reset): do nothing on non-standard
console emurators. [ruby-core:66471] [Bug #10546] -
- OK, I could repoduce it with ConEmu 141125.
-
- Is it http://bliker.github.io/cmder/?
-
06:32 AM Bug #10546 (Closed): Bug Segmentation Fault when input prompt on cmder
- Hi,
Whenever I run a ruby file that has a prompt, I get the a bug segmentation fault. I'm using cmder, which is a console emulator for windows. I can run the files just fine if I use the standard cmd or another console emulator.
My... -
- * win32/win32.c (constat_reset): do nothing on non-standard
console emurators. [ruby-core:66471] [Bug #10546]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48585 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:47 AM Feature #10508 (Closed): Return enumerator in TSort iterators
- Applied in changeset ruby-trunk:r48584.
----------
* lib/tsort.rb: Returns an enumerator if no block is given.
[ruby-core:66270] [Feature #10508] Proposed by Andrey Savchenko. -
- [ruby-core:66270] [Feature #10508] Proposed by Andrey Savchenko.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48584 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- fixed at r48558
-
- 遅くなりました。
こちら、性能劣化をいやがって、このような仕様にしているところがあります。
同じようなものに、Fixnum 同士の足し算などがあります。
まつもとさんからは、「出来るようにして欲しい」というリクエストを頂いているので、対応したものだか悩んでいるところです。
どなたか、ご協力頂けないでしょうか。
(1) 性能測定
(2) 何か性能劣化がない形で提供する方法はないか
-
- Applied in changeset r48583.
----------
parse.y: fix invalid keyword argument
* parse.y (f_label, f_kw, formal_argument_gen): ignore invalid
formal argument in keyword argument definition.
[ruby-dev:48742] [Bug #10545] -
- def m(A: a) end とすると SEGV するようです。
```
% ./ruby -e 'def m(A: a) end'
-e:1: formal argument must be local variable
def m(A: a) end
^
-e:1: dynamic constant assignment
def m(A: a) end
^
./ruby: [BUG] Segmen... -
- * parse.y (f_label, f_kw, formal_argument_gen): ignore invalid
formal argument in keyword argument definition.
[ruby-dev:48742] [Bug #10545]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48583 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:22 AM Revision c7855be2 (git): use clock_gettime to avoid object creation
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48582 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48581 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- nop; nop works, but I don't think it's an improvement (or regression).
I prefer to save 2 words entirely.
I planned to workaround the issue by doing ISeq#load twice:
first = iseq.to_a # useless jump|nop here
junk = I... -
- I use nop insns instead of "jump to next insn" (2 words) in r48579.
How about it? -
- ko1: thank you for checking, any comment on the extra jumps insns which
I hack around by disabling peephole optimization?
It seems caused by the following in iseq_set_sequence:
else if (orig_sp - sp == 0) {
/* jump to n... -
- * proc.c (rb_method_call_with_block): use RUBY_SAFE_LEVEL_MAX,
which is declared in include/ruby/ruby.h since 2.1. The safe
level is now limited upto 3.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48580 b2dd03c8-39d4-4d8f-98f... -
- "jump to next insn".
https://bugs.ruby-lang.org/issues/8543#change-50085
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48579 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:03 AM Revision ef8c2e4b (git): iseq.c (iseq_s_compile_file): close IO when done
- This will prevent some leaked FD warnings in future tests.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48578 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/25/2014
-
- 以下のように、/(?<n>a(b|\g<n>))/ というだけのソースは
ruby -c では問題無しとなりますが、
Ripper.sexp では構文木でなく nil が返ってきてしまいます。
```
% cat z.rb
/(?<n>a(b|\g<n>))/
% ./ruby -c z.rb
Syntax OK
% ./ruby -rripper -e 'p Ripper.sexp(STDIN.read)' <... -
11:16 PM Misc #10541: Remove shorthand string interpolation syntax
- This syntax is very confusing and while not common could possibly lead to confusing bugs. That blog post referenced an actual bug in production. If I came across this code in the wild, I would be surprised by this behavior:
~~~
requi... -
- Eric, I think it is dangerous syntax because (to take the example from the link above) changing "foo-#@name-1" to "foo-#@name1" unexpectedly changes what variable gets used.
That mistake can't happen with "foo-#{@name}-1".
I prefe... -
- I agree, I think this syntax exception is confusing, harder to read and most Ruby editors will insert {} after # so it is not saving any keystroke in that case.
Additionaly, it might also encourage using $global_vars, @@class_vars and @... -
- I use it frequently. It saves me keystrokes and screen space.
I think it is more readable and less noisy this way, too.
Removing it will break existing code I have.
Perhaps it needs to be used more so more Rubyists know about it... -
- I would like to see the shorthand string interpolation syntax, "foo#@bar" deprecated and then removed in 3.0.
My reasons:
1. Most experienced Ruby developers I've talked to don't even know it exists.
2. It has been the cause of re... -
- repository から checkout した ruby を out-of-place で build すると、
enc/trans/big5.c などいくつかのファイルが
source directory と build directory の両方に生成されます。
どちらかだけに生成されるのが意図された動作なんじゃないでしょうか。
```
% cd /tmp
% mkdir r
% cd r
% svn co -q http://svn.ru... -
- So prebuild files for them in tarball are useless.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48577 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_method.c (rb_mod_remove_method): preserve encodings of method
name and class name in error messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48576 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48575 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * object.c (inspect_i): preserve encodings in inspected result
string.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48574 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_method.c (rb_method_entry_make): preserve encodings of
constant names in warning messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48573 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_eval.c (rb_method_call_status): preserve encoding of called method
name in error messages.
* vm_insnhelper.c (vm_call_method): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48572 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * safe.c (rb_secure): preserve encoding of the called method name
in error messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48571 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * safe.c (rb_insecure_operation): preserve encoding of the called
method name in error messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48570 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48569 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Since they depend on $(PREP) which is miniruby, they are rebuilt
after miniruby is built, even if tarball contains them.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48568 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:22 PM Revision c6d52afd (git): * 2014-11-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48567 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It is not used now.
* common.mk: prelude.c and golf_prelude.c doesn't depend on rbconfig.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48566 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48565 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I can't reproduce the error, too.
What about this patch?
~~~diff
diff --git a/gc.c b/gc.c
index 9c0dbef..f4c4e93 100644
--- a/gc.c
+++ b/gc.c
@@ -7869,10 +7869,10 @@ wmap_aset(VALUE self, VALUE wmap, VALUE orig)
TypedDat... -
- Seems nice! Thank you!
(maybe we need fix rdoc)
-
03:09 AM Bug #8543: new rb_iseq_load crash
- Eric Wong wrote:
> Sorry, the inline patch was an extremely hacky work-in-progress,
> ...
Ah, I see.
Thanks! v3 is indeed no longer segfaulting on any of the iseq tests
I have.
Awesome!
Thanks again,
Bill
-
- Sorry, the inline patch was an extremely hacky work-in-progress,
but I think rb_iseq_load_fix@v1.txt should've been OK with your
(non keyword) use cases.
Here is a slightly less broken, but still hacky work-in-progress:
http://8... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48564 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This issue is a known bug.
[Bug #595]: Fiber ignores ensure clause
(3 digits!)
Rubinius supports it.
----
This feature is not impossible, but a bit difficult because there are two ENSURE points.
1. Owner thread is terminate... -
07:09 AM Bug #10533 (Closed): HTTP reconnection with SNI does not send correct hostname
- Applied in changeset r48563.
----------
* lib/net/http.rb: Do not attempt SSL session resumption when the
session is expired. [Bug #10533] -
- Via #ruby-core IRC:
~~~
22:53 nurse: ok > 10533
~~~
So I will commit it. -
- session is expired. [Bug #10533]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48563 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:03 AM Revision 49cb4119 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48562 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:03 AM Revision 975bfe0a (git): * append newline at EOF.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48561 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/rake: ditto.
* NEWS: ditto.
* test/lib/minitest/unit.rb: Add compatibility shim for minitest 5.
This only provides minitest 5 unit test naming compatibility.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48560 b2dd03c8... -
- * tool/vcs.rb (get_revisions): use Time.new instead of Time.mktime
which does not accept UTC offset, and offset manually for older
versions than 1.9.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48559 b2dd03c8-39d4-4d8f-98ff-82... -
- * common.mk (update-gems): remove old version gems after
successfully downloaded.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48558 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:18 AM Revision 25661ef5 (git): add gem name [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48557 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * process.c (Init_process): initialize static IDs before constant
definitions. [ruby-core:66445]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48556 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:46 AM Revision 8f796231 (git): * 2014-11-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48555 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:46 AM Revision cbf987c8 (git): compile.c (iseq_build_callinfo_from_hash): hoist out
- iseq_build_from_ary_body indentation was too deep for my little
terminal, so extract it so it is easier to add keyword support.
* compile.c (iseq_build_callinfo_from_hash): hoist out
(iseq_build_from_ary_body): shorten callinfo case
... -
- You need parentheses.
-
- I agree that this is a documentation issue.
But afraid that the negative value is worth to mention.
11/24/2014
-
- Howdy,
Eric Wong wrote:
> That was only one of the breakages :)
> ...
Thanks so much for working on this.
Just some initial feedback -- after applying both patches to trunk,
I'm still seeing a segfault in the iseq.eval call on ... -
- Thanks for trying. I can not reproduce your broken object issue
with my patch on Linux (x86-64 and i686). "make check" passes, but
maybe something else is missing... -
09:04 PM Bug #10537: Repeated creation and garbage collection of WeakRef instances against a single object leaks memory
- Getting this:
~~~
irb(main):008:0> a = Object.new
=> #<Object:0x007fe1b983a278>
irb(main):009:0> WeakRef.new a
=> #<Object:0x007fe1b983a278>
irb(main):010:0> WeakRef.new a
NotImplementedError: method `==' called on broken T_???(... -
- Thanks, the following patch should fix it. Your test runs much in less
than 20s and uses 10M on my older x86-64 machine. It took over 2
minutes before.
(lightly tested, and I'm unfamiliar with the weakmap code):
~~~diff
--- a... -
- Data point: tacking a `printf` onto the end of `define_final0` in `gc.c` reveals that a new finalizer is being added to `a` for each WeakRef. I expect those are what's hogging memory.
-
- ~~~ruby
require 'weakref'
a = Object.new
1_000_000.times do
WeakRef.new a
end
GC.start
~~~
The above results in Ruby consuming ~150 MB of RAM, all of which can only be freed by dropping `a`. This should not be the case - an o... -
- This seems unfortunate. I'm not sure if there's a good way to do
this automatically with current APIs because `Fiber`s require
explicit scheduling.
Perhaps storing `Fiber`s in `Thread.current` and having a
`terminate_all_fibers` ... -
08:11 PM Bug #10540 (Closed): Yielded fibers do not execute ensure blocks
- When a thread has paused fibers, if an exception occurs anywhere in the thread, `ensure` blocks in the paused fibers do not execute.
The effect of this is that block-scoped resources (like File.open, Mutex#synchronize, ActiveRecord tr... -
04:07 PM Bug #10539: Wrong pattern matching when string interpolation inside regexp is used
- I think I found my error. Sorry
Please Close it.
Best regards,
Tammo
-
- Hello,
maybe it is my fault, but I stumble over the fact, that I get a match when I should not (have added a short example).
I use an Array to have a list of matching names like:
~~~ruby
a = ['moin','test','whatever']
~~~
and whe... - 02:03 PM Revision 7806df70 (git): * gems/bundled_gems: Update to 3.0.7.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48553 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:54 PM Bug #10475: Array#flatten should not accept a nil argument
- Jörg W Mittag wrote:
> IMO, the correct behavior would be to use `to_int`.
It *is* using `to_int`, except for `nil` which is treated specially.
> ...
Right. The documentation lists two interfaces (one with no argument, one with a ... -
10:52 AM Bug #10476: String.strip remove characters different than pure whitespace
- It looks perfect.
-
10:21 AM Feature #10489: Add inherit method for clearer and multiple inheritance
- Bráulio Bhavamitra wrote:
> A new and more intuitive syntax:
> ...
Module is "multiple inheritance" for ruby. I don't think it is a good idea.
-
09:32 AM Bug #10538: Error when trying to update gem rake
- This error seems to happen whenever an update suggests to replace a ruby binary... no matter the answer (y/n).
-
- when running "gem update rake" I get the following:
c:\>gem update rake
Updating installed gems
Updating rake
rake's executable "rake" conflicts with C:/Ruby21-x64/bin/rake
Overwrite the executable? [yN] C:/Ruby21-x64/lib/ruby/si... -
- * process.c (check_exec_redirect_fd, check_exec_redirect),
(rb_execarg_addopt): get rid of inadvertent ID pindown.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48552 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * process.c (Init_process): intern IDs at initialization.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48551 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * marshal.c (check_dump_arg, check_load_arg): use literal method
names, instead of converting from ID every time.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48550 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/23/2014
-
- * string.c (rb_str_setter): preserve encoding of global variable
name in error message.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48549 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * iseq.c (rb_insn_operand_intern): preserve encoding of method
name in CALL_INFO at disassembling.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48548 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:03 PM Revision 31aed958 (git): * 2014-11-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48547 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * io.c (must_respond_to): preserve encodings of variable name and
class name in warning message.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48546 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parse_gvar): replace with equivalent macro, TOK_INTERN,
as well as other places.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48545 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:13 AM Bug #10475: Array#flatten should not accept a nil argument
- Dov Murik wrote:
> Currently `Array#flatten` accepts an explicit `nil` argument which has the same meaning as `-1` (or no arguemnt) - meaning endless recursive flattening. I'd expect `flatten` to accept an integer argument only (or not ... -
- Eric Wong <normalperson@yhbt.net> wrote:
> The following patch might be ready to commit to trunk:
>
> http://80x24.org/spew/m/rb_iseq_load_fix@v1.txt
Still some bugs related to keyword args I'm working on, but am out of
time ... -
03:37 AM Revision 8d729372 (git): * gems/bundled_gems: upgraded to power_assert 0.2.2.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48544 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:49 AM Revision 83f0e9d6 (git): trivial packing of rb_execarg, load_file_arg, args_info
- * internal.h (struct rb_execarg): 160 => 144 bytes on x86-64
* ruby.c (struct load_file_arg): 48 => 40 bytes on x86-64
* vm_args.c (struct args_info): ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48543 b2dd03c8-39d4-4d8f-98ff... - 01:49 AM Revision 919b1aa5 (git): ChangeLog: fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48542 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- * lib/rexml/dtd/elementdecl.rb (PATTERN_RE): comment out overridden
constant, and '_' is included in '\w'.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48541 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/22/2014
-
- * test/ruby/test_variable.rb (ruler4): suppress warning.
(test_global_variable_poped, test_constant_poped): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48540 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:47 PM Revision 7fed49d2 (git): * 2014-11-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48539 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * io.c (rb_io_sysread): Remove redundan assignment of 'n'.
[Fix GH-767]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48538 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:23 PM Bug #10536: RubyDoc example for Enumerable#map incorrect
- That's intentional, both methods are aliases (note that the documentation for #collect and #map is the same).
-
05:03 PM Bug #10536: RubyDoc example for Enumerable#map incorrect
- ```collect``` is shown in the example section instead of ```map```
This is fully the case for the 2.0 doc (http://ruby-doc.org/core-2.0/Enumerable.html#method-i-map) and partially the case for the 2.1 doc (http://ruby-doc.org/core-2.1... -
- `collect` is shown in the example section instead of `map`
This is fully the case for the 2.0 doc (http://ruby-doc.org/core-2.0/Enumerable.html#method-i-map) and partially the case for the 2.1 doc (http://ruby-doc.org/core-2.1.0/Enume... -
- asmaloney@gmail.com wrote:
> IF !defined(HAVE_WORKING_FORK) and !defined(HAVE_SPAWNV), THEN argc
> and argv are declared. (lines 5938, 5939)
> Unless I'm missing something in the #if #else #endif fiesta, they
> don't seem to be init... -
02:46 PM Bug #10535 (Closed): Potential uninitialized reference pipe_open() in io.c
- (From git commit f5063b7ea7e774519602f7a112d9acf536a1da33 of 22 November 2014.)
In **io.c** in the following function:
~~~
static VALUE
pipe_open(VALUE execarg_obj, const char *modestr, int fmode, convconfig_t *convconfig)
~~~... -
09:27 AM Bug #10046: OpenSSL::TestSSLSession#test_ctx_server_session_cb and OpenSSL::TestSSLSession#test_ctx_client_session_cb test failures
- You would need to have OpenSSL built with this patch:
http://pkgs.fedoraproject.org/cgit/openssl.git/tree/openssl-1.0.1h-disable-sslv2v3.patch
This patch is now applied in openssl-1.0.1j-3.fc22 in Fedora Rawhide. I would not be sur... -
02:11 AM Bug #10046 (Assigned): OpenSSL::TestSSLSession#test_ctx_server_session_cb and OpenSSL::TestSSLSession#test_ctx_client_session_cb test failures
- I can't reproduce these test failures, but this patch looks ok to me
-
- Awesome, thanks! I was having trouble building trunk on OS X, so (I believe) I based it off of 2.1.5. Quite a bit more's changed than I had anticipated.
Thanks for writing up tests as well! -
- Your patch seems based on pretty old revision.
I made updated version: https://github.com/nobu/ruby/compare/Feature%2310481-conditional-rescue -
- billk@cts.com wrote:
> But ultimately, the result of the manual bisect was:
>
> 66d247bcb50a29769ff940100223544c125521aa is the first bad commit
> commit 66d247bcb50a29769ff940100223544c125521aa
> Author: ko1 <ko1@b2dd03c8-39d4-4d... -
- Eric Wong <normalperson@yhbt.net> wrote:
> Work-in-progress fix here, can you please test?
> http://80x24.org/spew/m/rb_iseq_load_fix-wip@v0.txt
Don't bother with that, I forgot to test iseq-load-test3-file.rb
hello.rb works fine,... -
- Work-in-progress fix here, can you please test?
http://80x24.org/spew/m/rb_iseq_load_fix-wip@v0.txt
Thanks. -
- * test/ripper/dummyparser.rb (on_rescue): add to turn exception
class list into NodeList, to test exception class list.
* test/ripper/test_parser_events.rb (test_rescue_class): add
missing test.
git-svn-id: svn+ssh://ci.ruby-lang.o... -
- * common.mk (verconf.h): update only when changed to reduce
unnecessary recompiling loadpath.c.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48536 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Ultimately I think this may be an OpenSSL bug.
Looking at the ClientHello message for the second connection (which uses session resumption) no ServerNameIndication extension is present. Without this the server won't be able to respon... -
04:49 AM Bug #10467: net/http reconnects without SNI
- This looks to be a duplicate now of #10533, which has a patch
-
- PWD environment variable may not exist.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48535 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/21/2014
-
-
- If session resumption is requested with an expired SSL session on an SNI server then the handshake goes wrong and the connection fails as above.
The attached patch only attempts session resumption if the session is still valid. -
- When reconnecting after connection timeout on an SNI connection the server name is not sent during reconnect which results in a failed reconnection:
~~~
$ cat test.rb
require 'net/http'
uri = URI 'https://david.shanske.com'
Net:... -
08:04 PM Revision 570c028c (git): * lib/resolv.rb: fall back if canonicalization fails.
- Thanks Vit Ondruch for the patch! [ruby-core:65836]
* test/resolv/test_dns.rb: test for patch
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48534 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Adding a patch based on the latest trunk, replacing the originally submitted one.
-
- Nobuyoshi Nakada wrote:
> With your patch, the condition is checked *after* matching against the exception classes, not a part of the matching, right?
> ...
They're checked after checking for a match against the exception classes, so t... -
- Intersting.
With your patch, the condition is checked *after* matching against the exception classes, not a part of the matching, right?
Which behavior is preferred? -
05:34 PM Feature #10444: [PATCH 3/3] Vector#[] returns new vector if argument is range.
- @Marc-Andre Lafortune
OK, it does make sense. Thank you for your time. -
- gogo tanaka wrote:
> But I think there is no reason `Vector[1,2,3][0..1]` returns not `Vector` but `Array`.
I agree completely, and don't I think it was intended. The doc states "Returns element number +i+" too.
-
- * object.c (rb_mod_const_get, rb_mod_const_defined): ditto.
* variable.c (rb_const_missing, rb_mod_const_missing): call
const_missing without new ID to get rid of inadvertent ID
creation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... - 03:58 PM Revision df06c284 (git): * 2014-11-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48532 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * common.mk (ext/ripper/ripper.c): move MAKEDIR to Makefile.sub.
* win32/Makefile.sub (PWD): set to $(MAKEDIR), nmake built-in macro.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48531 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:40 PM Feature #10523 (Rejected): Suggestion for new Array.delete_to method
- I prefer Array#partition for its immutability.
Matz.
-
- Sorry, it fixes just one of the two issues :/
-
- This patch is fixing the issue for me.
-
- `next` and `peek` indeed live in their little world described as "external enumeration" in the documentation.
The documentation of `next` and `next_values` states:
* Note that +next_values+ does not affect other non-external enume... -
11:38 AM Bug #10534 (Rejected): Enumerator methods other than "next" do not always respect "peek"
- It seems like using "peek" and then calling other methods on the Enumerator consumes the value that was peeked at. While `next` correctly returns the peeked-at value the next time it is called, other Enumerator methods such as `to_a` and...
-
- * common.mk (ext/ripper/ripper.c): use $(PWD) for Unix,
$(MAKEDIR) for Windows.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48530 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48529 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48528 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:27 AM Revision 539b39af (git): * win32/Makefile.sub (top_srcdir): added because lacking this macro causes
- build error at r48526.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48527 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48526 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48525 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- FILES_CONFUSING.
* ext/objspace/extconf.rb: Add VPATH for id.h
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48524 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (ext/ripper/ripper.c): fix dependencies for the case
to make ripper.y and id.h under the build directory.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48523 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/20/2014
-
- directory.
* common.mk (ext/ripper/ripper.c): $(RM) was not defined.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48522 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- normalperson@yhbt.net wrote:
> I also intend to support this in the "openssl" extension as well as
accept_nonblock for openssl:
http://80x24.org/spew/m/f453956f3b04d2445e54d3141cc564a2529ce0f7.txt
Also pushed to the "more_nonblo... -
- This is analogous to functionality found in IO#read_nonblock and
IO#wait_nonblock. Raising exceptions for common failures on
non-blocking servers is expensive and makes $DEBUG too noisy.
This also increases performance slightly, se... -
- @Marc-Andre Lafortune
Thank for reply.
OK, I got your point. Actually I'm not sure anyone want to do this.
But I think there is no reason `Vector[1,2,3][0..1]` returns not `Vector` but `Array`.
thanks. -
- Robert Klemme wrote:
> Do you have an idea of the runtime performance impact? I mean, a type check (as done today) is fast and effort cannot change. But with your proposal arbitrary code can be executed as part of the test. If you do... -
03:09 PM Feature #10481: Add "if" and "unless" clauses to rescue statements
- Alex Boyd wrote:
> I'd like to propose a syntax change: allow boolean "if" and "unless" clauses to follow a rescue statement.
> ...
Do you have an idea of the runtime performance impact? I mean, a type check (as done today) is fast ... -
- A second patch, to fix an uninitialized variable I noticed just after I'd uploaded the first.
-
- A patch.
I've only tested the Ripper bits cursorily, so I could very well have missed something - feedback in that particular direction would be appreciated.
I'm also not sold on the format of NODE_RESCOND in node.c, but I can't th... -
- @Marc-Andre Lafortune
Thank you for reply.
OK, the answer is when we expect `Matrix` to behave something like `Array`, I mean..
```ruby
[1,2,3,4][1..2]
#=> [2,3]
Matrix[[1,2,3],[4,5,6],[7,8,9]][0..1, 0..1]
#=> Matrix[[1,2... -
05:20 PM Feature #10528: Allow line breaks instead of commas in arrays, hashes, argument lists, etc.
- I forgot to mention other usual cases when lines should be implicitly continued: after a dot, after an operator symbol, etc.
-
- Since the seemingly reasonable proposal #8956 has been rejected because it "diverged so far from the original", i will dare to propose another version here.
I suggest to automatically convert line breaks inside parentheses `(...)`, in... - 03:39 PM Revision c1bad604 (git): * ext/openssl/lib/openssl/x509.rb
- (OpenSSL::X509::Name::RFC2253DN::StringChar): get rid of a false
positive assertion in ripper's test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48521 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:36 PM Revision a23e9c7f (git): * ChangeLog: missed at r48518.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48520 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:35 PM Revision 518ef569 (git): * ChangeLog: missed at r48516.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48519 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:29 PM Revision 9bbfca81 (git): * lib/net/imap.rb (Net::IMAP::ResponseParser::BEG_REGEXP): no need to use embbed
- string.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48518 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:19 PM Revision 947de1ce (git): * 2014-11-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48517 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:19 PM Revision 0a71befc (git): * lib/uri/mailto.rb (URI::MailTo::EMAIL_REGEXP): should escape `#`.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48516 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48515 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48514 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48513 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I have proposed another version: #10528.
-
08:19 AM Bug #10300: Encoding error in conversion from UTF-16LE to UTF-8 to CP850
- Nobuyoshi Nakada wrote:
> Or from `FormatMessage`?
> ...
Thanks that solved the issue!
- 08:04 AM Revision 37d0c509 (git): * test/psych/json/test_stream.rb (Psych::JSON::TestStream::test_list_to_json):
- escape `]`.
* test/psych/test_json_tree.rb (Psych::JSON::TestJSONTree#test_list_to_json):
ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48512 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:56 AM Revision 9d38d655 (git): * test/ripper/test_files.rb: set filename.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48511 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- bsdmake tries to make nkf.o with nkf-utf8/nkf.c without this.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48510 b2dd03c8-39d4-4d8f-98ff-823fe69b080e