Activity
From 07/13/2014 to 07/19/2014
07/19/2014
-
11:50 PM Bug #10061 (Closed): Segmentation fault
-
08:25 PM Bug #10061: Segmentation fault - Nobuyoshi Nakada wrote:
> It's a machine stack overflow, and should be fixed already.
> ...
ruby 2.2.0dev (2014-07-20 trunk 46879) [x86_64-linux]
Segmentation fault is fixed.
~~~
bug.rb:3:in `puts': stack level too deep (SystemS... -
- Will Wood wrote:
> After pulling the latest code, your fix still causes a seg fault. IMO you're still overrunning the buffer.
> ...
Can't you show the argument to `encode64`?
-
04:33 PM Bug #10019: segmentation fault/buffer overrun in pack.c (encodes)
- After pulling the latest code, your fix still causes a seg fault. IMO you're still overrunning the buffer.
~~~
d:/ruby-2.1.2-i386-mingw32/lib/ruby/2.1.0/base64.rb:38: [BUG] Segmentation fault
ruby 2.1.2p176 (2014-07-19 revision 4686... -
09:08 PM Feature #10069: [PATCH] Implement monadic operator for Matrix
- Yukihiro Matsumoto wrote:
> unary operator has nothing related to inject though.
It's kind of my mistake, sorry to confuse you.
I think it not seldom happens that we want do this(term monadic). And this is based on custom in math... -
11:16 AM Feature #10069: [PATCH] Implement monadic operator for Matrix
- As #10068, I like the idea, but unary operator has nothing related to inject though.
Matz.
-
- Before
```
m = Matrix[[1,2,3], [4,5,6]]
+ m
NoMethodError: undefined method `+@' for Matrix[[1, 2, 3], [4, 5, 6]]:Matrix
- m
NoMethodError: undefined method `-@' for Matrix[[1, 2, 3], [4, 5, 6]]:Matrix
```
After
```
... -
- Marc-Andre Lafortune wrote:
> Yes, ideally. If they can be discussed separately, they should be separate issues.
> ...
I see, I try this next time.
Thank you for your committing my patches. -
09:44 AM Feature #10058: [PATCH] Fix some coding styles
- gogo tanaka wrote:
> Sorry, I'm not familiar with how to use redmine. so you mean I need to make new 2 features?
Yes, ideally. If they can be discussed separately, they should be separate issues.
No need for this issue, it's alrea... -
- @ Mr. Marc-Andre Lafortune
> Even though it can be a pain, please split unrelated patches in different requests.
Sorry, I'm not familiar with how to use redmine. so you mean I need to make new 2 features?
(About unify_product_op... -
- oh.... I'm embarrassed now... thank you for teaching that!
How can I delete this patch from Feature?
gogo. -
- "iff" is "if and only if", not a typo.
-
- When I read codes, I notice some mistakes about comments.
It have nothing to do with ruby's performance.
If you don't mind that or are busy, you can ignore my patches.
gogo. -
04:10 PM Revision 2f1ce283 (git): * ext/openssl/ossl.c: use encryptor instead of encrypter in doc.
- contributed from @vipulnsward. [fix GH-663]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46879 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ```
We can build standard euclidean space easily with this method.
[Vector.basis(3, 0), Vector.basis(3, 1), Vector.basis(3, 2)]
=> [Vector[1, 0, 0], Vector[0, 1, 0], Vector[1, 0, 1]]
```
This patch is needed in https://bugs.... -
- Standard basis vectors are really important in linear algebra.
And we usually need this when we use matrix or vector. (base conversion, principal component analysis...
This is why I implemented.
But I recognize Ruby should be no... -
- 'ConditionVariable#marshal_dump' by @vipulnsward
[fix GH-672]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ```
For all n * n matrix m, k <- {1, 2, ..., n}.
m.laplace_expansion(k-1, :row) == m.laplace_expansion(k-1, :column) == m.det
It is important when we think about values contains not Scalar, like that.
Matrix[[Vector[1, 0], ... -
- Laplace expansion has really important mathematical property.
We can handle many thing with this (determinant, cross product)
So I'm confident that this method is necessary.
But I recognize Ruby should be not for mathematician b... -
- Applied in changeset r46876.
----------
io.c: fix rdoc of append mode
* io.c (rb_io_initialize): [DOC] fix rdoc of append mode. it does
not move the pointer at open. [ruby-core:63747] [Bug #10039] -
- Append mode doesn't move the pointer at open.
It moves it to the end at each `write(2)`.
-
05:06 AM Bug #10039: "a+" mode for File.open doesn’t work
- Writing with `a+` mode appears to work fine, but the `pos` cursor is not updated until the first IO operation.
echo -en "test1\ntest2\n" > test
irb
irb(main):001:0> f = File.open('test', 'a+')
=> #<File:test>
... - 03:32 PM Revision d177879f (git): * 2014-07-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * io.c (rb_io_initialize): [DOC] fix rdoc of append mode. it does
not move the pointer at open. [ruby-core:63747] [Bug #10039]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
Before
```
Vector[1, 0, 0].cross_product Vector[0, 1, 0]
=> Vector[0, 0, 1]
Vector[1, 2].cross_product
=> ArgumentError: wrong number of arguments (0 for 1)
Vector[3, 5, 2, 1].cross_product(Vector[4, 3, 1, 8], Vector[2,...-
- Usually We use cross_product in only 3 dimensions.
Sometimes we want to handle cross_product in n-dimensions.
But I recognize Ruby should be not for mathematician but rubyist.
Ruby doesn't need too academic method.
So If you ... -
02:22 PM Bug #10049: RDoc bug for time format
- > However, the documentation for Time.strptime says, simply:
> ...
Actually, I cannot find such description. I searched in these docs:
* Ruby 1.9.3 Time (http://ruby-doc.org/stdlib-1.9.3/libdoc/date/rdoc/Time.html)
* Ruby 1.9.3 Date... -
08:26 AM Bug #10049: RDoc bug for time format
- Tsuyoshi Sawada wrote:
> > However, the documentation for Time.strptime says, simply:
> ...
No, it doesn't mean that there must be a third digit, it means that the century is always explicit, never implied. This includes absence. For e... -
- > However, the documentation for Time.strptime says, simply:
> ...
I don't understand how you interpreted the phrase "with century". In order to express a year with century, there has to be the third digit (hundreds), which means there ... -
- The cited line of documentation:
%Y - Year with century (can be negative, 4 digits at least)
was taken from `strftime` (time.c:4395). Therefore, the phrase "4 digits at least" refers to output.
However, the documentation fo... -
- Thread fairness issue?
Checking interrupts seems to help it, but not sure.
~~~diff
diff --git a/thread.c b/thread.c
index 682e05f..6f67df6 100644
--- a/thread.c
+++ b/thread.c
@@ -4528,11 +4528,15 @@ rb_mutex_synchronize(VALUE m... -
01:29 PM Bug #10076: 2nd thread can't get mutex even though 1st thread released it (race)
- Attaching source code with reproduced problem.
-
- ~~~ruby
require 'thread'
m = Mutex.new
Thread.abort_on_exception = true
Thread.new {
loop {
m.synchronize {
puts 'got mutex in thread'
sleep 0.1
}
}
}
loop {
m.synchronize {
puts 'got mut... -
- I am not sure the term monadic is a proper one, but I like the idea.
Matz.
-
- I'm sorry my report looks ugly... I fix it. ↓
Before
```
v = Vector[1, 2, 3]
+ v
=> NoMethodError: undefined method `+@' for Vector[1, 2, 3]:Vector
- v
=> NoMethodError: undefined method `-@' for Vector[1, 2, 3]:Vector
`... -
Before
```
v = Vector[1, 2, 3]
+ v
=> NoMethodError: undefined method `+@' for Vector[1, 2, 3]:Vector
- v
=> NoMethodError: undefined method `-@' for Vector[1, 2, 3]:Vector
```
After
```
v = Vector[1, 2, 3]
+ v
...-
- The original idea includes dispatch based on type (Symbol), which is not a good idea in general.
The one proposed by ko1 is slightly better, yet I still don't love it.
Matz.
-
02:41 AM Feature #10064: &:symbol in when clause
- just idea.
```ruby
class Symbol
def ~@
self.to_proc
end
end
case 0
when ~:zero?
p :zero
end
```
-
10:14 AM Bug #10067: File.file? misleading semantics & documentation for symbolic links
- Nobuyoshi Nakada wrote:
> Citing from [POSIX manpage test(1)](http://www.unix.com/man-page/POSIX/1/test/)
> ...
Oh my, just double-checked, Python and Perl have implemented the same behaviour as test(1), along with Ruby.
The big d... -
- Citing from [POSIX manpage test(1)](http://www.unix.com/man-page/POSIX/1/test/)
> With the exception of the `-h pathname` and `-L pathname` primaries,
> ...
-
- I can confirm that `test -f` and `File.file?` seem to have the same return values in this example:
ln -s link file
ruby -e 'puts File.file?("link")'
false
test -f link; echo $?
1
touch file
ruby -e 'p... -
- * compile.c (iseq_compile_each): set FCALL flag on AREF call at
private aref op_assign. [ruby-core:63817] [Bug #10060]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:01 AM Bug #10075 (Closed): URI#join needs documentation of its behavior
- The [documentation](http://www.ruby-doc.org/stdlib-2.1.2/libdoc/uri/rdoc/URI.html#method-c-join) for `URI.join` says:
> "Joins URIs."
Let's look at what a similar `join` method [documentation](http://www.ruby-doc.org/core-2.1.2/Fil... -
07:33 AM Bug #10071 (Closed): Documentation for time.c contains broken links
- The documentation for `compat_common_month_table` in time.c:1326 contains a link to http://use.perl.org/articles/08/02/07/197204.shtml, which 404s. I tried to search for the original article (http://use.perl.org/use.perl.org/search1e49-2...
-
04:22 AM Revision ef809762 (git): * string.c: [DOC] teach rdoc symbol.c.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46874 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r46873.
----------
compile.c: private reader in op_assign
* compile.c (iseq_compile_each): allow to access private attribute
reader in op_assign. [ruby-core:63817] [Bug #10060] -
- * compile.c (iseq_compile_each): allow to access private attribute
reader in op_assign. [ruby-core:63817] [Bug #10060]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/time.rb (Time#apply_offset): Guards against a `nil` return
value from `Time.month_days` when offsetting date. Out of range
values are then caught when `Time.utc` is called (as usual).
Previously a `nil` return value from `Ti... -
12:06 AM Feature #10065: Make `gem env` command output valid YAML
- I just realized that the current output is actually valid Markdown (at least Github Flavored Markdown). The proposed patch does not change that at all. It just makes the output valid (Github Flavored) Markdown *and* valid YAML!
The...
07/18/2014
-
- It's same as `test(1)` command.
-
- The documentation for ``File.file?`` states:
"Returns true if the named file exists and is a regular file."
When trying that out I get the following results:
~~~
% /usr/bin/stat link
File: `link' -> `file'
Size: 4 ... -
- It's a valid path, and `File.expand_path()` doesn't reject non-existent pathes.
-
10:02 PM Bug #10066 (Rejected): File.expand_path performs poor validation of absolute path
- With `File.expand_path()`, if one of the arguments is of the form "~/.*", then it will search for the environment variable `$HOME`. If this is set to:
~~~sh
export HOME="/home/peter"
~~~
Then searching for `File.expand_path '~/.ba... -
11:35 PM Bug #10053: OpenSSL: incorrect return value check of EGD functions
- The Entropy Gathering Daemon was last updated twelve years ago.
Ruby should deprecate the use of egd functions and provide configuration options to use LibreSSL in place of OpenSSL, just like how the Editline Library can be used in pl... -
- It doesn't *need* to be YAML, but does it need *not* to be YAML? It is sooooo close already why not make it YAML? Besides, much of the info in the `GEM CONFIGURATION` section (where the only non-YAML syntax exists) comes from YAML file...
-
10:03 PM Feature #10065 (Feedback): Make `gem env` command output valid YAML
- Why does it need to be YAML?
I don't think it was ever intended to be YAML and with your change it will be too clumsy to be useful. -
- The output of `gem environment` is close to being valid YAML, but the `GEM CONFIGURATION` section uses `key => value` instead of `key: value` so the output cannot be parsed by YAML. The attached patch changes just one line to make the o...
- 09:20 PM Revision 595d057e (git): * 2014-07-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46871 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:20 PM Revision cf55e34e (git): * refactoring
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46870 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:11 PM Bug #10062: Segfault involving Queue
- The condition has been tagged as 'segfault' on all three projects. Since I will attempt to find a workaround, be sure to pull those tags, as well as 'devready' branches on rubyneat and rubyneat_examples
-
- Pushing an object onto a `Queue` instantiation causes a segfault. This was seen on Ruby versions 2.1.1 and 2.1.2
In the interests of being able to completely reproduce the environment in which this happens, I have included detailed in... -
07:20 PM Bug #10063: [ruby_2_1] test-all abort due to undefined marshal_dump from test_queue.rb
- May be something in my environment as `make test-all` runs fine on one of my other 64-bit Ubuntu Server boxes.
-
- ~~~
uname -a
Linux ubusvr64 3.13.0-32-generic #57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
git st
## ruby_2_1...origin/ruby_2_1
git log -1 --oneline
c7391a0 merge revision(s) r44516,r46159,r46196: ... -
05:42 PM Feature #10064 (Feedback): &:symbol in when clause
- Now we can put Proc objects in a when clause as this code.
~~~
require 'prime'
def test(n)
print "#{n} is "
case n
when :zero?.to_proc
puts 'zero'
when :even?.to_proc
puts 'an even number'
when :prime?.to_... -
- ~~~diff
diff --git i/compile.c w/compile.c
index 637e112..556efc2 100644
--- i/compile.c
+++ w/compile.c
@@ -4178,8 +4178,8 @@ iseq_compile_each(rb_iseq_t *iseq, LINK_ANCHOR *ret, NODE * node, int poped)
asgnflag = COMPILE_REC... -
04:52 PM Bug #10060: private attr_accessor and NoMethodError
- Not a bug, there is no such thing as a private accessor
- 09:08 AM Bug #10060 (Closed): private attr_accessor and NoMethodError
- ~~~ruby
class Bug
def initialize
self.n = 1 # ok
end
def t1
self.n = n + 1 # ok
self.n += 1 # in `t1': private method `n' called for #<Bug:0x000000019ae1a0 @n=2> (NoMethodError)
end
def t2
n # ok
... -
05:16 PM Bug #9902: Regexp#[] ignores after NUL byte in named capture index
- backported into `ruby_2_1` branch at r46869.
-
- @ Hiroshi SHIBATA さん
ファイルの削除や進捗、ステータスのハンドリングありがとうございます.
Thank you for your some supports.
@ Mr. Marc-Andre Lafortune
I don't know that ... ! it's great! Thank you for your kindness!!! -
- Gogo Tanaka san,
Thanks for these additional tests.
Please note that the vast majority of tests of the Matrix library are in RubySpec: https://github.com/rubysl/rubysl-matrix
I hope you'll find them extensive, having for instanc... -
- Applied in changeset r46861.
----------
* test/matrix/test_matrix.rb: Add tests for Matrix class.
[Feature #10057][ruby-core:63809] -
- @ Hiroshi SHIBATA さん
I split patch "reorder_Matrix#real_and_Matrix_imaginary.patch" to https://bugs.ruby-lang.org/issues/10058
How can I delete patch from feature ?
承知致しました.
7つのPATCHの内、"reorder_Matrix#real_and_Matrix_imagina... -
- Please split new feature and tests into another issue.
-
- I send 7 patches.
In one of patches (reorder_Matrix#real_and_Matrix_imaginary.patch), I just reorder methods.
I think Matrix#real should be upon Matrix#imaginary(From what I see complex.c)
In the others(6 patches), I add tests ... -
- Marc-Andre Lafortune wrote:
> Finally, my personal goal is that PRs are dealt as early as convenient, but definitely before a major release. Please realize that there is no real way to accelerate this cycle for new features.
OK, I g... -
- gogo tanaka wrote:
> I think only Mr. Marc-Andre Lafortune can review my PR, and this is why it take time to review.
I find it ironic that you feel it took me much time to review your patch, when it took you the same time to make the... -
- @ Shota Fukumori
> But please remember that almost of us are volunteer. I think you already know as you did, write a code, not only criticizing.
はい、多いに同意致します. ただ毎回、同じ方がレビュワーで、レビューに時間を要していたので（すみません結果的には僕がGithubを使っていたせいでした）
問題ではない... -
- >But I think Whether I use github or redmine, It's not problem.
github の pull request へのレビューが行われないことは、公式の issue tracker ではないので
私は問題とは思っていません。
一方で、redmine に継続的にパッチを送っているにもかかわらず、何も行動がない、という状況が
もしあるのであれば、問題だと思っています。解決したいです。 -
12:29 AM Misc #10032: Matrix classについて
- Translating from Japanese...
gogo tanaka wrote:
> > And I'm afraid that nobody but you can maintain matrix..
> ...
-> I'm afraid for losing maintainers.
> > Nobody but you haven't maintained EigenvalueDecomposition class, and it... -
- * re.c (match_aref): should not ignore name after NUL byte.
[ruby-dev:48275] [Bug #9902]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@46869 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:33 PM Feature #10058: [PATCH] Fix some coding styles
- > Naohisa Goto: Good point about __send__, I imagine it is to avoid classes that redefined send? In any case, I revised the uses of send in the Matrix lib and they are all to call our own private methods, so I think it's fine like this.
... -
- Naohisa Goto: Good point about `__send__`, I imagine it is to avoid classes that redefined `send`? In any case, I revised the uses of `send` in the Matrix lib and they are all to call our own private methods, so I think it's fine like this.
-
- Even though it can be a pain, please split unrelated patches in different requests.
1) Unify && vs and:
Thanks, this is good.
2) I reorder methods. I think Matrix#real should be upon Matrix#imaginary
Methods are sorted alphab... -
- > There are both && and and. So, I Unify with &&
Be careful that "&&" and "and" have different operator precedence, and they can not always be simply replaceable.
&& と and は演算の優先順位が異なるので、単純に置換できない場合もあるのは要注意です。
http://qiita.com/... -
- > There are both send :xxx and send(:xxx) expressions. So, I Unify with send(:xxx)
I think "send" should be replaced with "__send__", because the Japanese version of reference manual for Object#send says that libraries should use "__s... -
- When I read codes, I notice some issues about coding style.
If you don't mind that, you can ignore my patches. It's just coding style problem.
コードを読んでいる中でコーディングスタイルに関して気になる事があったのでPATCHを投げますが、
こちら（redmine, rubyコミュニティ）のコーディングスタイルに... -
- * array.c (rb_ary_any_p): the array may be modified in the yielded
block, do not access directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- does not support VT_RECORD. VT_RECORD should be supported in
WIN32OLE_RECORD.
* test/win32ole/test_win32ole_variant.rb (test_s_new_vt_record_exc):
ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46867 b2dd03c8-39d4-4d8f-9... -
- * array.c (rb_ary_any_p), hash.c (rb_hash_any_p): optimized
versions. these are bit faster than optimization in
Enumerable#any?.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46866 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- revert "enum.c: optimize any? object allocations for Array and Hash"
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It's #9776.
-
- Stephen Celis wrote:
> - **kwargs are mutable
> ...
I believe this is a bug. Matz, could you confirm?
-
- It's a machine stack overflow, and should be fixed already.
Try recent versions. - 09:19 AM Bug #10061 (Closed): Segmentation fault
- ~~~
array = []
100000.times { array = [array] }
puts array
~~~
~~~
bug.rb:4: [BUG] Segmentation fault at 0x007fffaa0e0ff8
ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-linux]
-- Control frame information -------------------... -
- code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:11 AM Revision 84eba0de (git): * lib/matrix/eigenvalue_decomposition: Style fix
- Patch by Gogo Tanaka [#10058]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:04 AM Revision b0eda568 (git): * lib/matrix.rb: Avoid using `and`.
- Patch by gogo tanaka [#10058]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [Feature #10057][ruby-core:63809]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- タイトルに書きました通り、代数構造を記述する時にメタプログラミングは非常に非常に強力で
保守性や可読性を著しく推し上げます. 著しくです. これは代数的な性質（演算子の対称性、可逆性など）を記述出来る事に起因します.
しかし議論を呼びそうなのと取り分け優先度が高い訳でないので、提案レベルで簡単なPATCHを投げさせて頂きます. お手透きの時にでも目をお通し下さい. -
- * ChangeLog: fix Github reference in r46859. [fix GH-671]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46860 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * enum.c (enum_any): optimize object allocations for Array and
Hash when `each` is not redefined, always false if empty and the
case without a block. [fix GH-617]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46859 b2dd03c8-39d... -
- * vm_core.h (struct rb_vm_struct): move redefined_flag from
ruby_vm_redefined_flag.
* vm_core.h (BASIC_OP_UNREDEFINED_P): move from vm_insnhelper.h.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46858 b2dd03c8-39d4-4d8f-98ff-823f... -
- * configure.in: add --with-destdir option which sets default
destination directory to install.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46857 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- Add Matrix#adjugate to make a matrix adjugate.
Adjugate is really important operator to handle matrix (especially Exploring Data with ruby)
```ruby:
# Property
* Any n-th matrix `m`(object of Matrix class) Satisfy the followin... -
- [fix GH-669]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46856 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/17/2014
-
- If `require` failed, you don't have the features (classes and modules) from the library, so that your program would not work. So I think plain `require_failsafe` is useless.
Matz.
-
09:54 PM Bug #10055 (Closed): Shellwords.shellsplit() does not match POSIX sh behavior for backslashes within double-quoted strings
- In POSIX sh, the following commands are identical:
~~~
printf '%s\n' hello world
printf "%s\n" hello world
~~~
However, Shellwords.shellsplit() parses them differently:
~~~
head :001 > require 'shellwords'
=> true
head :0... -
- @ Shota Fukumori さん
すみません、僕の英語力が拙いばかりに. お手数おかけ致します.
I'm really sorry for my poor English.
僕が意図してた事を対訳と共に以下に示します.
> And I'm afraid that nobody but you can maintain matrix..
JP ->僕はあなた（Marc-Andre Lafortuneさん）以外の誰もMatrix class ... -
- gogo tanaka wrote:
> And I'm afraid that nobody but you can maintain matrix..
(snip)
> ...
(snip)
> But I think Whether I use github or redmine, It's not problem. (If it's github's problem, We should solve that right now. )
Sorry... -
- @ Mr. Marc-Andre Lafortune
You reviewed all of my PR about Matrix, I really appreciate your review, thank you.
As Mr. Yukihiro Matsumoto said, I want to accelerate development. And I'm afraid that nobody but you can maintain ma... -
06:38 PM Bug #8507: Keyword splat does not convert arg to Hash
- Another issue with keyword args and consistency with args:
- *args are immutable
- **kwargs are mutable
~~~ruby
def splat *args
args << 'foobar'
end
arr = []
splat(*arr)
arr # => []
def double_splat **kwargs
kwargs[:... -
06:22 PM Feature #10038: Extend ObjectSpace.dump to expose buffer addresses for String and Array
- Eric Wong wrote:
> The objspace extension is already implementation-specific and documented
> ...
I suppose that's fair. We haven't had anyone request features from 'objspace' in JRuby.
I would still prefer an MRI-specific namespac... -
05:21 PM Feature #10038: Extend ObjectSpace.dump to expose buffer addresses for String and Array
- headius@headius.com wrote:
> If a feature like this must be added, put it in an MRI-specific
> namespace like RubyVM. And I'd still recommend not adding another
> feature that limits Ruby's (and MRI's) evolution.
The objspace exte... -
- -1 from me, mostly because exposing actual memory addresses will *further* limit what Ruby can do with object references. In the presence of RGenGC, some objects are already being relocated in memory, so those objects would either have t...
- 04:55 PM Revision 1e92d275 (git): * 2014-07-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46855 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * iseq.h (iseq_catch_table_bytes): check range and suppress a
warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46854 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I don't really understand the benefit of having Time literals.
I don't see `20140718T` more readable than `Time.new(2014,7,18)`.
Matz.
-
- Andrew Vit wrote:
> The "Z" suffix is for "Zulu Time", also known as UTC, so I would expect that to return a proper UTC time.
Indeed.
https://github.com/nobu/ruby/compare/time_literal -
- * ext/thread/thread.c (queue_pop_should_block): returns int
instead of VALUE, and use rb_check_arity.
* ext/thread/thread.c (szqueue_push_should_block): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46853 b2dd03c8-39d4-4d8... -
- Applied in changeset r46852.
----------
thread/thread.c: non-blocking push on SizedQueue
* ext/thread/thread.c (rb_szqueue_push): add optional parameter,
non_block defaulted to false. [ruby-core:63794] [Feature #10052] -
09:50 AM Feature #10052: Add parameter non_block (defaults to false) on SizedQueue#push
- The following patch should do the trick.
Another thing to consider in this file: don't mix up tabs and spaces. The indention is completely gone when viewing with a tabstop < 8. -
- The implementations of Queue and SizedQueue have a method pop, where a parameter non_block would make the call raise a ThreadError if the queue is empty. Since popping of an empty queue is comparable with pushing to a full SizedQueue, I ...
-
- * ext/thread/thread.c (rb_szqueue_push): add optional parameter,
non_block defaulted to false. [ruby-core:63794] [Feature #10052]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46852 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/thread/test_queue.rb (test_queue_pop_non_block): test for
non-blocking pop.
* test/thread/test_queue.rb (test_sized_queue_pop_non_block):
ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46851 b2dd03c8-39d4-4d8f-98ff... -
09:43 AM Bug #10054 (Closed): Net::HTTPGenericRequest sets host even if it was set before by user
- ~~~
# there is SSH tunnel that forwards 127.0.0.1:9293 to google.com:80
request = Net::HTTP::Post.new(URI("http://127.0.0.1:9293")).tap do |req|
req.form_data = {q: "ruby"}
req["Host"] = "google.com"
end
~~~
This code ignore... -
09:32 AM Bug #9344 (Closed): warning origin incorrect with instance_eval
- Onigmo 5.14.1 was merged with r46831.
Fix for this issue is included in Onigmo 5.14.1.
> Rather I think onig_syntax_warn() should use onig_verb_warn instead of calling rb_warn() directly.
> ...
If you send me another pull request, I... -
09:16 AM Bug #7215: Remaining messages on OpenSSL error queue after Certificate#verify
- Any changes here? Can confirm that problem persists in newer versions of ruby (i.e. 2.1.0p0 (2013-12-25 revision 44422) [x86_64-linux] and 2.1.2p95 (2014-05-08 revision 45877) [x86_64-linux]).
-
09:16 AM Bug #8716: segmation fault 正規表現で大量のグループを利用時
- Ken Takata wrote:
> クローズの際の取り決めがあるのかということを気にしていました。
> ...
直したら閉じていいですし、直ってるのに閉じてなかったら閉じていいです。
……というくらいのゆるーい運用だと思います、現状は。
あまり厳密なルール作ってもどうせ守られないので、こんなもんでよろしいかと。
Backport欄はUNKNOWNで放置するのが安全です。
それなりの確信があればREQUIREDやDONTNEEDにしてもかまいません。
... -
- クローズの際の取り決めがあるのかということを気にしていました。
(勝手に閉じて良いのかとか、Backport 欄は誰が何を設定するとか。)
> 該当修正部分のみを抽出して取り込むことになるかと思います。
関連コミットを挙げておきます。以下の4件となります。
1. alloca でスタックオーバーフロー
https://github.com/k-takata/Onigmo/commit/b9fba1dc63ccb42a86e934011b468e60... -
- Ken Takata wrote:
> Ruby 2.0/2.1へのバックポートはどうしましょうか。
該当修正部分のみを抽出して取り込むことになるかと思います。
しかし、backportチケットから持ってくるとBackport欄が空白になるというのは
本当に困るのでどうにかならないものかしらん？ -
- 閉じます
Edit → Status → Closed ですね。あるいは ChangeLog/commitMessage で [Bug #8716] とか。
http://img.sorah.jp/20140717_16.34_urw8d_Bug_8716_segmation_fault___rubytrunk__Ruby_Issue_Tracking_System.png
-
09:01 AM Bug #10053 (Closed): OpenSSL: incorrect return value check of EGD functions
- https://www.openssl.org/docs/crypto/RAND_egd.html#RETURN_VALUE
~~~diff
diff --git a/ext/openssl/ossl_rand.c b/ext/openssl/ossl_rand.c
index 270a4b7..a9188bc 100644
--- a/ext/openssl/ossl_rand.c
+++ b/ext/openssl/ossl_rand.c
@@ -1... -
-
- *Note that normal maintenance phase of 1.9.3 has already ended.*
I can't reproduce it on my environment.
* Windows 7 x64
* ruby 1.9.3p545 (2014-02-24) [x64-mswin64_100]
Don't hide the result of `ruby -v`. We are not espers.
... -
- Currently methods of `String` don't deal with Unicode properties.
Possibly some gems might be available. -
06:40 AM Feature #10051 (Open): nbsp isn't remove with trim
When I have a nbsp character in a string and call strip on it, it will not remove it even though is would could as a whitespace.
E.g.
```ruby
Nokogiri.HTML(" ").text.strip
```
results in `" "` and should result in `""`-
- You loaded an extension library linked against the shared libruby from statically linked ruby.
```
4 ruby 0x000000010027cd40 sigsegv + 144
5 libsystem_platform.dylib 0x00007fff88d0d5aa _sigtramp +... -
05:13 AM Bug #10041: Segmentation Fault.
- Attached is the file containing more information.
-
07:33 AM Bug #10031 (Assigned): Net::IMAP idle can still block a thread forever.
-
- I forgot to note this the last publically-visible struct which may be
packed. Internals for the others are defined privately:
$ pahole -P ruby
rb_thread_struct 1016 1000 16
rb_execarg 160 152 8
io_internal_writev_struct 24 1... -
- This will allow x86-64 machines to only use 3 cache lines instead of 4
(where cache size == 64).
Hopefully there are other 64-bit architectures which benefit, too.
This is also public ABI breakage, so I hope to commit it around wh... -
- * parse.y (tokadd_ident, tokenize_ident): extract from
parse_ident().
* parse.y (parse_gvar, parse_atmark): move tokenization from
parse_ident().
* parse.y (parse_ident): now deals with non-sigil names only.
git-svn-id: svn+ssh://... -
- * parse.y (parse_atmark): extract from parser_yylex().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parse_ident): extract from parser_yylex().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46848 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parse_gvar): extract from parser_yylex().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parse_percent): extract from parser_yylex().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46846 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parse_qmark): extract from parser_yylex().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46845 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parse_rational): extract from parse_numeric().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:30 AM Revision f180814e (git): * 2014-07-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46843 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (parse_numeric): extract from parser_yylex().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46842 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (negate_lit): alter only literal object itself, not NODE.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46841 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/16/2014
-
- r46831 で Onigmo 5.14.1 がマージされましたので、これも取り込まれました。
チケットのクローズ手順がよく分かっていないので、処理をお願いします。＞NARUSEさん
(あと #9344 も)
Ruby 2.0/2.1へのバックポートはどうしましょうか。 -
08:54 PM Feature #10040: `%d` and `%t` shorthands for `Date.new(*args)` and `Time.new(*args)`
- > Nathan, Date is only available in stdlib (maybe it should be moved to core) so I don't think those literals will work for dates with "D".
I would definitely vote to move Date to core, I think that's a great idea
> ...
Yep, I thin... -
- I like that literal syntax!
~~~
Time.new(2014, 7, 15, 12, 58, 45, "+00:00").utc? #=> false
Time.utc(2014, 7, 15, 12, 58, 45).utc? #=> true
~~~
The "Z" suffix is for "Zulu Time", also known as UTC, so I would expect tha... -
- Nobuyoshi Nakada wrote:
> I don't think there is possibilities to introduce `%d` and `%i`, especially using variables.
I understand if the syntax doesn't feel quite right, I'm not sure about it either. But I think it should be quite ... -
- I don't think there is possibilities to introduce `%d` and `%i`, especially using variables.
But the latter would be different story, you may want to file another ticket for it.
And yet another idea came to my mind:
```ruby
20140... -
- A bug report https://bugs.ruby-lang.org/issues/8941 notes a contradiction between RDoc and Ruby behavior. If tadayoshi funaba is correct and `%Y` should be able to accept digits less than four, then the following RDoc description is a bu...
-
06:49 PM Bug #10048 (Closed): Time comparison broken on Windows, Ruby 1.9.3
- Ruby 2.0 on OSX:
~~~ruby
Time.parse("2014-07-15 14:25:04") <= Time.now
=> true
~~~
Ruby 1.9.3 on Windows 7 Embedded:
~~~ruby
Time.parse("2014-07-15 14:25:04") <= Time.now
=> false
~~~ -
03:17 PM Feature #10047 (Feedback): Proposal for failesafe requires
- Hi guys,
I know this is unlikely to make it in, so it can be closed soon I suppose,
but a short discussion might be useful still?
I am doing something like this here quite often:
begin
require 'foo_bar'
rescue LoadError; en... -
- VT_RECORD variant.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46840 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:03 PM Bug #7877: E::Lazy#with_index should be lazy
- Is it somehow related? http://stackoverflow.com/q/24782712/322020
... .lazy ... .take_while.with_index{ ...
ArgumentError - tried to call lazy take_while without a block:`
Nevermind, swaping the chain in this way .with_index.take_wh... -
12:57 PM Bug #10045: SegFault in BigDecimal in 2.1.2p95
- It seems that this bug is a duplicate of bug #9657.
The bug was fixed and backported to ruby-2.1.2
https://bugs.ruby-lang.org/projects/ruby-21/repository/revisions/45815
The above stack trace shows that rubygems(bigdecimal-1.2.5) v... -
11:19 AM Bug #10045: SegFault in BigDecimal in 2.1.2p95
- Actually, I'm not sure if this should be core or extensions? Please correct as needed during triage; I'm not familiar with the core project's processes.
-
- We use Travis CI to build our code and are having issues with some builds terminating; today we caught a segfault in one of the unresponsive builds' logs. It appears to be a segfault in `BigDecimal`. This is in Ruby `2.1.2p95` which is c...
-
12:47 PM Bug #10046 (Closed): OpenSSL::TestSSLSession#test_ctx_server_session_cb and OpenSSL::TestSSLSession#test_ctx_client_session_cb test failures
- I observe following test failures in Fedora 21 and Rawhide:
~~~
4) Error:
OpenSSL::TestSSLSession#test_ctx_server_session_cb:
OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 state=SSLv3 read server hello A: sslv3 alert han... -
- r46838 is temporal workaround for this bug. Please remove when the drastic solution come.
r46839 changes the type of stack_max to int. This reverts r42401 and part of r23945. -
- because all calculations related to stack_max in compile.c
(iseq_set_sequence) and vm_insnhelper.c (vm_push_frame) are
conducted by using int. This partly reverts r23945.
* vm_insnhelper.c (vm_push_frame): ditto. This reverts r42401.... -
- Add padding on big-endian 64-bit architecture (e.g. sparc64).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:35 AM Revision 25ece76e (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46837 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- rb_hash_fetch instead of rb_hash_aref.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- rb_vm_t::trap_list_cmds (an array) and
rb_vm_t::trap_list_safes[RUBY_NSIG]
(separate to two different array).
This modification reduce root objects.
* signal.c: ditto.
* vm.c (rb_vm_mark): remove marking code for rb_vm_t::trap_list... -
09:33 AM Bug #10044 (Closed): socket.write has different behaviors in process and thread
- It's a use case that sending message to syslog through unix socket.
My env is Amazon Linux 2013.09.
Run the script attached and check /var/log/message, you will see:
The result of socket.write in a thread is cut around 4KB, which se... -
- marking from vm_mark().
* vm.c (rb_vm_mark): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46833 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm.c: remove mark function for RubyVM object because
RubyVM object marked manually.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46832 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- No objection?
-
-
-
- Hello.
I've encounter the similar issue on Mac OS X Mavericks with Ruby 2.0.0-p481 and 2.1.2.
But in my case, the problem is server configuration about intermediate certificate.
The right configuration (SSSLCertificateChainFile of h... -
- Hello, Martin.
It is not a bug.
At first, please take a look at the script belows.
Script:
$LOAD_PATH << "."
File.unlink "dbm.rb" if File.exist?("dbm.rb")
p require "dbm"
open("dbm.rb", "w") do |f|
... -
03:27 AM Bug #9092 (Closed): Update Unicode data to Unicode Version 7.0
- Applied in changeset r46831.
----------
* regcomp.c: Merge Onigmo 5.14.1 25a8a69fc05ae3b56a09.
this includes Support for Unicode 7.0 [Bug #9092]. -
- this includes Support for Unicode 7.0 [Bug #9092].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46831 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- There are some SJIS variants which includes Emoji.
Therefore you must which variant will you use.
Use SJIS-DoCoMo, SJIS-KDDI, or SJIS-SoftBank instead of SJIS. -
- I don't want to repeat "please show your Crash Report log".
-
- Please backport r44916, which mentions about Crash Report log file on MacOS X.
-
-
- Please show the following files:
~~~
-- Crash Report log information --------------------------------------------
See Crash Report log file under the one of following:
* ~/Library/Logs/CrashReporter
* /Library/Logs/Cr...
07/15/2014
-
- The postfix rescue notation is convenient...but almost always is a really bad antipattern.
An example of the notation:
Integer(f) rescue f # returns f if it is not parseable as an Integer
It silently ignores all StandardErro... -
- Getting segmentation fault with rake routes, rails server, or any rails generate etc.
This is the output I get when running rake routes.
```
/usr/local/rvm/gems/ruby-2.0.0-p481/gems/eventmachine-1.0.3/lib/rubyeventmachine.bundle... -
- Is EVP API necessary?
I've reverted it because of segfaults on many platforms. -
- Thanks Nobu. Nonetheless, I don't think it is backportable (which was not necessarily the point :).
-
- Applied in changeset r46826.
----------
digest.c: raise exception on init failure
* ext/digest/digest.c: expect digest init and finish functions to
indicate success or failure; raise exception on failure.
[ruby-core:61614] [Bug #9659] -
02:28 PM Bug #9659: crash in FIPS mode after unchecked algo->init_func failure
- The above set of patches looks good to me.
-
- https://github.com/nobu/ruby/compare/Bug%239659-digest-failure
-
- Hi, can we please push this forward? Since the fixes proposed so far seems to break API/ABI, it would be nice to have fixes in upstream Ruby sooner than later. This would help incorporate this patch into future versions of RHEL/CentOS/Fe...
-
- I'm working on a Ruby application where we have to deal with a lot of dates and times, especially in our test suite. We currently have a couple thousand cases of `Date.new(...)`, and I'm finding the syntax to be a little unwieldy.
Wha... -
- SASADA Koichi <ko1@atdot.net> wrote:
> (2014/07/16 1:38), ngotogenome@gmail.com wrote:
> > With the patch, the following error occurs. (using r46830)
>
> That't it.
>
> Please add padding zero's 2bytes after type for workaround.... -
- (2014/07/16 1:38), ngotogenome@gmail.com wrote:
> With the patch, the following error occurs. (using r46830)
That't it.
Please add padding zero's 2bytes after type for workaround.
I will make drastic solution.
--
// SASADA ... -
- With the following additional patch, the "[BUG] unreachable" occurs after iseq->stack_max is set to 124 (== 0x7c).
~~~
Index: compile.c
===================================================================
--- compile.c (revision 4... -
- With the patch, the following error occurs. (using r46830)
~~~
(snip)
./miniruby -I./lib -I. -I.ext/common "./tool/transcode-tblgen.rb" -vo "enc/trans/single_byte.c" "enc/trans/single_byte.trans"
generating enc/trans/single_byte.c... -
```c
enum iseq_type {
ISEQ_TYPE_TOP,
ISEQ_TYPE_METHOD,
ISEQ_TYPE_BLOCK,
ISEQ_TYPE_CLASS,
ISEQ_TYPE_RESCUE,
ISEQ_TYPE_ENSURE,
ISEQ_TYPE_EVAL,
ISEQ_TYPE_MAIN,
ISEQ_TYPE_DEFINED_GUARD
} type; /* in...-
- ngotogenome@gmail.com wrote:
> With "int stack_max" without dummy, the same error.
Thanks for trying. Do you have a different compiler to try?
Maybe do some rearranging of the struct, I'm out of ideas :(
The current iseq struct l... -
- With "int stack_max" without dummy, the same error.
~~~
(snip)
./miniruby -I./lib -I. -I.ext/common "./tool/transcode-tblgen.rb" -vo "enc/trans/single_byte.c" "enc/trans/single_byte.trans"
generating enc/trans/single_byte.c ...
c... -
- ngotogenome@gmail.com wrote:
> I think it is possbile that the first 8 byte (in 64-bit architecture)
> of "struct rb_iseq_struct" is sometimes used for some other purposes
> (maybe VALUE ?), and on big-endian 64-bit architecture (inc... -
- Since r46798, failed to build on Solaris 10 running on SPARC64.
~~~
(snip)
converter from WINDOWS-874 to UTF-8
converter from UTF-8 to WINDOWS-874
enc/trans/single_byte.trans:22: [BUG] rb_vm_get_cref: unreachable
ruby 2.2.0dev (2... -
06:47 PM Bug #10039 (Closed): "a+" mode for File.open doesn’t work
- Hi there,
According to [the documentation](http://www.ruby-doc.org/core-2.1.2/IO.html#method-c-new) the "a+" file open mode should open a file:
> Read-write, starts at end of file if file exists
However, it appears that the "a+"... - 03:43 PM Revision bb51e69a (git): * 2014-07-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46830 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- r46828 "md5ossl.c: indicate the result" caused segfaults.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46829 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:39 PM Feature #7792: Make symbols and strings the same thing
- So now that Symbol GC is implemented (#9634), does that change anything about the viability of this proposal?
-
- Yes, this is a duplicate of [9634](https://bugs.ruby-lang.org/issues/9634).
-
- Oh, I didn't know that.
I confirmed with VC6 SP6 that the function exists in the library.
(But they are not declared in malloc.h.) -
- They seem provided as statically linked functions.
```
C:\Program Files (x86)\VC98\lib> dir msvcrt.lib
2000/03/07 00:00 236,042 msvcrt.lib
C:\Program Files (x86)\VC98\lib> ..\bin\dumpbin -symbols msvcrt.lib | findstr _... -
- VC6 doesn't have _aligned_malloc/free. I think you should use VC7 or later.
Or, attached patch might fix the problem? -
03:54 AM Bug #10027: make at windows , err : _rb_file_expand_path_internal already defined in file. obj
- Nobuyoshi Nakada wrote:
> Those functions are in msvcrt.lib.
> ...
oh , I'll install service packs , thank you . -
- * ext/digest/md5/md5ossl.c: use OpenSSL EVP API instead of MD5 API
to perform MD5 hashes using OpenSSL in ext/digest.
[ruby-core:61614] [Bug #9659]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46828 b2dd03c8-39d4-4d8f-98ff-823f... -
- * ext/digest: make built-in digest function implementations
indicate success or failure of init and final functions.
[ruby-core:61614] [Bug #9659]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46827 b2dd03c8-39d4-4d8f-98ff-823fe... -
- * ext/digest/digest.c: expect digest init and finish functions to
indicate success or failure; raise exception on failure.
[ruby-core:61614] [Bug #9659]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46826 b2dd03c8-39d4-4d8f-98ff... -
02:52 PM Bug #10019: segmentation fault/buffer overrun in pack.c (encodes)
- It seems that the (off-by-one) issue is also present in Ruby 1.9.3, requiring a backport too.
It may also worth confirming with the reporter if he continues to observe the crash after adding the fix, since as Tomas analysis of aws-sdk... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46825 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It works in ruby-2.0.0-p481.
If you compare the files lib/find.rb from both versions, you can see that some code for encoding has been added. This is where it breaks.
Another option might be to give the Pathname class a method enco... -
- I don't think I can agree with you in regards to Pathname being a more suitable type - because I rarely use Pathname myself, with just about the single exception being code like this here:
Pathname(__FILE__).dirname.realpath.to_s
... -
- +1
-
- ObjectSpace.dump() expose internal information in JSON.
How about to expose buffer addresses for String and Array?
```diff
Index: ext/objspace/objspace_dump.c
===================================================================
---... -
- * tool/rbinstall.rb (gem): fix permissions of bundle gems
directories.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46824 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/rubygems.rb (Gem.install): pass optinos to
Gem::DependencyInstaller.
* tool/rbinstall.rb (gem): respect DESTDIR.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46823 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_env.rb (test_memory_leak_{aset,select,shift}):
test for Windows platform specific code.
(test_memory_crash_select): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46822 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Naohisa Goto wrote:
> r46791 にて、Solaris 9 以降で、以下を満たす場合に、それらの環境変数をセットして invoke_ruby するように変更しました。
> ...
これ、failureのままよりskipしてしまったほうがいいのではないでしょうか。 -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46821 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:07 AM Revision bf0e6f0a (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46820 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:07 AM Revision 6be1627d (git): * 2014-07-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46819 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [fix GH-668]
* test/rake/*.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46818 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
12:45 AM Bug #10036 (Closed): Time.parse raises NoMethodError: undefined method `<' for nil:NilClass when called with out of range arguments and a negative offset
- To replicate:
require 'time'
Time.parse("2014-13-13T18:00:00-0900") # => NoMethodError: undefined method `<' for nil:NilClass
This should instead return "ArgumentError: argument out of range", like it does with a positive offset:
... -
01:24 AM Bug #10009: IO operation is 10x slower in multi-thread environment
- Hi Eric !
Eric Wong wrote:
> Good to know it works for you. Keep in mind TIME_QUANTUM_USEC=1000 is
What problems do I have?
> ...
In the application do a stress test where 5 threads overload.
I tested 50 and the latency i...
07/14/2014
-
- Good to know it works for you. Keep in mind TIME_QUANTUM_USEC=1000 is
very low and may cause problems on some systems, too.
My gut feeling is 100ms (default) is too high, but 10ms is too low
(based on kosaki's comment). Maybe 20m... -
01:31 PM Bug #9759: [TracePoint API] return event missing when raising exception
- Yes, maybe he is aware of this because he only asked for backport to the 2.1 branch. Can you help us, ko1?
-
- In 2.1, a check for encoding of the paths parameter has been added to File.find. This works perfectly well for String parameters, but this results in a NoMethodError when a Pathname parameter is given. In my opinion a Pathname is a bette...
-
- Those functions are in msvcrt.lib.
Have you applied service packs? -
I have delete all source , and run configure.bat . have an other problem :
```
G:\dev-tools\ruby-2.1.2>win32\configure.bat --disable-install-doc
Creating Makefile.new
"type `nmake' to make ruby."
G:\dev-tools\ruby-2.1.2>nmak...-
- Andrii Tereshchenko wrote:
> kk kk wrote:
> ...
thank you . how to clean all config files ? -
- * win32/Makefile.sub (LIBS): oldnames.lib is not used already.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46817 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- add comment for constants of WIN32OLE.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46816 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Sean Linsley wrote:
> I don't follow. Can't this assignment behave the same way that method argument destructuring does?
I agree. Destructuring should work as method & block passing works (apart from block passing) - 09:48 AM Revision f747a231 (git): ChangeLog: document size changes [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46815 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It may need further consideration whether `instance_exec` should affect the wrapped proc.
-
- Reducing struct re_pattern_buffer from 464 to 448 bytes allows it to fit
into neatly into seven 64-byte cache lines on x86-64 systems.
ABI is changed in 2.2.0dev anyways, so we may do this.
Will commit in a few days.
C extension us... - 07:42 AM Revision ff9046ad (git): vm_core.h (struct rb_iseq_struct): reduce to 288 bytes on 64-bit
- * vm_core.h (struct rb_iseq_struct): reduce to 288 bytes on 64-bit
(found with pahole, from the dwarves package)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- (2014/07/14 16:12), Eric Wong wrote:
> OK, r46811 (I also made trivial commit r46813 to shrink catch entry)
Thanks.
> What should we do about rb_iseq_build_for_ruby2cext? I think it is
> broken, now (as is anything else which m... -
- ko1@atdot.net wrote:
> Thank you.
> I will modify style after your commit.
OK, r46811 (I also made trivial commit r46813 to shrink catch entry)
What should we do about rb_iseq_build_for_ruby2cext? I think it is
broken, now (as... -
- Thank you.
I will modify style after your commit.
-
- Changes from v2:
- iseq_catch_table_size removed, use if (...) for (;...;)
I used a short local variable in some places to keep the "if (...) for (...)"
sequences from wrapping on long lines.
-
- Eric Wong wrote:
> Eric Wong <normalperson@yhbt.net> wrote:
> ...
There are two reasons I'm opposed to:
(1) I think writing "if (...) for (...)" is more clear (easy to understand).
I don't care to adding one line to check exisiting... -
- Updated patch
Changes from v1:
- renamed iseq->_catch_table to iseq->catch_table
- iseq_catch_table_bytes: made a static inline function
- iseq_catch_table_size: new function replaces the
iseq_catch_table_each iterator macro
- 07:08 AM Revision 34f7e908 (git): iseq.h (struct iseq_catch_table_entry): shrink to 32 bytes on 64-bit
- * iseq.h (struct iseq_catch_table_entry): shrink to 32 bytes on 64-bit
This drops a few minor page faults on my system at startup.
Using 64-bit start, end, cont, and sp fields are unnecessary as
label_get_position and label_get_sp only ... - 07:06 AM Revision b811194e (git): * 2014-07-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46812 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:06 AM Revision e91ae784 (git): vm_core.h (struct rb_iseq_struct): reduce to 296 bytes on 64-bit
- Most iseq do not have a catch_table, so avoid needlessly adding
4-8 bytes to the struct for the common case.
Changes from v2:
- iseq_catch_table_size removed, use if (...) for (;...;)
Changes from v1:
- renamed iseq->_catch_table to is... -
- Nobuyoshi Nakada wrote:
> How did you get the source, and what is the exact revision?
I delete all source, and run `nmake array.obj -n` ,the result is same to you. fixed.
( I think the reason is I run configure.bat at win32 dir , ... -
- Setting SO_KEEPALIVE on the socket will help, but that still takes at
least 2 hours to detect on a stock Linux system. Do you want to set a
shorter keepalive, or is ~2 hours OK?
You can change the interval using OS-specific knobs ...
07/13/2014
-
- Marc-Andre Lafortune wrote:
> Since this request talks about Matrix, of which I'm the maintainer, and refers to a PR I reviewed, I'd very much like an english translation.
In short, he is interested in improving Matrix class. And to... -
- >こちらのPRなど最初のレビューを頂くまでに一ヶ月半を要しました. 問題だと感じました.
対面でもお伝えしましたが、 github は補助的なものなので、レビューを要するものは
オフィシャルの issue tracker である redmine に最初にパッチを投稿することをお勧めします。
また、Ruby の標準添付ライブラリのメンテナンスはライブラリごとにメンテナが
担当することになっています。
つまり、パッチをどうするかはメンテナ次第です。まず最初... -
- Since this request talks about Matrix, of which I'm the maintainer, and refers to a PR I reviewed, I'd very much like an english translation.
Thanks -
- こんにちは. 突然のご連絡失礼します.
もしこちらでお伺いするには不適切な内容であれば、お叱りと共にその旨をお伝え頂ければなと思います.
* 以下本文
Matrixクラスの貧弱さに憂いてGithub上からシコシコとPRを投げているのですが、
https://github.com/ruby/ruby/pull/594
こちらのPRなど最初のレビューを頂くまでに一ヶ月半を要しました. 問題だと感じました.
こちらは単純にGithubの扱... -
11:05 PM Feature #8895: Destructuring Assignment for Hash
- Koichi Sasada wrote:
> Problem is what happen when `h' is not a hash object (and doesn't have to_hash method).
> ...
I don't follow. Can't this assignment behave the same way that method argument destructuring does? This currently work... -
07:35 PM Bug #10031 (Closed): Net::IMAP idle can still block a thread forever.
- When calling Net::IMAP idle often errors will go unnoticed forever, simply leaving the Thread that called "idle" blocking forever.
For example try bringing your internet connection down whilst a thread is calling the idle method, the ... -
- r44516, r46159 and r46196 were backported into `ruby_2_1` branch at r46810.
-
- test_timeout.rb: shorten waiting times
* test/test_timeout.rb (test_timeout): inverted test condition.
[Bug #8523]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@46810 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Backported into `ruby_2_1` branch at r46809.
-
- * ext/digest/digest.c (rb_digest_instance_equal):
fix #== for non-string arguments. [ruby-core:62967] [Bug #9913]
* test/digest/test_digest.rb: add test for above.
* ext/digest/digest.c (rb_digest_instance_equ... -
- r46417 and r46418 were backported into `ruby_2_1` branch at r46808.
-
- * array.c (yield_indexed_values): extract from permute0(),
rpermute0(), and rcombinate0().
* array.c (rb_ary_combination): iterate on a shared copy, and use
array of indexes instead of array of chosen objects... -
- Backported into `ruby_2_1` branch at r46807.
-
- * array.c (rb_ary_permutation): `p` is the array of size `r`, as
commented at permute0(). since `n >= r` here, buffer overflow
never happened, just reduce unnecessary allocation though.
git-svn-id: svn+ssh://ci.rub... -
- Backported into `ruby_2_1` branch at r46806.
-
- * pack.c (encodes): fix buffer overrun by tail_lf. Thanks to
Mamoru Tasaka and Tomas Hoger. [ruby-core:63604] [Bug #10019]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@46806 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- Backported into `ruby_2_1` branch at r46805.
-
- * ext/thread/thread.c (undumpable): ConditionVariable and Queue
are not dumpable. [ruby-core:61677] [Bug #9674]
* marshal.c (w_object): internal objects are not dumpable.
[ruby-core:61677] [Bug #9674]
git-... -
10:38 AM Bug #10011: Passing a string to Pathname#relative_path_from results in NoMethodError
- https://github.com/ruby/ruby/pull/666
-
- spell out `encryption` by @vipulnsward [fix GH-664]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46804 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/sdbm/init.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46803 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Eric Wong <normalperson@yhbt.net> wrote:
> How about using a `iseq_catch_table_size` macro instead:
Or static inline function (also for `iseq_catch_table_bytes`). -
- ko1@atdot.net wrote:
> From what size on which architecture?
x86-64
> On the code:
>
> (1) `_catch_table` should be `catch_table`
OK, I will change it back. I renamed it so it'd be easier for the
compiler to det... -
- From what size on which architecture?
On the code:
1. `_catch_table` should be `catch_table`
2. I don't like `iseq_catch_table_each()` macro.
I like to write like
```C
if (iseq->_catch_table) for (i=0; i<iseq->_catch_table-... -
- This probably breaks ruby2cext; but I'm not sure if anybody uses that.
May we remove rb_iseq_build_for_ruby2cext?
I will probably have more patches along these lines to reduce iseq-related
allocations. This is probably the most o... -
- * ext/sdbm/init.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46802 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [fix GH-655]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46801 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:46 AM Revision c7fbc296 (git): vm_core.h (struct rb_call_info_struct): improve packing
- * vm_core.h (struct rb_call_info_struct): improve packing
On x86-64, it goes from 112 to 104 bytes. This results in
~20K of savings from just "./ruby -e exit"
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46800 b2dd03c8-39d4-4d... -
- [fix GH-659]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46799 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:01 AM Revision 499f6d62 (git): vm_core.h (struct rb_iseq_struct): stack_max is uint32_t
- * vm_core.h (struct rb_iseq_struct): stack_max is uint32_t
No program will ever need more than a few megabytes of stack,
so there's no sense in using a 64-bit counter for stack
accounting. Packing this with the 32-bit type enum re... -
- Applied in changeset r46796.
----------
configure.in: exit with failure
* configure.in (rb_cv_broken_backtrace): exit with failure
normally, no needs to abort. [ruby-core:63678] [Bug #10008] -
-
- It makes no sense.
- 01:56 AM Revision da16701b (git): * 2014-07-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46797 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * configure.in (rb_cv_broken_backtrace): exit with failure
normally, no needs to abort. [ruby-core:63678] [Bug #10008]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46796 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -