Project

General

Profile

Activity

From 10/11/2012 to 10/17/2012

10/17/2012

11:22 PM Bug #7166: Speed up Hash#dup by patching Hash#initialize_copy
Compatibility is important. Call rehash in initialize_copy and see how performance changes.
Matz.
matz (Yukihiro Matsumoto)
11:08 AM Bug #7166 (Assigned): Speed up Hash#dup by patching Hash#initialize_copy
This introduce imcompatiblity.
A testcase of Sets fails.
I've added a new test to test/ruby/test_hash.rb to clarify the problem
at r37238.
usa (Usaku NAKAMURA)
06:47 AM Bug #7166 (Closed): Speed up Hash#dup by patching Hash#initialize_copy
Thanks. I've committed this in r37232 tenderlovemaking (Aaron Patterson)
09:55 PM Feature #6643: io.seek(off, :end)
個人的には(1)間違った値と(2)間違っている理由と(3)期待する値が入ったエラーメッセージがあると直す時に嬉しいので、今ある案がまざった"whence must be an Integer or Symbol: %s given"みたいなのがいいんじゃないかと思います!
(自分が書くときは"whence must be an Integer or Symbol: <%s>"みたいに間違った値を「<>」とかの記号で囲んだりします。空文字列だったときにわかりづらいので。。。)
kou (Kouhei Sutou)
08:53 AM Feature #6643: io.seek(off, :end)
Kouhei Sutou wrote:
> "type mismatch: %s given"というエラーメッセージに、「本当はIntegerかSymbolで指定して欲しかったんだよ!」みたいな情報が入っていると、間違ったオブジェクトを指定してしまった時にどうすればうまく動くようにできるかがわかりやすくなってうれしいなぁと思いました!
"%s is not an Integer or Symbol"や、"whence must be an Integer or ...
Glass_saga (Masaki Matsushita)
09:20 PM Bug #7165 (Closed): mingw make -jN fails when linking rubyw.exe
This issue was solved with changeset r37246.
Hiroshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
extmk.rb: fix mingw make failure with make -jN
* common.mk (W...
Anonymous
04:38 PM Bug #7168: File.join trips over string encodings
Use UTF-8.
I don't think Darwin uses wide chars for file systems, though.
nobu (Nobuyoshi Nakada)
02:28 AM Bug #7168: File.join trips over string encodings
I don't see how that patch fixes the issue to achieve the behavior that I expected. It looks like it will just raise an explicit error instead of the ArgumentError.
For systems that have multi-byte, fixed-size encodings how is this su...
aparker42 (Andrew Parker)
04:31 PM Feature #7177 (Closed): Proposal of a new C API
Hi.
We uses rb_newobj() in CRuby when we allocates any object.
However, this function has no arguments, so we can not change a
internal allocate method depending klass and flags of any object.
So I propose to add following new C ...
authorNari (Narihiro Nakamura)
03:43 PM Feature #7145 (Feedback): Add string-based range support to IMAP library
tonyarkles (Tony Arkles) wrote:
> The imap protocol supports fetching ranges of messages using notation like "1:*" (to fetch all messages). I'd like to support things like: @im.fetch('1:*', 'FULL')@
> ...
You can specify "1:*" like im....
shugo (Shugo Maeda)
03:18 PM Bug #7153 (Closed): IMAP: emails with (BODY ("MIXED")) returned from fetch fail to parse
This issue was solved with changeset r37240.
Tony, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/net/imap.rb: fix Net::IMAP::ResponseParser to accept
mess...
shugo (Shugo Maeda)
03:18 PM Bug #7147 (Closed): IMAP: emails with message/rfc822 attachments fail to parse
This issue was solved with changeset r37240.
Tony, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/net/imap.rb: fix Net::IMAP::ResponseParser to accept
mess...
shugo (Shugo Maeda)
03:18 PM Bug #7146 (Closed): IMAP: messages with a mime-attachment of type "message/delivery-notification" fail
This issue was solved with changeset r37240.
Tony, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/net/imap.rb: fix Net::IMAP::ResponseParser to accept
mess...
shugo (Shugo Maeda)
01:36 PM Revision bff930cc (git): * ChangeLog: fix a typo of r37243.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37247 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nagachika (Tomoyuki Chikanaga)
12:20 PM Revision 14d59c12 (git): extmk.rb: fix mingw make failure with make -jN
* common.mk (WPROGRAM): need same dependencies as PROGRAM.
* cygwin/GNUmakefile.in (uncommon.mk): move include position
below WPROGRAM definition to be defined in uncommon.mk.
* ext/extmk.rb (all, static): fix make rubyw.exe failure ...
h.shirosaki (Hiroshi Shirosaki)
08:37 AM Bug #7175 (Third Party's Issue): unpack('M*') changed behavior between patchlevels
drbrain (Eric Hodel)
07:46 AM Bug #7175: unpack('M*') changed behavior between patchlevels
FWIW, bug ticket there: https://github.com/mikel/mail/issues/440 briantobin (Brian Tobin)
07:27 AM Bug #7175: unpack('M*') changed behavior between patchlevels
Second update
I discovered that the Mail gem (https://github.com/mikel/mail) is incorrectly stripping the newline after the "=", which makes it illegal. I'll file a bug there.
briantobin (Brian Tobin)
07:01 AM Bug #7175: unpack('M*') changed behavior between patchlevels
After reading the changelog I see that this changed b/c of bug #5635 (http://bugs.ruby-lang.org/issues/5635).
I still believe that this might be a regression. Looking at our data, the last lines of quoted-printable strings produced by...
briantobin (Brian Tobin)
06:25 AM Bug #7175 (Third Party's Issue): unpack('M*') changed behavior between patchlevels
I'm seeing an important difference in the output of string.unpack between two patchlevels of ruby 1.9.3. The output of patchlevel 194 is expected, and the output of 286 is unexpected.
--- Console 1 ---
>> RUBY_VERSION
=> "1.9.3"
> ...
briantobin (Brian Tobin)
07:26 AM Revision aef5f902 (git): * benchmark/bm_vm2_method_missing.rb: add a benchmark to measure
performance of invoking `method_missing'.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37245 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
07:24 AM Revision 000ff5b3 (git): * vm_insnhelper.c (vm_getivar): fix to use `aux.index' instead of
`aux.opt_pc'.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37244 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
07:12 AM Revision 9a82db49 (git): * vm_insnhelper.c (vm_call_method_missing): make a refactoring
about method_missing process. Use `vm_call_method()' to invoke
`method_missing' method instead of `rb_funcall2()'.
In `vm_call_method()', set fastpath to `vm_call_method_missing()'
if it can be cached.
* vm_core.h (rb_call_info_t):...
ko1 (Koichi Sasada)
06:33 AM Revision 7254573c (git): configure.in: multiple opt-dir
* configure.in (opt-dir): allow multiple directories separated by
$PATH_SEPARATOR as well as dir_config in mkmf.rb. [ruby-core:47868]
[Bug #7120]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37242 b2dd03c8-39d4-4d8f-98ff-823fe...
nobu (Nobuyoshi Nakada)
06:30 AM Revision 0f1e7bce (git): * ChangeLog: add credit.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37241 b2dd03c8-39d4-4d8f-98ff-823fe69b080e shugo (Shugo Maeda)
06:18 AM Revision bd6bb6c0 (git): * lib/net/imap.rb: fix Net::IMAP::ResponseParser to accept
message/delivery-status ([ruby-core:47920] [Bug #7146]),
message/rfc822 attachments ([ruby-core:47921] [Bug #7147]), and
(BODY ("MIXED")) ([ruby-core:47951] [Bug #7153]).
* test/net/imap/test_imap_response_parser.rb: related test.
...
shugo (Shugo Maeda)
03:55 AM Revision c4e63346 (git): * ChangeLog: use tab for indentation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37239 b2dd03c8-39d4-4d8f-98ff-823fe69b080e shugo (Shugo Maeda)
02:06 AM Revision 38c0b5f0 (git): * test/ruby/test_hash.rb (TestHash#test_dup_equality): added a new test
to show the problem of r37232.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37238 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
01:50 AM Revision 8f58f606 (git): * vm_insnhelper.c (vm_search_method): fix a build error that occurs
when OPT_INLINE_METHOD_CACHE is 0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shugo (Shugo Maeda)

10/16/2012

11:47 PM Revision 5e2625ee (git): * benchmark/bm_vm2_dstr.rb: add a benchmark to measure
performance of dynamic generated string ("foo#{bar}baz").
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37236 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
11:46 PM Bug #7173: with-opt-dir flag documentation
I've made a patch in the following gist: https://gist.github.com/3899727
Assigning this to nobu, since it's not actual documentation.
zzak (zzak _)
11:36 PM Bug #7173 (Closed): with-opt-dir flag documentation
From #7120:
Current documentation:
--with-opt-dir=DIR add optional headers and libraries DIR
nobu's reply:
--with-opt-dir allows multiple paths separated by File::PATH_SEPARATOR
zzak (zzak _)
11:38 PM Revision 49371b54 (git): * compile.c (compile_dstr_fragments): use `putobject' instead of
`putstring' for all of strings used by NODE_DSTR because
ruby users can not grab this string.
For example, the string object of "baz" in "foo#{bar}baz"
is located by `putobject' (users can not touch "baz" object
directly). This c...
ko1 (Koichi Sasada)
11:03 PM Revision 8addee96 (git): * thread.c (rb_threadptr_interrupt_mask): fix to check interrupt
after interrupt_mask changed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37234 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
10:29 PM Bug #7172: [[Ruby 1.9:]] fix rbconfig for --enable-load-relative (v2)
Thanks mpapis for moving the ball forward on this. I rely on
--enable-load-relative for Tokaido, and getting/keeping it working reliably
will make me very happy.

Yehuda Katz
(ph) 718.877.1325


On Tue, Oct 16, 2012 at 9...
wycats (Yehuda Katz)
10:14 PM Bug #7172 (Closed): [[Ruby 1.9:]] fix rbconfig for --enable-load-relative (v2)
continuation of http://bugs.ruby-lang.org/issues/6903 and http://bugs.ruby-lang.org/issues/7115
Checked with http://bugs.ruby-lang.org/projects/ruby-193/repository/entry/tool/mkconfig.rb and p286,
there is still missing fix for rbco...
mpapis (Michal Papis)
10:29 PM Bug #7158: require is slow in its bookkeeping; can make Rails startup 2.2x faster
Yehuda Katz
(ph) 718.877.1325


On Tue, Oct 16, 2012 at 12:21 AM, gregprice (Greg Price) <price@mit.edu>wrote:

>
> Issue #7158 has been updated by gregprice (Greg Price).
>
>
> trans (Thomas Sawyer) wrote:
> > I b...
wycats (Yehuda Katz)
01:21 PM Bug #7158: require is slow in its bookkeeping; can make Rails startup 2.2x faster
trans (Thomas Sawyer) wrote:
> I believe a great deal of additional speed could be gained by optimizing
> ...
I'd like to keep this thread focused on speeding up existing code which uses #require. If you're interested in making changes...
gregprice (Greg Price)
09:49 PM Revision 199fc6a5 (git): * vm_insnhelper.c (vm_call_method): fix to return value immediately.
Remove CHECK_INTS() after that method dispatch.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37233 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
09:48 PM Feature #6643: io.seek(off, :end)
"type mismatch: %s given"というエラーメッセージに、「本当はIntegerかSymbolで指定して欲しかったんだよ!」みたいな情報が入っていると、間違ったオブジェクトを指定してしまった時にどうすればうまく動くようにできるかがわかりやすくなってうれしいなぁと思いました! kou (Kouhei Sutou)
09:36 PM Feature #6643: io.seek(off, :end)
IO::SEEK_XXXの値は従来のままとして、whence引数にIntegerもSymbolも受け付けるIO#seekを作ってみました。
Symbolとしては、:set, :cur, :current, :endを大文字小文字を区別せず受け付けます。
これで互換性を崩さずにSymbolも渡せるようになるので良いんじゃないかと思うのですが、いかがでしょうか。
Glass_saga (Masaki Matsushita)
08:47 PM Feature #6643: io.seek(off, :end)
こんにちは。
(Mon, 25 Jun 2012 23:31:12 +0900), SASADA Koichi wrote:
> これ,例えば IO::SEEK_END も値が :end になるんでしょうか(なっちゃいけない理由はあるんかな).
IO::SEEK_XXXの値もSymbolにした上でSymbolを受け付けるIO#seekを作ってみたところ、StringIOで引っかかりました。
ext/stringio/stringio.cのstrio_se...
Glass_saga (Masaki Matsushita)
09:33 PM Revision b3803cc4 (git): * hash.c (initialize_copy): copy the underlying st_table on dup,
rather than copying the hash key by key. [ruby-core:48009]
* test/ruby/test_hash.rb: relevant tests for initialize_copy
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37232 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlovemaking (Aaron Patterson)
09:20 PM Revision ddb6408f (git): * vm_insnhelper.c (vm_call_iseq_setup_2): separate tailcall and normal
method frame setup functions.
Add checking interrupts at the tailcall setup function.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37231 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
08:40 PM Bug #7171 (Closed): test-all failure on OS X (RubyCI)
rubyci(http://rubyci.org/)で、LionおよびMountain Lionの一部の構成で以下のようなエラーがずっと出ています。
このエラーが出るものと出ないものがあるのが不気味なのですが、原因はなんでしょう?
test_udp_server(TestSocket):
RuntimeError: no response from #<Addrinfo: fd2e:1e2f:2d52:da8d:e6ce:8fff:fe1f:1c3c>
...
usa (Usaku NAKAMURA)
08:37 PM Revision db3898fe (git): * benchmark/bm_vm1_yield.rb: add a benchmark to measure `yield'
(invoke empty block) performance.
* benchmark/bm_vm2_method_with_block.rb: add a benchmark to measure
method invocation with empty block.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37230 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
08:30 PM Revision 9182dab4 (git): * vm_insnhelper.c (vm_invoke_block): vm_caller_setup_args() can skip
when splat flag is not set.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37229 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
07:54 PM Bug #7137: Date.parse overly lenient when attempting to parse Monday?
btw, bigdecimal doesn't validate the given arg.
but, nobody is aware of it.
BigDecimal('five million')
#=> #<BigDecimal:8edaba4,'0.0',9(9)>
tadf (tadayoshi funaba)
07:48 PM Bug #7137: Date.parse overly lenient when attempting to parse Monday?
first of all, i'm not a fan of the current parse method.
you already know the reason.
but, this is not a bug.
if you don't admit this, any discussion is meaningless.
lecture? no thanks.
i already wrote a strict parser at 1999.
tadf (tadayoshi funaba)
07:11 PM Bug #7166: Speed up Hash#dup by patching Hash#initialize_copy
Go ahead. If we see the problem, it can be easily reverted.
Matz.
matz (Yukihiro Matsumoto)
07:31 AM Bug #7166: Speed up Hash#dup by patching Hash#initialize_copy
The gain is not so big at me, but it's clearly there (I get 1.4 to 1.6 speed-up).
Note about half of the time is spent in GC.
Eregon (Benoit Daloze)
02:37 AM Bug #7166 (Closed): Speed up Hash#dup by patching Hash#initialize_copy
Hash#dup can be sped up. Hash#initialize_copy will iterate over each pair in the hash, inserting in to the new hash. I think we can speed up hash duping by using st_copy and copying the underlying hash table.
Here is the benchmark I...
tenderlovemaking (Aaron Patterson)
06:39 PM Bug #7154: For whatever reason \s doesn't match \u00a0.
duerst (Martin Dürst) wrote:
> My understanding is that this is a feature. See previous post for explanation. I hope somebody can provide the feedback to http://stackoverflow.com/questions/2588942/convert-non-breaking-spaces-to-spaces...
t0d0r (Todor Dragnev)
05:07 PM Revision db1e99cd (git): * vm_insnhelper.c (vm_getivar, vm_setivar): support index inline cache
with rb_call_info_t to speedup `attr' getter and setter.
Cached index is stored in rb_call_info_t::aux::index.
`index' == 0 means not cached. `index' > 0 means cached and cached
index is `index - 1'.
* insns.def ((get|set)instancev...
ko1 (Koichi Sasada)
03:32 PM Revision aedc460f (git): * 2012-10-17
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37227 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:32 PM Revision 0eb6ef5b (git): * method.h(rb_method_definition_struct): remove a comma after the last element
of enum. fix for r37198.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37226 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nagachika (Tomoyuki Chikanaga)
01:26 PM Revision f8c2a968 (git): * benchmark/driver.rb (show_results): Show speedup ratio
with first executables score at last of results
if two or more executrables are given.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37225 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
01:07 PM Revision 64b17511 (git): * benchmark/driver.rb: some refactoring.
(1) Remove `average differential'.
In this benchmark driver, We should not care about `average'.
We use fastest score because this score should not include
any disturbances (affections of background process, etc).
If you care abo...
ko1 (Koichi Sasada)
12:44 PM Bug #7085: Subversion → GitHub gateway stops.
I think it's Evan's move now. shyouhei (Shyouhei Urabe)
06:13 AM Bug #7085: Subversion → GitHub gateway stops.
Thanks shyouhei for syncing the latest security fixes to the GH mirror.
What's the timeline for bringing the mirror back to life?
While I'm curious as to the new implementation (Evan's colo, single svn/git server, ??) I really just...
jonforums (Jon Forums)
12:19 PM Bug #7170 (Closed): tOP_ASGN and rescue_modifier precedence, with a few confusing examples
nobu (Nobuyoshi Nakada)
11:47 AM Bug #7170: tOP_ASGN and rescue_modifier precedence, with a few confusing examples
Hmm. I think I read parse.y wrong. modifier_rescue has higher precedence than tOP_ASGN.
Sorry about the noise.
hasari (Hiro Asari)
11:38 AM Bug #7170 (Closed): tOP_ASGN and rescue_modifier precedence, with a few confusing examples
parse.y shows that tOP_ASGN has precedence over modifier_rescue.
So I expect that
a = 1
a += [] rescue 5
should be parsed as "(a += []) rescue 5". Furthermore, it should evaluate to 5, and leave a untouched.
But in r...
hasari (Hiro Asari)
10:54 AM Bug #7168 (Closed): File.join trips over string encodings
This issue was solved with changeset r37207.
Andrew, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
file.c: ASCII-compatible
* file.c (rb_file_join): path names m...
nobu (Nobuyoshi Nakada)
04:31 AM Bug #7168 (Closed): File.join trips over string encodings
It seems like `File.join` is unable to handle string encodings that contain null bytes even though the string is properly encoded. This causes it to be unable to process inputs when the filenames on the system are encoded in this manner.... aparker42 (Andrew Parker)
09:49 AM Feature #7148: Improved Tempfile w/o DelegateClass
Hello,
Yukihiro Matsumoto wrote:
> I'd expect it to copy the underlying temporary file.
Is the behavior of #dup you expect like the following?
~~~ruby
def dup
dupe = self.class.new(@basename)
IO.copy_stream(self, dupe, 0...
Glass_saga (Masaki Matsushita)
08:55 AM Revision 14ddf6c9 (git): * test/bigdecimal/test_bigdecimal.rb (TestBigDecimal#test_gc): Fix
a bogus test that would have never passed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8@37223 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Akinori MUSHA
08:55 AM Revision 6585a304 (git): * 2012-10-16
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8@37222 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
08:55 AM Revision 2fa46520 (git): * test/-ext-/test_threadswitch_hook.rb
(Test_ThreadSwitch#test_threadswitch_init): This test does not
pass because the hook method actually calls rb_add_event_hook()
which does not emit a warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8@37221 b2dd03...
Akinori MUSHA
08:55 AM Revision 2c791e96 (git): Merge r37148 from ruby_1_8_7.
* error.c (name_err_to_s): we need not infect msg.
* test/ruby/test_exception.rb (TestException#test_exception_to_s_should_not_propagate_untrustedness): test for it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8@37220 b...
Akinori MUSHA
08:55 AM Revision 4928543d (git): Merge r35953 from ruby_1_8_7.
* ext/bigdecimal/bigdecimal.c (VpMemAlloc): Fixes a bug reported by Drew Yao <ayao at apple.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8@37219 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Akinori MUSHA
08:54 AM Revision 7eb8872b (git): Merge r33999 from ruby_1_8_7.
* ext/openssl/ossl_x509store.c (ossl_x509store_initialize): initialize
store->ex_data.sk. [ruby-core:28907] [ruby-core:23971]
[ruby-core:18121]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8@37218 b2dd03c8-39d4-4d8f-...
Akinori MUSHA
08:54 AM Revision 71ac625b (git): Merge r32233 and r32320 from ruby_1_8_7.
* ext/tk/extconf.rb: copy from trunk, as requested by Hidetoshi NAGAI.
* ext/tk/extconf.rb (intptr_t, uintptr_t): support for the latest ActiveTcl with mingw.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8@37217 b2dd03c8...
Akinori MUSHA
05:56 AM Revision 9af81022 (git): file.c: ASCII-compatible
* file.c (rb_file_join): need to check again after any conversion run.
[ruby-core:48012] [Bug #7168]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37216 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:14 AM Bug #7156: Invalid byte sequence in US-ASCII when using URI from std lib
What part of the URL contains the UTF-8 characters?
If it's the domain, you need to decode the UTF-8 into punycode before passing it to Ruby.
It it's in the path, Ruby ought to handle it for IRI compliance, but probably doesn't rig...
meta (mathew murphy)
04:02 AM Revision 66141d47 (git): * test/ruby/envutil.rb (Test::Unit::Assertions#assert_file): rename from file_assertion.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37215 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
04:02 AM Revision 41e5fdb2 (git): fix typos
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37214 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
03:58 AM Bug #7167 (Closed): Segmentation Fault
I got a segfault trying to install the prawn gem via rubygems on a archlinux box. Please tell me how i can help.
% sudo ruby -v /usr/bin/gem install prawn
ruby 1.9.3p286 (2012-10-12 revision 37165) [x86_64-linux]
/usr/lib/ruby/1.9.1...
ushi (ushi kalcher)
02:30 AM Revision 37b8f7b8 (git): file.c: hide result
* file.c (rb_file_join): hide the result under construction until
return.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37213 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:27 AM Revision a583f420 (git): file.c: ASCII-compatible
* file.c (rb_file_join): check nul-byte only for strings, since
FilePathStringValue() does it. [ruby-core:48012] [Bug #7168]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37212 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:19 AM Revision 772640a2 (git): merge revision(s) 37153: [Backport #6207]
* lib/mkmf.rb (dir_config, init_mkmf): use configured libdir value as
default library path. [ruby-core:43726] [Bug #6207]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@37211 b2dd03c8-39d4-4d8f-98ff-823fe69b...
U.Nakamura
02:13 AM Revision 62f6e924 (git): merge revision(s) 36625: [Backport #6831]
test_etc.rb: remove implicit assumption
* test/etc/test_etc.rb (TestEtc#test_getpwuid): remove implicit
assumption, that getpwuid() would return the first entry in the
order of getpw(), for shared UID. apparently it is not ...
U.Nakamura
02:11 AM Revision e9ff4a22 (git): merge revision(s) 36800: [Backport #6377]
* file.c (rb_find_file_ext_safe, rb_find_file_safe): default to
US-ASCII for encdb and transdb.
* load.c (search_required): keep encoding of feature name. set
loading path to filesystem encoding. [Bug #6377][ruby-core:44750]
* ru...
U.Nakamura
02:10 AM Feature #6668: Multiple assignment should not return an Array object
Method inlining could help if we do it before handing off to the JVM, since we'd see that masgn result is not used...but that's still pretty far away from reality. The JVM might be able to eliminate the array allocation, but it's a very ... headius (Charles Nutter)
01:55 AM Revision ae5930a8 (git): merge revision(s) 34977: [Backport #5661]
* random.c (random_s_rand): ensure default PRNG is re-initialized
after fork. patched by Eric Wong. [ruby-core:41209][Bug #5661]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@37208 b2dd03c8-39d4-4d8f-98ff-...
U.Nakamura
01:54 AM Revision 7b4f0c0d (git): file.c: ASCII-compatible
* file.c (rb_file_join): path names must be ASCII-compatible.
[ruby-core:48012] [Bug #7168]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37207 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:53 AM Revision ad54de2a (git): file.c: check_path_encoding
* file.c (check_path_encoding): new function to ensure path name
encoding to be ASCII-compatible.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:21 AM Revision 259d9dbc (git): merge revision(s) 37177: [Backport #7157]
* ruby.c (rb_f_sub, rb_f_gsub): pass the given block.
[ruby-core:47967] [Bug #7157]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@37205 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
12:49 AM Revision 535649ee (git): merge revision(s) 37169: [Backport #7169]
use tty(1) to check if /dev/tty is usable or not
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@37204 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
12:48 AM Revision 998a3981 (git): merge revision(s) 37201,37202:
* test/ruby/test_regexp.rb
(TextRegexp#test_raw_hyphen_and_tk_char_type_after_range): ignoring
warnings are already set in setup method.
* test/ruby/test_regexp.rb
(TextRegexp#test_raw_hyphen_and_tk...
U.Nakamura
12:40 AM Revision 5ed8ca14 (git): * test/ruby/test_regexp.rb
(TextRegexp#test_raw_hyphen_and_tk_char_type_after_range): use
Regexp.new instead of literal to ignore a parser warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37202 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
12:31 AM Revision 4ae5081b (git): * test/ruby/test_regexp.rb
(TextRegexp#test_raw_hyphen_and_tk_char_type_after_range): ignoring
warnings are already set in setup method.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37201 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura

10/15/2012

11:30 PM Bug #7165 (Closed): mingw make -jN fails when linking rubyw.exe
=begin
When I run make -jN with MSYS mingw build, build failed as the following.


sh-3.1$ rm -rf ruby.exe rubyw.exe *.dll *.res.o ext/zlib ext/win32ole
sh-3.1$ gnumake -j6


linking shared-object zlib.so
gnumake[2]: Lea...
h.shirosaki (Hiroshi Shirosaki)
10:53 PM Bug #7137: Date.parse overly lenient when attempting to parse Monday?
On 15 October 2012 22:48, garysweaver (Gary Weaver)
<garysweaver@gmail.com> wrote:
>
> Issue #7137 has been updated by garysweaver (Gary Weaver).
>
>
> I respectfully ask to reopen this ticket. The problem is that people expect th...
phluid61 (Matthew Kerwin)
09:48 PM Bug #7137: Date.parse overly lenient when attempting to parse Monday?
I respectfully ask to reopen this ticket. The problem is that people expect that Date.parse('Monitoring') to fail or return nil because it isn't a date nor does it contain anything that *should* be interpreted as a date. The problem was ... garysweaver (Gary Weaver)
10:01 PM Bug #1926: Different eval/binding behaviour in 1.9
Given this change, what is the proper method of setting a local variable in a specific binding? shreeve (Steve Shreeve)
09:45 PM Revision 7c1778d6 (git): * vm_insnhelper.c (VM_CALLEE_SETUP_ARG): fix wrong condition.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37200 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ko1 (Koichi Sasada)
09:35 PM Revision 3083ad7b (git): * vm_insnhelper.c (vm_call_method): disable CI_SET_FASTPATH() if
this method call needs splat argument because cahced functions
(vm_call_attrset, vm_call_ivar, vm_call_cfunc_fast_(unary|binary))
do not check an arity.
* bootstraptest/test_method.rb: add a test to check an above issue.
git-svn-i...
ko1 (Koichi Sasada)
09:24 PM Revision 90a6dce0 (git): * method.h: introduce new method type VM_METHOD_TYPE_CFUNC_FAST.
This method is similar to VM_METHOD_TYPE_CFUNC methods, but
called cfunc without building new frame (does not push new control
frame). If error is occured in cfunc, the backtrace only shows
caller frame and upper.
This kind of me...
ko1 (Koichi Sasada)
09:01 PM Bug #6941: ID_H_TARGET no longer created after running make
nobu (Nobuyoshi Nakada) wrote:
> Now id.h doesn't depend on parse.y since r36864.
Confirmed it's working on my end, too. Thank you!
MartinBosslet (Martin Bosslet)
06:23 PM Feature #6647: Exceptions raised in threads should be logged
On 15/10/12 03:24, kosaki (Motohiro KOSAKI) wrote:
>
> Issue #6647 has been updated by kosaki (Motohiro KOSAKI).
>
>
> I think "exception raised" callback is better way because an ideal output (both format and output device) d...
regularfry (Alex Young)
11:23 AM Feature #6647: Exceptions raised in threads should be logged
I think "exception raised" callback is better way because an ideal output (both format and output device) depend on an application. It should be passed a raised exception. kosaki (Motohiro KOSAKI)
05:03 AM Feature #6647: Exceptions raised in threads should be logged
Ping! This came up in JEG's talk at Aloha RubyConf as a recommendation (specifically, set abort_on_exception globally to ensure failed threads don't quietly disappear). Ruby should not allow threads to quietly fail. headius (Charles Nutter)
05:40 PM Revision 747487cd (git): * vm_insnhelper.h (CI_SET_FASTPATH): add new parameter `enabled'.
If `enable' is 0 then CI_SET_FASTPATH() doesn't work.
And add new configuration option OPT_CALL_FASTPATH. If this macro
was defined by 0, then CI_SET_FASTPATH() doesn't work any more.
* vm_insnhelper.c (vm_call_method): Pass `0' for ...
ko1 (Koichi Sasada)
05:22 PM Revision a91e91c5 (git): * vm_core.h (VM_CALL_*): rename VM_CALL_*_BIT
to VM_CALL_* (remove `_BIT' suffix).
Add comments on each macros.
Remove unused macro VM_CALL_TAILRECURSION_BIT.
* compile.c, iseq.c, insns.def, vm_insnhelper.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37196 b2dd0...
ko1 (Koichi Sasada)
03:45 PM Revision b188d42b (git): * 2012-10-16
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37195 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:45 PM Revision 84cfea70 (git): ChangeLog: fix a typo of r37185.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37194 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nagachika (Tomoyuki Chikanaga)
03:29 PM Feature #6668 (Rejected): Multiple assignment should not return an Array object
Changing return value from massign would be agaist 2.0 compatibility policy. Maybe in 3.0.
Method inlining in JRuby would help compatibility here as well, wouldn't it?
Matz.
matz (Yukihiro Matsumoto)
04:55 AM Feature #6668: Multiple assignment should not return an Array object
I thought I replied to ko1, but must not have.
I believe MRI is using the same trick JRuby is...specifically, when the masgn's result is not used, it is not created. However, that does not help cases where masgn happens to be the last...
headius (Charles Nutter)
03:01 PM Bug #7163 (Closed): Chomp problem in pkg_config of mkmf.rb (ruby 1.9.3 P286)
when compiled the ext packages under mingw64 + MSYS, mkmf reports error like this:
"gcc -o conftest -Ic:/ruby64/include/ruby-1.9.1/x64-mingw32 -Ic:/ruby64/include/ruby-1.9.1/ruby/backward -Ic:/ruby64/include/ruby-1.9.1 -I. -I./.. -D_...
raylinn@gmail.com (ray linn)
01:47 PM Feature #7149: Constant magic for everyone.
Not out of the box, only if the user turns it on:
class Fixnum
constant_magic # or constant_magic( true ); or const_magic(); etc.
end
But, oh, do I feel your point. Saying that naming 42 is stupid is not enough.
Giving o...
Anonymous
08:53 AM Feature #7149: Constant magic for everyone.
Do you expect the following?
class Foo
Bar = 42
end
p (6*7).name #=> Foo::Bar
nobu (Nobuyoshi Nakada)
04:42 AM Feature #7149: Constant magic for everyone.
nobu (Nobuyoshi Nakada) wrote:
> What do you expect if the object is assigned to two or more constants?
Same behavior as with Class and Struct objects. I do not understand the implementation details, but it seems that for these objects ...
Anonymous
01:14 PM Revision 32569104 (git): envutil.rb: file_assertion
* test/ruby/envutil.rb (Test::Unit::Assertions#file_assertion):
rewrite file assertions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37193 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:53 PM Revision a17cb167 (git): * benchmark/: add missing spaces around assignment operators (= and +=) for
consistency.
Approved by ko1.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37192 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sutou Kouhei
12:29 PM Revision 2780e752 (git): * vm_eval.c: fix a typo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37191 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Sutou Kouhei
11:18 AM Bug #6994 (Rejected): yield plus splat unwraps too much
kosaki (Motohiro KOSAKI)
05:02 AM Bug #6994: yield plus splat unwraps too much
This can be closed. headius (Charles Nutter)
09:23 AM Bug #7154: For whatever reason \s doesn't match \u00a0.
Just forgot to mention that the pickaxe book, for "\s", says "For
Unicode, add Line_Separator codepoints.".

This is wrong because even LINE SEPARATOR itself, \u2028, doesn't match
\s. It would also be wrong in that the result...
duerst (Martin Dürst)
08:56 AM Bug #7154 (Closed): For whatever reason \s doesn't match \u00a0.
My understanding is that this is a feature. See previous post for explanation. I hope somebody can provide the feedback to http://stackoverflow.com/questions/2588942/convert-non-breaking-spaces-to-spaces-in-ruby. duerst (Martin Dürst)
08:53 AM Bug #7154: For whatever reason \s doesn't match \u00a0.
My understanding is that in Ruby, all the pre-Unicode escapes, and in
particular "\s", still refer only to characters in the ASCII range.

My understanding is that this was done in this way for backwards
compatibility, and on ...
duerst (Martin Dürst)
05:02 AM Feature #905: Add String.new(fixnum) to preallocate large buffer
I do not believe for a moment that realloc or mremap can in all cases perform the operation in O(1) time, and the docs seem to agree with me...first based on the doc above for realloc, and then for this doc on mremap:
MREMAP_MA...
headius (Charles Nutter)
04:50 AM Feature #6648: Provide a standard API for retrieving all command-line flags passed to Ruby
Ping...we'd still like to have this to be able to build a unifying benchmark tool, which needs to be able to report the actual command-line arguments passed to the runtime. Current tricks are too ugly (parsing `ps` output, for example), ... headius (Charles Nutter)
04:49 AM Bug #7037: float formatting inconsistently rounds half to even
If there's nothing further to do here and we all agree that the details of rounding logic are implementation-dependent, this can be closed. headius (Charles Nutter)
04:35 AM Bug #7161 (Closed): Perf fix: use symbols instead of strings for const/ivar access methods
From pull request: https://github.com/ruby/ruby/pull/195
Fixes a number of places where literal, non-dynamic strings are used as the first argument for constant and instance variable get, set, and defined? methods. This reduces object...
headius (Charles Nutter)
03:59 AM Bug #7160 (Closed): "gem rdoc" command outputs a wealth of warnings
This is fixed but unreleased drbrain (Eric Hodel)
02:47 AM Bug #7160 (Closed): "gem rdoc" command outputs a wealth of warnings
=begin
The (({gem rdoc})) command outputs an insane number of warnings:
% sudo gem rdoc --overwrite sinatra
NOTE: Gem::SourceIndex.from_installed_gems is deprecated with no replacement. It will be removed on or after 2011-10-01.
...
Quintus (Marvin Gülker)
02:04 AM Revision f1d3fcec (git): fix typos
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37190 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
01:44 AM Revision 4c9ea3c3 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37189 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
12:57 AM Revision c0481015 (git): vm_insnhelper.c: suppress warnings
* vm_insnhelper.c (vm_callee_setup_arg_complex): suppress
shorten-64-to-32 warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37188 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:44 AM Revision f9e50b05 (git): * vm_insnhelper.c (VM_CALLEE_SETUP_ARG): skip CI_SET_FASTPATH() if
it was called from vm_yield_setup_args().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37187 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)

10/14/2012

10:52 PM Bug #7158: require is slow in its bookkeeping; can make Rails startup 2.2x faster
I believe a great deal of additional speed could be gained by optimizing #require_relative (and making use of it, of course). From what I understand, #require_relative ends up calling ordinary #require code, which is inefficient since #r... trans (Thomas Sawyer)
02:41 PM Bug #7158: require is slow in its bookkeeping; can make Rails startup 2.2x faster
=begin
I've also made these patches available at https://github.com/gnprice/ruby , in the "fast-require" branch against a recent trunk and in "fast-require-1.9.3p194" against the latest release.
If you use ((<rbenv|URL:https://github...
gregprice (Greg Price)
01:56 PM Bug #7158 (Closed): require is slow in its bookkeeping; can make Rails startup 2.2x faster
=begin
Starting a large application in Ruby is slow. Most of the startup
time is not spent in the actual work of loading files and running Ruby
code, but in bookkeeping in the 'require' implementation. I've
attached a patch series ...
gregprice (Greg Price)
08:59 PM Revision c4457e03 (git): * vm_insnhelper.h CI_SET_FASTPATH: introduce new macro
`CI_SET_FASTPATH(ci, func)'. This macro set `ci->call' as `func'.
`func' (ci->call) is called at the last of `send'
(and `invokesuper') instruction.
`CI_SET_FASTPATH' does not set `ci->call' when the method
(stored in `ci->me') i...
ko1 (Koichi Sasada)
07:58 PM Revision 8f08e61b (git): * vm_insnhelper.c: refactoring.
- move all `call' related functions to the last of file.
- make functions for respective method types in vm_call_method().
(all functions have same function parameters)
* vm_core.h: add `opt_pc' filed in `rb_call_info_t'
as tempora...
ko1 (Koichi Sasada)
07:40 PM Bug #7137: Date.parse overly lenient when attempting to parse Monday?
i recommend you to use full year.
so, parse method can detect properly except minority middle endian.
sorry if you are minority.
i also recommend you to use internatinal standard format such as iso 8601.
moreover, parse method is jus...
tadf (tadayoshi funaba)
06:15 PM Bug #7137: Date.parse overly lenient when attempting to parse Monday?
@tadf thanks for the explanation. Maybe proper parsing is not really a responsibility of `Date` class. The following also may look surprising:
Date.parse('10/11/12')
=> #<Date: 2010-11-12 ((2455513j,0s,0n),+0s,2299161j)>
@sh...
alexeymuranov (Alexey Muranov)
06:53 PM Revision fd3b0dec (git): * benchmark/bm_vm1_attr_ivar(_set).rb: added (for method dispatch speed).
* benchmark/bm_vm1_float_simple.rb: added (for flonum/float).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37184 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
05:54 PM Revision 7f052a72 (git): * vm_eval.c (vm_call0_body): add new function.
`vm_call0()' makes call_info struct and calls `vm_call0_body()'
with this struct. In near future, `vm_call0()' will be removed
because all of `vm_call0()' users setup call_info struct by itself.
git-svn-id: svn+ssh://ci.ruby-lang....
ko1 (Koichi Sasada)
05:20 PM Revision ca968ee4 (git): remove garbage line
* compile.c (new_insn_send): remove garbage line.
* tool/instruction.rb (sp_increase_c_expr): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37182 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
05:11 PM Feature #7149: Constant magic for everyone.
May be any hook can be implemented to make it possible in such a way?
on_const_set{|const, obj|
def obj.name
const
end
}
prijutme4ty (Ilya Vorontsov)
04:59 PM Revision c84bd9d7 (git): * 2012-10-15
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37181 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:59 PM Revision cbd597e9 (git): * insns.def (send, invokesuper, invokeblock, opt_*), vm_core.h:
use only a `ci' (rb_call_info_t) parameter instead of using
parameters such as `op_id', 'op_argc', `blockiseq' and flag.
These information are stored in rb_call_info_t at the compile
time.
This technique simplifies parameter pass...
ko1 (Koichi Sasada)
11:46 AM Bug #7105: Socket documentation fix
Hello,
I've discussed this with another mri committer, and we've come to the conclusion that the example should use AF_INET, as socket(2) suggests:
"The manifest constants used under 4.x BSD for protocol families are PF_UNIX, PF_I...
zzak (zzak _)
09:34 AM Bug #7032: TestSetTraceFuncの実行に失敗する
=begin
SEGVの問題について調べてみました。
手元の環境では以下のコードで100%再現します。
# Thread(A)
th = Thread.new { loop { 0 } }

# Thread(B)
loop do
# test_remove_in_trace
func = lambda do |e, f, l, i, b, k|
set_trace_func(nil)
eval("...
ktsj (Kazuki Tsujimoto)
08:52 AM Bug #7156 (Rejected): Invalid byte sequence in US-ASCII when using URI from std lib
Invalid byte sequence in US-ASCII on ruby 1.9.3
I receive that error when trying to open url with bulgarian text (utf-8: "История"). It seems that the problem is in uri/common.rb from ruby standard library...
adding str.force_encod...
t0d0r (Todor Dragnev)
08:48 AM Bug #7155: Invalid byte sequence in US-ASCII when using open-air
Sorry, syntax error in title "open-air" =>is URI lib from core library ./src/ruby-1.9.3-p286/lib/uri/common.rb t0d0r (Todor Dragnev)
08:45 AM Bug #7155 (Rejected): Invalid byte sequence in US-ASCII when using open-air
Invalid byte sequence in US-ASCII on ruby 1.9.3
I receive that error when trying to open url with bulgarian text (utf-8: "История"). It seems that the problem is in uri/common.rb from ruby standard library...
adding str.force_encod...
t0d0r (Todor Dragnev)
08:37 AM Bug #7154 (Closed): For whatever reason \s doesn't match \u00a0.
The problem is already explained here:
http://stackoverflow.com/questions/2588942/convert-non-breaking-spaces-to-spaces-in-ruby
I just hit it today.
t0d0r (Todor Dragnev)
06:11 AM Revision e8c23457 (git): fix a typo
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37179 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
03:31 AM Revision 204692c5 (git): * 2012-10-14
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37178 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:30 AM Revision 9e02550b (git): ruby.c: passing block
* ruby.c (rb_f_sub, rb_f_gsub): pass the given block.
[ruby-core:47967] [Bug #7157]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37177 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)

10/13/2012

10:37 PM Bug #7137: Date.parse overly lenient when attempting to parse Monday?
also the following examples should raise error:
Mon Mon Mon
Mon OR Fri?
Good Friday
Friday Sept 11 2001
Sept 11, 2001 & 2002
the original parsedate written by matz.
once, i rewrote the library with a parser generator.
it seem...
tadf (tadayoshi funaba)
10:17 PM Bug #7137: Date.parse overly lenient when attempting to parse Monday?
-1 is not about parsing. Stop messing. shyouhei (Shyouhei Urabe)
09:33 PM Bug #7137: Date.parse overly lenient when attempting to parse Monday?
IMO this is a bug. For example, Math::sqrt(-1) raises an error and does not assume that -1 is 1. alexeymuranov (Alexey Muranov)
02:16 PM Bug #7137 (Rejected): Date.parse overly lenient when attempting to parse Monday?
it does not function as a validator.
it believes the given date is valid.
tadf (tadayoshi funaba)
05:56 PM Bug #7152 (Closed): Is the order of Module#instance_methods intended to be preserved?
No. nobu (Nobuyoshi Nakada)
02:01 PM Bug #7152: Is the order of Module#instance_methods intended to be preserved?
I vote no! Imposing order upon the method table requires all implementations to use an ordered data structure here where unordered structures might serve better. Also consider that reflective method access on most other platforms does no... headius (Charles Nutter)
11:58 AM Bug #7152 (Closed): Is the order of Module#instance_methods intended to be preserved?
https://github.com/jruby/jruby/issues/277 asks this question:
results = 10000.times.map do
chars = ('A'..'Z').map(&:to_sym).shuffle
cls = Class.new do
chars.each do |chr|
define_method(chr) {}
end
end
...
hasari (Hiro Asari)
04:23 PM Revision c3e874d7 (git): merge revision(s) 37175:
* regparse.c (parse_char_class): should match with a hyphen after a
range in a character class.
* test/ruby/test_regexp.rb (TestRegexp#test_char_class): fixed wrong
test.
* test/ruby/test_regexp.rb (...
U.Nakamura
02:23 PM Revision be3a6b8c (git): * regparse.c (parse_char_class): should match with a hyphen after a
range in a character class.
* test/ruby/test_regexp.rb (TestRegexp#test_char_class): fixed wrong
test.
* test/ruby/test_regexp.rb (TestRegexp#check): now can accept the
error message.
* test/ruby/test_regexp.rb
(TextRegexp#test_...
U.Nakamura
01:25 PM Feature #7145: Add string-based range support to IMAP library
I broke the pull request. https://github.com/ruby/ruby/pull/196 is the fixed one. tonyarkles (Tony Arkles)
01:25 PM Bug #7146: IMAP: messages with a mime-attachment of type "message/delivery-notification" fail
I accidentally broke the pull request. Fixed one at https://github.com/ruby/ruby/pull/196 tonyarkles (Tony Arkles)
01:24 PM Bug #7147: IMAP: emails with message/rfc822 attachments fail to parse
I broke the one pull request. Fixed at https://github.com/ruby/ruby/pull/196 tonyarkles (Tony Arkles)
01:23 PM Bug #7153: IMAP: emails with (BODY ("MIXED")) returned from fetch fail to parse
Pull request: https://github.com/ruby/ruby/pull/196 tonyarkles (Tony Arkles)
12:48 PM Bug #7153: IMAP: emails with (BODY ("MIXED")) returned from fetch fail to parse
OK, the patch for this will have conflicts with the patches for #7145, #7146, and #7147 because it also adds unit tests to test_imap_response_parser.rb. I'm not sure what the best approach is for this... Whether to wait until that pull r... tonyarkles (Tony Arkles)
12:35 PM Bug #7153 (Closed): IMAP: emails with (BODY ("MIXED")) returned from fetch fail to parse
I'm not sure if this is even valid IMAP (I couldn't find a reference to it in the RFC), but Google's IMAP server seems to return these occasionally. Found a message in my Inbox that wouldn't parse because of this.
I've added a test an...
tonyarkles (Tony Arkles)
10:03 AM Feature #7068 (Feedback): ability to deactivate Hash#compare_by_identity()
=begin
h = {}
h.compare_by_identity = true
h['a'] = 1
h['a'] = 2
h.compare_by_identity = false
What value is returned for (({h['a']}))?
=end
drbrain (Eric Hodel)
09:46 AM Bug #6830 (Closed): test failure test_constants(OpenSSL::TestConfig) [/ruby/test/openssl/test_config.rb:27] on Mac + homebrew
nobu (Nobuyoshi Nakada)
09:45 AM Bug #6830: test failure test_constants(OpenSSL::TestConfig) [/ruby/test/openssl/test_config.rb:27] on Mac + homebrew
Now tests it if the file exists. nobu (Nobuyoshi Nakada)
03:14 AM Feature #7149 (Feedback): Constant magic for everyone.
What do you expect if the object is assigned to two or more constants? nobu (Nobuyoshi Nakada)
02:46 AM Feature #7149 (Assigned): Constant magic for everyone.
I noticed that certain objects have constant magic: When they are first assigned to a constant, they acquire a name property equal to the constant name string. I only know about Class and Struct objects behaving this way. I like this beh... Anonymous
12:07 AM Bug #7100: WEBrick::HTTPServer.new で BindAddress を指定しない場合に必ず警告が記録される
=begin
私のところでも同様の症状が出ています。そういった警告が出る場合、WEBrick サーバーに IPv6 でアクセスできなくなってしまいます。また、環境によっては http://localhost:3000/ のように localhost を指定してもアクセス不能になってしまいます。(:BindAddress を明示的に指定すれば問題ないのですけれども…)
WEBrick のドキュメントには :BindAddress に関して
デフォルトの ...
ChultOch5 (Sho Morita)

10/12/2012

10:30 PM Bug #7142 (Closed): mingw TestFloat#test_round_with_precision failure
This issue was solved with changeset r37168.
Hiroshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
win32.h: set floating point precision for pow()
* include/rub...
Anonymous
10:30 PM Bug #7140 (Closed): TestWEBrickCGI#test_cgi fails on Windows with chcp 437
This issue was solved with changeset r37167.
Hiroshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
test_cgi.rb: skip a test on Windows
* test/webrick/test_cgi.r...
Anonymous
05:36 PM Bug #7140: TestWEBrickCGI#test_cgi fails on Windows with chcp 437
usa (Usaku NAKAMURA) wrote:
> I can't make the decision to change the encoding of ENV now.
> ...
Is that means changing the encoding of ENV will solve the following inconsistency between input and output?
sh-3.1$ ./miniruby -e 'ENV[...
h.shirosaki (Hiroshi Shirosaki)
04:56 PM Bug #7140 (Assigned): TestWEBrickCGI#test_cgi fails on Windows with chcp 437
I can't make the decision to change the encoding of ENV now.
In future version -- 3.0? -- we will be able to change it.
So, we should make a work around by changing test.
Please commit it.
usa (Usaku NAKAMURA)
10:14 PM Bug #6653: 1.9.2/1.9.3 exhibit SEGV with many threads+tcp connections
Please write a complete reproducing procedure. It requires memcached, right?
I cannot repro on Ubuntu 12.04.
--
Yusuke Endoh <mame@tsg.ne.jp>
mame (Yusuke Endoh)
09:41 PM Bug #6374 (Rejected): Acces to initialized class variable from included module
shugo (Shugo Maeda) wrote:
> mame (Yusuke Endoh) wrote:
> ...
Thanks Shugo!
We then need "very good reason" to change this behavior.
Please reopen this ticket if you have.
--
Yusuke Endoh <mame@tsg.ne.jp>
mame (Yusuke Endoh)
09:40 PM Feature #7114: New classes: `HumanTime::LocalTime`, `HumanTime::Duration`
In my opinion, the most important method of `HumanTime::LocalTime` would be `initialize` ;). It would need to be able to take the number of hours and minutes, or a string and a pattern description, and store it as "hh:mm:ss", with or wi... alexeymuranov (Alexey Muranov)
09:18 PM Feature #6842 (Assigned): Add Optional Arguments to String#strip
mame (Yusuke Endoh)
08:52 PM Bug #7085: Subversion → GitHub gateway stops.
FYI, to follow up latest security fixes, I triggered the script manually. github.com/ruby/ruby
is now synchronized against revision r37165 and the working copy is updated as:
ftp://ftp.ruby-lang.org/pub/incoming/ruby-gateway.r37165....
shyouhei (Shyouhei Urabe)
06:01 PM Revision 872a47c1 (git): file.c: GC guard
* file.c (realpath_rec): prevent link from GC while link_names refers
the content.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37174 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:48 PM Bug #7144 (Closed): [mingw] 1.9.3 backport r37138 breaks build
Already committed shirosaki-san's patch.
Thank you for your report.
usa (Usaku NAKAMURA)
12:42 PM Bug #7144: [mingw] 1.9.3 backport r37138 breaks build
Hiroshi's patch from http://bugs.ruby-lang.org/issues/6127#note-10 enables successful builds on my Win7 32bit using mingw gcc 4.6.2. I expect mingw-w64 gcc 4.7.2 to pass; will reply with details iff failures.
The following complete wi...
jonforums (Jon Forums)
10:42 AM Bug #7144 (Closed): [mingw] 1.9.3 backport r37138 breaks build
On ruby_1_9_3@r37144 (but not trunk@37146) the following error occurs with both GCC 4.6.2 (mingw) and GCC 4.7.2 (mingw-w64)
compiling ../../../../Jenkins/workspace/ruby-1_9_3-svn/io.c
../../../../Jenkins/workspace/ruby-1_9_3-svn/io.c...
jonforums (Jon Forums)
04:47 PM Revision 88e264d2 (git): * regparse.c (parse_char_class): also need to check the type of token
after raw hyphen in regexp class, because the charcter code area
is union'ed with the property of TK_CHAR_TYPE.
reported by Bushi Zhang at [ruby-core:47115] [Backport #6853].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/rub...
U.Nakamura
04:41 PM Revision cc251c2f (git): merge revision(s) 37171:
* test/ruby/test_regexp.rb
(TestRegexp#test_raw_hyphen_and_type_char_after_range): added new
test. ref [ruby-core:47115] [Backport #6853]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@37172 b2dd03c...
U.Nakamura
04:38 PM Revision 5ea65366 (git): * test/ruby/test_regexp.rb
(TestRegexp#test_raw_hyphen_and_type_char_after_range): added new
test. ref [ruby-core:47115] [Backport #6853]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37171 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
04:03 PM Revision 5eb3f9cb (git): * 2012-10-13
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37170 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:03 PM Revision 78e3185a (git): use tty(1) to check if /dev/tty is usable or not
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37169 b2dd03c8-39d4-4d8f-98ff-823fe69b080e naruse (Yui NARUSE)
02:23 PM Feature #7148: Improved Tempfile w/o DelegateClass
Hi,
In message "Re: [ruby-core:47930] [ruby-trunk - Feature #7148][Open] Improved Tempfile w/o DelegateClass"
on Fri, 12 Oct 2012 14:04:08 +0900, "Glass_saga (Masaki Matsushita)" <glass.saga@gmail.com> writes:
> I propose impr...
Anonymous
02:04 PM Feature #7148 (Assigned): Improved Tempfile w/o DelegateClass
I propose improved `Tempfile` without `DelegateClass()`.
Present `Tempfile` has following problems.
1. confusing inspect
~~~ruby
t = Tempfile.new("foo") #=> #<File:/tmp/foo20121012-6762-12w11to>
t.is_a? File #=> fal...
Glass_saga (Masaki Matsushita)
01:30 PM Revision 8d236bc0 (git): win32.h: set floating point precision for pow()
* include/ruby/win32.h (rb_w32_pow): set floating point precision
for mingw-w64 x86 pow(). This improves the precision of pow() on
Windows XP for TestFloat#test_round_with_precision failure.
[ruby-core:47911] [Bug #7142]
git-svn-i...
h.shirosaki (Hiroshi Shirosaki)
01:30 PM Revision 25a79e9f (git): test_cgi.rb: skip a test on Windows
* test/webrick/test_cgi.rb (TestWEBrickCGI#test_cgi): skip a test
depending on locale on Windows. ENV[] doesn't work properly if
console code page is not equal to file system encoding.
[ruby-core:47910] [Bug #7140]
git-svn-id: svn...
h.shirosaki (Hiroshi Shirosaki)
11:41 AM Revision 7206f9bc (git): * process.c (posix_sh_cmds): the command name of colon is ":".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37166 b2dd03c8-39d4-4d8f-98ff-823fe69b080e akr (Akira Tanaka)
11:38 AM Bug #7147 (Assigned): IMAP: emails with message/rfc822 attachments fail to parse
shugo (Shugo Maeda)
11:31 AM Bug #7147 (Closed): IMAP: emails with message/rfc822 attachments fail to parse
Doing im.fetch("1:*", "FULL") on my inbox resulted in a few email messages with attached emssage/rfc822 emails (these were forwarded by someone else). These messages failed to parse. I've fixed this in https://github.com/ruby/ruby/pull/1... tonyarkles (Tony Arkles)
11:37 AM Bug #7146 (Assigned): IMAP: messages with a mime-attachment of type "message/delivery-notification" fail
shugo (Shugo Maeda)
11:31 AM Bug #7146: IMAP: messages with a mime-attachment of type "message/delivery-notification" fail
Was in version "ruby 1.9.3p194" that I noticed the problem. tonyarkles (Tony Arkles)
11:29 AM Bug #7146 (Closed): IMAP: messages with a mime-attachment of type "message/delivery-notification" fail
When doing im.fetch("1:*", "FULL") on my inbox, I discovered an email message that had a delivery notification attached to it. This failed to parse around line 2414 in imap.rb. I've fixed this in https://github.com/ruby/ruby/pull/193 and... tonyarkles (Tony Arkles)
11:37 AM Feature #7145 (Assigned): Add string-based range support to IMAP library
shugo (Shugo Maeda)
11:31 AM Feature #7145: Add string-based range support to IMAP library
Was in "ruby 1.9.3p194" that I noticed the problem. tonyarkles (Tony Arkles)
11:26 AM Feature #7145 (Rejected): Add string-based range support to IMAP library
The imap protocol supports fetching ranges of messages using notation like "1:*" (to fetch all messages). I'd like to support things like: @im.fetch('1:*', 'FULL')@
I've already implemented this as part of https://github.com/ruby/ruby...
tonyarkles (Tony Arkles)
10:23 AM Bug #7097: Thread locals don't work inside Enumerator
2012/10/12 tenderlovemaking (Aaron Patterson) <aaron@tenderlovemaking.com>:
>
> Akira-san, do you have suggestions for method names?

I have no concrete idea.

I guess thread-local variable is used less often than fiber-loca...
akr (Akira Tanaka)
03:53 AM Bug #7097: Thread locals don't work inside Enumerator
Akira-san, do you have suggestions for method names? tenderlovemaking (Aaron Patterson)
09:22 AM Revision b12a9cfb (git): merge revision(s) 37163:
* file.c (rb_get_path_check): path name must not contain NUL bytes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@37164 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
09:18 AM Revision 7085db45 (git): file.c: poisoned NUL
* file.c (rb_get_path_check): path name must not contain NUL bytes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37163 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
08:55 AM Revision 57008f89 (git): merge revision(s) 37068:
* error.c (exc_to_s, name_err_to_s, name_err_mesg_to_str): do not
taint messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@37162 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
08:37 AM Revision 6ae7a4fc (git): merge revision(s) 33857,37157:
Run the test only if /dev/tty exists.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@37158 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
08:19 AM Revision 84fa14aa (git): Fix wrong condition of skipping test_ioctl_linux
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37157 b2dd03c8-39d4-4d8f-98ff-823fe69b080e naruse (Yui NARUSE)
07:28 AM Bug #7141 (Assigned): ALT_STACK_SIZE is not enough
あー、では私のミスっぽいのでちょっと預からさせてくださいませ kosaki (Motohiro KOSAKI)
07:24 AM Revision 2efac157 (git): merge revision(s) 36847,36873: [Backport #7115]
* configure.in (LIBDIR_BASENAME): use configured libdir value to fix
--enable-load-relative on systems where libdir is not default value,
overridden in config.site files. [ruby-core:47267] [Bug #6903]
* ruby...
U.Nakamura
07:07 AM Revision 727c8cdf (git): * tool/merger.rb: now can merge revision(s) without --ticket again.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37154 b2dd03c8-39d4-4d8f-98ff-823fe69b080e U.Nakamura
05:26 AM Bug #7088 (Closed): Documentation of Timeout::timeout is wrong about which thread executes the block
This issue was solved with changeset r37145.
Robert, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/timeout.rb (timeout):
Remove paragraph on wrong impleme...
zzak (zzak _)
05:04 AM Bug #7088: Documentation of Timeout::timeout is wrong about which thread executes the block
I think deleting the paragraph would be sufficient. We don't need to reveal the implementation details of timeout. drbrain (Eric Hodel)
03:29 AM Bug #7088: Documentation of Timeout::timeout is wrong about which thread executes the block
How about we change that to: "The block will be executed on the current thread and will be given one argument: sec. While, the timer for sec number of seconds will run in another thread". zzak (zzak _)
05:10 AM Revision 1b4c99c0 (git): mkmf.rb: use configured libdir value
* lib/mkmf.rb (dir_config, init_mkmf): use configured libdir value as
default library path. [ruby-core:43726] [Bug #6207]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:56 AM Revision c171c834 (git): merge revision(s) 33215:
* test/rexml/test_encoding.rb:
Add require 'require 'rexml/document'
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@37152 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
04:38 AM Revision 58fef622 (git): merge revision(s) 35015:
* numeric.c (flodivmod): must through the same pass if HAVE_FMOD or not.
this is a bugfix of r35013.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@37151 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
04:31 AM Revision 30fbe3a9 (git): * io.c (rb_cloexec_fcntl_dupfd): get rid of compile error on windows.
reported by Donovan Lampa at [ruby-core:43152] [Backport #6127],
based on a patch by Hiroshi Shirosaki at [ruby-core:47917].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@37150 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
04:05 AM Revision 2ac236dc (git): * error.c (name_err_to_s): we need not infect msg.
* test/ruby/test_exception.rb (TestException#test_exception_to_s_should_not_propagate_untrustedness): test for it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8_7@37148 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
12:33 AM Revision 226689a2 (git): Remove wrong tests of r37144
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@37147 b2dd03c8-39d4-4d8f-98ff-823fe69b080e naruse (Yui NARUSE)

10/11/2012

11:09 PM Bug #7135 (Closed): GC bug in Ruby 1.9.3-p194?
This issue was solved with changeset r37143.
Alex, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
string.c: GC guard
* string.c (rb_str_sub{seq,pos,str}, rb_str_e...
nobu (Nobuyoshi Nakada)
05:19 PM Bug #7135: GC bug in Ruby 1.9.3-p194?
Just sent PR. https://github.com/ruby/ruby/pull/191 alexdowad (Alex Dowad)
04:20 PM Bug #7135: GC bug in Ruby 1.9.3-p194?
> I see. In which timezone 4AM?
That's 4AM Zambian time... right now I'm serving as a volunteer in Zambia (and doing Rails-related consulting on the side to support myself and my wife).
alexdowad (Alex Dowad)
11:29 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
Hi,

At Thu, 11 Oct 2012 11:03:31 +0900,
alexdowad (Alex Dowad) wrote in [ruby-core:47905]:
> I'd prefer to submit my own PR, if it's OK with you. It would
> somehow make staying up until 4AM to debug this problem seem
> wor...
nobu (Nobuyoshi Nakada)
11:02 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
> Not yet. I'll apply it if it fixes the bug.
I'd prefer to submit my own PR, if it's OK with you. It would somehow make staying up until 4AM to debug this problem seem worthwhile...
alexdowad (Alex Dowad)
10:53 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
> + RB_GC_GUARD(str);
This also fixes the problem. I looked on GitHub, and it looks like this patch hasn't been applied to the newest version of the Ruby source... I'll submit a pull request.
Thanks to @nobu and @normalperson fo...
alexdowad (Alex Dowad)
10:53 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
Hi,

At Thu, 11 Oct 2012 10:33:16 +0900,
alexdowad (Alex Dowad) wrote in [ruby-core:47902]:
> I just saw your messages after posting. Has the patch you
> showed already been applied to edge Ruby?

Not yet. I'll apply it i...
nobu (Nobuyoshi Nakada)
10:33 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
Hi Nobuさん,
I just saw your messages after posting. Has the patch you showed already been applied to edge Ruby?
alexdowad (Alex Dowad)
10:30 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
YEE-HA!!! I think I may have nailed it!!!
I believe that my compiler was storing the pointer to the frozen string copy in a register, rather than on the stack, so the garbage collector couldn't find any references to it. But even afte...
alexdowad (Alex Dowad)
10:29 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
Hi,

At Thu, 11 Oct 2012 10:08:51 +0900,
alexdowad (Alex Dowad) wrote in [ruby-core:47898]:
> Question: does the Ruby GC look for Object references by
> scanning the stack?

Of course yes, but recent compilers often optimi...
nobu (Nobuyoshi Nakada)
10:23 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
Hi,

At Thu, 11 Oct 2012 08:32:23 +0900,
alexdowad (Alex Dowad) wrote in [ruby-core:47897]:
> OK, I overcame the problem with compiling and testing a
> patched Ruby binary. When I comment out line 6229 of
> string.c, the pro...
nobu (Nobuyoshi Nakada)
10:08 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
OK, I have established beyond all doubt that the contents of the String *are* being overwritten -- *not* the original String, but the frozen copy which #codepoints makes internally. Additionally, the overwriting definitely happens when t... alexdowad (Alex Dowad)
08:32 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
OK, I overcame the problem with compiling and testing a patched Ruby binary. When I comment out line 6229 of string.c, the problem goes away. Then when I uncomment the line and recompile Ruby, the problem comes back again. This is the co... alexdowad (Alex Dowad)
08:05 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
I patched the Ruby interpreter source and recompiled, but I'm having trouble using the resulting binary. The problem is that I don't want to run "make install", because I don't want to mess up my system's setup. But without "make install... alexdowad (Alex Dowad)
07:53 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
"alexdowad (Alex Dowad)" <alexinbeijing@gmail.com> wrote:
> Eric Wong <normalperson@yhbt.net> wrote:
> > I'm not familiar with Prawn, but does any of its dependencies pull in
> > extra C extension which may have memory corruption ...
normalperson (Eric Wong)
07:03 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
More information:
When I restructure the code to avoid using an Enumerator, like this:
s = 0
string.codepoints do |r|
GC.start if $my_debug
if $my_debug
print r, "(", st...
alexdowad (Alex Dowad)
07:00 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
OK, I found a couple more significant things:
1. I can reproduce the problem on Ruby 1.9.2 and 1.9.3, but never 1.8.7.
2. I tried putting calls to "print string.bytes.to_a" and "print string.codepoints.to_a" inside the "string.codepo...
alexdowad (Alex Dowad)
06:50 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
> Does this happen with unmodified Prawn at all?

Good question. I haven't spent a lot of time repeatedly running the spec tests for "unmodified" Prawn. Generally when I run some tests, it's because I'm contributing a patch to the gem...
alexdowad (Alex Dowad)
06:23 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
"alexdowad (Alex Dowad)" <alexinbeijing@gmail.com> wrote:
> Nobuさん, I don't expect that you (or anyone else) would be able to reproduce this bug. As I said, it doesn't happen when I extract the part which is failing from Prawn, only w...
normalperson (Eric Wong)
05:12 AM Bug #7135: GC bug in Ruby 1.9.3-p194?
Nobuさん, I don't expect that you (or anyone else) would be able to reproduce this bug. As I said, it doesn't happen when I extract the part which is failing from Prawn, only when I run the tests against the whole thing (which I have modif... alexdowad (Alex Dowad)
10:13 PM Bug #7142 (Closed): mingw TestFloat#test_round_with_precision failure
=begin
Trunk ruby on Windows XP x86 with mingw-w64 gcc 4.7.2 has the following test failure.
1) Failure:
test_round_with_precision(TestFloat) [C:/Users/Worker/Jenkins/workspace/ruby-trunk-x86-build/test/ruby/test_float.rb:389]:
...
h.shirosaki (Hiroshi Shirosaki)
09:56 PM Bug #7141 (Closed): ALT_STACK_SIZE is not enough
nariです。
以下で教えていただいたバックトレースが出ない件をもう少し追いかけてみた
ところ、どうもシグナルハンドラ内でスタックオーバーフローしているような
気がしています。
http://bugs.ruby-lang.org/issues/7095#note-6
r37088 のコミットで一応問題は再現しなくなったのですが、たぶんこれはスタッ
クを突き破ってメモリ破壊したときに、たまたまセグメント違反にならないよ
うなメモリの配置になったた...
authorNari (Narihiro Nakamura)
09:51 PM Bug #7140 (Closed): TestWEBrickCGI#test_cgi fails on Windows with chcp 437
=begin
Webrick test fails with chcp 437 on Windows mingw reported by Jon.
https://gist.github.com/3859711#gistcomment-585563
C:\Jenkins\workspace>chcp 437
Active code page: 437

C:\Jenkins\workspace>ruby -I ruby-trunk-svn\t...
h.shirosaki (Hiroshi Shirosaki)
08:26 PM Revision 1968892c (git): * 2012-10-12
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37146 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
08:26 PM Revision 17821595 (git): * lib/timeout.rb (timeout):
Remove paragraph on wrong implementation detail.
[ruby-core:47739] [Bug #7088]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37145 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
zzak (zzak _)
06:12 PM Feature #6602: Tail call optimization: enable by default?
+1 for `goto foo()`
Tail call optimization looks to me like a tamed form of `goto`.
alexeymuranov (Alexey Muranov)
03:34 PM Revision 3036104a (git): merge revision(s) 33819,33839:
* io.c (ioctl_narg_len): don't use _IOC_SIZE macro on Linux.
On Linux some constants for ioctl(2) doesn't include the size of
its return value and 16bit value; for example FIONREAD 0x541B.
Moreover the manua...
naruse (Yui NARUSE)
02:09 PM Revision e808b2b1 (git): string.c: GC guard
* string.c (rb_str_sub{seq,pos,str}, rb_str_each_{line,codepoint}):
prevent String copies from GC. [ruby-core:47881] [Bug #7135]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37143 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:50 AM Revision 104d1737 (git): test_string.rb: missing test
* test/ruby/test_string.rb (test_each_codepoint): missing test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37142 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:50 AM Revision 88e326ed (git): test_string.rb: suppress warnings
* test/ruby/test_string.rb (test_match_method): use unique objects in
TestString and TestString2.
* test/ruby/test_string.rb (test_ascii_incomat_inspect): suppress
warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37141 b...
nobu (Nobuyoshi Nakada)
06:50 AM Revision eddfa31b (git): test_string.rb: highlighting
* test/ruby/test_string.rb (test_LSHIFT, test_succ): get rid of
ruby-mode.el confusion.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37140 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:47 AM Revision a9f1e5da (git): * 2012-10-11
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@37139 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
06:47 AM Revision cf7a5afa (git): merge revision(s) 33711,33713,33714,33715,33716,33717,33718,33719,33720,33721,33724,33727,33728,33752,33753: [Backport #6127]
* io.c (ioctl_req_t): Type of req argument of ioctl() depend on platform.
Moreover almost all linux ioctl can't be represented by 32bit integer
(i.e. MSB is 1). We need wrap ioctl argument type.
[Bug #5429] [r...
naruse (Yui NARUSE)
02:33 AM Feature #7106: FileUtils.touch should allow touching the symlink itself rather than the file the link points to
Hey,
Definitely a nice to have feature in the standard library :)
And so... few thoughts / ideas ...
On Linux, it would require both the glibc >= 2.6 and kernel >= 2.6.22 since lutimes() on linux uses the utimensat() system-call (and ...
kwilczynski (Krzysztof Wilczynski)
01:58 AM Bug #7137 (Rejected): Date.parse overly lenient when attempting to parse Monday?
irb(main):001:0> require 'date'
=> true
irb(main):002:0> Date.parse('Monitoring')
=> #<Date: 2012-10-08 ((2456209j,0s,0n),+0s,2299161j)>
irb(main):003:0> Object.constants.sort.each{|c|puts "#{c}=#{Object.const_get(c)}" if c.to_s.star...
garysweaver (Gary Weaver)
12:50 AM Revision 34996e23 (git): Suppress warning: 'iseqval' may be used uninitialized in this function
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37137 b2dd03c8-39d4-4d8f-98ff-823fe69b080e naruse (Yui NARUSE)
 

Also available in: Atom