Activity
From 05/29/2012 to 06/04/2012
06/04/2012
-
10:34 PM Feature #2715: Optimization to avoid spawning shell in Kernel#system call should check for failure conditions
- I wrote a patch to remove the optimization:
remove-shell-invocation-optimization.patch
However it was not good enough because it causes several test failures.
Several failures are caused by pid change which the invoked command is ... -
10:24 PM Bug #6538: Mutability of Rational and Complex
- An alternative way is "marshal format compatibility layer".
-
04:22 AM Bug #6538 (Rejected): Mutability of Rational and Complex
- ok, it's unnecessary.
-
01:12 AM Bug #6538: Mutability of Rational and Complex
- Hi,
nobu (Nobuyoshi Nakada) wrote:
> Marshal compatibilities for (({Complex})) and (({Rational})) are already broken,
> ...
I didn't know. Changing from `#marshal_load` to `.load` would break marshalling between 1.9 and 2.0 though. ... -
- This issue was solved with changeset r35913.
Luis, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
no windows dialog
* win32/win32.c (rb_w32_sysinit): let the syst... -
01:14 PM Bug #6535: [MinGW] Unexpected close program dialog for TestRubyOptions#test_segv_test
- So, this is mingw issue, I guess.
-
09:41 AM Bug #6535: [MinGW] Unexpected close program dialog for TestRubyOptions#test_segv_test
- I saw similar blocking issues with the following tests while MinGW test-all, but mswin build doesn't have.
test_segv_test in ruby/test_rubyoptions.rb
test_require_invalid_shared_object in ruby/test_require.rb.
test_separate in test/... -
- The feature of shell, invoke /bin/sh after ENOEXEC, is implemented
at r33009 of Ruby.
So this example works now as follows.
% cat test1
echo success
% chmod a+x test1
% ./ruby -ve 'p `./test1`'
ruby 2.0.0dev (2012-06... -
- #3856 is at RubyForge tracker:
http://rubyforge.org/tracker/?func=detail&atid=1698&aid=3856&group_id=426 -
05:37 PM Feature #6515: array.c: added method that verifies if an Array is part of another
- Eregon (Benoit Daloze) wrote:
> as = a.to_set
> ...
But does allocate the Set for it of course (so likely not better). -
- lellisga (Li Ellis Galardo) wrote:
> a = [1,2,3,4,5,6,7].to_set
> ...
Taking you example of a the first set and b the maybe-subset:
Well, probably because #subset? is O(m) (m is the size of b), and doing it naively on Array/Enumerable... -
02:36 PM Feature #6515: array.c: added method that verifies if an Array is part of another
- Sorry but i'm not sure what you are asking. In other words you really think it's easier to do this:
a = [1,2,3,4,5,6,7].to_set
=> #<Set: {1, 2, 3, 4, 5, 6, 7}>
b = [1,2,3].to_set
=> #<Set: {1, 2, 3}>
b.subset? a
=> true
... -
- This issue was solved with changeset r35907.
Usaku, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
win32: VT100 escape
* win32/win32.c (constat_apply): apply VT10... -
02:32 PM Bug #6124: remove the "spec-only gems" in Ruby 1.9.3 (was What is the purpose of "fake" gems in Ruby) - Activesupport gem seems to have a problem with this, too: https://github.com/rails/rails/issues/5355.
In short, if new version of bigdecimal is released, activesupport won't pick it up, as it is not in the gemspec and therefore the "fak... -
- I found that test/dl/test_c_{struct,union}_entity.rb was broken when running
test-all with -j option.
The problem was wrong require, so I resolved them in r35901.
In the middle of this work, I noticed that dl/struct.rb didn't requir... -
- * win32/win32.c (rb_w32_sysinit): let the system not display the
critical-error-handler message box and the Windows Error Reporting
dialog. [ruby-core:45389] [Bug #6535]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35913 b2dd0... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35912 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35911 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- beginning in argv_str for try_with_sh.
* internal.h (ARGVSTR2ARGC): adjust for the above change.
(ARGVSTR2ARGV): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- (ARGVSTR2ARGV): defined.
* process.c (proc_exec_v): use ARGVSTR2ARGV.
(rb_spawn_process): use ARGVSTR2ARGC and ARGVSTR2ARGV.
* io.c (pipe_open): use ARGVSTR2ARGV.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35909 b2dd03c8-39d... -
08:14 AM Bug #6544 (Closed): Broken links on lib/drb references documentation
- Hi seki, I've added a patch to remove the broken links in drb documentation.
-
07:24 AM Revision 06513cc1 (git): * vm_insnhelper.h: remove magical code "lfp[0] & 0x02".
- Current VM doesn't use this bit.
* vm_core.h (RUBY_VM_GET_BLOCK_PTR): added.
* eval.c (rb_block_given_p): use RUBY_VM_GET_BLOCK_PTR().
* vm_eval.c (rb_f_block_given_p): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35908 b2... -
- * win32/win32.c (constat_apply): apply VT100 functions.
[ruby-core:44958] [Feature #6418]
* win32/win32.c (constat_parse): parse some VT100 escape sequence.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35907 b2dd03c8-39d4-4d8f-98... -
- * process.c (proc_exec_v, rb_proc_exec_e): merge definitions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35906 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * process.c (proc_spawn_n): remove unused parameter.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35905 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * io.c (pipe_open): argc and argv are not used on win32.
* process.c (rb_spawn_process): remove already useless variables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:06 AM Revision 9bb642d6 (git): * process.c (rb_exec_err): should preserve errno.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35903 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:02 AM Revision efebb5b1 (git): Suppress warnings.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35902 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:10 AM Revision 00e4c2e3 (git): * test/dl/test_c_{struct,union}_entity.rb: broken require.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35901 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Windows path includes `:' character.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35900 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- (1) rename rb_location_t to rb_iseq_location_t.
(2) rename field names of rb_iseq_location_t to adjust
RubyVM::Backtrace::Location methods.
(2-1) filename -> path
(2-2) filepath -> absolute_path
(2-3) basename -> base_label
(... -
- * marshal.c (r_object0): also load TYPE_USRMARSHAL, TYPE_DATA using
compatible loader.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35898 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:36 AM Revision 2493e48d (git): * process.c (rb_run_exec_options_err): restore save_env() call for
- non-fork environments.
* process.c (rb_exec_err): restore environments after the failure of
exec to fix [ruby-core:44093] [Bug #6249] on non-fork environments
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35897 b2dd03c8-39d4-4d8... - 01:44 AM Revision 859869e5 (git): * io.c (pipe_open): follow up changes in r35889.
- * process.c (proc_spawn_n): now uses char ** instead of VALUE *.
* process.c (rb_spawn_process): prog is now VALUE of String, not char *.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35896 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:49 AM Feature #6483: parametric map
- I've made a simple extension that allows one to use nested symbolic-procs like this:
```ruby
[[1,2,3],[4,5,6]].map(&:map.(&:to_s.(2))) # => [['1','10','11'],['100','101','110']]
```
Not to duplicate code - look at http://bugs.rub...
06/03/2012
-
- i thought it first.
but it is cheap trick too (or nils filled instead).
i doubt about this issue.
really need? -
- =begin
What about adding "uninitialized (just allocated) flag" and checking
if it is set in (({marshal_load})) method?
=end
-
- =begin
Marshal compatibilities for (({Complex})) and (({Rational})) are already broken,
since the time they were built in.
=end
-
- class IM
def initialize(s) @s = s end
attr :s
end
i = IM.new(1)
i.s #=> 1
i.instance_eval{@s = 100}
i.s #=> 100
is this a mutable?
-
- I see that this trick won't work if it's frozen after your commit, but the the freeze part was just more fun, sorry. It's the immutability of Rational and Complex that is at stake here.
r = Rational(0)
magic_trick(r)
r ... -
- anyway forbade it.
this is not a magic.
but this trick seems also effective to others.
> r = Random.new
#=> #<Random:0xb87a6d50>
> ...
#=> [...]
> r.freeze
#=> #<Random:0xb87a6d50>
> ...
#=> true
> (0..10).map{r.rand}.to_a... -
-
- I hesitated to report this, but there is a "hole" in the immutability of Rational & Complex:
r = Rational(0) # Rationals are immutable
r.freeze # but let's be certain and freeze it!
magic_trick(r) # r is now chan... -
- This issue was solved with changeset r35888.
Vit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* GPL: update text of GPLv2. [ruby-core:44488] [Bug #6328]
http:... -
- I also propose to consider recursive application for a method in a style I've written in http://bugs.ruby-lang.org/issues/6483#note-3:
Usual application:
~~~ruby
(1..5).map(&:to_s.(2)) # => ['1', '10', '11', '100', '101']
Recursi... -
- * marshal.c (r_object0): adjust indent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35895 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * marshal.c (r_object0): remove old warning for _alloc.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35894 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:26 PM Revision eb6579e6 (git): * marshal.c: experimental test aborted.
- * complex.c: ditto.
* rational.c: ditto.
* include/ruby/intern.h: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35893 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This issue was solved with changeset r35882.
John, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* use execve() to preserve environment variables when exec method... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35892 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:13 PM Revision 78713916 (git): * 2012-06-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35891 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- are not word separator in Bourne shell.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35890 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- add use_shell, argv_str and argv_buf fields.
* process.c (rb_proc_exec_e): don't split shell command line arguments
here to avoid memory allocation in a child process.
(rb_exec_fillarg): split shell command line arguments here.
(p... -
- http://www.gnu.org/licenses/gpl-2.0.txt
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35888 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35887 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:21 PM Revision f5b06413 (git): * marshal.c: calls directly rb_{Complex,Rational}_marshal_load().
- But now disabled. [experimental]
* complex.c: followed the above.
* rational.c: ditto.
* include/rub/intern.h: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- rb_str_new4.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35885 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Ruby has a rule that method names should use a bare verb.
For example, matz described it in [ruby-dev:20735].
I'm not sure that matz described it in English.
Although File#exists? is not removed for compatibility,
it doesn't mean... -
- https://bugs.ruby-lang.org/issues/6538#change-26982
-
- https://bugs.ruby-lang.org/issues/6538#change-26982
-
- call execle().
(rb_proc_exec): use rb_proc_exec_e().
(rb_exec_err): use rb_proc_exec_e().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35884 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35883 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- failed. [ruby-core:44093] [ruby-trunk - Bug #6249]
* include/ruby/intern.h (rb_exec_arg): add envp_str and envp_buf field
to store envp of execve().
* process.c (proc_exec_v): takes envp_str as an argument and use it
for execve().... -
- I feel there are inconsistencies in which methods are public and which are private.
For example:
```
obj = []
prev = obj.instance_variable_get(:@foo) # allowed
obj.instance_variable_set(:@foo, nil) # allowed
# But th... -
- * marshal.c: revert r35879 "now marshal_{load|dump} are external."
* complex.c (nucomp_marshal__{dump,load}): should use rb_marshal_{dump,load}.
* rational.c (nurat_marshal__{dump,load}): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... - 05:17 AM Revision 5dc5a526 (git): modified tests.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35880 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:15 AM Revision d9dd6f5d (git): now marshal_{load|dump} are external.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35879 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:14 AM Revision 1ddb6f70 (git): * ext/date/date_core.c: checks whether the object is frozen or not.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:05 AM Revision bdc55aa0 (git): * complex.c: wrote Complex#_dump and Complex::load. But now
- disabled (due to compatibility) [experimental].
* rational.c: wrote Rational#_dump and Rational::load. ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I've written a short wiki on making feature requests: http://bugs.ruby-lang.org/projects/ruby/wiki/HowToRequestFeatures
I'm inviting others to review and edit it...
I'm rejecting this feature request as it contains many different req... -
- You should have a look at #values_at about #selection.
I'm against has_*_keys?, because I think using any?,all?,... is clearer and not too verbose. (If it did look like C with an explicit loop, then I would consider it verbose).
Ab... -
- I've added a patch to update the links in lib/drb and lib/observer to the Programming Ruby book.
-
01:28 AM Bug #6535 (Closed): [MinGW] Unexpected close program dialog for TestRubyOptions#test_segv_test
- =begin
Hello,
While running tests for MinGW-based build of trunk, I've found the mentioned test (test_segv_test) always blocks test execution.
The command issue to trigger this was:
make test-all TESTS="-q -v ruby/test_rubyopt... - 01:26 AM Revision 89ae71d7 (git): * complex.c (nucomp_marshal_load): [ruby-core:45394]
- * rational.c (nurat_marshal_load): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Nobu, Usa,
Apply plans to apply this?
I've been using it locally with good results. Tools like Spinach, MiniTest and even Bundler worked as expected (with colors)
Here I did a naive attempt to benchmark the impact of this change... -
- I've added a patch to cover Delegator#!(), and fix a nodoc bug.
The nodoc bug may be a separate issue for rdoc, please check it. Using rdoc 3.9.4
Open to feedback on the bang description.
06/02/2012
-
- And of course I forgot the most useful method (more suggestions about names highly appreciate) Array#selection and Hash#selection
alphabet = %w{a b c d e f g h i j}
alphabet.selection(0,1,5,7) # ==> ['a','b','f','h']
{A: 1, T: 4, G:... -
- I suggest introducing Hash methods: has_all_keys?, has_any_key?, has_none_key?, has_one_key?
to write: input.has_all_keys? %w{A C G T}
instead of: %w{A C G T}.all?{|letter| input.has_key? letter}
and to write args.has_one_key?(:inp... -
- =begin
I've added a patch to fix a formatting bug with lib/benchmark.
(({BENCHMARK_VERSION = "2002-04-25" #:nodoc"})) should be (({BENCHMARK_VERSION = "2002-04-25" # :nodoc:}))
Also, went through and fixed up formatting for consis... -
- I've added a patch to update the versions in Racc to be consistent.
This is related to https://github.com/tenderlove/racc/issues/8
Should patches for Racc goto GH/tenderlove/racc, or here? -
- I've added a patch to improve documentation for Racc module.
Not sure what to do with debug functions racc_*()
Or what to do with ext/racc?
Feedback welcome -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35874 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- =begin
Add !<verconf>! mark
+ AC_DEFINE_UNQUOTED(RUBYGEMS_DIR,"$rubygemsdir")
=end -
- + AC_DEFINE_UNQUOTED(RUBYGEMS_DIR,"$rubygemsdir")
-
08:38 AM Feature #5617: Allow install RubyGems into dediceted directory
- This functionality is fine with me, but since it applies to the build system and not RubyGems I think matz or someone else should decide if it should be applied.
I had to manually apply one chunk of this patch, so I attached an update... -
- This issue was solved with changeset r35863.
okkez, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* string.c (rb_enc_cr_str_buf_cat): don't reset coderange as unk... -
- (1) Class name: RubyVM::FrameInfo -> RubyVM::Backtrace::Location.
(2) Method name: RubyVM::FrameInfo.caller ->
Kernel.caller_locations.
(3) Instance methods of
RubyVM::FrameInfo (RubyVM::Backtrace::Location)
(3-1) name -> label... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35872 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- is no longer included from vm.c). I hope this separation reduce
compile time of vm.c.
* internal.h: ditto.
* vm.c, vm_core.h, vm_dump.c, vm_eval.c: ditto.
* vm_eval.c: some functions (callee, etc) moved to vm_backtrace.c.
git-svn-i... -
03:55 PM Bug #6529 (Closed): missing words in description of =~ operator for Regexp
- Currently the Regexp class documentation contains the following: "<tt>=~</tt> is Ruby's basic pattern-matching operator. When one operand is a regular expression and is a string (this operator is equivalently defined by Regexp and Strin...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35870 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:23 PM Revision ea5605dd (git): * 2012-06-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35869 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- this file.
* vm.c, common.mk: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:37 PM Feature #6528 (Closed): Add Pathname#write and Pathname#binwrite
- IO.read と対応する Pathname#read があるので
IO.write と対応する Pathname#write が欲しいです．
IO.write がない現在は pathname.open('w') { |f| f << str } などと書かなくてはならず，冗長ですが
IO.write があれば pathname.write(str) と書けて，簡潔です．
Pathname#write と Pathname#binwrite を実装したパ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35867 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * string.c (rb_enc_cr_str_buf_cat): don't reset coderange as unknown.
the condition 'ptr_a8 && str_cr != ENC_CODERANGE_7BIT' means not
unknown, str is also ASCII-8BIT because str_encindex == ptr_encindex,
an... -
- =begin
Then why don't you use (({Set#subset?})) method?
What's the rationale that (({Array})) also should have similar method?
And why different name?
=end
-
- @nobu you are right. I'll change the method to (arry1 - arry2).empty?. About the method functionally I thought of it like the subset method from Set. That's why it doesn't care about the order.
- 09:18 AM Revision 866761d2 (git): * lib/ipaddr.rb: Inhibit zero-filled octets in an IPv4 address in
- all platforms. [ruby-dev:45671]
* lib/ipaddr.rb: Allow the x:x:x:x:x:x:d.d.d.d form not limited to
IPv4 mapped/compatible addresses. This change also makes it
possible for the parser to understand IPv4 mapped and compatible
IPv6 ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I will commit this once #6492 is approved and committed.
-
- Fixed by eaf2b80c and 0d72fc0d to the rdoc repository.
-
- the condition 'ptr_a8 && str_cr != ENC_CODERANGE_7BIT' means not
unknown, str is also ASCII-8BIT because str_encindex == ptr_encindex,
and nont (str_cr == ENC_CODERANGE_UNKNOWN) and
str_cr != ENC_CODERANGE_7BIT means str_cr is vali... -
- This issue was solved with changeset r35862.
Nathan, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* doc/re.rdoc (Performance): Replaced incorrect example of red... -
- This issue was solved with changeset r35860.
Nathan, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* doc/re.rdoc (Performance): Removed useless sample output fro... -
- This is a duplicate of #5624 and was fixed by r33976
-
06:10 AM Bug #6306: Ripper lexes :on_kw when it should find :on_ident
- That is correct. I've used Ripper.sexp() a tad, but will look to using that more. Thank you for the feedback.
-
- I think this is good.
Nobu, do you have any comments?
06/01/2012
-
10:15 PM Bug #6527 (Rejected): WEBrick::HTTPResponse.header is a hash
- This means that there can only be one header with a given name, which makes if for example impossible to implement anything but the most trivial RFC 2617 authentication schemes, most of which would require several WWW-Authenticate header...
-
- backtracking through anchoring with reduced backtracking through a
range. [ruby-trunk - Bug #6525]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:45 PM Bug #6479: ipaddr.rbの受け付ける書式が、プラットフォームによって異なる
- 武者さん、なかむら(う)さん
お二方とも、御返信下さり有難う御座います。
> cf. http://pubs.opengroup.org/onlinepubs/009696799/functions/inet_addr.html
0埋め時のC側に於ける解釈は、8進数にする旨明記されていたのですね
由来が把握できて、すっきりしました。
> ...
御丁寧に有難うございます。
手元の ipaddr.rb を利用しているコード内で問題が表面化してい... - 09:35 PM Revision 5c56ae7f (git): * 2012-06-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- performance example and switched from #match to #=~ for consistency.
[ruby-trunk - Bug #6524]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35860 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Hi Eric,
I've updated a new patch with your requested changes, also fixed up the method definitions in "(4) prepare extconf.rb" where applicable. -
- I don't think the call-seq changes to lib/mkmf.rb are necessary. In some cases they don't match up with the method definitions. Can you remove them?
I think Appendix C. can be removed entirely and and after the extconf.rb method lis... -
- I've added a patch to move any missing bits from README.EXT Appendix C to MakeMakefile, in exchange for "See MakeMakefile for functions that are available to extconf.rb".
-
-
- In the Regexp class documentation, "Performance" section, the code block that starts out "# Match a string of 29 <i>a</i>s against a pattern of 29 optional" seems to be the only block of sample code on the page which would return a valu...
-
- marcandre (Marc-Andre Lafortune) wrote:
> Hi
> ...
Actually! I had such a problem with #product too, but have already forgotten about it. -
- same_by? is a good alternative. I've even replaced #same? with #same_by? in my projects.
-
- =begin
What status is this proposal?
I don't think the original proposal has been rejected, but only other
additional extensions.
Possible choice would be:
(1) keep current behavior, all method transplanting is prohibited.
(2) accept... -
- In the "Performance" section of the Regexp class documentation, the intro to the first sample code block says "Consider a string of 25 as, a d, 4 as, and a c."
However, as the return value given in that sample block makes clear, t... -
- In the Performance section of the Regexp documention, it is stated that changing from Regexp.new('a?' * 29 + 'a' * 29) to Regexp.new('\A' 'a?' * 29 + 'a' * 29) speeds up the match significantly. However, '\A' 'a?' * 29 actually expands...
-
11:58 AM Feature #6445: request for default length/position on string index
- It would look nice and work fine with indexing strings and arrays, but if it were put in you would've come to want (1..).each {|i| .. } to work as well.
It might be better to default the omitted end to +Infinity and then make {Array,S... -
11:53 AM Bug #5497 (Feedback): Math.log10(10_000) error on HP-UX/PA
- I don't have any environments to examine this issue.
Please give me a patch to fix this. -
- This is fixed by r33915
-
- This is fixed by r35555
-
- You use Leopard because the kernel version is 9.8.0.
We don't support Leopard so we want to know whether this issue is reproduced on the combination of the newest version of kernel (11.4.0) and the newest version of ruby (trunk or 1.9.3... -
- Great work, but please watch for trailing whitespace.
-
- This issue was solved with changeset r35858.
Zachary, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* array.c: Updated Array documentation formatting. Patch by ... -
- This is a duplicate of #6488
-
- I was looking through the Regexp class documentation found at
http://www.ruby-doc.org/core-1.9.3/Regexp.html
... and found a number of problems that appeared to be either display issues or typos.
Most notably, throughout the entire ... -
- I reworded this slightly to emphasize that instance methods of Kernel are documented on Object but module methods are documented on Kernel.
-
- This issue was solved with changeset r35856.
Zachary, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* object.c (Init_Object): Restored Kernel documentation based... -
- I've added a patch to cover Kernel module documentation. This puts object.c to 100% documentation!
-
- This issue was solved with changeset r35854.
Zachary, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* object.c (rb_equal): Let Object be a link in #=== documenta... -
01:47 AM Bug #6520 (Rejected): Invalid url is identified as valid
- The following will tell you what is happening.
1.9.3p125 :010 > s[URI.regexp]
=> "http://abc"
URI.regexp is supposed to be used to extract urls from text.
str.scan(URI.regexp) { p $& }
I don't think it is a good idea t... -
01:33 AM Bug #6520 (Rejected): Invalid url is identified as valid
- (({
1.9.3p125 :006 > require 'uri'
=> true
1.9.3p125 :007 > URI.parse invalid_url
URI::InvalidURIError: bad URI(is not URI?): http://abc</option%3E
1.9.3p125 :009 > invalid_url =~ URI::regexp
=> 0
}))
As you can see, 'parse... -
- * object.c (class_or_module_required): extract check for class or
module.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35859 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:06 AM Bug #6514: Abort trap: 6 running rspec on rdf.rb
- Hi,
It seems that step 1.5
$ git clone git://github.com/ruby-rdf/rdf.git
is required.
But I also cannot reproduce abort trap with ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-darwin11.3.0].
Mr Gregg, could you tell us th...
05/31/2012
-
- Scott. [ruby-trunk - Feature #6517]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35858 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- redmine側のbugfixをしていたり系なのでclose
-
- これって [ruby-dev:45694] を見るとバックポート以外決着がついてるように見えるのですが、
今更チケット化されたのは何かやることが残っているのでしょうか。
よくわからないままに usa さんにアサイン。
--
Yusuke Endoh <mame@tsg.ne.jp> -
12:09 PM Bug #6519 (Closed): space in COUTFLAG
- こんにちは。
mkmf.rbで作成するMakefileには COUTFLAG や OUTFLAG といったmakeの変数が
定義されます。その内容が意図した結果となっていないのではないかと思いま
した。殆どの環境で実害は出ていないと思います。
きっかけは4月の終わりに、Solaris 9上のpkgsrcでruby193-baseのコンパイル
がエラーとなるという報告がありました。報告された方に答えつつ確認を求め
た事項が少々的... -
-
- Let Object be a link in rdoc output, formatting of case.
-
-
- I went through array.c to add missing examples and apply more consistent formatting.
-
- I cannot reproduce.
$ git clone git://github.com/ruby-rdf/rdf.git
Cloning into 'rdf'...
remote: Counting objects: 6187, done.
remote: Compressing objects: 100% (1828/1828), done.
remote: Total 6187 (delta 4496), reused 5949 (delta... -
- I completely agree that the behavior you are proposing is best.
But it would be hard to implement exactly because the library (libyaml) is searched by extconf.rb, which requires ruby executable (miniruby).
So, it is impossible to make ... -
- =begin
I'm not in favor with this proposal, because of its name mainly.
'Array ((|X|)) is part of array ((|Y|))' sounds like 'all elements in ((|X|)) are
arranged in ((|Y|)) successively in the same order', to me.
If the order is not yo... -
-
-
-
- #set_ctypes using newer ruby features to simplify its implementation.
* test/dl/test_c_struct_entry.rb (class DL): Test to verify
refactoring.
Reviewed by Aaron Patterson.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35857 b2d... -
- Pickaxe book documentation. Patch by Zachary Scott.
[ruby-trunk - Feature #6521]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35856 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:30 PM Revision ee4f9b7c (git): * 2012-06-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35855 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Patch by Zachary Scott. [ruby-trunk - Feature #6518]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35854 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:16 PM Bug #4413: Segmentation fault when using deliver for GMAIL SMTP
- So, thinking about this resulted in the following:
1.9.3p194 pry(main)> require 'openssl'
=> true
1.9.3p194 pry(main)> OpenSSL::OPENSSL_VERSION
=> "OpenSSL 1.0.1c 10 May 2012"
1.9.2p180 pry(main)> require 'openssl'
=> true
1.9... -
- * gc.c (os_obj_of_i): adjust indent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35853 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- jrochkind (jonathan rochkind) wrote:
> I think the use case is very common -- it is for me anyway, I think I"m not unique!
> ...
Raising exception as soon as possible sounds reasonable.
But replacing is not.
In principle, such bad da... -
11:05 AM Bug #6306: Ripper lexes :on_kw when it should find :on_ident
- So, you need to have semantics of your input, not a lexical analysis. Right?
Then your using Ripper.lex is a wrong idea. You should not only catch those lexer events but also catch parser events.
You might find Ripper.sexp() implemen... -
- =begin
If this is how the lexer works, then I guess there's not much use in pleading my case, but FWIW, I'll explain more...
I'm the author of ((<URL:http://rubygems.org/gems/tailor>)) and I'm trying to parse code that looks, for exampl... -
- After checking with Aaron I cleaned up some missing capitalization in the patch, improved some generic descriptive documentation, and replaced "== Example" with just "Example:" since the sections were so short.
-
- This issue was solved with changeset r35846.
Vincent, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* ext/dl: Added documentation. Patch by Vincent Batts.
[ru... -
07:48 AM Feature #5663: Combined map/select method
- =begin
By the way, is anybody using the (({nil})) returned by (({#compact!})) ?
enum.map { |i| i + 1 if i.even? }.compact
makes un unnecessary copy, but i cannot use
enum.map { |i| i + 1 if i.even? }.compact!
because it ... -
- * vm.c (frame_info_{line_no,name,basename,filename,filepath}): add
UNREACHABLE to suppress warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35852 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35851 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- to remove unused variables and simplify using newer ruby features.
* test/dl/test_c_struct_entry.rb: Test to validate refactoring
Reviewed by Aaron Patterson
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35850 b2dd03c8-39d4-4d8f-...
05/30/2012
-
- #set_types to reuse DL::CUnionEntity::size
* test/dl/test_c_union_entity.rb: Added test
Reviewed by Aaron Paterson
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I'm adding a new patch that fixed a typo. I also did some refactor to the code.
-
-
- I've added Li's patch from GH#127
-
- Sorry, I wasn;t sure what to upload. Please remove them.
nobu (Nobuyoshi Nakada) wrote:
> Why attaching whole files?
-
- Why attaching whole files?
-
- This method is like the include? method but instead of receiving a value and check if the array has it, it receives an array an check if it's part of another one.
https://github.com/ruby/ruby/pull/127 -
- return the size of the union.
* test/dl/test_c_union_entity.rb: Test for DL::CUnionEntity::size
Reviewed by Aaron Patterson
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35848 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:48 PM Revision e88c8880 (git): * 2012-05-31
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [ruby-trunk - Bug #6496]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35846 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- drbrain (Eric Hodel) wrote:
> Why remove the HAVE_ZLIB and @response_has_body checks?
Ah, I wrongly removed it, it is needed.
> ...
OK, you can commit it, thanks. -
- Why remove the HAVE_ZLIB and @response_has_body checks?
This updated patch incorporates your change to maintain backwards-compatibility but leaves in the HAVE_ZLIB and @response_has_body checks. -
08:24 PM Feature #6513: Make method_missing to lookup in constants too
- @sorah it's probably the best possible example - I met it a while ago in nokogiri and was confused to see "def XML". dirty.Nokogiri.XML.new("<foo />").class - neat
@matz every "new" thing confuses until user learns how it works now. I... -
09:36 AM Feature #6513: Make method_missing to lookup in constants too
- I am negative, since it gives more chance to confuse users, e.g.
mere constant definition can differentiate the meaning of the code.
-
09:26 AM Feature #6513: Make method_missing to lookup in constants too
- FYI, nokogiri.gem has Nokogiri::XML module and Nokogiri::XML method.
$ irb -rnokogiri
>> Nokogiri::XML.class
=> Module
> ...
=> Nokogiri::XML::Document
-
- @nobu
>Why do you think so?
any example of method in popular libraries or anything with first capital letter? Why to support what is not needed and messes lookup process?(example above)
> ...
Are you sure, why?
by 'awesome' I mea... -
- =begin
: egor.homakov (egor homakov) wrote:
None of code style guides teaches to use capital letters in methods' names. It's not convinient and bad practise.
Why do you think so?
#A.B.C instead of A::B::C - awesome?!
It do... -
02:16 PM Feature #5937: Zlib::Inflate#add_dictionary to pre-supply dictionaries for inflate streams
- @naruse: as Eric pointed out in his original ticket (#5929), I do believe this is a bug, as the current API advertises that it can set and use the dictionary, but that is not the case.
I've opened a different / new ticket: http://bug... -
- I think #5929 should be backported instead. While #5937 makes working with custom dictionaries easier, #5929 fixes the current API (#set_dictionary) to be fully usable.
-
- 本件の実装の大枠はもうできていて、あとはどういう表記を認めるかというところで諸方面に確認中ですが、ゼロ埋めについては不許可にしたいと思うようになりました。
というのもアドレスのパースに用いられるCの inet_addr() の仕様を見ると、ドット区切りの各オクテットが0で始まるときは8進数として扱うべしとあり、一方でゼロ埋めの十進3桁固定方式も入力フォーム等で見られるため、ライブラリ側ではいずれとも判断しかねるからです。
cf. http://pubs.op... -
09:57 AM Bug #6514 (Rejected): Abort trap: 6 running rspec on rdf.rb
- Running RSpec on http://github.com/ruby-rdf/rdf/spec reliably generates the Abort trap.
To repeat:
1. git clone git://github.com/ruby-rdf/rdf.git
2. cd rdf
3. bundle install
4. rspec spec
It does not seem to happen when runni... -
- I've updated this patch. Upon working with the code again and looking at RFC 2616, I have made the following changes:
> naruse (Yui NARUSE) wrote:
> ...
Due to read_chunked, and persistent connections I don't see how to make this wo... -
- * ext/zlib/zlib.c (do_inflate): Inflate more data if buffered data
exists. Allows Zlib::Inflate#set_dictionary to work.
[ruby-trunk - Bug #5929]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@3584... - 07:30 AM Revision d3a349bb (git): * ext/bigdecimal/lib/bigdecimal/jacobian.rb,
- ext/bigdecimal/lib/bigdecimal/newton.rb:
fix documentation comments.
Patch by alperakgun from github.com/shyouhei/ruby/pull/8
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:26 AM Revision ecb6bd90 (git): * ext/bigdecimal/lib/bigdecimal/jacobian.rb (Jacobian#dfdxi):
- fix jacobian to get stuck in an infinite loop when a solution is not
found due to forget to increment nRetry counter.
Patch by alperakgun from github.com/shyouhei/ruby/pull/8
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35843 b... -
- On May 28, 2012, at 04:37, NARUSE, Yui wrote:
> 2012/5/27 mame (Yusuke Endoh) <mame@tsg.ne.jp>:
>>
>> Issue #6482 has been updated by mame (Yusuke Endoh).
>>
>>
>> Hello, drbrain
>>
>> Are you willing to be a net/http(s) mai... -
- This issue was solved with changeset r35837.
Daniel, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* error.c (exc_set_backtrace): Updated documentation to indica... -
- This is a bug in RDoc's ruby parser
-
- * time.c (utc_offset_arg): utc offset can be precision in seconds.
e.g. old Europe/Lisbon (c.f. [ruby-dev:40066])
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35842 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/test/unit.rb (Test::Unit::Runner#_prepare_run): split platform condition.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35841 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * bootstraptest/runner.rb, sample/test.rb: add --color option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35840 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (btest, test-sample, test-knownbugs, test-all, test-ruby):
pass common options by TESTOPTS.
* tool/rubytest.rb: pass ARGV from make to sample/test.rb.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35839 b2dd03c8-39d4-...
05/29/2012
-
10:44 PM Bug #6498: Cygwin needs $(DEFFILE) for extension libraries.
- nobu-san, I'm not sure if I fully understand what you said, but this is an issue of linking a static import library into a DLL. Please let me clarify.
The command line which fails looks like this:
gcc -shared -o atk.so atkobj.o -Wl,-... -
- First letter of constant is always a capital letter(in Ruby).
if you define method:
def Hi
1
end
You're not able to use it w/o ():
Hi
it looks up for constant and raises error. only:
Hi() or send(:Hi)
None of code style ... -
- =begin
First letter of constant is always a capital letter(in Ruby).
if you define method:
def Hi
1
end
You're not able to use it w/o ():
Hi
it looks up for constant and raises error. only:
Hi() or send(:Hi)
N... - 09:20 PM Revision 99c741c1 (git): * 2012-05-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- set_backtrace allows a string as well as an array of strings.
[ruby-trunk - Bug #6501]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35837 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- str_gsubの中でdestが一回non asciiになってしまったらそれ以降はsearch_nonasciiしても無駄という気がしますが専門家のご意見をうかがいたいところです。
-
10:03 AM Bug #6509 (Closed): String#gsub is too slow if receiver includes a binary
- =begin
以下のようなコードで String#gsub が遅くなります。
* b = "" の場合(A): 0.2840230464935303
* b = "\xB9" の場合(B): 4.183771848678589
# -*- coding: utf-8 -*-
a = ("abcde\n"*50000).force_encoding("binary")
#b = ""
b = "\xB9".forc... -
- partially borrowed from ext/date.
* strftime.c (rb_strftime_with_timespec): support GNU extension triple
colons modifier. [EXPERIMENTAL]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- partially borrowed from ext/date.
* strftime.c (rb_strftime_with_timespec): check conversion with locale
modifier.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- partially borrowed from ext/date.
* strftime.c (rb_strftime_with_timespec): colons are valid only for
'z' and must come just before it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35834 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I was unable to reproduce this with ruby 1.9.3p125 (2012-02-16 revision 34643) [x86_64-linux] and rdoc 3.9.4
Could be an issue with ruby-doc.org? - 12:52 AM Revision 4f4de9b8 (git): * 2012-05-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35833 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The warning cause test_singleton_method_added to fail.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35832 b2dd03c8-39d4-4d8f-98ff-823fe69b080e