Activity
From 12/19/2011 to 12/25/2011
12/25/2011
-
11:42 PM Feature #5805: object_hexid
- On 2011年12月25日 14:38, Nobuyoshi Nakada wrote:
> In 1.9.3 or later
> ...
Hmm.. this seems to pad two extra zeros.
"0x00000000014100e0"
instead of
"0x000000014100e0"
Is Urabe correct? Does `sprintf` work just as well... -
11:27 PM Feature #5805: object_hexid
- Thank you for 1.9.3+ definition, I will add that. Do you happen to know definition for 1.8.7? I am not worried about anything older than that.
> Even if the method were added, it would never affect 1.9 or earlier, so it changes nothin... -
06:23 PM Feature #5805: object_hexid
- On 2011年12月25日 14:38, Nobuyoshi Nakada wrote:
> In 1.9.3 or later
> ```ruby
> module Kernel
> def object_hexid
> "0x"+[object_id<<1].pack("L>!").unpack("H*")[0]
> end
> end
I prefer to use `sprintf()... -
02:38 PM Feature #5805 (Feedback): object_hexid
- Hi,
(11/12/25 0:22), Thomas Sawyer wrote:
> By default Ruby will show this id when using #inspect.
> ...
In 1.9.3 or later
```ruby
module Kernel
def object_hexid
"0x"+[object_id<<1].pack("L>!").unpack("H*")[0]
... -
12:57 PM Feature #5805: object_hexid
- I think this seems like a simple proposal.
-
12:22 AM Feature #5805 (Feedback): object_hexid
- I would like to see #object_hexid added to Ruby to return an object's id in hexidecimal form.
By default Ruby will show this id when using #inspect.
Object.new.inspect
=> "#<Object:0x000000023cadf0>"
I, for one, have often ... -
11:17 PM Bug #5714: Unexpected error of STDIN#read with non-ascii input on Windows XP
- I updated the patch while waiting for the response.
Cleanups
* remove unnecessary parentheses of `fptr`
* use return value of setmode() which returns the previous translation mode if successful
http://msdn.microsoft.com/en-us/libr... -
10:05 PM Feature #5798: Range#include? needs some optimization
- I agree that the behavior you point out seems inconsistent, because
(0..1).include?(0.5)
=> true
-
08:47 PM Revision 7a9b2cad (git): * ext/openssl/ossl_cipher.c: Fix more typos.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34127 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:09 PM Revision 91785eca (git): * ext/openssl/ossl_cipher.c: Fixed typo.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34126 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:02 PM Revision 16558749 (git): * ext/openssl/ossl_cipher.c: Update and complete documentation.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34125 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:53 PM Revision 684d7b8e (git): * 2011-12-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34124 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:53 PM Revision 976aba43 (git): git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34123 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:17 PM Revision 38ade501 (git): * test/testunit/test_parallel.rb (test_separate): Test for "--separate"
- option (r34121)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34122 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:47 PM Revision 60da7a36 (git): * lib/test/unit.rb (_run_parallel):
- New option "--separate" for test/unit; when running tests with this
option, a job process will be restarted after one testcase has done.
This means all testcases will run with separated process.
* lib/test/unit/parallel.rb: Fix for ... -
12:42 AM Feature #5788: Thread#at_exit
- =begin
Nakada-san, thank you for your reviewing.
I improved the patch at some points.
* th->at_exit is to be marked.
* If the thread is dead, Thread#at_exit returns nil.
* The thread is passed to the hooks(including hooks on main th...
12/24/2011
-
11:58 PM Feature #5788: Thread#at_exit
- I don't think ruby impl w/o GVL can implement this feature.
-
11:15 PM Feature #5788: Thread#at_exit
- i don't think the name of this method is good… are there any more suitable name for this method?
-
07:37 PM Feature #5798: Range#include? needs some optimization
- There is method `Range#cover?` for this. `Range#include?` is inherited from `Enumerable` module, so you are proposing to redefine it inside the class.
This being said, i also had a somewhat related proposal here: #5534. I suggested ... - 03:05 PM Revision f8a4e233 (git): * 2011-12-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34120 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:05 PM Revision 60b99d05 (git): * configure.in: change --with-ntver to --with-winnt-ver to be more
- descriptive in the context. [ruby-core:41794]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34119 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:24 PM Revision 3cbf3e20 (git): * configure.in: add --with-ntver option to match win32/configure.bat
- functionality. Set 0x0501 as default. [ruby-core:35010]
[ruby-core:35035]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34118 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:56 AM Bug #5803 (Closed): closed output and Readline.readline dumps core
- This issue was solved with changeset r34116.
Nobuhiro, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* ext/readline/readline.c (readline_readline): check if outst... -
01:04 AM Bug #5803 (Closed): closed output and Readline.readline dumps core
- =begin
libreadline 側の問題だと思うのですが、Readline.output= に指定した IO をクローズした後
Readline.readline で補完するとコアダンプしました。
"##\t" のところを色々変えてみるとコアダンプしたりしなかったりします。
$ cat readline_test.rb
require "readline"
IO.pipe do |r, w|
Readline.input = ... -
06:59 AM Bug #5802 (Closed): 0 assretions in test/readline/test_readline.rb:test_line_buffer__point
- This issue was solved with changeset r34115.
Nobuhiro, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* test/readline/test_readline.rb (test_line_buffer__point): u... -
12:39 AM Bug #5802 (Closed): 0 assretions in test/readline/test_readline.rb:test_line_buffer__point
- =begin
test/readline/test_readline.rb の test_line_buffer__point を実行しても、
一つも assertion が実行されていません。Readline.completion_proc に指定した
proc から return しているので、そこでテストケースから抜けているようです。
$ ruby test/readline/test_readline.rb -n test_line_buffer_... -
04:51 AM Bug #5804 (Closed): Cannot cross compile trunk using Ruby 1.9.3 as BASERUBY
- Hello,
Attempting to cross-compile trunk (at r34114) with i686-w64-mingw32 host. -
03:38 AM Revision 8af67e30 (git): * proc.c (proc_call): get rid of optimazation-out by clang.
- * proc.c (rb_proc_call, rb_proc_call_with_block): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34117 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:56 AM Revision 1dec79c3 (git): * ext/readline/readline.c (readline_readline): check if outstream
- is closed to get rid of a bug of readline 6. [ruby-dev:45043]
[Bug #5803]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34116 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/23/2011
-
09:59 PM Revision 83971343 (git): * test/readline/test_readline.rb (test_line_buffer__point): use
- lambda not to exit entire method by "return". or "next" for
proc. [ruby-dev:45042] [Bug #5802]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34115 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:45 PM Bug #5801: Enumerable#take_while の proc を外に出して使うと Segv
- Enumerable#grep なども同様の問題がありますね。
以下の再現コードで Segv を吐きます。
enum.c で、XX_i という形の関数の第二引数が C の
スタックへのポインタになってるやつは、全部同じ問題を
含んでいるのではないでしょうか。
# 再現コード
~~~ruby
class A
include Enumerable
def each(&b)
$block = b
yield
end
... -
05:31 PM Bug #5801 (Closed): Enumerable#take_while の proc を外に出して使うと Segv
- 芝と申します。
下の再現コードのように、`Enumerable#take_while` の Proc を
外に出して使うと Segv が発生します。
~~~ruby
# 再現コード
class A
include Enumerable
def each(&b)
$block = b
yield
end
end
puts A.new.take_while{true}
100.times{$block.call}... -
04:39 PM Revision db9657a8 (git): * bootstraptest/test_flow.rb: remove an unused parameter.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34114 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:23 PM Revision dd834c68 (git): * vm_eval.c (send_internal): PASS_PASSED_BLOCK_TH must be placed
- just before calling rb_call0.
* bootstraptest/test_flow.rb: add a test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34113 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:56 PM Revision c6cbbd6e (git): * 2011-12-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34112 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:56 PM Revision c5485f41 (git): * lib/tempfile.rb (Tempfile#initialize): warn if a block is given.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34111 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:32 PM Feature #5798 (Rejected): Range#include? needs some optimization
- For example:
('aa'..'az').include? 123
it seems that the procedure is:
1. check whether 'aa' == 123 # false
2. 'aa'.succ # 'ab'
3. check whether 'ab' == 123 # false
4. 'ab'.succ # 'ac'
5. check whether 'ac' == 123 # false
.... -
11:12 AM Bug #5797 (Third Party's Issue): 2nd crash (?) with green shoes gem (but it seems different) ...
- At http://bugs.ruby-lang.org/issues/5795. That issue was discovered on a Mac 10.5. However, on a Mac 10.7.2 machine, using the same source referenced in that report, an apparently different crash occurs (Cf. the log file at http://pasteb...
-
11:00 AM Bug #5795: Ruby crash (?) with a simple green shoes app
- It may be worth noting this happens on a Mac 10.5 (Leopard) machine.
-
02:42 AM Bug #5795 (Third Party's Issue): Ruby crash (?) with a simple green shoes app
- I have installed the "green shoes" gem and am attempting to run the script found at http://pastebin.com/cCVx7rB5. I expect a shoes app to open with a basic alert box and not a crash. Instead I get a crash (log file found at http://pasteb...
-
07:55 AM Revision dc42e8bb (git): refine message for test_thr_kill.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34110 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:38 AM Revision 5191ecad (git): * ext/readline/readline.c (readline_attempted_completion_function):
- in Readline module with GNU Readline 6 case, Readline module
resets completion_append_character to " ", after it executes
completion. So, Readline module stores
completion_append_character, and Readline module always sets it
afte... -
07:02 AM Revision ec4f9d1c (git): * ext/readline/readline.c (Init_readline): libedit check
- rl_getc_function only when rl_initialize() is called, and
using_history() call rl_initialize(). This assignment should be
placed before using_history(). [ruby-core:40641] [Bug #5539]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... -
05:44 AM Bug #5796 (Closed): main.c is not compiled during cross compilation
- Hello,
Attempting to cross-compile trunk against i686-w64-mingw32 (GCC 4.6) is failing to compile main.c when executed a simple "make".
Used 1.8.7-p352 as BASERUBY:
ruby 1.8.7 (2011-06-30 patchlevel 352) [i686-darwin10.8.0]
The... -
02:26 AM Feature #5788 (Feedback): Thread#at_exit
- =begin
Just reviewed briefly.
* (({th->at_exit})) needs to be marked,
* (({th->at_exit})) should be hidden, and
* a hook registered to the main thread seems to be executed in a child
process forked in a sub-thread too.
Second, ... -
01:15 AM Revision e89bebda (git): * test/thread/test_queue.rb (test_thr_kill): show the number of loop
- run when the test failed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34107 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:24 AM Revision 8beb0d35 (git): * test/test_pty.rb (test_pty_check_default): call PTY.check until
- "cat" command is finished.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34106 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/22/2011
-
11:57 PM Feature #5787: OpenSSL::X509::Name#to_a Improvement (Patch Attached)
- Great news, let me know if there's anything I can do to help.
-
09:41 AM Feature #5787 (Assigned): OpenSSL::X509::Name#to_a Improvement (Patch Attached)
- That's a good idea, Paul, thanks. It's also in line with RFC 4514 (the former 2253).
I'll have to check whether this causes problems when again parsing such a string
representation and probably fix that, too. But once that's done I'm... -
05:13 AM Feature #5787: OpenSSL::X509::Name#to_a Improvement (Patch Attached)
- Updated patch to avoid a probable memory leak. I don't do much in C so if I still have a mistake please let me know! The github diff is at https://github.com/reaperhulk/ruby/compare/trunk
-
03:30 AM Feature #5787 (Closed): OpenSSL::X509::Name#to_a Improvement (Patch Attached)
- In ruby 1.8/1.9/trunk the OpenSSL::X509::Name#to_a method attempts to map OIDs to short names. If an OID has no associated shortname this causes it to return the string "UNDEF". It would be much more useful if it returned the OID in this...
-
09:06 PM Revision b32f79e0 (git): * common.mk: add "check succeeded" message.
- * README, README.ja: follow above change.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34105 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:06 PM Revision 0212af17 (git): * ext/bigdecimal/bigdecimal.h: add satisfy cc-mode comment.
- * util.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34104 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:51 PM Bug #5637: warnings of shellescape
- いろいろ考えたんですが、単に //n フラグを削るだけにしようと思います。
・1.8: 一律バイナリとして扱うのは、文字列にencoding情報がなく$KCODEもあてにならないため、やむを得ない仕様だった。(この事情は1.9+には当てはまらない)
・1.9: 1.9.3の今までずっとこの挙動だった。警告はバグ(//nの修正漏れ)として消すが、挙動については非互換を招くので変えない。
・2.0: 文字列の使い道(渡すシェルのlocaleなど)を知っているのは呼... -
06:49 PM Bug #5790 (Closed): net/http の EOFError と Keep-Alive
- [ruby-dev:39421] がずっと心に残っていたので、思い立って調べてみたので、
(正確には自分が高頻度で踏むようになったので調べてみた)
その調査結果と対策案を提案します。
まず、投げられる原因ですが、根本的な原因は Keep-Alive のタイムアウトです。
HTTP/1.1 ではデフォルトで持続的接続を行うので、複数回のリクエストに渡って
一つの socket が使い回されます。
しかし、リクエスト同士で時間が開いていると、サーバー側で... -
06:34 PM Feature #5789 (Closed): Optimize st_table
- I prepared couple of patches to optimize st_table performance.
First patch (st_func.patch) is a trivial translation of some macroses to functions,
but it gives ~4% of improvement on gcc-4.5.2 32bit (sorry for not testing other enviro... -
05:35 PM Feature #5788 (Rejected): Thread#at_exit
- =begin
I propose a new method Thread#at_exit.
It is to register a block which will be called when the thread ends.
p Thread.main #=> #<Thread:0x007f828fa97fe0 run>
p t = Thread.new{ # do something } #=> #<Thread:0x007f828fc9e500 ... -
04:57 PM Bug #5423 (Feedback): readlineの入力待機中に端末のウィンドウサイズ変更すると入力内容が乱れる
- ご報告ありがとうございます。
ただ、こちら(OSX 10.6、ruby 2.0.0dev (2011-12-22 trunk 34097) [x86_64-darwin10.8.0]、 GNU Readline 6.2)では「画面が乱れます」を再現ができませんでした。
Readline.readline("> ")で何を入力しているときに、ウインドウサイズをどれくらい大きく、または小さくすると再現するのでしょうか。 - 03:10 PM Revision 9ce124dd (git): * 2011-12-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34103 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:10 PM Revision 37b79d03 (git): * test/test_pty.rb (test_pty_check_default): "cat" may not terminateed
- in the 0.1 second.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34102 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:58 PM Revision 92c5d84a (git): Decrease timeout limit.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34101 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:39 PM Revision 3be2c7db (git): * test/ruby/test_thread.rb: don't test the maximum sleep time. Ruby
- is not a real-time system.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34100 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:59 PM Feature #5474: keyword argument - Hi,
Not sure why the following modifications made in redmine were not
posted on the mailing list...
While having fun testing your patch, I encountered an issue with more
than 2 rest arguments:
def foo(*rest, b: 0,... -
06:46 AM Feature #5474: keyword argument
- On 30 October 2011 11:10, Yusuke Endoh <mame@tsg.ne.jp> wrote:
> Currently, my patch allows ** only when there are one or more
> ...
I'm worried about cases where one doesn't use named arguments directly but wants to pass them on to an... -
05:33 AM Feature #5474: keyword argument
- While having fun testing your patch, I encountered an issue with more than 2 rest arguments:
def foo(*rest, b: 0, **options)
[rest, options]
end
foo(1, 2, bar: 0) # => [[1, 2], {bar: 0}] OK
foo(1, 2, 3, b... -
01:45 PM Revision b288aa2d (git): * thread_pthread.c (ping_signal_thread_list): remove return value.
- * thread_pthread.c (check_signal_thread_list): add a new function to
check if signal thread list is empty.
* thread_pthread.c (thread_timer): check signal thread list after
timer_thread_function(). main thread might be added into sig... -
01:08 PM Feature #5248: Faster PStore
- Thank you, Nakamura-san.
I'm glad pstore.rb became faster.
Yui NARUSE wrote:
> About such possibility, see http://www.radiumsoftware.com/0406.html#040630
Thank you for letting me know. -
12:50 PM Feature #4495 (Closed): PStoreの高速化
- closing. thank you for your contribution.
-
09:48 AM Revision afbcfdf9 (git): Suppress warnings.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34098 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:00 AM Bug #5777: class_eval/module_eval works differently when given a string than when given a block in 1.9.2 and 1.9.3
- Yehuda, thanks for the response. I understand that the lookup rules were changed between 1.9.1 and 1.9.2 -- that's not the issue I'm raising.
What I find strange is that class_eval in 1.9.2+ interprets the exact same code differently ... -
04:27 AM Feature #5781: Query attributes (attribute methods ending in `?` mark)
- Perhaps one option to consider is to allow extra parameters specifying alternate names for the getters and setters (Obj-C does this for synthesized properties). Something like:
attr_accessor :foo, { :var => :bar, :getter => :is_barabl...
12/21/2011
-
06:39 PM Feature #5785 (Closed): Readline に pre_input_hook, insert_text, redisplay を追加
- 拡張ライブラリ readline で補完時の処理をカスタマイズするため rl_pre_input_hook, rl_insert_text, rl_redisplay をサポートして欲しいです。
叩き台としてパッチを添付します。 -
06:39 PM Feature #5784 (Closed): Readline.special_prefixes の追加
- 拡張ライブラリ readline で rl_special_prefixes のセットをサポートして欲しいです。
叩き台としてパッチを添付します。 -
06:30 PM Bug #5783 (Closed): r33949からVC++6.0でminiprelude.c、newline.cの生成ができなくなった
- This issue was solved with changeset r34092.
Masahiro, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* common.mk (newline.c, miniprelude.c): revert r33949 because... -
06:15 PM Bug #5783 (Closed): r33949からVC++6.0でminiprelude.c、newline.cの生成ができなくなった
- D:\ruby_ext\ruby_git\win32>nmake
<中略>
NMAKE : fatal error U1073: 'miniprelude.c' のビルド方法が指定されていません。
Stop.
common.mkでターゲット名がminiprelude.c:から{$(VPATH)}miniprelude.c:になって、nmakeに認識できなくなったようです。
-
03:50 PM Revision c9a9036d (git): ChangeLog: revert r34093. sorry, these are necessary for ruby-mode.el
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34097 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:44 PM Revision 5136e61c (git): * ChangeLog: fix a typo.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34096 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:42 PM Revision 4af11279 (git): * ext/bigdecimal/bigdecimal.c (VpMult, VpCtoV, VpSqrt): remove assined
- but unused variables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34095 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:37 PM Revision b3369100 (git): * 2011-12-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34094 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:37 PM Revision af845f35 (git): * ext/bigdecimal/bigdecimal.h: remove unused lines.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34093 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:35 PM Bug #5775 (Closed): BigDecimal does not follow Allocation Framework
- This issue was solved with changeset r34089.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* ext/bigdecimal/bigdecimal.c (BigDecimal_s_allocate): follo... -
12:16 PM Feature #5248: Faster PStore
- Masaki Matsushita wrote:
> Kenta Murata wrote:
> ...
About such possibility, see http://www.radiumsoftware.com/0406.html#040630 -
11:04 AM Feature #5248 (Closed): Faster PStore
- Applied to trunk at r34083 (perf.diff) and r34084 (cosmetic.diff), excluding $0 -> $PROGRAM_NAME change because other libs are using $0. I'm closing this as 'fixed'.
Thanks for the patch! We needed your eyes, I even didn't know we hav... -
09:37 AM Feature #4495: PStoreの高速化
- r34083, r34084 で同様のpatchを取り込んで頂いたので( #5248 )、差し支えなければこちらはcloseして頂ければと思います。
- 09:30 AM Revision 2e683de9 (git): * common.mk (newline.c, miniprelude.c): revert r33949 because the change
- broke mswin build, and the changer said no reason about the change.
[ruby-dev:45016] [Bug #5783]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34092 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:19 AM Feature #5781: Query attributes (attribute methods ending in `?` mark)
- attr_query :foo
Would be nice to add a query method ending in foo? to return the instance variable @foo.
I agree that changing current behaviour of attr or attr_reader or attr_writer would be bad.
But a new method "attr_query :f... -
07:44 AM Feature #5781: Query attributes (attribute methods ending in `?` mark)
- > So why not just allow: attr :foo?
I agree. I know many people wish for that too.
> ...
What do you mean by removing '?' from instance variables ?
As you said, '?' is already forbidden in instance variable names.
> Thomas Sawy... -
03:59 AM Feature #5781: Query attributes (attribute methods ending in `?` mark)
- @matz In that case I would propose:
attr :foo?
#=> def foo?; @foo; end
attr_reader :foo?
#=> def foo?; @foo; end
attr_writer :foo?
#=> def foo=(x); @foo=(x); end
attr_accessor :foo?
#=> attr_re... -
03:51 AM Feature #5781: Query attributes (attribute methods ending in `?` mark)
- @jeremy Been down that road, and it's not as clean as you might expect. You end up needing two methods e.g. `attr_query_reader` and `attr_query_accessor` (`attr_query_writer` would be essentially meaningless). Moreover, adding additional...
-
01:23 AM Feature #5781: Query attributes (attribute methods ending in `?` mark)
- On Tue, Dec 20, 2011 at 8:17 PM, Jeremy Bopp <jeremy@bopp.net> wrote:
> How about adding an attr_query method that otherwise works identically
> to attr_reader but creates a method with a '?' on the end of the given
> name instead?
... -
07:03 AM Revision 75583e52 (git): * goruby.c: windows support.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34091 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:23 AM Revision 7bc839bd (git): * goruby.c (goruby_options): auto irb.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34090 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:35 AM Revision f9a4d571 (git): * ext/bigdecimal/bigdecimal.c (BigDecimal_s_allocate): follow
- Allocation Framework. [Bug #5775]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34089 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/20/2011
-
11:53 PM Feature #5781: Query attributes (attribute methods ending in `?` mark)
- On 12/20/2011 08:03 AM, Yukihiro Matsumoto wrote:
>
> Issue #5781 has been updated by Yukihiro Matsumoto.
>
>
> It's mostly because semantics. attr :a creates a method corresponding to an instance variable @a. So naively,... -
11:03 PM Feature #5781: Query attributes (attribute methods ending in `?` mark)
- It's mostly because semantics. attr :a creates a method corresponding to an instance variable @a. So naively, attr :a? tries to create an instance variables @a? which is not a valid name for a instance variable.
I don't want to allo... -
09:52 PM Feature #5781 (Assigned): Query attributes (attribute methods ending in `?` mark)
-
04:57 AM Feature #5781 (Assigned): Query attributes (attribute methods ending in `?` mark)
- Pretty sure this has come up before, but I'd like to revisit b/c I don't understand why it isn't allowed.
Sometimes I define "query" attributes, and in those cases I'd like the reader method to end in a `?` mark. Currently I have to d... -
08:37 PM Revision 1c6226b6 (git): * test/ruby/test_require.rb (test_race_exception): delete temporary library name.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34088 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:58 PM Feature #5248 (Assigned): Faster PStore
-
06:58 PM Feature #5248: Faster PStore
- Nice performance tweak :)
-
06:02 PM Feature #5248: Faster PStore
- =begin
Thanks! perf.diff looks OK to me. I'm evaluating this. cosmetic.diff would be handled later.
require 'pstore'
require 'benchmark'
def run(size)
file = "pstore_#{size}"
File.unlink(file) if File.exist?(fil... -
04:52 PM Feature #5248: Faster PStore
- Yes.
I split the patch. -
03:56 PM Feature #5248: Faster PStore
- Matsushita-san, would you please split the patch into 2 parts, one for perf optimizations and another for trivial cosmetic changes?
There's no pstore.rb maintainer now but I think I can understand perf fixes and merge it for actual ps... -
03:22 PM Feature #5248: Faster PStore
- I wrote a patch using Digest::MD5.digest instead of String#sum.
I think it is enough to avoid collision. -
05:37 PM Revision 934b954a (git): * ext/psych/emitter.c: fixing clang warnings. Thanks Joey!
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34087 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:55 PM Bug #5768: TestRequire#test_race_exceptionで競合するケースがまだある
- Nobuyoshi Nakada wrote:
> rb_barrier_release/rb_barrier_destroyが呼ばれた時点ではmutexがロックさ
> ...
その前提は成立しません。
このテストにおいて、t1 は t2.stop? == true を待ってから、例外によって require を抜けます。
言い換えると、t2 が rb_barrier_wait 内の rb_mutex_lock 内の native_cond_wait に到... -
03:59 PM Bug #5768: TestRequire#test_race_exceptionで競合するケースがまだある
- なかだです。
(11/12/20 13:43), Yui NARUSE wrote:
> 追いかけた結果、どうも lock に用いている rb_barrier_release/rb_barrier_destroy や rb_mutex_lock のマルチスレッド対応がいまいちだったようです。
> 前者は rb_mutex_unlock を外した直後から、待っていた他のスレッドが動き始めるのでもはや mutex->cond_waiting は古い情報と... -
02:10 PM Bug #5768: TestRequire#test_race_exceptionで競合するケースがまだある
- lock_funcやrb_mutex_lockを変更するのは反対なので、いったん預かります
-
01:43 PM Bug #5768: TestRequire#test_race_exceptionで競合するケースがまだある
- 追いかけた結果、どうも lock に用いている rb_barrier_release/rb_barrier_destroy や rb_mutex_lock のマルチスレッド対応がいまいちだったようです。
前者は rb_mutex_unlock を外した直後から、待っていた他のスレッドが動き始めるのでもはや mutex->cond_waiting は古い情報となってしまう点、
後者は GVL_UNLOCK_BEGIN() した直後から、メインのスレッドが動いてしまう可... -
04:14 PM Bug #5782 (Closed): File.binwrite doc and hash argument
- The doc for `File.binwrite` doesn't mention the possibility of a fourth argument (option hash), unlike `File.write`. Judging from the code, this looks like an oversight.
Can we get confirmation that it does accept a fourth parameter a... - 04:09 PM Revision 0afb73c6 (git): * 2011-12-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34086 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:09 PM Revision 327ea26b (git): * ext/bigdecimal/README: Update redmine.ruby-lang.org to bugs.ruby-lang.org
- * ext/socket/ancdata.c: ditto
* test/-ext-/wait_for_single_fd/test_wait_for_single_fd.rb: ditto
* test/syck/test_yaml.rb: ditto
* doc/ChangeLog-1.9.3: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34085 b2dd03c8-39d4-4d8f-98ff... - 02:57 PM Revision a934aeb6 (git): Cosmetic changes of lib/pstore.rb. Patch by Masaki Matsushita. See #5248.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34084 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:56 PM Revision fcec6b5c (git): * PStore content update perf optimization. Patch by Masaki Matsushita.
- See #5248.
* lib/pstore.rb (save_data):
* Delete inadequate Marshal check.
* Deferred file truncation: when writing the new content, truncate
the saved file to the data size after writing the data, instead of
truncating wh... - 12:03 PM Revision 5aea2ad1 (git): * ext/date/date_core.c: uses to_integer instead.
- * test/date/test_switch_hitter.rb: added a test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34082 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:09 AM Feature #5741: Secure Erasure of Passwords
- Thanks for your thoughts!
> I think you're going to adopt opt-in way, so library/application
> ...
Yes, I think opt-in is the only way to ensure there are no negative side
effects on existing code.
> If it's opt-in, new specif... - 07:07 AM Revision 15e6d260 (git): * io.c: Improve rdoc for {File|IO}.write
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34081 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:52 AM Revision def733c5 (git): * 2011-12-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@34080 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:52 AM Revision a3192373 (git): * io.c: Improve rdoc for {File|IO}.write
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@34079 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:06 AM Revision be4f7bf5 (git): * Make sure to clear $! when ignoring an exception
- * ext/openssl/ossl.c (ossl_pem_passwd_cb0, ossl_verify_cb):
pem_passwd_cb and verify_cb ignores the exception raised in a
callback proc so it should clear $! for subsequent execution.
That's said, both subsequent processes for pem... -
05:57 AM Revision 0ead5c49 (git): * test/ruby/test_require.rb (test_race_exception): rewrote without
- global attribute.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34077 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:13 AM Bug #5780 (Closed): test/fileutils/test_fileutils.rb:86: [BUG] Segmentation fault
- Hello,
Using Debian SID/unstable I am trying to port ruby1.9.1 (1.9.3.0) package to ARM hardfloat, some data on my build environment is:
* gcc version 4.6.2 (Debian 4.6.2-7)
* libc6 eglibc 2.13 (Debian 2.13-21)
* Architec... -
03:51 AM Feature #5779 (Rejected): Ruby-FTP - allow easy way to find out whether a remote target is a file or a directory
- Hello.
The FTP documentation of Ruby is at:
http://www.ruby-doc.org/stdlib-1.9.3/libdoc/net/ftp/rdoc/index.html
When you have a local file on your HDD, you can do this:
File.directory? '/tmp' # => true
File.file? '/etc... -
03:50 AM Bug #5476: ruby 1.9.3_rc1 segfaults in test_fork.rb on HPPA
- Lucas Nussbaum wrote:
> Ruby on hppa is broken because hppa (at least last time I checked) was using a LinuxThreads-based thread implementation instead of NPTL.
Not true at least on Gentoo/HPPA which has been using NPTL. So at least ... -
02:49 AM Revision f26ee745 (git): * test/date/test_date_base.rb (test_jd): tests for
- [ruby-dev:45008].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34076 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:03 AM Bug #5777: class_eval/module_eval works differently when given a string than when given a block in 1.9.2 and 1.9.3
- It's important to note that most uses of class_eval with a block are mostly taking existing blocks and modifying their context. For example, take a look at the rspec DSL:
describe "TrueClass" do
it "should not be initializable"... -
02:02 AM Feature #5778 (Closed): Allow WEBrick::HTTPResponse to send IO-duck-typed bodies
- WEBrick::HTTPResponse currently type-checks for IO to determine how to transfer content to the outgoing socket. Because of this, it's not possible to use "IO-like" objects as data sources unless they specifically inherit from IO.
The... -
01:22 AM Revision a9b0e34b (git): * ext/date/date_core.c (wholenum): fix the type of the return value.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34075 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/19/2011
-
09:07 PM Revision 80101267 (git): * README.ja: Update redmine.ruby-lang.org to bugs.ruby-lang.org
- * README: ditto
* common.mk: ditto
* ext/bigdecimal/README: ditto
* man/erb.1: ditto
* man/irb.1: ditto
* man/ri.1: ditto
* man/ruby.1: ditto
* man/ruby.1: ditto
* sparc.c: ditto
* tool/install-sh: ditto
git-svn-id: svn+ssh:/... -
08:03 PM Bug #5777 (Closed): class_eval/module_eval works differently when given a string than when given a block in 1.9.2 and 1.9.3
- class_eval/module_eval works differently when passed code as a string than when passed the same code as a block in 1.9.2/1.9.3.
In particular, constant lookup appears to vary. Here's a very short test case (this is on a Mac on 1.9.2,... - 05:16 PM Revision 7e178720 (git): * 2011-12-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34073 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:16 PM Revision 305cd3fb (git): * ext/date/date_core.c: [ruby-dev:45008].
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34072 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:16 PM Bug #5476 (Feedback): ruby 1.9.3_rc1 segfaults in test_fork.rb on HPPA
-
02:53 PM Feature #5741: Secure Erasure of Passwords - Here's my 2 yen.
> 1. Would you agree that we need this functionality?
Good to have, but it would be hard to use properly.
> 2. Where would we ideally place it? I'm not sure whether
> String is the perfect place, but... -
11:37 AM Bug #5776 (Closed): irb のトップレベルで定義したメソッドが public になる
- irb のトップレベルで定義したメソッドの呼び出し制限が private ではなく public になってしまいます。
-------------------------------------------------
irb(main):001:0> def greeting
irb(main):002:1> 'hi'
irb(main):003:1> end
=> nil
irb(main):004:0> val = Object.ne... -
10:58 AM Bug #5768: TestRequire#test_race_exceptionで競合するケースがまだある
- bug5754 .rb の中で t2 が Thread.current になっているようだったのと、scratch の配列の順序が
違っているようだったので少し変更してみました。
diff --git a/test/ruby/test_require.rb b/test/ruby/test_require.rb
index 9186a6f..02f7efe 100644
--- a/test/ruby/test_require.rb
+++ b/test/... -
09:23 AM Bug #5714: Unexpected error of STDIN#read with non-ascii input on Windows XP
- Hello,
In message "[ruby-core:41689] Re: [ruby-trunk - Bug #5714] Unexpected error of STDIN#read with non-ascii input on Windows XP"
on Dec.16,2011 14:07:18, <h.shirosaki@gmail.com> wrote:
> > I think you should check in yo... -
02:13 AM Bug #5714 (Closed): Unexpected error of STDIN#read with non-ascii input on Windows XP
- This issue was solved with changeset r34043.
Heesob, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* win32/win32.c, include/ruby/win32.h (rb_w32_fd_is_text): new ... -
07:15 AM Feature #3090: xml-rpc support for i8 data type
- is there a reason why this patch was postponed to 2.0.0 and not included in one of the releases this year?
-
02:13 AM Bug #5762 (Closed): Bug#4178 が sparc Solaris 10 + Oracle Solaris Studio 12.2 で再発
- This issue was solved with changeset r34071.
Naohisa, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* vm.c (vm_define_method): improve guard of iseq from GC. Fix... -
02:13 AM Bug #5773 (Closed): bigdecimal comparison raises SystemStackError
- This issue was solved with changeset r34070.
Aaron, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* ext/bigdecimal/bigdecimal.c (Init_bigdecimal): does not follow... -
02:13 AM Bug #5711 (Closed): r32774 (and r32783) broke nmake support
- This issue was solved with changeset r34044.
Usaku, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* common.mk,Makefile.in,win32/Makefile.sub (ECHO1): move platfor... -
02:13 AM Bug #5754 (Closed): Double require bug in 1.9.3
- This issue was solved with changeset r34039.
Evan, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* load.c (load_unlock): release loading barrier and then remove i... -
02:13 AM Bug #5688 (Closed): Solaris10 で spawn を繰り返すとメモリリークする
- This issue was solved with changeset r34033.
okkez, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* thread_pthread.c (rb_thread_create_timer_thread): fix memory
...