Project

General

Profile

Actions
Copy link

Bug #13955

closed

NKF.nkf のオプション文字列が SHARABLE_MIDDLE_SUBSTRING=1 を考慮していない

Bug #13955: NKF.nkf のオプション文字列が SHARABLE_MIDDLE_SUBSTRING=1 を考慮していない

Added by tommy (Masahiro Tomita) about 8 years ago. Updated almost 8 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
Backport:
2.3: DONE, 2.4: DONE
[ruby-dev:50269]

Description

SHARABLE_MIDDLE_SUBSTRING=1 でコンパイルしたRubyで、NKF.nkf のオプション文字列が正しく扱われません。

% ruby -rnkf -e 'opt="--ic=UTF-8 --oc=EUC-JISX0213 -w"[0,28]; p opt; p NKF.nkf(opt, "あ").encoding' "--ic=UTF-8 --oc=EUC-JISX0213" #<Encoding:UTF-8>

次のパッチで直ると思います。

diff --git a/ext/nkf/nkf.c b/ext/nkf/nkf.c index 9613a925ce..df32e9cf0b 100644 --- a/ext/nkf/nkf.c +++ b/ext/nkf/nkf.c @@ -137,7 +137,7 @@ rb_nkf_convert(VALUE obj, VALUE opt, VALUE src) { VALUE tmp; reinit(); - StringValue(opt); + StringValueCStr(opt);  nkf_split_options(RSTRING_PTR(opt)); if (!output_encoding) rb_raise(rb_eArgError, "no output encoding given");

適用後

% ruby -rnkf -e 'opt="--ic=UTF-8 --oc=EUC-JISX0213 -w"[0,28]; p opt; p NKF.nkf(opt, "あ").encoding' "--ic=UTF-8 --oc=EUC-JISX0213" #<Encoding:EUC-JIS-2004>

Updated by nobu (Nobuyoshi Nakada) about 8 years ago Actions
Copy link
 #1

  • Status changed from Open to Closed
  • Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN to 2.3: REQUIRED, 2.4: REQUIRED

Updated by nagachika (Tomoyuki Chikanaga) almost 8 years ago Actions
Copy link
 #2 [ruby-dev:50387]

  • Backport changed from 2.3: REQUIRED, 2.4: REQUIRED to 2.3: REQUIRED, 2.4: DONE

ruby_2_4 r61456 merged revision(s) 60071.

Updated by usa (Usaku NAKAMURA) almost 8 years ago Actions
Copy link
 #3 [ruby-dev:50458]

  • Backport changed from 2.3: REQUIRED, 2.4: DONE to 2.3: DONE, 2.4: DONE

ruby_2_3 r62140 merged revision(s) 60071.

Actions
Copy link

Also available in: PDF Atom