Project

General

Profile

Actions

Bug #13112

closed

io/console io.winsize=[rows,cols] throws TypeError: no implicit conversion of false into Integer

Bug #13112: io/console io.winsize=[rows,cols] throws TypeError: no implicit conversion of false into Integer

Added by tompng (tomoya ishida) almost 9 years ago. Updated over 8 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-darwin16]
[ruby-core:79004]

Description

The doc says

winsize = [rows, columns] Tries to set console size. The effect depends on the platform and the running environment. You must require 'io/console' to use this method. https://docs.ruby-lang.org/en/2.4.0/IO.html#method-i-winsize-3D 

but it doesn't work.

require 'io/console' STDIN.winsize=[] #=> ArgumentError: wrong number of arguments (given 0, expected 2..4) STDIN.winsize=[24,80,1,2] #=> ok(args=4) STDIN.winsize=[24,80,nil,nil] #=> ok(args=4) STDIN.winsize=[24,80,1] #=> ok(args=3) STDIN.winsize=[24,80,nil] #=> ok(args=3) STDIN.winsize=[24,80] #=> args=2 unexpectedly throws TypeError: no implicit conversion of false into Integer 
OS: macOS Sierra 10.12.2 versions: ruby 2.4.0 -> TypeError ruby 2.3.1 -> TypeError ruby 2.0.0 -> ok 
// ext/io/console/console.c static VALUE console_set_winsize(VALUE io, VALUE size) { .... size = rb_Array(size); rb_check_arity(RARRAY_LENINT(size), 2, 4); sz = RARRAY_CONST_PTR(size); row = sz[0], col = sz[1], xpixel = sz[2], ypixel = sz[3]; ... #define SET(m) ws.ws_##m = NIL_P(m) ? 0 : (unsigned short)NUM2UINT(m)  SET(row); SET(col); SET(xpixel); SET(ypixel); // is using xpixel(==sz[2]) and ypixel(==sz[3]) ok? (RARRAY_LENINT(size) might be less than 4) // maybe sz[3] is 0(object_id of false?) when RARRAY_LENINT(size) is 2 

Updated by nobu (Nobuyoshi Nakada) almost 9 years ago Actions #1

  • Status changed from Open to Closed

Applied in changeset r57280.


console.c: OOB access

Updated by nobu (Nobuyoshi Nakada) almost 9 years ago Actions #2 [ruby-core:79008]

  • Description updated (diff)
  • Backport changed from 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN to 2.2: DONTNEED, 2.3: REQUIRED, 2.4: REQUIRED

Updated by naruse (Yui NARUSE) over 8 years ago Actions #3 [ruby-core:80022]

  • Backport changed from 2.2: DONTNEED, 2.3: REQUIRED, 2.4: REQUIRED to 2.2: DONTNEED, 2.3: REQUIRED, 2.4: DONE

ruby_2_4 r57849 merged revision(s) 57280,57282.

Updated by nagachika (Tomoyuki Chikanaga) over 8 years ago Actions #4 [ruby-core:80382]

  • Backport changed from 2.2: DONTNEED, 2.3: REQUIRED, 2.4: DONE to 2.2: DONTNEED, 2.3: DONE, 2.4: DONE

ruby_2_3 r58151 merged revision(s) 57280,57282.

Updated by nagachika (Tomoyuki Chikanaga) over 8 years ago Actions #5

  • Backport changed from 2.2: DONTNEED, 2.3: DONE, 2.4: DONE to 2.2: DONTNEED, 2.3: REQUIRED, 2.4: DONE

Updated by nagachika (Tomoyuki Chikanaga) over 8 years ago Actions #6 [ruby-core:80412]

  • Backport changed from 2.2: DONTNEED, 2.3: REQUIRED, 2.4: DONE to 2.2: DONTNEED, 2.3: DONE, 2.4: DONE

ruby_2_3 r58189 merged revision(s) 57289.

Actions

Also available in: PDF Atom