changeset:   87932:68e0dbc492de
branch:      3.3
parent:      87928:08c95dd68cfc
user:        Victor Stinner <victor.stinner@gmail.com>
date:        Fri Dec 13 12:14:44 2013 +0100
files:       Lib/test/test_bytes.py Misc/NEWS Objects/bytesobject.c
description:
Issue #19969: PyBytes_FromFormatV() now raises an OverflowError if "%c"
argument is not in range [0; 255].


diff -r 08c95dd68cfc -r 68e0dbc492de Lib/test/test_bytes.py
--- a/Lib/test/test_bytes.py	Fri Dec 13 12:08:01 2013 +0200
+++ b/Lib/test/test_bytes.py	Fri Dec 13 12:14:44 2013 +0100
@@ -729,6 +729,12 @@
         self.assertEqual(PyBytes_FromFormat(b's:%s', c_char_p(b'cstr')),
                          b's:cstr')
 
+        # Issue #19969
+        self.assertRaises(OverflowError,
+                          PyBytes_FromFormat, b'%c', c_int(-1))
+        self.assertRaises(OverflowError,
+                          PyBytes_FromFormat, b'%c', c_int(256))
+
 
 class ByteArrayTest(BaseBytesTest, unittest.TestCase):
     type2test = bytearray
diff -r 08c95dd68cfc -r 68e0dbc492de Misc/NEWS
--- a/Misc/NEWS	Fri Dec 13 12:08:01 2013 +0200
+++ b/Misc/NEWS	Fri Dec 13 12:14:44 2013 +0100
@@ -10,6 +10,9 @@
 Core and Builtins
 -----------------
 
+- Issue #19969: PyBytes_FromFormatV() now raises an OverflowError if "%c"
+  argument is not in range [0; 255].
+
 - Issue #14432: Generator now clears the borrowed reference to the thread
   state. Fix a crash when a generator is created in a C thread that is
   destroyed while the generator is still used. The issue was that a generator
diff -r 08c95dd68cfc -r 68e0dbc492de Objects/bytesobject.c
--- a/Objects/bytesobject.c	Fri Dec 13 12:08:01 2013 +0200
+++ b/Objects/bytesobject.c	Fri Dec 13 12:14:44 2013 +0100
@@ -186,8 +186,17 @@
 
             switch (*f) {
             case 'c':
-                (void)va_arg(count, int);
-                /* fall through... */
+            {
+                int c = va_arg(count, int);
+                if (c < 0 || c > 255) {
+                    PyErr_SetString(PyExc_OverflowError,
+                                    "PyBytes_FromFormatV(): %c format "
+                                    "expects an integer in range [0; 255]");
+                    return NULL;
+                }
+                n++;
+                break;
+            }
             case '%':
                 n++;
                 break;
@@ -267,8 +276,12 @@
 
             switch (*f) {
             case 'c':
-                *s++ = va_arg(vargs, int);
+            {
+                int c = va_arg(vargs, int);
+                /* c has been checked for overflow in the first step */
+                *s++ = (unsigned char)c;
                 break;
+            }
             case 'd':
                 if (longflag)
                     sprintf(s, "%ld", va_arg(vargs, long));