Skip to content

Commit 1d81506

Browse files
committed
Merge pull request geocoder-php#474 from heiglandreas/hotfix/CountryCode
Adds coutry-code to MapQuest-Results
2 parents fa09a3d + 8f51e4d commit 1d81506

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

src/Geocoder/Provider/MapQuest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ private function executeQuery($query)
159159
'postalCode' => $location['postalCode'] ?: null,
160160
'adminLevels' => $admins,
161161
'country' => $location['adminArea1'] ?: null,
162+
'countryCode' => $location['adminArea1'] ?: null,
162163
));
163164
}
164165
}

tests/Geocoder/Tests/Provider/MapQuestTest.php

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,11 @@ public function testGeocodeWithRealAddress()
7272
$this->assertEquals('Paris', $result->getAdminLevels()->get(2)->getName());
7373
$this->assertEquals('Ile-de-France', $result->getAdminLevels()->get(1)->getName());
7474
$this->assertEquals('FR', $result->getCountry()->getName());
75+
$this->assertEquals('FR', $result->getCountry()->getCode());
7576

7677
$this->assertFalse($result->getBounds()->isDefined());
7778
$this->assertNull($result->getStreetNumber());
7879
$this->assertNull($result->getAdminLevels()->get(1)->getCode());
79-
$this->assertNull($result->getCountry()->getCode());
8080
$this->assertNull($result->getTimezone());
8181
}
8282

@@ -117,11 +117,11 @@ public function testReverseWithRealCoordinates()
117117
$this->assertEquals('Lancashire', $result->getAdminLevels()->get(2)->getName());
118118
$this->assertEquals('England', $result->getAdminLevels()->get(1)->getName());
119119
$this->assertEquals('GB', $result->getCountry()->getName());
120+
$this->assertEquals('GB', $result->getCountry()->getCode());
120121

121122
$this->assertFalse($result->getBounds()->isDefined());
122123
$this->assertNull($result->getStreetNumber());
123124
$this->assertNull($result->getAdminLevels()->get(1)->getCode());
124-
$this->assertNull($result->getCountry()->getCode());
125125
$this->assertNull($result->getTimezone());
126126
}
127127

@@ -147,6 +147,7 @@ public function testGeocodeWithCity()
147147
$this->assertEquals('Region Hannover', $result->getAdminLevels()->get(2)->getName());
148148
$this->assertEquals('Lower Saxony', $result->getAdminLevels()->get(1)->getName());
149149
$this->assertEquals('DE', $result->getCountry()->getName());
150+
$this->assertEquals('DE', $result->getCountry()->getCode());
150151

151152
/** @var \Geocoder\Model\Address $result */
152153
$result = $results->first();
@@ -158,6 +159,7 @@ public function testGeocodeWithCity()
158159
$this->assertEquals('Region Hannover', $result->getAdminLevels()->get(2)->getName());
159160
$this->assertEquals('Lower Saxony', $result->getAdminLevels()->get(1)->getName());
160161
$this->assertEquals('DE', $result->getCountry()->getName());
162+
$this->assertEquals('DE', $result->getCountry()->getCode());
161163

162164
/** @var \Geocoder\Model\Address $result */
163165
$result = $results->first();
@@ -169,6 +171,7 @@ public function testGeocodeWithCity()
169171
$this->assertEquals('Region Hannover', $result->getAdminLevels()->get(2)->getName());
170172
$this->assertEquals('Lower Saxony', $result->getAdminLevels()->get(1)->getName());
171173
$this->assertEquals('DE', $result->getCountry()->getName());
174+
$this->assertEquals('DE', $result->getCountry()->getCode());
172175

173176
/** @var \Geocoder\Model\Address $result */
174177
$result = $results->first();
@@ -180,6 +183,7 @@ public function testGeocodeWithCity()
180183
$this->assertEquals('Region Hannover', $result->getAdminLevels()->get(2)->getName());
181184
$this->assertEquals('Lower Saxony', $result->getAdminLevels()->get(1)->getName());
182185
$this->assertEquals('DE', $result->getCountry()->getName());
186+
$this->assertEquals('DE', $result->getCountry()->getCode());
183187
}
184188

185189
public function testGeocodeWithCityDistrict()
@@ -205,11 +209,11 @@ public function testGeocodeWithCityDistrict()
205209
$this->assertCount(1, $result->getAdminLevels());
206210
$this->assertEquals('Hesse', $result->getAdminLevels()->get(1)->getName());
207211
$this->assertEquals('DE', $result->getCountry()->getName());
212+
$this->assertEquals('DE', $result->getCountry()->getCode());
208213

209214
$this->assertFalse($result->getBounds()->isDefined());
210215
$this->assertNull($result->getStreetNumber());
211216
$this->assertNull($result->getAdminLevels()->get(1)->getCode());
212-
$this->assertNull($result->getCountry()->getCode());
213217
$this->assertNull($result->getTimezone());
214218
}
215219

0 commit comments

Comments
 (0)