Skip to content

Commit 55e6921

Browse files
author
Brian Chen
authored
Avoid protobuf equals (firebase#1920)
1 parent dc90128 commit 55e6921

File tree

1 file changed

+2
-2
lines changed
  • firebase-firestore/src/main/java/com/google/firebase/firestore/model

1 file changed

+2
-2
lines changed

firebase-firestore/src/main/java/com/google/firebase/firestore/model/Values.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public static boolean equals(Value left, Value right) {
120120
private static boolean numberEquals(Value left, Value right) {
121121
if (left.getValueTypeCase() == Value.ValueTypeCase.INTEGER_VALUE
122122
&& right.getValueTypeCase() == Value.ValueTypeCase.INTEGER_VALUE) {
123-
return left.equals(right);
123+
return left.getIntegerValue() == right.getIntegerValue();
124124
} else if (left.getValueTypeCase() == Value.ValueTypeCase.DOUBLE_VALUE
125125
&& right.getValueTypeCase() == Value.ValueTypeCase.DOUBLE_VALUE) {
126126
return Double.doubleToLongBits(left.getDoubleValue())
@@ -157,7 +157,7 @@ private static boolean objectEquals(Value left, Value right) {
157157

158158
for (Map.Entry<String, Value> entry : leftMap.getFieldsMap().entrySet()) {
159159
Value otherEntry = rightMap.getFieldsMap().get(entry.getKey());
160-
if (!entry.getValue().equals(otherEntry)) {
160+
if (!equals(entry.getValue(), otherEntry)) {
161161
return false;
162162
}
163163
}

0 commit comments

Comments
 (0)