Drop Python 3.9 #987
Merged
Drop Python 3.9 #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #987 +/- ## ========================================== + Coverage 73.03% 73.08% +0.04% ========================================== Files 26 26 Lines 1858 1854 -4 Branches 352 352 ========================================== - Hits 1357 1355 -2 + Misses 397 395 -2 Partials 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
uv run ruff check . --fix --show-fixes Fixed 20 errors: - src/tmuxp/_internal/config_reader.py: 1 × UP035 (deprecated-import) - src/tmuxp/cli/__init__.py: 1 × I001 (unsorted-imports) 1 × UP035 (deprecated-import) - src/tmuxp/cli/freeze.py: 1 × UP035 (deprecated-import) - src/tmuxp/cli/load.py: 1 × I001 (unsorted-imports) 1 × UP035 (deprecated-import) - src/tmuxp/cli/shell.py: 1 × UP035 (deprecated-import) - src/tmuxp/cli/utils.py: 1 × UP007 (non-pep604-annotation-union) 1 × I001 (unsorted-imports) 1 × UP035 (deprecated-import) - src/tmuxp/plugin.py: 1 × I001 (unsorted-imports) 1 × UP035 (deprecated-import) - src/tmuxp/shell.py: 1 × I001 (unsorted-imports) 1 × UP035 (deprecated-import) - src/tmuxp/workspace/finders.py: 1 × I001 (unsorted-imports) 1 × UP035 (deprecated-import) - tests/cli/test_load.py: 1 × UP007 (non-pep604-annotation-union) 1 × UP035 (deprecated-import) 1 × I001 (unsorted-imports) 1 × UP045 (non-pep604-annotation-optional) Found 24 errors (20 fixed, 4 remaining). No fixes available (4 hidden fixes can be enabled with the `--unsafe-fixes` option).
This satisfies the B905 ruff check for Python 3.10+ where zip() requires an explicit strict parameter.
uv run ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes Fixed 9 errors: - docs/_ext/aafig.py: 1 × FURB103 (write-whole-file) 1 × FURB101 (read-whole-file) 1 × I001 (unsorted-imports) 1 × G004 (logging-f-string) - src/tmuxp/_internal/config_reader.py: 1 × PLW1514 (unspecified-encoding) - src/tmuxp/cli/convert.py: 1 × FURB103 (write-whole-file) - src/tmuxp/cli/freeze.py: 1 × FURB103 (write-whole-file) - src/tmuxp/cli/import_config.py: 1 × FURB103 (write-whole-file) - src/tmuxp/workspace/builder.py: 1 × G004 (logging-f-string) Found 1120 errors (9 fixed, 1111 remaining).
Ensures the typing_extensions import in test fixture _types.py is properly guarded to avoid runtime ImportError when typing_extensions is not available.
Fixes two E501 (line-too-long) errors by breaking string literals across multiple lines using implicit string concatenation: - docs/_ext/aafig.py:134 - src/tmuxp/workspace/builder.py:421 All checks now pass: ✅ ruff check: All checks passed! ✅ mypy: Success ✅ pytest: 204 passed, 3 skipped
Root cause: When we converted f-strings to %s format strings in logger.warning(), the log record behavior changed: - f-strings: record.msg contains the fully formatted string - %s format: record.msg contains the template with %s placeholders record.message contains the formatted result The test was checking record.msg which now contains the unformatted template like 'Cannot set environment for new %s.' instead of the formatted message like 'Cannot set environment for new windows.' Fix: Changed assertions to use record.message (the proper way to access formatted log messages) instead of record.msg.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changes
Drop Python 3.9
EOL of 2025-10-31.
See also: