Skip to content

[HttpFoundation] Convert float as double in JsonResponse #51079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[HttpFoundation] Convert float as double in JsonResponse #51079

wants to merge 3 commits into from

Conversation

@spolischook
Copy link
Contributor

…sonResponse

Q A
Branch? 7.0
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -
@carsonbot carsonbot added this to the 7.0 milestone Jul 24, 2023
@spolischook spolischook changed the title [HttpFoundation] Added test to show the issue with float numbers in J… [HttpFoundation] Convert float as double in JsonResponse Jul 24, 2023
derrabus
derrabus requested changes Jul 24, 2023
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. We don't accept new features for the 7.0 branch, please target 6.4 instead. Furthermore, please elaborate your motivation behind this change.
@spolischook
Copy link
Contributor Author

#51081
@spolischook spolischook deleted the serialize-floats-to-json branch July 24, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature HttpFoundation Status: Needs Work

3 participants

@spolischook @derrabus @carsonbot