Skip to content

Use Memcache::replace() first instead of Memcache::set(): #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use Memcache::replace() first instead of Memcache::set(): #5

wants to merge 1 commit into from

Conversation

@till
Copy link
Contributor

@till till commented Apr 16, 2012

Using Memcache::set() in a multi-server environment can yield unexpected results:
http://docs.php.net/manual/en/memcache.replace.php#100023

It's best to attempt replace() first and only use set() if the key does not exist.
@Tobion
Copy link
Contributor

Tobion commented Apr 17, 2012

This repo is a read-only subtree split. Please reopen your PR on symfony/symfony
@till
Copy link
Contributor Author

till commented Apr 17, 2012

Alright.
@till till closed this Apr 17, 2012
@fabpot
Copy link
Member

fabpot commented Apr 18, 2012

I've applied the patch on symfony/symfony (symfony/symfony#962f9), thanks.
@till
Copy link
Contributor Author

till commented Apr 18, 2012

Thanks! I'll fork the correct repo next time!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@till @Tobion @fabpot