enable monitoring only if requested, fix when definition

Author: stdevel

README.md

@@ -51,7 +51,7 @@ The system needs access to the internet. Also, you will need an openSUSE Leap 15
 | `uyuni_defs_setup` | `false` | Flag whether errata for Debian should be generated via [DEFS](https://defs.steve-meier.de/) |
 | `uyuni_defs_setup_cronjob` | `false` | Flag whether DEFS cronjob should be generated |
 | `uyuni_cefs_path` | `/opt/errata-import` | Path to install CEFS and the wrapper script to |
-| `uyuni_channels`| *empty* | Common channels to synchronize (*e.g. ``centos7`` and ``epel7``*) |
+| `uyuni_channels`| *empty* | Common channels to synchronize (*e.g. `centos7` and `epel7`*) |
 | `uyuni_sync_channels` | `false` | Flag whether created channels should be synced |
 | `uyuni_bootstrap_repos` | `false` | Flag whether Salt bootstrap repositories should be created |
 | `uyuni_enable_monitoring` | `false` | Flag whether integrated monitoring stack should be enabled |

tasks/main.yml

@@ -19,3 +19,4 @@
 
 - include_tasks: monitoring.yml
  tags: monitoring
+ when: uyuni_enable_monitoring | bool

tasks/monitoring.yml

@@ -3,7 +3,6 @@
  zypper:
  name: "{{ uyuni_monitoring_packages }}"
  become: true
- when: uyuni_enable_monitoring
 
 - name: Install monitoring Salt formulas
  become: true
@@ -22,7 +21,7 @@
  command: mgr-monitoring-ctl enable
  # args:
  # creates: /usr/lib/systemd/system/tomcat.service.d/jmx.conf
- when: "'error' in monitoring_state.stdout|lower"
+ when: "'error' in monitoring_state.stderr|lower"
  notify: Restart Uyuni
 
 # TODO: enable monitoring in UI?