Skip to content

Support ClickHouse in BuiltInBindMarkersFactoryProvider #33947

New issue
New issue
Closed as not planned
Closed as not planned
Support ClickHouse in BuiltInBindMarkersFactoryProvider#33947
Assignees
sdeleuze
Labels
in: dataIssues in data modules (jdbc, orm, oxm, tx)status: declinedA suggestion or change that we don't feel we should currently apply
@eddumelendez

Description

@eddumelendez
eddumelendez
opened on Nov 22, 2024

ClickHouse provides an r2dbc driver. Building a project with Testcontainers fails because of the following exception:

Caused by: org.springframework.r2dbc.core.binding.BindMarkersFactoryResolver$NoBindMarkersFactoryException: Cannot determine a BindMarkersFactory for ClickHouse using ConnectionPool[ClickHouse]

Add ClickHouse to the list

spring-framework/spring-r2dbc/src/main/java/org/springframework/r2dbc/core/binding/BindMarkersFactoryResolver.java

Lines 119 to 128 in 5e08a88

static {
BUILTIN.put("H2", BindMarkersFactory.indexed("$", 1));
BUILTIN.put("MariaDB", BindMarkersFactory.anonymous("?"));
BUILTIN.put("Microsoft SQL Server", BindMarkersFactory.named("@", "P", 32,
BuiltInBindMarkersFactoryProvider::filterBindMarker));
BUILTIN.put("MySQL", BindMarkersFactory.anonymous("?"));
BUILTIN.put("Oracle", BindMarkersFactory.named(":", "P", 32,
BuiltInBindMarkersFactoryProvider::filterBindMarker));
BUILTIN.put("PostgreSQL", BindMarkersFactory.indexed("$", 1));
}

My workaround was to created my own provider and register it in spring.factories but it fails because it also needs to support the ClickHouse dialect in spring-data-r2dbc.

Metadata

Metadata

Assignees

Labels

in: dataIssues in data modules (jdbc, orm, oxm, tx)status: declinedA suggestion or change that we don't feel we should currently apply

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions