Fix issue with sampling without replacement #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Before this fix uniform sampling is not guaranteed, over-representing the first combination of neighbors, and not sampling the last possible combination Co-authored-by: Jaime Mosquera Gutiérrez <Jaimemosg@users.noreply.github.com> Co-authored-by: Andres Uriza <pa-uriza@users.noreply.github.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@ ## master #386 +/- ## ======================================= Coverage 73.09% 73.09% ======================================= Files 29 29 Lines 1171 1171 ======================================= Hits 856 856 Misses 315 315 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| This pull request had no activity for 6 months. It will be closed in 2 weeks unless there is some new activity. |
Author
| We believe this is still relevant. @rusty1s let us know if you have any thoughts on this |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Before this fix uniform sampling is not guaranteed, over-representing the first combination of neighbors, and not sampling the last possible combination.
This PR ensures all neighbor combinations are considered during sampling, by extending the range of possible indices to include the last element.
Referencing to the example showcased in #385, using this change the sampling distribution is now:
Closes #385.