minor symfony#50185 [HttpClient][HttpFoundation][HttpKernel][Ldap][Mailer][Mime][Process][Routing][Security][Serializer][Translation][Validator] Add missing return types (wouterj)

This PR was merged into the 6.3 branch. Discussion ---------- [HttpClient][HttpFoundation][HttpKernel][Ldap][Mailer][Mime][Process][Routing][Security][Serializer][Translation][Validator] Add missing return types | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | Ref symfony#47551 | License | MIT | Doc PR | - Last one, for the components. Only some bundle methods are missing now. Commits ------- f86dbbd Add missing return types

Author: nicolas-grekas

.github/expected-missing-return-types.diff

@@ -32,7 +32,7 @@ class StreamWrapper
  /** @var resource|string|null */
  private $content;
 
- /** @var resource|null */
+ /** @var resource|callable|null */
  private $handle;
 
  private bool $blocking = true;
@@ -266,6 +266,9 @@ public function stream_seek(int $offset, int $whence = \SEEK_SET): bool
  return false;
  }
 
+ /**
+ * @return resource|false
+ */
  public function stream_cast(int $castAs)
  {
  if (\STREAM_CAST_FOR_SELECT === $castAs) {

src/Symfony/Component/HttpClient/Response/StreamWrapper.php

@@ -1732,6 +1732,9 @@ public function preferSafeContent(): bool
  * Copyright (c) 2005-2010 Zend Technologies USA Inc. (https://www.zend.com/)
  */
 
+ /**
+ * @return string
+ */
  protected function prepareRequestUri()
  {
  $requestUri = '';

src/Symfony/Component/HttpFoundation/Request.php

@@ -34,6 +34,8 @@ final public function load(array $configs, ContainerBuilder $container): void
 
  /**
  * Configures the passed container according to the merged configuration.
+ *
+ * @return void
  */
  abstract protected function loadInternal(array $mergedConfig, ContainerBuilder $container);
 }

src/Symfony/Component/HttpKernel/DependencyInjection/ConfigurableExtension.php

@@ -167,7 +167,7 @@ protected function loadUser(string $identifier, Entry $entry): UserInterface
  return new LdapUser($entry, $identifier, $password, $this->defaultRoles, $extraFields);
  }
 
- private function getAttributeValue(Entry $entry, string $attribute)
+ private function getAttributeValue(Entry $entry, string $attribute): mixed
  {
  if (!$entry->hasAttribute($attribute)) {
  throw new InvalidArgumentException(sprintf('Missing attribute "%s" for user "%s".', $attribute, $entry->getDn()));

src/Symfony/Component/Ldap/Security/LdapUserProvider.php

@@ -199,7 +199,7 @@ private function getEndpoint(): ?string
  return ($this->host ?: self::HOST).($this->port ? ':'.$this->port : '');
  }
 
- private function castCustomHeader(string $value, string $type)
+ private function castCustomHeader(string $value, string $type): mixed
  {
  return match ($type) {
  'bool' => filter_var($value, \FILTER_VALIDATE_BOOL),

src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php

@@ -396,6 +396,9 @@ public function getBody(): AbstractPart
  return $this->generateBody();
  }
 
+ /**
+ * @return void
+ */
  public function ensureValidity()
  {
  $this->ensureBodyValid();

src/Symfony/Component/Mime/Email.php

@@ -47,6 +47,9 @@ public function __construct(Process $process)
  $this->process = $process;
  }
 
+ /**
+ * @return Process
+ */
  public function getProcess()
  {
  return $this->process;

src/Symfony/Component/Process/Exception/ProcessFailedException.php

@@ -38,6 +38,9 @@ public function __construct(Process $process, int $timeoutType)
  ));
  }
 
+ /**
+ * @return Process
+ */
  public function getProcess()
  {
  return $this->process;
@@ -59,7 +62,7 @@ public function isIdleTimeout()
  return self::TYPE_IDLE === $this->timeoutType;
  }
 
- public function getExceededTimeout()
+ public function getExceededTimeout(): ?float
  {
  return match ($this->timeoutType) {
  self::TYPE_GENERAL => $this->process->getTimeout(),

src/Symfony/Component/Process/Exception/ProcessTimedOutException.php

@@ -285,6 +285,8 @@ public function mustRun(callable $callback = null, array $env = []): static
  * @param callable|null $callback A PHP callback to run whenever there is some
  * output available on STDOUT or STDERR
  *
+ * @return void
+ *
  * @throws RuntimeException When process can't be launched
  * @throws RuntimeException When process is already running
  * @throws LogicException In case a callback is provided and output has been disabled
@@ -1140,6 +1142,8 @@ public function setInput(mixed $input): static
  * In case you run a background process (with the start method), you should
  * trigger this method regularly to ensure the process timeout
  *
+ * @return void
+ *
  * @throws ProcessTimedOutException In case the timeout was reached
  */
  public function checkTimeout()
@@ -1180,6 +1184,8 @@ public function getStartTime(): float
  *
  * Enabling the "create_new_console" option allows a subprocess to continue
  * to run after the main process exited, on both Windows and *nix
+ *
+ * @return void
  */
  public function setOptions(array $options)
  {
@@ -1275,6 +1281,8 @@ protected function buildCallback(callable $callback = null): \Closure
  * Updates the status of the process, reads pipes.
  *
  * @param bool $blocking Whether to use a blocking read call
+ *
+ * @return void
  */
  protected function updateStatus(bool $blocking)
  {
@@ -1323,7 +1331,7 @@ protected function isSigchildEnabled(): bool
  *
  * @throws LogicException in case output has been disabled or process is not started
  */
- private function readPipesForOutput(string $caller, bool $blocking = false)
+ private function readPipesForOutput(string $caller, bool $blocking = false): void
  {
  if ($this->outputDisabled) {
  throw new LogicException('Output has been disabled.');
@@ -1358,7 +1366,7 @@ private function validateTimeout(?float $timeout): ?float
  * @param bool $blocking Whether to use blocking calls or not
  * @param bool $close Whether to close file handles or not
  */
- private function readPipes(bool $blocking, bool $close)
+ private function readPipes(bool $blocking, bool $close): void
  {
  $result = $this->processPipes->readAndWrite($blocking, $close);
 
@@ -1407,7 +1415,7 @@ private function close(): int
  /**
  * Resets data related to the latest run of the process.
  */
- private function resetProcessData()
+ private function resetProcessData(): void
  {
  $this->starttime = null;
  $this->callback = null;
@@ -1528,7 +1536,7 @@ function ($m) use (&$env, $uid) {
  *
  * @throws LogicException if the process has not run
  */
- private function requireProcessIsStarted(string $functionName)
+ private function requireProcessIsStarted(string $functionName): void
  {
  if (!$this->isStarted()) {
  throw new LogicException(sprintf('Process must be started before calling "%s()".', $functionName));
@@ -1540,7 +1548,7 @@ private function requireProcessIsStarted(string $functionName)
  *
  * @throws LogicException if the process is not yet terminated
  */
- private function requireProcessIsTerminated(string $functionName)
+ private function requireProcessIsTerminated(string $functionName): void
  {
  if (!$this->isTerminated()) {
  throw new LogicException(sprintf('Process must be terminated before calling "%s()".', $functionName));