Skip to content

Delete package-lock.json #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Delete package-lock.json #20

wants to merge 1 commit into from
+0 −6,080

Conversation

@bcomnes
Copy link
Collaborator

@bcomnes bcomnes commented Jul 14, 2019

This tiny library doesn't benefit from a lock file (consumers don't ever see it), and its triggering security alerts. Lets rely on the semver range defined in package.json.
@bcomnes
Delete package-lock.json
233130c 
This tiny library doesn't benefit from a lock file (consumers don't ever see it), and its triggering security alerts. Lets rely on the semver range defined in package.json.
@coveralls
Copy link

coveralls commented Jul 14, 2019

Pull Request Test Coverage Report for Build 76

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-22.4%) to 63.354%
Files with Coverage Reduction New Missed Lines %
lib/url.js 5 66.67%
index.js 11 61.48%
Totals Coverage Status
Change from base Build 74: -22.4%
Covered Lines: 66
Relevant Lines: 87
💛 - Coveralls
1 similar comment
@coveralls
Copy link

coveralls commented Jul 14, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 76

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-22.4%) to 63.354%
Files with Coverage Reduction New Missed Lines %
lib/url.js 5 66.67%
index.js 11 61.48%
Totals Coverage Status
Change from base Build 74: -22.4%
Covered Lines: 66
Relevant Lines: 87
💛 - Coveralls
@bcomnes
Copy link
Collaborator Author

bcomnes commented Jul 14, 2019

Hrmm. Looks like test arn't passing.
@bcomnes
Copy link
Collaborator Author

bcomnes commented Dec 3, 2019

Done elsewhere.
@bcomnes bcomnes closed this Dec 3, 2019
@bcomnes bcomnes deleted the bcomnes-patch-2 branch December 3, 2019 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@bcomnes @coveralls