Skip to content

BUG: Offsets of offsets in holiday raise type error during usage #57921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

BUG: Offsets of offsets in holiday raise type error during usage #57921

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7bee907
support offsets of offsets in holiday creation
dontgoto Mar 19, 2024
aaa781f
update whatsnew
dontgoto Mar 19, 2024
0cf929e
add type annotations
dontgoto Mar 19, 2024
8a9a4b6
update type annotation
dontgoto Mar 20, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update whatsnew
  • Loading branch information
@dontgoto
dontgoto committed Mar 19, 2024
commit aaa781f86fc87b494a6ce1f7fc4090e9f72829ef
1 change: 1 addition & 0 deletions doc/source/whatsnew/v3.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ Performance improvements

Bug fixes
~~~~~~~~~
- Fixed bug in :class:`Series.Holiday` that leads to a ``TypeError`` when using ``Holiday.dates`` with a ``Holiday`` that is initialized with ``offset`` of type ``list`` which itself references another Holiday's list of offsets. (:issue:`29049`)
- Fixed bug in :class:`SparseDtype` for equal comparison with na fill value. (:issue:`54770`)
- Fixed bug in :meth:`DataFrame.join` inconsistently setting result index name (:issue:`55815`)
- Fixed bug in :meth:`DataFrame.to_string` that raised ``StopIteration`` with nested DataFrames. (:issue:`16098`)
Expand Down