Skip to content

Commit f23c876

Browse files
committed
Fixed issue with letters in streetNumber value, fixes geocoder-php#73
1 parent 5b8d66e commit f23c876

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

src/Geocoder/Result/Geocoded.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class Geocoded implements ResultInterface, \ArrayAccess
3131
protected $bounds = null;
3232

3333
/**
34-
* @var int
34+
* @var string|int
3535
*/
3636
protected $streetNumber = null;
3737

@@ -199,7 +199,7 @@ public function fromArray(array $data = array())
199199
);
200200
}
201201
if (isset($data['streetNumber'])) {
202-
$this->streetNumber = (int) $data['streetNumber'];
202+
$this->streetNumber = (string) $data['streetNumber'];
203203
}
204204
if (isset($data['streetName'])) {
205205
$this->streetName = $this->formatString($data['streetName']);

src/Geocoder/Result/ResultInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ function getBounds();
5555
/**
5656
* Returns the street number value.
5757
*
58-
* @return int
58+
* @return string|int
5959
*/
6060
function getStreetNumber();
6161

tests/Geocoder/Tests/Result/GeocodedTest.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,4 +220,14 @@ public function testFromArrayWithAccents()
220220
$this->assertEquals('Midi-Pyrénées', $this->geocoded->getRegion());
221221
$this->assertEquals('France', $this->geocoded->getCountry());
222222
}
223+
224+
public function testFromArrayWithLettersInStreetNumber()
225+
{
226+
$array = array(
227+
'streetNumber' => '1A'
228+
);
229+
230+
$this->geocoded->fromArray($array);
231+
$this->assertEquals('1A', $this->geocoded->getStreetNumber());
232+
}
223233
}

0 commit comments

Comments
 (0)