Type checking

Author: mana-ysh

Makefile

@@ -19,11 +19,7 @@ ci: typecheck test lint
 
 typecheck:
 @echo check types
-mypy ./ \
---disallow-untyped-defs \
---disallow-any-expr \
---no-implicit-optional \
---no-site-packages \
+mypy ./python_api_template
 
 lint:
 @echo check style
@@ -37,9 +33,6 @@ test:
 ##### application
 GUNICORN_CONFIG_PATH := config/gunicorn.py
 
-install:
-poetry install
-
 launch:
 gunicorn app:app -c ${GUNICORN_CONFIG_PATH}
 

mypy.ini

@@ -0,0 +1,10 @@
+# Global options:
+
+[mypy]
+python_version = 3.7
+disallow_untyped_defs = True
+no_implicit_optional = True
+
+# Per-module options:
+[tests/*]
+ignore_errors = True

python_api_template/controller.py

@@ -1,33 +1,34 @@
 
 from flask import Blueprint, Flask, jsonify
+from flask.wrappers import Response
 
 
 dummy = Blueprint('dummy', __name__)
 api = Blueprint('api', __name__)
 
 
 @dummy.route('/', methods=["GET"])
-def dummy_home():
+def dummy_home() -> Response:
  return jsonify({
  "msg": "hello {}".format(dummy.name)
  })
 
 
 @api.route('/', methods=["GET"])
-def api_home():
+def api_home() -> Response:
  return jsonify({
  "msg": "hey {}".format(api.name)
  })
 
 
-def create_app(env=None):
+def create_app() -> Flask:
  app = Flask(__name__)
  app.url_map.strict_slashes = False
  app.register_blueprint(dummy, url_prefix='/dummy')
  app.register_blueprint(api, url_prefix='/api')
 
  @app.route("/health")
- def health():
+ def health() -> Response:
  return jsonify({
  "msg": "I'm healthy"
  })