Autocomplete: Fix bad behaviour on TAB press #717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Do not select anything when TAB is pressed. This is really annoying if your mouse pointer happens to be where the suggestions pop up and some arbitrary element is focused just because it happened to be where your mouse pointer was.
Member
| This needs more discussion. The Awesome Bar treats TAB the same as DOWN. |
Member
| Actually, Firefox and Chrome both have the exact same behavior for native autocomplete (I didn't test any other browsers). I don't see a reason to change this. |
Author
| Well, just because the behaviour is broken there, doesn't mean that jquery-ui shouldn't do it right. |
Member
| There needs to be a solid case made that jQuery UI is doing it wrong in the first place. I'm sure the biggest annoyance for this comes from a bug that has already been fixed where the mouse would highlight a term when the menu is shown even if the mouse hasn't been moved. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Do not select anything when TAB is pressed. This is really annoying if your mouse pointer happens to be where the suggestions pop up and some arbitrary element is focused just because it happened to be where your mouse pointer was.
See also:
http://stackoverflow.com/questions/9624773/jquery-autocomplete-mouse-below-text-box-a-causes-selection-after-menu-is-show
http://stackoverflow.com/questions/9672918/jquery-autocomplete-when-mouse-is-below-text-input-your-text-is-replaced-as-y
This commit only fixes the TAB Key, but the basic problem is the same.