ci: Implemented formatting check in CI (#178)

* Fix react typings * Implemented formatting check in CI * Moved Formatting check * Formatted repo * Fix formatting * Fix formatting * Used ci instead of just biome * Updated spaces * Update package.json Co-authored-by: Hassan Bahati <mukisabahati@gmail.com> * Updated workflow * format: Reformat merge --------- Co-authored-by: Hassan Bahati <mukisabahati@gmail.com> Co-authored-by: Elliot Hesp <elliot.hesp@gmail.com>

Author: 3 people

.github/workflows/tests.yaml

@@ -32,7 +32,8 @@ jobs:
  # Install all dependencies at the root
  - name: Install dependencies (pnpm)
  run: pnpm install
-
+ - name: Check formatting
+ run: pnpm format:ci
  - name: Start Firebase Emulator Suite
  uses: invertase/firebase-emulator-action@v1.0.1
  with:
@@ -42,6 +43,7 @@ jobs:
  run: |
  curl --silent http://localhost:4400/emulators | jq 'keys[]'
 
+
  # Determine which packages have changed
  - name: Determine changed packages
  id: changes

package.json

@@ -6,7 +6,8 @@
  "serve:coverage": "npx serve coverage",
  "emulator": "firebase emulators:start --project test-project",
  "emulator:kill": "lsof -t -i:4001 -i:8080 -i:9000 -i:9099 -i:9199 -i:8085 | xargs kill -9",
- "check": "pnpm biome check --write ./packages/react/src ./packages/angular/src"
+ "format:ci": "pnpm biome ci ./packages/react/src ./packages/angular/src",
+ "format": "pnpm biome check --write ./packages/react/src ./packages/angular/src"
  },
  "devDependencies": {
  "@angular/core": "^19.1.8",

packages/angular/src/data-connect/index.ts

@@ -1,30 +1,30 @@
 import {
  type CreateMutationOptions,
  type CreateQueryOptions,
- injectMutation,
- injectQuery,
  QueryClient,
  type QueryKey,
+ injectMutation,
+ injectQuery,
 } from "@tanstack/angular-query-experimental";
 
 import type { FirebaseError } from "firebase/app";
 
 import {
  EnvironmentInjector,
- inject,
  type Injector,
+ inject,
  signal,
 } from "@angular/core";
 import {
  type CallerSdkType,
  CallerSdkTypeEnum,
  DataConnect,
- executeMutation,
- executeQuery,
  type MutationRef,
  type MutationResult,
  type QueryRef,
  type QueryResult,
+ executeMutation,
+ executeQuery,
 } from "@angular/fire/data-connect";
 import type {
  CreateDataConnectMutationResult,
@@ -56,7 +56,7 @@ export function injectDataConnectQuery<Data, Variables>(
  | QueryRef<Data, Variables>
  | (() => CreateDataConnectQueryOptions<Data, Variables>),
  injector?: Injector,
- _callerSdkType: CallerSdkType = CallerSdkTypeEnum.TanstackAngularCore
+ _callerSdkType: CallerSdkType = CallerSdkTypeEnum.TanstackAngularCore,
 ): CreateDataConnectQueryResult<Data, Variables> {
  const dataConnectResult = signal<
  Partial<QueryResult<Data, Variables>> | undefined
@@ -98,7 +98,7 @@ export function injectDataConnectQuery<Data, Variables>(
 
 export type GeneratedSignature<Data, Variables> = (
  dc: DataConnect,
- vars: Variables
+ vars: Variables,
 ) => MutationRef<Data, Variables>;
 export type DataConnectMutationOptionsFn<Data, Error, Variables, Arguments> =
  () => Omit<CreateMutationOptions<Data, Error, Arguments>, "mutationFn"> & {
@@ -109,7 +109,7 @@ export type DataConnectMutationOptionsFn<Data, Error, Variables, Arguments> =
 export type DataConnectMutationOptionsUndefinedMutationFn<
  Data,
  Error,
- Variables
+ Variables,
 > = () => Omit<
  ReturnType<DataConnectMutationOptionsFn<Data, Error, Variables, Variables>>,
  "mutationFn"
@@ -123,56 +123,56 @@ export function injectDataConnectMutation<Data, Variables, Arguments>(
  FirebaseError,
  Variables,
  Arguments
- >
+ >,
 ): CreateDataConnectMutationResult<Data, FirebaseError, Arguments>;
 export function injectDataConnectMutation<
  Data,
  Variables,
- Arguments = void | undefined
+ Arguments = void | undefined,
 >(
  factoryFn: EmptyFactoryFn<Data, Variables>,
  options?: DataConnectMutationOptionsUndefinedMutationFn<
  Data,
  FirebaseError,
  Variables
- >
+ >,
 ): CreateDataConnectMutationResult<Data, FirebaseError, Arguments>;
 
 export function injectDataConnectMutation<
  Data,
  Variables extends undefined,
- Arguments = void | undefined
+ Arguments = void | undefined,
 >(
  factoryFn: EmptyFactoryFn<Data, Variables>,
  options?: DataConnectMutationOptionsUndefinedMutationFn<
  Data,
  FirebaseError,
  Variables
- >
+ >,
 ): CreateDataConnectMutationResult<Data, FirebaseError, Arguments>;
 export function injectDataConnectMutation<
  Data,
  Variables extends undefined,
- Arguments = Variables
+ Arguments = Variables,
 >(
  factoryFn: GeneratedSignature<Data, Variables>,
  optionsFn?: DataConnectMutationOptionsUndefinedMutationFn<
  Data,
  FirebaseError,
  Arguments
- >
+ >,
 ): CreateDataConnectMutationResult<Data, FirebaseError, Arguments>;
 export function injectDataConnectMutation<
  Data,
  Variables,
- Arguments extends Variables
+ Arguments extends Variables,
 >(
  factoryFn: GeneratedSignature<Data, Variables>,
  optionsFn?: DataConnectMutationOptionsUndefinedMutationFn<
  Data,
  FirebaseError,
  Arguments
- >
+ >,
 ): CreateDataConnectMutationResult<Data, FirebaseError, Arguments>;
 /**
  * injectDataConnectMutation takes a mutation ref factory function and returns a tanstack wrapper around `injectMutation`
@@ -184,7 +184,7 @@ export function injectDataConnectMutation<
 export function injectDataConnectMutation<
  Data,
  Variables,
- Arguments extends Variables
+ Arguments extends Variables,
 >(
  factoryFn:
  | GeneratedSignature<Data, Variables>
@@ -199,7 +199,7 @@ export function injectDataConnectMutation<
  Variables
  >,
  injector?: Injector,
- _callerSdkType: CallerSdkType = CallerSdkTypeEnum.TanstackAngularCore
+ _callerSdkType: CallerSdkType = CallerSdkTypeEnum.TanstackAngularCore,
 ): CreateDataConnectMutationResult<Data, Variables, Arguments> {
  const finalInjector = injector || inject(EnvironmentInjector);
  const dataConnect = finalInjector.get(DataConnect);
@@ -256,5 +256,3 @@ export function injectDataConnectMutation<
  dataConnectResult,
  };
 }
-
-export type { CreateDataConnectMutationResult, CreateDataConnectQueryResult } from './types';