Skip to content

Commit e7570d8

Browse files
committed
To better name of variables in actionList
1 parent cbec7e4 commit e7570d8

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

src/controllers/ItemController.php

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
<?php
22
namespace githubjeka\rbac\controllers;
33

4+
use githubjeka\rbac\models\ItemForm;
5+
use Yii;
46
use yii\filters\ContentNegotiator;
57
use yii\filters\VerbFilter;
8+
use yii\helpers\ArrayHelper;
9+
use yii\rbac\Item;
610
use yii\web\Controller;
7-
use Yii;
8-
use githubjeka\rbac\models\ItemForm;
911
use yii\web\HttpException;
10-
use yii\helpers\ArrayHelper;
1112
use yii\web\Response;
1213

1314
/**
@@ -45,19 +46,22 @@ public function behaviors()
4546
*/
4647
public function actionList()
4748
{
48-
$roles = Yii::$app->authManager->getRoles();
49-
$permissions = Yii::$app->authManager->getPermissions();
49+
$authManager = Yii::$app->authManager;
50+
$roles = $authManager->getRoles();
51+
$permissions = $authManager->getPermissions();
5052

5153
$items = ArrayHelper::merge($roles, $permissions);
54+
$namesItems = array_keys($items);
5255

5356
$links = [];
5457

55-
$_keys = array_keys($items);
56-
foreach ($items as $np => $oP) {
57-
foreach ($c = Yii::$app->authManager->getChildren($np) as $nC => $oC) {
58+
foreach ($items as $nameItem => $item) {
59+
$children = $authManager->getChildren($nameItem);
60+
61+
foreach ($children as $nameChild => $child) {
5862
$links[] = [
59-
'source' => array_search($np, $_keys),
60-
'target' => array_search($nC, $_keys),
63+
'source' => array_search($nameItem, $namesItems),
64+
'target' => array_search($nameChild, $namesItems),
6165
];
6266
}
6367
}

0 commit comments

Comments
 (0)