Skip to content

Make all Storage APIs available via Swift #9443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 17, 2022
Merged

Make all Storage APIs available via Swift #9443

merged 7 commits into from
Mar 17, 2022

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Mar 12, 2022 •
edited
Loading

  • All Storage APIs available via Swift
  • Component model moved to Swift
  • Objective C API coverage tests added
  • Public API typedefs are kept only for Objective C and CocoaPods via an additional Objective C public header
  • APIs that previously returned StorageHandle now return String
  • API doc type references are updated from Objective C to Swift

TODO:

  • migrate component unit tests to Swift
  • implement previously auto-generated async/await APIs
  • API review
  • Release Notes
  • umbrella header
@paulb777 paulb777 marked this pull request as draft March 12, 2022 19:11
@google-oss-bot
Copy link

google-oss-bot commented Mar 12, 2022 •
edited
Loading

Danger has errored

[!] Invalid Dangerfile file: POST https://api.github.com/repos/firebase/firebase-ios-sdk/issues/9443/labels: 500 - . Updating the Danger gem might fix the issue. Your Danger version: 6.1.0, latest Danger version: 8.4.5

 # from Dangerfile:31 # ------------------------------------------- # repo_name = "firebase/firebase-ios-sdk" > github.api.add_labels_to_an_issue(repo_name, issue_number, label_array) # end # -------------------------------------------

Generated by 🚫 Danger

@paulb777 paulb777 force-pushed the pb-storage-objc-coverage branch 2 times, most recently from 985ce9f to 59675d9 Compare March 12, 2022 22:28
@paulb777 paulb777 force-pushed the pb-storage-objc-coverage branch from 59675d9 to 31c3d8a Compare March 12, 2022 22:40
@paulb777 paulb777 marked this pull request as ready for review March 13, 2022 18:45
@paulb777 paulb777 requested review from ncooke3 and ryanwilson March 14, 2022 16:18
ncooke3
ncooke3 reviewed Mar 16, 2022
View reviewed changes
@paulb777 @ncooke3
Update FirebaseStorage.podspec
c30f761 
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
paulb777
paulb777 commented Mar 17, 2022
View reviewed changes
FirebaseCombineSwift/Tests/Unit/FirebaseCombine-unit-Bridging-Header.h
#import "SharedTestUtilities/FIRComponentTestUtilities.h"
#import "SharedTestUtilities/FIROptionsMock.h"

// Firebase Storage
Copy link
Member Author

@paulb777 paulb777 Mar 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer accessible, but tests still pass without it.
@paulb777 paulb777 force-pushed the pb-storage-objc-coverage branch from e899c38 to 1a546ad Compare March 17, 2022 14:31
@paulb777
Copy link
Member Author

paulb777 commented Mar 17, 2022

I'm going to merge this here into storage-v9 to make the follow up task PRs more manageable. Feel free to continue to review here or in the storage-v9 umbrella PR - #9355 and I'll address.
@paulb777 paulb777 merged commit 237f17d into storage-v9 Mar 17, 2022
@paulb777 paulb777 deleted the pb-storage-objc-coverage branch March 17, 2022 23:00
paulb777 added a commit that referenced this pull request Mar 17, 2022
@paulb777
Make all Storage APIs available via Swift (#9443)
aac28e7
@paulb777 paulb777 mentioned this pull request Mar 17, 2022
Merged
paulb777 added a commit that referenced this pull request Mar 20, 2022
@paulb777
Make all Storage APIs available via Swift (#9443)
c7c08f1
paulb777 added a commit that referenced this pull request Mar 21, 2022
@paulb777
Make all Storage APIs available via Swift (#9443)
c8e3ecd
paulb777 added a commit that referenced this pull request Mar 23, 2022
@paulb777
Make all Storage APIs available via Swift (#9443)
cf9b2b8
paulb777 added a commit that referenced this pull request Mar 23, 2022
@paulb777
Make all Storage APIs available via Swift (#9443)
1d6e364
paulb777 added a commit that referenced this pull request Mar 30, 2022
@paulb777
Make all Storage APIs available via Swift (#9443)
80981dc
paulb777 added a commit that referenced this pull request Mar 30, 2022
@paulb777
Make all Storage APIs available via Swift (#9443)
14f0bac
paulb777 added a commit that referenced this pull request Apr 4, 2022
@paulb777
Make all Storage APIs available via Swift (#9443)
1ed4d69
paulb777 added a commit that referenced this pull request Apr 4, 2022
@paulb777
Make all Storage APIs available via Swift (#9443)
f8b3415
@firebase firebase locked and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: appcheck api: auth api: core api: messaging api: storage public-api-change

3 participants

@paulb777 @google-oss-bot @ncooke3