Skip to content

Commit 985ce9f

Browse files
committed
fixes
1 parent 79c3cf2 commit 985ce9f

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

.github/workflows/storage.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,17 +108,17 @@ jobs:
108108
# Don't run on private repo unless it is a PR.
109109
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
110110
runs-on: macos-11
111-
112111
strategy:
113112
matrix:
114113
target: [ios, tvos, macos, watchos]
114+
podspec: [Storage, StorageObjC]
115115
steps:
116116
- uses: actions/checkout@v2
117117
- name: Setup Bundler
118118
run: scripts/setup_bundler.sh
119119
- name: Build and test
120120
run: |
121-
scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseStorage.podspec --test-specs=unit --platforms=${{ matrix.target }}
121+
scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb Firebase${{ matrix.podspec }}.podspec --test-specs=unit --platforms=${{ matrix.target }}
122122
123123
storage-cron-only:
124124
# Don't run on private repo.

Example/watchOSSample/Podfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,16 @@ target 'SampleWatchAppWatchKitExtension' do
88
platform :watchos, '7.0'
99

1010
pod 'FirebaseCore', :path => '../../'
11+
pod 'FirebaseCoreInternal', :path => '../../'
1112
pod 'FirebaseMessaging', :path => '../../'
1213
pod 'FirebaseCoreDiagnostics', :path => '../../'
1314
pod 'FirebaseInstallations', :path => '../../'
1415
pod 'FirebaseStorage', :path => '../../'
1516
pod 'FirebaseRemoteConfig', :path => '../../'
1617
pod 'FirebaseABTesting', :path => '../../'
1718
pod 'FirebaseDatabase', :path => '../../'
19+
pod 'FirebaseAppCheckInterop', :path => '../../'
20+
pod 'FirebaseAuthInterop', :path => '../../'
1821

1922
pod 'Firebase/Messaging', :path => '../../'
2023
pod 'Firebase/Storage', :path => '../../'

FirebaseStorageObjC.podspec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ Objective C Implementations for FirebaseStorage. This pod should not be directly
5252
unit_tests.platforms = {
5353
:ios => ios_deployment_target,
5454
:osx => osx_deployment_target,
55-
:tvos => tvos_deployment_target
55+
:tvos => tvos_deployment_target,
56+
:watchos => watchos_deployment_target,
5657
}
5758
unit_tests.source_files = [
5859
'FirebaseStorage/Tests/Unit/*.[mh]',

FirebaseStorageSwift/Tests/ObjCIntegration/ObjCAPITests.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2022 LLC Google
1+
// Copyright 2022 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.

scripts/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,7 @@ case "$product-$platform-$method" in
537537
if check_secrets; then
538538
# Integration tests are only run on iOS to minimize flake failures.
539539
RunXcodebuild \
540-
-workspace 'gen/FirebaseStorageObjc/FirebaseStorageObjC.xcworkspace' \
540+
-workspace 'gen/FirebaseStorageObjc/FirebaseStorage.xcworkspace' \
541541
-scheme "FirebaseStorage-Unit-objcintegration" \
542542
"${ios_flags[@]}" \
543543
"${xcb_flags[@]}" \

0 commit comments

Comments
 (0)