Skip to content

Replace HARD_ASSERT with SIMPLE_HARD_ASSERT to fix absl linker breakage. #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2021
Merged

Replace HARD_ASSERT with SIMPLE_HARD_ASSERT to fix absl linker breakage. #616

merged 1 commit into from
Aug 24, 2021

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Aug 24, 2021 •
edited
Loading

Fix the following build error in the downstream Unity SDK builds for iOS:

Undefined symbols for architecture arm64: "firebase::firestore::util::internal::StringFormatPieces(char const*, std::initializer_list<absl::string_view>)", referenced from: std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > firebase::firestore::util::StringFormat<char const*>(char const*, char const* const&) in libFirebaseCppFirestore.a(firestore_main.o) firebase::firestore::TransactionInternal::ValidateReference(firebase::firestore::DocumentReference const&) in libFirebaseCppFirestore.a(transaction_main.o) void firebase::firestore::util::ThrowInvalidArgument<>(char const*) in libFirebaseCppFirestore.a(transaction_main.o) ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 (use -v to see invocation)
@dconeybe dconeybe added api: firestore skip-release-notes Skip release notes check labels Aug 24, 2021
@dconeybe dconeybe self-assigned this Aug 24, 2021
@google-cla google-cla bot added the cla: yes label Aug 24, 2021
@dconeybe dconeybe assigned var-const and unassigned dconeybe Aug 24, 2021
@dconeybe dconeybe requested a review from var-const August 24, 2021 18:28
@var-const var-const assigned dconeybe and unassigned var-const Aug 24, 2021
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Aug 24, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 24, 2021
@github-actions
Copy link

github-actions bot commented Aug 24, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @dconeybe on commit 48103b1
Last updated: Tue Aug 24 14:14 PDT 2021
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FAILURE] [Android] [windows] [android_target]
(1 failed tests)  ServerTimestampTest.TestServerTimestampsUsesPreviousValueFromLocalMutation

Add flaky tests to go/fpl-cpp-flake-tracker
@dconeybe dconeybe enabled auto-merge (squash) August 24, 2021 19:21
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Aug 24, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 24, 2021
@dconeybe dconeybe merged commit 48103b1 into main Aug 24, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 24, 2021
@dconeybe dconeybe deleted the dconeybe/FixTransactionHardAssertAbslLinkerError branch August 24, 2021 20:09
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Aug 24, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 24, 2021
@dconeybe dconeybe mentioned this pull request Aug 25, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore cla: yes skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

2 participants

@dconeybe @var-const